Alexander M. Turek
827cb0c10b
Address DBAL 3.4 deprecations ( #9969 )
2022-08-07 18:11:43 +02:00
Vincent Langlet
4d19c0ea71
Improve phpdoc for ClassMetadataInfo ( #9965 )
2022-08-07 16:00:01 +00:00
Alexander M. Turek
17cfb944f2
Merge branch '2.12.x' into 2.13.x
...
* 2.12.x:
Fix build (#9964 )
fix: class normalisation test (#9966 )
2022-08-07 17:39:22 +02:00
Alexander M. Turek
78d08584f1
Fix build ( #9964 )
2022-08-07 17:31:32 +02:00
Adrien Foulon
f7e202f3ed
fix: class normalisation test ( #9966 )
2022-08-07 17:07:36 +02:00
Romain Canon
33f4db8405
Support native enum hydration when using NEW operator ( #9936 )
...
Using the `NEW` operator with the query builder now properly converts
scalar values to native enums inside data transfer objects.
2022-08-04 00:33:46 +02:00
Alexander M. Turek
fa63a395cc
Merge branch '2.12.x' into 2.13.x
...
* 2.12.x:
Update branch info in README and .doctrine-project.json (#9943 )
2022-08-02 22:35:33 +02:00
Alexander M. Turek
2ec2c585b0
Deprecate QueryBuilder APIs exposing its internal state ( #9945 )
...
Co-authored-by: Sergei Morozov <morozov@tut.by >
2022-08-01 11:42:24 +02:00
Alexander M. Turek
c8025dc4f8
Update branch info in README and .doctrine-project.json ( #9943 )
2022-07-31 14:53:31 +02:00
Alexander M. Turek
cd95b2a9e5
Merge branch '2.12.x' into 2.13.x
...
* 2.12.x:
Psalm 4.25.0, PHPStan 1.8.2 (#9941 )
Use a more precise phpdoc for ClassMetadataInfo::versionField than mixed (#9937 )
2022-07-28 19:38:58 +02:00
Alexander M. Turek
8bfe20073b
Psalm 4.25.0, PHPStan 1.8.2 ( #9941 )
2022-07-28 19:35:26 +02:00
Grégoire Paris
38a9a1c795
Stop passing event manager to constructor ( #9938 )
...
Co-authored-by: Alexander M. Turek <me@derrabus.de >
2022-07-28 16:47:04 +00:00
Grégoire Paris
2ebe18a822
Merge pull request #9915 from nicolas-grekas/pub-em
2022-07-28 14:55:34 +02:00
Vincent Langlet
9b37541b3b
Use a more precise phpdoc for ClassMetadataInfo::versionField than mixed ( #9937 )
2022-07-27 23:23:43 +02:00
Nicolas Grekas
518d7f2ef1
Make EntityManager @final and its constructor public
2022-07-27 17:15:40 +02:00
Alexander M. Turek
7684cea8ef
Add helper function TreeWalkerAdapter::getMetadataForDqlAlias() ( #9932 )
2022-07-25 20:54:31 +02:00
Alexander M. Turek
5085dbe94b
Merge 2.12.x into 2.13.x ( #9931 )
2022-07-25 18:49:29 +02:00
Alexander M. Turek
6c64bc6067
Simplify LanguageRecognitionTest ( #9930 )
2022-07-25 16:14:07 +02:00
Grégoire Paris
f5246bdedd
Merge pull request #9927 from rdey/patch-1
...
GH9335: Fix for bug with objects as foreign keys
2022-07-24 15:21:28 +02:00
Louise Zetterlund
705dc6fbda
test/added test for foreign keys with custom id object types
2022-07-22 18:41:35 +02:00
Alexander M. Turek
faedb90ffa
Widen types for DiscriminatorMap ( #9922 )
...
* Allow integers as keys for DiscriminatorMap
* Widen types for DiscriminatorMap
2022-07-21 10:19:42 +02:00
Grégoire Paris
2da28703e3
Merge pull request #9903 from glaszig/fix/dump-sql
...
schema tool: remove useless text from --dump-sql output
2022-07-19 23:13:51 +02:00
glaszig
20cec8ed79
schema tool: remove useless text from --dump-sql output
...
the description and semantics of the `--dump-sql` switch
indicate and sql dump. without that useless line
The following SQL statements will be executed:
the output can actually be used to generate a plain
dump.sql file that can be fed into sql command-
consuming programs.
resolves #8263 and #7186 .
2022-07-19 19:33:48 +00:00
Grégoire Paris
c125a856d0
Merge pull request #9914 from greg0ire/fix-build
...
Avoid supportsCreateDropDatabase()
2022-07-18 23:00:38 +02:00
Grégoire Paris
d7db596cb4
Avoid supportsCreateDropDatabase()
...
It has been deprecated.
2022-07-18 22:42:13 +02:00
Grégoire Paris
3a9aa5b8c6
Merge pull request #9910 from doctrine/2.12.x
...
Merge 2.12.x up into 2.13.x
2022-07-18 21:31:50 +02:00
Grégoire Paris
99d9c46bde
Add tests for SQL output feature ( #9907 )
...
It is not covered yet, and that makes contributions to these commands
hard.
2022-07-18 21:28:17 +02:00
Grégoire Paris
61d405162f
Merge pull request #9906 from franmomu/deprecate_lifecycleevent
...
Deprecate `LifecycleEventArgs`
2022-07-17 17:35:37 +02:00
Fran Moreno
b0f15e070d
Deprecate LifecycleEventArgs
...
Use LifecycleEventArgs from doctrine/persistence instead.
2022-07-17 12:06:10 +02:00
Grégoire Paris
fbb7e24594
Merge pull request #9895 from greg0ire/avoid-sql-assertions
...
Avoid SQL assertions
2022-07-14 19:09:32 +02:00
Grégoire Paris
888a4a8eff
Avoid SQL assertions
...
doctrine/dbal is the component responsible for generating the queries.
Let us make the test suite more robust by asserting that things work
from a functional point of view.
2022-07-12 08:01:19 +02:00
Grégoire Paris
48b4f63f61
Merge pull request #9893 from greg0ire/2.13.x
...
Merge 2.12.x up into 2.13.x
2022-07-10 23:18:39 +02:00
Grégoire Paris
4a62b661a5
Merge remote-tracking branch 'origin/2.12.x' into 2.13.x
2022-07-10 23:07:44 +02:00
Grégoire Paris
ab4844b82a
Merge pull request #9892 from greg0ire/address-array-object-type-deprecation
...
Address array object type deprecation
2022-07-10 23:05:34 +02:00
Grégoire Paris
00989d6671
Remove SerializationModel from generic model set
...
It contains fields with deprecated types.
2022-07-10 12:23:05 +02:00
Grégoire Paris
7ed0db0621
Document what we test in test method name
2022-07-10 11:23:22 +02:00
Grégoire Paris
d6dcfbd6f7
Use ::class notation
2022-07-10 11:23:21 +02:00
Grégoire Paris
baf6a394a1
Test invalid mapping file with boolean model
...
SerializationModel has a field with type array, and another with type
object. Both types are deprecated.
2022-07-10 11:22:46 +02:00
Alexander M. Turek
1538d70bb9
Merge branch '2.12.x' into 2.13.x
...
* 2.12.x:
PHPStan 1.8.0 (#9887 )
Fix typo in AbstractQuery
ObjectHydrator: defer initialization of potentially empty collections
Migrate more usages of SchemaTool::createSchema()
preUpdate: Add restriction that changed field needs to be in computed changeset (#9871 )
2022-07-08 13:54:43 +02:00
Alexander M. Turek
291765e879
PHPStan 1.8.0 ( #9887 )
2022-07-08 13:53:03 +02:00
Grégoire Paris
f79ec43e70
Merge pull request #9880 from CarlSchwan/patch-1
...
Fix typo in AbstractQuery
2022-07-06 21:07:32 +02:00
Carl Schwan
306b5f9812
Fix typo in AbstractQuery
2022-07-06 14:06:42 +02:00
Grégoire Paris
68405f3e5b
Merge pull request #9876 from franmomu/extend_event_manager_args
...
Change parent classes in some events
2022-07-04 19:21:56 +02:00
Grégoire Paris
83c1ad2f57
Merge pull request #9870 from popov-a-e/GH-9807
...
[GH-9807] Fix: initialize potentially empty collections at the hydration complete
2022-07-03 22:25:18 +02:00
Alex Popov
79447cbb18
ObjectHydrator: defer initialization of potentially empty collections
...
If ObjectHydrator faces an empty row to an uninitialized collection,
it initializes it, to prevent it from querying again (DDC-1526).
However, if that row is the first but not the only in the collection,
the next rows will be ignored, as the collection will be considered
"existing", and "existing" collections are only replaced if REFRESH hint
is present. To prevent it, we defer initialization to the end of the
hydration.
Fixes GH-9807
2022-07-03 13:25:34 +04:00
Fran Moreno
eea53397c5
Change parent classes
...
*FlushEventArgs classes should extend ManagerEventArgs from
doctrine/persistence to be able to use ManagerEventArgs for any
persistance implementation.
OnClearEventArgs should extend from OnClearEventArgs from
doctrine/persistence.
2022-07-02 14:27:36 +02:00
Grégoire Paris
3295ccfa25
Merge pull request #9874 from greg0ire/migrate-to-csfm
...
Migrate more usages of SchemaTool::createSchema()
2022-07-02 00:11:41 +02:00
Grégoire Paris
b1419ddc6c
Migrate more usages of SchemaTool::createSchema()
...
When I introduced OrmFunctionalTestCase::createSchemaForModels(), I made
several wrong assumptions:
- the call is always wrapped in a try / catch;
- that try / catch is always typed with "Exception".
Because of that, I missed, many, many occurrences of
SchemaTool::createSchema().
I recently noticed that contributors kept using the
SchemaTool::createSchema() and figured not everything had been
migrated.
Migrating some of them did not result in something far better until I
also introduced similar methods for
SchemaTool::getUpdateSchemaSql() and SchemaTool::getSchemaFromMetadata().
2022-07-01 21:45:45 +02:00
Thomas Landauer
0ef08c5dfb
preUpdate: Add restriction that changed field needs to be in computed changeset ( #9871 )
2022-06-28 23:44:23 +02:00
Alexander M. Turek
dc8ddfd3e6
Merge branch '2.12.x' into 2.13.x
...
* 2.12.x:
Psalm 4.24.0, PHPStan 1.7.15 (#9865 )
PHP CodeSniffer 3.7.1, PHPStan 1.7.14 (#9858 )
2022-06-28 13:35:26 +02:00
Alexander M. Turek
278bf194ca
Psalm 4.24.0, PHPStan 1.7.15 ( #9865 )
2022-06-28 10:41:20 +02:00
Alexander M. Turek
b9f2488c6c
PHP CodeSniffer 3.7.1, PHPStan 1.7.14 ( #9858 )
2022-06-19 14:48:36 +02:00
Hans Mackowiak
b931a59ebc
Deprecate omitting the alias in QueryBuilder ( #9765 )
...
… methods update() and delete()
Co-authored-by: Alexander M. Turek <me@derrabus.de >
2022-06-17 10:33:11 +02:00
Alexander M. Turek
d15eef9051
Merge release 2.12.3 into 2.13.x ( #9853 )
2022-06-17 10:22:16 +02:00
Alexander M. Turek
c05e1709e9
Run tests on PHP 8.2 ( #9840 )
2022-06-16 15:42:23 +02:00
Alexander M. Turek
6e31758c7b
PHPStan 1.7.13 ( #9844 )
2022-06-15 11:11:24 +02:00
Alexander M. Turek
eff540a996
Flip conditional extension of legacy AnnotationDriver class ( #9843 )
2022-06-13 20:10:37 +02:00
Alexander M. Turek
33d74e2e48
PHP CodeSniffer 3.7 ( #9842 )
2022-06-13 19:19:15 +02:00
bartholdbos
09ff36cda0
Make Reflection available to ConvertMappingCommand ( #9619 )
2022-06-13 17:30:08 +02:00
Grégoire Paris
e30426cbc0
Merge pull request #9841 from derrabus/bugfix/dynamic-property
...
Add missing property declaration
2022-06-12 16:55:59 +02:00
Alexander M. Turek
e9135b86e0
Add missing property declaration
2022-06-12 14:25:39 +02:00
Grégoire Paris
5ccb59fa02
Merge pull request #9839 from morozov/list-tables
...
Use proper API for introspection of tables
2022-06-11 22:41:41 +02:00
Sergei Morozov
2e927970ca
Use proper API for introspection of tables
2022-06-11 12:13:25 -07:00
Grégoire Paris
0366a5796f
Merge pull request #9837 from greg0ire/address-getdbplatform-deprecation
...
Address deprecation of getDatabasePlatform()
2022-06-10 20:14:06 +02:00
Grégoire Paris
93f7e78a14
Address deprecation of getDatabasePlatform()
2022-06-10 19:57:50 +02:00
Grégoire Paris
d99e64c05e
Merge pull request #9833 from greg0ire/deprecate-sequence-based-ig
2022-06-10 10:09:33 +02:00
Grégoire Paris
9efeefb913
Merge pull request #9826 from greg0ire/improve-phpdoc-configuration
...
Improve phpdoc for Configuration
2022-06-09 23:53:12 +02:00
Grégoire Paris
3f8430459c
Deprecate reliance on sequence-emulated identity columns
...
Sequence-based identity values have been deprecated.
2022-06-09 23:46:50 +02:00
Grégoire Paris
5f12b8f7de
Remove uneeded rule form baseline
2022-06-09 08:13:54 +02:00
Grégoire Paris
f949b9d212
Improve phpdoc for Configuration
2022-06-09 08:09:41 +02:00
Grégoire Paris
2bc0be6fa9
Merge remote-tracking branch 'origin/2.12.x' into 2.13.x
2022-06-09 07:47:32 +02:00
Grégoire Paris
3dc5581294
Merge pull request #9818 from greg0ire/fix-wrong-type-config
...
Document missing possible types
2022-06-09 07:23:43 +02:00
Grégoire Paris
7bf2c4c8d1
Merge pull request #9823 from greg0ire/fix-build
2022-06-08 14:39:31 +02:00
Grégoire Paris
c81776ad12
Backport fixes from upstream branch
...
Not all of 01fb82b497 was ported, only
what is necessary to fix the build.
2022-06-08 13:26:35 +02:00
Grégoire Paris
d9c6f86627
Document missing possible types
2022-06-04 18:16:35 +02:00
Alexander M. Turek
ddede4064c
Merge 2.12.x into 2.13.x ( #9811 )
2022-06-03 13:22:41 +02:00
Alexander M. Turek
67d82cdf72
PHPStan 1.7.9 ( #9812 )
2022-06-03 13:11:19 +02:00
Alexander M. Turek
744f0b5983
Remove empty test file ( #9805 )
2022-06-03 07:53:13 +02:00
Grégoire Paris
1d02289481
Merge pull request #9809 from greg0ire/disallow-null-setFirstResult
...
Deprecate passing null to Query::setFirstResult()
2022-06-03 07:51:04 +02:00
Alexander M. Turek
4bd0f974ab
Remove calls to deprecated MockBuilder::setMethods() ( #9808 )
2022-06-02 23:48:47 +02:00
Grégoire Paris
d0c582ca48
Deprecate passing null to Query::setFirstResult()
...
The argument is cast to an integer, so the user might as well pass 0
instead, and we can require an integer.
2022-06-02 22:29:01 +02:00
Alexander M. Turek
cc6cc26f18
Rename Abstract*Test to *TestCase ( #9806 )
2022-06-02 16:33:33 +02:00
wiseguy1394
768e2f3816
Add primary key on temp table ( #9770 )
...
* add primary key on temp table;fixes doctrine/orm#9768
* use all ID Columns in primary key
2022-06-02 16:08:22 +02:00
Grégoire Paris
deb5f49413
Merge pull request #9804 from greg0ire/2.13.x
...
Merge 2.12.x up into 2.13.x
2022-06-02 07:14:42 +02:00
Grégoire Paris
52ce39f595
Merge pull request #9801 from greg0ire/widen-types
...
Widen types
2022-06-02 07:13:58 +02:00
Grégoire Paris
f84ecb2842
Merge pull request #9794 from VincentLanglet/associationMapping
...
Add type for AssociationMapping
2022-06-01 23:37:00 +02:00
Grégoire Paris
b2fedaef9e
Merge remote-tracking branch 'origin/2.12.x' into 2.13.x
2022-06-01 22:49:10 +02:00
Grégoire Paris
21976471a3
Fix wrong types ( #9802 )
2022-06-01 22:42:51 +02:00
Grégoire Paris
6fb88e1496
Widen return type
...
This type is so complex that it is not going to bring much value to the
consumer of this method. Let us widen it to mixed.
2022-06-01 19:56:25 +02:00
Sergei Morozov
3ac5f119aa
Merge pull request #9799 from morozov/sqlite-fk
...
Prep work for enabling support for foreign keys on SQLite
2022-06-01 06:19:47 -07:00
Sergei Morozov
01fb82b497
Prep work for enabling support for foreign keys on SQLite
2022-05-30 18:45:43 -07:00
Alexander M. Turek
4f1072e1ac
Add missing import ( #9796 )
2022-05-31 00:42:03 +02:00
Alexander M. Turek
a559563682
Deprecate calling setters without arguments ( #9791 )
2022-05-30 20:39:06 +02:00
Vincent Langlet
0f9cc194ae
Update baseline
2022-05-29 20:27:26 +02:00
Vincent Langlet
2513a1e2b1
Fix
2022-05-29 20:16:12 +02:00
Vincent Langlet
4230214ced
Add type for AssociationMapping
2022-05-29 13:17:04 +02:00
Alexander M. Turek
fb1f258736
Move duplicate fixture into dedicated file ( #9789 )
2022-05-27 15:08:21 +02:00
olegsuvorkov
aae8b43622
Update IdentifierFlattener.php
...
Fix for coding-standards / Coding Standards (8.1)
2022-05-27 15:35:23 +03:00
Alexander M. Turek
e66fbc434d
MockTreeWalker should be an SqlWalker ( #9790 )
2022-05-27 00:15:30 +02:00
olegsuvorkov
3f4e9e397a
Update IdentifierFlattener.php
...
Hello, I would like to make a small change.
The need arose when using \Symfony\Bridge\Doctrine\IdGenerator\UuidGenerator in "symfony/doctrine-bridge" composite foreign keys
I'm sure these changes will not hurt performance
and allow other objects to be used as identifiers
2022-05-26 10:46:14 +03:00
Grégoire Paris
0f6f752887
Merge pull request #9777 from greg0ire/improve-phpdoc-abstract-query
...
Make phpdoc more precise for AbstractQuery
2022-05-24 20:42:40 +02:00
Grégoire Paris
c1dd1cfc2c
Make phpdoc more precise
2022-05-24 20:42:10 +02:00
Grégoire Paris
3684d236f6
Deprecate setting fetch mode to random integers
2022-05-24 20:42:08 +02:00
Alexander M. Turek
bba6c696f5
Prepare split of output walkers and tree walkers ( #9786 )
2022-05-24 18:34:40 +00:00
Alexander M. Turek
e02e6f481b
Merge branch '2.12.x' into 2.13.x
...
* 2.12.x:
PHPStan 1.7.0 (#9785 )
2022-05-24 00:43:35 +02:00
Alexander M. Turek
48e4e333c7
PHPStan 1.7.0 ( #9785 )
2022-05-24 00:41:57 +02:00
Grégoire Paris
507bc514ce
Merge pull request #9784 from greg0ire/deprecate-no-op
...
Deprecate passing null to Query::setDQL()
2022-05-23 22:31:50 +02:00
Grégoire Paris
1ae5de5409
Deprecate passing null to Query::setDQL()
...
It is a no-op.
2022-05-23 22:11:16 +02:00
Alexander M. Turek
82508956fe
Kill call_user_func(_array) ( #9780 )
2022-05-23 16:28:32 +02:00
Alexander M. Turek
a131878814
Merge branch '2.12.x' into 2.13.x
...
* 2.12.x:
Fix wrong types for AbstractQuery and child classes (#9774 )
Document callable as possible
Add use statement (#9769 )
2022-05-23 11:29:26 +02:00
Grégoire Paris
1f63389065
Fix wrong types for AbstractQuery and child classes ( #9774 )
...
* Remove comment about BC
I do not think we actually want to force our users to build an array
collection when they want to use setParameters().
* Make phpdoc more accurate
2022-05-23 11:26:19 +02:00
Grégoire Paris
359dd4ecfb
Merge pull request #9779 from greg0ire/fix-config-phpdoc
2022-05-23 11:18:58 +02:00
Grégoire Paris
a0697c9aff
Document callable as possible
...
Custom string functions can either be a class string or a callable
returning the function.
2022-05-23 11:05:16 +02:00
Grégoire Paris
5601c2ce4b
Merge pull request #9775 from greg0ire/no-override
...
Remove override phpdoc tag
2022-05-23 07:48:01 +02:00
Grégoire Paris
1141fe106f
Remove override phpdoc tag
...
Given how little occurrences there are, signalling method overrides with
this tag is probably not something we do everywhere. Besides, it does
not seem to be standard.
See https://docs.phpdoc.org/3.0/guide/references/phpdoc/tags/index.html#tag-reference
2022-05-22 16:28:41 +02:00
Grégoire Paris
8f7701279d
Add use statement ( #9769 )
...
We are supposed to use the driver from doctrine/persistence, and not the
deprecated one from this package.
2022-05-19 13:16:51 +02:00
Grégoire Paris
779f9c36fa
Merge pull request #9766 from greg0ire/non-nullable-arg-ns
...
Document future argument better
2022-05-18 08:00:17 +02:00
Grégoire Paris
0908f92629
Document future argument better
...
That argument is always provided, so the tests should provide it and the
commented out argument should reflect the future.
2022-05-17 12:09:31 +02:00
Grégoire Paris
24badd60fb
Merge pull request #9761 from greg0ire/fix-phpdoc-ns
...
Fix phpdoc and tests for NamingStrategy
2022-05-16 22:00:41 +02:00
Sergei Morozov
f2d794f8bc
Merge pull request #9762 from morozov/schema-manager-database-platform
...
Do not call AbstractSchemaManager::getDatabasePlatform()
2022-05-16 08:31:45 -07:00
Sergei Morozov
7311f77dfe
Do not call AbstractSchemaManager::getDatabasePlatform()
2022-05-15 19:25:51 -07:00
Grégoire Paris
16afa45abf
Make tests more realistic
...
These tests were using the fact that some arguments of some methods of
the naming strategy interface are optional or nullable for now to avoid
providing some. In practice, these arguments are always provided, and
that should also be the case in tests.
2022-05-14 17:31:45 +02:00
Grégoire Paris
8b4d25e94f
Handle self-refencing entities
...
When computing a foreign key column name, the referenced column name
may be null in the case of a self referencing entity with join columns
defined in the mapping.
2022-05-14 16:56:19 +02:00
Grégoire Paris
70087782e8
Merge pull request #9756 from greg0ire/more-precise-phpdoc-ns
...
Document types as they are passed
2022-05-12 09:05:51 +02:00
Grégoire Paris
dbc5a818e0
Document types as they are passed
...
Some arguments have been added afterwards which was a BC break for
implementing classes. I do not think they should have been introduced as
optional.
2022-05-11 21:36:44 +02:00
Alexander M. Turek
31a9c9c49b
Update Psalm baseline ( #9751 )
2022-05-10 16:00:54 +02:00
Alexander M. Turek
125afb8e39
Merge branch '2.12.x' into 2.13.x
...
* 2.12.x:
Omit version number in README (#9749 )
2022-05-10 15:08:24 +02:00
Grégoire Paris
45e196eb57
Omit version number in README ( #9749 )
2022-05-10 09:09:20 +02:00
Grégoire Paris
2c30fe6e5b
Merge pull request #9748 from doctrine/2.12.x
...
Merge 2.12.x up into 2.13.x
2022-05-10 08:21:34 +02:00
Grégoire Paris
6757bdf8c6
Deprecate omitting second argument to joinColumnName() ( #9747 )
...
* fix headings
* Deprecate omitting second argument to joinColumnName()
2022-05-10 00:37:44 +02:00
Grégoire Paris
eed20ff4dd
Better phpdoc tests ( #9746 )
...
* Fix inaccurate and imprecise phpdoc
* Remove extra argument
The method signature does not specify it, and it's always set to null.
It looks like this test and its data provider were copy/pasted from the
previous one.
* Specify what concrete class is passed
This is important as the signature of the concrete classes don't
necessarily match the one of the interface. Here, an extra argument that
is only defined in the classes is used.
2022-05-10 00:32:30 +02:00
Sergei Morozov
636712a928
Merge pull request #9737 from morozov/dbal-4-compatibility
...
Improve compatibility with DBAL 4 for MySQL, MariaDB and PostgreSQL
2022-05-07 07:42:14 -07:00
Sergei Morozov
0aa91c7140
Pass sequence name to AbstractPlatform::getDropSequenceSQL()
...
See https://github.com/doctrine/dbal/pull/4797
2022-05-06 19:15:06 -07:00
Sergei Morozov
c2f3831b85
Specify length for string columns
...
See https://github.com/doctrine/dbal/pull/3586
2022-05-06 19:15:06 -07:00
Sergei Morozov
2af52f6a18
Inherit parent column length regardless of the type
...
See https://github.com/doctrine/dbal/pull/3586
2022-05-06 19:15:05 -07:00
Sergei Morozov
0a79ddf344
Cast column length to int in XML annotation driver
...
See https://github.com/doctrine/dbal/pull/3511
2022-05-06 19:15:05 -07:00
Sergei Morozov
165c8bd6dd
Do not use AbstractSchemaManager::dropAndCreateTable()
...
See https://github.com/doctrine/dbal/pull/4933
2022-05-06 19:15:03 -07:00
Alexander M. Turek
07ee555279
Exclude /ci from distribution packages ( #9732 )
2022-05-06 13:07:36 +02:00
Sergei Morozov
e6bda4afda
Merge pull request #9730 from morozov/dbal-4-compatibility
...
Forward compatibility with DBAL 4
2022-05-05 14:06:25 -07:00
Sergei Morozov
51b4e02873
Obtain database platform from the connection, not from the driver
...
See https://github.com/doctrine/dbal/pull/4764
2022-05-05 11:30:36 -07:00
Sergei Morozov
1915dcd1e8
Use zero as the default query offset
...
See https://github.com/doctrine/dbal/pull/3574
2022-05-05 11:30:35 -07:00
Sergei Morozov
480d99b107
Use getStringTypeDeclarationSQL() instead of getVarcharTypeDeclarationSQL()
...
See https://github.com/doctrine/dbal/pull/3586
2022-05-05 11:30:35 -07:00
Sergei Morozov
c6661caaed
Do not extend a type with a different PHP return type
...
See https://github.com/doctrine/dbal/pull/5043
2022-05-05 11:30:34 -07:00
Sergei Morozov
9e27370f15
Drop and create test database manually
...
See https://github.com/doctrine/dbal/pull/4933
2022-05-05 11:30:32 -07:00
Sergei Morozov
1a3fbcb145
Lookup type name in the registry
...
See https://github.com/doctrine/dbal/pull/5208
2022-05-05 09:32:38 -07:00
Sergei Morozov
c950e72628
Do not use null column definition
2022-05-05 09:32:37 -07:00
Alexander M. Turek
05560f260c
Merge release 2.12.2 into 2.13.x ( #9725 )
2022-05-03 02:15:35 +02:00
Alexander M. Turek
8291a7f09b
Allow doctrine/deprecations 1.0 ( #9723 )
2022-05-02 21:10:07 +02:00
Ruud Kamphuis
d7d6b9d2c7
Allow setting column options like charset and collation everywhere ( #9655 )
...
This makes it possible to set custom options on the following:
* `JoinTable`
* `JoinColumn`
* `InverseJoinColumn`
2022-05-02 19:01:24 +02:00
Grégoire Paris
26e274e373
Merge pull request #9708 from michnovka/2.12.x-fix-psalm-repository
2022-05-02 15:26:47 +02:00
Alexander M. Turek
a02642e3e6
Merge branch '2.12.x' into 2.13.x
...
* 2.12.x:
Psalm 4.23, PHPStan 1.6.3 (#9718 )
2022-05-02 11:09:12 +02:00
Alexander M. Turek
5209184a60
Psalm 4.23, PHPStan 1.6.3 ( #9718 )
2022-05-02 11:07:33 +02:00
Grégoire Paris
b4da0ece41
Merge pull request #9704 from greg0ire/reference-cmi-less-and-less
...
Reference ClassMetadataInfo less and less
2022-05-01 22:06:19 +02:00
Sergei Morozov
3980d58b80
Merge pull request #9710 from morozov/2.13.x
...
Merge 2.12.x into 2.13.x
2022-05-01 12:46:13 -07:00
Sergei Morozov
10cbb24649
Merge branch '2.12.x' into 2.13.x
2022-05-01 12:24:28 -07:00
Sergei Morozov
23f54885bc
Merge pull request #9706 from morozov/cleanup-test-entity-manager
...
Remove unused OrmTestCase::getTestEntityManager() parameters
2022-05-01 11:43:07 -07:00
Sergei Morozov
7f29b576d8
Remove some ConnectionMock methods ( #9707 )
2022-05-01 17:52:10 +02:00
Tomas
a8425a5248
Fix psalm annotation
2022-05-01 16:40:44 +02:00
Pierre B
86ce0e5e35
Update ClassMetadataInfo::table definition ( #9703 )
...
Everything except the name key might be undefined when accessing to this public property, for instance in a LoadMetadataEvent
Co-authored-by: Pierre Bourdet <pbourdet@worldia.com >
2022-05-01 09:40:00 +02:00
Sergei Morozov
39fd5f4d46
Remove unused OrmTestCase::getTestEntityManager() parameters
2022-04-30 12:35:05 -07:00
Grégoire Paris
476a02075f
Deprecate classes and methods removed in 3.0
2022-04-30 19:47:20 +02:00
Grégoire Paris
98e10906f8
Change class metadata type declarations
...
There is a guarantee in the call sites that we are only passing
ClassMetadata instances.
2022-04-30 19:47:20 +02:00
Grégoire Paris
7241b4d2e0
Reference constants from ClassMetadata
2022-04-30 19:47:20 +02:00
Grégoire Paris
b8db858784
Deprecate not passing ClassMetadata instances
2022-04-30 19:47:20 +02:00
Thomas Landauer
a9309d748b
Add missing use statement ( #9699 )
2022-04-30 08:04:44 +02:00
Grégoire Paris
fe09af6df1
Merge pull request #9701 from doctrine/2.11.x
...
2.11.x
2022-04-29 22:45:58 +02:00
Grégoire Paris
ed50e3d967
Merge pull request #9698 from ThomasLandauer/patch-8
2022-04-29 16:33:49 +02:00
Thomas Landauer
1d59e46245
use valid link syntax
2022-04-29 16:25:10 +02:00
Grégoire Paris
d8f3198ef8
Merge pull request #9693 from doctrine/2.12.x
...
Merge 2.12.x up into 2.13.x
2022-04-29 08:13:20 +02:00
Grégoire Paris
a0a0b0e476
Merge pull request #9692 from greg0ire/reference-cmi-even-less
...
Use ClassMetadata over ClassMetadataInfo in tests
2022-04-28 23:07:56 +02:00
Grégoire Paris
0078a67786
Use ClassMetadata over ClassMetadataInfo in tests
...
ClassMetadataInfo is deprecated in favor of ClassMetadata.
2022-04-28 21:40:23 +02:00
Grégoire Paris
38d1124be9
Merge pull request #9691 from greg0ire/reference-cmi-less
...
Reference ClassMetadaInfo less
2022-04-28 07:58:51 +02:00
Grégoire Paris
e9d3c218ef
Remove explanation about inexistent distinction
...
ClassMetadataInfo used to be useful during entity generation, because it
allowed the entity not to exist. We no longer do entity generation, and
even if we did, the reflection methods have been moved to
ClassMetadataInfo as of 76e4f5a80b .
2022-04-27 23:28:58 +02:00
Grégoire Paris
6d2ca8fe40
Address mapping driver extraction
...
This documentation must be very old because this is no longer valid as
of e9e36dcf32 . The interface and abstract
file driver have since then been moved to doctrine/common, and the to
doctrine/persistence.
2022-04-27 23:28:43 +02:00
Grégoire Paris
a06011daf3
Refer to ClassMetadata instead of ClassMetadataInfo
...
Although properties and methods are currently located in
ClassMetadataInfo, it is better to refer to ClassMetadata as the former
is deprecated in favor of the latter.
2022-04-27 23:28:40 +02:00
Alexander M. Turek
825e9641fd
Merge branch '2.12.x' into 2.13.x
...
* 2.12.x:
PHPStan 1.6.1 (#9688 )
Drop SymfonyStyle[listing] for sqls (#9679 )
2022-04-27 09:53:50 +02:00
Alexander M. Turek
0846b8b102
PHPStan 1.6.1 ( #9688 )
2022-04-26 23:52:07 +02:00
Simon Podlipsky
1dd2b44982
Drop SymfonyStyle[listing] for sqls ( #9679 )
...
This was super annoying as UpdateCommand printed sqls prefixed with `*` so it was not possible to copy statements anymore without manually removing those asterisks.
This removes prefixing sqls and makes it consistent with Create and Drop commands.
2022-04-26 15:33:18 +02:00
Alexander M. Turek
5fbe5ebef4
Merge 2.12.x into 2.13.x ( #9684 )
2022-04-26 11:32:14 +02:00
Alexander M. Turek
d9508e97df
Remove dynamic property declarations ( #9683 )
2022-04-26 11:10:50 +02:00
Alexander M. Turek
534ed9c3c2
PHPStan 1.6.0 ( #9682 )
2022-04-26 11:01:11 +02:00
Grégoire Paris
f4585b954f
Merge pull request #6728 from greg0ire/validate_xml_against_xsd
...
Validate XML mapping against XSD file
2022-04-25 23:04:26 +02:00
Grégoire Paris
ab3a255440
Validate XML mapping against XSD file
...
Co-Authored-By: Axel Venet <avenet@wamiz.com >
Co-authored-by: Luís Cobucci <lcobucci@gmail.com >
2022-04-25 22:55:00 +02:00
Grégoire Paris
a552df66a9
Merge pull request #9677 from greg0ire/assert-drivers-are-orm-specific
...
Document ORM drivers only really load ORM metadata
2022-04-24 20:55:13 +02:00
Grégoire Paris
85238d4d98
Document ORM drivers only really load ORM metadata
2022-04-24 20:05:37 +02:00
Fran Moreno
b7e9dd023c
Fix HydrationException::invalidDiscriminatorValue parameter type ( #9676 )
2022-04-24 19:32:57 +02:00
Fran Moreno
1ac05f5e4e
Fix type on ClassMetadata discriminatorMap ( #9675 )
2022-04-24 17:52:28 +02:00
Alexander M. Turek
2e4a872272
Conditionally extend the old AnnotationDriver class ( #9671 )
2022-04-22 19:46:03 +02:00
Alexander M. Turek
d550364431
Deprecate the doctrine binary ( #9661 )
2022-04-19 20:34:28 +02:00
Alexander M. Turek
5b2bf9d74c
Merge branch '2.11.x' into 2.12.x
...
* 2.11.x:
ScalarColumnHydrator: prevent early-bail on falsy values (#9663 )
2022-04-19 11:27:11 +02:00
Mitch
4af1aa3177
ScalarColumnHydrator: prevent early-bail on falsy values ( #9663 )
...
* add failing test for issue #9230
* ScalarColumnHydrator: prevent early-bail on falsy values, fix #9230
Co-authored-by: Mickael GOETZ <contact@mickael-goetz.com >
2022-04-19 09:01:33 +00:00
michnovka
2fe40679f4
Fix enum hydration when fetching partial results ( #9657 )
2022-04-16 20:49:28 +02:00
Alexander M. Turek
7029965d3a
Indicate support for doctrine/persistence 3 ( #9656 )
2022-04-15 13:00:03 +02:00
michnovka
7e49c70320
Fix tests for enum ID hydration ( #9658 )
2022-04-13 12:58:20 +02:00
Grégoire Paris
f7fe5ad1bb
Merge pull request #9654 from greg0ire/revert-9636
...
Revert "Use charset/collation from column or table default when creatng relations (#9636 )"
2022-04-12 07:19:51 +02:00
Grégoire Paris
035c52ce3c
Revert "Use charset/collation from column or table default when creating relations ( #9636 )"
...
This reverts commit 03f4468be2 .
The inferring process seems fragile and MySQL-specific. The ORM might
not be the correct place to fix this issue (if it needs to be fixed at
all).
2022-04-11 20:26:17 +02:00
michnovka
7e7e38b60e
Fix test file/class names ( #9649 )
2022-04-11 12:15:45 +02:00
Alexander M. Turek
36ab133e62
Leverage generic persistence event classes ( #9633 )
2022-04-11 11:58:42 +02:00
Alexander M. Turek
e13422ab5e
Merge 2.11.x into 2.12.x ( #9650 )
...
* Fix composer install in contributing readme
People that contribute know how to use composer.
* Fix static analysis for Persistence 2.5 (#9648 )
Co-authored-by: Ruud Kamphuis <ruudk@users.noreply.github.com >
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr >
2022-04-10 23:45:04 +02:00
Alexander M. Turek
f4d5283f70
Fix static analysis for Persistence 2.5 ( #9648 )
2022-04-10 23:31:12 +02:00
Grégoire Paris
fda79b8e21
Improve exception message ( #9646 )
...
In setups where you have many parameters, or do not even realise you are
using an entity, that additional piece of context can be helpful. The
parameter name is not always available where the old exception was
called though.
2022-04-10 23:08:52 +02:00
Alexander M. Turek
5a345b01dc
Deprecate console helper ( #9641 )
2022-04-10 20:59:10 +02:00
Ruud Kamphuis
03f4468be2
Use charset/collation from column or table default when creating relations ( #9636 )
...
Fixes #6823
2022-04-10 14:34:21 +02:00
michnovka
a3d82f8e2f
Support Enum IDs and search by Enum fields ( #9629 )
2022-04-09 23:40:41 +02:00
Grégoire Paris
976fe5bc0d
Merge pull request #9639 from ruudk/patch-1
...
Fix composer install in contributing readme
2022-04-09 16:41:21 +02:00
Ruud Kamphuis
582b222b00
Fix composer install in contributing readme
...
People that contribute know how to use composer.
2022-04-09 15:29:45 +02:00
Alexander M. Turek
d9e8e839fe
Deprecate custom ObjectRepository implementations ( #9533 )
2022-04-06 13:51:12 +02:00
Alexander M. Turek
e8472c8f1a
Fix types on walkLiteral() and walkLikeExpression() ( #9566 )
2022-04-06 10:48:54 +02:00
Alexander M. Turek
deaab5133e
Merge branch '2.11.x' into 2.12.x
...
* 2.11.x:
explicitly use the non-deprecated ORMException
2022-04-05 13:02:01 +02:00
Sander
cffe31fc9d
Add support for array of enums ( #9497 )
...
* Add support for array of enums
This allows the use of 'array' and 'simple_array' in combination
with the enumType parameter.
* Reference is_array and array_map through a use statement nstead of global fallback
* Return the value of an array of enums correctly
* Add enum array mapping test
* Fix order of use parameters
* Fix return type docblock
* Apply phpcs feedback
* Fix static closure
* Add missing return type to static closure
* Add helper method for enum initialization to reduce code duplication
* Fix CS
* Replace mixed typehints with more specific ones
* Update docblock type hint to allow for array of string/int
* Fix types
* Fix types
Co-authored-by: Alexander M. Turek <me@derrabus.de >
2022-04-05 01:29:40 +02:00
Alexander M. Turek
0e9c7533fb
Fix types on ResultSetMapping ( #9621 )
2022-04-04 21:58:25 +02:00
Grégoire Paris
1ffb9152f7
Merge pull request #9623 from BenoitDuffez/dont-use-depecated-ormexception
...
explicitly use the non-deprecated ORMException
2022-04-02 11:52:48 +02:00
Benoit Duffez
51faa6ddb7
explicitly use the non-deprecated ORMException
2022-04-01 13:23:05 -07:00
Alexander M. Turek
18d6bc3757
Merge branch '2.11.x' into 2.12.x
...
* 2.11.x:
Remove "Description of" PHPDoc (#9611 )
2022-03-31 00:14:34 +02:00
Alexander M. Turek
7c4ae58517
Support enums as default values ( #9616 )
2022-03-28 22:36:45 +02:00
Alexander M. Turek
05f8fcf836
Skip tests requiring ObjectManagerAware ( #9612 )
2022-03-28 13:50:45 +00:00
Alexander M. Turek
692c3e1b45
Remove "Description of" PHPDoc ( #9611 )
2022-03-28 13:47:30 +02:00
Alexander M. Turek
acff29fddd
Update psalm.xml
2022-03-28 10:48:23 +02:00
Alexander M. Turek
58659f6c4f
Merge branch '2.11.x' into 2.12.x
...
* 2.11.x:
PHPStan 1.5.0 (#9607 )
Remove Sphinx config
Use correct syntax for external links
Update XmlExporter.php - Type problem in php8.x (#9589 )
Ignore deprecation from Persistence
Stands with Ukraine (#9567 )
Use internal links when self-referencing
Link to docs for the stable version
2022-03-28 10:46:50 +02:00
Alexander M. Turek
e410180c6e
PHPStan 1.5.0 ( #9607 )
2022-03-28 10:37:03 +02:00
Grégoire Paris
4476b05d59
Merge pull request #9608 from greg0ire/remove-python-config
...
Remove Sphinx config
2022-03-26 17:15:36 +01:00
Grégoire Paris
343b0ae576
Remove Sphinx config
...
I do not think this file is still useful, since AFAIK we are not using
Sphinx anymore. Besides, this is the only Doctrine project I could find
that still has that file. It was last updated 6 years ago.
2022-03-26 12:07:22 +01:00
Grégoire Paris
9952350c64
Merge pull request #9604 from greg0ire/improve-exception-message
...
Indicate what feature is deprecated
2022-03-24 08:46:03 +01:00
Grégoire Paris
3bc78caba9
Indicate what feature is deprecated
2022-03-23 18:39:33 +01:00
Grégoire Paris
0f1c9ec72a
Merge pull request #9603 from greg0ire/int-mask-of
2022-03-22 14:18:14 +01:00
Grégoire Paris
80f65d6f77
Implement int-mask-of where appropriate
...
With Psalm, you can specify that an integer should be a bitmask of
constants. Doing so allows to make some types more precise.
2022-03-22 14:02:31 +01:00
Grégoire Paris
de69f60c6a
Merge pull request #9598 from greg0ire/fix-event-table
...
Use correct syntax for external links
2022-03-20 19:32:10 +01:00
Grégoire Paris
2a653b05a0
Use correct syntax for external links
...
There is no leading underscore, and the trailing underscore should not
be forgotten.
2022-03-20 19:13:19 +01:00
Grégoire Paris
0f04a82857
Merge pull request #9595 from greg0ire/deprecate-more-ns-aliases
...
Deprecate more occurrences of namespace aliases
2022-03-20 14:34:16 +01:00
Grégoire Paris
17903346cf
Deprecate more occurrences of namespace aliases
2022-03-20 14:26:13 +01:00
Alexander M. Turek
98b468da57
Fix type on SqlWalker::walkPathExpression() ( #9565 )
2022-03-20 13:42:41 +01:00
Grégoire Paris
bccb4c7bd9
Merge pull request #9592 from greg0ire/fix-persistence-compat
...
Deprecate or throw on namespace alias usage
2022-03-20 12:26:28 +01:00
Grégoire Paris
dc53628faf
Deprecate or throw on namespace alias usage
...
This feature has been deprecated and removed in doctrine/persistence.
It was already deprecated in doctrine/orm for other APIs.
2022-03-20 11:44:42 +01:00
Grégoire Paris
21f339e6eb
Merge pull request #9528 from greg0ire/get-rid-of-persistent-object
...
Implement forward compatibility with Persistence 3
2022-03-19 13:18:06 +01:00
Jan Záruba
c6831c6b07
Update XmlExporter.php - Type problem in php8.x ( #9589 )
...
Please see PHP interface SimpleXMLElement::addAttribute(string $name, string $value = null, string $namespace = null): void ....
The $value must be string or null.
2022-03-19 13:03:28 +01:00
Grégoire Paris
33da4d84eb
Merge pull request #9590 from greg0ire/fix-build
...
Ignore deprecation from Persistence
2022-03-18 22:56:08 +01:00
Grégoire Paris
08de12e962
Merge pull request #9580 from klammbueddel/bug/duplicate-object-in-nested-collections
...
Add test to reproduce #9579
2022-03-18 22:54:19 +01:00
Grégoire Paris
7c83373f1e
Add specific CI jobs for Persistence 3
2022-03-18 22:25:47 +01:00
Grégoire Paris
021164fbe5
throw when attempting to use partial clearing
2022-03-18 22:21:59 +01:00
Grégoire Paris
b2d0c21fe0
Workaround the impossibility of unsetting metadata
2022-03-18 21:49:08 +01:00
Grégoire Paris
7391e2586a
Mock ClassMetadata::getName()
...
It is supposed to return a string.
2022-03-18 21:49:08 +01:00
Grégoire Paris
3532ce9a25
Remove useless calls
2022-03-18 21:49:08 +01:00
Grégoire Paris
2c769acf8c
Implement forward compatbility with Persistence 3
2022-03-18 21:49:08 +01:00
Grégoire Paris
c1b373b931
Ignore deprecation from Persistence
...
The deprecation is already addressed in the next minor branch.
2022-03-18 19:19:15 +01:00
Christian Bartels
61cb557b18
Check if association already contains object ( #9579 )
2022-03-18 11:00:33 +01:00
Maxime Veber
b6cff1aa1c
Stands with Ukraine ( #9567 )
2022-03-18 10:32:03 +01:00
Grégoire Paris
4471ad9f6b
Merge pull request #9587 from greg0ire/implement-colocated-driver
2022-03-16 10:54:06 +01:00
Grégoire Paris
cd57768b08
Implement colocated mapping driver
...
This allows us to decouple further from doctrine/annotations, and to fix
some static analysis issues.
The assumption being made here is that the abstract class we are no
longer extending is not used in type declarations and instanceof checks.
2022-03-15 12:42:27 +01:00
Grégoire Paris
d2206152bb
Merge pull request #9585 from greg0ire/hunt-down-latest
2022-03-13 17:11:29 +01:00
Grégoire Paris
a34dc0a0e3
Use internal links when self-referencing
...
This should result in links with the current version of the docs.
2022-03-13 14:36:37 +01:00
Grégoire Paris
881a7b3b69
Link to docs for the stable version
...
When we do not know what version people intend to browse, it seems more
sensible to assume they want to see the docs for the stable version.
2022-03-13 14:35:15 +01:00
Alexander M. Turek
b64824addb
Leverage MemcachedAdapter::isSupported() ( #9578 )
2022-03-10 23:37:36 +01:00
Alexander M. Turek
c7104c9471
Merge branch '2.11.x' into 2.12.x
...
* 2.11.x:
Baseline Psalm errors caused by DBAL 3.3.3 (#9577 )
Make sure MemcachedAdapter is supported before tring to use it (#9574 )
Fixing `:doc:` link (#9569 )
Adding PHP attributes (#9555 )
Remove reference to removed class
2022-03-09 17:20:17 +01:00
Alexander M. Turek
82bbb1dc4a
Baseline Psalm errors caused by DBAL 3.3.3 ( #9577 )
2022-03-09 17:18:11 +01:00
flack
9c351e0444
Make sure MemcachedAdapter is supported before tring to use it ( #9574 )
2022-03-09 16:23:58 +01:00
Thomas Landauer
5ed5383338
Fixing :doc: link ( #9569 )
2022-03-08 22:31:56 +01:00
Thomas Landauer
eb1d54871b
Adding PHP attributes ( #9555 )
...
Co-authored-by: Alexander M. Turek <me@derrabus.de >
Co-authored-by: Claudio Zizza <859964+SenseException@users.noreply.github.com >
2022-03-08 01:40:01 +01:00
Grégoire Paris
e148c838b0
Merge pull request #9563 from greg0ire/address-sqllogger-deprecation
...
Remove reference to removed class
2022-03-03 22:27:51 +01:00
Grégoire Paris
c73df2a7b4
Remove reference to removed class
...
EchoSQLLogger is deprecated in DBAL 2, and removed in DBAL 3.
2022-03-03 22:12:04 +01:00
Alexander M. Turek
bc6c6c9f0c
Merge branch '2.11.x' into 2.12.x
...
* 2.11.x:
Parser: SimpleArithmeticExpression should return ArithmeticTerm (#9557 )
2022-03-03 19:55:19 +01:00
Loïc Vernet
89d0a6a67c
validate schema command: allow to debug missing schema updates list ( #9019 )
2022-03-03 18:35:32 +00:00
Jan Barášek
38682e93db
Parser: SimpleArithmeticExpression should return ArithmeticTerm ( #9557 )
2022-03-03 00:25:27 +01:00
Alexander M. Turek
1febeaca7f
Document tree walker class strings ( #9553 )
2022-03-01 20:14:46 +01:00
Alexander M. Turek
229dcb082b
Use literal types for JOIN_TYPE_* constants ( #9552 )
2022-03-01 15:10:51 +01:00
Grégoire Paris
3849aed6fb
Merge pull request #9549 from derrabus/improvement/leverage-token-type
...
Leverage Lexer's Token type
2022-02-28 20:56:19 +01:00
Alexander M. Turek
f82db6a894
Leverage Lexer's Token type
2022-02-28 20:27:19 +01:00
Alexander M. Turek
a8a859cf5e
Merge branch '2.11.x' into 2.12.x
...
* 2.11.x:
Update baselines for Lexer 1.2.3 (#9546 )
2022-02-28 14:11:53 +01:00
Alexander M. Turek
84df37de97
Update baselines for Lexer 1.2.3 ( #9546 )
2022-02-28 14:06:31 +01:00
Alexander M. Turek
7be96f64ab
Document QueryComponent array shape ( #9527 )
2022-02-25 00:21:29 +01:00
Grégoire Paris
947935e4c9
Merge pull request #9541 from greg0ire/improve-templating
2022-02-24 20:25:13 +01:00
Grégoire Paris
40af1fcfc6
Improve templating
...
This is helpful for static analysis
2022-02-24 18:19:30 +01:00
Alexander M. Turek
021444b322
Merge branch '2.11.x' into 2.12.x
...
* 2.11.x:
Fix bug-#9536
2022-02-24 11:24:13 +01:00
Alexander M. Turek
ec7c637cf2
Un-deprecate the current proxy mechanism ( #9532 )
2022-02-24 11:17:05 +01:00
Grégoire Paris
0a0779c4a9
Remove unused methods
2022-02-22 20:26:18 +01:00
Grégoire Paris
856c3143f8
Merge pull request #9537 from kiler129/fix-bug-9536
...
Make error message suggestion accurate
2022-02-22 20:08:49 +01:00
kiler129
79f73a23f3
Fix bug-#9536
...
Wrong validation message is displayed when an incorrect bidirectional
bi-directional mapping is set up. When the owning side is configured
correctly and the target side is missing the back reference, the ORM
suggests adding inverseBy instead of mappedBy, with the field name
missing. This commit fixes this problem.
2022-02-22 12:05:35 -06:00
Grégoire Paris
a52d9880cc
Merge pull request #9542 from doctrine/2.11.x
...
Merge 2.11.x up into 2.12.x
2022-02-22 18:11:25 +01:00
Grégoire Paris
4af912f712
Merge pull request #9539 from greg0ire/use-stable-dbal
...
Drop minor version number
2022-02-22 18:01:26 +01:00
Grégoire Paris
65f48e0ecd
Drop minor version number
...
We should make it explicit that we mean to test with whatever is the
latest 3.x
2022-02-22 17:25:21 +01:00
Alexander M. Turek
08eaba44ca
Fix more types on EntityRepository and FilterCollection ( #9525 )
2022-02-20 21:09:41 +01:00
Alexander M. Turek
05c35c398f
Merge branch '2.11.x' into 2.12.x
...
* 2.11.x:
Bring `FilterCollection` to a "clean" state after hash computation (#9523 )
2022-02-20 14:19:47 +01:00
Matthias Pigulla
193c3abf0e
Bring FilterCollection to a "clean" state after hash computation ( #9523 )
...
Co-authored-by: Alexander M. Turek <me@derrabus.de >
2022-02-20 13:09:05 +00:00
Alexander M. Turek
dac1875a79
Merge branch '2.11.x' into 2.12.x
...
* 2.11.x:
Make creating test models more straightforward
Trigger the desired code path
Fix syntax typo in attributes reference (#9513 )
Constructor-Argument "options" has the same type as the associated property. (#9501 )
2022-02-20 11:52:36 +01:00
Grégoire Paris
5b8263e8fb
Merge pull request #9526 from greg0ire/better-model-setup
...
Make creating test models more straightforward and revert to swallowing exceptions
2022-02-20 09:35:21 +01:00
Grégoire Paris
26e85b8c88
Make creating test models more straightforward
...
In https://github.com/doctrine/orm/pull/8962 , I established that
swallowing exceptions while creating model was bad because it could hide
other helpful exceptions.
As it turns out however, swallowing exceptions is really the way to go
here, because of the performance implication of calling dropSchema(). It
is possible to catch a more precise exception as well, which should
preserve the benefits of not swallowing them.
It looks like I based my grep on the comment inside the catch and today,
I found many other occurrences of this pattern, without the easy to grep
comment.
I decided to fix them as well, but in a lazier way: one no longer has to
remember to call dropSchema in tearDown() now, it is automated.
2022-02-20 09:26:57 +01:00
Grégoire Paris
152c04c03d
Merge pull request #9519 from lcobucci/fix-pagination-test
...
Trigger the desired code path
2022-02-16 09:24:32 +01:00
Luís Cobucci
12ab6fa43f
Trigger the desired code path
...
Since v2.7.0 the ORM avoids using extra queries via the paginator
component when maximum results isn't set on the original query. With
that change, this test was not executing the code path that it was
expected to run.
This makes sure we trigger the forcing of custom DBAL types when
hydrating the identifiers, making sure we don't introduce bugs.
More info:
- Forcing DBAL type conversion: https://github.com/doctrine/orm/pull/7905
- Issue on optimisation: https://github.com/doctrine/orm/issues/7829
- PR on optimisation: https://github.com/doctrine/orm/pull/7863
- Minor BC-break docs: https://github.com/doctrine/orm/blob/2.11.x/UPGRADE.md#minor-bc-break-paginator-output-walkers-arent-be-called-anymore-on-sub-queries-for-queries-without-max-results
2022-02-15 22:59:09 +01:00
Alexander M. Turek
5a55772559
Document deprecation of AbstractCollectionPersister helpers ( #9512 )
2022-02-15 22:54:30 +01:00
Yann Rabiller
e8e61cbbd5
Fix syntax typo in attributes reference ( #9513 )
...
Curly brackets are the annotation way of declaring array. Probably a
mistake while copy pasting some examples from annotations.
2022-02-15 14:32:33 +00:00
Alexander M. Turek
d78fa52ad7
Replace TreeWalkerChainIterator with a generator ( #9511 )
2022-02-15 13:00:15 +01:00
Alexander M. Turek
4ddaa5fc20
Fix types on caches ( #9507 )
2022-02-13 22:50:21 +01:00
Tony Lemke
8f847cb5aa
Constructor-Argument "options" has the same type as the associated property. ( #9501 )
2022-02-13 21:42:15 +01:00
Alexander M. Turek
d7abcb01bc
Merge branch '2.11.x' into 2.12.x
...
* 2.11.x:
Fix AbstractQuery::setParameter phpdoc (#9504 )
2022-02-13 11:02:56 +01:00
David Maicher
599832cb81
Fix AbstractQuery::setParameter phpdoc ( #9504 )
...
* Fix AbstractQuery::setParameter phpdoc
* Fix AbstractQuery::setParameter phpdoc
2022-02-12 21:49:30 +01:00
Alexander M. Turek
8cff7dcdaf
Merge branch '2.11.x' into 2.12.x
...
* 2.11.x:
Added "false" value to $columnPrefix type declaration. (#9493 )
2022-02-09 14:56:45 +01:00
Dmytro Hordinskyi
530f515556
Added "false" value to $columnPrefix type declaration. ( #9493 )
2022-02-09 09:40:16 +01:00
Alexander M. Turek
601728045c
Merge branch '2.11.x' into 2.12.x
...
* 2.11.x:
PHPStan 1.4.6, Psalm 4.20.0 (#9491 )
Fix `#[DiscriminatorMap]` params (#9487 )
Run tests with stricter error handling (#9482 )
2022-02-09 00:51:01 +01:00
Alexander M. Turek
b18cd893be
Fix types on QueryBuilder ( #9492 )
2022-02-09 00:48:36 +01:00
Alexander M. Turek
21390a12b9
Fix types on EntityRepository ( #9474 )
2022-02-09 00:44:30 +01:00
Alexander M. Turek
182bcbae23
Avoid calling merge() ( #9489 )
2022-02-09 00:42:49 +01:00
Alexander M. Turek
1c55025b12
PHPStan 1.4.6, Psalm 4.20.0 ( #9491 )
2022-02-09 00:42:34 +01:00
Steve
0900d4bc97
Fix #[DiscriminatorMap] params ( #9487 )
...
Fix `#[DiscriminatorMap]` params
2022-02-08 08:35:46 +00:00
Alexander M. Turek
be2518d784
Run tests with stricter error handling ( #9482 )
2022-02-07 22:08:34 +00:00
Alexander M. Turek
978f687df9
Modernize strpos() calls ( #9480 )
2022-02-07 09:34:45 +01:00
Alexander M. Turek
fd1690431f
Fix types on persisters ( #9466 )
2022-02-07 09:26:15 +01:00
Grégoire Paris
3cfcd4ad13
Merge pull request #9479 from derrabus/improvement/useless-catch
...
Remove useless catches
2022-02-06 16:07:47 +01:00
Alexander M. Turek
69b0b764e3
Rename DoctrineSetup to ORMSetup ( #9481 )
2022-02-06 15:22:58 +01:00
Alexander M. Turek
e11cef5fca
Remove useless catches
2022-02-06 00:20:25 +01:00
Alexander M. Turek
395c02caf4
Deprecate methods removed in 3.0 ( #9475 )
2022-02-05 22:41:33 +01:00
Alexander M. Turek
0c4e739e94
Merge 2.11.x into 2.12.x ( #9473 )
2022-02-05 20:15:38 +01:00
Alexander M. Turek
7a72526e47
Skip tests related to PersistentObject if that class is missing ( #9472 )
2022-02-05 19:31:42 +01:00
Alexander M. Turek
bdd8883d12
Run Postgres 14 and MariaDB 10.6 in CI ( #9470 )
2022-02-05 19:28:13 +01:00
Alexander M. Turek
5f882b1cdd
Check requirements for metadata drivers ( #9459 )
2022-02-01 19:19:40 +01:00
Alexander M. Turek
b3d849dd38
Merge branch '2.11.x' into 2.12.x
...
* 2.11.x:
PDO is not a required extension (#9457 )
Check requirements for metadata drivers (#9452 )
Remove trailing underscore (#9446 )
2022-02-01 14:16:15 +01:00
Alexander M. Turek
536b65f02b
PDO is not a required extension ( #9457 )
2022-02-01 14:13:50 +01:00
Alexander M. Turek
103c42cdb7
Check requirements for metadata drivers ( #9452 )
2022-02-01 13:48:03 +01:00
Alexander M. Turek
aa1dd881d8
Support enums in findBy() calls ( #9453 )
2022-01-31 23:02:58 +01:00
Alexander M. Turek
92d27f2fea
Streamline cache creation in tests ( #9451 )
2022-01-31 21:55:39 +01:00
Alexander M. Turek
f8de44c35f
Document the new DoctrineSetup class ( #9448 )
2022-01-31 08:13:10 +01:00
Grégoire Paris
cdaf7b5308
Remove trailing underscore ( #9446 )
...
It looks like there was confusion between the syntax for external links
and the syntax for internal links, which does not mention underscores.
See https://www.sphinx-doc.org/en/master/usage/restructuredtext/roles.html#role-doc
versus https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html#external-links
2022-01-30 23:01:35 +00:00
Alexander M. Turek
f81980e1fa
Introduce DoctrineSetup as a replacement for Setup ( #9443 )
2022-01-30 22:38:57 +00:00
Alexander M. Turek
e9e54d8f65
Merge release 2.11.1 into 2.12.x ( #9444 )
2022-01-30 23:04:07 +01:00
Claudio Zizza
4b88ce787d
Introduce __unserialize behaviour in docs ( #9390 )
...
* Introduce __unserialize behaviour in docs
* Mention deprecation of Serializable interface
* Add link to __unserialize method
2022-01-30 22:47:06 +01:00
Alexander M. Turek
04bfdf85de
Merge 2.11.x up into 2.12.x ( #9441 )
2022-01-30 18:06:16 +01:00
Grégoire Paris
f9c3470a8d
Adapt test logic to PHP and SQLite II ( #9442 )
...
In a88242ee6c , testDateSub() was modified
in order to satisfy different opinions to the question "What is now
minus one month", that has different answers for different pieces of
software on March 30th.
Today, we are January 30th, we need to do the same for testDateAdd().
Hopefully this is the last time we hear about this.
2022-01-30 17:48:10 +01:00
Grégoire Paris
c1b131b67e
Merge pull request #9440 from sir-kain/php-8.1-ci
...
Added php 8.1 to CI
2022-01-30 09:55:04 +01:00
Grégoire Paris
16b82ea061
Use the identify generator strategy
...
It is a better default, and should fix tests for PostgreSQL
2022-01-29 11:33:13 +01:00
Waly
f8f370ace6
Added php 8.1 to CI
2022-01-28 22:55:25 +00:00
Alexander M. Turek
43f67c6164
Merge branch '2.11.x' into 2.12.x
...
* 2.11.x:
Psalm 4.19.0, PHPStan 1.4.3 (#9438 )
Ignore PHPUnit result cache everywhere (#9425 )
2022-01-28 23:08:59 +01:00
Alexander M. Turek
d5c69fb73f
Psalm 4.19.0, PHPStan 1.4.3 ( #9438 )
2022-01-28 21:54:10 +00:00
Alexander M. Turek
93f9eb7af2
Ignore PHPUnit result cache everywhere ( #9425 )
2022-01-24 12:35:44 +01:00
Alexander M. Turek
f5be4183ce
Introduce assertQueryCount ( #9423 )
2022-01-24 09:39:48 +01:00
Alexander M. Turek
eed031fab0
Merge branch '2.11.x' into 2.12.x
...
* 2.11.x:
Add support for PHP 8.1 enums in embedded classes (#9419 )
Added class-string typehint on $targetEntity (#9415 )
Allow DiscriminatorColumn with length=0 (#9410 )
Move UnderscoreNamingStrategyTest to correct namespace (#9414 )
2022-01-24 00:05:44 +01:00
HypeMC
6d5da83c68
Add support for PHP 8.1 enums in embedded classes ( #9419 )
2022-01-23 23:56:36 +01:00
Alexander M. Turek
328f36846e
Switch tests to the middleware logging system ( #9418 )
2022-01-23 23:55:07 +01:00
jworman
5f01dd8d09
Added class-string typehint on $targetEntity ( #9415 )
2022-01-23 20:09:41 +01:00
Benjamin Cremer
b596e6a665
Allow DiscriminatorColumn with length=0 ( #9410 )
2022-01-21 10:27:29 +01:00
Alexander M. Turek
79d3cf5880
Move UnderscoreNamingStrategyTest to correct namespace ( #9414 )
2022-01-20 20:49:11 +01:00
Alexander M. Turek
f7822c775d
Fix types on CacheLogger implementations ( #9401 )
2022-01-20 00:29:39 +01:00
Sergei Morozov
8c08792f0e
Rework some tests that use hardcoded DBAL mocks ( #9404 )
2022-01-19 17:11:57 +01:00
Alexander M. Turek
026bba23f1
Merge branch '2.11.x' into 2.12.x
...
* 2.11.x:
Fix type on loadCacheEntry (#9398 )
2022-01-18 23:35:01 +01:00
Alexander M. Turek
4305cb9230
Deprecate MultiGetRegion ( #9397 )
2022-01-18 22:50:26 +01:00
Alexander M. Turek
d7b7c28ae5
Fix type on loadCacheEntry ( #9398 )
2022-01-18 22:49:52 +01:00
Alexander M. Turek
2886d0dc92
Merge 2.11.x into 2.12.x ( #9394 )
...
* Expose enumType to DBAL to make native DB Enum possible (#9382 )
* Accessing private properties and methods from the same class is forbidden (#9311 )
Resolves issue https://github.com/doctrine/common/issues/934
Update docs/en/cookbook/accessing-private-properties-of-the-same-class-from-different-instance.rst
Co-authored-by: Claudio Zizza <859964+SenseException@users.noreply.github.com >
Update docs/en/cookbook/accessing-private-properties-of-the-same-class-from-different-instance.rst
Co-authored-by: Claudio Zizza <859964+SenseException@users.noreply.github.com >
Fix review issues
* Update baselines for DBAL 3.3 (#9393 )
Co-authored-by: Vadim Borodavko <vadim.borodavko@gmail.com >
Co-authored-by: olsavmic <molsavsky1@gmail.com >
2022-01-18 09:45:05 +01:00
Alexander M. Turek
d6fd510c49
Update baselines for DBAL 3.3 ( #9393 )
2022-01-18 09:13:14 +01:00
olsavmic
a2a7d5bb01
Accessing private properties and methods from the same class is forbidden ( #9311 )
...
Resolves issue https://github.com/doctrine/common/issues/934
Update docs/en/cookbook/accessing-private-properties-of-the-same-class-from-different-instance.rst
Co-authored-by: Claudio Zizza <859964+SenseException@users.noreply.github.com >
Update docs/en/cookbook/accessing-private-properties-of-the-same-class-from-different-instance.rst
Co-authored-by: Claudio Zizza <859964+SenseException@users.noreply.github.com >
Fix review issues
2022-01-17 23:15:31 +01:00
Vadim Borodavko
223b2650c4
Expose enumType to DBAL to make native DB Enum possible ( #9382 )
2022-01-17 10:39:16 +01:00
Alexander M. Turek
07f1c4e8f8
Merge pull request #9387 from doctrine/2.11.x
2022-01-16 21:39:56 +01:00
Vadim Borodavko
01c1644d9c
Allow using Enum from different namespace than Entity ( #9384 )
2022-01-16 13:08:30 +01:00
Sukhdev Mohan
3eff2d4b3f
Corrected ORM version and added missing dependency ( #9386 )
...
* Corrected ORM version and added missing dependency
Noticed that the version wasn't updated, pointing to 2.11.0 instead of 2.10.2.
Also when following this tutotial ran into missing dependency for "doctrine/annotation" so added that too.
* Tutorial: Bump DBAL, YAML and Cache
Co-authored-by: Alexander M. Turek <me@derrabus.de >
2022-01-16 02:28:30 +01:00
Alexander M. Turek
9ddf8b96f8
PHPStan 1.4.0 ( #9385 )
2022-01-16 01:22:41 +01:00
Benjamin Eberlei
3d00fa817a
[GH-9380] Bugfix: Delegate ReflectionEnumProperty::getAttributes(). ( #9381 )
...
* [GH-9380] Bugfix: Delegate ReflectionEnumProperty::getAttributes().
* [GH-9380] Add test for retrieving attributes via enum property.
* [GH-9380] Add test for retrieving attributes via enum property.
* [GH-9380] Call parent ReflectionProperty ctor for best behavior.
* Update tests/Doctrine/Tests/ORM/Functional/EnumTest.php
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr >
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr >
2022-01-16 00:06:59 +01:00
Alexander M. Turek
0809a2b671
Support enum cases as parameters ( #9373 )
2022-01-13 13:11:13 +01:00
Andrii Dembitskyi
c0a1404e4c
Add detach as of list cascade-all operations ( #9357 )
2022-01-12 22:33:11 +01:00
Alexander M. Turek
bfed8cb6ed
Update branch metadata for 2.11 ( #9364 )
2022-01-12 14:20:33 +01:00
Alexander M. Turek
09a2648f7e
Fix doc blocks on ID generators ( #9368 )
2022-01-12 12:10:23 +01:00
Alexander M. Turek
ee591195cf
Use EntityManagerInterface in type declarations ( #9325 )
2022-01-12 11:00:07 +01:00
Alexander M. Turek
e974313523
Merge branch '2.10.x' into 2.11.x
...
* 2.10.x:
Add errors caused by the lexer update to the baselines (#9360 )
2022-01-12 10:11:19 +01:00
Alexander M. Turek
1e972b6e0e
Add errors caused by the lexer update to the baselines ( #9360 )
2022-01-12 10:06:40 +01:00
Christian Mehldau
e369cb6e73
Generated/Virtual Columns: Insertable / Updateable ( #9118 )
...
* Generated/Virtual Columns: Insertable / Updateable
Defines whether a column is included in an SQL INSERT and/or UPDATE statement.
Throws an exception for UPDATE statements attempting to update this field/column.
Closes #5728
* Apply suggestions from code review
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr >
* Add example for virtual column usage in attributes to docs.
Co-authored-by: Benjamin Eberlei <kontakt@beberlei.de >
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr >
2022-01-12 08:06:11 +01:00
Grégoire Paris
ec391be4f2
Merge pull request #9356 from derrabus/remove/package-versions
...
Remove the `composer/package-versions-deprecated` package
2022-01-11 21:03:59 +01:00
Alexander M. Turek
697e23422f
Remove the composer/package-versions-deprecated package
2022-01-11 10:42:42 +01:00
Alexander M. Turek
e487b6fe2b
Relax assertion to include null as possible outcome ( #9355 )
2022-01-10 23:09:02 +01:00
Alexander M. Turek
656f881756
Merge branch '2.10.x' into 2.11.x
...
* 2.10.x:
Fix WhereInWalker description to better describe the behaviour of this class (#9268 )
2022-01-09 23:48:22 +01:00
Alexander M. Turek
cd2aa487a5
Leverage generic ObjectManagerDecorator ( #9312 )
2022-01-09 23:10:05 +01:00
LuigiCardamone
b7d822972e
Fix WhereInWalker description to better describe the behaviour of this class ( #9268 )
...
* Fix WhereInWalker description:
- change the verb "replace" with "append" to better describe the behaviour of this class
* Rephrase comment in WhereInWalker as suggested from reviewer
Co-authored-by: Alexander M. Turek <me@derrabus.de >
* Rephrase comment in WhereInWalker as suggested from reviewer
Co-authored-by: Alexander M. Turek <me@derrabus.de >
Co-authored-by: Alexander M. Turek <me@derrabus.de >
2022-01-09 23:09:28 +01:00
Alexander M. Turek
ec63f5d32a
Regenerate Psalm baseline
2022-01-09 22:35:05 +01:00
Alexander M. Turek
952ccc5fc8
Merge branch '2.10.x' into 2.11.x
...
* 2.10.x:
Update Psalm baseline for Persistence 2.3 (#9349 )
2022-01-09 22:33:24 +01:00
Alexander M. Turek
9a2f1f380d
Update Psalm baseline for Persistence 2.3 ( #9349 )
2022-01-09 20:11:12 +00:00
Alexander M. Turek
580b9196e6
Support readonly properties for read operations ( #9316 )
...
* Provide failing test for readonly properties
* Skip writing readonly properties if the value did not change
2022-01-09 20:15:56 +01:00
Grégoire Paris
0d911b9381
Merge pull request #9322 from derrabus/feature/psr-region-cache
...
PSR-6 second level cache
2022-01-09 16:23:04 +01:00
Grégoire Paris
c6d8aecc0f
Merge pull request #9326 from kimhemsoe/rsm-custom-type
...
Add support for custom types with requireSQLConversion and ResultSetMappingBuilder::generateSelectClause()
2022-01-09 16:17:31 +01:00
Grégoire Paris
fdd3d112b0
Merge remote-tracking branch 'origin/2.10.x' into 2.11.x
2022-01-09 15:50:52 +01:00
Grégoire Paris
2fecb3cb1a
Merge pull request #9341 from derrabus/bump/phpstan-psalm
...
PHPStan 1.3.3, Psalm 4.18.1
2022-01-09 15:48:49 +01:00
Alexander M. Turek
f3630ea16b
PHPStan 1.3.3, Psalm 4.18.1
2022-01-09 15:39:44 +01:00
Grégoire Paris
fd19444761
Merge pull request #9344 from greg0ire/remove-dbal2-psalm-job
...
Remove Psalm job for analyzing DBAL 2
2022-01-09 15:38:56 +01:00
Grégoire Paris
4b1afb41b3
Remove Psalm job for analyzing DBAL 2
...
As of now, we cannot have specific config files for each DBAL version
and avoid repetition. We already have PHPStan performing checks with
DBAL 2, which could be considered enough.
2022-01-09 13:57:00 +01:00
Alexander M. Turek
f9f453f4d7
Use the readonly annotation ( #9340 )
2022-01-09 12:25:04 +01:00
Kim Hemsø Rasmussen
f508a4bb71
Add support for custom types with requireSQLConversion and ResultSetMappingBuilder::generateSelectClause()
2022-01-09 10:02:30 +01:00
Alexander M. Turek
5d0fbc47d0
PSR-6 second level cache
2022-01-09 02:02:50 +01:00
Alexander M. Turek
1e977426eb
Fix type errors in AbstractQuery and QueryBuilder ( #9275 )
2022-01-09 00:26:58 +01:00
Grégoire Paris
2640f88f8a
Merge pull request #9339 from greg0ire/fix-field-mapping-typing
...
Fix field mapping typing
2022-01-08 23:57:48 +01:00
Grégoire Paris
fa731b10ec
Mark columnName as always set
...
This is enforced before writing to the property that holds FieldMapping
arrays.
As shown by the static analysis baselines reduction, this existence is
relied on throughout the codebase.
2022-01-08 14:12:04 +01:00
Grégoire Paris
4117ca349f
Merge pull request #9304 from beberlei/EnumSupport
...
Add support for PHP 8.1 enums.
2022-01-08 11:49:08 +01:00
Benjamin Eberlei
2d475c9bb3
Add support for PHP 8.1 enums.
2022-01-08 09:53:11 +01:00
Grégoire Paris
6f54011e7b
Merge remote-tracking branch 'origin/2.10.x' into 2.11.x
2022-01-07 20:28:54 +01:00
Grégoire Paris
760397c429
Remove ignore rules for issues fixed upstream ( #9336 )
...
The rules still should apply when using DBAL v2
2022-01-07 20:25:00 +01:00
Benjamin Eberlei
7190ac5127
[GH-9277] deprecate php driver ( #9309 )
...
* [GH-9277] Deprecate PHPDriver
* Update UPGRADE.md, fix wrong parameter
* Copy docblock to appease confused Psalm
* Talk about alternatives more
2022-01-06 10:19:42 +01:00
Alexander M. Turek
ceaefcb18d
Merge 2.10.x into 2.11.x ( #9331 )
...
* Enable some previously disabled PHPCS rules (#9324 )
* Fix broken type declaration (#9330 )
2022-01-05 10:03:45 +01:00
Alexander M. Turek
844ce77cae
Added runtime deprecation to UnitOfWork::commit() and clear() ( #9327 )
2022-01-05 08:14:46 +01:00
Alexander M. Turek
cf3a185b62
Document return type of getEntityState() ( #9328 )
2022-01-05 07:58:21 +01:00
Alexander M. Turek
efc982a48d
Fix broken type declaration ( #9330 )
2022-01-05 07:55:33 +01:00
Alexander M. Turek
96bc214acd
Enable some previously disabled PHPCS rules ( #9324 )
2022-01-03 23:25:34 +01:00
Alexander M. Turek
15999758a7
Merge branch '2.10.x' into 2.11.x
...
* 2.10.x:
Run static analysis with language level PHP 8.1 (#9314 )
Document PHPUnit mocks with intersection types (#9318 )
2022-01-02 19:36:10 +01:00
Alexander M. Turek
44aa8c2c5b
Run static analysis with language level PHP 8.1 ( #9314 )
2022-01-02 18:01:31 +01:00
Alexander M. Turek
8c6fc5ae52
Document LockMode enums ( #9319 )
2022-01-02 18:01:00 +01:00
Alexander M. Turek
c4561571aa
Document PHPUnit mocks with intersection types ( #9318 )
2022-01-02 18:00:17 +01:00
Alexander M. Turek
40a203843d
Merge branch '2.10.x' into 2.11.x
...
* 2.10.x:
Run PHP CodeSniffer on PHP 8.1 (#9317 )
Psalm 4.17.0 (#9315 )
2022-01-02 14:16:56 +01:00
Alexander M. Turek
8b5ee54c6a
Run PHP CodeSniffer on PHP 8.1 ( #9317 )
2022-01-02 14:15:30 +01:00
Alexander M. Turek
03fa495fbc
Psalm 4.17.0 ( #9315 )
2022-01-01 23:41:05 +01:00
Alexander M. Turek
5901848944
Merge 2.10.x into 2.11.x ( #9313 )
2022-01-01 23:40:19 +01:00
Grégoire Paris
d40f9e57ff
Run static analysis on PHP 8.1 ( #9310 )
...
This will make it easier to add code that leverages features only
defined since that version of PHP.
2022-01-01 20:28:17 +01:00
Alexander M. Turek
133cc95f33
Merge branch '2.10.x' into 2.11.x
...
* 2.10.x:
Bump PHPStan & Psalm (#9303 )
Removing list "Lifecycle Events" (#9243 )
Drop unneeded backslashes
Fix Hidden fields triggering error when using getSingleScalarResult() (#8340 )
Findby joined lookup (#8285 )
2021-12-31 02:59:55 +01:00
Alexander M. Turek
d30e748e64
Bump PHPStan & Psalm ( #9303 )
2021-12-31 02:21:15 +01:00
Alexander M. Turek
98d77043d8
Fix type errors in AnnotationDriver ( #9274 )
2021-12-29 16:03:10 +01:00
Grégoire Paris
40d1e7bbfc
Merge pull request #9214 from doctrine/2.7
...
Merge 2.7 into 2.10.x
2021-12-28 23:41:38 +01:00
Thomas Landauer
e8275f6e4d
Removing list "Lifecycle Events" ( #9243 )
...
As announced in https://github.com/doctrine/orm/pull/9184#issuecomment-965837780
2021-12-28 14:04:58 +01:00
Alexander M. Turek
70dcffa025
Leverage get_debug_type() ( #9297 )
2021-12-28 08:02:16 +01:00
Alexander M. Turek
c94a9b1d8b
Merge 2.10.x into 2.11.x ( #9298 )
...
* Bump reusable workflows
* Fix union type on QueryExpressionVisitorTest::testWalkComparison() (#9294 )
* Synchronize Psalm baseline (#9296 )
* Fix return type (#9295 )
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr >
2021-12-28 01:25:01 +01:00
Alexander M. Turek
6a9393e8ed
Fix return type ( #9295 )
2021-12-28 00:49:50 +01:00
Alexander M. Turek
ab98d0ffc6
Synchronize Psalm baseline ( #9296 )
2021-12-28 00:49:32 +01:00
Alexander M. Turek
2ddeb79431
Fix union type on QueryExpressionVisitorTest::testWalkComparison() ( #9294 )
2021-12-27 23:43:09 +01:00
David ALLIX
92ff9c9108
Allow arithmetic expressions within IN operator ( #9242 )
...
* allow arithmetic expressions within IN operator
Co-authored-by: Artem Stepin <stepin.artem@gmail.com >
2021-12-27 19:03:47 +01:00
Grégoire Paris
7c58dc89c3
Merge pull request #9289 from derrabus/bump/workflows
...
Bump reusable workflows
2021-12-27 18:36:35 +01:00
Alexander M. Turek
b513f7c935
Bump reusable workflows
2021-12-27 13:05:20 +01:00
Alexander M. Turek
f1483f848c
Merge 2.10.x into 2.11.x ( #9287 )
...
* Better explain limitations of DQL "DELETE" (#9281 )
We think the current documentation does not stress these details enough, so that they are easily overlooked.
Co-authored-by: Malte Wunsch <mw@webfactory.de >
Co-authored-by: Malte Wunsch <mw@webfactory.de >
* Put actual value instead of index inside $originalEntityData. (#9244 )
This fixes a bug with redundant UPDATE queries, that are executed when some entity uses foreign index of other entity as a primary key. This happens when after inserting related entities with $em->flush() call, you do the second $em->flush() without changing any data inside entities.
Fixes GH8217.
Co-authored-by: ivan <ivan.strygin@managinglife.com >
* Allow symfony/cache 6 (#9283 )
* Fix XML export for `change-tracking-policy` (#9285 )
* Whitelist composer plugins used by this repository (#9286 )
Co-authored-by: Matthias Pigulla <mp@webfactory.de >
Co-authored-by: Malte Wunsch <mw@webfactory.de >
Co-authored-by: Ivan Strygin <feolius@gmail.com >
Co-authored-by: ivan <ivan.strygin@managinglife.com >
Co-authored-by: Fedir Zinchuk <getthesite@gmail.com >
2021-12-26 01:06:54 +01:00
Alexander M. Turek
ea4c9b21b7
Enable UnusedUse sniff again ( #9267 )
2021-12-25 23:06:50 +01:00
Alexander M. Turek
72edfbc270
Whitelist composer plugins used by this repository ( #9286 )
2021-12-25 13:04:42 +01:00
Fedir Zinchuk
5ccf2eac40
Fix XML export for change-tracking-policy ( #9285 )
2021-12-24 00:22:42 +01:00
Alexander M. Turek
6696b0dfbf
Allow symfony/cache 6 ( #9283 )
2021-12-24 00:12:11 +01:00
Ivan Strygin
aead77d597
Put actual value instead of index inside $originalEntityData. ( #9244 )
...
This fixes a bug with redundant UPDATE queries, that are executed when some entity uses foreign index of other entity as a primary key. This happens when after inserting related entities with $em->flush() call, you do the second $em->flush() without changing any data inside entities.
Fixes GH8217.
Co-authored-by: ivan <ivan.strygin@managinglife.com >
2021-12-24 00:10:42 +01:00
Alexander M. Turek
130c27c1da
Fix return types of cache interfaces ( #9271 )
2021-12-22 01:04:07 +01:00
Matthias Pigulla
f6e1dd44f0
Better explain limitations of DQL "DELETE" ( #9281 )
...
We think the current documentation does not stress these details enough, so that they are easily overlooked.
Co-authored-by: Malte Wunsch <mw@webfactory.de >
Co-authored-by: Malte Wunsch <mw@webfactory.de >
2021-12-22 00:44:25 +01:00
Alexander M. Turek
1e9973a0c0
Merge release 2.10.4 into 2.11.x ( #9280 )
2021-12-21 11:01:59 +01:00
Alexander M. Turek
91761738fd
Fix docblocks on nullable EM properties ( #9273 )
2021-12-20 22:31:57 +01:00
Andrii Dembitskyi
cccb2e2fdf
Docs: use canonical order for phpdoc tags, add missed semicolon ( #9190 )
2021-12-20 22:23:47 +01:00
Benjamin Eberlei
18138d895e
Make PrimaryReadReplicaConnection enforcement explicit ( #9239 )
...
* Move primary replica connection logic into ORM explicitly.
* Housekeeping: Use full named variables
* Housekeeping: phpcs
2021-12-20 13:50:25 +01:00
Alexander M. Turek
95d434d003
Merge 2.10.x into 2.11.x ( #9276 )
...
* Docs: consistency for FQCN, spacing, etc (#9232 )
* Docs: consistent spacing, consistent array-style, consistent FQCN, avoid double escaped slashes, avoid double quotes if not necessary
* Docs: use special note block instead of markdown-based style
* Docs: Quote FQCN in table with backticks to be compatible with all render engines
* Drop all mentions API doc - it is not available anymore
* Add missed FQCN for code snippets
* Revert "Fix SchemaValidator with abstract child class in discriminator map (#9096 )" (#9262 )
This reverts commit bbb68d0072 .
* [docs] Fix wording for attributes=>parameters. (#9265 )
Co-authored-by: Andrii Dembitskyi <andrew.dembitskiy@gmail.com >
Co-authored-by: olsavmic <molsavsky1@gmail.com >
Co-authored-by: Benjamin Eberlei <kontakt@beberlei.de >
2021-12-20 04:11:33 +01:00
Alexander M. Turek
70c651ebb7
Regenerate Psalm baseline ( #9272 )
2021-12-19 17:06:20 +01:00
Sergei Morozov
8cb62a616a
Improve compatibility with Doctrine DBAL 4 ( #9266 )
...
* Improve compatibility with AbstractPlatform::getLocateExpression() in DBAL 4
* Improve compatibility with AbstractPlatform::getTrimExpression() in DBAL 4
* Improve compatibility with Connection::quote() in DBAL 4
2021-12-19 13:19:30 +01:00
Benjamin Eberlei
fa2b52c974
[docs] Fix wording for attributes=>parameters. ( #9265 )
2021-12-18 11:16:35 +01:00
Benjamin Eberlei
6d306c1946
Support for nesting attributes with PHP 8.1 ( #9241 )
...
* [GH-9240] Refactor Association/AttributeOverrides to use @NamedConstructorArguments with AnnotationDriver.
* [GH-9240] Add support for PHP 8.1 nested attributes.
Supported/new attributes are #[AttributeOverrides], #[AssociationOverrides], #[JoinTable] with nested joinColumns, inverseJoinColumns.
* [GH-9240] Add support for nesting Index, UniqueCosntraint into #[Table] on PHP 8.1
* Apply review comments by gregooire.
* Add documentation for new attributes.
* Add docs for new nested #[JoinTable] support of join columns
* Add docs for new nested #[Table] support of index, uniqueConstraints
* Rename "Required/Optional atttributes" to "Required/Optional parameters"
* Remove nesting for JoinTable#joinColumns and Table#indexes/uniqueConstraints again.
* Hosuekeeping: phpcs/psalm
* housekeeping
* Remove unused function imports.
2021-12-18 11:03:12 +01:00
olsavmic
5bf814032f
Revert "Fix SchemaValidator with abstract child class in discriminator map ( #9096 )" ( #9262 )
...
This reverts commit bbb68d0072 .
2021-12-18 11:01:30 +01:00
Sergei Morozov
bea5e7166c
Address more DBAL 3.2 deprecations ( #9256 )
...
* Instantiate comparator via the schema manager, if possible
* Do not use AbstractPlatform::getName()
2021-12-16 23:18:18 +01:00
Alexander M. Turek
003090b70c
Deprecate Setup::registerAutoloadDirectory() ( #9249 )
2021-12-13 23:36:10 +01:00
Andrii Dembitskyi
02a4e4099d
Docs: consistency for FQCN, spacing, etc ( #9232 )
...
* Docs: consistent spacing, consistent array-style, consistent FQCN, avoid double escaped slashes, avoid double quotes if not necessary
* Docs: use special note block instead of markdown-based style
* Docs: Quote FQCN in table with backticks to be compatible with all render engines
* Drop all mentions API doc - it is not available anymore
* Add missed FQCN for code snippets
2021-12-13 23:10:01 +01:00
Alexander M. Turek
56e0ac02af
Merge 2.10.x into 2.11.x ( #9248 )
2021-12-13 22:21:00 +01:00
Alexander M. Turek
12a70bbefb
PHPCS 3.6.2, Psalm 4.15.0 ( #9247 )
2021-12-13 21:28:56 +01:00
Grégoire Paris
5a4ddb2870
Merge pull request #9184 from ThomasLandauer/patch-1
...
[Documentation] Events Overview Table: Adding "Passed Argument" column
2021-12-12 16:21:13 +01:00
Simon Podlipsky
42195060e6
Add SchemaIgnoreClasses property for #8195 . ( #9202 )
...
Co-authored-by: Simon Podlipsky <simon@podlipsky.net >
Co-authored-by: Iab Foulds <ianfoulds@x-act.co.uk >
2021-12-12 13:42:07 +01:00
Alexander M. Turek
68fa55f310
Remove fallbacks for old doctrine/annotations version ( #9235 )
2021-12-11 17:11:34 +01:00
Thomas Landauer
0b0c3e7e58
Update docs/en/reference/events.rst
...
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr >
2021-12-09 12:00:30 +01:00
Kevin van Sonsbeek
92434f91c7
Added psalm param to abstract addFilterConstraint ( #9229 )
2021-12-08 22:31:52 +00:00
Alexander Schranz
6414ad4cbb
Merge pull request #9210 from alexander-schranz/patch-2
...
Fix making columns optional in indexes xml schema as they can be defined via fields now
2021-12-06 00:55:01 +01:00
Alexander M. Turek
ac5aea1c81
Merge release 2.10.3 into 2.11.x ( #9224 )
2021-12-03 22:40:00 +01:00
Alexander M. Turek
a75605b8c3
Merge pull request #9211 from derrabus/deprecate/convert-mapping
...
Add deprecation hints to `orm:convert-mapping` command
2021-12-03 15:50:09 +01:00
Grégoire Paris
7b24275346
Merge pull request #9218 from Florian-Varrin/patch-1
...
Fix typo assumptio--> assumption
2021-12-03 13:27:05 +01:00
Florian Varrin
ed1a576305
Fix typo assumptio--> assumption
2021-12-03 11:39:59 +01:00
Grégoire Paris
66c95a65c5
Drop unneeded backslashes
2021-12-01 21:53:36 +01:00
Bruce
62a0d7359b
Fix Hidden fields triggering error when using getSingleScalarResult() ( #8340 )
...
* Fix Hidden fields triggering error when using getSingleScalarResult()
Fixes #4257
HIDDEN fields was causing the "unicity" check to fail (NonUniqueResultException), because we was counting raw data instead of gathered row data.
* Fix Coding Standards (7.4)
* Fix Coding Standards (7.4) #2
* Fix Coding Standards (7.4) - Fix whitespaces
* Fix Coding Standards (7.4) - Fix whitespaces in tests
* Fix Coding Standards (7.4) - Fix more things
* Refactor tests into separate methods
* Fix Coding Standards (7.4) - Equals sign not aligned with surrounding assignments
2021-12-01 21:52:31 +01:00
Benjamin Eberlei
2c7d7ebb48
Findby joined lookup ( #8285 )
...
* [GH-7512] Bugfix: Load metadata on object-typed value in EntityPersisters
* [GH-7512] Refactor double check for object/entity and flatten code.
Co-authored-by: Joe Mizzi <themizzi@me.com >
2021-12-01 21:52:29 +01:00
Thomas Landauer
8b6fe52f74
Update events.rst
2021-12-01 01:01:04 +01:00
Alexander M. Turek
eabb7f84e9
Add deprecation hints to orm:convert-mapping command
2021-11-30 23:04:44 +01:00
Alexander M. Turek
f0a20dbc9c
Merge 2.10.x into 2.11.x ( #9213 )
2021-11-30 22:37:08 +01:00
Alexander M. Turek
15ec77fa79
Suppress Psalm's ReservedWord errors ( #9212 )
2021-11-30 20:20:27 +01:00
Thomas Landauer
32cd2106d0
Completing links to EventArgs classes in overview table
...
Questions:
1. Is https://github.com/doctrine/persistence/blob/master/lib/Doctrine/Persistence/Event/LifecycleEventArgs.php correct at all? Shouldn't this be https://github.com/doctrine/orm/blob/2.10.x/lib/Doctrine/ORM/Event/LifecycleEventArgs.php , like all the others?
2. Which one is correct for `preUpdate`? https://www.doctrine-project.org/projects/doctrine-orm/en/2.10/reference/events.html#entity-listeners-class says `PreUpdateEventArgs`, but https://www.doctrine-project.org/projects/doctrine-orm/en/2.10/reference/events.html#listening-and-subscribing-to-lifecycle-events says `LifecycleEventArgs`
For the two links to `doctrine/persistence`, I'm linking to `/master/` now, which is being forwarded to `/2.2.x/`.
2021-11-30 15:51:20 +01:00
Alexander M. Turek
6857a2e8d4
Add missing deprecations for YAML metadata mapping ( #9206 )
2021-11-29 16:46:05 +01:00
Alexander M. Turek
5e8b34ae30
Merge pull request #9203 from derrabus/bump/dbal-3.2
...
Drop support for DBAL 3.1
2021-11-29 16:45:30 +01:00
Alexander M. Turek
a9b682b7c0
Drop support for DBAL 3.1
2021-11-29 10:37:05 +01:00
Alexander M. Turek
0aadc456dc
Merge 2.10.x into 2.11.x ( #9205 )
...
* Adding Attributes code block (#9161 )
Just that there is some real-world example somewhere ;-) see https://github.com/doctrine/orm/issues/9020#issuecomment-955582801
* Use `equal to` instead of `equal of` in `assertSqlGeneration()` (#9195 )
* Add a psalm type for field mapping
Field mapping have different definitions
in property definition and method return.
As suggested in issue and to avoid further desynchronization,
a psalm type has been created.
Fixes #9193
* Psalm 4.13.1, PHPStan 1.2.0 (#9204 )
Co-authored-by: Thomas Landauer <thomas@landauer.at >
Co-authored-by: Simon Podlipsky <simon@podlipsky.net >
Co-authored-by: Julien LARY <47776596+laryjulien@users.noreply.github.com >
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr >
2021-11-28 01:08:49 +01:00
Alexander M. Turek
cac2acae07
Psalm 4.13.1, PHPStan 1.2.0 ( #9204 )
2021-11-28 00:50:56 +01:00
Grégoire Paris
146b465ec1
Merge pull request #9198 from laryjulien/fix-fieldmapping-definition
...
Add a psalm type for field mapping
2021-11-23 21:10:18 +01:00
Julien LARY
5aba762a33
Add a psalm type for field mapping
...
Field mapping have different definitions
in property definition and method return.
As suggested in issue and to avoid further desynchronization,
a psalm type has been created.
Fixes #9193
2021-11-23 18:05:47 +01:00
Thomas Landauer
77b7107d05
Using const for type
2021-11-23 01:41:01 +01:00
Simon Podlipsky
a663dda869
Use equal to instead of equal of in assertSqlGeneration() ( #9195 )
2021-11-20 21:27:46 +01:00
Thomas Landauer
db14f0fa89
Adding Attributes code block ( #9161 )
...
Just that there is some real-world example somewhere ;-) see https://github.com/doctrine/orm/issues/9020#issuecomment-955582801
2021-11-20 18:14:49 +01:00
Grégoire Paris
2488b4c50c
Merge pull request #9196 from greg0ire/2.11.x
...
Merge 2.10.x up into 2.11.x
2021-11-20 15:38:36 +01:00
Grégoire Paris
ed642c72c9
Merge remote-tracking branch 'origin/2.10.x' into 2.11.x
2021-11-20 15:28:20 +01:00
Vincent Langlet
9a74ae6280
Fix discriminatorColumn phpdoc ( #9168 )
2021-11-11 23:01:34 +01:00
Grégoire Paris
32eb38ebd9
Merge pull request #9181 from greg0ire/fix-broken-build
...
Remove similar assertions for other platforms
2021-11-11 16:20:53 +01:00
Thomas Landauer
2dde65c4ba
[Documentation] Events Overview Table: Adding "Passed Argument" column
...
As announced in https://github.com/doctrine/orm/pull/9160#issuecomment-954304588 I'm adding the passed "EventArgs" class to the overview table. Once this is complete, my further plan is to remove the entire paragraph https://www.doctrine-project.org/projects/doctrine-orm/en/2.10/reference/events.html#lifecycle-callbacks-event-argument , and probably also the second code block at https://www.doctrine-project.org/projects/doctrine-orm/en/2.10/reference/events.html#entity-listeners-class
Is there a better way to link to the source code of `LifecycleEventArgs` than https://github.com/doctrine/persistence/blob/2.2.x/lib/Doctrine/Persistence/Event/LifecycleEventArgs.php ?
Also, I changed `postLoad` to `preUpdate` in the code block, to have an example that does not receive `LifecycleEventArgs` ;-)
2021-11-11 00:22:25 +01:00
Thomas Landauer
176fbedc69
Fine-tuning codeblock ( #9176 )
...
* Deleting "Not needed for XML and YAML mapping" - this was stupid of me, since *all* annotations are obviously not needed in XML&YAML ;-)
* Shortening the @Column annotation, for consistency with the following event handlers
* Removing some blank lines from XML, for consistency with YAML
* Adding PHP Attributes
2021-11-10 22:43:09 +01:00
Grégoire Paris
1b15af44b6
Remove similar assertions for other platforms
...
Testing with several platforms should not increase code coverage here,
since the DBAL is responsible for providing the concat expression for
each platform.
Moreover, whenever that concat expression changes for one of the tested
platforms, this test will break.
In doctrine/dbal 3.2, that is the case for SQLServer2012Platform, which
means this test no longer passes.
2021-11-08 21:21:41 +01:00
Grégoire Paris
8336420a26
Merge pull request #9153 from armenio/2.10.x
...
Infer type from field instead of column
2021-11-08 07:45:07 +01:00
Thomas Landauer
1e971d85c4
Merging two ~identical lists on event types ( #9160 )
...
* Merging two ~identical lists on event types
Just noticed that what I added in https://github.com/doctrine/orm/pull/9128 was (in other words) already there ;-)
* Update docs/en/reference/events.rst
Co-authored-by: Claudio Zizza <859964+SenseException@users.noreply.github.com >
Co-authored-by: Claudio Zizza <859964+SenseException@users.noreply.github.com >
2021-11-06 21:32:46 +01:00
Thomas Landauer
a6b7569d7a
Fixing more links ( #9154 )
...
* Fixing more links
The first two I missed in https://github.com/doctrine/orm/pull/9151
The third is probably older.
Shouldn't the chapter name be displayed as link text by default?? Are you sure that everything is set up correctly with the parser?
* Update architecture.rst
* Update getting-started.rst
* Update events.rst
2021-11-06 20:49:54 +01:00
Rafael Armenio
9e37c788ef
Infer type from field instead of column
...
getTypeOfColumn() relies on getTypeOfField(), and does not suffer from
mismatching issues caused by quoting, because you cannot quote a field.
Since a field can be composite, that method returns an array, hence why we
need to select the first element.
2021-11-05 13:58:53 -03:00
Grégoire Paris
ca0a6bbf71
Merge pull request #9167 from derrabus/bump/phpstan
...
PHPStan 1.0.1
2021-11-03 21:15:19 +01:00
Grégoire Paris
a3da3d78d4
Merge pull request #9159 from ThomasLandauer/patch-10
...
Merging Lifecycle Callbacks code samples for PHP + XML + YAML
2021-11-03 21:13:53 +01:00
Alexander M. Turek
e1c2d2e65d
PHPStan 1.0.1
...
Signed-off-by: Alexander M. Turek <me@derrabus.de >
2021-11-02 20:41:48 +01:00
Alexander Schranz
6f194eeabf
Remove reverted bc break ( #9166 )
2021-11-01 13:56:12 +01:00
Grégoire Paris
16cbc16998
Document BC break ( #9143 )
...
Closes #9141
2021-10-30 19:10:25 +02:00
Thomas Landauer
5e6608b48e
Update events.rst
2021-10-30 13:48:03 +02:00
Grégoire Paris
94bc137526
Merge pull request #9123 from phansys/quotes_in_column_names
...
Add XSD "orm:columntoken" type in order to support reserved words in column names
2021-10-29 18:19:35 +02:00
Thomas Landauer
276a0f55ee
Removing paragraph on consts ( #9158 )
...
IMO, this is better shown by example, so I added it there.
2021-10-29 14:21:37 +02:00
Thomas Landauer
dbaf99f3d9
Update events.rst
2021-10-29 01:17:32 +02:00
Thomas Landauer
97411f5567
Merging Lifecycle Callbacks code samples for PHP + XML + YAML
...
IMO, the text I deleted just repeated things that are obvious in the example anyway.
2021-10-29 01:12:02 +02:00
Chase Noel
641330baa6
Add doctrine/dbal to project composer.json ( #9152 )
...
As discussed in https://github.com/doctrine/orm/issues/9078 when entities utilize data mappings which are provided by the dbal lib it is expected behavior that users will explicitly define their dependency on the package.
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr >
2021-10-28 23:42:05 +02:00
Grégoire Paris
2074fc3ff9
Merge pull request #9133 from judahnator/2.10.x
...
Adding a setup helper for attribute metadata config
2021-10-28 22:23:25 +02:00
Thomas Landauer
35e680cd3f
Fixing links in overview table ( #9151 )
...
I got them wrong in https://github.com/doctrine/orm/pull/9131 ;-)
2021-10-28 21:29:47 +02:00
Javier Spagnoletti
705d88eaba
Add XSD "orm:columntoken" type in order to support reserved words in column names
2021-10-28 14:00:39 -03:00
Judah Wright
8fef44333b
Adding a setup helper for attribute metadata config
2021-10-27 15:05:38 -07:00
Paul Waring
3271d8f6e2
Fix markup for variable names ( #9150 )
...
Three references to `$isDevMode` were marked up with a single backtick, however two backticks are required in order for the variable name to be highlighted correctly (c.f. `ArrayCache`).
2021-10-26 10:59:31 +00:00
Thomas Landauer
3622381f8c
Overview table for events: Jump links ( #9131 )
...
* Overview table for events: Jump links
* Update events.rst
2021-10-25 22:34:36 +02:00
wickedOne
f2729b0610
Return 0 when there's no metadata to process ( #9147 )
2021-10-23 09:43:40 +00:00
chapterjason
cd44547573
Remove old use statements ( #9146 )
2021-10-23 11:32:44 +02:00
Grégoire Paris
3361691d0a
Merge pull request #9140 from doctrine/2.10.x-merge-up-into-2.11.x_JJHD4HD8
...
Merge release 2.10.2 into 2.11.x
2021-10-21 20:49:48 +02:00
Grégoire Paris
81d472f6f9
Merge pull request #9139 from greg0ire/upgrade-workflows
...
Upgrade workflows to 1.1.1
2021-10-21 19:57:02 +02:00
Grégoire Paris
d458968cee
Upgrade workflows to 1.1.1
...
That version fixes a bug with the release workflow. Releasing is not
possible unless we do that upgrade.
2021-10-21 19:55:57 +02:00
Alexander M. Turek
b6a2257758
Merge 2.10.x into 2.11.x ( #9137 )
2021-10-21 19:50:56 +02:00
Christophe Coevoet
5eb01da0a0
Fix the upgrade guide for 2.8 changes ( #9138 )
2021-10-21 16:44:42 +02:00
Grégoire Paris
5aaf361139
Merge pull request #9136 from greg0ire/revert-bc-break
...
Revert "Removing all the occurence of any"
2021-10-21 08:49:18 +02:00
Alexander M. Turek
6a8dcbc392
Regenerate Psalm baseline ( #9135 )
2021-10-20 23:30:57 +02:00
Grégoire Paris
12babcc1c2
Revert "Removing all the occurence of any"
...
This reverts commit 84afd6c937 , because it
is a BC-break that seems to affect more people than we originally
thought it would.
2021-10-20 23:12:01 +02:00
Thomas Landauer
416aa1d2d7
Explaining the two major ways to register an event v2 ( #9128 )
...
Co-authored-by: Javier Spagnoletti <phansys@gmail.com >
2021-10-16 11:45:10 +02:00
Alexander M. Turek
06d9c584a3
Merge 2.10.x into 2.11.x ( #9127 )
2021-10-15 18:41:04 +02:00
Grégoire Paris
8e16bb4ddc
Merge pull request #9126 from greg0ire/explicitly-pass-secrets
...
Explicitly pass secrets
2021-10-14 23:45:30 +02:00
Grégoire Paris
e1dee439bb
Explicitly pass secrets
...
Secrets are sensitive and not passed implicitly.
2021-10-14 23:35:29 +02:00
Thomas Landauer
e313d012ae
Overview table for events ( #9039 )
...
* Overview table for events
Better late than never - finally delivering what I announced at https://github.com/doctrine/orm/pull/8435#issuecomment-769940427 :-)
* Update events.rst
* Update events.rst
* Adding "Lifecycle Callback" column
* Update events.rst
2021-10-14 10:58:07 +02:00
Javier Spagnoletti
dede619b9e
Add "@method" annotation for wrapInTransaction() method at EntityManagerInterface ( #9091 )
2021-10-13 20:18:50 +02:00
Grégoire Paris
142cfb39fc
Merge pull request #9114 from greg0ire/try-out-reusable-workflows
...
Directly reference upstream CS workflow
2021-10-11 21:00:41 +02:00
Alexander M. Turek
53d41a456a
PHP CodeSniffer 3.6.1 ( #9115 )
2021-10-11 12:05:46 +02:00
Grégoire Paris
95b34ca940
Directly reference some upstream workflows
2021-10-10 21:08:57 +02:00
Paul Capron
3eaf76eebd
Fix typo & minor issues in dql-custom-walkers.rst ( #9113 )
2021-10-09 23:29:38 +02:00
Grégoire Paris
5c12d36be3
Merge pull request #9107 from BackEndTea/patch-1
...
Remove the twitter #doctrine2 hashtag refference
2021-10-07 22:35:44 +02:00
Grégoire Paris
1ee68eb318
Merge pull request #9098 from ajgarlag/bugfix-indexed-iterable
...
Honor INDEX BY construct in Query::toIterable
2021-10-07 22:34:54 +02:00
orklah
705c7f0a4b
[Psalm] always true/false conditions ( #9108 )
2021-10-07 20:21:58 +02:00
Gert de Pagter
8c5e49efc0
Remove the twitter #doctrine2 hashtag refference
...
Looking at twitter, the hashtag its hardly used. There was 1 question posted in the last year, and it went unanswered.
The `2` part has mostly been dropped everywhere, and orm is now just refered to doctrine orm instead of doctrine2
2021-10-07 16:12:06 +02:00
Antonio J. García Lagar
483e09cf1c
Fix Query::toIterable to honor INDEX BY construct
2021-10-07 13:02:22 +02:00
Benjamin Morel
bbb68d0072
Fix SchemaValidator with abstract child class in discriminator map ( #9096 )
2021-10-06 22:35:51 +02:00
Alexander M. Turek
b0381b3705
Merge release 2.10.1 into 2.11.x ( #9092 )
2021-10-05 15:12:04 +02:00
Knallcharge
f346379c7b
Add integer cast in setFirstResult methods of Query and QueryBuilder ( #9090 )
2021-10-05 15:04:30 +02:00
Michael Telgmann
b1c31e1aac
Add integer cast in setMaxResults methods of Query and QueryBuilder ( #9079 )
2021-10-04 23:00:38 +02:00
Grégoire Paris
02b6f9c335
Merge pull request #9084 from annechko/patch-1
...
Update phpdoc comment - association-mapping.rst
2021-10-04 21:59:30 +02:00
Anna Borzenko
d14d9919c7
Update phpdoc comment
2021-10-04 21:50:03 +02:00
Alexander M. Turek
3984f74eb4
Deprecate ensureProductionSettings() ( #9074 )
2021-10-04 10:00:34 +02:00
Alexander M. Turek
ebdced6175
Deprecate AbstractHydrator::hydrateRow() ( #9072 )
2021-10-03 21:46:30 +00:00
Grégoire Paris
1a702075ba
Merge pull request #9071 from doctrine/2.10.x
...
Merge up
2021-10-03 22:49:21 +02:00
Grégoire Paris
bd79e3d383
Merge pull request #9068 from greg0ire/update-branch-metadata
...
Reflect latest minor release in metadata
2021-10-03 22:48:37 +02:00
Grégoire Paris
10f72417c9
Reflect latest minor release in metadata
2021-10-03 21:12:59 +02:00
Grégoire Paris
87ad869a8a
Merge pull request #9067 from greg0ire/use-latest-laminas-release
...
Use latest laminas release
2021-10-03 21:08:55 +02:00
Grégoire Paris
bc4659b73c
Revert "Pin laminas/automatic-releases to 1.11.1"
...
This reverts commit e800f90d7c .
2021-10-03 20:56:35 +02:00
Grégoire Paris
4eab6536c3
Revert "Try using docker image directly"
...
This reverts commit ddcea63d0f .
2021-10-03 20:56:27 +02:00
Grégoire Paris
1571c8a781
Revert "Explicitly disallow workflows for tags"
...
This reverts commit bbe4022566 .
2021-10-03 20:56:12 +02:00
Grégoire Paris
20a65cbe32
Revert "Use org admin token"
...
This reverts commit e8a221d227 .
2021-10-03 20:55:17 +02:00
Grégoire Paris
07e15a0038
Merge pull request #9065 from greg0ire/2.10.x
...
Merge up
2021-10-03 17:14:07 +02:00
Grégoire Paris
5918cfaa20
Merge remote-tracking branch 'origin/2.9.x' into 2.10.x
2021-10-03 17:13:24 +02:00
Grégoire Paris
73fa465c26
Merge pull request #9064 from greg0ire/use-org-token
...
Use org admin token
2021-10-03 17:09:48 +02:00
Grégoire Paris
e8a221d227
Use org admin token
...
My previous attempts to disallow running a workflow when pushing a tag
failed, so let's ensure we can run said workflow. Maybe we will be able
to understand why it happened after it happens.
2021-10-03 17:08:50 +02:00
Grégoire Paris
b734a7d155
Merge pull request #9063 from greg0ire/explicitly-disallow-workflows-for-tags
...
Explicitly disallow workflows for tags
2021-10-03 17:02:04 +02:00
Grégoire Paris
bbe4022566
Explicitly disallow workflows for tags
...
Despite what is described in the docs, it seems that there is still an
attempt to run a workflow for tags.
2021-10-03 17:01:08 +02:00
Grégoire Paris
63f3abfbe8
Avoid triggering workflows for tags
...
To avoid recursive workflows, Github will prevent the release bot from
pushing tags because that would result in a new workflow being triggered.
2021-10-03 16:41:29 +02:00
Grégoire Paris
22added5fa
Merge pull request #9062 from greg0ire/dont-run-workflows-for-tags
...
Avoid triggering workflows for tags
2021-10-03 16:39:43 +02:00
Grégoire Paris
3a3b53e11d
Avoid triggering workflows for tags
...
To avoid recursive workflows, Github will prevent the release bot from
pushing tags because that would result in a new workflow being triggered.
2021-10-03 16:36:46 +02:00
Grégoire Paris
ddcea63d0f
Try using docker image directly
2021-10-03 16:23:22 +02:00
Grégoire Paris
e800f90d7c
Pin laminas/automatic-releases to 1.11.1
...
1.12.0 and up comes with a migration to azjezz/psl that makes it
impossible to troubleshoot issues with external commands such as git push
2021-10-03 15:09:18 +02:00
Grégoire Paris
6d16147d60
Merge pull request #9061 from greg0ire/revert-to-older-automatic-releases
...
Revert to older automatic releases
2021-10-03 15:06:41 +02:00
Grégoire Paris
9ed1fe59f2
Pin laminas/automatic-releases to 1.11.1
...
1.12.0 and up comes with a migration to azjezz/psl that makes it
impossible to troubleshoot issues with external commands such as git push
2021-10-03 14:49:00 +02:00
Alexander M. Turek
f805526336
Deprecate isIdGeneratorTable and isIdentifierUuid ( #9046 )
2021-10-03 12:18:53 +02:00
Alexander M. Turek
2e86134c0b
Merge branch '2.9.x' into 2.10.x
...
* 2.9.x:
Run PHP 8.1 CI with stable dependencies (#9058 )
Duplicate testTwoIterateHydrations (#9048 )
Add PHP 8.1 to CI (#9006 )
Fix locking non-existing entity (#9053 )
Signed-off-by: Alexander M. Turek <me@derrabus.de >
2021-10-02 21:22:45 +02:00
Alexander M. Turek
5f768742a0
Run PHP 8.1 CI with stable dependencies ( #9058 )
2021-10-02 19:37:08 +02:00
Alexander M. Turek
7a8c086d44
Add PHP 8.1 to CI ( #9057 )
2021-10-02 18:01:18 +02:00
Alexander M. Turek
1d4e12bc6b
Duplicate testTwoIterateHydrations ( #9048 )
2021-10-02 17:45:29 +02:00
Alexander M. Turek
70b0f50d13
Add PHP 8.1 to CI ( #9006 )
...
Signed-off-by: Alexander M. Turek <me@derrabus.de >
2021-10-02 17:20:20 +02:00
Grégoire Paris
149c4308bb
Merge pull request #9056 from derrabus/improvement/foreign-key-get-columns
...
Remove calls to `ForeignKeyConstraint::getColumns()`
2021-10-02 17:14:03 +02:00
Alexander M. Turek
9d4fac088c
Remove calls to ForeignKeyConstraint::getColumns()
...
Signed-off-by: Alexander M. Turek <me@derrabus.de >
2021-10-02 17:05:16 +02:00
Alexander M. Turek
eb27acaa65
Update documentation regarding caching ( #9043 )
2021-09-30 23:30:49 +02:00
Csupity Laszlo
2362aa1a7a
Fix locking non-existing entity ( #9053 )
2021-09-30 23:29:34 +02:00
Kévin Dunglas
f414e57d82
fix: prevent TypeError in QueryBuilder joins ( #9050 )
2021-09-30 06:03:33 +00:00
Alexander M. Turek
13543df649
Merge pull request #9049 from derrabus/merge/2.9.x
...
Merge 2.9.x into 2.10.x
2021-09-29 23:15:15 +02:00
Alexander M. Turek
1d7fdde81d
Merge branch '2.9.x' into merge/2.9.x
...
* 2.9.x:
Minor rewording (#8435 )
Don't presume one-to-one lookup returned an entity (#9028 )
Minor change about double The (#9038 )
Remove duplicate comment (#9036 )
Fix docblock types for some nullable properties (#9024 )
Explicitly allow to use `Comparison` and `Composite` in JOIN conditions (#9022 )
Fix some typehints in QueryBuilder
Bump PHPStan (#9014 )
Add tests for advanced types in collection matching
Use types in collection persister
Signed-off-by: Alexander M. Turek <me@derrabus.de >
2021-09-29 20:33:01 +02:00
Thomas Landauer
5326736571
Minor rewording ( #8435 )
...
Emphasizing the (counter-intuitive) fact that preUpdate is called inside **flush** - cause this was causing me some confusion, see https://github.com/symfony/symfony/issues/39894
2021-09-28 09:41:16 +02:00
Greg Tyler
78d07b0bd2
Don't presume one-to-one lookup returned an entity ( #9028 )
...
If `$this->em->find()` returns null, don't treat it like an object. Instead, just set the field to null and back out of the switch statement.
Fixes #9027
2021-09-27 12:43:35 +02:00
Loenix
51ff4713b3
Minor change about double The ( #9038 )
2021-09-27 08:50:16 +00:00
Jérémy
c0f70204d1
Remove duplicate comment ( #9036 )
2021-09-23 12:47:01 +00:00
Javier Spagnoletti
2575aa5120
Fix docblock types for some nullable properties ( #9024 )
2021-09-22 23:48:49 +02:00
Javier Spagnoletti
1f6401ee0a
Explicitly allow to use Comparison and Composite in JOIN conditions ( #9022 )
2021-09-20 06:09:05 +02:00
Grégoire Paris
248ff82f83
Merge pull request #9017 from norkunas/fix-typehints
...
Fix some typehints in QueryBuilder
2021-09-16 16:44:29 +01:00
Tomas
f1db7d7fa2
Fix some typehints in QueryBuilder
2021-09-16 15:26:18 +03:00
Alexander M. Turek
0bcc3ee4e9
Bump PHPStan ( #9014 )
2021-09-15 15:46:59 +02:00
Grégoire Paris
0bd651abda
Merge pull request #9010 from sztyup/2.9.x
...
Fix ignoring custom types for PersistentCollection matching()
2021-09-15 08:02:57 +01:00
Alexander M. Turek
334ca18171
Document fluent interfaces ( #9009 )
2021-09-13 21:25:33 +02:00
Laszlo_Csupity
ff978ce4d8
Add tests for advanced types in collection matching
2021-09-13 13:56:13 +02:00
Laszlo_Csupity
128ebe630b
Use types in collection persister
2021-09-13 13:55:41 +02:00
Alexander M. Turek
6371081593
Use PSR-6 for accessing the query cache ( #9004 )
2021-09-13 12:39:32 +02:00
Alexander M. Turek
31d8bd7a5e
Merge pull request #9008 from greg0ire/2.10.x
...
Merge 2.9.x up into 2.10.x
2021-09-13 12:16:40 +02:00
Grégoire Paris
dee58cfefd
Merge remote-tracking branch 'origin/2.9.x' into 2.10.x
2021-09-13 12:07:43 +02:00
Grégoire Paris
71f1fdb668
Merge pull request #9007 from derrabus/test/query-get-cache
...
Add tests for Query::getQueryCacheDriver()
2021-09-13 11:06:04 +01:00
Alexander M. Turek
85488d69e2
Add tests for Query::getQueryCacheDriver()
...
Signed-off-by: Alexander M. Turek <me@derrabus.de >
2021-09-13 10:08:58 +02:00
Alexander M. Turek
5c7e6689fc
Switch cache configuration to PSR-6 ( #9002 )
2021-09-11 23:16:31 +02:00
Grégoire Paris
5b3fb6ac56
Merge pull request #8999 from derrabus/merge/2.9.x
...
Merge 2.9.x into 2.10.x
2021-09-11 16:36:44 +01:00
Alexander M. Turek
65839235ce
Merge branch '2.9.x' into merge/2.9.x
...
* 2.9.x:
Remove Proxy from EntityManagerInterface contract
Add extension point for the "embedded" XML node (#8992 )
Fix return type at `EntityManagerInterface::get(Partial)Reference()` (#8922 )
Fix class casing and avoid name collisions
Remove unused performance base test class
Drop unused test base classes
Fix mapped superclass missing in discriminator map
2021-09-11 16:53:52 +02:00
Grégoire Paris
d1cd8047fa
Merge pull request #9001 from derrabus/sa/em-get-reference
...
Remove Proxy from EntityManagerInterface contract
2021-09-11 15:33:26 +01:00
Alexander M. Turek
90ed9f5387
Remove Proxy from EntityManagerInterface contract
...
Signed-off-by: Alexander M. Turek <me@derrabus.de >
2021-09-11 15:23:14 +02:00
Javier Spagnoletti
04d28a9362
Add extension point for the "embedded" XML node ( #8992 )
2021-09-11 14:17:37 +02:00
Grégoire Paris
fb89129fb2
Merge pull request #9000 from derrabus/bugfix/missing-imports
...
Fix class casing and avoid name collisions
2021-09-11 12:55:07 +01:00
Simon Podlipsky
399b69a309
Fix return type at EntityManagerInterface::get(Partial)Reference() ( #8922 )
2021-09-11 13:53:20 +02:00
Grégoire Paris
01ab70d204
Merge pull request #8996 from derrabus/improvement/psr6-result-cache
...
Support for PSR-6 result caches
2021-09-11 12:53:09 +01:00
Alexander M. Turek
45553556d5
Fix class casing and avoid name collisions
2021-09-11 13:41:46 +02:00
Alexander M. Turek
996fa777bd
Support for PSR-6 result caches
...
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr >
2021-09-11 13:20:37 +02:00
Grégoire Paris
dc1336dbc2
Include the DBAL version in coverage filenames ( #8998 )
...
Currently, files from different jobs probably overwrite each other.
2021-09-11 13:03:55 +02:00
Alexander M. Turek
b1f89a5cb8
Merge pull request #8997 from greg0ire/drop-unused-classes
2021-09-10 22:15:58 +02:00
Grégoire Paris
48f7abf697
Remove unused performance base test class
...
It is unused since b960170fe1
2021-09-10 21:13:32 +02:00
Grégoire Paris
2159fbee56
Drop unused test base classes
...
They are no longer needed since e4c7fa961e
2021-09-10 21:13:24 +02:00
Grégoire Paris
7fcab3d52e
Merge pull request #8903 from olsavmic/fix-schema-validator-for-mapped-superclass-inheritance
...
SchemaValidator: Fix mapped superclass missing in discriminator map
2021-09-08 17:25:23 +01:00
Grégoire Paris
2d42d7835d
Merge pull request #8919 from bhushan/feat/add-get-flat-array-results-by-key-for-query
...
feat(ScalarColumnHydrator): added ScalarColumnHydrator to get flat array results from query for single column
2021-09-08 17:02:58 +01:00
Bhushan
ed83825223
feat(ScalarColumnHydrator): get one dimensional array values for single column
2021-09-08 17:32:35 +02:00
Alexander M. Turek
beee34055a
Merge pull request #8991 from derrabus/merge/2.9.x
...
Merge 2.9.x into 2.10.x
2021-09-08 09:07:18 +02:00
Alexander M. Turek
7abd106c8a
Merge branch '2.9.x' into merge/2.9.x
...
* 2.9.x:
Restore functional cache tests (#8981 )
Fix English in `note`. (#8987 )
Remove detach deprecation entry in UPGRADE.md (#8978 )
Bump to PHPStan 0.12.98 and Psalm 4.10.0 (#8979 )
Signed-off-by: Alexander M. Turek <me@derrabus.de >
2021-09-08 08:57:00 +02:00
Alexander M. Turek
be2208f208
Remove unnecessary method_exists() checks ( #8984 )
2021-09-07 22:45:44 +02:00
Alexander M. Turek
316ba5f75e
Restore functional cache tests ( #8981 )
2021-09-07 22:45:12 +02:00
ash-m
a08b6306d3
Fix English in note. ( #8987 )
...
Improper agreement; either:
- Doctrine does not EVER touch ...
- Doctrine NEVER touches ...
2021-09-07 22:44:43 +02:00
Simon Berger
21e71af13f
Remove detach deprecation entry in UPGRADE.md ( #8978 )
2021-09-06 19:46:48 +02:00
Alexander M. Turek
f352b2a7ed
Bump to PHPStan 0.12.98 and Psalm 4.10.0 ( #8979 )
2021-09-06 15:14:20 +02:00
Grégoire Paris
7bf1ad1a5a
Merge pull request #8964 from derrabus/feature/dbal-3
...
DBAL 3
2021-08-31 22:42:46 +02:00
Alexander M. Turek
9de601f377
Merge pull request #8966 from doctrine/2.9.x
...
Merge 2.9.x into 2.10.x
2021-08-30 00:34:08 +02:00
carnage
df5086196f
Added clarification of using change tracking policy on entities with embeddables ( #7495 )
...
* Added clarification of using change tracking policy on entities with embeddables
* Apply suggestions from code review
Co-Authored-By: carnage <carnage@users.noreply.github.com >
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr >
2021-08-29 23:44:14 +02:00
Grégoire Paris
a427d7d852
Merge pull request #8961 from greg0ire/drop-table
...
Deprecate / remove TABLE id generator strategy
2021-08-29 23:43:09 +02:00
Grégoire Paris
efbcca3cb6
Get dbname from connection params first
...
Getting the database name from a connection object results in a PDO
object being created, which might in turn result in an error message if
the database does not exist. For instance it does with PostgreSQL.
In some other situations, like when using sqlite, there is no database
name though, so we still have to fallback on the previous behavior.
2021-08-29 21:08:17 +02:00
Alexander M. Turek
c65cc91f5b
Support for DBAL 3
2021-08-29 21:08:17 +02:00
Grégoire Paris
d5f65ba62e
Merge pull request #8962 from greg0ire/dont-swallow-exceptions
...
Stop swallowing exceptions
2021-08-29 20:54:57 +02:00
Grégoire Paris
ef9c984bcd
Merge pull request #8946 from derrabus/bugfix/dbal-3-platforms
...
Support for DBAL 3's platform classes
2021-08-29 16:07:49 +02:00
Grégoire Paris
3074a4b02d
Merge pull request #8932 from greg0ire/drop-support-for-generating-json-array-fields
...
Drop support for generating json array fields
2021-08-29 15:48:17 +02:00
Alexander M. Turek
fdbc6b6c13
Support for DBAL 3's platform classes
...
Signed-off-by: Alexander M. Turek <me@derrabus.de >
2021-08-29 15:27:28 +02:00
Grégoire Paris
ea584992d5
Drop support for generating JSON_ARRAY fields
...
JSON_ARRAY has been deprecated in favor of JSON for a while, we should
not encourage people to generate new entities with it, since it will
introduce technical debt for them.
Support for JSON is added instead.
2021-08-29 14:40:29 +02:00
Grégoire Paris
96b4c763e4
Stop swallowing exceptions
...
This was probably done in order to get rid of exceptions about tables
already existing, but may and does swallow other exceptions as well, for
instance exceptions about sequences failing to be created on Oracle
because the identifier is too long. This makes it unnecessarily hard to
understand what is going on.
2021-08-28 18:02:41 +02:00
Grégoire Paris
0b55275418
Deprecate / remove TABLE id generator strategy
...
This strategy has been marked as TODO for more than 14 years. It should
be OK to remove some things related to it since they lead to an
exception being thrown.
2021-08-28 11:02:06 +02:00
Grégoire Paris
1963733311
Merge pull request #8959 from norkunas/fix-typehint
...
Fix `getEntityChangeSet` return typehint
2021-08-27 08:27:04 +02:00
Grégoire Paris
a06bbafd6a
Merge pull request #8957 from derrabus/remove/connection-helper
...
Only wire ConnectionHelper if it's available
2021-08-25 19:33:54 +02:00
Grégoire Paris
250f7acc98
Merge pull request #8960 from inarli/2.9.x
...
Fix typo
2021-08-25 19:32:36 +02:00
İlkay Narlı
82f8a7c56a
Fix typo
2021-08-25 17:54:14 +03:00
Alexander M. Turek
b345488272
Remove calls to fixSchemaElementName() ( #8941 )
2021-08-25 15:06:06 +02:00
Tomas
1de4020dc9
Fix getEntityChangeSet return typehint
2021-08-25 12:38:44 +03:00
Alexander M. Turek
dc6ed8716d
Only wire ConnectionHelper if it's available
...
Signed-off-by: Alexander M. Turek <me@derrabus.de >
2021-08-24 16:34:00 +02:00
Grégoire Paris
a8a9b2ae75
Merge pull request #8953 from derrabus/improvement/create-schema-manager
...
Don't call deprecated `getSchemaManager()`
2021-08-24 08:21:25 +02:00
Grégoire Paris
e03a30bd85
Merge pull request #8954 from derrabus/bugfix/dbal-exception
...
Fix references to deprecated `DBALException`
2021-08-24 08:19:26 +02:00
Alexander M. Turek
16357c5666
Fix references to deprecated DBALException
...
Signed-off-by: Alexander M. Turek <me@derrabus.de >
2021-08-24 04:59:12 +02:00
Alexander M. Turek
131cc17384
Don't call deprecated getSchemaManager()
...
Signed-off-by: Alexander M. Turek <me@derrabus.de >
2021-08-24 04:41:36 +02:00
Grégoire Paris
c18b474bbf
Merge pull request #8934 from derrabus/remove/sql-result-casing
...
Remove calls to `AbstractPlatform::getSQLResultCasing()`
2021-08-23 20:46:40 +02:00
Grégoire Paris
e3b1ad5591
Merge pull request #8935 from derrabus/improvement/deprecated-calls
...
Remove calls to deprecated Connection methods
2021-08-23 18:32:14 +02:00
Alexander M. Turek
e6f1bb7dad
Remove calls to AbstractPlatform::getSQLResultCasing()
2021-08-23 16:55:33 +02:00
Alexander M. Turek
730143e39b
Remove calls to deprecated Connection methods
2021-08-23 16:54:59 +02:00
Alexander M. Turek
5cd00a50b2
Remove UUID generator strategy from fixtures ( #8947 )
2021-08-23 16:47:19 +02:00
Alexander M. Turek
3b8b3f9034
Remove ImportCommand from console ( #8948 )
2021-08-23 16:41:25 +02:00
Alexander M. Turek
bbe0b17b93
Don't pass false as lock mode to appendLockHint() ( #8937 )
2021-08-23 16:25:49 +02:00
Alexander M. Turek
7446569cf4
Remove remaining call to prefersSequences() ( #8942 )
2021-08-23 16:24:35 +02:00
Alexander M. Turek
930c2e093c
Remove calls to EchoSQLLogger ( #8940 )
2021-08-23 16:23:34 +02:00
Alexander M. Turek
2154b513af
Make mock layer compatible with DBAL 3 ( #8949 )
2021-08-23 16:22:43 +02:00
Grégoire Paris
93508438fa
Merge pull request #8945 from greg0ire/document-possible-null-variable
2021-08-23 14:22:41 +02:00
Grégoire Paris
1490b2c3bb
Merge pull request #8952 from greg0ire/ditch-simple-annotation-reader-2
2021-08-23 14:20:40 +02:00
Grégoire Paris
760abfc316
Drop more usages of SimpleAnnotationReader
2021-08-23 14:05:52 +02:00
Grégoire Paris
a1c15778ae
Merge pull request #8951 from doctrine/2.9.x-merge-up-into-2.10.x_Ryg07QLG
2021-08-23 13:05:04 +02:00
Grégoire Paris
4f9c104ec9
Merge tag '2.9.5' into 2.9.x-merge-up-into-2.10.x_Ryg07QLG
...
2.9.x bugfix release (patch)
- Total issues resolved: **0**
- Total pull requests resolved: **2**
- Total contributors: **2**
- [8930: Introduce 2.10 to readme](https://github.com/doctrine/orm/pull/8930 ) thanks to @SenseException
- [8895: Implement __serialize() and __unserialize()](https://github.com/doctrine/orm/pull/8895 ) thanks to @derrabus
2021-08-23 12:35:37 +02:00
Grégoire Paris
77cc86ed88
Merge pull request #8916 from greg0ire/failing-test-8914
...
Check current class' discriminator map
2021-08-23 12:20:22 +02:00
Grégoire Paris
627113dc60
Merge pull request #8950 from derrabus/bump/phpstan
...
PHPStan 0.12.96
2021-08-23 00:02:24 +02:00
Alexander M. Turek
234829644c
PHPStan 0.12.96
...
Signed-off-by: Alexander M. Turek <me@derrabus.de >
2021-08-22 23:45:59 +02:00
Grégoire Paris
af4ecbadab
Document possibly-null member variables
...
Many of the variables in AbstractHydrator are not initialized in the
constructor, and should be documented as possibly null because of that.
Introducing accessors that perform null checks allows to to have to do
these null checks when using the accessors.
Making the member variables private would be a backwards-compatibility
break and could be considered for the next major version.
This makes Psalm's and PHPStan's baselines smaller, and should make
implementing new hydrators easier.
2021-08-22 22:12:00 +02:00
Grégoire Paris
b20743b352
Merge pull request #8943 from simPod/wrap-types
...
Add missing EntityManagerInterface argument to callable that is being passed to `EM::wrapInTransaction()`
2021-08-22 18:17:41 +02:00
Grégoire Paris
e546cdef51
Merge pull request #8944 from derrabus/bugfix/datetime-constant
...
Remove references to `Type::DATETIME`
2021-08-22 18:10:22 +02:00
Alexander M. Turek
5f3e17152b
Remove references to Type::DATETIME
...
Signed-off-by: Alexander M. Turek <me@derrabus.de >
2021-08-22 17:43:07 +02:00
Simon Podlipsky
0d6ff230da
Add missing EntityManagerInterface argument to callable that is being passed to EM::wrapInTransaction()
2021-08-22 17:26:57 +02:00
Grégoire Paris
14da92cf6b
Merge pull request #8939 from derrabus/remove/driver-get-name
...
Remove calls to `Driver::getName()`
2021-08-22 16:27:48 +02:00
Grégoire Paris
563f3bdd85
Merge pull request #8938 from derrabus/bump-psalm
...
Bump Psalm to 4.9.3
2021-08-22 16:26:56 +02:00
Marcin Czarnecki
8bed63090b
Throw exception NotSupported Exception for UuidGenerator with doctrine/dbal:3.x. ( #8898 )
...
Generating `getGuidExpression` has been removed in doctrine/dbal:3.x.
Partially fixes #8884
2021-08-22 16:05:22 +02:00
Alexander M. Turek
4f28ad6ccc
Remove calls to Driver::getName()
...
Signed-off-by: Alexander M. Turek <me@derrabus.de >
2021-08-22 15:56:18 +02:00
Alexander M. Turek
3f98633704
Bump Psalm to 4.9.3
...
Signed-off-by: Alexander M. Turek <me@derrabus.de >
2021-08-22 15:43:55 +02:00
Grégoire Paris
e7758866c9
Merge pull request #8936 from derrabus/bugfix/reset-baseline
...
Reset Psalm baseline
2021-08-22 14:51:30 +02:00
Alexander M. Turek
1b1d1a246f
Reset Psalm baseline
...
Signed-off-by: Alexander M. Turek <me@derrabus.de >
2021-08-22 14:18:08 +02:00
Grégoire Paris
db175020e0
Merge pull request #8928 from simPod/wrap-types
...
Add types to `EM::wrapInTransaction()`
2021-08-21 16:06:49 +02:00
Grégoire Paris
1de28c2cab
Merge pull request #8930 from doctrine/2.10-readme
...
Introduce 2.10 to readme
2021-08-21 16:05:17 +02:00
Claudio Zizza
565987f583
Introduce 2.10 to readme
2021-08-20 21:14:25 +02:00
Simon Podlipsky
44bea09b10
Add types to EM::wrapInTransaction()
2021-08-19 16:35:22 +02:00
Grégoire Paris
ae10af0259
Check current class' discriminator map
...
A class can be in its own discriminator map, as described in the
documentation example at
https://www.doctrine-project.org/projects/doctrine-orm/en/2.9/reference/inheritance-mapping.html#single-table-inheritance
Checking only the current class' discriminator map should be enough,
since it is set to a copy of its parent's discriminator map earlier.
Fixes #8914
2021-08-15 11:59:11 +02:00
Grégoire Paris
d636d79686
Merge pull request #8895 from derrabus/bugfix/serializable
...
Implement __serialize() and __unserialize()
2021-08-15 11:56:49 +02:00
Grégoire Paris
aee197f027
Merge pull request #8904 from carnage/refactoring-tests-backport
...
Refactoring more tests
2021-08-14 21:22:49 +02:00
Carnage
38c0f2b205
Change assertion order to ensure query count is tested correctly
2021-08-14 14:14:11 +01:00
Carnage
3dfbce1f40
Tidy up CS errors
2021-08-14 13:57:39 +01:00
Carnage
ad2cbd6afe
Fix PHP Unit deprecations and removed methods
2021-08-14 13:31:55 +01:00
Gabriel Caruso
f34215d56a
Refactoring more tests
2021-08-14 11:46:47 +01:00
Grégoire Paris
163aef158b
Merge pull request #8915 from basseta/address-type-deprecation
...
Address Type deprecation messages
2021-08-12 23:13:56 +02:00
Antoine BASSET
40f613199a
Address Type deprecation messages
...
This makes us more compatible with DBAL v3.
We didn't address Type::JSON_ARRAY because it has been removed
2021-08-12 17:11:41 +02:00
Grégoire Paris
ed230264fb
Merge pull request #8913 from doctrine/2.9.x-merge-up-into-2.10.x_GK8LNgB8
...
Merge release 2.9.4 into 2.10.x
2021-08-11 23:32:36 +02:00
Vincent Langlet
b19a13f4ed
Override getAssociationTargetClass phpdoc ( #8907 )
...
The upstream interface now allows null to be returned, but this
implementation never returns null, and consumers are expecting it not
to.
2021-08-11 22:53:03 +02:00
Grégoire Paris
03948f891e
Merge pull request #8911 from greg0ire/2.10.x
...
Merge 2.9.x up into 2.10.x
2021-08-11 22:23:44 +02:00
Grégoire Paris
7dfa140542
Remove uneeded assertion
2021-08-11 22:14:33 +02:00
Grégoire Paris
01e7e45744
Merge remote-tracking branch 'origin/2.9.x' into 2.10.x
2021-08-11 22:11:32 +02:00
Grégoire Paris
1e2c0ce72d
Merge pull request #8909 from greg0ire/fix-build
...
Fix build
2021-08-11 22:08:05 +02:00
Grégoire Paris
6a6bcc1e2b
Ignore error caused by upstream package
...
See https://github.com/doctrine/collections/pull/282
2021-08-11 21:48:09 +02:00
Grégoire Paris
e2f54f6fa6
Remove phpstan-specific annotation
...
This is a direct consequence of https://github.com/doctrine/collections/pull/274
2021-08-11 21:48:09 +02:00
Grégoire Paris
e16a768916
Adapt baseline to new error message
...
The signature has become more precise, and so has the error message.
2021-08-11 21:48:03 +02:00
Benjamin Eberlei
25135d429f
Merge 2.9.x into 2.10.x
2021-08-11 20:21:39 +02:00
Grégoire Paris
3b9e04e971
Merge pull request #8905 from nicolas-grekas/ret-types
...
Add explicit `@return` type next to `#[ReturnTypeWillChange]`
2021-08-11 00:13:16 +02:00
Grégoire Paris
7c1593742c
Merge pull request #8870 from derrabus/improvement/prefers-sequences
...
Remove calls to prefersSequences()
2021-08-10 23:24:26 +02:00
Nicolas Grekas
fca1f5240d
Add explicit @return type next to #[ReturnTypeWillChange]
2021-08-10 18:51:46 +02:00
Michael Olšavský
5685dc05f6
Fix mapped superclass missing in discriminator map
2021-08-09 16:24:37 +02:00
Grégoire Paris
4fa2f6baa4
Merge pull request #8896 from derrabus/bugfix/dont-pass-null
...
Don't pass null as parameter
2021-08-09 08:19:12 +02:00
Grégoire Paris
245563e1cf
Merge pull request #8894 from derrabus/bugfix/return-type-will-change
...
Fix return types for PHP 8.1
2021-08-09 08:18:46 +02:00
Grégoire Paris
f980682829
Merge pull request #8897 from scyzoryck/dbal-3-fix-connection-params
...
Redeclare `$_attributes` property in `Configuration` class.
2021-08-09 08:18:10 +02:00
Grégoire Paris
b600c01bca
Merge pull request #8419 from simPod/more-tests
...
Introduce `EntityManagerInterface#wrapInTransaction()`
2021-08-08 22:45:14 +02:00
Grégoire Paris
ad43cc04ff
Merge pull request #8900 from simPod/psalm-10
...
Regenerate psalm baseline
2021-08-08 18:01:39 +02:00
Simon Podlipsky
c45402c1eb
Regenerate psalm baseline
2021-08-08 17:48:07 +02:00
Grégoire Paris
a35ce43a61
Merge pull request #8902 from greg0ire/2.10.x
...
Merge 2.9.x into 2.10.x
2021-08-08 17:47:08 +02:00
Grégoire Paris
ed32b4c812
Merge remote-tracking branch 'origin/2.9.x' into 2.10.x
2021-08-08 17:38:45 +02:00
Grégoire Paris
a5436be939
Merge pull request #8899 from simPod/psalm
...
Regenerate psalm baseline
2021-08-08 17:13:19 +02:00
Simon Podlipsky
1246b3b5c3
Regenerate psalm baseline
2021-08-08 16:24:49 +02:00
Simon Podlipsky
4ad5d3edbd
Introduce Doctrine\ORM\EntityManagerInterface#wrapInTransaction()
2021-08-08 16:22:53 +02:00
scyzoryck
355a4a126b
Redeclare $_attributes property in Configuration class that has been removed in doctrine/dbal:3.x
...
To keep backward compatibility we need to redeclare this property to keep using it.
Partially fixes #8884
2021-08-08 12:22:16 +02:00
Alexander M. Turek
3464591763
Don't pass null as parameter
...
Signed-off-by: Alexander M. Turek <me@derrabus.de >
2021-08-08 01:39:43 +02:00
Alexander M. Turek
ae4bcd61ee
Implement __serialize() and __unserialize()
...
Signed-off-by: Alexander M. Turek <me@derrabus.de >
2021-08-08 01:24:06 +02:00
Alexander M. Turek
dc960d7d96
Fix return types for PHP 8.1
...
Signed-off-by: Alexander M. Turek <me@derrabus.de >
2021-08-08 01:10:58 +02:00
Grégoire Paris
7736429e9b
Merge pull request #8892 from derrabus/bump/phpstan
...
Bump PHPStan to 0.12.94
2021-08-08 00:08:21 +02:00
Alexander M. Turek
edaa05a217
Remove calls to prefersSequences()
...
Signed-off-by: Alexander M. Turek <me@derrabus.de >
2021-08-07 23:47:55 +02:00
Alexander M. Turek
7c6bea1307
Bump PHPStan to 0.12.94
...
Signed-off-by: Alexander M. Turek <me@derrabus.de >
2021-08-07 22:12:21 +02:00
Grégoire Paris
c4456a2863
Merge pull request #8889 from scyzoryck/dbal-3-fix-possibly-null-argument
...
doctrine/dbal v3 - Make sure that values passed to are not null
2021-08-05 23:58:20 +02:00
scyzoryck
2bf0f64295
Make sure that passed values (offset and lock mode) will not be a null to meet changes in doctrine/dbal v3.
...
Fix psalm issues with type: `PossiblyNullArgument`, found after updating doctrine/dbal to v3. Override `null` passed as offset with `0` in calls to `Doctrine\DBAL\Platforms\AbstractPlatform::modifyLimitQuery`. Override `null` passed as lockMode with `LockMode::NONE` in calls to `Doctrine\DBAL\Platforms\AbstractPlatform::appendLockHint`.
Partialy fixes #8884
2021-08-05 22:30:58 +02:00
Grégoire Paris
12705b5c3e
Merge pull request #8820 from beberlei/GH-8818-EntityNamespaceAliasDeprecation
...
[GH-8818] Deprecate entity namespace short aliases.
2021-08-05 19:49:39 +02:00
Benjamin Eberlei
913700b116
Remove alias in docs
2021-08-05 00:48:28 +02:00
Grégoire Paris
106ed8009a
Merge pull request #8883 from dopeh/patch-1
...
Fix getting-started example by including cache
2021-08-05 00:20:07 +02:00
Pep
b2e00f6086
Fix getting-started example by including cache
...
The getting started example does not work without a valid cache library, this adds symfony/cache.
2021-08-04 23:04:46 +02:00
Benjamin Eberlei
0540485b14
Update UPGRADE.md
2021-08-04 22:29:12 +02:00
Benjamin Eberlei
e5228ba66f
[GH-8818] Deprecate entity namespace short aliases.
2021-08-04 22:17:09 +02:00
Grégoire Paris
e09f126abf
Merge pull request #8852 from greg0ire/backport-6943
...
Remove possibility to extend the doctrine mapping xml schema with anything
2021-08-04 07:43:13 +02:00
Grégoire Paris
055b646d9a
Merge pull request #8769 from greg0ire/remove-unhelpful-template
...
Make templating Psalm-specific
2021-08-04 07:42:29 +02:00
Grégoire Paris
acdbbdacab
Merge pull request #8874 from greg0ire/build-with-dbal-3
...
Build with DBAL 3
2021-08-03 23:52:55 +02:00
Grégoire Paris
6a267f588c
Build with DBAL 3
...
Making these jobs green will not result in a comprehensive result of the
features, but it is a good start, and having them should give a good
overview of what is left to do.
2021-08-03 19:47:30 +02:00
Grégoire Paris
c1c3c89836
Merge pull request #8855 from piowin/GH8443-failing-test
...
Failing test for GH8443
2021-08-03 07:53:38 +02:00
Grégoire Paris
692277e72c
Merge pull request #8862 from carnage/this-to-self
...
Change $this->assert* to self::assert* in unit tests
2021-08-03 07:53:00 +02:00
Grégoire Paris
47267b0da5
Merge pull request #8875 from doctrine/2.9.x
...
Merge 2.9.x up into 2.10.x
2021-08-02 23:57:34 +02:00
Grégoire Paris
6fc0176f87
Merge pull request #8872 from simPod/fix-build
...
Fix CI SA failures
2021-08-02 23:48:02 +02:00
Grégoire Paris
8bb1454d5d
Merge pull request #8859 from greg0ire/backport-7110
...
Drop tools/sandbox
2021-08-02 19:13:22 +02:00
Simon Podlipsky
42126dc1bd
Fix CI SA failures
2021-08-02 18:30:31 +02:00
Grégoire Paris
5861b0575d
Merge pull request #8861 from carnage/dbal-compat
...
Fix compatibility with DBAL develop
2021-07-25 20:12:15 +02:00
Carnage
afe0d1c810
Change ->assert* to self::assert*
2021-07-24 19:10:38 +01:00
Grégoire Paris
bc9e0b3d2c
Merge pull request #8860 from t-richard/patch-1
...
Fix typo in "Working with Objects"
2021-07-24 14:55:58 +02:00
Michael Moravec
0b6ab2d1a7
Fix compatibility with DBAL develop
...
* ResultStatement signature BC break
* PDO::FETCH_* -> FetchMode::*
* PDO::PARAM_* -> ParameterType::*
* AbstractPlatform::DATE_INTERVAL_UNIT_* -> DateIntervalUnit::*
* AbstractPlatform::TRIM_* -> TrimMode::*
2021-07-24 13:24:39 +01:00
Thibault RICHARD
aa9d0148d5
Fix typo in "Working with Objects"
2021-07-24 14:13:29 +02:00
Michael Moravec
183f4a5211
Drop tools/sandbox
2021-07-24 10:31:50 +02:00
21skills
86703cbc73
Extra brackets if no cti joins fix
...
Continuation of a problem from
https://github.com/doctrine/orm/pull/6812
The same problem appears if you add WITH condition to the joined entity with discriminator
2021-07-23 21:27:05 +02:00
piowin
0504c535f1
Failing test for GH8443
2021-07-23 21:27:05 +02:00
mike
84afd6c937
Removing all the occurence of any
...
If someone wants to override the doctrine mapping that person should
write their own mapping file.
2021-07-21 19:48:11 +02:00
mike
7065070838
replacing all the sequence by choice
...
The order is never important in the declaration
2021-07-21 19:45:36 +02:00
Grégoire Paris
3e18990e90
Merge pull request #8851 from greg0ire/backport-7008
...
Remove unused exceptions
2021-07-21 07:45:28 +02:00
Grégoire Paris
6b481be074
Remove unused exceptions
2021-07-20 23:28:50 +02:00
Grégoire Paris
52f5528d3a
Merge pull request #8838 from carnage/remove-expensive-array-ops
...
Remove expensive array ops
2021-07-20 23:23:13 +02:00
Grégoire Paris
0db4a3936f
Merge pull request #8841 from greg0ire/strict_types
...
Enable strict mode
2021-07-20 23:19:35 +02:00
Grégoire Paris
ccc2993610
Merge pull request #8837 from greg0ire/backport-6878
...
Replace spl_object_hash() with spl_object_id()
2021-07-20 23:19:18 +02:00
Grégoire Paris
b7c0e97e71
Assert child property is not null
...
It is then passed to a class whose constructor cannot work with null.
2021-07-20 21:56:31 +02:00
Grégoire Paris
6c7e854797
Enable strict mode
2021-07-20 21:56:29 +02:00
Grégoire Paris
efb74f3ba3
Document possible return type
2021-07-20 21:56:11 +02:00
Grégoire Paris
270e7a4234
Pass strings to SimpleXMLELement::addAttribute()
2021-07-20 21:56:10 +02:00
Grégoire Paris
decbd93af4
Cast mode to string
...
It might be an integer, in fact it probably is, but the phpdoc says it
might be a string too.
2021-07-20 21:55:49 +02:00
Grégoire Paris
4770008cb7
Cast string value to float
...
round() becomes stricter with PHP 8 and no longer accepts strings.
2021-07-20 21:55:49 +02:00
Grégoire Paris
1413111099
Ensure walkLiteral returns a string
...
By contract, it is supposed to.
2021-07-20 21:55:45 +02:00
Grégoire Paris
60cf2c785f
Merge pull request #8846 from greg0ire/backport-6974
...
Use $strict param in functions that have it
2021-07-19 20:14:10 +02:00
Grégoire Paris
ee7ddac7a2
Merge pull request #8848 from greg0ire/2.10.x
...
Merge 2.9.x into 2.10.x
2021-07-18 12:39:24 +02:00
Grégoire Paris
e7de028d2d
Merge remote-tracking branch 'origin/2.9.x' into 2.10.x
2021-07-18 12:05:37 +02:00
Grégoire Paris
3c4009df38
Merge pull request #8847 from greg0ire/adapt-tests-to-new-wrapping
...
Adapt tests to new way of wrapping
2021-07-18 12:04:40 +02:00
Grégoire Paris
0a1be2cc21
Adapt tests to new way of wrapping
...
Namespacing is configured here, which means instead of just one layer,
we have a PSR cache wrapped in a doctrine cache with namespacing, itself
wrapped again with a PSR cache.
2021-07-18 11:00:46 +02:00
Grégoire Paris
e39a9ba199
Regenerate Psalm baseline
...
It looks like using --update-baseline can make number of occurences
drop, but will not result in a removal of some code elements.
2021-07-17 10:37:07 +02:00
Grégoire Paris
65a55cea7e
Use $strict param in functions that have it
2021-07-15 23:18:27 +02:00
Grégoire Paris
9e6bc35944
Merge pull request #8845 from greg0ire/backport-6929
...
[CS] Clean elses
2021-07-15 22:51:47 +02:00
Grégoire Paris
c289b79fb2
Merge pull request #8844 from greg0ire/backport-6549
...
Ditch SimpleAnnotationReader
2021-07-15 22:32:22 +02:00
Grégoire Paris
03a728dfc8
Ditch SimpleAnnotationReader
...
We want to get rid of it, because it is not really usable in context
when you use annotations from more than one namespace. This implies
importing classes for all annotations in use.
2021-07-15 22:23:40 +02:00
Grégoire Paris
558ebcdc83
Merge pull request #8842 from greg0ire/backport-6963
...
Add documentation for ToolEvents
2021-07-15 08:06:59 +02:00
Gabriel Caruso
4b06fb2424
[CS] Clean elses
2021-07-14 22:08:46 +02:00
Claudio Zizza
474218395a
Add root namespace to full classname
2021-07-14 11:06:35 +02:00
Claudio Zizza
70092b9800
Update loadClassMetadata example and add namespaces
2021-07-14 11:04:41 +02:00
Claudio Zizza
cd13addcfc
Add ToolEvents of SchemaTool
2021-07-14 11:03:08 +02:00
Grégoire Paris
5b6a1d7a40
Merge pull request #8836 from greg0ire/explicit-type-casts
...
Make implicit type casts explicit
2021-07-13 23:53:35 +02:00
Marco Pivetta
74ffc25b50
Removing useless post-array-population association hydration via array_walk()
2021-07-11 14:40:22 +02:00
Marco Pivetta
91de49e6a6
Removing is_array check on a type that can only have two possible states - using instanceof instead
2021-07-11 14:40:21 +02:00
Marco Pivetta
102484dea8
Removing useless array_key_exists() calls, using ?? operator instead
2021-07-11 14:34:21 +02:00
Marco Pivetta
f9b9a14275
Removing useless variable
2021-07-11 14:34:17 +02:00
Marco Pivetta
8b3d5848a2
Removing useless checking for never-used parameter, inlining merge operation
2021-07-11 14:33:49 +02:00
Marco Pivetta
9c5d676111
Replacing possible O(n^2) operation from PersistentCollection diffing operations
2021-07-11 14:33:43 +02:00
Michael Moravec
84ad007de3
Replace spl_object_hash() with spl_object_id()
...
It is more efficient, and can be provided to 7.1 users thanks to
symfony/polyfill-php72.
2021-07-10 11:55:13 +02:00
Grégoire Paris
e88d261dca
Make implicit type casts explicit
2021-07-10 10:41:25 +02:00
Benjamin Eberlei
95408cd8e4
[docs] Fix sentence about how nullable types affecting column definitions. ( #8835 )
2021-07-08 22:22:34 +02:00
Thomas Landauer
182bdaac6b
Adding fields to Index ( #8830 )
...
* Adding `fields` to Index
I guess this was just forgotten here.
Wording is taken from https://www.doctrine-project.org/projects/doctrine-orm/en/2.9/reference/annotations-reference.html#index
* Update attributes-reference.rst
2021-07-08 22:06:57 +02:00
Grégoire Paris
3c805b22b4
Merge pull request #8825 from greg0ire/github-templates
...
Backport Github issue and PR templates
2021-07-06 08:34:55 +02:00
Grégoire Paris
7a56ca13f8
Merge pull request #8824 from greg0ire/remove-license-header
...
Drop license header
2021-07-06 08:30:55 +02:00
Grégoire Paris
6a41ab56ce
Backport Github issue and PR templates
2021-07-05 23:14:47 +02:00
fridde
802dd54f07
Referenced new support for PHP8 attributes ( #8823 )
2021-07-05 22:06:04 +02:00
Grégoire Paris
be2d99e5f6
Drop license header
2021-07-05 21:26:41 +02:00
Grégoire Paris
0a663da5b6
Merge pull request #8822 from greg0ire/2.10.x
2021-07-05 10:36:24 +02:00
Grégoire Paris
0b3fc57458
Merge remote-tracking branch 'origin/2.9.x' into 2.10.x
2021-07-05 10:14:57 +02:00
Grégoire Paris
836c0d3803
Merge pull request #8814 from greg0ire/backport-7158
...
Proposed corrected typo in demo code.
2021-07-05 10:11:50 +02:00
Grégoire Paris
aa3ed91dd2
Merge pull request #8821 from greg0ire/fix-phpstan
2021-07-05 10:01:59 +02:00
Grégoire Paris
f542dde131
Pin PHPStan to current version
...
We want to control upgrades to avoid suddenly failing builds.
2021-07-05 09:22:54 +02:00
Grégoire Paris
a165d4af7c
Adapt ignore rules to new PHPStan version
2021-07-05 09:13:37 +02:00
Cathy Guilbaud
ff13059ba2
Proposed corrected typo in demo code.
...
changed $payed to $paid.
2021-07-04 17:34:22 +02:00
Grégoire Paris
c3953435dd
Merge pull request #8806 from greg0ire/resurrect-phpbench
...
Resurrect phpbench
2021-07-03 23:21:21 +02:00
Grégoire Paris
37f60be836
Merge pull request #8813 from greg0ire/deprecate-uuid-generator
...
Deprecate all things related to DB-generated UUIDs
2021-07-03 22:38:44 +02:00
Grégoire Paris
9f5b38f539
Deprecate all things related to DB-generated UUIDs
...
DB-generated UUIDs have been deprecated in the DBAL.
2021-07-03 21:52:26 +02:00
Grégoire Paris
665e5c49ea
Merge pull request #8812 from greg0ire/update-baseline
...
Update baseline
2021-07-03 21:31:33 +02:00
Grégoire Paris
3a10e07dfc
Update baseline
...
Many deprecations have been addressed, particularly DBAL ones.
2021-07-03 21:21:24 +02:00
Grégoire Paris
909de45c5c
Merge pull request #8811 from greg0ire/2.10.x
...
Merge 2.9.x into 2.10.x
2021-07-03 21:17:46 +02:00
Grégoire Paris
5aa7f75f77
Merge remote-tracking branch 'origin/2.9.x' into 2.10.x
2021-07-03 21:02:03 +02:00
Grégoire Paris
8f2aef5fa3
Merge pull request #8810 from greg0ire/update-baseline
...
Update Psalm baseline
2021-07-03 21:00:26 +02:00
Grégoire Paris
05be0e8bbd
Update Psalm baseline
...
It seems some deprecations have been addressed recently.
2021-07-03 20:46:37 +02:00
Grégoire Paris
64cf6edea6
Use consistent style for the OR operator
2021-07-03 12:07:43 +02:00
Grégoire Paris
7608a40463
Run phpbench in the CI
2021-07-03 12:05:45 +02:00
Grégoire Paris
b1f6f9bfc3
Make phpbench runnable again
...
There seems to have been a new major version.
2021-07-03 11:57:32 +02:00
Grégoire Paris
71af666c38
Merge pull request #8796 from derrabus/improvement/hydrators-dbal-3
...
Migrate hydrators and queries to DBAL's new Result interface
2021-06-30 23:39:19 +02:00
Grégoire Paris
3fe980de96
Merge pull request #8801 from derrabus/bugfix/ignore-return-type-will-change
...
Ignore errors about missing ReturnTypeWillChange class
2021-06-30 23:02:01 +02:00
Grégoire Paris
f5d988de4e
Merge pull request #8784 from greg0ire/undeprecate-passing-null
...
Undeprecate targetEntity omission for some types
2021-06-30 21:42:13 +02:00
Grégoire Paris
e840aef630
Merge pull request #8798 from greg0ire/backport-7776
...
Remove hack to access class scope inside closures
2021-06-30 08:20:29 +02:00
Gabriel Caruso
2936bac7ec
Remove hack to access class scope inside closures
...
This is possible since 5.4.
2021-06-29 23:56:37 +02:00
Grégoire Paris
55971d2f05
Merge pull request #8799 from greg0ire/backport-6909-6910
...
Combine consecutive issets and unsets
2021-06-29 23:51:35 +02:00
Grégoire Paris
1f6bfe1754
Merge pull request #8800 from jderusse/fix-exception
...
Fix exception not thrown by "getEntityIdentifier"
2021-06-29 23:50:41 +02:00
Alexander M. Turek
0723e664e1
Migrate hydrators and queries to DBAL's new Result interface
...
Signed-off-by: Alexander M. Turek <me@derrabus.de >
2021-06-29 23:04:15 +02:00
Alexander M. Turek
b0c7993dd6
Ignore errors about missing ReturnTypeWillChange class
...
Signed-off-by: Alexander M. Turek <me@derrabus.de >
2021-06-29 22:50:16 +02:00
Jérémy Derussé
796af72650
Fix exception not thrown by "getEntityIdentifier"
2021-06-29 22:32:29 +02:00
Gabriel Caruso
02174fb68f
Combine consecutives issets
2021-06-28 23:33:33 +02:00
Gabriel Caruso
92c51de734
Combine consecutive unsets
2021-06-28 23:32:02 +02:00
Claudio Zizza
233d9b0276
Update session examples in docs ( #8795 )
...
The session examples contained approaches that aren't favorable for an application
and needed an overhaul using either scalar values or an DTO instead of the whole
entity with detach() and merge().
2021-06-28 23:23:40 +02:00
Grégoire Paris
b6d7826dc7
Merge pull request #8789 from greg0ire/backport-7292
...
Use a more concrete, less confusing example
2021-06-28 23:09:24 +02:00
Grégoire Paris
ce8de6df7f
Merge pull request #8794 from derrabus/improvement/dbal-depecations
...
Fix deprecated DBAL calls
2021-06-28 10:58:20 +02:00
Grégoire Paris
b3ee7141eb
Use a more concrete, less confusing example
...
I picked a toothbrush because you usually do not share it with other
persons, feel free to propose something else.
2021-06-28 00:03:29 +02:00
Grégoire Paris
73aa6e8352
Merge pull request #8791 from greg0ire/backport-docs-batch-2
...
Backport docs batch 2
2021-06-28 00:00:10 +02:00
Grégoire Paris
d1e5c59af9
Merge pull request #8792 from greg0ire/backport-malukenho
...
Backport malukenho's work
2021-06-27 23:59:19 +02:00
Grégoire Paris
e792777187
Merge pull request #8793 from greg0ire/backport-slamdunk
...
Backport slamdunk's work
2021-06-27 23:58:46 +02:00
Alexander M. Turek
afa837a361
Fix deprecated DBAL calls
2021-06-27 18:26:37 +02:00
Filippo Tessarotto
5a9bd0904b
Apply ternary_operator_spaces
2021-06-27 12:18:14 +02:00
Filippo Tessarotto
b50d06ae58
Apply align_multiline_comment
2021-06-27 12:15:37 +02:00
Filippo Tessarotto
220201cf14
Apply escape_implicit_backslashes,heredoc_to_nowdoc
2021-06-27 12:06:02 +02:00
Filippo Tessarotto
5fa3a92ecb
Apply bare heredoc_to_nowdoc
2021-06-27 12:05:50 +02:00
Jefersson Nathan
fef46263b5
Remove unused return statement
...
Signed-off-by: Jefersson Nathan <admin@phpse.net >
2021-06-27 11:09:23 +02:00
Jefersson Nathan
e6d9f99ac0
Remove redundant php-docs
...
Signed-off-by: Jefersson Nathan <admin@phpse.net >
2021-06-27 11:09:21 +02:00
Igor Pellegrini
f3e87d2c2f
Fix bullet list not rendering correctly on Github
...
As *rst*, if reading the tutorial on the Github repository, the items
are not seen as elements of a bullet list, hence they are not rendered
and they are collapsed in a single line of text.
Fix won't affect how it renders on
[doctrine-project.org](https://www.doctrine-project.org/projects/doctrine-orm/en/latest/tutorials/getting-started.html ).
2021-06-27 10:42:17 +02:00
Grégoire Paris
244e7c7c29
Merge pull request #8787 from greg0ire/optional-doctrine-annotations
...
Make doctrine/annotations an optional dependency
2021-06-27 10:15:00 +02:00
Catalin Ciobanu
53ba6b9732
Updated docblock
2021-06-26 23:04:56 +02:00
Jachim Coudenys
b3f580bf5e
Fix the link to the 'Change Tracking Policies' documentation
2021-06-26 23:04:12 +02:00
Alex Rock Ancelet
774b5cbdd4
document using DTOs and entities as Value Objects
2021-06-26 22:51:22 +02:00
Gabriel Caruso
7fa3e6ec7c
Use HTTPS instead of HTTP
2021-06-26 22:43:16 +02:00
Grégoire Paris
e743981f8d
Merge pull request #8790 from greg0ire/backport-docs-batch
...
Backport docs batch
2021-06-26 22:18:30 +02:00
Haralan Dobrev
a469514ef0
Remove obsolete backslashes from underscores
...
These backslashes were not correctly migrated when updating the website
and it prevents search for some important terms like the query hints.
2021-06-26 18:57:58 +02:00
Jachim Coudenys
9fb13dbe28
Fix the result cache documentation (it caches raw data, not hydrated entities)
2021-06-26 17:12:28 +02:00
Adrian Föder
fc97041e49
[TASK] Streamline code block type hints for readability
...
This corrects a mistake with a given type hint in
the PHP code blocks as well as adds further for
consistency and brevity.
2021-06-26 16:14:05 +02:00
Claudio Zizza
f8f3b196a1
Extend documentation of arbitrary joins
2021-06-26 16:13:56 +02:00
Claudio Zizza
c01961840e
Fix of variable typo in cache usage example
2021-06-26 16:13:47 +02:00
Andreas Möller
6ef1367cde
Fix: Consistently format inversedBy and mappedBy attributes
2021-06-26 16:13:39 +02:00
Adrian Föder
3572b49e6a
[FEATURE] Mention and link identifier generation strategies
2021-06-26 16:13:30 +02:00
Maciej Malarz
587c5f5ad6
Fix Criteria's orderBy example
2021-06-26 16:13:23 +02:00
someniatko
4f0a04e0eb
Better PHPDoc for AbstractQuery cache methods
...
Updated useResultCache() and setResultCacheLifetime() docs to clearly state $lifetime is measured in seconds;
Added description to useResultCache()'s params. Renamed $bool => $useCache.
2021-06-26 16:13:19 +02:00
Andreas Möller
4451019dc0
Fix: Attributes vs. annotations
2021-06-26 15:56:33 +02:00
Gabriel Ostrolucký
c021426613
Fix #2935 [DDC-2236] Add note that Paginator might screw aggreg. queries
2021-06-26 15:56:09 +02:00
Gabriel Ostrolucký
243c8bff1f
Fix EBNF of InExpression (StateFieldPath -> Arithmetic)
2021-06-26 15:55:18 +02:00
Gert de Pagter
5bbad8c403
Require ctype extension
2021-06-26 15:53:07 +02:00
Thomas Landauer
6c6b919788
Added UNIQUE INDEX to generated SQL schema
...
When I tried the example code, I got this unique index too.
Plus my `ALTER TABLE` statement was a little different from the one in the docs:
> ALTER TABLE cart ADD CONSTRAINT FK_BA388B79395C3F3 FOREIGN KEY (customer_id) REFERENCES customer (id)
Should I change that too?
2021-06-26 15:51:51 +02:00
Thomas Bisignani
b37c433080
[Documentation] Fixed comments syntax
2021-06-26 15:50:34 +02:00
Claudio Zizza
173f31a14a
Add readOnly attribute to annotation example
2021-06-26 15:48:33 +02:00
Guido Sangiovanni
319acb1076
typo in class description
...
fixed typo in class description
2021-06-26 15:46:45 +02:00
Arman
242d2c1c41
Remove year from license
2021-06-26 15:46:14 +02:00
Jérôme Vasseur
5c95ce5c21
Fix EntityRepository constructor phpdoc
...
Remove redundant phpdoc from EntityRepository constructor
2021-06-26 15:45:02 +02:00
Grégoire Paris
fa583f6533
Make doctrine/annotations an optional dependency
...
First, there are other drivers than the annotations-based one, and
second, one of them is base on attributes, which are basically
annotations native to PHP.
Closes #8785
2021-06-26 09:51:42 +02:00
Grégoire Paris
7a78fd2900
Undeprecate targetEntity omission for some types
...
Some relationship types are attached to properties that can be typed
since php 7.4.
To avoid repeating the property type in targetEntity, an autodetection
feature has been developed that allows building the mapping from that
type information and annotations.
Omitting the targetEntity stays deprecated for ManyToMany as there is no
auto-detection for that yet (although one could be built by analyzing
phpdoc annotations).
2021-06-24 23:41:05 +02:00
Grégoire Paris
67fc57b5e1
Merge pull request #8780 from derrabus/improvement/deprecated-constants
...
Fix usages of deprecated DBAL constants
2021-06-23 09:13:32 +02:00
Grégoire Paris
b4547888d9
Merge pull request #8782 from doctrine/2.9.x
...
Merge 2.9.x up into 2.10.x
2021-06-23 08:28:06 +02:00
Grégoire Paris
f233e4cf6b
Merge pull request #8781 from derrabus/bugfix/static-analysis
...
Fix Psalm/PHPStan errors
2021-06-23 08:20:28 +02:00
Alexander M. Turek
7277afefb9
Fix usages of deprecated DBAL constants
2021-06-23 01:30:14 +02:00
Alexander M. Turek
b9f7e09401
Fix Psalm/PHPStan errors
2021-06-23 01:12:54 +02:00
Julio Montoya
5e91eea726
Link to correct section ( #8778 )
2021-06-22 13:12:54 +02:00
Julio Montoya
10922a5329
Spell "entity" properly ( #8777 )
2021-06-22 13:09:57 +02:00
Grégoire Paris
fbf793af0e
Merge pull request #8543 from simonberger/add_missing_param_and_return_attributes
...
Add missing @param and @return PHPDoc attributes
2021-06-20 21:51:38 +02:00
Simon Berger
a26ae0648f
Add missing @param and @Result PHPDoc attributes
2021-06-20 21:42:50 +02:00
Grégoire Paris
8bb564d5fe
Limit template annotations to Psalm
...
Phpstan requires that the template can be resolved in all cases, while
Psalm seems to tolerate this ambiguous situation.
See https://github.com/phpstan/phpstan/issues/5175#issuecomment-861437050
2021-06-16 08:13:57 +02:00
Grégoire Paris
08149ea0b9
Merge pull request #8692 from greg0ire/split_orm_exception
...
Split the ORMException class
2021-06-15 23:43:16 +02:00
Grégoire Paris
06844484dd
Split the ORMException class
2021-06-15 23:34:35 +02:00
Matthias Pigulla
7827869191
Make ResolveTargetEntityListener deal with the DiscriminatorMap as well ( #8402 )
2021-06-15 08:08:15 +02:00
Grégoire Paris
23602784f8
Merge pull request #8765 from doctrine/2.9.x-merge-up-into-2.10.x_osteH8Wj
...
Merge release 2.9.3 into 2.10.x
2021-06-14 18:40:15 +02:00
Philipp Fritsche
82e77cf508
Bugfix: handle repeatable attributes ( #8756 )
...
* fix: handle repeatable attributes
* Restore interface compatibility
A reader is supposed to only ever return objects. By introducing
RepeatableAttributeCollection, we fulfill the interface and improve
clarity.
* refactor: accurate type declarations and returns
* refactor: remove unused use
* Ignore AttributeReader in phpstan and psalm to pass on CI running PHP 7.4.
* test: isTransient
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr >
Co-authored-by: Benjamin Eberlei <kontakt@beberlei.de >
2021-06-13 12:29:22 +02:00
Grégoire Paris
1518b40dd2
Merge pull request #8758 from greg0ire/restore-bc-for-annotations
...
Restore bc for annotations
2021-06-10 19:12:13 +02:00
Grégoire Paris
10e41ec8bc
Deprecate required of mandatory arguments
2021-06-09 23:04:16 +02:00
Grégoire Paris
303e346390
Restore backwards-compatibility
...
There used to be no constructor in this class, adding one with mandatory
arguments was technically a BC-break.
Fixes #8753
2021-06-09 23:04:16 +02:00
Grégoire Paris
fc7db8f59e
Merge pull request #8747 from greg0ire/fix-attributes-syntax
...
Use correct named argument syntax in docs
2021-06-07 22:41:13 +02:00
Grégoire Paris
ae7f04ea53
Use correct named argument syntax in docs
2021-06-07 21:06:44 +02:00
Grégoire Paris
b8808099ea
Merge pull request #8742 from derrabus/bugfix/return-type-will-change
...
Add ReturnTypeWillChange to ReflectionEmbeddedProperty
2021-06-05 23:52:49 +02:00
Alexander M. Turek
6432a3eeb2
Add ReturnTypeWillChange to ReflectionEmbeddedProperty
2021-06-05 22:51:55 +02:00
Grégoire Paris
3a0f60d6c6
Merge pull request #8734 from VincentLanglet/fixMetadata
...
Fix metadata constructor inference by phpstan
2021-06-05 21:48:17 +02:00
Grégoire Paris
ee19cf5cfd
Merge pull request #8740 from VincentLanglet/fixMetada2
...
Make ClassMetadata covariant
2021-06-03 10:21:39 +02:00
Vincent Langlet
66daafd597
Make ClassMetadata covariant
2021-06-03 09:04:46 +02:00
Vincent Langlet
249c4fe61b
Remove currentWorkingDirectory
2021-06-01 09:28:45 +02:00
Vincent Langlet
89673c60bf
Fix metadata constructor inference by phpstan
2021-05-31 23:53:58 +02:00
github-actions[bot]
f8bcd2d200
Merge release 2.9.2 into 2.10.x ( #8733 )
...
* Mark 2.8.x as unmaintained, and 2.9.x as current
* Fix ClassMetadataInfo template inference
* Fix metadata cache compatibility layer
* Bump doctrine/cache patch dependency to fix build with lowest deps
* Add generics to parameters
* Add note about performance and inheritance mapping (#8704 )
Co-authored-by: Claudio Zizza <859964+SenseException@users.noreply.github.com >
* Adapt flush($argument) in documentation as it's deprecated. (#8728 )
* [GH-8723] Remove use of nullability to automatically detect nullable status (#8732 )
* [GH-8723] Remove use of nullability to automatically detect nullable status.
* [GH-8723] Make Column::$nullable default to false again, fix tests.
* Add automatic type detection for Embedded. (#8724 )
* Add automatic type detection for Embedded.
* Inline statement.
Co-authored-by: Benjamin Eberlei <kontakt@beberlei.de >
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr >
Co-authored-by: Vincent Langlet <VincentLanglet@users.noreply.github.com >
Co-authored-by: Andreas Braun <git@alcaeus.org >
Co-authored-by: Fran Moreno <franmomu@gmail.com >
Co-authored-by: Juan Iglesias <juan.manuel.iglesias93@gmail.com >
Co-authored-by: Claudio Zizza <859964+SenseException@users.noreply.github.com >
Co-authored-by: Yup <warxcell@gmail.com >
Co-authored-by: Benjamin Eberlei <kontakt@beberlei.de >
2021-05-31 17:45:06 +02:00
Yup
75b4b88c5b
Add automatic type detection for Embedded. ( #8724 )
...
* Add automatic type detection for Embedded.
* Inline statement.
Co-authored-by: Benjamin Eberlei <kontakt@beberlei.de >
2021-05-31 11:53:14 +02:00
Benjamin Eberlei
d9e59d6862
[GH-8723] Remove use of nullability to automatically detect nullable status ( #8732 )
...
* [GH-8723] Remove use of nullability to automatically detect nullable status.
* [GH-8723] Make Column::$nullable default to false again, fix tests.
2021-05-31 10:19:16 +02:00
Yup
5fa94969de
Adapt flush($argument) in documentation as it's deprecated. ( #8728 )
2021-05-29 22:22:19 +02:00
Juan Iglesias
f2c3ddac97
Add note about performance and inheritance mapping ( #8704 )
...
Co-authored-by: Claudio Zizza <859964+SenseException@users.noreply.github.com >
2021-05-27 08:27:55 +02:00
Grégoire Paris
46f0da9ffa
Merge pull request #8710 from franmomu/recompute
...
Handle generic parameters in UnitOfWork
2021-05-25 13:29:21 +02:00
Fran Moreno
1e832a6782
Add generics to parameters
2021-05-25 13:01:47 +02:00
Grégoire Paris
56bdb44efd
Merge pull request #8722 from alcaeus/fix-metadata-cache-clear
2021-05-25 12:55:00 +02:00
Andreas Braun
fffac44991
Bump doctrine/cache patch dependency to fix build with lowest deps
2021-05-25 11:58:11 +02:00
Andreas Braun
e42b3d6584
Fix metadata cache compatibility layer
2021-05-25 10:38:00 +02:00
Grégoire Paris
7ab2c3abbd
Merge pull request #8708 from VincentLanglet/patch-2
...
Fix ClassMetadaInfo template inference
2021-05-25 08:49:50 +02:00
Grégoire Paris
498c816b65
Merge pull request #8717 from greg0ire/update-branch-metadata
...
Mark 2.8.x as unmaintained, and 2.9.x as current
2021-05-25 00:01:21 +02:00
Vincent Langlet
eec740079d
Fix ClassMetadataInfo template inference
2021-05-24 21:52:40 +02:00
Grégoire Paris
c359715a97
Mark 2.8.x as unmaintained, and 2.9.x as current
2021-05-24 21:32:26 +02:00
Benjamin Eberlei
f3e55fae9f
Update .doctrine-project.json to include 2.9 stable and 2.10 upcoming
2021-05-24 17:54:12 +02:00
Michael Babker
91c3bd4121
Fix links to attribute sections ( #8714 )
2021-05-24 17:52:30 +02:00
Peter Gribanov
e6cf12c66f
remove usage Webmozart ( #8713 )
2021-05-24 17:50:15 +02:00
Grégoire Paris
99d67cb77d
Merge pull request #8705 from greg0ire/2.9.x
...
Merge 2.8.x into 2.9.x
2021-05-21 09:15:28 +02:00
Grégoire Paris
43f66d5808
Merge remote-tracking branch 'origin/2.8.x' into 2.9.x
2021-05-21 09:04:27 +02:00
Grégoire Paris
a6577b89a2
Merge pull request #8701 from jderusse/symfony6
...
Allow Symfony 6.0
2021-05-20 07:58:49 +02:00
Jérémy Derussé
0ca87566a9
Allow Symfony 6.0
2021-05-20 07:48:21 +02:00
Grégoire Paris
5d01f94a36
Merge pull request #8699 from greg0ire/fix-psalm
...
Fix some static analysis issues
2021-05-20 07:43:12 +02:00
Grégoire Paris
3d02b02636
Update static analysis baseline files
...
These issues were not introduced with new code, but with upgrades.
2021-05-20 00:03:39 +02:00
Grégoire Paris
6de321cb09
Address Psalm issues introduced by persistence
2021-05-20 00:03:39 +02:00
Grégoire Paris
535bc92dc8
Merge pull request #8700 from deguif/fix-undefined-offset
...
Fix undefined index
2021-05-18 12:20:38 +02:00
François-Xavier de Guillebon
ebb5d03f7a
Fix undefined offset
2021-05-18 10:00:19 +02:00
Grégoire Paris
8e13369621
Merge pull request #8698 from deguif/cache-deprecation
...
Fix cache deprecation
2021-05-17 22:15:13 +02:00
François-Xavier de Guillebon
8eff4b775a
Fix cache deprecation
2021-05-17 21:33:52 +02:00
Grégoire Paris
b85403d0a2
Merge pull request #8691 from alcaeus/check-deprecations
...
Check for use of deprecated API with Psalm
2021-05-15 18:50:30 +02:00
Andreas Braun
22ce3adfce
Move to psalm level 2
...
This converts more issues to errors, most notably around deprecations. This can be used to later remove deprecated API.
2021-05-15 17:01:43 +02:00
tweet9ra
3a194ad699
SimpleObjectHydrator: skip unsuit custom type before converting it ( #8566 )
...
When using inheritance, it is possible to map the same column to properties of
different child classes. This can result in the same column being selecting several
times with different aliases in one SQL query, and only one aliased field needs
to be hydrated per row.
We now check that such an aliased value is mapped to the class we are hydrated
before attempting to convert it as it might result in an error when using a custom
type that does not get the expected data to initialize php value.
Co-authored-by: Sergey Naumov <s.naumov@lamoda.ru >
2021-05-15 09:37:16 +02:00
Andreas Braun
d52dab54dd
Merge pull request #8672 from alcaeus/allow-cache-2.0
2021-05-14 20:21:56 +02:00
Andreas Braun
b5ac7714bc
Remove ignored phpstan errors related to doctrine/cache 2.0
2021-05-13 20:38:21 +02:00
Andreas Braun
590551d5c3
Fix setup tool tests
2021-05-13 20:16:52 +02:00
Andreas Braun
c9fb9fdb40
Improve BC layer for getMetadataCacheImpl
2021-05-13 20:16:52 +02:00
Andreas Braun
965926dcc8
Update phpstan baseline to account for doctrine/cache deprecation
2021-05-13 20:16:52 +02:00
Andreas Braun
a6e30c5f4c
Fix checkstyle violations
2021-05-13 20:16:52 +02:00
Andreas Braun
30ab6f4cea
Add upgrade note for cache changes
2021-05-13 20:16:52 +02:00
Andreas Braun
5e5a44dce2
Suggest using symfony/cache in setup tool
2021-05-13 20:16:52 +02:00
Andreas Braun
d7bf30b291
Fix setup tool tests
2021-05-13 20:16:51 +02:00
Andreas Braun
ce8da6623f
Stop using doctrine/cache
2021-05-13 20:16:51 +02:00
Andreas Braun
2ecec0c5d6
Remove reliance on doctrine/cache implementations in tests
2021-05-13 20:16:51 +02:00
Andreas Braun
6f128e4515
Allow installing doctrine/cache 2.0
2021-05-13 20:11:14 +02:00
Benjamin Eberlei
e24b0f0be7
[GH-8589] A new approach to non-nullable typed associations for BC ( #8678 )
...
* [GH-8589] A new approach to non-nullable typed associations for BC
* Address review comment about keeping the target entity type detection.
2021-05-10 19:08:16 +02:00
Benjamin Eberlei
6753b26f73
[GH-8676] Allow nested annotations to work without parents as attributes ( #8677 )
...
* [GH-8676] Allow nested annotations to work without parents as attributes.
* Housekeeping
2021-05-09 19:58:44 +02:00
Grégoire Paris
4ccc4e19fc
Merge pull request #8600 from VincentLanglet/computeChangeset
...
Remove internal tag from computeChangeSet
2021-05-05 19:27:39 +02:00
Simon Podlipsky
4e2009433b
Reflect that default EntityManager is not always named default ( #8671 )
...
Follows up #8646
2021-05-05 18:53:34 +02:00
Grégoire Paris
c25b822217
Merge pull request #8673 from Seldaek/patch-1
...
Add hint for ->iterate() deprecation
2021-05-05 13:31:30 +02:00
Jordi Boggiano
c3dcc5af91
Add hint for ->iterate() deprecation
2021-05-05 10:31:33 +02:00
Grégoire Paris
b2f404b25f
Merge pull request #8651 from alcaeus/deprecate-doctrine-metadata-cache
...
Introduce PSR-6 for metadata caching
2021-05-01 14:53:46 +02:00
Alexandr Li
d141f27875
ConvertDoctrine1Schema: Fix Doctrine 1 notnull field import ( #8649 )
...
* ConvertDoctrine1Schema: Fix Doctrine 1 `notnull` field import
* cs fix
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr >
2021-05-01 13:56:41 +02:00
Andreas Braun
4691839201
Extend DoctrineTestCase to fix missing methods
2021-04-29 12:54:23 +02:00
Andreas Braun
91387382b7
Allow symfony/cache 4.4 to provide PHP 7.1 support
2021-04-29 09:48:27 +02:00
Andreas Braun
f634c64b7a
Use stubs over mocks in tests
...
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr >
2021-04-29 09:42:18 +02:00
Andreas Braun
7ba9c980b5
Introduce PSR-6 for metadata caching
2021-04-29 09:42:18 +02:00
Grégoire Paris
dacdcf2c7b
Merge pull request #8662 from greg0ire/2.9.x
...
Merge 2.8.x into 2.9.x
2021-04-29 09:27:40 +02:00
Grégoire Paris
f296fee9e4
Merge remote-tracking branch 'origin/2.8.x' into 2.9.x
2021-04-29 09:20:26 +02:00
Grégoire Paris
8555fc1d34
Merge pull request #8659 from greg0ire/make-tests-independent
...
Make tests independent
2021-04-29 09:07:26 +02:00
Grégoire Paris
b0826fd746
Merge pull request #8201 from oojacoboo/2.8.x
...
Throw Exception when unable to locate identifier
2021-04-28 15:57:50 +02:00
Jacob Thomason
fe93c2e9d5
Throw Exception that includes name of entity when unable to locate identifier
2021-04-28 15:33:03 +02:00
Grégoire Paris
850d57827f
Make tests independent
...
It seems like IdentityMapTest cannot be run on its own when the second
level cache is enabled (with ENABLE_SECOND_LEVEL_CACHE=1).
It does work when running the whole test suite because
ExtraLazyCollectionTest disables part of that cache in its setUp()
method.
In this patch, we restore the class metadata as it was before running
setUp() and put the test in IdentityMapTest inside the group that is
excluded when running with ENABLE_SECOND_LEVEL_CACHE=1 on the CI.
2021-04-28 14:12:31 +02:00
Benjamin Eberlei
e1388fa986
[GH-8327] Make EntityManagerProvider compatible with expected DoctrineBundle usage ( #8646 )
...
* [GH-8327] Make EntityManagerProvider compatible with expected DoctrineBundle usage.
* phpcs
* [Gh-8327] Delegate to EntityManagerProvider::getDefaultManager in ConnectionFromManagerProvider
2021-04-25 19:44:12 +02:00
Grégoire Paris
9a48450481
Merge pull request #7608 from mavroprovato/patch-1
...
Avoid unnecessary flush after processing first row
2021-04-24 14:23:09 +02:00
Kostas Kokkoros
cff8b96dd6
Avoid unnecessary flush after processing first row
...
The code as is needlessly flushes after just one row is updated or
removed. It makes more sense to update after ``$batchSize`` elements are
updated or removed, just as it is in the insert case.
2021-04-24 13:01:33 +02:00
Grégoire Paris
996c1c74b3
Merge pull request #8644 from greg0ire/more-accurate-return-type
...
Describe return types more accurately
2021-04-22 22:31:05 +02:00
Grégoire Paris
48612e6dc6
Merge pull request #8641 from Jean85/remove-deprecated-proxy-usage
...
Replace deprecated Proxy usages with parent interface to reduce baseline
2021-04-19 23:37:22 +02:00
Benjamin Eberlei
ddfee26f80
Support for Array parameters in SQL filters ( #8375 )
...
* #1168 Add support for array parameters on the SQLFilter
* DDC-1168 Add support for array parameters on the SQLFilter
* [GH-2624] Rework array support to use new getParameterList()
* [DDC-1952] Change at() mocking to using returnCallback()
* [DDC-1952] Make arrays of values explicit with new setParameterList
* Adjust tests to use country as list and locale as single value.
* [DDC-1952] Add tests for new exxeption conditions.
* Apply suggestions from code review
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr >
Co-authored-by: Manuel Nogales <nogales.manuel@gmail.com >
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr >
2021-04-19 19:46:22 +02:00
Grégoire Paris
eb860a704e
Change incorrect DBAL return types
2021-04-19 19:27:00 +02:00
Grégoire Paris
51ffcb4891
Describe return types more accurately
...
This fixes an SA regression introduced when using stricter types in
SchemaTool.
Fixes #8642
2021-04-19 19:09:10 +02:00
Grégoire Paris
72f500318a
Merge pull request #8544 from greg0ire/bc-type-declarations
...
Add type declarations where backwards-compatible
2021-04-19 14:02:17 +02:00
Grégoire Paris
55f030f66b
Add type declarations where backwards-compatible
...
This includes:
- private methods
- return type declarations of final protected methods
- return type declarations of public and protected methods of final classes
Parameter type declarations are a more delicate matter and should
probably be handled separately to make it easier to catch issues during
code review.
Type declarations can be more trusted than simple phpdoc when it
comes to static analysis, having them means we can infer the phpdoc of
calling methods with confidence.
Note that it seems that some of the phpdoc I initially inferred these
declarations from were apparently wrong, in particular some mentioning
Doctrine\Dbal\Statement when was is really passed around is
Doctrine\Dbal\Driver\Statement.
2021-04-19 13:51:00 +02:00
orklah
95af30eb72
FileLockRegion::__construct 3rd param is meant to be an int ( #8640 )
2021-04-19 13:29:43 +02:00
Alessandro Lai
9ea0769d78
Replace deprecated Proxy usages with parent interface to reduce baseline
2021-04-19 10:43:49 +02:00
Benjamin Eberlei
22413453da
Reintroduce PHP 7.1 support ( #8613 )
...
* Reintroduce PHP 7.1 support
* phpcs
* Another object typehint
* More compatibility
* phpcs
* Reduce doctrine/inflector versions again since 1.4.4 is released.
* Housekeeping: phpcbf
* Simplify PHPUnit Polyfill abstraction.
* Missing assertDoesNotMatchRegularExpression
* phpcs
* Add 7.1 on Github actions, since dependencies now supported.
* Simplify code to work with renamed phpunit assertions and document when to remove.
* phpcs
* Downgrade target phpstan version to 7.1.0
* Run --prefer-lowest with PHP 7.1 not 7.3
2021-04-18 21:24:51 +02:00
Grégoire Paris
06fadcdd8c
Merge pull request #8630 from Jean85/reduce-baseline
...
Reduce baseline
2021-04-18 18:50:59 +02:00
Alessandro Lai
7c56aa2141
Reduce baseline with a nullable return where needed
2021-04-18 18:39:20 +02:00
Alessandro Lai
4cdcb5f760
Reduce baseline for AbstractCollectionPersister
2021-04-18 18:39:20 +02:00
Alessandro Lai
b542b36e45
Remove baseline for DefaultCacheFactory
2021-04-18 18:39:20 +02:00
Alessandro Lai
e5a7a13e1e
Remove single baseline rule from DefaultCache
2021-04-18 18:39:20 +02:00
Alessandro Lai
8336dd3779
Remove baseline for AbstractQuery
2021-04-18 18:39:14 +02:00
Grégoire Paris
b04d7a62ae
Merge pull request #8548 from orklah/test2
...
Adding details to types in PHPDoc
2021-04-18 18:09:28 +02:00
Grégoire Paris
a959a474fd
Merge pull request #8636 from greg0ire/update-gitattributes
...
Update ignore rules to reflect current situation
2021-04-18 17:56:47 +02:00
Benjamin Eberlei
ce128e742b
[GH-5202] Implement Query::HINT_READ_ONLY flag ( #7936 )
...
* Rebase QueryHintReadOnly on 2.9.x
* Housekeeping: phpcs
* [GH-5202] Dont mark known entities as read only.
* [GH-5202] Not mark objects read only when proxy before.
* phpcs
2021-04-18 16:45:25 +02:00
Benjamin Eberlei
dac87dae06
[GH-8327] Deprecate EntityManagerHelper for a provider abstraction. ( #8524 )
...
* cli config
* [GH-8327] Deprecate EntityManager HelperSet for a provider abstraction.
* Housekeeping: phpcs
* [GH-8327] Refactor tests towards use of SingleManagerProvider instead of HelperSet.
* [GH-8327] Refactor tests towards use of SingleManagerProvider instead of HelperSet.
* [GH-8327] Refactor tests towards use of SingleManagerProvider instead of HelperSet.
* Housekeeping: cs
* Update tests/Doctrine/Tests/ORM/Tools/Console/ConsoleRunnerTest.php
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr >
* [GH-8327] Change option from entity-manager to em for consistency with DoctrineBundle.
* Add final to new methods and classes
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr >
* [GH-8327] Bugfix: phpstan detected stricter type checks needed.
* phpcs
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr >
2021-04-18 14:32:42 +02:00
Jakub Caban
a2230485b2
Fix typed properties for default metadata ( #7939 ) ( #8589 )
...
* Make Column::$type, Column::$nullable and JoinColumn::$nullable nullable by default
* Add tests for mapped typed properties (type and nullable)
* Fix Yaml driver tests and remove driver exceptions thrown too early
* Fix PHP driver tests
* Fix static PHP driver tests
* Fix XML driver tests
* Coding Standards
* Deprecate unused MappingException method
* Add manyToOne test and check nullable at the right place
* Coding Standards
* Bugfix: Temporarily change association join columns in CascadeRemoveOrderTest to circumvent new CommitOrderCalculator bug.
* phpcs
Co-authored-by: Benjamin Eberlei <kontakt@beberlei.de >
2021-04-18 14:26:41 +02:00
Benjamin Eberlei
a68aa580c5
[GH-8345] Fields for unique constraints ( #8629 )
...
* Add possibility to use fields instead of column for unique constraint and indexes (#8345 )
* Document changes in annotation reference
* phpcs
* Ensure exactly one of fields/columns is set for index/uniqueConstraint
* Adapt docs to fields/columns changes
* phpcs
* Implement fields in Attribute driver and fix mapping classes constructors.
* Coding Standard
* Apply suggestions from code review
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr >
* phpcs
Co-authored-by: Jakub Caban <kuba.iluvatar@gmail.com >
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr >
2021-04-18 14:06:30 +02:00
Grégoire Paris
5ee71c54d4
Update ignore rules to reflect current situation
...
We no longer use Travis, we do not use git submodules as far as I know,
and we now use baseline files as well as project metadata.
2021-04-18 10:49:48 +02:00
orklah
dc37c2cd2f
psalm fixes
2021-04-17 17:11:04 +02:00
Grégoire Paris
261a405970
Merge pull request #8635 from greg0ire/2.9.x
...
Manually merge 2.8.x into 2.9.x
2021-04-17 16:42:07 +02:00
Grégoire Paris
1ea51d88c4
Merge remote-tracking branch 'origin/2.8.x' into 2.9.x
2021-04-17 16:31:14 +02:00
Grégoire Paris
da3a9fa361
Merge pull request #8634 from orklah/static-upgrade
...
upgrade static tools
2021-04-17 15:41:51 +02:00
orklah
4fd81d26ff
upgrade static tools
2021-04-17 13:12:35 +02:00
Benjamin Eberlei
f8e06ad31e
[GH-6396] Allow custom hydrators access to meta columns via Query::HINT_INCLUDE_META_COLUMNS hint. ( #8382 )
2021-04-16 21:27:29 +02:00
Grégoire Paris
559c1ba806
Merge pull request #8628 from greg0ire/2.9.x
...
Merge 2.8.x up into 2.9.x
2021-04-16 20:08:51 +02:00
Grégoire Paris
4665758c44
Merge remote-tracking branch 'origin/2.8.x' into 2.9.x
2021-04-16 19:59:27 +02:00
Grégoire Paris
e2e9f8fa97
Merge pull request #8627 from greg0ire/add-baselines
...
Add baseline files for static analyzers
2021-04-16 19:04:04 +02:00
Grégoire Paris
f7249ec709
Declare return type
...
This helps SA tools figure out that it is fine to call count on the
return value of that method.
As a side-effect, using $metadata->name is not really an option since it
is not part of the ClassMetadata interface.
2021-04-16 13:14:54 +02:00
Grégoire Paris
87dbcca454
Add baseline files for static analyzers
...
There are many CS and SA-related changes in the ORM as we pursue better
code quality, and easier contributions. These often involve huge
changes, which can be hard to review and inevitably lead to some
regressions. I know some of those could have been avoided if we were
using stricter levels for PHPStan and Psalm.
By adding baselines, we ensure new code is at level 5 for both tools,
which should allow us to catch the most interesting issues.
2021-04-16 09:23:11 +02:00
Grégoire Paris
ceeea8ccd1
Merge pull request #8620 from greg0ire/2.9.x
...
Manually merge 2.8.x into 2.9.x
2021-04-13 19:23:10 +02:00
Grégoire Paris
6e16ef8c31
Merge remote-tracking branch 'origin/2.8.x' into 2.9.x
2021-04-13 18:51:39 +02:00
Grégoire Paris
305e0d6664
Merge pull request #8617 from greg0ire/cs9
...
Upgrade to doctrine/coding-standard 9
2021-04-13 18:48:12 +02:00
Grégoire Paris
199be94e6d
Upgrade to doctrine/coding-standard 9
2021-04-13 09:00:33 +02:00
Benjamin Eberlei
09a7d9f18a
[GH-6578] Add validation that inherited entity class is mapped in discriminator. ( #8378 )
2021-04-10 18:13:31 +02:00
Grégoire Paris
f57f33b67f
Merge pull request #8606 from greg0ire/2.9.x
2021-04-09 13:33:34 +02:00
Grégoire Paris
e86cddb360
Merge remote-tracking branch 'origin/2.8.x' into 2.9.x
2021-04-09 13:21:30 +02:00
Grégoire Paris
fa588af3b1
Merge pull request #8604 from janatjak/2.8.x
...
Fix psalm param typehint for OneToManyAssociationBuilder::setOrderBy method
2021-04-09 12:57:12 +02:00
Grégoire Paris
d4741720fa
Merge pull request #8605 from greg0ire/fix-phpdoc-lsp-violations
2021-04-09 11:59:28 +02:00
Grégoire Paris
343385d060
Pin squizlabs/php_codesniffer
...
We are referencing rules in phpcs.xml.dist, and may experience
unexpected BC-breaks because of that when they get renamed.
2021-04-09 09:27:44 +02:00
Grégoire Paris
6d04dced03
Address sniff rename
...
This sniff seems to have been renamed or split in the latest version of
phpcs.
2021-04-09 09:19:10 +02:00
Grégoire Paris
22fa3a8556
Document actual return types
...
Some executors may return integers, for instance executors that only
execute update or delete statements.
Also, in case an integer is not returned, what's actually returned is a
Doctrine\DBAL\Driver\ResultStatement, and not a Doctrine\DBAL\Driver\Statement
2021-04-09 08:52:56 +02:00
Jakub Janata
eb05756dc3
Fix psalm param typehint for OneToManyAssociationBuilder::setOrderBy method
2021-04-08 22:52:50 +02:00
Grégoire Paris
5bb7e20708
Merge pull request #8602 from NicoHaase/fix-8599
...
Adjusted return type annotation for getOriginalEntityData
2021-04-07 23:22:19 +02:00
Nico Haase
a9076313c7
Adjusted return type
2021-04-07 21:06:58 +02:00
Grégoire Paris
2a87821b28
Merge pull request #8552 from acoulton/maint-phpunit-upgrade
2021-04-07 15:33:06 +02:00
acoulton
da5877d60c
Only polyfill older phpunit methods when required
2021-04-07 12:08:55 +01:00
Andrew Coulton
67dfe8e1af
Simplify mock building calls
...
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr >
2021-04-07 11:07:35 +01:00
Vincent Langlet
2dfe51b396
Remove internal tag
2021-04-07 11:41:34 +02:00
Grégoire Paris
5ac036de02
Merge pull request #8594 from greg0ire/make-sure-test-is-run
2021-04-06 17:47:17 +02:00
Grégoire Paris
fda0d7b440
Merge pull request #8596 from doctrine/2.8.x-merge-up-into-2.9.x_606c485ba431f2.86881997
2021-04-06 15:06:02 +02:00
Grégoire Paris
23e1fd8ad6
Drop assertion about not being an instance of proxy
...
We do not want to enforce it as it is an internal details that seems to
vary from environment to environment.
2021-04-06 14:55:25 +02:00
Benjamin Eberlei
f8fa0fe069
[GH-8592] Deprecated Named (Native) Queries in Metadata/EntityRepository ( #8593 )
...
* [GH-8592] Deprecated Named (Native) Queries in Metadata and EntityRepository.
* [GH-8592] Add deprecation notice for named queries in docs [ci-skip]
2021-04-05 21:59:08 +02:00
Grégoire Paris
a588555ecd
Merge pull request #8586 from KartaviK/patch-3
...
Additional psalm param typehint for orderBy argument in findBy method
2021-04-05 20:38:36 +02:00
Grégoire Paris
501057da83
Ensure test is suffixed with Test
2021-04-05 14:42:17 +02:00
Grégoire Paris
7de84537f6
Merge pull request #8591 from DmitriiBezborodnikov/case_insensive_parenthesis
...
Return case insensitive check
2021-04-05 14:40:51 +02:00
Grégoire Paris
97f8325dad
Make sure tests are suffixed with Test
...
They will not be taken into account when running vendor/bin/phpunit
otherwise.
2021-04-05 14:32:40 +02:00
Grégoire Paris
0ebd7052d7
Drop create table at shutdown
...
It makes tests more isolated from each other: another test relying on
some tables including some of the ones created here may fail creating
the tables it needs because they already exist.
2021-04-05 14:03:49 +02:00
Dmitrii Bezborodnikov
5d73378b92
Return case insensitive check
2021-04-05 14:03:49 +02:00
Grégoire Paris
10572ec441
Merge pull request #8590 from VincentLanglet/patch-2
...
Fix phpdoc of ClassMetadataInfo::getIdentifierValues
2021-04-04 23:47:09 +02:00
Vincent Langlet
76278d801d
Fix phpdoc
2021-04-04 21:19:54 +02:00
Roman Varkuta
ca80830b26
Describe $orderBy parameter as a hash
...
A list of string is incorrect, it actually looks like this:
['someField' => 'DESC', 'someOtherField' => 'ASC'…]`
2021-04-03 12:45:24 +02:00
Grégoire Paris
1ed89c756a
Merge pull request #8582 from doctrine/2.8.x-merge-up-into-2.9.x_6066399d9875f8.96494390
...
Merge release 2.8.3 into 2.9.x
2021-04-02 09:12:58 +02:00
Grégoire Paris
bb078b5cb7
Merge remote-tracking branch 'origin/2.8.x' into 2.8.x-merge-up-into-2.9.x_6066399d9875f8.96494390
2021-04-02 09:00:35 +02:00
Grégoire Paris
bcb4889a2c
Merge pull request #8583 from greg0ire/sync-static-analysis-workflows
...
Synchronize static analysis jobs with upstream
2021-04-02 08:58:50 +02:00
Grégoire Paris
961da8b0cc
Synchronize static analysis jobs with upstream
2021-04-01 23:32:04 +02:00
Benjamin Eberlei
657a30f8ce
[GH-6394] Bugfix: IdentifierFlattener support for association non-object values. ( #8384 )
...
* [GH-6394] Bugfix: IdentifierFlattener support for association non-object values
* [GH-6394] Bugfix: BasicEntityPersister::update used wrong identifiers for version assignment.
* Exclude MissingNativeTypeHint phpcs rule as 7.4 is not lowest version.
2021-04-01 23:16:53 +02:00
Benjamin Eberlei
c3f8996af5
Bump requirement to DBAL 2.13 ( #8577 )
2021-04-01 21:26:25 +02:00
Grégoire Paris
0655083e50
Merge remote-tracking branch 'origin/2.8.x' into 2.9.x
2021-04-01 09:02:08 +02:00
Grégoire Paris
0b25d4d8b0
Merge pull request #8573 from greg0ire/fix-build
...
Fix build issues
2021-04-01 07:49:27 +02:00
Grégoire Paris
a88242ee6c
Adapt test logic to PHP and SQLite
...
There seems to be at least 2 camps in the software world when it comes
to the question "What's today minus one month", today being at the end
of march.
While PHP and SQLite agree that that would be the 2nd of March, other
RDBMS than SQLite and humans will tell you that it's the last day of
February.
This patch ensures that we check one logic for SQLite, and the other
logic for other platforms.
2021-03-30 21:08:29 +02:00
Grégoire Paris
fe4964008d
Accommodate 2 behaviors of symfony/console in test
...
Decorated text used to be wrapped too early in SymfonyStyle->block()
See https://github.com/symfony/symfony/pull/40348
The fix was not contributed to version 3, which means we have to rewrite
the test so that it passes for both the correct and the buggy version.
2021-03-30 08:41:10 +02:00
Grégoire Paris
3f3de70c3e
Merge pull request #8564 from cybercitizen7/featureIncludeDirectory
...
Adding DIR to include statement to fix issue with pathing
2021-03-26 19:46:40 +01:00
darkw1z
eb4e317144
Adding DIR to include statement to fix issue with pathing
2021-03-26 14:04:46 +01:00
Grégoire Paris
c8f2f61ea1
Merge pull request #8556 from VincentLanglet/patch-2
...
Fix fieldMapping phpdoc
2021-03-26 08:26:40 +01:00
Vincent Langlet
c9502d3d0b
Fix fieldMapping phpdoc
2021-03-24 15:07:08 +01:00
Benjamin Eberlei
b6b3c97436
[GH-8265] Attribute Metadata Driver ( #8266 )
...
* [GH-8265] Prototype for Attribute Metadata Driver
* [GH-8265] Skip AttributeDriverTest on PHP 7.
* [GH-8265] Fill more test entities with Attribute declarations to pass tests.
* [GH-8265] More test entity attributes for passing AttributeDriverTest.
* [GH-8265] Final changes to get AttributeDriverTest passing with test entities.
* [GH-8265] automatically update cs for new code when possible.
* [GH-8265] exclude sniffs that break because of phpcs not knowing attributes.
* [GH-8265] Fix AttributeReader styles.
* [GH-8265] Fix AttributeReader styles.
* [GH-8265] Missing changes to AttributeDriver
* [GH-8265] Fix InverseJoinColumn attribute cs violations.
* [GH-8265] Fix AbstractMappingDriverTest::_loadDriver and other CS
* [GH-8265] Coding styles
* [GH-8265] Coding styles
* [GH-8265] Coding styles
* [GH-8265] Coding styles
* [GH-8265] Convert Cache, ChangeTrackingPolicy, Column to named annotations.
* [GH-8265] Convert all annotations to named constructor for attribute support.
* [GH-8265] Style after attribute changes.
* [GH-8265] more styles
* [GH-8265] Remove workaround code for attributes.
* More cs
* More cs
* More cs
* More cs
* Add Attribute Metadata driver reference.
* Housekeeping: phpcs
* More merge conflict resolutions
* phpcs
* fix broken merge
* Change NamedArgumentConstructorAnnotation interface to use NamedArgumentConstructor annotation instead.
* phpcs
* Housekeeping: cs
* Housekeeping: cs
* Update docs with review comments
* Improve attribute docs
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr >
* Rename AttributesDriver to AttributeDriver
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr >
2021-03-23 13:30:57 +01:00
Benjamin Eberlei
8f6d146bc4
Bump doctrine/deprecations to at least v0.5.3 ( #8553 )
2021-03-22 23:23:03 +01:00
Grégoire Paris
3358ccde39
Merge pull request #8547 from greg0ire/psalm-lv6-phpdoc
...
Make phpdoc types correct
2021-03-21 22:11:51 +01:00
acoulton
1f4e6ebeeb
Add a forward-compatibility wrapper for phpunit8 assertions
...
While doctrine still supports php7.2 the test cases need to run
under phpunit8 as well. However some assertion methods produce
deprecation warnings in the test output with phpunit >= 9.
This commit adds a thin forward compatiblity wrapper for the
new assertion method names so that they can be used with both
supported phpunit versions.
2021-03-18 11:25:18 +00:00
acoulton
a94db4f5c0
Fix remaining warnings from the phpunit9 upgrade
...
Some tests were still using deprecated assertion and mocking methods,
resulting in a long list of warnings in the phpunit output.
This commit resolves all the warnings:
* Fixes a couple of test names in `@depends` tags (presumably these
tests were renamed at some point for coding standards).
* Changes how mocks are configured when asserting the same method
is called multiple times with a sequence of arguments / sequence
of return values. The old `->at` expectation is deprecated because
it can be brittle and give unreliable results. Some of this
mocking could probably still be refactored further, but my focus
was on solving the deprecation with the existing setup.
* Removes one use of prophecy for mocking, in favour of using
phpunit mock objects. Prophecy now requires an extra composer
dependency and a trait which seems overkill given it was only
used in one place.
* Updates to the new names for assertFileExists and assertRegExp
(and their `not` versions) - these are functionally equivalent.
* Replaces the last few references to old PHPUnit_Framework_XXX
classes with their namespaced equivalent. These were mostly in
comments, or in native php `assert()` statements that were sanity
checking mocked object types. These asserts are probably redundant
(and are clearly not running in CI since the classes they referenced
no longer exist).
2021-03-18 10:51:43 +00:00
Grégoire Paris
47475f3a67
Merge pull request #8532 from acoulton/bug-fix-ci-db-connection
...
All CI runs are using the sqlite fallback connection instead of the expected driver
2021-03-17 19:49:56 +01:00
acoulton
61c4a5da0a
Rename tmpdb_ to privileged_db in test config and TestUtil
...
To avoid confusion, the `tmpdb_` test config values are now named
`privileged_db_` and better documented in the phpunit.xml.dist.
The TestUtil class has been refactored to more closely mirror the
structure and method / variable naming of the equivalent in
doctrine/dbal. This does not introduce any significant functional
changes. The only real difference is that the test output now prints
the selected database driver the first time it is referenced,
rather than repeating this through the test run.
2021-03-17 10:31:22 +00:00
acoulton
dd34bca4eb
Upgrade previously-skipped tests to phpunit 9
...
These tests had not been running in CI so missed the previous
phpunit upgrade.
Note that assertions in decimal/floaty values in GH7941Test have
been changed to compare numerically with a reasonable level of
precision, instead of using regex. This is because the types
returned by the different drivers are inconsistent, and phpunit
now only allows regex comparisons on strings.
2021-03-17 10:31:22 +00:00
acoulton
3e21c50f61
Fix unit test and CI database driver / credential configuration
...
Builds using the github actions phpunit.xml files were not properly
recognising driver-specific configuration values, so were all
falling back to use the in-memory sqlite database instead of the
expected driver. This also meant a number of tests were skipped
as they rely on functionality not available in sqlite.
This commit addresses that by:
* REMOVING the automatic fallback to the sqlite memory database -
phpunit.xml must now always specify explicit parameters for the
desired connection.
* Displaying the active driver in the build output for visibility
and debugging.
* Changing the way TestUtil loads the database config in line
with the equivalent logic in doctrine/dbal, and to support the
way that the config is/was specified in the phpunit.xml files
for CI.
Note that this means a couple of the expected config variable names
have changed. Developers that are using customised phpunit.xml files
locally will need to update them to provide:
* Database config variables if they want to use the sqlite/memory
driver - see phpunit.xml.dist for details.
* `db_driver` instead of `db_type`
* `db_user` instead of `db_username`
* `db_dbname` instead of `db_name`
* And, if in use, the equivalent changes to the `tmpdb_` values
The other change is that now if you provide any value for
`db_driver` we will attempt to create that connection type and
that will throw if other details (username / password / etc as
required by the driver) are not provided. Previously providing
partial configuration would cause TestUtil to silently fall back
to the in-memory sqlite driver.
2021-03-17 10:31:22 +00:00
Grégoire Paris
bc3592bcc8
Make phpdoc type correct
2021-03-16 19:20:11 +01:00
Grégoire Paris
4fccec1322
Merge pull request #8545 from orklah/psalm-plugins-2
...
remove some empty() use when safe
2021-03-15 23:51:09 +01:00
orklah
0177133385
remove unwanted check with 0
2021-03-15 23:28:20 +01:00
orklah
8df5cb84fa
remove some empty() use when safe
2021-03-15 23:28:19 +01:00
Grégoire Paris
3b7275e183
Merge remote-tracking branch 'origin/2.8.x' into 2.9.x
2021-03-14 18:57:41 +01:00
Grégoire Paris
5247c56fce
Merge pull request #8539 from greg0ire/cs-20210311
...
🎉 Final CS batch 🎉
2021-03-14 18:47:03 +01:00
Grégoire Paris
cc37c490c2
Synchronize coding standard workflow with upstream
...
Now that there no longer are cs issues, we can thank diff-sniffer and
kiss it goodbye!
2021-03-13 09:55:38 +01:00
Grégoire Paris
95824efd61
Manually fix cs
2021-03-13 09:46:38 +01:00
Grégoire Paris
44d4712e64
Ignore rule about annotation phpdoc
...
These phpdoc is parsed by doctrine/annotations, and that package does
not understand things like array<string, mixed> yet.
2021-03-13 09:46:38 +01:00
Grégoire Paris
930f44c02f
Ignore rule for externally-defined property
2021-03-13 00:08:03 +01:00
Grégoire Paris
6e3c011e65
Ignore rule about superflous comment
...
We can fix it with a breaking change.
2021-03-13 00:08:03 +01:00
Grégoire Paris
a82de0d422
Ignore rule about unused method
...
It cannot work when you call the private method like a callable.
2021-03-13 00:08:03 +01:00
Grégoire Paris
9917488179
Ignore rule about empty statements
...
This should be implemented in a separate pull request.
2021-03-12 08:20:46 +01:00
Grégoire Paris
93f31d2c33
Merge pull request #8533 from acoulton/test-string-lock-version
...
Add test coverage for passing optimistic lock version as string
2021-03-11 21:41:32 +01:00
acoulton
77356b954f
Add test coverage for passing optimistic lock version as string
...
As discussed in #8527 , when using optimistic locking with integer
version columns, Doctrine has always supported passing the lock
version as a string. For example when passing in a version
received in POST / GET.
Technically speaking this does not comply with the docs and phdoc
(which show the app explicitly casting to int before passing).
Nonetheless the maintainers decided it should continue to be valid
for now and reinstated the old soft-equals logic with #8531 .
This modified test just avoids accidental changes in future.
2021-03-11 13:24:53 +00:00
Grégoire Paris
92f764206e
Ignore broken rule
2021-03-11 09:11:24 +01:00
Grégoire Paris
141539673e
Merge pull request #8530 from doctrine/cs-20210310
...
CS-batch 25/26 🤩
2021-03-11 00:05:31 +01:00
Grégoire Paris
23dc804c9b
Merge pull request #8531 from beberlei/GH-8527-RevertLockEquals
...
[GH-8527] Revert cs fixes for entity version compares in lock+merge
2021-03-10 23:30:25 +01:00
Benjamin Eberlei
9e3baa7baa
[GH-8527] Revert cs fixes for entity version compares in lock+merge
2021-03-10 22:46:07 +01:00
Grégoire Paris
322ea51ecf
Manually fix cs
2021-03-10 22:17:31 +01:00
Grégoire Paris
21b046452b
Merge pull request #8529 from greg0ire/cs-20210308
...
CS batch 24/26 🤞
2021-03-10 19:53:52 +01:00
Grégoire Paris
c57b81ada4
Manually fix cs
2021-03-09 21:15:33 +01:00
Grégoire Paris
4fa7c9c6de
Merge pull request #8521 from greg0ire/cs-20210228
...
CS batch 23/an estimated 26
2021-03-08 19:57:18 +01:00
Benjamin Eberlei
2685b65c2b
[GH-6855] Trigger deprecation for unsupported lifecycle callback mapping on embedded classes.( #8381 )
2021-03-04 22:08:11 +01:00
Benjamin Eberlei
3902a4eb6e
[GH-8458] Properly deprecate ConvertDoctrine1Schema ( #8517 )
2021-03-02 09:38:09 +01:00
Jakub Caban
b3ed525d4d
Use typed properties for default metadata for #7939 ( #8439 )
...
[GH-7939] Detect column and association types from typed properties.
* Use typed properties for default metadata for #7939
* Coding Standards
* Remove $name from CmsUserTypes and adapt tests
* Factor out conditions required for typed property
* Factor out typed validation and completion methods
* Move Typed tests model to separate namespace
* Don't pass by reference, return array
* Document changes to default mapping for typed properties
* Better wording in annotation reference
* Add missing targetEntity assertion on typed association
* Try to comply with CS
* USe constants instead of strings
* Use one-line comments for single line content
* phpcs
* phpcs
Co-authored-by: Benjamin Eberlei <kontakt@beberlei.de >
2021-03-01 22:13:58 +01:00
Grégoire Paris
3580517aac
Manually fix cs
2021-03-01 21:49:10 +01:00
Benjamin Eberlei
4cdc6b1a71
[GH-7128] Improve OneToManyRequiresMappedBy Exception message ( #8380 )
2021-03-01 21:42:57 +01:00
plfort
38ccbd8638
DDC-2076 - MEMBER OF - Remove useless join over target table of ManyToMany relationship ( #8438 )
...
Co-authored-by: Pierre-Louis FORT <pierre-louis.fort@theia.fr >
2021-02-28 23:37:40 +01:00
Grégoire Paris
f9e7c3c2d8
Merge pull request #8516 from greg0ire/cs-20210227
...
CS batch 22/an estimated 26
2021-02-28 21:27:52 +01:00
Grégoire Paris
3600c0fbca
Manually fix cs
2021-02-28 18:31:38 +01:00
Grégoire Paris
f779513042
Remove unused properties
...
They should have been removed as part of a6b43b93ac
2021-02-28 18:31:38 +01:00
Benjamin Eberlei
b4e6530d2d
[GH-8471] Deprecate Partial DQL syntax and forcing partial loads. ( #8472 )
...
* [GH-8471] Deprecate Partial DQL syntax and forcing partial loads.
2021-02-28 18:17:12 +01:00
Diego Rin Martín
07d426edf5
Changed lock function to compare timestamps instead of DateTimeInterface objects directly. ( #8508 )
...
When using optimistic lock with DateTimeInterface based version field a bug appears due to the use of the === operator for comparing the lock version and the entity version. This comparison always resolves to false because the === operator when comparing objects is only true when both sides are the exact same instance of the object.
To fix the issue I have decided to compare timestamps instead the DateTimeInterface based objects directly, calling getTimestamp() method and doing a strict comparison.
Modified OptimisticLockException to use DateTimeInterface instead of DateTime class.
Added test suite to cover case.
Fixes #8499
2021-02-27 18:40:48 +01:00
Grégoire Paris
4afd4069be
Merge pull request #8515 from greg0ire/cs-20210226
...
CS batch 21/an estimated 26
2021-02-27 14:30:25 +01:00
Grégoire Paris
239215c2e5
Merge pull request #8502 from greg0ire/rework-contributing-md
...
Rework CONTRIBUTING.md
2021-02-27 13:03:20 +01:00
Grégoire Paris
e6f11652d2
Add section for 2.9.x branch
2021-02-27 12:16:49 +01:00
Grégoire Paris
2910a73927
Rework badges urls
...
Some .x were missing, and ugly urlencoding can be avoided.
2021-02-27 12:10:47 +01:00
Grégoire Paris
3959b2743c
Remove references to Travis
2021-02-27 12:03:35 +01:00
Grégoire Paris
658e54027e
Remove trailing whitespace
2021-02-27 12:01:06 +01:00
Grégoire Paris
ba882451b0
Refer to our actual coding/standard
...
We do much more than just PSR 1 and 2
2021-02-27 12:01:05 +01:00
Grégoire Paris
1ed9840123
Refer to global workflow policy
...
We are doing things differently now, and the how is already documented.
2021-02-27 12:01:05 +01:00
Grégoire Paris
71044894a1
Manually fix cs
2021-02-26 21:30:49 +01:00
Grégoire Paris
1a41d6b87c
Fix configuration mix up
2021-02-26 08:25:44 +01:00
Grégoire Paris
5dfcb08999
Merge pull request #8512 from greg0ire/cs-20210225
...
CS batch 20/an estimated 26
2021-02-25 23:23:24 +01:00
Grégoire Paris
284bd6fd03
Manually fix cs
2021-02-25 21:22:50 +01:00
Grégoire Paris
e40ac3e1d0
Merge pull request #8510 from greg0ire/cs-20210224
...
CS batch 19/an estimated 26
2021-02-24 22:41:28 +01:00
Grégoire Paris
0bce2472f2
Manually fix cs
2021-02-24 18:51:02 +01:00
Grégoire Paris
89f57de884
Merge pull request #8504 from greg0ire/cs-20210223
...
CS batch 18/an estimated 26
2021-02-23 23:18:42 +01:00
Grégoire Paris
ae19f40958
Merge pull request #8495 from Warxcell/fix_to_iterable_with_cache
...
Fix bug when using Result Cache with Query::toIterable
2021-02-23 20:16:39 +01:00
Grégoire Paris
c2d69a3c48
Merge pull request #8507 from greg0ire/address-move-away-from-master
...
Address move away from master
2021-02-23 18:19:47 +01:00
Grégoire Paris
6ce91dd37b
Address move away from master
2021-02-23 09:24:40 +01:00
Grégoire Paris
57e6ba25c9
Merge pull request #8505 from dbu/patch-1
...
fix typo in changelog
2021-02-23 08:56:31 +01:00
David Buchmann
9d2e67bbb4
fix typo in changelog
2021-02-23 08:17:31 +01:00
Grégoire Paris
2dce5b20ad
Manually fix cs
2021-02-22 23:50:09 +01:00
Warxcell
930859f803
Fix bug when using ResultCache with Query::toIterable.
...
Signed-off-by: Warxcell <warxcell@gmail.com >
2021-02-22 23:35:22 +02:00
Yup
a70c73ae3a
Use RegEx to match if queryPart contains OR/AND ( #8453 )
...
This allows fixes cases of queries that contain line feeds or tabs but
do not benefit from automatic wrapping of parenthesis.
2021-02-22 20:58:06 +01:00
David Buchmann
074346b8d5
Note deprecation of AbstractQuery::iterator ( #8497 )
2021-02-22 20:30:05 +01:00
Grégoire Paris
9ed4a8c043
Merge pull request #8498 from greg0ire/cs-20210222
...
CS batch 17/an estimated 26
2021-02-22 20:25:06 +01:00
Grégoire Paris
9c917811e5
Manually fix cs
2021-02-22 09:12:04 +01:00
Grégoire Paris
f883820257
Ignore rule about wrong comment style
2021-02-22 08:48:46 +01:00
Grégoire Paris
a32045dd51
Ignore rule violated by external package
2021-02-22 07:52:57 +01:00
Grégoire Paris
672b04a55d
Merge pull request #8483 from olsavmic/fix-single-scalar-hydrator-memory-leak-on-exception
...
Fix single scalar hydrator memory leak on exception
2021-02-21 21:12:50 +01:00
Grégoire Paris
261334aca2
Merge pull request #8494 from greg0ire/cs-20210221
...
CS batch 16/an estimated 26
2021-02-21 20:29:47 +01:00
Warxcell
7f6ed094cd
Add test to verify that using ResultCache with Query::toIterable is failing.
2021-02-21 21:12:52 +02:00
Grégoire Paris
a792655813
Manually fix cs
2021-02-21 12:20:19 +01:00
Grégoire Paris
fb71204910
Relax assertion ( #8493 )
...
EntityManager is too restrictive, any implementation can actually be
returned here.
Closes #8488
2021-02-21 07:43:56 +01:00
Grégoire Paris
b918661cf1
Merge pull request #8492 from greg0ire/cs-20210220
...
CS batch 15/an estimated 26
2021-02-20 20:49:25 +01:00
Michael Olšavský
7971a53164
Method hydrateAll() does not take into account possible exception
...
from hydrateAllData() which in turn does not call cleanup()
2021-02-20 18:58:50 +01:00
Grégoire Paris
a175f96ae8
Manually fix cs
2021-02-20 15:37:15 +01:00
Grégoire Paris
7c1cde6471
Ignore rule that triggers on external property
2021-02-20 15:32:26 +01:00
Grégoire Paris
1ffc0cacf4
Merge pull request #8491 from greg0ire/cs-20210219
...
CS batch 14/an estimated 26
2021-02-20 11:10:27 +01:00
Grégoire Paris
e979d0d50f
Manually fix cs
2021-02-20 00:01:41 +01:00
Grégoire Paris
553ea03079
Ignore rule about case mismatch
...
@group does not have to do with the Group entity at all.
2021-02-19 23:33:25 +01:00
Grégoire Paris
149014879d
Ignore rule about property defined externally
2021-02-19 23:11:43 +01:00
Grégoire Paris
b991c58988
Merge pull request #8490 from greg0ire/cs-20210218
...
CS batch 13/an estimated 26
2021-02-19 23:08:25 +01:00
Aleksandr Frolov
ee9627b82e
Update QueryBuilder::setParameters docs ( #8487 )
...
Use `ArrayCollection` instead of plain array (which is supported only for bc)
2021-02-19 01:45:14 +01:00
Grégoire Paris
e3f03414f9
Manually fix cs
2021-02-18 23:17:03 +01:00
Grégoire Paris
1f406fd3df
Merge pull request #8484 from greg0ire/cs-20210217
...
CS batch 12/an estimated 26
2021-02-18 21:54:43 +01:00
Grégoire Paris
0ae53a6703
Merge pull request #8485 from doctrine/2.8.x-merge-up-into-2.9.x_602d59a0aa86b9.63081052
...
Merge release 2.8.2 into 2.9.x
2021-02-17 20:50:44 +01:00
Grégoire Paris
49864a7f57
Merge remote-tracking branch 'origin/2.8.x' into 2.8.x-merge-up-into-2.9.x_602d59a0aa86b9.63081052
2021-02-17 20:39:28 +01:00
Grégoire Paris
b747bf15ff
Manually fix cs
2021-02-17 16:32:39 +01:00
Grégoire Paris
5fe85bfc03
Ignore rule about underscore in method name
...
We inherit from a class defined in another package.
2021-02-17 15:55:21 +01:00
Grégoire Paris
0dccf05ca8
Automatically fix cs
2021-02-17 15:55:21 +01:00
Grégoire Paris
ebae57eb96
Merge pull request #8480 from greg0ire/cs-20210216
...
CS batch 11/an estimated 26
2021-02-16 23:10:18 +01:00
Benjamin Eberlei
30a7c2aa67
[GH-8410] Fix memory leak in new toIterable and state bug. ( #8467 )
...
* [GH-8410] Fix memory leak in new toIterable and state bug.
The new AbstractQuery::toIterable() had a memory leak that
AbstractQuery::iterable() did not have. This leak is now fixed.
After fixing the leak, one test failed where the identity map in
ObjectHydrator triggered and lead to a notice. Introduced a new
AbstractHydrator::cleanupAfterRowIteration() that the ObjectHydrator
uses to cleanup the state.
* [GH-8413] Bugfix: Iterating with multiple, mixed results
When multiple entity results are part of a row, the result handling
must be different. In addition mixed results with scalars are broken
and now throw an exception as illegal operation.
* Housekeeping: phpcs
* [GH-8413] Add assertions for entity alias iteration.
* [GH-8387] Missing @deprecated on Query::iterate
2021-02-16 17:52:20 +01:00
Benjamin Eberlei
3a9b8fde9b
Housekeeping: Fix cs
2021-02-16 16:24:19 +01:00
Yosh
4f864bc178
Identifier type is not set when many2many relations are deleted ( #8401 )
...
* Ensure identifier type is set on deleteJoinTableRecords
* Housekeeping: phpcs
* Housekeeping: phpcs
Co-authored-by: Benjamin Eberlei <kontakt@beberlei.de >
2021-02-16 16:12:39 +01:00
Grégoire Paris
d76cbd755f
Manually fix cs
2021-02-16 09:07:26 +01:00
Grégoire Paris
4aece04ae7
Automatically fix cs
2021-02-16 08:48:48 +01:00
Grégoire Paris
f31dbf8d4e
Merge pull request #8479 from greg0ire/cs-20210215
...
CS batch 10/an estimated 27
2021-02-15 23:44:27 +01:00
Grégoire Paris
416f35dba9
Manually fix cs
2021-02-14 21:00:58 +01:00
Grégoire Paris
c29370e061
Automatically fix cs
2021-02-14 14:39:35 +01:00
Grégoire Paris
4e0f6837d0
Merge pull request #8478 from beberlei/CsFixes2
...
CS Fixes 2 string interpolation to sprintf
2021-02-14 14:39:00 +01:00
Benjamin Eberlei
e45d212f02
Housekeeping: CS fixes Doctrine\ORM\Mapping\MappingException
2021-02-14 14:28:42 +01:00
Benjamin Eberlei
8f62bd39b5
Housekeeping: CS fixes Doctrine\ORM\ORMException
2021-02-14 09:53:19 +01:00
Benjamin Eberlei
5e11afcdf1
Housekeeping: CS fixes Doctrine\ORM\Mapping\MappingException
2021-02-14 09:49:39 +01:00
Benjamin Eberlei
f833222017
Cs fixes1 ( #8475 )
...
* Housekeeping: CS Query, AbstractQuery, NativeQuery.
* Housekeeping: phpcs TreeWalker
* Housekeeping: CS Doctrine\ORM\EntityManager
* Housekeeping: CS Doctrine\ORM\Cache
* Upgrade git-phpcs
* Drop unused method parameter
* Describe types more precisely
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr >
2021-02-14 09:23:15 +01:00
Grégoire Paris
c7f39ebbde
Merge pull request #8477 from greg0ire/cs-20210214
...
CS batch 9/an estimated 28
2021-02-14 09:20:11 +01:00
Grégoire Paris
15f08ed006
Manually fix cs
2021-02-14 00:04:18 +01:00
Grégoire Paris
b6fd4b5ef3
Automatically fix cs
2021-02-14 00:04:11 +01:00
Benjamin Eberlei
e2e59e94f5
[GH-8383] deprecate notify change tracking policy ( #8473 )
...
* [GH-8383] Deprecate notify change tracking policy.
* [GH-8383] Add warning to documentation about notify change tracking policy deprecation.
2021-02-13 23:14:28 +01:00
Grégoire Paris
5e4dae88f3
Merge pull request #8476 from greg0ire/cs-20210213
...
CS batch 8/an estimated 30
2021-02-13 17:26:58 +01:00
Grégoire Paris
7312ddeda7
Manually fix cs
2021-02-13 13:46:01 +01:00
Grégoire Paris
9a67b6f699
Merge pull request #8474 from greg0ire/cs-20210212
...
CS batch 7/an estimated 30
2021-02-12 23:03:28 +01:00
Grégoire Paris
f59a0c349b
Manually fix cs
2021-02-12 20:43:17 +01:00
Grégoire Paris
4c8831f716
Remove unused helper method
2021-02-12 20:04:56 +01:00
Benjamin Eberlei
6fe388a705
Introduce doctrine/deprecations ( #8466 )
...
* Introduce doctrine/deprecations, empty out VerifyDeprecations trait for now.
* Replace more usages of VerifyDeprecations (akwardkly for now)
* Update doctrine/deprecations to v0.2.0
* Remove ORM VerifyDeprecations trait and its use.
* Use doctrine/deprecatios VerifyDeprecations trait where useful
* Housekeeping: phpcs
* Fix reference link for toIterable/iterate deprecation
2021-02-12 18:14:34 +01:00
Vincent Langlet
172a8d9414
Restrict EntityManagerInterface::getRepository ( #8417 )
2021-02-12 17:44:22 +01:00
Grégoire Paris
01ca442be7
Ignore error about no assignment
...
These files must be require'd
2021-02-12 08:45:07 +01:00
Grégoire Paris
01374ca2ab
Ignore rule about lone comment
...
That comment is mistaken for a method comment because it precedes one.
The issue was reported but will most likely not be fixed.
2021-02-12 07:39:56 +01:00
Grégoire Paris
94e8b1d43c
Merge pull request #8470 from greg0ire/cs-20210211
...
CS batch 6/an estimated 30
2021-02-12 07:25:43 +01:00
Grégoire Paris
61d0f96c17
Manually fix cs
2021-02-11 21:02:10 +01:00
Grégoire Paris
41729be80a
Spell "first" properly
2021-02-11 18:24:56 +01:00
Grégoire Paris
6dbaa39016
Merge pull request #8469 from greg0ire/cs-20210209
...
CS batch 5/an estimated 30
2021-02-10 21:11:11 +01:00
Grégoire Paris
58c95a92d1
Manually fix cs
2021-02-09 22:58:05 +01:00
Grégoire Paris
4958180b02
Merge pull request #8468 from greg0ire/cs-20210208
...
CS batch 4/an estimated 30
2021-02-09 22:22:41 +01:00
Grégoire Paris
d00dbf7e2d
Merge pull request #8357 from snapshotpl/add-psalm-annotation
...
Add psalm annotation to ArrayCollection of Parameters
2021-02-08 21:25:58 +01:00
Grégoire Paris
8312ff0cb5
Merge pull request #8353 from fezfez/patch-1
...
Add docs to export-ignore
2021-02-08 21:23:35 +01:00
Witold Wasiczko
17012f1fea
Improve psalm types
2021-02-08 21:16:56 +01:00
Witold Wasiczko
324ac3972f
Add psalm annotation for parameters
2021-02-08 21:16:25 +01:00
Grégoire Paris
fb9b9b276e
Manually fix cs
2021-02-08 13:53:04 +01:00
Benjamin Eberlei
323469cdb7
Add /*.phpunit.xml to .gitignore
2021-02-07 19:38:52 +01:00
Grégoire Paris
792a9a9149
Merge pull request #8464 from greg0ire/cs-20210207
...
CS batch 3/many
2021-02-07 14:21:09 +01:00
Grégoire Paris
0f655f9fb6
Manually fix cs
2021-02-07 12:21:40 +01:00
Grégoire Paris
2d7acbd07f
Merge pull request #8457 from greg0ire/cs-20210206
...
CS Batch 2/many
2021-02-06 12:22:10 +01:00
andrews05
835030297a
Add support for INDEX BY an associated entity (2.9.x) ( #7918 )
...
* Add support for INDEX BY an associated entity
This allows specifying an association in the INDEX BY clause of a query
which will index by the association's join column.
Related to #7661 .
* Reintroduce IndexBy#simpleStateFieldPathExpression as deprecated property.
* Housekeeping: phpcs
* Housekeeping: phpcs
Co-authored-by: Benjamin Eberlei <kontakt@beberlei.de >
2021-02-06 11:46:18 +01:00
Grégoire Paris
b06679cc14
Manually fix cs
2021-02-06 11:44:32 +01:00
Julian Ullrich
2693a93aed
fixed entity generation for numeric values ( #8434 )
...
* fixed entity generation for numeric values
* fixed entity generation for numeric values
Co-authored-by: julian <julian@ullrichmail.net >
2021-02-06 00:35:45 +01:00
Benjamin Eberlei
8724589c6e
Housekeeping: Fix wrong typehint - Closes #8421
2021-02-06 00:23:45 +01:00
Grégoire Paris
4cc78d9478
Merge remote-tracking branch 'origin/2.8.x' into 2.9.x
2021-02-05 23:40:59 +01:00
Grégoire Paris
424305ef38
Merge pull request #8455 from greg0ire/cs
...
Cs
2021-02-05 23:40:01 +01:00
Grégoire Paris
9d01f6a45c
Run phpcbf after running git-phpcs
...
git-phpcs can publish comments to Github, that will be helpful.
phpcbf will still be helpful to ensure no one upgrades the coding
standard without also fixing issues that can be autofixed.
2021-02-05 21:39:13 +01:00
Grégoire Paris
7ed487b534
Manually fix CS
2021-02-05 21:38:33 +01:00
Grégoire Paris
68d24288ce
Merge remote-tracking branch 'origin/2.8.x' into 2.9.x
2021-02-05 20:06:04 +01:00
Grégoire Paris
40f3925589
Merge pull request #8144 from greg0ire/cs
...
Automated fixes with phpcbf + manual fixes
2021-02-05 08:44:58 +01:00
Alexander Schranz
f92c3dba32
Fix --complete flag in orm:ensure-production-settings command ( #8426 )
2021-02-01 22:08:04 +01:00
Grégoire Paris
5abad7c0af
Merge remote-tracking branch 'origin/2.8.x' into 2.9.x
2021-01-31 00:01:45 +01:00
Grégoire Paris
bcbd4401b8
Ignore export directory
2021-01-30 23:50:15 +01:00
Grégoire Paris
d6aca8e146
Fix proxy file exclude pattern
...
__CG__ is a file prefix, not a directory
2021-01-30 23:45:46 +01:00
Grégoire Paris
8f1911a4fe
Fix cs by hand
2021-01-30 23:29:40 +01:00
Grégoire Paris
7f30cd3102
Require doctrine/common ^3.0.3
...
That release comes with a fix for a bug that affects us since we are
using return type declarations for wakeUp() in proxyfied classes in on
of our tests.
2021-01-30 18:55:32 +01:00
Grégoire Paris
f01fe3e050
Fix or remove wrong assertions
2021-01-30 18:55:32 +01:00
Grégoire Paris
210c2ee6a4
Remove strict types
2021-01-30 18:55:32 +01:00
Grégoire Paris
497dfd1a84
Avoid covariant return types
...
It's not supported by PHP 7.2/7.3
2021-01-30 18:55:31 +01:00
Grégoire Paris
d9f0e2a27f
Add exclude rules for tricky cases
2021-01-30 18:55:31 +01:00
Grégoire Paris
9a40ac6e2a
Restore weird phpdoc
...
Tests do not pass when I format that phpdoc nicely.
2021-01-30 18:55:31 +01:00
Grégoire Paris
1687d9c479
Restore version annotation, but capitalized
...
@version is commonly used for svn ids and is forbidden
2021-01-30 18:55:31 +01:00
Gabriel Ostrolucký
1a46ed8901
Relax contract of EntityListenerResolver so it doesn't require class name ( #8448 )
...
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr >
2021-01-30 13:37:26 +01:00
Grégoire Paris
36d0352c01
Add missing use statements
2021-01-30 11:21:44 +01:00
Grégoire Paris
15eacd787b
Remove weird extra argument
2021-01-30 11:21:44 +01:00
Grégoire Paris
5b3f9bdd7b
Fix type declarations
2021-01-30 11:21:44 +01:00
Grégoire Paris
e00dba94f4
Remove strict types
2021-01-30 11:21:44 +01:00
Grégoire Paris
ab0e4007a5
Use interface instead of concretion
2021-01-30 11:17:40 +01:00
Grégoire Paris
32266c54f9
Fix compatibility with parent signature
2021-01-30 11:17:39 +01:00
Grégoire Paris
dd2120cd41
Make default value compatible with phpdoc
2021-01-30 11:17:39 +01:00
Grégoire Paris
8991df0785
Add missing return types
2021-01-30 11:17:39 +01:00
Grégoire Paris
ca31923a39
Run phpcbf in the CI
...
There are still many CS issues to fix, but with this, we now know people
can run vendor/bin/phpcbf to fix their issues and only their issues.
2021-01-30 11:17:39 +01:00
Grégoire Paris
68bc00b6c6
Automatically fix CS
2021-01-30 10:58:42 +01:00
Grégoire Paris
5b55b8c6cf
Disable rules that would result in BC-breaks
2021-01-29 23:21:12 +01:00
Grégoire Paris
10f381bc95
Restrict fixes to be compatible with PHP 7.2
2021-01-29 21:16:18 +01:00
Nikolay Gagarinov
40aa8fe5db
update getting-started fix type, improve doc ( #8440 )
...
* update getting-started fix type, improve doc
* Update getting-started.rst
2021-01-26 21:40:41 +01:00
Simon Podlipsky
5801474ba3
Catch doctrine/persistence MappingException ( #8264 )
...
When driver chain is used doctrine/persistence MappingException is thrown instead of doctrine/orm MappingException
2021-01-11 09:07:06 +01:00
Claudio Zizza
9dbd960631
Update website config to current repository branches ( #8420 )
2021-01-11 09:06:06 +01:00
Grégoire Paris
544df89055
Use proper workflow name ( #8418 )
...
This must have been a copy/paste/adapt mistake.
2021-01-11 09:05:18 +01:00
orklah
f0ad5f72b2
bump psalm and fix some issues on level 6 ( #8409 )
2021-01-08 20:30:15 +01:00
azjezz
378944dd27
remove T from class metadata ( #8398 )
2020-12-19 20:48:16 +01:00
Benjamin Eberlei
8b749642cd
[GH-8231] Bugfix: Missed dirty check synchronization check. ( #8392 )
...
When an entity with change tracking policy "deferred explicit" gets
removed, then persisted again, it is not schedulded for a dirty check
synchronization. This is not the case for entities that are persisted
and are already in the managed state.
2020-12-14 11:00:07 +01:00
Nic Wortel
277b53a970
Use the ramsey/composer-install action to install dependencies ( #8388 )
...
Follow-up of https://github.com/doctrine/.github/pull/16 .
2020-12-10 20:03:47 +01:00
Benjamin Morel
2febb4509a
Fix Psalm param ( #8386 )
2020-12-09 11:03:01 +01:00
Benjamin Eberlei
cbc252f3b7
Add Doctrine\ORM\Query\Expr::mod() ( #8377 )
...
* Add Doctrine\ORM\Query\Expr::mod()
Co-authored-by: Menno Holtkamp <menno.holtkamp@shopforce.nl >
* [GH-6739] Add entry to documentation
Co-authored-by: Menno Holtkamp <menno.holtkamp@shopforce.nl >
2020-12-06 23:09:20 +01:00
Benjamin Eberlei
21d2c88013
[GH-7486] Bugfix: failing the command when clearing empty cache is wrong semantics. ( #8376 )
2020-12-06 22:00:00 +01:00
Vašek Henzl
e7d33eb1a9
Infer datetime_immutable DBAL type for \DateTimeImmutable instance parameters ( #8328 )
...
The support for passing \DateTimeImmutable instance as a query parameter has
been added to ORM in #1333 (the year 2015), a long time before immutable date
types (datetime_immutable etc) were introduced to DBAL in doctrine/dbal#2450
(2017).
Back then, it made sense to treat \DateTimeImmutable (or any
\DateTimeInterface) in the same way as \DateTime and infer parameter type as
datetime. However, when immutable date types were later added to DBAL, it
wasn't reflected anyhow in type inference in ORM and \DateTimeImmmutable
instances are still inferred as datetime DBAL type.
This PR fixes this IMO incorrect behaviour of
ParameterTypeInferer::inferType(): for a \DateTimeImmmutable parameter, it now
returns datetime_immutable DBAL type; for \DateTime or any other types
implementing \DateTimeInterface, it returns datetime DBAL type as it did
before.
This behaviour is in line with DateTimeImmutableType handling only
\DateTimeImmutable and DateTimeType handling any \DateTimeInterface.
Why? In most cases, it doesn't matter and datetime works for \DateTimeImmutable
parameters just fine. But it does matter if using custom implementation of
datetime_immutable type like UTCDateTimeImmutableType from
simpod/doctrine-utcdatetime. Then the broken type inference is revealed.
This is partially related to #6443 , however, this PR isn't about custom DBAL
types but about correct type inference for build-in types.
2020-12-05 23:36:33 +01:00
Michel Hunziker
cab7a4558d
Fix invalid psalm annotation ( #8374 )
2020-12-05 14:47:49 +01:00
Benjamin Eberlei
242cf1a33d
Fix ambiguous case where an entity is also a Traversable ( #8371 )
...
* Fix ambiguous case where an entity is also a Traversable
* Address phpcs violations.
* Address phpcs violations.
* Address phpcs violations.
Co-authored-by: Laurent VOULLEMIER <laurent.voullemier@gmail.com >
2020-12-04 20:53:07 +01:00
Grégoire Paris
da225a0db8
Drop step that switches the release branch ( #8372 )
...
ORM is a repository where we use the stable branch as the default
branch, that step is not appropriate here.
2020-12-04 20:46:09 +01:00
Benjamin Eberlei
3ef5a30102
[GH-8366] Catch additional Persistence MappingException ( #8370 )
2020-12-04 20:16:50 +01:00
Grégoire Paris
418587bc25
Merge remote-tracking branch 'origin/2.7' into 2.8.x
2020-12-03 20:18:13 +01:00
Grégoire Paris
01187c9260
Remove trailing whitespaces ( #8360 )
...
Stylistically, it's not great to have them, but more importantly, the
latest symfony/yaml version has issues with trailing whitespaces.
2020-12-03 09:52:14 +01:00
Stéphane
35cf4810c1
Add docs to export-ignore
2020-11-27 18:50:57 +01:00
Benjamin Eberlei
404edd418b
[GH-8229] Prevent Illegal Inheritance Override ( #8348 )
...
* [GH-8229] Prevent AttributeOverride on fields from entities, only allowed for MappedSuperclass
* [GH-8229] Prevent AssociationOverride on fields from entities, only allowed for MappedSuperclass
* Revert "Fix SQL alias generation regression for simple inheritance (#8329 )"
This reverts commit f4ebded63c .
* [GH-8229] Finalize checks for illegal attribute/assocation overrides.
* [GH-8229] Revert ccae8f7176 PR #8234
* [GH-8229] Update documentation to clarify only mapped superclass or trait works with overrides
* [GH-8229] Fix style violations introduced by revert
* [GH-8229] Fix style violations introduced by revert
* [GH-8229] Temporarily disable the exception until 2.8.
* Make phpcs happy
2020-11-25 23:04:56 +01:00
Claudio Zizza
011d3c21eb
Update functionality of code examples ( #8336 )
2020-11-24 22:39:42 +01:00
Benjamin Eberlei
3d46e07887
PHP8 Support ( #8303 )
...
* Update doctrine/dbal to 2.12 for PHP 8 support.
* Change Query\Parser::match to Query\Parser::matchToken including DQL functions.
* Fix phpunit constraint to 9.4, adjust @group usage to workaround PHPUnit bug.
* Fix PHPUnit API related changes.
* Add PHP 8 support for EntityGenerator namespace detection.
* Use new assertEqualsWithDetla for QueryDqlFunctionTest with date comparisons
* Replace ReflectionParameter::getClass usage with non-deprecated ::getType instead.
* Revert "Change Query\Parser::match to Query\Parser::matchToken including DQL functions."
This reverts commit 279070491d50deaa4d41e17b28bb5a68f5a22796.
* More matchToken => match reverts
* Housekeeping: phpcs
* Housekeeping: phpcs
* Housekeeping: phpcs
* Housekeeping: phpcs
* Add PHP 8 testrunner, update composer.json and small fix in OrmFunctionalTestCase for new PHPUnit behvaior
* Update doctrine/coding-standard to 8.x
* Update rule names for doctrine/coding-standard v8.0
* Update to Psalm 4.
* Not failOnWarning anymore.
* Fix phpcs
* fix phpcs
* remove 7.2 for now until we can support in DBAL.
* Relax doctrine/dbal requirement and add 7.2 CI support again.
2020-11-15 13:24:31 +01:00
Roma
b1ac293a50
Add missing backtick in rst markup ( #8335 )
2020-11-10 20:37:36 +01:00
Romain Grégoire
f4ebded63c
Fix SQL alias generation regression for simple inheritance ( #8329 )
...
This fixes a regression from 099c5b42e1 .
Without the fix, "where part" in SQL is generated with incorrect aliases.
See https://github.com/doctrine/orm/issues/8229#issuecomment-722942180 .
2020-11-10 10:53:01 +01:00
Benjamin Eberlei
51bc596502
Update to Psalm 4. ( #8332 )
2020-11-08 10:38:21 +01:00
Grégoire Paris
95f1b48422
Merge remote-tracking branch 'origin/2.7' into 2.8.x
2020-11-07 20:19:45 +01:00
Grégoire Paris
385b5a2f80
Phpunit 8 ( #8330 )
...
* Revert to whitelist
coverage requires PHPunit 9, and we don't have that yet.
* Upgrade to PHPUnit 8
This unlocks PCOV usage for coverage
* Upload coverage files to Codecov
2020-11-07 19:41:15 +01:00
Benjamin Eberlei
f7d8b155db
Merge branch '2.7' into 2.8.x
2020-11-07 18:37:53 +01:00
Benjamin Eberlei
fa6fe09647
Ignore composer.lock
2020-11-07 18:37:46 +01:00
Benjamin Eberlei
539ffea390
Merge 2.7 into 2.8.x
2020-11-07 18:30:32 +01:00
Benjamin Eberlei
c270eba678
Start moving travis phpunit runs to Github actions. ( #8317 )
...
* Move PHPUnit runs from Travis to Github Actions
This removes all artifacts used for TravisCI testing and replaces them
with the existing infrastructure for Github Actions from DBAL component.
In addition some test changes were needed and triggered larger Coding
Style cleanups in 3 test files.
* Remove composer.lock and improve naming in CI workflow.
2020-11-07 18:11:42 +01:00
Michael Käfer
2f0eb95c90
Patch 1 ( #8325 )
...
* Update outdated doc parts
- The cache implementation moved from `Common` to `doctrine/cache`
- APCu is mor appropiate nowadays I guess
- AbstractQuery::useResultCache() is deprecated since 2.7
* Fix wrong argument
* Fix wrong arguments and remove useless line
2020-10-31 12:13:48 +01:00
Grégoire Paris
b13b2e8bab
Upgrade doctrine/coding-standard ( #8321 )
...
* Use a classname that exists
Doctrine\ORM\Mapping\TableGenerator does not exist, only
Doctrine\ORM\Id\TableGenerator does.
* Upgrade doctrine/coding-standard
That library has a dependency on another library that requires composer
plugin API v1. Updating both libs allow to use Composer v2.
* Account for doctrine/reflection deprecation
2020-10-28 11:14:10 +01:00
Simon Podlipsky
4bfc84f035
Rename getIterable() to toIterable() (part 2) ( #8293 )
2020-10-17 23:55:39 +02:00
Michael Voříšek
ca27cc3f72
Fix EOL of text files ( #8310 )
2020-10-17 19:04:42 +02:00
Mateusz Sip
53dc5b2ac3
Detect associations inside embeddables ( #8291 )
2020-10-17 18:49:16 +02:00
orklah
f1219f1418
Add psalm template support to several types ( #8289 )
2020-10-17 12:01:52 +02:00
Grégoire Paris
072066f746
Merge remote-tracking branch 'origin/2.7' into 2.8.x
2020-10-17 11:07:05 +02:00
Laurent VOULLEMIER
5fde5801c1
Fix many typos ( #8299 )
...
- Some uppercase letters were used in the middle of sentence
- Some dots were missing
- There was two sentences with wrong or missing words
2020-10-13 21:52:04 +02:00
Thomas Landauer
18d96fcc02
Update working-with-indexed-associations.rst ( #8298 )
...
* Update working-with-indexed-associations.rst
Fixing broken link
* Update docs/en/tutorials/working-with-indexed-associations.rst
Co-authored-by: Claudio Zizza <859964+SenseException@users.noreply.github.com >
Co-authored-by: Claudio Zizza <859964+SenseException@users.noreply.github.com >
2020-10-12 21:27:18 +02:00
Benjamin Eberlei
4d2908a065
Change <phpunit verbose="true" /> to false for better readability of test output.
2020-10-11 19:14:47 +02:00
Benjamin Eberlei
8d250f5921
Use SHELL_VERBOSITY=3 instead of LOG_LEVEL=DEBUG
2020-10-11 12:03:57 +02:00
Benjamin Eberlei
59fd9b5ea7
Change LOG_LEVEL to debug should expose more info from laminas/automatic-releases.
2020-10-11 00:17:52 +02:00
Benjamin Eberlei
8fcc70cfbe
Change LOG_LEVEL to debug should expose more info from laminas/automatic-releases.
2020-10-11 00:14:35 +02:00
Grégoire Paris
7d84a49980
Setup automated release workflow ( #8301 )
2020-10-10 19:11:26 +02:00
Claudio Zizza
bb64fc953d
Move website config to default branch ( #8287 )
...
Adds the website config to be compatible with the doctrine/doctrine-website#356 changes
2020-10-02 20:31:00 +02:00
orklah
e0eb82a3b1
psalm fixes ( #8286 )
2020-09-30 22:00:38 +02:00
orklah
79cdcde9ec
rename parameters to match parents ( #8284 )
2020-09-26 20:24:11 +02:00
orklah
f4524a8bb0
Fix psalm errors and upgrade strictness ( #8209 )
...
* Fixes and improvements
* fix param type
2020-09-25 20:44:07 +02:00
Simon Podlipsky
f1365b78d5
Rename getIterable to toIterable ( #8268 )
2020-09-25 20:42:09 +02:00
Grégoire Paris
d810ea4111
Use inline literals over escaping ( #8279 )
...
Escaping underscores does not work as expected.
See https://www.doctrine-project.org/projects/doctrine-orm/en/latest/cookbook/dql-custom-walkers.html#modify-the-output-walker-to-generate-vendor-specific-sql
2020-09-22 20:10:05 +02:00
Michael Voříšek
107ba93d79
Convert CRLF to LF in test file ( #8276 )
...
* Convert CRLF to LF in test file
* fix cs
2020-09-21 22:51:49 +02:00
Guillaume Simon
706670215d
Fix OrderByItem parser to proceed with SimpleArithmetic expression before function ( #8277 )
...
There is parser bug for OrderByItem(), where a function is detected
before a SimpleArithmeticExpression while it should be the reverse:
simple arithmetic expressions can start with a function too, and thus
they should be matched first if present.
This fix enables the use of expressions in sorting and with window
functions.
2020-09-20 18:56:57 +02:00
Yohann Durand
ab2b4987b3
Improve formatting ( #8028 )
2020-09-08 20:56:51 +02:00
Thomas Landauer
717ef9106c
Update events.rst ( #8257 )
...
* Update events.rst
Improved code formatting
* Update docs/en/reference/events.rst
I was wondering myself what the `#` was about ;-)
Co-authored-by: Claudio Zizza <859964+SenseException@users.noreply.github.com >
* Update events.rst
See https://github.com/doctrine/orm/pull/8257#discussion_r482305774
Co-authored-by: Claudio Zizza <859964+SenseException@users.noreply.github.com >
2020-09-03 22:44:28 +02:00
Christoph Ziegenberg
ccae8f7176
Fix for bug #8229 (id column from parent class renamed in child class) ( #8234 )
...
This fixes problems with id columns defined in the parent class but renamed in the child class using an attribute override. Before this change always the child column name was used (which was not present in the parent class), now the correct column names are used for the parent table when creating inserts, joins and deletions for it.
Co-authored-by: Crossjoin <crossjoin@users.noreply.github.com >
2020-08-29 13:25:18 +02:00
Grégoire Paris
da18985aca
Stop using the DBAL extension of PHPBench ( #8252 )
...
It has been removed, and the default XML storage driver is supposed to
be fine for our purposes.
2020-08-29 12:28:40 +02:00
Simon Podlipsky
60cd524443
Introduce getIterable() on AbstractQuery ( #7885 )
2020-08-14 11:12:40 +02:00
Simon Podlipsky
045d1f3bf2
Bump Doctrine CS to v6 ( #8241 )
2020-08-13 09:10:43 +02:00
Grégoire Paris
1ae6f18fe9
Merge remote-tracking branch 'origin/2.7' into 2.8.x
2020-08-12 22:26:19 +02:00
Simon Podlipsky
1e2ed07731
Use consistent formatting in command line ( #8238 )
2020-08-12 08:38:00 +02:00
Grégoire Paris
424241f29c
Use more accurate terminology ( #8236 )
...
I think this was a mistake when writing this documentation, and that the
original author meant to use attribute here, columns do not have
columns, they have attributes.
2020-08-09 22:48:52 +02:00
Grégoire Paris
8230afcde9
Fetch deeper
...
This is needed to preserve parent information and be able to find the
merge base with the head branch. The assumption here is that the common
ancestor can be found among the 10 parent commits.
2020-08-07 22:11:21 +02:00
Kirill Matasov
7cffba8743
Fix annotation in Expr
2020-08-07 22:11:21 +02:00
Zacharias Luiten
91b9dd90f4
Add DQL support for ORDER BY CASE ( #8188 )
2020-08-05 22:49:51 +02:00
Benjamin Cremer
7e5fe79349
Change preferred cache driver for metadata and query caches ( #8223 )
...
See: https://twitter.com/lcobucci/status/1289087725694484481
2020-08-03 21:40:52 +02:00
njutn95
efd25484f4
Update aggregate-fields.rst ( #8215 )
...
Minor typo fix
2020-07-20 21:19:16 +02:00
Andreas Möller
271f3480c8
Fix: Typo ( #8213 )
2020-07-15 22:46:25 +02:00
orklah
aab589b596
add/fix more types (checked by psalm) ( #8199 )
...
* add/fix more psalm types
* remove inexistant SimpleEntityExpression
* Declare template implements for TreeWalkerChainIterator
2020-07-10 22:08:13 +02:00
orklah
190218b267
Change list() syntax to array destructuring (short list syntax) ( #8204 )
2020-07-07 22:02:34 +02:00
Benjamin Eberlei
181114f2c7
[GH-8106] Move test into existing QueryTest testcase to reduce surface.
2020-07-05 21:51:35 +02:00
tom93
3689b76a86
Fix QueryBuilder::getParameter() on parameter names with colons ( #8107 )
...
* Fix type errors
(partially cherry picked from commit 17e7c2a42e )
* Fix QueryBuilder::getParameter() on parameter names with colons
Fixes #8106 .
Co-authored-by: Michael Moravec <mail@majkl578.cz >
2020-07-05 21:46:48 +02:00
Igor Pellegrini
75fe18ea5f
Add alert to "avoid persisting detached entities" ( #8109 )
...
The alert is hidden into the code of ``EntityManager``,
while it's useful to be mentioned in the documentation.
2020-07-05 20:24:08 +02:00
Grégoire Paris
6c73a6b720
Infer return type information with Psalter ( #8150 )
...
These changes are a subset of changes done with vendor/bin/psalm --alter
--issues=LessSpecificReturnType
--allow-backwards-incompatible-changes=false
2020-07-05 20:15:39 +02:00
Benjamin Eberlei
775d91c2a3
[GH-8122] Move test from AbstractMappingDriverTest to ClassMetadataFactoryTest case
2020-07-05 20:11:01 +02:00
Gildas Quéméner
64c3f68734
Prohibits class typo in the discriminator map ( #8122 )
...
* Prevents incorrect table aliases to be generated
When a defined subclass has a case typo, the query builder will be lost
and will generate exotic table alias. This commit fixes the issue at the
root by prohibiting case typo in discriminator map.
See https://github.com/doctrine/orm/pull/8112 for the consequence of
such typo.
* Controls growing rate of the abstract test class
* Fixes incorrect test case
The Cube class must be autoloaded with the correct case, otherwise
composer autoloader will complain.
* Removes non architecture compliant code
See https://github.com/doctrine/orm/pull/8122/files#r423952247
* Ensures discriminator map is case sensitive
2020-07-05 19:48:38 +02:00
Mohamed Ettaki Talbi
2a2a0b2980
Remove unwanted period ( #8198 )
2020-07-02 08:36:18 +02:00
Grégoire Paris
505d658e3d
Merge remote-tracking branch 'origin/2.7' into 2.8.x
2020-06-21 13:50:48 +02:00
vladyslavstartsev
a438e90046
add dev files to .gitattribute ( #8190 )
...
those files probably are not used by end user of the lib
2020-06-19 13:48:45 +02:00
Nicolas Grekas
6a670d7d6d
Allow using on PHP 7.1 with Composer 2 ( #8184 )
2020-06-18 23:05:13 +02:00
Grégoire Paris
765521d257
Use CodeCov instead of Scrutinizer ( #8187 )
...
* Document current branch status in the README
* Use CodeCov instead of Scrutinizer
2020-06-17 22:47:25 +02:00
Grégoire Paris
5ced62bf83
Run benchmark on PHP 7.4 ( #8186 )
...
phpbench recently dropped compatibilty with PHP 7.1
When this job was introduced, 7.1 was the latest version of PHP we
supported, so it makes sense to bump to 7.4 now.
See https://github.com/phpbench/phpbench/releases/tag/0.17.0
See e07c90df44
2020-06-17 22:06:42 +02:00
Grégoire Paris
bee8decd18
Require persistence 2 and common 3 ( #8166 )
...
This allows us to drop the autoload-calls-based BC layer.
2020-06-17 14:56:17 +02:00
Alexander Berl
93867f8d77
TASK: Replace "Blacklist" example with "Banlist" ( #8174 )
2020-06-08 23:06:53 +02:00
Laurent VOULLEMIER
6bce7e9cab
Add iterable support for IN criterias ( #8162 )
2020-06-03 18:40:53 +02:00
Grégoire Paris
4d8418fe6f
Merge remote-tracking branch 'origin/2.7' into drop-persistence-bc-layer
2020-06-02 18:40:48 +02:00
Grégoire Paris
d95e03ba66
Allow doctrine/common 3 and doctrine/persistence 2 ( #8158 )
2020-05-26 18:03:49 +02:00
Robert Basic
825ceb6b7a
Fix inline code example ( #8153 )
...
* Fix inline code example
* Remove extra backslash
2020-05-22 22:45:24 +02:00
orklah
de2e2a1d74
Add psalm types ( #7989 )
2020-05-18 21:48:28 +02:00
Benjamin Eberlei
850d57e791
[GH-8137] Update doctrine/inflector dependency to 1.4|2.0 ( #8147 )
...
* [GH-8137] Update doctrine/inflector dependency to 1.4|2.0 and resolve deprecations.
* [GH-8137] Address review comments
* Address phpcs issues.
* More CS
* Codingstyle
2020-05-17 19:58:02 +02:00
Grégoire Paris
c3dd71704b
Merge remote-tracking branch 'origin/2.7' into 2.8.x
2020-05-16 15:14:51 +02:00
Grégoire Paris
6780a963f7
Migrate git-phpcs to Github actions ( #8146 )
2020-05-16 14:01:10 +02:00
Philippe Le Van (@plv)
0b305e5bd3
Add possibility to use sql comments in the DQL syntax ( #8140 )
2020-05-15 08:04:58 +02:00
Benjamin Eberlei
4d172e2591
Revert changes to embeddable mapping in 2.7 ( #8138 )
...
* Revert "Fix inherited embeddables and nesting after AnnotationDriver change #8006 (#8036 )"
This reverts commit a9b6b72017 .
* Revert "Make Embeddable not transient"
This reverts commit 58677c29b4 .
* Housekeeping: CS fixes
2020-05-12 20:10:26 +02:00
Grégoire Paris
21a98234d0
Static analysis with Psalm ( #8116 )
...
* Remove useless ternaries
If these expressions are truish inside the condition, they will still be
truish inside the if.
* Describe properties more accurately
These are not objects, they are strings holding class names for classes
that implement TreeWalker.
* Remove duplicate key
Comparison::IS and Comparison::EQ are the same. I chose to remove IS
because it does not seem to exist anymore on master
* Remove unwanted . before = operator
This worked, but makes no sense.
* Setup static analysis with Psalm
* Move PHPStan to Github actions
2020-05-11 23:06:46 +02:00
Gabriel Birke
061207861b
Improve CLI config documentation ( #8130 )
...
Change code examples for `cli-config.php` to use
`ConsoleRunner::createHelperSet` instead of constructing the helper set
array yourself.
Remove DBAL-specific documentation
Co-authored-by: Claudio Zizza <859964+SenseException@users.noreply.github.com >
2020-05-11 21:43:26 +02:00
Grégoire Paris
8a9954e46c
Address deprecations from persistence ( #7953 )
...
A backwards-compatibility layer has been added to persistence to help
consumers move to the new namespacing. It is based on class aliases,
which means the type declaration changes should not be a BC-break: types
are the same.
See https://github.com/doctrine/persistence/pull/71
This means:
- using the new namespaces
- adding autoload calls for new types to types that may be extended and
use persistence types in type declarations of non-constructor methods,
so that signature compatibility is recognized by old versions of php.
More details on this at
https://dev.to/greg0ire/how-to-deprecate-a-type-in-php-48cf
2020-05-07 08:35:39 +02:00
Grzesiek
527fff53cc
removed repository class from metadata ( #8125 )
...
The annotation is required only in the next chapter of the tutorial, specifically the "Entity Repositories"
2020-05-03 21:58:20 +02:00
Maks Rafalko
70fb1ecd78
Warn users about performance issues with DateTime objects in setParameter() ( #8114 )
2020-04-25 22:16:17 +02:00
Jeroen van den Heuvel
73ec483e9d
Convert PHP to SQL for new object expression ( #8062 )
2020-04-16 23:01:43 +02:00
Mathieu
8d67eec812
Fix JoinColumn documentation ( #7966 )
2020-03-30 21:33:13 +02:00
Vincent Langlet
a418cf6418
Remove TODO ( #8078 )
2020-03-30 20:06:04 +02:00
Arne
6138afdca9
[Docs] Make clear that calling remove() detaches the object ( #8081 )
...
I changed a relationship from eager to lazy loading which broker the behaviour of my application in regards to object removal. It was not clear for me that removing an object detaches it and subsequent calls like contains() in a OneToMany relationship with the object scheduled for removal will return false afterwards.
2020-03-27 19:42:39 +01:00
Vincent Langlet
dafe298ce5
Fix phpdoc ( #8074 )
2020-03-19 07:41:02 +01:00
Matthias Pigulla
58b8130ea1
Fix regression in 2.7.1 when mysqli is used with discriminator column that is not a string ( #8055 )
...
* Add a test case showing the regression
* Cast the discriminator value to string
* Fix CS
2020-03-16 11:19:12 +01:00
Grégoire Paris
3c91792dd8
Address deprecation about PHPUnit annotations ( #8070 )
...
These changes have been done using Rector, this might not result in the
best placement for method calls, but it is not worse than the current
situation.
I used the configuration documented at
b398e8740c/docs/HowItWorks.md (221-order-of-rectors)
Fixes #8069
2020-03-16 08:56:59 +01:00
Benjamin Eberlei
a705f526fb
[GH-7633] disallow cache partial objects ( #8050 )
...
* [GH-7633] Bugfix: Partial queries were stored in 2LC.
There was a check in DefaultQueryCache that prevented partial queries,
because they are not supported. However the checked hint
Query::HINT_FORCE_PARTIAL_LOAD is optional, so cant be used to prevent
caching partial DQL queries.
Introduce a new hint that the SqlWalker sets on detecing a PARTIAL
query and throw an exception in the DefaultQueryCache if thats found.
* Housekeeping: CS
* [GH-7633] HINT_FORCE_PARTIAL_LOAD still needs to be checked.
* Housekeeping: Fix CS
2020-03-15 01:11:34 +01:00
Maciej Malarz
a9b6b72017
Fix inherited embeddables and nesting after AnnotationDriver change #8006 ( #8036 )
...
* Add test case
* Treat parent embeddables as mapped superclasses
* [GH-8031] Bugfix: Get working again on nested embeddables in inherited embeddables.
* Housekeeping: CS
* Update note on limitations
* [GH-8031] Verify assocations still do not work with Embeddables.
* Housekeeping: CS
Co-authored-by: Benjamin Eberlei <kontakt@beberlei.de >
2020-03-15 01:00:58 +01:00
Jorrit Schippers
cd905fff77
Fix documentation of default generated value behavior ( #8068 )
2020-03-13 20:40:31 +01:00
Claudio Zizza
431d0a3c5e
Remove ORM 2.0 version constraints from docs ( #8002 )
2020-03-06 21:47:40 +01:00
Andreas Möller
eb700405be
Fix: Use neutral pronouns ( #8059 )
2020-03-06 16:08:53 +01:00
Rosemary Orchard
9273057649
Annotations override naming strategy ( #8041 )
...
Add a note/warning that annotations override the naming strategy.
2020-03-01 14:01:26 +01:00
Soliman
1da002ca2f
Throw OptimisticLockException when connection::commit() returns… ( #7946 )
...
* Throw OptimisticLockException when connection::commit() returns false
* Update unit tests
* Fix doctrine persistence version to avoid deprecations changes
* Apply changes from 2.8.x
* Update from 2.8.x
2020-02-29 23:06:47 +01:00
Grégoire Paris
e04a79526e
Merge pull request #7230 from holtkamp/patch-2
...
Mention that lifecycle callbacks do not support Embeddables
2020-02-17 23:00:44 +01:00
Menno Holtkamp
d157a6cbeb
Mention that lifecycle callbacks do not support Embeddables
...
As discussed in https://github.com/doctrine/doctrine2/issues/6855
2020-02-17 22:25:00 +01:00
Benjamin Eberlei
ca57222010
Merge pull request #8023 from peterkeatingie/query-cache-fix
...
Put into cache using root entity name
2020-02-16 10:50:24 +01:00
Peter Keating
9bb2bf0cce
Put into cache using root entity name
2020-02-15 15:53:47 +00:00
Benjamin Eberlei
445796af0e
Travis: Use 7.4 instead of 7.4snapshot
2020-02-15 15:35:56 +01:00
Benjamin Eberlei
ab93285284
Remove nightly builds from .travis.yml
2020-02-15 15:34:36 +01:00
Benjamin Eberlei
ef639d4de6
Remove nightly builds from .travis.yml
2020-02-15 15:34:05 +01:00
Benjamin Eberlei
31f4dd671a
Merge remote-tracking branch 'origin/2.7' into 2.8.x
2020-02-13 21:31:29 +01:00
Benjamin Eberlei
a692670469
Merge pull request #8006 from doctrine/malarzm-patch-1
...
Make Embeddable not transient
2020-02-13 21:31:02 +01:00
Maciej Malarz
58677c29b4
Make Embeddable not transient
2020-02-13 21:05:52 +01:00
Benjamin Eberlei
60c4867ed3
Merge branch 2.7 into 2.8.x
2020-02-12 23:42:36 +01:00
Benjamin Eberlei
9a0fcb5a86
Merge pull request #7940 from doctrine/GH-7864-ExtraLazyRemoveElement
...
[GH-7864] Bugfix in PersistentCollection::removeElement for EXTRA_LAZY.
2020-02-12 23:42:06 +01:00
Benjamin Eberlei
0ee1716b26
Merge branch 2.7 into 2.8.x
2020-02-12 23:38:27 +01:00
Benjamin Eberlei
8104c65d6c
Merge pull request #7987 from beberlei/GH-7982-NoSqlExecutor
...
[GH-7982] no sql executor leads to parse error
2020-02-12 23:37:39 +01:00
Benjamin Eberlei
a64d254d07
[GH-7982] Bugfix: Passing string|null DQL to Lexer(string $input) leads to downstream notice.
2020-02-12 23:23:12 +01:00
Claudio Zizza
a236a83fa8
Merge pull request #7993 from SenseException/readme2-8
...
Update version and links in readme
2020-01-20 11:14:33 +01:00
Claudio Zizza
37f1bd7606
Update version and links in readme
2020-01-17 21:42:59 +01:00
Grégoire Paris
af4cb282ba
Merge pull request #7978 from alexeyshockov/patch-2
...
Stable PHP 7.4 in Travis
2020-01-17 07:49:48 +01:00
Benjamin Eberlei
ce4914ba0e
Merge 2.7 to 2.8.x
2020-01-17 00:08:23 +01:00
Benjamin Eberlei
fdad48278b
Merge pull request #7991 from greg0ire/7.4-sa
...
Try running phpstan on php 7.4
2020-01-17 00:06:40 +01:00
Benjamin Eberlei
fc94127d7f
Make ocramius/package-versions 1.2 the lowest version for phpstan
2020-01-16 23:51:17 +01:00
Grégoire Paris
dea3e5df44
Try running phpstan on php 7.4
...
It might be easier to find packages compatible with both our locked deps
and phpstan with that version of php.
2020-01-16 23:49:15 +01:00
Alexey Shokov
bdfd6c1677
Stable PHP 7.4 in Travis
2020-01-16 23:27:20 +01:00
Benjamin Eberlei
5d7d3e99a0
Downgrade ocramius/package-versions to lowest in composer.lock to support all PHP versions.
2020-01-16 23:18:00 +01:00
Benjamin Eberlei
3bc1096fd0
[GH-7982] Default Query state to dirty to fix execution of empty query.
2020-01-15 23:30:59 +01:00
Benjamin Eberlei
8e0157d97d
Merge branch '2.7' into 2.8.x
2020-01-15 22:57:06 +01:00
Benjamin Eberlei
a2f01f7ccc
Allow everything from ocramius/package-versions ^1.0.
2020-01-15 22:56:08 +01:00
Benjamin Eberlei
1767f4b8e7
Merge branch '2.7' into 2.8.x
2020-01-15 22:02:55 +01:00
Benjamin Eberlei
401db453a2
Merge pull request #7974 from beberlei/gh-7505
...
[GH-7505] Bug in SimpleObjectHydrator when using inheritance with same field
2020-01-15 22:02:25 +01:00
Benjamin Eberlei
6e59ec8f16
[GH-7505] Fix cs
2020-01-15 21:52:11 +01:00
Benjamin Eberlei
87e491465a
Add @group
2020-01-15 21:13:25 +01:00
Luís Cobucci
8b588eceb2
Merge pull request #7973 from DocFX/patch-1
...
Just a micro grammar update.
2020-01-14 11:26:21 +01:00
Benjamin Eberlei
edce36598f
Adjust tests back for 2.x.
2020-01-09 00:41:47 +01:00
Benjamin Eberlei
ca95b0ee13
Merge branch '2.7' into 2.8.x
2020-01-08 19:39:17 +01:00
Woody Gilk
20c46035d1
[Docs] Prefer PhpFileCache for caching and remove APC/XCache.
2020-01-08 19:36:08 +01:00
William Pinaud
324aacfb54
Just a micro grammar update.
2020-01-08 18:52:11 +01:00
Benjamin Eberlei
1edfcabead
Merge pull request #7894 from TomckySan/convert-default-value-to-boolean
...
Fix boolean properties default value when generating entities.
2020-01-05 16:11:33 +01:00
Luís Cobucci
2785cde792
Merge pull request #7957 from lcobucci/fix-version-information
...
Fix version information
2019-12-17 19:19:05 +01:00
Luís Cobucci
d67e3e8b1b
Rely on ocramius/package-versions to render the version
...
Since `Doctrine\ORM\Version` is now deprecated it shall not be updated
on future releases.
This ensures that our CLI tool will present the correct version number.
2019-12-17 15:47:55 +01:00
Luís Cobucci
d629c4e487
Remove build.xml and related files
...
We aren't using ant/phing to handle the releases any more.
2019-12-17 01:03:34 +01:00
Luís Cobucci
4a4226213f
Merge pull request #7875 from nicolas-grekas/schema-tool
...
Whilelist existing assets we know about from metadata in SchemaTool::getUpdateSchemaSql()
2019-12-16 23:59:31 +01:00
Andreas Braun
0ce1440884
Add upgrade note about schema_filter change
2019-12-16 23:45:49 +01:00
Laurent VOULLEMIER
9aa28b4e33
Test asset whitelisting on SchemaTool#getUpdateSchemasSql()
2019-12-16 23:45:49 +01:00
Nicolas Grekas
5c2b6870bf
Whitelist existing assets we know about from metadata in SchemaTool::getUpdateSchemaSql()
2019-12-16 23:22:50 +01:00
Luís Cobucci
4389b2c188
Merge pull request #7956 from lcobucci/fix-test-suite
...
Ignore Doctrine\Common\Persistence\ObjectManagerDecorator deprecation
2019-12-16 21:49:25 +01:00
Luís Cobucci
e481d9880b
Ignore Doctrine\Common\Persistence\ObjectManagerDecorator deprecation
...
Since applying the fixes requires bumping up the dependency, which isn't
done in a patch release.
This should be removed in v2.8.0.
2019-12-16 21:22:28 +01:00
Luís Cobucci
85528f28e2
Fix CS errors
2019-12-16 21:22:23 +01:00
Luís Cobucci
5873242fb5
Merge pull request #7937 from doctrine/GH-7930-SqliteForeignKeys
...
Revert SchemaTool change to check for foreign key support
2019-12-16 10:45:07 +01:00
Luís Cobucci
4aa09861dd
Merge pull request #7941 from Grafikart/feat-typed-functions
...
Allow DQL functions to specify return type
2019-12-12 19:50:23 +01:00
Grafikart
24e9a7caaf
Allow defining return types for DQL functions
2019-12-12 14:19:09 +01:00
Luís Cobucci
d90df59118
Merge pull request #7948 from beberlei/TravisSmokeTesting
...
Add stage that runs before Test to allow fast failures on Sqlite/phpcs
2019-12-12 11:54:41 +01:00
Benjamin Eberlei
f9103a7b41
Add another stage that runs before Test to allow fast failures on Sqlite, Quality + PHPCS-differ
2019-12-12 11:43:24 +01:00
Luís Cobucci
9891477094
Merge pull request #7928 from kokspflanze/2.7-patch-deprecated
...
Deprecate EntityRepository#clear()
2019-12-09 21:56:41 +01:00
kokspflanze
59e3a55110
Deprecate EntityRepository#clear()
2019-12-09 21:42:11 +01:00
Luís Cobucci
c9e41d0aa7
Merge pull request #7934 from BenMorel/php74
...
Fix Trying to access array offset on value of type null
2019-12-09 21:32:58 +01:00
Benjamin Morel
f37c12834d
Fix Trying to access array offset on value of type null
2019-12-09 21:24:29 +01:00
Benjamin Eberlei
041404e8b3
[GH-7864] Revert removeElement EXTRA_LAZY support.
2019-12-07 00:03:09 +01:00
Benjamin Eberlei
bfc68b3aba
Add warning about removeElement on extra lazy
2019-12-03 20:34:44 +01:00
Benjamin Eberlei
1e628370c4
[GH-7864] Address review comments.
2019-12-03 19:35:49 +01:00
Benjamin Eberlei
ae2b9b1921
Housekeeping: phpcbf to fix issues.
2019-12-01 21:11:09 +01:00
Benjamin Eberlei
419df77a09
[GH-7864] ExtraLazyCollectionTest is not cacahble and should not fail SLC suite.
2019-12-01 20:28:30 +01:00
Benjamin Eberlei
d6f6b2e97c
[GH-7864] Remove tests that checked invalid behavior.
2019-12-01 19:47:58 +01:00
Benjamin Eberlei
75d5adf599
[GH-7864] Bugfix in PersistentCollection::removeElement for EXTRA_LAZY.
2019-12-01 19:27:45 +01:00
Benjamin Eberlei
cfd6fadf9c
Revert " #7841 SchemaTool generates extra diff for platforms without FK support"
...
This reverts commit 3707c39124 .
2019-12-01 11:23:45 +01:00
Tomoka Baba
2bf7916c52
Fix to pass code quality check.
2019-11-20 17:03:34 +09:00
Tomoka Baba
253fd10cc0
Modified test to use assertTrue.
2019-11-20 17:02:25 +09:00
Tomoka Baba
2c956d55f2
Fix to pass code quality check.
2019-11-20 17:02:25 +09:00
Tomoka Baba
3db992e953
Add test code.
2019-11-20 17:01:52 +09:00
Tomoka Baba
6fc9b3ab16
Fix to pass code quality check.
2019-11-20 17:01:52 +09:00
Tomoka Baba
2d833a5e86
Fix boolean properties default value when generating entities.
2019-11-20 17:01:19 +09:00
Luís Cobucci
a416a9a8b2
Bump up version
2019-11-19 09:43:57 +01:00
Luís Cobucci
4d763ca4c9
Bump up version
2019-11-19 09:38:05 +01:00
Luís Cobucci
398d74deaa
Merge pull request #7911 from lcobucci/be-more-explicit-on-deprecation-messages
...
Be explicit about which Doctrine package in message
2019-11-19 09:36:14 +01:00
Luís Cobucci
3314322929
Be explicit about which Doctrine package in message
...
Avoiding possible confusion while reading the deprecation messages.
2019-11-19 09:03:36 +01:00
Luís Cobucci
ce93817bf7
Merge pull request #7909 from lcobucci/add-deprecation-messages
...
Add deprecation messages
2019-11-19 08:21:44 +01:00
Luís Cobucci
50992eafa2
Deprecated the usage of number unaware underscore naming strategy
2019-11-19 02:15:11 +01:00
Luís Cobucci
9ccb8837e7
Add deprecation message for EM#clear($entityName)
2019-11-19 01:34:50 +01:00
Luís Cobucci
d959744c0a
Merge pull request #7079 from mairo744/hotfix/sqlite-join-table-name
...
fix getJoinTableName for sqlite with schema attribute
2019-11-18 23:37:33 +01:00
mairo744
0264ba1759
Fix creation of join table names with schemas in SQLite
...
Join table name doesnt depending on the platform.
Table name was "schema.table" instead of "schema__table".
(cherry picked from commit 4878cd3f4ef30ffc6047c18e0f7b16aafeabc3b4)
2019-11-18 23:25:28 +01:00
Luís Cobucci
8332fa1855
Merge remote-tracking branch 'upstream/2.6' into 2.7
2019-11-18 23:06:28 +01:00
Luís Cobucci
4fae126459
Bump up version
2019-11-18 23:05:16 +01:00
Luís Cobucci
2d9b935183
Bump up version
2019-11-18 23:01:21 +01:00
Luís Cobucci
4804f602f8
Merge pull request #7908 from lcobucci/fix-bc-break-on-naming-strategy
...
Fix BC-break on underscore naming strategy
2019-11-18 22:57:27 +01:00
Luís Cobucci
3d17290eb5
Fix BC-break on underscore naming strategy
...
We broke our BC promises on the last patch release by changing how the
underscore naming strategy parses values with numbers.
This commit makes it possible to configure whether or not to make the
underscore naming strategy aware of numbers, keeping the old
configuration as default value.
2019-11-18 22:38:14 +01:00
Luís Cobucci
8420d24f90
Merge remote-tracking branch 'upstream/2.6' into 2.7
2019-11-18 19:59:58 +01:00
Luís Cobucci
52f2b37921
Bump up version
2019-11-18 12:17:41 +01:00
Luís Cobucci
16751d210f
Bump up version
2019-11-18 12:06:51 +01:00
Luís Cobucci
686f508576
Merge pull request #7905 from lcobucci/7890-paginator-objecti
...
[Paginator] Fix type conversion during hydration of pagination limit subquery
2019-11-18 10:50:54 +01:00
Luís Cobucci
00ef1eba90
Add paginator query hint to force type conversion
...
We're keeping a BC layer in the hydrator, which prevents type conversion
in scalar results.
This makes bypasses such layer in order to always convert the identifier
types when limiting the result set during a pagination.
The main goal here is to keep the conversion DB->PHP inside of the
hydrator components.
2019-11-18 10:27:10 +01:00
Gabriel Ostrolucký
3843eee5cb
[Paginator] Add test case for regression with custom id
...
Co-authored-by: Alexei Korolev <alexei.korolev@gmail.com >
2019-11-18 10:27:10 +01:00
Luís Cobucci
f576e6c41f
Merge pull request #7904 from greg0ire/validate-composer-json
...
Make sure composer files are valid
2019-11-16 11:47:02 +01:00
Grégoire Paris
c79d2e0dc2
Make sure composer files are valid
...
The composer.lock is put under version control and it often happens to
be out of sync with the composer.json, which could lead to
hard-to-understand issues.
Using the --strict option here because we might as well aim for a
perfectly valid composer.json
2019-11-16 10:59:39 +01:00
Grégoire Paris
33b8d020a7
Synchronize lock file and json manifest
2019-11-16 10:59:39 +01:00
Luís Cobucci
1b2daac25d
Merge pull request #7710 from rtek/pretty-tool-describe
...
Prettified arrays in tool command orm:mapping:describe
2019-11-16 02:15:31 +01:00
Luís Cobucci
977985f756
Merge pull request #7701 from someniatko/deprecate-use-result-cache
...
Split and deprecate AbstractQuery#useResultCache()
2019-11-16 02:12:29 +01:00
rtek
0c36f87935
Prettify arrays in orm:mapping:describe command
...
This will prevent excessive column width and wrapping in the output which uses Symfony\Component\Console\Style\SymfonyStyle::table().
2019-11-16 02:03:03 +01:00
someniatko
e8f265d480
Make ResultCacheTest tests slightly more logical
2019-11-16 01:59:57 +01:00
Illia Somov
7bcbad076d
Split and deprecate AbstractQuery#useResultCache()
2019-11-16 01:59:57 +01:00
Luís Cobucci
57496e32fd
Add minor BC-break notes on output walkers in paginator
...
As explained in
https://github.com/doctrine/orm/pull/7863#issuecomment-554578313 .
2019-11-16 01:48:37 +01:00
Luís Cobucci
797bfc53c4
Fix deprecation messages version
2019-11-16 01:32:15 +01:00
Luís Cobucci
8c47dcb6fc
Merge pull request #7863 from Seb33300/skip-limit-subquery
...
Paginator: Skip limit subquery if not required
2019-11-16 01:21:43 +01:00
Sébastien ALFAIATE
6347190886
Skip limit subquery if not required
2019-11-16 01:03:22 +01:00
Luís Cobucci
9162f3519d
Merge pull request #7900 from doctrine/2.6.x-merge-up-into-2.7
...
Merge up 2.6 to 2.7
2019-11-16 00:27:50 +01:00
Grégoire Paris
fc9314d9f5
Merge remote-tracking branch 'origin/2.7' into 7900--2.6.x-merge-up-into-2.7
2019-11-15 23:50:05 +01:00
Luís Cobucci
26806d08eb
Require more updated doctrine packages
2019-11-15 23:46:22 +01:00
Luís Cobucci
6a827d5b61
Merge pull request #7861 from ferrastas/bug_removing_collection
...
Delete statements will not be created using `clear`
2019-11-15 22:58:31 +01:00
Gabriel Ostrolucký
7d77984306
Restore ability to clear deferred explicit tracked collections
...
This was regression from #7862 which tried to respect tracking config
when clearing collections, but this logic can happen in UOW only,
PersistentCollection::clear is triggered too early to know what
is (going to be) persisted.
Fixes #7862
2019-11-15 22:49:06 +01:00
Ferran Vidal
ec93014713
Delete statements will not be created using clear.
2019-11-15 22:43:53 +01:00
Luís Cobucci
c83094bde0
Merge pull request #7684 from rharink/2.6
...
only replace '_id' at end of columnName
2019-11-15 16:50:16 +01:00
Robert den Harink
982d1519db
only replace '_id' at end of columnName
2019-11-15 16:36:48 +01:00
Marco Pivetta
f7c04ae537
Merge pull request #7901 from lcobucci/add-deprecation-notices
...
Add deprecation warnings for 2.7.x
2019-11-15 16:15:31 +01:00
Michael Moravec
f9a4258ded
Upgrading notes for 2.7
2019-11-15 14:43:33 +01:00
Michael Moravec
eb9f11bf96
Added deprecation warnings for 2.x
2019-11-15 14:43:15 +01:00
Luís Cobucci
2b8cb9de79
Add basic tool to verify deprecation messages
2019-11-15 14:42:48 +01:00
Luís Cobucci
570abb5bad
Fix PHP warnings in test suite
2019-11-15 14:42:47 +01:00
Luís Cobucci
855244fd10
Merge pull request #7865 from Ocramius/fix/#7837-paginate-with-custom-identifier-types-even-with-cached-dql-parsing
...
#7837 paginate with custom identifier types even with enabled DQL query cache
2019-11-15 11:08:22 +01:00
Guilherme Blanco
c62977412c
Merge pull request #7869 from BenMorel/patch-4
...
UnitOfWork::clear() misses $eagerLoadingEntities
2019-11-15 00:27:08 -05:00
Gabriel Ostrolucký
98e557b68e
Improve assertion failure message for testWillFindSongsInPaginatorEvenWithCachedQueryParsing
2019-11-14 23:37:13 +01:00
Mickaël RAYBAUD-ROIG
3a32c00dcf
Add a failing test for issue #7505
2019-11-14 23:28:42 +01:00
Gabriel Ostrolucký
1dde2c9e8e
Add test case verifying eager loads are clear
...
Otherwise, getClassMetadata would be triggered more times
2019-11-14 22:17:06 +01:00
Marco Pivetta
adfd010a78
Merge pull request #7889 from ajgarlag/hotfix/fix-tests-with-dbal-2.10
...
Use quoted collation declaration when available.
2019-11-05 15:52:18 +01:00
Antonio J. García Lagar
1bc4e1f594
Use quoted collation declaration when available.
2019-11-05 14:58:24 +01:00
Marco Pivetta
21680df9bd
Merge pull request #7884 from rogeriolino/patch-1
...
[Documentation] Advanced field value... - missing entity alias
2019-11-05 01:23:52 +01:00
Rogério Alencar Lino Filho
19aa3c125c
missing entity alias
2019-10-31 18:20:58 -03:00
Marco Pivetta
e9e012a037
Merge pull request #7880 from kuraobi/update-doc-dql-qb
...
Update documentation to recommend DQL over QueryBuilder when possible
2019-10-29 19:04:03 +01:00
Mathieu Lemoine
d1db0655ac
Update documentation to recommend DQL over QueryBuilder when possible
2019-10-29 16:26:17 +01:00
Luís Cobucci
2d643e6b7b
Merge pull request #7876 from nicolas-grekas/sf5-cmd
...
Fix compat of commands with Symfony 5
2019-10-23 16:12:18 +02:00
Nicolas Grekas
4d6b1f3e63
Fix compat of commands with Symfony 5
2019-10-23 16:00:19 +02:00
Jonathan H. Wage
d9c30e34c4
Merge pull request #7723 from nicolas-grekas/sf5
...
Allow Symfony 5.0
2019-10-23 15:57:25 +02:00
Nicolas Grekas
90c1ee0bd0
Allow Symfony 5.0
2019-10-23 15:57:25 +02:00
Marco Pivetta
cfcca3a63c
Merge pull request #7600 from Majkl578/travis-php7.4-2.7
...
[2.7] CI: Test against PHP 7.4snapshot instead of nightly (8.0)
2019-10-23 15:57:24 +02:00
Michael Moravec
af0949adab
Merge pull request #7382 from Majkl578/homepage-2.7
...
Update homepage
2019-10-23 15:57:24 +02:00
Michael Moravec
cdb652ad87
CI: Test against PHP 7.4snapshot instead of nightly (8.0)
2019-10-23 15:57:24 +02:00
Claudio Zizza
4fb1ebfc10
Create 2.7 upgrade headline for deprecation changes
2019-10-23 15:57:24 +02:00
Michael Moravec
46c1b57560
Update homepage
2019-10-23 15:57:24 +02:00
Claudio Zizza
fdbbf7edd1
Add deprecation of EntityManagerInterface::copy() to upgrade information
2019-10-23 15:57:23 +02:00
Claudio Zizza
2fed8204c1
Set copy-method as deprecated
2019-10-23 15:57:23 +02:00
Michael Moravec
76f03b5db0
Bump version to 2.7-dev
2019-10-23 15:57:19 +02:00
Guilherme Blanco
9fef4e86e4
Merge pull request #7871 from BenMorel/2.6
...
AbstractQuery::getSingleScalarResult() throws exception when no result
2019-10-18 10:37:53 -04:00
Benjamin Morel
4781dc03e9
AbstractQuery::getSingleScalarResult() throws exception when no result
2019-10-16 20:41:00 +02:00
Benjamin Morel
cc5f84ac22
UnitOfWork::clear() misses $eagerLoadingEntities
2019-10-16 10:11:55 +02:00
Marco Pivetta
023e94661a
#7837 force expiry of query cache when WhereInWalker is being used
...
In order to figure out the paginated query identifier type, we would
have to parse the DQL query into an AST+SQL anyway, so we'd have
to re-parse it manually: instead of doing that, we can force the
`WhereInWalker` to be reached at all times by forcing the
`$whereInQuery` to use no query cache.
While it is a sad performance regression, it is also not a
noticeable one, since we'll be performing an `O(1)` operation
around an I/O one (query execution, in this case).
2019-10-10 18:23:31 +02:00
Marco Pivetta
b59fc23f86
#7837 reproduced issue: DQL caching prevents WhereInWalker run
...
Since `WhereInWalker` does not run, query parameters are not translated
from their in-memory type to the expected SQL type when the paginator
is run again with the same DQL string. This is an architectural
issue, since (for the sake of simplicity) we moved parameter
translation into the SQL walker, we didn't consider that SQL
walkers only act when no cache is in place. The translatio
needs to be moved into the paginator logic again.
2019-10-10 17:30:43 +02:00
Luís Cobucci
d71dd5d94f
Bump up version
2019-10-08 20:04:50 +02:00
Luís Cobucci
63513e9a05
Merge pull request #7856 from lcobucci/fix/underscore-strategy-dont-work-with-numbers
...
Fix underscore naming strategy behaviour with numbers
2019-10-08 12:06:24 +02:00
Luís Cobucci
c802bc46a5
Format NamingStrategyTest according to our CS
2019-10-08 11:56:11 +02:00
Luís Cobucci
506bf0ee12
Allow numbers in property names on underscore naming strategy
2019-10-08 11:56:11 +02:00
Luís Cobucci
a36809db72
Merge pull request #7851 from peter-gribanov/reflFieldValue2.6
...
Remove not used variable $reflFieldValue in ObjectHydrator
2019-10-04 07:50:26 +02:00
Peter Gribanov
5b00d7ba5e
remove not used variable $reflFieldValue in ObjectHydrator
2019-10-03 11:14:24 +03:00
Luís Cobucci
b22604352d
Merge pull request #7849 from axi/patch-1
...
Mention SQL logger impact on batch processing
2019-10-02 14:14:48 +02:00
axi
00c6b1bc60
Update batch-processing.rst
...
Clarify note
2019-10-02 14:00:06 +02:00
Luís Cobucci
4b0d86ee92
Merge pull request #7842 from vpArth-php/gh-7841
...
#7841 SchemaTool generates extra diff for platforms without FK support
2019-10-02 10:50:42 +02:00
Alexander Deider
3707c39124
#7841 SchemaTool generates extra diff for platforms without FK support
2019-10-02 15:35:59 +07:00
Luís Cobucci
fe72b00df2
Merge pull request #7850 from nlx-lars/nlx-lars/bugfix/7836-dont-merge-criteria
...
Don't merge PersistentCollection orderBy with criteria in matching()
2019-10-02 10:02:38 +02:00
Lars Lauger
79a7ecc92f
Don't merge PersistentCollection orderBy with criteria in matching()
...
If no orderings are given to PersistentCollection::matching(), the
orderBy annotation will be used if present. If the criteria contains
orderings, those will be used without merging them with the orderBy.
See #7836
2019-10-02 09:23:38 +02:00
Luís Cobucci
16df8bfe0d
Merge pull request #7298 from dunglas/patch-2
...
Add a missing type in Query::getFirstResult PHPDoc
2019-10-02 04:27:19 +02:00
Kévin Dunglas
b37ceaa9f7
Add a missing type in Query::getFirstResult and Query::getDQL
2019-10-02 04:13:42 +02:00
Luís Cobucci
c41fdbce8a
Merge pull request #7727 from madand/patch-1
...
[doc] Finish incomplete definition of class UTCDateTimeType
2019-10-02 04:11:20 +02:00
Luís Cobucci
7526adc80a
Merge pull request #7443 from naitsirch/fix/issue6793
...
Added doc about exception in Query#getOneOrNullResult()
2019-10-02 04:07:25 +02:00
Andriy Kmit
766eb693fb
Finish incomplete definition of class UTCDateTimeType
2019-10-02 03:57:06 +02:00
Luís Cobucci
f9e2ae3488
Merge pull request #7667 from jschaedl/patch-1
...
Fixes example One-To-One, Self-referencing
2019-10-02 03:56:01 +02:00
Luís Cobucci
6bf2ff5d10
Merge pull request #7671 from jschaedl/patch-4
...
Added missing "the"
2019-10-02 03:45:50 +02:00
Jan Schädlich
27fcc01d81
Fixes example One-To-One, Self-referencing
2019-10-02 03:37:23 +02:00
Jan Schädlich
3ac1f8e680
Added missing "the"
2019-10-02 03:36:06 +02:00
Luís Cobucci
b63db53552
Merge pull request #7764 from guillaume-a/7763
...
#7763 escape quotes in field comments
2019-10-02 02:56:05 +02:00
Guillaume Aveline
bed8186573
Fix comment quoting in the EntityGenerator
...
Fixes: https://github.com/doctrine/orm/issues/7763
2019-10-02 02:42:09 +02:00
Luís Cobucci
f08ff83d0a
Merge pull request #7768 from mickaelandrieu/patch-1
...
EntityManagerHelper can't accept an array of paths
2019-10-01 22:51:13 +02:00
axi
7c8c0906be
Update batch-processing.rst
...
Looking for a way to improve one of our bulk update treatment, I went back to this page then found elsewhere that setting logger to null was a really effective way to improve time and memory consumption. Might be a right place to state it ? Don't know if my edit style is ok
2019-10-01 17:46:09 +02:00
Grégoire Paris
167cb44ea1
Merge pull request #7742 from bocharsky-bw/patch-1
...
Start i var from 1 instead of 0
2019-09-28 18:54:56 +02:00
Mickaël Andrieu
5d74bdb240
Remove misleading documentation
...
EntityManagerHelper does not have a second argument, see
ca38249f6c/lib/Doctrine/ORM/Tools/Console/Helper/EntityManagerHelper.php (L49)
2019-09-28 12:32:09 +02:00
Luís Cobucci
ca38249f6c
Merge pull request #7838 from samnela/fix/name-classmetadata
...
Fix the name of ClassMetadata in documentation
2019-09-27 22:31:49 +02:00
Samuel NELA
6a74f373b9
Fix the name of ClassMetadata in documentation
2019-09-27 21:59:32 +02:00
Luís Cobucci
b52ef5a100
Merge pull request #7322 from dennisenderink/fix/joinedsubclasspersister-pass-identifier-types-on-delete
...
JoinedSubclassPersister pass identifier types on delete
2019-09-20 16:30:26 +02:00
Luís Cobucci
ef783f7049
Make use of the PersisterHelper to get field type
...
Removing the unnecessary code duplication.
2019-09-20 16:17:43 +02:00
Luís Cobucci
435d624d33
Centralise functional test classes
...
Which provides better isolation and makes things a bit more
understandable.
2019-09-20 16:17:43 +02:00
Dennis Enderink
53775fe086
Added correct return types to docblock
2019-09-20 16:17:43 +02:00
Dennis Enderink
59f1679fed
Patched spacing
2019-09-20 16:17:43 +02:00
Dennis Enderink
390d081fca
Created new DBAL type and updated/reverted tests; also clarified new method return type
2019-09-20 16:17:43 +02:00
Dennis Enderink
37d1d57900
Added unit tests
2019-09-20 16:17:42 +02:00
Dennis Enderink
d7a537c941
Pass ClassMetadata object instead of string in parent classes loop
2019-09-20 16:17:42 +02:00
Dennis Enderink
cfe73cd74f
Separated class identifiers types retrieval in a separate method and implemented in JoinedSubclassPersister delete method
2019-09-20 15:40:03 +02:00
Luís Cobucci
d0e1da8c51
Merge pull request #7490 from vladyslavstartsev/patch-2
...
Fix broken link
2019-09-20 15:32:13 +02:00
vladyslavstartsev
7fbe663ea0
Fix broken link
...
closing #7489
2019-09-20 15:31:12 +02:00
Luís Cobucci
409f2f5d82
Merge pull request #7672 from jschaedl/patch-5
...
Added cross-links to relevant documentation
2019-09-20 15:30:14 +02:00
Luís Cobucci
3d8b672771
Merge pull request #7610 from smtchahal/patch-1
...
Change APC to OPcache in improving-performance.rst
2019-09-20 15:29:07 +02:00
Jan Schädlich
17650a6100
Added cross-links to relevant documentation
2019-09-20 15:19:49 +02:00
Luís Cobucci
1588ca7e1f
Merge pull request #7821 from Ocramius/bug/#7820-paginator-ignores-dbal-type-conversions-in-identifiers
...
Bug: #7820 paginator ignores dbal type conversions in identifiers
2019-09-20 15:13:58 +02:00
Marco Pivetta
0de17319d3
#7820 use PersisterHelper to figure out identifier types
...
This logic was pre-existing, but I forgot about it while writing
#7820 , therefore it was re-implemented inside this unit of
code. Now we just use the `PersisterHelper`, which does all
the nice and shiny identifier type discovery operations we need.
2019-09-20 15:03:22 +02:00
Marco Pivetta
681ff32e76
#7820 documented PersisterHelper#getTypeOfField() array return type
...
Array values are `string`, and the array is a packed array.
2019-09-20 14:57:44 +02:00
Marco Pivetta
caee6c8685
#7820 restricted return type of Doctrine\ORM\Mapping\ClassMetadataInfo#getTypeOfColumn()
...
This method will always return `string|null`, so we can safely
remove DBAL types from its possible return types.
2019-09-20 14:51:56 +02:00
Marco Pivetta
c67a515cc2
As per discussion with @lcobucci, it is better to keep dragons where
...
there be dragons, and this change does indeed rewrite the previous
approach by moving the responsibility of type conversion on a query
object from the `Paginator` to the `WhereInWalker`, which already
has access to class metadata for the root of the selection (and can
reliably detect the root of the selection too)
2019-09-19 20:05:34 +02:00
Luís Cobucci
24892779f7
Merge pull request #7818 from SenseException/simple-annotation-docs
...
Add note into docs about not using SimpleAnnotationReader
2019-09-18 10:49:43 +02:00
Marco Pivetta
39d2113549
Fixed #7820 - convert identifiers for WHERE IN(?) queries before binding parameters
...
This patch introduces new internal API on the `ResultSetMapping` class, which is responsible
for finding the type of the single column identifier of a DQL query selection root.
2019-09-17 16:54:25 +02:00
Marco Pivetta
65522d9775
Failing test case for #7820 - paginator doesn't use custom ID types
...
When using a `Doctrine\ORM\Tools\Pagination\Paginator` to iterate over a query that has entities with a custom DBAL type used in the identifier, then `$id->__toString()` is used implicitly by PDO, instead of being converted by the `Doctrine\DBAL\Types` system.
In order to reproduce this, you must have identifiers implementing `#__toString()` (to allow the `UnitOfWork` to hash them) and other accessors that are used by the custom DBAL type during DB/PHP conversions. If `#__toString()` and the DBAL type conversions are asymmetric, then the paginator will fail to find records.
Tricky situation, but this very much affects `ramsey/uuid-doctrine` and anyone relying on the `uuid_binary`.
2019-09-17 11:37:50 +02:00
Claudio Zizza
50eecf698c
Add note into docs about not using SimpleAnnotationReader
2019-09-15 22:50:46 +02:00
Luís Cobucci
20ab78e3c1
Merge pull request #7753 from SenseException/getting-started-annotation
...
Add ORM annotations in getting-started docs
2019-09-12 17:01:53 +02:00
Luís Cobucci
613ffe9bbd
Backport documentation sidebar
2019-09-10 16:31:41 +02:00
Luís Cobucci
61ff45f98e
Merge pull request #7785 from mlocati/php74-fixes
...
Fix "access array offset on value of type null" PHP 7.4 notices
2019-09-10 16:08:49 +02:00
Luís Cobucci
a8aa475d09
Add PHP 7.4 to test matrix
2019-09-10 15:48:05 +02:00
Luís Cobucci
a4215cfa59
Update locked dependencies
2019-09-10 15:48:04 +02:00
Luís Cobucci
a4ac9a721f
Upgrade PHPUnit to 7.5
2019-09-10 15:48:03 +02:00
Michele Locati
447183e235
Fix "access array offset on value of type null" PHP 7.4 notices
2019-09-10 15:47:57 +02:00
Luís Cobucci
642e543b4b
Merge pull request #7778 from umpirsky/fix/issue-7266
...
Guard L2C regions against corrupted data
2019-08-14 18:07:58 +02:00
Luís Cobucci
80503c4837
Guard cache regions against corrupted data
...
For some bizarre reason the underlying cache drivers are returning
unexpected values, which are leaking to the cache objects and causing
them to error.
This makes our cache regions much more strict about the types that are
fetched from the cache provider, ensuring that no invalid information is
ever sent to the hydrators.
2019-08-14 17:42:56 +02:00
Luís Cobucci
3577064f8c
Make closure static
...
To adhere to our coding standard.
2019-08-14 17:42:56 +02:00
Luís Cobucci
b6663733c0
Add type assertion to be more strict about persister type
2019-08-14 17:42:56 +02:00
Luís Cobucci
b9d6834213
Remove unnecessary function calls
2019-08-14 17:42:56 +02:00
Luís Cobucci
eafc4c5a0c
Remove unnecessary parentheses
2019-08-14 17:42:56 +02:00
Saša Stamenković
ecf80b47a0
Call to a member function resolveAssociationEntries() on boolean
...
The following mistakes occur occasionally:
```
Call to a member function resolveAssociationEntries() on boolean {"detail":"[object] (Symfony\\Component\\Debug\\Exception\\FatalThrowableError(code: 0): Call to a member function resolveAssociationEntries() on boolean at /www/vendor/doctrine/orm/lib/Doctrine/ORM/Cache/DefaultQueryCache.php:140)"}
```
On cache miss the parameter `$entityEntry` sometimes will be false. This fixes issue #7266 .
2019-08-14 17:42:56 +02:00
Luís Cobucci
5499555862
Merge pull request #7791 from Steveb-p/fix-docs
...
Fix preFlush event documentation stating incorrectly that flush can be called safely
2019-08-14 14:03:13 +02:00
Paweł Niedzielski
70df74f65f
Fix preFlush event documentation stating incorrectly that flush can be called safely
...
Original author: egonolieux
Supersedes #6858
2019-08-14 13:41:31 +02:00
Luís Cobucci
74415becce
Merge pull request #7737 from Smartel1/smartel1/patch1
...
Fix MEMBER_OF comparison when using criteria in query builder
2019-08-14 10:07:11 +02:00
drews
3a56cf8ad9
Add MEMBER_OF comparison to queryExpressionVisitor
2019-08-14 09:47:20 +02:00
Luís Cobucci
6b7f53f0f3
Merge pull request #7766 from stephanschuler/respect-collection-ordering-in-selectable-matching
...
Respect collection orderBy meta when matching()
Fixes https://github.com/doctrine/orm/issues/7767
2019-08-13 23:42:32 +02:00
Stephan Schuler
e51666e8be
Fix PersistentCollection::matching() not respecting collection ordering
...
The ordering of a Criteria is prefered over the collections default
ordering.
The default collection ordering used as additional sorting attributes.
2019-08-13 23:34:54 +02:00
Luís Cobucci
6e56bcd75f
Merge pull request #7750 from AlexSmerw/issue_7735_null_values_in_entities_cache_for_2.6
...
Fix incorrect return of null values in L2C
2019-08-12 01:28:20 +02:00
Luís Cobucci
48bfef1f7a
Merge pull request #7761 from paxal/persistent_collection/deferred_explicit_2.6
...
Do not modify UOW on PersistentCollection::clear() when owner has DEFFERED_EXPLICIT change tracking policy
2019-08-12 01:21:21 +02:00
A.Kuterev
e8f91434a7
Avoid reusing variable name
...
The same variable name is used below, and that causes a bug etc.
Fixes https://github.com/doctrine/orm/issues/7735
2019-08-12 01:18:48 +02:00
Luís Cobucci
7e26d82790
Merge pull request #7794 from lcobucci/fix-compatibility-with-dev-dependencies
...
Fix test compatibility with DBAL 2.10.x-dev
2019-08-12 00:00:45 +02:00
Luís Cobucci
869b70e4db
Use Ubuntu Xenial for MySQL 5.7 build
...
Since July 21st 2019 it's no longer possible to install MySQL 5.7 in
Ubuntu Trusty.
More info: https://docs.travis-ci.com/user/database-setup/#mysql-57
2019-08-11 23:41:32 +02:00
Luís Cobucci
33904cb9c1
Fix test compatibility with DBAL 2.10.x-dev
2019-08-11 23:41:32 +02:00
Cyril PASCAL
a42191eecf
Add functional test for ArrayCollection::clear() bug
2019-07-19 16:21:12 +02:00
Cyril PASCAL
3fbf163d34
Do not modify UOW on PersistentCollection::clear() when owner has DEFFERED_EXPLICIT change tracking policy
2019-06-26 16:07:15 +02:00
naitsirch
1c45e1b744
Fixed grammatical mistake in doc
...
Co-Authored-By: Grégoire Paris <postmaster@greg0ire.fr >
2019-06-24 22:07:56 +02:00
Claudio Zizza
c777aa62b6
Fix of ORM annotation in examples
2019-06-23 23:39:41 +02:00
Luís Cobucci
6296bd4e1d
Merge pull request #7744 from noobshow/patch-1
...
Fixed a typo-error
2019-06-18 08:30:35 +02:00
Luís Cobucci
5a236c19f5
Merge pull request #7731 from greg0ire/try-mysql-addon
...
Replace custom install script with add-on
2019-06-17 23:33:04 +02:00
Olumide Samson
4f8a1f92a3
Fixed a typo-error
...
exploitet changed to exploited
2019-06-17 09:00:45 +01:00
Victor Bocharsky
5612790307
Start i var from 1 instead of 0
...
Because (0 % $batchSize) === 0 but we don't want to execute flush() and clear() on the first iteration.
2019-06-11 13:19:56 +03:00
Jonathan H. Wage
0b5be00374
Merge pull request #7732 from lchrusciel/patch-1
...
[Documentation] Missing comma fix
2019-06-04 11:11:46 -05:00
Łukasz Chruściel
145cc782ff
[Documentation] Missing comma fix
2019-06-04 17:38:26 +02:00
Jonathan H. Wage
9712506be8
Merge pull request #7729 from JoppeDC/patch-1
...
Update DATE_ADD and DATE_SUB docs
2019-06-04 10:23:15 -05:00
Grégoire Paris
bd9ead11c5
Replace custom install script with add-on
...
Following this documentation:
https://docs.travis-ci.com/user/database-setup/#mysql-57
found via https://stackoverflow.com/a/49542847/353612
2019-06-03 22:12:54 +02:00
Joppe de Cuyper
a98ebf7344
Whitespace fixes
2019-06-03 20:21:19 +02:00
Joppe de Cuyper
c721ab63ee
Update DATE_ADD and DATE_SUB docs
2019-06-03 20:20:03 +02:00
Jonathan H. Wage
2820438afc
Merge pull request #7694 from darrylhein/patch-1
...
Change variable name in docs
2019-04-29 11:00:10 -05:00
Darryl Hein
180cfcc3e3
change variable name
...
to make it consistent throughout document
2019-04-28 21:07:22 -06:00
Marco Pivetta
52d806a34a
Merge pull request #7612 from spirlici/patch-1
...
Update ordered-associations.rst
2019-03-12 00:16:09 +01:00
Marco Pivetta
49a8f2ec96
Merge pull request #7630 from yethee/gh-7629
...
Fix #7629 - `scheduledForSynchronization` leaks memory when using `@ORM\ChangeTrackingPolicy("DEFERRED_EXPLICIT")`
2019-03-01 21:24:57 +01:00
yethee
7f5f4629e5
Ensure state is cleanup after empty commit
2019-03-01 23:00:01 +03:00
yethee
d91e0b3867
Failing tests
2019-02-28 17:12:54 +03:00
Sergiu Pirlici
b537758b32
Update ordered-associations.rst
...
Fixed some typos
2019-02-16 15:04:45 +02:00
Sumit Chahal
2ba6e473de
Change APC to OPcache in improving-performance.rst
...
OPcache is a lot better supported now than APC,
which is apparently not maintained anymore.
2019-02-16 16:44:21 +05:30
Marco Pivetta
de97061d65
Merge pull request #7596 from mbessolov/patch-1
...
Correct method names and broken link in docs
2019-02-09 15:47:17 +01:00
Michael Bessolov
624ee78081
Correct method names and broken link in docs
...
This basically applying the same documentation fix as in #7335 (master) to 2.6 branch
2019-02-08 22:29:10 -08:00
Marco Pivetta
e003bb2bb4
Merge pull request #7577 from SenseException/advanced-config-link
...
Fix of single link to dbal docs in advanced-configuration.rst
2019-01-23 07:48:12 +01:00
Claudio Zizza
5c5f310646
Fix of link to dbal docs
2019-01-22 22:42:13 +01:00
Marco Pivetta
c10433e512
Merge pull request #7572 from SenseException/remove-codeigniter
...
Remove codeigniter Framework example
2019-01-17 22:35:58 +01:00
Claudio Zizza
580c530041
Remove codeigniter example from docs
2019-01-17 21:54:33 +01:00
Marco Pivetta
4d461afbd6
Merge pull request #7571 from batwolf/patch-1
...
Fix typo in inheritance mappings docs
2019-01-17 21:42:45 +01:00
Marco Pivetta
536e31f343
Merge pull request #7385 from SenseException/links-and-typos
...
Update information and links of documentation
2019-01-17 21:11:50 +01:00
Marc Plotz
c6eb4df25e
fix typo
...
`has to allow null values` vs `has to allows null values`
2019-01-17 10:14:56 +01:00
Claudio Zizza
aae00e3987
Fix of links and php version after review
2019-01-07 14:40:26 +01:00
Claudio Zizza
b56800b15c
Fix of links and anchors
2019-01-07 14:40:17 +01:00
Claudio Zizza
be461be36b
Update getting help section
2019-01-07 14:40:10 +01:00
Claudio Zizza
85171a9490
Fix of reStructuredText format
2019-01-07 14:40:02 +01:00
Claudio Zizza
f5b9f2052a
Update MySQL links to current version
2019-01-07 14:39:54 +01:00
Claudio Zizza
3d652997d1
Remove changelog from documentation
...
This was removed in favour of the UPGRADE.md file, which
contains the changelog information needed.
2019-01-07 14:39:42 +01:00
Marco Pivetta
10393dca68
Merge pull request #7557 from doctrine/malarzm-patch-1
...
Change Stackoverflow tag to doctrine-orm
2019-01-05 17:48:41 +01:00
Maciej Malarz
597bfaea03
Change Stackoverflow tag to doctrine-orm
2019-01-04 22:20:24 +01:00
Jonathan H. Wage
98b8ced814
Merge pull request #7551 from Majkl578/repo-rename/2.6
...
[2.6] Migrate repository name doctrine/doctrine2 -> doctrine/orm
2019-01-03 17:18:59 -06:00
Michael Moravec
efaee8ce85
Migrate repository name doctrine/doctrine2 -> doctrine/orm
2019-01-03 09:07:03 +01:00
Luís Cobucci
6e93f5bb72
Merge pull request #7528 from Ocramius/fix/#7527-prevent-unit-of-work-lookup-for-known-value-types
...
Fix #7527 : prevent `UnitOfWork` lookup for DBAL types specified in `Doctrine\ORM\Query#setParameter()`
2018-12-21 21:54:20 +01:00
Marco Pivetta
a41f5673bc
#7527 automated CS checks
2018-12-20 22:59:46 +01:00
Marco Pivetta
ca436f0bae
#7527 performance benchmark - verifying performance impact of inferred query parameter types
...
As an example result:
```
./phpbench.phar run tests/Doctrine/Performance/Query --iterations=50 --revs=50 --report=aggregate
PhpBench 0.15-dev (dcbe193). Running benchmarks.
Using configuration file: /home/ocramius/Documents/doctrine/doctrine2/phpbench.json
\Doctrine\Performance\Query\QueryBoundParameterProcessingBench
benchExecuteParsedQueryWithInferredParameterTypeI49 P0 [μ Mo]/r: 643.684 634.664 (μs) [μSD μRSD]/r: 17.700μs 2.75%
benchExecuteParsedQueryWithDeclaredParameterTypeI49 P0 [μ Mo]/r: 97.673 94.251 (μs) [μSD μRSD]/r: 8.259μs 8.46%
2 subjects, 100 iterations, 100 revs, 0 rejects, 0 failures, 0 warnings
(best [mean mode] worst) = 88.460 [370.679 364.458] 127.400 (μs)
⅀T: 37,067.880μs μSD/r 12.980μs μRSD/r: 5.603%
suite: 133f0e30090f815142331ebec6af18241694e7c0, date: 2018-12-19, stime: 10:47:10
+------------------------------------+--------------------------------------------------+--------+--------+------+-----+------------+-----------+-----------+-----------+-----------+----------+--------+-------+
| benchmark | subject | groups | params | revs | its | mem_peak | best | mean | mode | worst | stdev | rstdev | diff |
+------------------------------------+--------------------------------------------------+--------+--------+------+-----+------------+-----------+-----------+-----------+-----------+----------+--------+-------+
| QueryBoundParameterProcessingBench | benchExecuteParsedQueryWithInferredParameterType | | [] | 50 | 50 | 5,970,568b | 604.680μs | 643.684μs | 634.664μs | 677.640μs | 17.700μs | 2.75% | 6.59x |
| QueryBoundParameterProcessingBench | benchExecuteParsedQueryWithDeclaredParameterType | | [] | 50 | 50 | 5,922,424b | 88.460μs | 97.673μs | 94.251μs | 127.400μs | 8.259μs | 8.46% | 1.00x |
+------------------------------------+--------------------------------------------------+--------+--------+------+-----+------------+-----------+-----------+-----------+-----------+----------+--------+-------+
```
This indicates that the performance impact for NOT declaring parameter types
explicitly is *MASSIVE*.
2018-12-19 10:52:11 +01:00
Marco Pivetta
d8212e8dd6
Merge pull request #7530 from vladyslavstartsev/patch-3
...
Documentation error fix
2018-12-17 16:00:44 +01:00
vladyslavstartsev
12eb9f42dc
Documentation error fix
2018-12-16 20:33:21 +02:00
Marco Pivetta
23af164d7a
Note: this will still lead to the UnitOfWork#getSingleIdentifierValue() still being
...
called when not specifying the type of a DQL parameter being bound via
`Doctrine\ORM\Query#setParameter()`:
```php
$query->setParameter('foo', $theValue, $theType);
```
A full parameter bind is required in order to gain back performance:
```php
$query->setParameter('foo', $theValue, $theType);
```
This is up for discussion with patch reviewers.
2018-12-16 18:05:02 +01:00
Marco Pivetta
960a437d46
#7527 failing test case: UnitOfWork#getSingleIdentifierValue() should not be called for a well specified parameter type
...
As previously reported by @flaushi in https://github.com/doctrine/doctrine2/pull/7471#discussion_r241949045 , we discovered
that binding a parameter causes a `ClassMetadataFactory#getClassMetadata()` call, which in turn leads to large performance
regression when using any `object` type as parameter.
Following two snippets lead to an internal `ClassMetadataFactory#getClassMetadata()` call, which in turn leads to an
exception being thrown and garbage collected, plus multiple associated performance implications:
```php
$query->setParameter('foo', new DateTime());
$query->getResult();
```
```php
$query->setParameter('foo', new DateTime(), DateTimeType::NAME);
$query->getResult();
```
This is due to following portion of code:
434820973c/lib/Doctrine/ORM/Query.php (L406-L409)
Notice how `$value = $this->processParameterValue($value);` happens before attempting to infer the type for the parameter value.
That call leads to this segment being reached, which leads to the regression:
434820973c/lib/Doctrine/ORM/AbstractQuery.php (L423-L433)
Assuming the bound parameter type is provided, we can completely skip attempting to introspect the given object:
```php
$query->setParameter('foo', new DateTime(), DateTimeType::NAME);
$query->getResult();
```
Processing the parameter value is not needed in this case, so we can safely skip that logic for all known parameters.
In order to not introduce a BC break or change the `AbstractQuery#processParameterValue()` implementation, we could filter
out all parameters for which the type is given upfront, and later on merge them back in instead.
The test expectation to be set is for `UnitOfWork#getSingleIdentifierValue()` to never be called.
2018-12-16 15:37:45 +01:00
Marco Pivetta
237bebe2ed
Merge pull request #7519 from koftikes/fix/#7518-phpdoc-error
...
#7518 Fixed type mismatch between `EntityRepository#__construct()` and its documented constructor arguments
2018-12-13 08:14:30 +01:00
Jonathan H. Wage
fc3dca772e
Merge pull request #7521 from doctrine/update-chat-link
...
Update chat link from Gitter to Slack.
2018-12-12 20:07:31 +00:00
Konstantin Litvinov
ee64d31f48
7518 Fixed PHPDoc Error.
2018-12-12 17:08:35 +03:00
Michael Moravec
493ff74a0d
Merge pull request #7473 from Majkl578/incremental-cs-2.x
...
Incremental CS checks in 2.x branches
2018-12-10 14:43:55 +01:00
Michael Moravec
78c7000962
Lock dependencies for Code Quality stage
2018-12-10 13:58:51 +01:00
Michael Moravec
6a05e01298
Perform incremental coding standard checks for pull requests
2018-12-10 13:58:51 +01:00
Gabriel Ostrolucký
7de3434733
Update doctrine/coding-standard in 2.x branch
...
Co-Authored-By: Michael Moravec <me@majkl.me >
2018-12-10 13:58:51 +01:00
Luís Cobucci
74e6189f3e
Merge pull request #7483 from javiereguiluz/patch-9
...
Fixed a minor syntax issue
2018-11-21 10:48:33 +01:00
Javier Eguiluz
2e7a3affba
Fixed a minor syntax issue
2018-11-21 09:06:54 +01:00
Luís Cobucci
505ec21f97
Bump up development version
2018-11-21 01:24:06 +01:00
Luís Cobucci
434820973c
Bump up version
2018-11-21 00:46:46 +01:00
Luís Cobucci
41ff526921
Merge pull request #6830 from Tobion/fix-collation-foreign-key
...
fix applying column options on foreign key columns
2018-11-21 00:41:17 +01:00
Luís Cobucci
0be52b0087
Isolate entities used by the new test
...
To ensure we don't have any unintended side-effect.
2018-11-21 00:20:20 +01:00
Tobias Schultze
ee8dc496d9
Fix applying collation on foreign key columns
2018-11-21 00:20:15 +01:00
Luís Cobucci
f80656cddf
Merge pull request #7317 from protecinnovations/fix/7316-xml-order-by-dir-many-to-many
...
[XML] Fix default value of many-to-many order-by to ASC
2018-11-20 13:11:22 +01:00
Alex Denvir
72121c01ec
[XML] Fix default value of many-to-many order-by to ASC
2018-11-20 12:33:29 +01:00
Luís Cobucci
ac505390dd
Merge pull request #7472 from seferov/patch-2
...
fix incorrect phpdoc typehint
2018-11-20 09:41:01 +01:00
Luís Cobucci
728e6e15c5
Merge pull request #7441 from asgrim/fix-getResult-type
...
$hydrationMode throughout can be a string as well as int (for custom modes)
2018-11-20 09:40:04 +01:00
Luís Cobucci
d21305378c
Merge pull request #7471 from alcaeus/fix-unloaded-metadata-parameter-processing
...
Fix parameter value processing for objects with unloaded metadata
2018-11-15 11:34:31 +01:00
Andreas Braun
0552749059
Fix parameter value processing for objects with unloaded metadata
2018-11-15 11:21:05 +01:00
Farhad Safarov
fbd3fe95e4
fix incorrect phpdoc typehint
2018-11-13 13:01:10 +03:00
James Titcumb
c6d02daee0
$hydrationMode throughout can be a string as well as int (for custom modes)
2018-11-12 13:58:42 +00:00
Luís Cobucci
5208035003
Merge pull request #7444 from naitsirch/fix/issue6968
...
Fixed URLs of doctrine-mapping.xsd in docs
2018-11-12 11:40:01 +01:00
Luís Cobucci
d93956eff0
Use HTTPS endpoint for XML schema location
2018-11-12 11:29:32 +01:00
naitsirch
b3b06d3e7d
Fixed URLs of doctrine-mapping.xsd in docs
...
Until now the references to the `doctrine-mapping.xsd` consisted of different URLs.
A grep of docs showed:
* /Users/robo/dev/php/Doctrine/doctrine-mapping.xsd
* http://doctrine-project.org/schemas/orm/doctrine-mapping.xsd
* http://www.doctrine-project.org/schemas/orm/doctrine-mapping.xsd
* https://raw.github.com/doctrine/doctrine2/master/doctrine-mapping.xsd
Now it is used http://doctrine-project.org/schemas/orm/doctrine-mapping.xsd everywhere.
2018-11-12 11:09:15 +01:00
Michael Moravec
427f815975
Merge pull request #7465 from unguul/patch-1
...
Fixes tiny typo in the 'Working with DateTime instances' documentation
2018-11-11 23:24:29 +01:00
Michael Moravec
bf601ce268
Merge pull request #7421 from seferov/patch-1
...
JIRA to Github issues on Limitations and Known Issues
2018-11-11 23:24:00 +01:00
Michael Moravec
8bfb363fcc
Merge pull request #7434 from naitsirch/fix/doc-faq-public-property
...
Removed FAQ paragraph stating public variables are disallowed
2018-11-11 23:22:58 +01:00
Michael Moravec
ebf2630a66
Merge pull request #7435 from oguzdumanoglu/patch-2
...
Fix a typo on Documentation
2018-11-11 23:22:25 +01:00
Michael Moravec
9018955e1f
Merge pull request #7412 from ThomasLandauer/patch-1
...
Some formatting improvements
2018-11-10 21:05:50 +01:00
Thomas Landauer
88d58ae0a3
Some formatting improvements
2018-11-10 20:45:03 +01:00
Michael Moravec
2fc99afd44
Merge pull request #7423 from ThomasLandauer/patch-2
...
Update association-mapping.rst
2018-11-10 20:40:44 +01:00
Michael Moravec
fa0885e25d
Merge pull request #7374 from SenseException/deprecate-yaml-docs
...
Deprecation message in documentation for YAML
2018-11-10 20:33:51 +01:00
Alexandru Ungureanu
0e4a0108d2
Fixes small typo
2018-11-08 13:59:21 +02:00
naitsirch
17bc627bf2
Added hint about exception in Query#getOneOrNullResult()
...
When calling `Query#getOneOrNullResult()` and there are more than one
objects in the result an `NonUniqueResultException` is thrown.
This information was missing in the documentation about the query result
formats.
This commit addresses #6793 .
2018-10-29 21:26:02 +01:00
Oguz Dumanoglu
58370256c0
Fix a typo
...
There was a typo in Working with Associations page.
2018-10-19 16:32:27 +02:00
naitsirch
d5364231c2
Removed FAQ paragraph stating public variables are disallowed
...
In #7427 @flaushi mentioned the outdated paragraph. This commit removes
this one.
2018-10-18 22:36:29 +02:00
Luís Cobucci
4df3a4d436
Merge pull request #7428 from Majkl578/php7.3
...
CI: Test against PHP 7.3
2018-10-14 09:39:26 +02:00
Michael Moravec
812989490c
CI: Test against PHP 7.3
2018-10-13 20:33:26 +02:00
Thomas Landauer
892ef9edb7
Update association-mapping.rst
...
Added info about owning and inverse side.
2018-10-09 21:33:42 +02:00
Farhad Safarov
982782f8c9
JIRA to Github issues
2018-10-09 11:52:22 +03:00
Michael Moravec
7319f524a3
Merge pull request #7397 from eibt/patch-1
...
Update getting-started.rst
2018-09-23 07:04:34 +02:00
Michael Moravec
1d71fbf77b
Merge pull request #7367 from timdev/fix/entitymanager-find-with-optimistic-lock-no-need-tx
...
Fix for BC break in 2.6.2 when calling EM::find() with LockMode::OPTIMISTIC outside of a TX
2018-09-23 06:43:26 +02:00
Ivan
7eacfec2c3
Fix typo in getting-started.rst
2018-09-23 06:39:11 +02:00
Michael Moravec
46f2a41cf7
Merge pull request #7377 from sserbin/fix-query-andx-doctype
...
Fix query andX doctype
2018-09-23 06:37:42 +02:00
Michael Moravec
fd2baf6f65
Merge pull request #7260 from stof/regression_commit_order
...
Fix the handling of circular references in the commit order calculator
2018-09-23 05:44:14 +02:00
Michael Moravec
c8bf06d549
Merge pull request #7401 from bobdenotter/patch-1
...
[docs] Fix docblock in `inheritance-mapping.rst`
2018-09-23 05:34:59 +02:00
Tim Lieberman
3acfa50214
Fix for BC break #7366 when calling EM::find() with LockMode::OPTIMISTIC outside of a TX
2018-09-23 05:33:05 +02:00
sserbin
3dbe205498
Query\Expr::andX(): added string as allowed parameter type
2018-09-23 05:23:49 +02:00
Michael Moravec
899cce8094
Merge pull request #7363 from philippe-unitiz/2.6
...
Fix compatibility with phan
2018-09-23 05:16:52 +02:00
Bob den Otter
7400d51444
Fix docblock in inheritance-mapping.rst
2018-09-23 05:12:55 +02:00
Michael Moravec
96c344d22b
Merge pull request #7345 from guilliamxavier/improve-DOMDocument-construct
...
Correct DOMDocument constructor in test
2018-09-23 05:11:21 +02:00
Michael Moravec
f48d71ecd0
Merge pull request #7378 from BenMorel/patch-2
...
Typo fix
2018-09-23 05:05:58 +02:00
philippe-unitiz
d3acbbf79b
Fix constructor argument type in Query\Base
2018-09-23 05:02:30 +02:00
philippe-unitiz
cb9ec8234b
Fix multiline parameter phpDoc in Query\Expr
...
See https://github.com/phan/phan/issues/1897 (parser won't accept `@param` spanning over several lines)
2018-09-23 05:02:01 +02:00
Guilliam Xavier
47c72e583e
correct load-only DOMDocument constructor in test
2018-09-23 04:52:52 +02:00
Christophe Coevoet
568c2d308c
Fix the computation of commit order for circular dependencies
...
When finding a circular dependencies, we must ensure that all dependencies
of a node have been visited before adding it to the sorted list.
2018-09-20 12:13:25 +02:00
Christophe Coevoet
11a7f359d1
Add a unit test reproducing the commit order regression
2018-09-20 12:11:44 +02:00
Christophe Coevoet
145f1f5198
Add a test reproducing GH7259
2018-09-20 11:53:08 +02:00
Claudio Zizza
ff1df41485
Add deprecation note to getting-started chapter
2018-09-07 21:06:08 +02:00
Claudio Zizza
d36aec8fb7
Add deprecation message for YAML into docs
2018-08-30 23:24:30 +02:00
Benjamin Morel
2779b5ee91
Typo fix
2018-08-28 14:56:01 +02:00
Pierre-Louis FORT
32efbd3edd
Handle removed parameters by tree walker in Paginator
2018-08-27 11:23:21 +02:00
Luís Cobucci
68718eac1b
Merge pull request #7360 from lcobucci/fix-partial-reference-docblock
...
Document getPartialReference() properly
2018-08-19 16:25:51 +02:00
Luís Cobucci
7b64b4a207
Document getPartialReference() properly
...
According to the current implementation that method also returns `null`,
however the interface's documentation was incorrect.
Ref: https://github.com/doctrine/doctrine2/blob/v2.6.2/lib/Doctrine/ORM/EntityManager.php#L514-L516
2018-08-18 14:52:17 +02:00
Michael Moravec
f1143f591f
Merge pull request #7325 from paxal/php73_compatible
...
Make code php 7.3 lint-compatible
2018-08-02 14:23:28 +02:00
Cyril PASCAL
07fc401d25
Make code php 7.3 lint-compatible
2018-07-26 14:32:52 +02:00
Luís Cobucci
96f166a7e9
Merge pull request #7307 from Majkl578/remaining-deprecations
...
Fix remaining usages of deprecated ClassLoader and Inflector from doctrine/common
2018-07-13 07:27:10 +02:00
Michael Moravec
f4b775323d
Fix remaining usages of deprecated ClassLoader and Inflector from doctrine/common
2018-07-13 05:31:39 +02:00
Michael Moravec
43d308116d
Bump version to 2.6.3-DEV
2018-07-12 23:24:26 +02:00
Michael Moravec
d2b4dd71d2
Preparing v2.6.2 release
2018-07-12 22:47:13 +02:00
Luís Cobucci
36e6a73d5b
Merge pull request #7296 from Majkl578/fix/2.6/#7286
...
Fix #7286 : StringPrimary no longer accepts aggregate functions as argument
2018-07-10 00:05:51 +02:00
Michael Moravec
e26158a45e
Fix #7286 : StringPrimary no longer accepts aggregate functions as argument
2018-07-09 19:12:39 +02:00
Marco Pivetta
3cfcd6a856
Merge pull request #7291 from Majkl578/fix/2.6/#7068
...
[2.6] Fix for #7068 : EntityManager::find() with pessimistic lock should check for transaction
2018-07-03 09:40:48 +02:00
Michael Kühn
ff68806bfa
Fix for #7068 : EntityManager::find() with pessimistic lock should check for transaction
2018-07-03 03:00:58 +02:00
Michael Moravec
4192c3abf4
Merge pull request #7290 from Majkl578/dbal-2.8-tests-compat
...
Fix compatibility with DBAL 2.8 (doctrine/dbal#3157 )
2018-07-03 02:58:02 +02:00
Michael Moravec
ac1e1c7d23
Fix compatibility with DBAL 2.8 where OFFSET 0 is no longer generated ( doctrine/dbal#3157 )
2018-07-03 02:14:23 +02:00
Luís Cobucci
9ab999618c
Merge pull request #7276 from Majkl578/entityrepository-count-upgrade
...
Add UPGRADE note for EntityRepository::count()
2018-07-03 02:05:46 +02:00
Michael Moravec
f2666a472f
Add UPGRADE note for EntityRepository::count()
2018-06-27 20:41:59 +02:00
Luís Cobucci
ceda5d3bc7
Merge pull request #7274 from Majkl578/non-deprecated-lexer-and-inflector
...
Use non-deprecated version of Lexer and Inflector
2018-06-25 23:56:32 +02:00
Michael Moravec
6d81d519b6
Use non-deprecated version of Lexer and Inflector
2018-06-25 14:20:52 +02:00
Marco Pivetta
88d1d79516
Merge pull request #7253 from JarJak/patch-2
...
Mention that Doctrine does not use Entities public API
2018-06-09 07:28:20 +02:00
Jarek Jakubowski
cfc6cfd1a3
Unnecessary newline removed, small improvements in text
2018-06-09 00:29:59 +02:00
Jarek Jakubowski
6b7d67b427
Add info about Doctrine not using constructor
2018-06-08 20:29:37 +02:00
Jarek Jakubowski
b6d08b15c0
Mention that Doctrine does not use Entities public API
2018-06-08 18:47:39 +02:00
Marco Pivetta
01f89a8cdc
Merge pull request #7190 from Tobion/patch-1
...
Fix wrong type in phpdoc of AbstractIdGenerator
2018-04-13 16:29:25 +01:00
mikeSimonson
efd7a5dca6
Merge pull request #7146 from Awkan/fix/7141-xml-order-by-default-asc
...
[XML] Fix default value of one-to-many order-by to ASC
2018-04-12 22:29:41 +02:00
Tobias Schultze
7ba0290643
entity should be nullable as in master
2018-04-10 19:15:48 +02:00
Tobias Schultze
8ceb47178b
Fix wrong type in phpdoc of AbstractIdGenerator
...
\Doctrine\ORM\Mapping\Entity is the annotation class which is not correct. The entity object itself is meant here as tests also assume see https://github.com/doctrine/doctrine2/blob/2.6/tests/Doctrine/Tests/ORM/Id/AssignedGeneratorTest.php#L28
Found this when running phpstan on our code that used a custom generator.
2018-04-10 18:31:36 +02:00
Donovan Bourlard
2560d4f419
Fix default value of one-to-many order-by to ASC, #7141
2018-03-22 14:51:02 +01:00
Marco Pivetta
87ee409783
Merge pull request #7082 from mariusklocke/issue-7062
...
Add failing test for issue #7062
2018-02-27 08:30:56 +01:00
Luís Cobucci
d47c1f3e9b
Fix basic entity persister type resolver
...
Which was using the wrong way to fetch the field type and using the
association type instead of the column type.
2018-02-26 14:39:06 +01:00
Marius Klocke
b952dac339
Add a failing test for issue 7062
2018-02-26 14:39:05 +01:00
Luís Cobucci
ffb7d4c79c
Merge pull request #7093 from lcobucci/patch-association-identifier-not-quoted
...
Fix updating entities with quoted identifier association
2018-02-25 20:28:33 +01:00
Jan Langer
e68717b725
Fix updating entities with quoted identifier association
2018-02-25 20:10:18 +01:00
Luís Cobucci
30a063ef9d
Merge pull request #6701 from vhenzl/pr/issue-6531-test
...
Add failing tests for #6531
Fixes https://github.com/doctrine/doctrine2/issues/6043
Fixes https://github.com/doctrine/doctrine2/issues/6531
Fixes https://github.com/doctrine/doctrine2/issues/7002
Fixes https://github.com/doctrine/doctrine2/pull/7003
2018-02-19 23:17:19 +01:00
Nicolas FRANÇOIS
35c3669ebc
Fix handling entities with post generated IDs as FK
...
This prevents a throw in UnitOfWork#addToIdentityMap because some fields
are null.
2018-02-19 23:05:13 +01:00
Vašek Henzl
23f4f03575
Add failing tests for #6531
...
Tests are based on examples from "Composite and Foreign Keys as Primary Key" tutorial:
http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/tutorials/composite-primary-keys.html
2018-02-19 22:14:57 +01:00
Luís Cobucci
a912fc09be
Add @group to delete query test
2018-02-19 22:04:28 +01:00
Marco Pivetta
a736a3713b
Merge pull request #6988 from kbond/inheritance-issue
...
Inheritance middle-layer doesn't get hydrated
2018-02-19 12:13:08 +01:00
Luís Cobucci
f2da5bc93e
Extract private method to retrieve discriminator values
2018-02-19 12:07:44 +01:00
Luís Cobucci
2905b435db
Remove loose comparison on discriminator values
...
According to mapping drivers the discriminator values can always be
converted to strings so it's safe to assume that we can actually do a
strict comparison during hydration.
2018-02-19 12:07:43 +01:00
Toni Cornelissen
48ca6dbcec
Use partial discriminator map on multi-inheritance
...
Hydrator was ignoring data from subclasses when using multiple
inheritance levels. With this patch it will now use the discriminator
values from all subclasses of the class being hydrated.
2018-02-19 12:07:42 +01:00
Kevin Bond
15a4302902
Inheritance middle-layer doesn't get hydrated with HYDRATE_OBJECT
2018-02-19 12:07:41 +01:00
Marco Pivetta
1f82a20312
Merge pull request #7077 from lcobucci/fix-delete-bc-break
...
Fix BC-break on delete without alias DQL
2018-02-19 11:32:46 +01:00
Luís Cobucci
fc943b70f6
Use early-returns to improve readability of the Parser
2018-02-19 00:53:42 +01:00
Luís Cobucci
f36470941c
Fix BC-break on delete queries with nasty workaround
...
The `v2.5.x` series of the ORM allowed to have DELETE DQLs without using
an alias, even though it didn't follow the grammar rules of the parser.
We fixed that issue on `v2.6.0` however that was a BC-breaking change
and lots of people were relying on this faulty behaviour.
This workaround fixes the BC-break, without even trying to be elegant.
In `v2.7.0.` we should raise a deprecation notice to notify people that
we'll drop that "feature" in `v3.0`.
2018-02-19 00:53:36 +01:00
Carnage
ae6d80daab
Adds sql generation test
2018-02-19 00:50:27 +01:00
Luís Cobucci
44e82e2720
Remove unused functions
2018-02-17 19:49:16 +01:00
Luís Cobucci
e94467d6da
Fix incorrect value in L2C+lock test
...
Which was causing the optimistic lock to fail in MySQL since it was
trying to update the data with exact same value.
2018-02-17 19:46:22 +01:00
Luís Cobucci
794c7708e8
Merge branch 'backport/fix/l2c-version' into 2.6
...
Backporting https://github.com/doctrine/doctrine2/pull/7069
2018-02-17 18:09:39 +01:00
‘Andrey Lukin’
8e73926359
Add version fields into L2C data
2018-02-17 18:05:32 +01:00
‘Andrey Lukin’
8fc1d74820
Add test for L2C using optimistic locks
...
As explained in #7067 , fields with `@ORM\Version` annotation were not
being added to L2C cached data.
2018-02-17 18:05:27 +01:00
Luís Cobucci
496c6a9f03
Merge branch 'backport/fix-date-issues-once-and-for-all' into 2.6
...
Backporting https://github.com/doctrine/doctrine2/pull/7055
2018-02-09 17:21:29 +01:00
Luís Cobucci
7873f700b0
Add missing tests for day calculation
...
For the DATE_SUB() and DATE_ADD() functions.
2018-02-09 17:21:06 +01:00
Luís Cobucci
46c0861f45
Fix date calculation in tests (again)
...
Now using PHP to calculate the expected date manipulation, keeping a day
as delta since PHP resets the hour when performing operations with
days/weeks/months/years.
February is a wonderful month, isn't it?
2018-02-09 17:21:06 +01:00
Luís Cobucci
5149c0ff25
Merge branch 'backport/fix/7031-tests-february' into 2.6
...
Backporting: https://github.com/doctrine/doctrine2/pull/7032
2018-02-02 09:07:25 +01:00
Michael Moravec
cf99d62472
QueryDqlFunctionTest: Increase delta for testDateAdd() to work in February
2018-02-02 08:59:35 +01:00
Luís Cobucci
5878797eae
Merge pull request #6971 from rolando-caldas/master
...
Exception Call to undefined method Doctrine\Common\Cache\MemcachedCache::setMemcache()
2018-01-30 01:53:35 +01:00
Rolando Caldas
8c2d090dc8
Exception Call to undefined method Doctrine\Common\Cache\MemcachedCache::setMemcache()
...
When memcached extension is loaded Doctrine\ORM\Tools\Setup.php calls to setMemcache method. The MemcachedCache class has the setMemcached method instead. Changed this call in Setup to setMemcached and $memcache to $memcached to keep the name like the extension
2018-01-30 01:38:56 +01:00
Luís Cobucci
3f772eac32
Merge pull request #7021 from lcobucci/fix-phpstan-check
...
Fix incorrect variable reference
2018-01-30 01:38:21 +01:00
Luís Cobucci
62c952d258
Fix wrong variable reference
2018-01-30 01:21:34 +01:00
Luís Cobucci
c2f698e56e
Merge pull request #6997 from NicolaF/fix/fix-6991-2.6
...
ManyToManyPersister fails to remove join table entry if there is multiple join columns
2018-01-30 01:19:12 +01:00
Nicolas FRANÇOIS
40f2a3efba
Add test case for many-to-many collection deletion, when owning side has a composite PK
2018-01-30 01:04:28 +01:00
Nicolas FRANÇOIS
333b9c0b99
Fix #6991 : correctly resolve identifer values in ManyToManyPersister
2018-01-19 12:19:02 +01:00
Luís Cobucci
90d19b4131
Bumping development version to v2.6.1-DEV
2017-12-20 02:01:05 +01:00
Luís Cobucci
374e7ace49
Preparing v2.6.0 release
2017-12-20 01:38:15 +01:00
Marco Pivetta
d752cafb47
Merge pull request #6911 from lcobucci/bump-dependencies
...
Require more up-to-date dependencies
2017-12-20 00:19:31 +01:00
Luís Cobucci
0e44271a40
Require more up-to-date dependencies
2017-12-20 00:10:05 +01:00
Marco Pivetta
4c89498359
Merge branch 'feature/#6767-allow-association-as-JTI-identifier'
...
Close #6767
2017-12-19 18:02:48 +01:00
Marco Pivetta
b6aa4bab15
#6767 using in_array rather than array_search
...
Ref: https://github.com/doctrine/doctrine2/pull/6767/files#r157355050
2017-12-19 18:01:38 +01:00
Marco Pivetta
27c42d418b
#6767 removed unused variable
...
Ref: https://github.com/doctrine/doctrine2/pull/6767/files#r157354726
2017-12-19 18:00:03 +01:00
Tyler Romeo
bb8970286d
Allow association mappings as IDs for joined-table inherited entity
...
SchemaTool has custom logic for creating the primary key of a
joined-table inherited entity. This logic overlooked association maps
as a possible source for identity columns, resulting in a fatal error
when fetching the primary key list for child entities.
Removed any custom logic for generating primary keys for root entities
in joined-table inheritance, deferring to the common logic used for
other entities.
Also adjusted the child entity logic, scanning association maps for
identity columns, and including the column as appropriate. It also
ensures that the primary key columns are in the correct order.
2017-12-19 17:58:31 +01:00
Luís Cobucci
b210c1e364
Merge pull request #6905 from Majkl578/setup-cache-7.1-compat
...
Setup: Switch Apc -> Apcu and Memcache -> Memcached
2017-12-19 08:21:02 +01:00
Guilherme Blanco
a16dc65cd2
Fixes #1391 , DDC-3693
2017-12-18 22:46:48 -05:00
Guilherme Blanco
0345f7b836
Merge pull request #1578 from StoshSeb/patch-1
...
Fixed DDC-3740
2017-12-18 22:41:18 -05:00
Michael Moravec
349724f05b
Setup: Switch Apc -> Apcu and Memcache -> Memcached
2017-12-19 02:43:03 +01:00
Michael Moravec
e1825e37ef
Merge pull request #6780 from aequasi/patch-1
...
getRepository actually returns ObjectRepository
2017-12-18 00:40:47 +01:00
Luís Cobucci
cfa1dfbfe6
Merge pull request #6887 from greg0ire/stable_stability
...
Use stable packages
2017-12-18 00:39:02 +01:00
Grégoire Paris
8e3c3f0bae
Add marker variable for Travis
2017-12-18 00:14:00 +01:00
Grégoire Paris
ad3c3f4114
Implement conditional build
...
This will make cron builds fail, which is a bit more noticeable than an
allowed failure.
2017-12-17 23:38:16 +01:00
Grégoire Paris
8ca7db8852
Use stable packages
...
This will make it easier to contribute. It will also make reviews safer
since you will be able to tell if a PR is reponsible for a broken build
or not. Catching errors early is still possible by having a look at
allowed failures.
2017-12-17 23:38:16 +01:00
Michael Moravec
ca42879f9e
Merge pull request #6898 from Majkl578/upgrade-typos
...
UPGRADE: Added method parenthesis, fixed method name
2017-12-17 04:43:43 +01:00
Michael Moravec
28b6ca3a16
UPGRADE: Added method parenthesis, fixed method name
2017-12-17 04:31:42 +01:00
Luís Cobucci
c4a5e5c3f8
Merge pull request #6748 from KonstantinKuklin/patch1
...
Fix missing null check on `AbstractQuery#setResultCacheProfile()`
2017-12-17 03:37:06 +01:00
Konstantin Kuklin
c308986a90
Fix insufficient variable check
...
To ensure that `AbstractQuery#setResultCacheProfile()` doesn't raise
errors when being called with `null`.
2017-12-17 03:21:52 +01:00
Luís Cobucci
739f518ebe
Merge pull request #6892 from thexpand/patch-1
...
Re-order attributes of relation complex types
2017-12-17 02:49:49 +01:00
Cvetomir
a46e794b60
Re-order attributes of relation complex types
...
This will provide the same look for all of the relations: one-to-many, many-to-one, one-to-one, many-to-many.
It helps during auto-completion of XML code when creating XML schema for an entity.
The order is as follows: field, target-entity, mapped-by, inversed-by, indexed-by, fetch, orphan-removal.
2017-12-17 02:36:41 +01:00
Luís Cobucci
d3ff823f97
Merge pull request #6812 from Deltachaos/bugfix/inheritance-joins-master
...
Fix syntax error when join unrelated entity with discriminator entity
2017-12-17 01:42:42 +01:00
Maximilian Ruta
32c125def1
Fix syntax error when join with discriminator
2017-12-17 01:25:50 +01:00
Michael Moravec
0837493a7c
Merge pull request #6894 from Majkl578/fix-readme-php-version
...
README: Fix PHP version
2017-12-17 01:16:50 +01:00
Luís Cobucci
260c2e899a
Merge pull request #6897 from lcobucci/update-phpstan
...
Upgrade PHPStan to 0.9.x
2017-12-17 01:08:48 +01:00
Luís Cobucci
74ce8913fc
Upgrade phpstan to 0.9
...
Applying the necessary fixes.
2017-12-17 00:55:50 +01:00
Luís Cobucci
80a94727ee
Run tests also with the stable version of dependencies
2017-12-17 00:54:12 +01:00
Luís Cobucci
d6212dd09e
Merge pull request #6896 from lcobucci/improve-build-stages
...
Run all code quality tools in the same stage
2017-12-17 00:04:58 +01:00
Luís Cobucci
122e9c3aa3
Run all code quality tools in the same stage
...
In order to execute things in parallel and speed up the build.
2017-12-16 23:52:20 +01:00
Luís Cobucci
8e4f624f90
Merge pull request #6895 from lcobucci/simplify-LimitSubqueryWalker
...
Reduce complexity of LimitSubqueryWalker#walkSelectStatement()
2017-12-16 23:50:24 +01:00
Luís Cobucci
441c5d138c
Reduce complexity of LimitSubqueryWalker#walkSelectStatement()
...
Ensuring that the code follows our code standards.
2017-12-16 23:31:50 +01:00
Michael Moravec
b3654f95d0
README: Fix PHP version
2017-12-16 22:05:22 +01:00
Michael Moravec
aacea65519
Merge pull request #6889 from carusogabriel/clean-elses
...
Clean elses
2017-12-16 05:30:33 +01:00
Gabriel Caruso
d0d802309c
Clean elses
2017-12-14 05:55:54 -02:00
Michael Moravec
a352c214a0
Merge pull request #6805 from yesdevnull/patch-1
...
[Docs] Corrected NamingStrategy demo code to match example
2017-12-12 04:30:01 +01:00
Dan Barrett
cd00ccae69
Updated table/column names example to be lowercase
2017-12-11 12:14:39 +11:00
Guilherme Blanco
e149f89cfe
Merge pull request #6820 from plfort/#6819-pagination-optim
...
#6819 Optimize LimitSubqueryWalker
2017-12-10 19:56:31 -05:00
Marco Pivetta
b79b26aa8b
Merge pull request #5805 from borNfreee/patch-1
...
Fix typo in documentation
2017-12-08 09:44:35 +01:00
Maks Rafalko
04d9bc40e4
Update validation-of-entities.rst
2017-12-08 09:33:41 +03:00
Michael Moravec
31816f6e2f
Merge pull request #1442 from elazar/patch-1
...
Corrected bad class reference in "Adding own commands"
2017-12-08 05:13:04 +01:00
Michael Moravec
d32a8634aa
Merge pull request #5736 from guilliamxavier/patch-3
...
Fix PHP syntax error in composite-primary-keys.rst
2017-12-08 04:39:56 +01:00
Luís Cobucci
f13f7ebe54
Merge pull request #6862 from OskarStark/typo
...
fixed closing tag
2017-12-03 11:27:52 +01:00
Oskar Stark
79e1be8c3d
fixed closing tag
2017-12-01 15:41:52 +01:00
Luís Cobucci
92dd27fe3f
Merge pull request #6826 from JKapitein/patch-1
...
Add Type::GUID to $typeAlias list in EntityGenerator
2017-11-28 00:38:11 +01:00
JKapitein
ad0a8c53fa
Add Type::GUID to $typeAlias list in EntityGenerator
...
Right now, when generating entities, a column of type 'guid' will generate the following PHPDoc:
```
/**
* Get id
*
* @return guid
*/
public function getId() {...}
```
Since guid is not a valid PHP type, this throws a warning in PHPStorm, and I assume most IDEs.
Adding the type to the type alias list fixes the problem.
2017-11-28 00:11:32 +01:00
Luís Cobucci
be18256a93
Merge pull request #6849 from lcobucci/fix/options-on-entity-generation
...
Make entity generator generate values for all supported options
Fixes: https://github.com/doctrine/doctrine2/issues/6703
2017-11-26 20:55:28 +01:00
Luís Cobucci
bc7aeb9d11
Make entity generator create the correct options
...
The `EntityGenerator` was not creating the field options for all
supported values.
2017-11-26 20:05:52 +01:00
Luís Cobucci
6e095f7c3b
Merge pull request #6801 from foaly-nr1/DDC6029
...
Improve misleading ORMInvalidArgumentException message
Fixes: https://github.com/doctrine/doctrine2/issues/6029
2017-11-26 18:54:01 +01:00
foaly-nr1
c0a505366f
Use the correct type for the exception message
...
Since the UoW checks each item of a *-to-many association to ensure
it has the correct type, we should never say that we expect an instance
of `Doctrine\Common\Collections\Collection` or an `array`.
2017-11-26 17:55:59 +01:00
foaly-nr1
b211dd4db7
Add failing test for misleading exception message
...
Describes: https://github.com/doctrine/doctrine2/issues/6029
2017-11-26 17:55:59 +01:00
Luís Cobucci
3ca65e28fc
Merge pull request #6683 from alextech/bugfix/xml_sequence_params
...
Supply default values for optional values in sequence mapping if omitted by driver.
Fixes: https://github.com/doctrine/doctrine2/issues/6682
2017-11-26 17:07:03 +01:00
Sasha Alex Romanenko
b3331b2237
Enforce sequence XSD requirement
...
Supply default values for allocationSize and initialValue optional parameters.
Related to: https://github.com/doctrine/doctrine2/issues/6682
2017-11-26 16:33:27 +01:00
Luís Cobucci
dfc31bc855
Merge pull request #6740 from mduplouy/DDC288
...
Fix operator when using criteria on ManyToMany
Fixes: https://github.com/doctrine/common/issues/600
2017-11-26 14:21:57 +01:00
Mathieu Duplouy
7c28a932ae
Add operator to walkComparison output
2017-11-26 14:03:54 +01:00
Mathieu Duplouy
15c145f3b3
Add failing test for DCOM-288
...
Reported on: https://github.com/doctrine/common/issues/600
2017-11-26 13:54:54 +01:00
Luís Cobucci
dda42f6c09
Merge pull request #6848 from lcobucci/cache-namespace-fix
...
Fix overwriting explicit cache namespace
Replaces: https://github.com/doctrine/doctrine2/pull/5904
2017-11-26 13:22:24 +01:00
Jan Jakes
99b2e57606
Fix overwriting explicit cache namespace
2017-11-26 12:48:12 +01:00
Luís Cobucci
d3759a2447
Fix incorrect arguments on SetupTest
...
Which was only caught by adding proper type declaration on private
methods.
2017-11-26 12:26:28 +01:00
Luís Cobucci
b7cace86a0
Merge pull request #6705 from Majkl578/ticket/6699
...
Fix parameter name comparison in AbstractQuery regarding different types (fixes #6699 )
Fixes https://github.com/doctrine/doctrine2/issues/6699
2017-11-24 03:00:07 +01:00
Luís Cobucci
b8fd708139
Fix parameter name comparison in QueryBuilder#setParameter() with different types
2017-11-24 02:43:01 +01:00
Michael Moravec
6cb5a9c50a
Fix parameter name comparison in AbstractQuery#setParameter() with different types
2017-11-24 02:43:00 +01:00
Michael Moravec
4bbb1067ac
Add failing test for #6699
2017-11-24 02:42:59 +01:00
Luís Cobucci
b47a39be64
Merge pull request #6655 from OskarStark/symfony-style
...
Use SymfonyStyle for command output
2017-11-24 01:52:00 +01:00
Oskar Stark
6b5eb11458
Use SymfonyStyle for command output
2017-11-24 01:25:17 +01:00
Luís Cobucci
43a88d539d
Format commands' tests
...
To simplify and organise the code (also replacing `$this->assert*`
with `self::assert*`).
2017-11-24 01:25:15 +01:00
Luís Cobucci
8a893068ce
Remove constants existence validation
...
These constants are available since PHP 5.4 and since we're requiring
PHP 7.1 there's no reason to require them.
I've also simplified the `array_map()` call since it's useless to
define a closure that simply calls a function.
2017-11-24 01:25:14 +01:00
Oskar Stark
214dc9896b
Use addOption()/addArgument() to configure commands
...
In order to simplify and standardise the definition of the commands.
2017-11-24 01:20:09 +01:00
Luís Cobucci
ba32237e2b
Merge pull request #6844 from lcobucci/configure-phpcs
...
Configure PHPCS
2017-11-23 13:30:18 +01:00
Luís Cobucci
984327d782
Update PHPStan
2017-11-23 11:29:39 +01:00
Luís Cobucci
2be1b7d0b8
Add configuration for PHPCS
...
And execute it on Travis (allowing it to fail for now to prevent a lot
of conflicts with `develop`).
2017-11-23 11:26:33 +01:00
Luís Cobucci
13197123c5
Sort dependencies definitions
2017-11-23 11:15:52 +01:00
Luís Cobucci
24408b42d3
Merge pull request #6843 from lcobucci/use-new-scrutinizer-config
...
Use new analyser on scrutinizer-ci
2017-11-23 11:08:52 +01:00
Luís Cobucci
8918bd3b8a
Use new analyser on scrutinizer-ci
...
Also preventing from running the tests (because that's already done on
Travis-CI) and simplifying the build failure conditions.
2017-11-23 10:24:18 +01:00
Pierre-Louis FORT
4ab9413675
Test that orderByItem is string
2017-11-10 10:45:57 +01:00
Pierre-Louis FORT
91408a3a54
#6819 Optimize LimitSubqueryWalker when resultVariable are involved and they are not used in "order by"
2017-11-09 14:34:11 +01:00
Dan Barrett
bccc46dc12
Corrected demo code to match example
...
Example paragraph mentions changing column titles to upper case, yet `strtolower` was being used.
2017-11-01 16:40:04 +11:00
Luís Cobucci
a82f6c5725
Merge pull request #6742 from Legenyes/feature/DDC-2938_Support_all_time_intervals_on_DATE_ADD
...
Add support second, minute, week, year on DATE_ADD and DATE_SUB
Fixes #5835
2017-10-31 20:46:02 +01:00
Luís Cobucci
59792654c0
Improve tests for DATE_ADD and DATE_SUB
...
So that we can do proper assertions and cover all the possibilities
of the functions.
2017-10-31 15:48:26 +01:00
Sébastien Lévêque
f277eef6ea
Add support second, minute, week, year on DATE_ADD and DATE_SUB
2017-10-29 21:48:40 +01:00
Andreas
ed86ee2567
Merge pull request #6800 from ErikJson/master
...
Fix some grammar and outdated information in docs
2017-10-29 05:53:58 +01:00
Erik Johansson
302c3a6640
Fix some grammar and outdated information in docs
2017-10-29 00:28:10 +03:00
Luís Cobucci
0497f50ba6
Merge pull request #6766 from ThomasLandauer/patch-1
...
Moved explanation out of PHP-Codeblock...
2017-10-26 09:49:48 +02:00
Marco Pivetta
2129801ac1
Merge pull request #6788 from kejwmen/fix/custom-types-docs
...
[Docs] Type::convertToDatabaseValue is always called
2017-10-24 08:46:02 +02:00
Mateusz Sip
620319f206
Type::convertToDatabaseValue is always called
2017-10-24 01:50:58 +02:00
Marco Pivetta
5f3afa4c4f
Merge pull request #6778 from stevepetcu/clarify-embedded-embeddable-docs
...
Clarify docs for embedded and embeddable.
2017-10-19 12:40:50 +02:00
Aaron Scherer
99db207a9f
getRepository actually returns ObjectRepository
2017-10-18 19:10:00 -07:00
Stefan Petcu
0bea6881da
Clarify docs for embedded and embeddable.
2017-10-17 19:21:34 +02:00
Guilherme Blanco
e279dfaa91
Merge pull request #6772 from greg0ire/disallow_many_to_one_orphan_removal
...
Disallow orphan removal attribute on many-to-one
2017-10-16 07:47:26 -04:00
Guilherme Blanco
87a6d0b77e
Merge pull request #6774 from greg0ire/proove_orphan_removal_is_useless
...
Proove orphan removal is useless
2017-10-15 22:12:31 -04:00
Grégoire Paris
ffd3d34f34
Disable uuid generation
...
Apparently, setting a value by hand is not enough to avoid it.
2017-10-14 12:39:58 +02:00
Grégoire Paris
57e9feffb2
Avoid uuid generation
...
pg needs an extra module to do this, so let's spare us that and set them
manually.
2017-10-14 12:39:58 +02:00
Grégoire Paris
6b5c97055c
Set null on delete, at database level
2017-10-14 12:39:57 +02:00
Grégoire Paris
30fccf8e83
Proove orphan-removal on many-to-one is useless
2017-10-14 12:39:57 +02:00
Grégoire Paris
2a865177b9
Disallow orphan removal attribute on many-to-one
...
It only makes sense for collections, and there is no collection here.
Plus the docs do not say it is supported.
See
http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/reference/working-with-associations.html#orphan-removal
2017-10-13 16:38:02 +02:00
Thomas Landauer
d560449661
Minor formating
2017-10-11 22:50:32 +02:00
Thomas Landauer
436b15e873
Moved explanation out of PHP-Codeblock...
...
...to make it visible for XML and YML too.
2017-10-11 22:45:42 +02:00
Marco Pivetta
aea970722e
Merge pull request #6764 from AlessandroMinoccheri/fix_doc
...
fixed little typo inside documentation
2017-10-11 20:44:16 +02:00
Alessandro Minoccheri
b1466e6d3e
fixed little typo inside documentation
2017-10-11 17:04:29 +02:00
Luís Cobucci
8e16748ff8
Merge pull request #6734 from ossinkine/issue-6734
...
Add DateInterval type parameter
2017-10-11 13:13:09 +02:00
Luís Cobucci
9e9e5628f5
Merge pull request #6755 from BenMorel/patch-2
...
EntityManager::getReference() can return null
2017-10-09 20:05:46 +02:00
Luís Cobucci
f2dc9a8f92
Merge pull request #6760 from doctrine/fix/#6759-showstopper-one-to-one-inverse-not-being-loaded-with-correct-identifier-restrictions
...
#6759 showstopper one-to-one inverse not being loaded with correct identifier restrictions when defining `joinColumn`
2017-10-08 14:47:15 +02:00
Marco Pivetta
66f903a38f
#6759 remove # symbol from @group annotation as per @lcobucci's review
...
Ref: https://github.com/doctrine/doctrine2/pull/6760#discussion_r143353225
2017-10-08 14:26:45 +02:00
Marco Pivetta
3dd7eb5888
#6759 removing outdated comment as per @alcaeus' review
...
Ref: https://github.com/doctrine/doctrine2/pull/6760#discussion_r143347881
2017-10-08 10:57:33 +02:00
Marco Pivetta
dd12ba88ee
#6759 avoiding reuse of the $identifier variable when constructing an identifier from the owning side value
...
Fixes #6759
2017-10-07 12:54:36 +02:00
Marco Pivetta
83e00d5010
#6759 cleaning up test case, using new models from the isolated namespace
2017-10-07 12:52:34 +02:00
Marco Pivetta
d831f4fd9f
#6759 segregating test models into their own namespace
2017-10-07 12:48:19 +02:00
Marco Pivetta
6ba2d1c317
#6759 cleaning up test case body
2017-10-07 10:09:44 +02:00
Jan Langer
5f99cad669
Failing test - inverse side OneToOne loaded without identifier condition
2017-10-06 17:34:34 +02:00
Benjamin Morel
fb7a96caf9
EntityManager::getReference() can return null
2017-10-05 00:27:11 +02:00
Jonathan H. Wage
13f838f8be
Merge pull request #6749 from KonstantinKuklin/patch2
...
sync type of property em with constructor value
2017-10-04 08:47:55 -04:00
Konstantin Kuklin
2d88e45240
sync type of property em with constructor value
2017-10-04 03:43:20 +03:00
Marco Pivetta
2ade863bca
Merge pull request #6746 from doctrine/malarzm-patch-1
...
[DOCS] Emphasize that Embeddable can only contain simple fields
2017-10-03 17:42:31 +02:00
Maciej Malarz
19dcd629c0
[DOCS] Emphasize that Embeddable can only contains simple fields
2017-10-03 17:14:06 +02:00
Gocha Ossinkine
4fdbdabae4
Add DateInterval type parameter
2017-09-28 13:15:40 +05:00
Marco Pivetta
53245e8a73
Merge pull request #6731 from guiajlopes/master
...
#6723 Remove variable from UnitOfWork#createEntity()
2017-09-26 13:10:39 +02:00
Guilherme Lopes
a7e13f89cc
#6723 Remove variable from UnitOfWork#createEntity()
2017-09-26 12:52:18 +02:00
Marco Pivetta
1d5c87ee4b
Merge pull request #6714 from guiajlopes/master
...
Remove unnecessary else
2017-09-21 14:30:25 +02:00
Marco Pivetta
f96dc3ba91
Merge pull request #6715 from PowerKiKi/patch-3
...
Promote nullable types from PHP 7.1
2017-09-21 14:29:23 +02:00
Adrien Crivelli
3d3ecc77bd
Drop PHP version specifics
2017-09-21 21:28:19 +09:00
Guilherme Lopes
df1250ee4b
Fix negation clause and also adding both conditions in the same if
2017-09-21 13:42:51 +02:00
Adrien Crivelli
d995203ee1
Promote nullable types from PHP 7.1
...
Also don't show type hinting in a bad light with sentences such as "If you insist on type-hinting"
2017-09-21 17:29:54 +09:00
Guilherme Lopes
8ecddc4fc1
Adding empty line between logic blocks
2017-09-21 10:13:19 +02:00
Guilherme Lopes
059cfd86df
Remove unnecessary else
2017-09-21 10:02:43 +02:00
Benjamin Eberlei
0c4f9a8866
Clarify some assumptions the object hydration makes.
2017-09-16 17:15:08 +02:00
Marco Pivetta
6a86175617
Merge pull request #6695 from wshafer/prefix-update
...
Update table prefix docs
2017-09-11 20:58:11 +02:00
Marco Pivetta
bf8e27b422
Merge pull request #6690 from bitwombat/issue_6686
...
Clarify association mapping language
2017-09-11 08:51:50 +02:00
Marco Pivetta
80f7824b3d
Merge pull request #6691 from keradus/php_syntax
...
Use newer PHP syntax
2017-09-11 08:50:05 +02:00
Westin Shafer
828bfdf4ae
Update docs for deprecated setTableName()
...
Updated docs to remove deprecated setTableName() and replace it with setPrimaryTable()
2017-09-07 13:59:32 -06:00
Dariusz Ruminski
c7d6d62393
Use newer PHP syntax
2017-09-06 01:32:49 +02:00
Greg Bell
c429f1c38b
Clarify association mapping language
...
- 5.3 was wrong - should really be 'inversedBy'
- 11.1 - change 'use' to 'have' for consistency. A class has an attribute.
- See https://github.com/doctrine/doctrine2/issues/6686
2017-09-06 07:58:34 +10:00
Marco Pivetta
8b81691e77
Merge pull request #6685 from votemike/update-maxresult-docblocks
...
Updating `Query#$_maxResults` to allow for `null` (no limit)
2017-09-04 11:40:06 +02:00
Michael Gwynne
d0d1e557d1
Adding change to appease scrutinizer
2017-09-04 10:11:43 +01:00
Michael Gwynne
fd9f96c766
Updating _maxResults to allow for null
2017-09-04 09:26:11 +01:00
Marco Pivetta
4bc29d1049
Merge branch 'fix/#5796-catch-also-throwable-in-transactional-abstraction'
...
Close #5796
2017-09-02 13:58:08 +02:00
Marco Pivetta
c016e2d434
Adding minimal test to verify EntityManager behavior against #5796
2017-09-02 13:55:07 +02:00
Marco Pivetta
12043cd845
#5796 minor CS fixes (imported symbols) and removing last PHP5 compliance bits
2017-09-02 13:47:58 +02:00
Marco Pivetta
a1c93bfd48
#5796 replacing Exception catching with Throwable catching, removing PHP5 compliance code
2017-09-02 13:44:12 +02:00
Benjamin Morel
874a5e3547
Catch Throwable in PHP 7
2017-09-02 13:41:53 +02:00
Marco Pivetta
68706034e5
Merge pull request #6658 from Majkl578/fix/allow-stable-yaml
...
Drop explicit conflict with stable symfony/yaml
2017-08-30 22:43:28 +02:00
Michael Moravec
bfc76adce0
Drop explicit conflict with stable symfony/yaml
...
As per discussion in #6639 , conflict with versions below 3.4
of the YAML component is superfluous, previous versions
would work just fine even with bb994b9e70 .
2017-08-30 22:06:19 +02:00
Marco Pivetta
8c7052c99c
Merge pull request #6652 from doctrine/fix/allow-batch-insert-test-to-run-in-multiple-revolutions
...
Correcting the `SimpleInsertPerformanceBench` duplicate record issues when run with multiple revolutions/iterations
2017-08-26 16:42:51 +02:00
Marco Pivetta
e1e7485e58
Correcting the SimpleInsertPerformanceBench, which was running into duplicate record integrity constraint violations when run with >1 revs
2017-08-26 16:41:03 +02:00
Marco Pivetta
7a0385634f
Merge pull request #6651 from doctrine/fix/use-quote-model-set-when-available
...
Replacing direct `quote` model-set schema creation with actually existing model-set setup
2017-08-26 14:23:26 +02:00
Marco Pivetta
922c55f5dd
Replacing direct quote model-set schema creation with actually existing model-set setup
2017-08-26 14:15:05 +02:00
Marco Pivetta
61404e2d6d
Merge pull request #6640 from doctrine/fix/#6284-#6217-avoid-passing-l2-cache-information-internals-to-the-uow
...
#6217 #6284 when hydrating an entity with a composite primary key that is both an `EAGER` and a `LAZY` association and also cached, the `DefaultQueryCache` tries to pass L2 cache implementation detail objects to the `UnitOfWork`
2017-08-25 09:22:45 +02:00
Marco Pivetta
660f164568
#6284 #6217 s/$this->assert/self::assert as per @lcobucci's review
2017-08-25 09:21:12 +02:00
Marco Pivetta
acfc890dbd
Merge pull request #6644 from AlessandroMinoccheri/fix_documentation_typo
...
fixed typo into native-sql documentation
2017-08-24 11:29:17 +02:00
Alessandro Minoccheri
a708d4076e
fixed typo into native-sql documentation
2017-08-24 11:27:54 +02:00
Marco Pivetta
aac0204611
Merge pull request #6642 from radmax/patch-1
...
Fixed typo in DQL docs
2017-08-24 10:57:11 +02:00
radmax
ed047520c3
fixed typo
2017-08-24 10:55:29 +02:00
Marco Pivetta
caa008b61d
#6284 #6217 removing hacks around the ClassMetadata details - invalid fix that was actually fixing the symptom
2017-08-23 00:25:29 +02:00
Marco Pivetta
07b397f341
#6284 fixing actual issue, which comes from an extremely tricky L2 caching issue.
...
We are not hydrating some of the cached association data into entities due to keys missing in the cache association definition.
Since this is an extreme edge case that is just a mismatch between db and cache, a detailed explanation was provided in the fix snippet as well
2017-08-23 00:19:49 +02:00
Marco Pivetta
c9d1f852de
#6284 removing unused lazy entity
2017-08-22 21:41:04 +02:00
Marco Pivetta
c29a1e96b7
#6284 removing unused separate class
2017-08-22 21:40:42 +02:00
Marco Pivetta
a2f4053a81
#6284 renaming variables, classes and properties to fit tested behavior
2017-08-22 21:38:44 +02:00
Marco Pivetta
3f09e20955
#6284 correcting alignment, removing stuff that isn't strictly needed
2017-08-22 21:31:01 +02:00
Marco Pivetta
220dc79ebf
#6284 renaming entities to match the scope of this test
2017-08-22 21:29:27 +02:00
Marco Pivetta
6f6e88cfb6
#6284 adding assertions about equality of the loaded classes
2017-08-22 21:27:46 +02:00
Marco Pivetta
dac1ce4172
#6284 removing profile entity, since it is not needed to reproduce the issue
2017-08-22 21:21:53 +02:00
Marco Pivetta
ca39abcd71
#6284 reducing annotation mapping clutter
2017-08-22 21:17:14 +02:00
Marco Pivetta
4e0b76ce69
#6284 eager fetching is strictly required to verify the issue
2017-08-22 21:14:38 +02:00
Marco Pivetta
805ba041ef
#6284 reducing annotation mapping clutter
2017-08-22 21:12:45 +02:00
Marco Pivetta
3842ad8ea1
#6284 simplifying tests to a minimum, removing unused auto-generated id field
2017-08-22 21:11:03 +02:00
Marco Pivetta
c7281f6ade
#6284 simplifying tests to a minimum, removing unused auto-generated id field
2017-08-22 21:08:06 +02:00
Marco Pivetta
a8453dda89
#6284 removing the "WTF" part of the logic - an association cache entry should never ever reach metadata
2017-08-22 21:03:14 +02:00
Waleed Gadelkareem
309b286ed3
Add tests for #6217
2017-08-22 19:45:26 +02:00
Marco Pivetta
8ad3dfd3bd
Merge branch 'fix/#1521-DDC-2922-defer-checking-non-persisted-entities-through-multiple-differently-mapped-cascading-associations'
...
Close #1521
Close DDC-2922
2017-08-22 10:26:15 +02:00
Marco Pivetta
645cccf2db
#1521 DDC-2922 adapting test so the UnitOfWork stops bragging about previous inconsistent states
2017-08-22 10:24:46 +02:00
Marco Pivetta
2be32f249c
#1521 DDC-2922 adapting UoW and exception implementation to the new specification
2017-08-22 09:57:57 +02:00
Marco Pivetta
4a007c76f5
#1521 DDC-2922 spec for a new exception endpoint that produces a multi-new-non-cascaded-entities error message
2017-08-22 09:56:43 +02:00
Marco Pivetta
a754eae0f0
#1521 DDC-2922 verifying that persistence operations will resume normally after a crash due to invalid new values detected on associations - tweaked test to make it fail
2017-08-22 08:51:27 +02:00
Marco Pivetta
89fbb6a060
#1521 DDC-2922 verifying that persistence operations will resume normally after a crash due to invalid new values detected on associations
2017-08-22 08:49:42 +02:00
Marco Pivetta
2751c0fff2
#1521 DDC-2922 minor code cleanup - renaming internal private methods, variables, removing redundant if/else
2017-08-21 20:08:20 +02:00
Marco Pivetta
87e8bccb11
#1521 DDC-2922 removed redundant integration test that was replaced by a unit test
2017-08-21 19:58:52 +02:00
Marco Pivetta
f39614136f
#1521 DDC-2922 reproducing test scenarios within the UnitOfWorkTest
2017-08-21 19:58:16 +02:00
Marco Pivetta
a3208f8d08
#1521 DDC-2922 removed unrelated model usage from test - using minimal models only
2017-08-21 19:47:16 +02:00
Marco Pivetta
e21b29c264
#1521 DDC-2922 simplified test case to a minimum reproducible unit
2017-08-21 19:44:38 +02:00
Darien Hager
b456cffa2d
Move final cascade-persist-checking so that it covers not just normal flushes, but also flushes where specific entities are singled out.
2017-08-21 09:08:31 +02:00
Darien Hager
17b996da8c
Speculative fix: Defer any errors for missing cascade-persist until object graph has been better-explored
2017-08-21 09:08:31 +02:00
Darien Hager
92dc39bfb9
Add extra assertions to test to ensure that flush actually succeeded in saving all items
2017-08-21 09:08:31 +02:00
Darien Hager
997000352a
Add another test to demonstrate the bug doesn't appear if everything is flushed at once.
2017-08-21 09:08:31 +02:00
Darien Hager
6f8a80be79
Move failing unit test into ticket-specific case
2017-08-21 09:08:31 +02:00
Darien Hager
c4465abaa0
Initial failing test-case to demonstrate cascade-persist problem.
2017-08-21 09:08:12 +02:00
Marco Pivetta
ddccd42bb1
Merge pull request #6636 from Kwadz/annot-ref-update
...
Mention the nullable default value for @column
2017-08-20 08:17:41 +02:00
Richard
9eaf23a5e0
Mention the nullable default value for @column
...
Related to #6632
2017-08-20 05:57:00 +02:00
Marco Pivetta
a30d8d85ea
Merge branch 'fix/#6303-#6304-check-for-null-discriminator-before-hydrating-inheritance-rows'
...
Close #6303
Close #6304
ge aborts
2017-08-19 18:37:04 +02:00
Marco Pivetta
44f2e22f14
#6303 #6304 documenting why collisions in field name hydration in STI/JTI require additional information and checks in the hydration process
2017-08-19 18:30:33 +02:00
Marco Pivetta
4cbcdb761a
#6303 #6304 documenting that the discriminator map order is extremely important for this test
2017-08-19 18:25:44 +02:00
Marco Pivetta
b66643d52e
#6303 #6304 removing useless union type usage
2017-08-19 17:49:14 +02:00
Marco Pivetta
42d9162bd5
#6303 #6304 re-enabling disabled test code data
2017-08-19 17:47:12 +02:00
Marco Pivetta
8af68614fc
#6303 #6304 correcting type mapping. For simple_array, [] == null (which is bullshit), so we use array here
2017-08-19 17:45:26 +02:00
Marco Pivetta
764ab59882
#6303 #6304 making unnecessary visible fields private
2017-08-19 17:06:27 +02:00
Marco Pivetta
468496be1a
#6303 #6304 using strict types in the tests
2017-08-19 17:05:44 +02:00
Marco Pivetta
e18fb6607d
#6303 #6304 removing duplicate test details
2017-08-19 17:04:26 +02:00
Marco Pivetta
2ab363ab82
#6303 #6304 adding void hints where applicable
2017-08-19 16:53:41 +02:00
Marco Pivetta
0882b10213
#6303 #6304 simplified tests, removing references to contract naming
2017-08-19 16:51:31 +02:00
Marco Pivetta
328467c226
#6303 #6304 simplified tests, removing references to contract naming
2017-08-19 16:48:50 +02:00
Marco Pivetta
f6ce69fe29
#6303 #6304 minor CS fixes in the test code - alignment/formatting
2017-08-19 16:37:24 +02:00
Marco Pivetta
aaad25a061
#6303 #6304 reverting changes to the OrmFunctionalTestCase
2017-08-19 16:25:20 +02:00
Marco Pivetta
c503b81421
#6303 #6304 removing += operator usage on arrays (scary\!), CS (alignment)
2017-08-19 16:02:30 +02:00
Marco Pivetta
7e7921e32f
#6303 #6304 documenting why the loose comparison is required
2017-08-19 15:58:50 +02:00
fullbl
8cc29e84a0
Update AbstractHydrator.php
...
revert strict comparison in hydration (fails on some dates)
2017-08-19 15:56:59 +02:00
Full
db9c12f1af
comparison on discriminator value with !==
2017-08-19 15:56:59 +02:00
fullbl
82db643b4f
clarified what's the problem in a comment
2017-08-19 15:56:59 +02:00
Full
4c7286f57b
removed trailing spaces
2017-08-19 15:56:59 +02:00
Full
0072054020
moved all test models into test class
2017-08-19 15:56:59 +02:00
Full
0b8e468f06
fix wrong pharenthesis
2017-08-19 15:56:59 +02:00
Full
bf06b7dbbc
check if array is set before assigning
2017-08-19 15:56:59 +02:00
Full
ad3b9de4b8
use dataMap also in first test function
2017-08-19 15:56:59 +02:00
Full
6d40859228
added tests on empty values
2017-08-19 15:56:59 +02:00
Full
aac523d155
tests with custom inheritance tree
2017-08-19 15:56:59 +02:00
Marco Pivetta
671fd50725
Merge pull request #6572 from bitwombat/doc_changes
...
Add additional detail and clarifications on SELECT
2017-08-18 21:45:17 +02:00
Marco Pivetta
1a0bb82e1d
Merge pull request #6392 from Jean85/pr_1441_rebased
...
Correct DQL `INSTANCE OF` to filter all possible child classes
2017-08-18 21:35:54 +02:00
Marco Pivetta
a426808a16
Merge branch 'fix/#6633-#3788-avoid-xml-external-entity-loading-errors-in-xml-mapping-driver'
...
Close #6633
Close #3788
2017-08-18 21:12:37 +02:00
Marco Pivetta
492fb50744
#6633 #3788 documenting why simplexml_load_file() was not used
2017-08-18 21:08:14 +02:00
Alessandro Lai
c799c6da8b
Add new functional test to check usage of INSTANCEOF with multiple parameters
2017-08-18 14:49:56 +02:00
Aljosha Papsch
eb762dea23
XmlDriver: Avoid PHP bug #62577 by avoiding simplexml_load_file.
...
Doctrine is affected by PHP bug #62577 . simplexml_load_file is not
able to load files if libxml_disable_entity_loader(true) has been
called. simplexml_load_file fails with the message:
I/O warning : failed to load external entity "/my/mappings/my_entity.dcm.xml"
in /path-to/lib/Doctrine/ORM/Mapping/Driver/XmlDriver.php on line 711
This error occurs even if there are no external entities in the XML file.
Waiting for the PHP bug to be resolved is infeasible, because it is
unresolved since years. Therefore Doctrine needs to circumvent the bug
by replacing simplexml_load_file with simplexml_load_string while getting
the file contents itself. simplexml_load_string is not affected by the
PHP bug.
2017-08-18 14:23:43 +02:00
Alessandro Lai
19bc4991ae
Add more CS fixes
2017-08-18 12:35:51 +02:00
Alessandro Lai
9864a5a9b9
Add unit test for HierarchyDiscriminatorResolverTest
2017-08-18 12:11:09 +02:00
Alessandro Lai
5224a89549
Apply various and CS fixes as per review
2017-08-18 11:02:28 +02:00
Alessandro Lai
d4db126bb0
Remove code duplication of the getAllDiscriminators method
2017-08-18 10:17:52 +02:00
Marco Pivetta
60e29b40a0
Merge branch 'fix/#5579-fix-performance-of-single-entity-flush-with-notify-tracking-policy'
...
Close #5579
2017-08-18 09:30:43 +02:00
Marco Pivetta
496c22db0e
#5579 completely removing a changeset when cleaning up
2017-08-18 09:27:47 +02:00
Marco Pivetta
1bf8465f43
#5579 correcting assertion static/instance method usage
2017-08-18 09:25:47 +02:00
Marco Pivetta
ff15a2bc79
#5579 correcting visibility of clearEntityChangeSet, which should be reverted to public
2017-08-18 09:23:28 +02:00
Marco Pivetta
9d7be0f927
#5579 s/clear/cleanup
2017-08-18 09:22:23 +02:00
Marco Pivetta
2921f068b7
#5579 cleaning up postCommitClear implementation
2017-08-18 09:21:53 +02:00
Marco Pivetta
9707701d10
#5579 isolating multi-entity-commit and single-entity-commit scenarios for the tracking policy changeset clearing
2017-08-18 09:15:48 +02:00
Marco Pivetta
df1577db0c
#5579 cleaning up test case, adding assertions critical to the understanding of the code
2017-08-18 09:13:56 +02:00
xhuberty
866a424963
Fix issue when using notify tracking policy with multiple flush on entity
2017-08-18 09:07:40 +02:00
Greg Bell
74c83f3cec
Fix format and content as-per discussion in PR
2017-08-18 15:20:17 +10:00
Marco Pivetta
5770459bfc
#6441 moving expected exception annotations into explicit method calls
2017-08-18 04:44:17 +02:00
Marco Pivetta
94640aca88
Merge pull request #6441 from sensorario/remove-loosely-comparison
...
Verify that the `fileLockRegionDirectory` passed to the `DefaultCacheFactory` cannot be empty
2017-08-18 04:38:20 +02:00
Marco Pivetta
fda770700a
Merge pull request #6579 from Nek-/patch-1
...
Add string type as possible parameter for between
2017-08-18 04:33:04 +02:00
Marco Pivetta
da109c36b7
Merge pull request #6630 from doctrine/fix/remove-reliance-on-yaml-deprecated-constants
...
Remove reliance on Symfony\Component\Yaml deprecated constants
2017-08-16 20:52:18 +02:00
Marco Pivetta
40515472c1
Bumping ORM YAML dependency to 3.4+, explicitly forbidding compatibility with older YAML component versions
2017-08-16 20:21:26 +02:00
Marco Pivetta
bb994b9e70
Removing reference to deprecated YAML component constant that is ignored after symfony 3.4
2017-08-16 20:20:22 +02:00
Marco Pivetta
76e2155fb3
Merge branch 'feature/#6593-#5864-export-metadata-should-contain-entity-listeners'
...
Close #6593
Close #5864
ge aborts
2017-08-16 19:58:23 +02:00
Marco Pivetta
894490c2a0
#6593 #5864 removing incorrect null return value in API marked as string
2017-08-16 19:57:26 +02:00
Marco Pivetta
e1acba3ae4
#6593 #5864 reverted all public/protected API parameter and return type changes
...
That's still to be considered a BC break, since child classes are broken if incompatible.
Sorry @tPl0ch :-(
2017-08-16 19:53:32 +02:00
Marco Pivetta
9005c5afdd
Merge branch 'fix/#6626-skip-proxy-generation-for-embeddable-classes'
...
Close #6626
Close #6625
2017-08-16 15:23:46 +02:00
Marco Pivetta
71218b66b9
#6626 #6625 minor CS fixes (removed useless assignments)
2017-08-16 15:23:20 +02:00
Issei.M
0bc91f8733
Replace double quote with single quote
2017-08-16 15:23:20 +02:00
Issei.M
de6d932e8c
Fix CS / Add annotation
2017-08-16 15:23:20 +02:00
Issei.M
9e837dc53c
Skip embeddable classes proxy generation
2017-08-16 15:23:20 +02:00
Marco Pivetta
57a9509dec
Merge branch 'fix/#6623-#1515-ensure-abstracthydrator-hydrateall-cleans-up-on-unit-of-work-clear'
...
Close #6623
2017-08-16 15:10:38 +02:00
Marco Pivetta
ff3c89d8b1
#6623 minor code cleanups (removing useless assignments, array callback syntax)
2017-08-16 15:10:27 +02:00
Marco Pivetta
7024926f10
#6623 splitting test scenario into two bits
2017-08-16 15:07:48 +02:00
Thomas Ploch
e4006e533c
[FX] Use single quotes for XML root in XmlExporter
2017-08-16 12:26:33 +02:00
Thomas Ploch
b1e091b0e1
[FX] Looking up PHP internal functions from the root namespace is faster
2017-08-16 12:25:31 +02:00
Thomas Ploch
599865528e
[CS] Remove obsolete doc blocks #2
2017-08-16 12:24:37 +02:00
Thomas Ploch
fe88422e68
[CS] Remove obsolete doc blocks
2017-08-16 12:24:00 +02:00
Thomas Ploch
741819f060
Revert "Minor coding style fixes and more docblock removal"
...
This reverts commit ec3eed68ca .
2017-08-15 10:28:43 +02:00
Thomas Ploch
ec3eed68ca
Minor coding style fixes and more docblock removal
2017-08-15 10:17:20 +02:00
Thomas Ploch
b7ae5b4afb
Entity listeners are now processed by exporters
...
The current implementation of the exporters are not taking the entity
listeners into account. I have added test cases for most of the edge
cases I could think of and implemented the Exporter handling.
This PR originates from https://github.com/doctrine/doctrine2/pull/5864 ,
I was overwhelmed by the amount of conflicts I had to resolve so I
started anew on a clean master HEAD.
Squashed commits:
- Code review aftermath
- Add even more return type declarations
- Added `return null` to methods declared with nullable return types
- Removed unneeded docblocks when types are self-explanatory
2017-08-15 10:08:50 +02:00
Nikolas Tsiongas
f0ed4e87b5
fix AbstractHydrator addEventListener on hydrateAll()
...
# Conflicts:
# tests/Doctrine/Tests/ORM/Functional/Ticket/DDC3146Test.php
2017-08-14 00:45:50 +02:00
Marco Pivetta
a0c0d3bf2a
Revert "Merge branch 'fix/#6499-#6533-fix-commit-order-calculation-consider-all-join-column-fields'"
...
This reverts commit 2a58645cb5 , reversing
changes made to 6d428c90e2 .
2017-08-11 22:29:45 +02:00
Marco Pivetta
2a58645cb5
Merge branch 'fix/#6499-#6533-fix-commit-order-calculation-consider-all-join-column-fields'
...
Close #6499
Close #6533
2017-08-11 22:17:02 +02:00
Marco Pivetta
1ede3c514f
#6499 #6533 simplifying nullable column check - null coalesce operator makes it *SOMEWHAT* more readable (no miracles)
2017-08-11 22:13:20 +02:00
Marco Pivetta
166c5816b6
#6499 #6533 calibrating test so that the association is populated after persistence in some edge cases
2017-08-11 22:10:02 +02:00
Marco Pivetta
25829ea450
#6499 #6533 simplifying test scenario to the bone, adding description of what happened at persistence-level
2017-08-11 22:05:00 +02:00
Marco Pivetta
ebd521c56e
#6499 #6533 minor CS fixes in the test
2017-08-11 21:55:02 +02:00
Marco Pivetta
b352cd3e22
#6499 #6533 minor CS fixes in the test
2017-08-11 21:54:30 +02:00
Gabe van der Weijde
da3cd04993
-- Transformed into a minimal example.
...
-- Processed Ocramius' feedback.
2017-08-11 21:51:17 +02:00
Gabe van der Weijde
db2530d6fd
-- Proposed fix due to logic error.
2017-08-11 21:51:17 +02:00
Gabe van der Weijde
16a14f2238
-- Created test for validation issue #6499 .
2017-08-11 21:51:17 +02:00
Marco Pivetta
6d428c90e2
Merge branch 'fix/#6464-#6475-correct-SQL-generated-with-JTI-and-WITH-condition'
...
Close #6464
Close #6475
2017-08-11 21:45:34 +02:00
Marco Pivetta
9ad91ddc1c
#6464 #6475 using PHP 7.1 void and string return hints where available
2017-08-11 21:45:23 +02:00
Marco Pivetta
91a5091612
#6464 #6475 cleaning up test - removed invalid fetch join, CS
2017-08-11 21:39:13 +02:00
Stefan Siegl
025ed1147b
#6464 code review updates
2017-08-11 21:36:33 +02:00
Stefan Siegl
99fdbf550d
generate nested join sql for CTIs, closes #6464
2017-08-11 21:36:33 +02:00
Stefan Siegl
55882ca7a6
#6464 add test
2017-08-11 21:36:33 +02:00
Marco Pivetta
633c8461c8
Merge branch 'fix/#6614-clean-modified-collection-causing-double-dirty-object-persistence'
...
Close #6613
Close #6614
Close #6616
2017-08-11 21:29:16 +02:00
Marco Pivetta
352b3ba6f6
#6613 #6614 #6616 adding void return type to newly introduced test methods
2017-08-11 21:28:18 +02:00
Marco Pivetta
c2dd274c42
#6613 #6614 #6616 adding void return type
2017-08-11 21:27:09 +02:00
Marco Pivetta
004ac51869
#6613 #6614 #6616 minor performance optimisations around the new restoreNewObjectsInDirtyCollection implementation
2017-08-11 21:14:05 +02:00
Marco Pivetta
3579997531
#6613 #6614 #6616 removing DDC6613 test, which was fully ported to unit tests
2017-08-11 21:11:31 +02:00
Marco Pivetta
a2ca6bbfaf
#6613 #6614 #6616 ensuring that the collection is marked as non-dirty if all new items are contained in the initialized ones
2017-08-11 21:09:34 +02:00
Andreas Braun
1174ec6e8a
Add failing test for dirty flag
2017-08-11 20:39:03 +02:00
Marco Pivetta
b064fe3d86
#6613 #6614 #6616 removing repeated PersistentCollectionTest chunks of code
2017-08-11 19:08:24 +02:00
Marco Pivetta
93c4064679
#6613 #6614 #6616 initializing a dirty collection that has new items that are also coming from initialization data de-duplicates new and persisted items
2017-08-11 19:02:39 +02:00
Marco Pivetta
04a5b122b0
#6613 #6614 #6616 moved integration test basics to a unit test that verifies basic dirty collection initialization semantics
2017-08-11 18:58:05 +02:00
Marco Pivetta
345cf1acf8
#6613 #6614 correcting broken test that isn't using objects against a PersistentCollection
2017-08-11 15:15:57 +02:00
Marco Pivetta
031e79e726
#6613 #6614 correcting broken test that isn't using objects against a PersistentCollection
2017-08-11 15:14:42 +02:00
Marco Pivetta
d44e6e1a9e
#6613 #6614 ensuring that only newly added items that weren't loaded are restored in the dirty state of the collection
2017-08-11 15:13:39 +02:00
Marco Pivetta
1fc7f81741
#6613 #6614 after initialization, the collection should be dirty anyway
2017-08-11 14:47:51 +02:00
Marco Pivetta
5e2257db04
#6613 #6614 adding assertions about collection initialization and dirty status
2017-08-11 14:46:11 +02:00
Marco Pivetta
d2c9b22397
#6613 #6614 removing IDE-generated header
2017-08-11 14:44:28 +02:00
Marco Pivetta
8c4b5a4b71
#6613 #6614 removing phone/user specifics, using ORM naming for associations
2017-08-11 14:44:04 +02:00
Marco Pivetta
80f12ed490
#6613 #6614 correcting column mapping (was integer, should be string), segregating phone creation away
2017-08-11 14:41:32 +02:00
Marco Pivetta
a4e547b691
#6613 #6614 remove superfluous mappings
2017-08-11 14:34:35 +02:00
Marco Pivetta
eca1d6b3ea
#6613 #6614 rewrote test logic to be less magic-constant-dependent
2017-08-11 14:27:34 +02:00
Marco Pivetta
c195064ba4
#6613 #6614 CS - applying @group annotation to the test
2017-08-11 14:23:21 +02:00
Marco Pivetta
625f792290
#6613 #6614 removing dedicated DDC6613 model directory
2017-08-11 14:22:31 +02:00
Marco Pivetta
112a402016
#6613 #6614 smashing entity definitions into the test
2017-08-11 14:21:56 +02:00
Marco Pivetta
0a1a84163e
#6613 #6614 better test specification - removing useless assertions
2017-08-11 14:20:07 +02:00
Marco Pivetta
594e60d3f7
#6613 #6614 simplifying entity definition - using auto-assigned string identifiers to reduce moving parts
2017-08-11 14:19:01 +02:00
Uladzimir Struts
874d60d8c7
It added the unit test #6613
2017-08-11 13:46:21 +03:00
Marco Pivetta
bbe005837e
Merge pull request #6607 from lcobucci/be-strict-with-risky-tests
...
Be strict with risky tests
2017-08-06 14:40:16 +02:00
Luís Cobucci
b960170fe1
Move test to the right place and add assertions
...
That test was removed from "performance" group but we forgot to move it
to the correct namespace.
It was also not doing any assertion, which is quite bad.
More info:
- https://github.com/doctrine/doctrine2/issues/3333
2017-08-06 12:51:58 +02:00
Luís Cobucci
27300bf4af
Make PHPUnit strict about risky tests
2017-08-06 12:51:16 +02:00
Luís Cobucci
aa13e49fdf
Merge pull request #6606 from lcobucci/add-exception-msg
...
Add message to NonUniqueResultException
2017-08-06 12:28:58 +02:00
Jean Carlo Machado
c2167664fc
add test of NonUniqueResultException message presence
2017-08-06 12:08:57 +02:00
Alfredo Costa
8952176c73
Add message to NonUniqueResultException
2017-08-06 12:07:47 +02:00
Marco Pivetta
2b8acb9907
Merge pull request #6601 from martin-georgiev/master
...
Fix double spacing in "cascade persist missing" exception message
2017-08-03 21:36:58 +02:00
Martin Georgiev
30088fe529
Fix double spacing in exception's message
2017-08-03 11:52:06 +01:00
Marco Pivetta
6744b48bc2
Merge pull request #6598 from mikeSimonson/xml-dtd-improvements2
...
More refinement of the xml dtd
2017-08-02 23:30:52 +02:00
mike
a54a258866
More refinement of the xml dtd
2017-08-02 22:58:05 +02:00
Marco Pivetta
97914c0f3e
Merge pull request #6588 from reypm/master
...
Updating docs to support for APCu as a cache driver
2017-07-31 17:00:36 +02:00
reypm
40ee7af9c8
Fixing issue in APC driver
2017-07-30 15:31:42 -04:00
reypm
0c30bab776
Adding extra tilde and updating APC references to APCu (APC is deprecated as per http://php.net/manual/en/intro.apc.php )
2017-07-30 14:40:19 -04:00
reypm
5d8dc1757f
Updating docs to support for APCu as a cache driver
2017-07-30 12:51:39 -04:00
Marco Pivetta
8149a1dd83
Merge pull request #6581 from Majkl578/travis-stages
...
Travis enhancements: Use Build Stages, added PHP 7.2
2017-07-25 04:44:41 +02:00
Michael Moravec
dbb0cdea51
Travis enhancements: Use Build Stages, added PHP 7.2
2017-07-25 03:54:04 +02:00
Maxime Veber
03d33ec900
Add string type as possible parameter for between
...
People may want to enter a date, or simply the parameter name. Linter may report an error while it's a good usage.
2017-07-24 14:23:16 +02:00
Luís Cobucci
84079572f7
Merge pull request #6575 from lcobucci/improvement/move-performance-tests-to-phpbench
...
Move performance tests to phpbench
2017-07-23 10:46:26 +02:00
Luís Cobucci
e07c90df44
Add PHPBench to Travis-CI matrix
...
Also separating the execution of the tests from other tools.
2017-07-23 10:30:19 +02:00
Marco Pivetta
cfa9d787fe
Removing old ProxyPerformanceTest
2017-07-23 10:16:51 +02:00
Marco Pivetta
f1bc1bbf12
Mocks required by the proxy performance benchmarks
2017-07-23 10:16:50 +02:00
Marco Pivetta
d8140d700a
Benchmarking proxy initialization logic
2017-07-23 10:16:49 +02:00
Marco Pivetta
d658364b59
Benchmarking instantiation of proxies
2017-07-23 10:16:48 +02:00
Marco Pivetta
77ce354f18
Removing old UnitOfWorkPerformanceTest
2017-07-23 10:16:47 +02:00
Marco Pivetta
b1bbad3b15
Unit of work changeset computation test
2017-07-23 10:16:46 +02:00
Marco Pivetta
7515dd20f2
Removing old PersisterPerformanceTest
2017-07-23 10:16:45 +02:00
Marco Pivetta
8ec186f095
Removing old inheritance persister test
2017-07-23 10:16:44 +02:00
Marco Pivetta
52402917a0
Benchmarking hydration of a STI
2017-07-23 10:16:43 +02:00
Marco Pivetta
c5a636ebfb
Corrected benchmark name: benchmark affects a STI
2017-07-23 10:16:42 +02:00
Marco Pivetta
2692435705
Benchmarking insert operations for a JTI
2017-07-23 10:16:41 +02:00
Marco Pivetta
29f55eaef9
Removing instantiation overhead from benchmark
2017-07-23 10:16:40 +02:00
Marco Pivetta
5401cb5329
Removed old InsertPerformanceTest (moved to benchmark)
2017-07-23 10:16:39 +02:00
Marco Pivetta
d51235f200
Removing useless imports
2017-07-23 10:16:37 +02:00
Marco Pivetta
cbb0c1bd04
Corrected class name - needs to end with Bench
2017-07-23 10:16:36 +02:00
Marco Pivetta
ef0edc8929
Benchmarking simple insert operations (batched)
2017-07-23 10:16:35 +02:00
Marco Pivetta
fd27b22ad1
Removing old HydrationPerformanceTest
2017-07-23 10:16:34 +02:00
Marco Pivetta
93dc028194
Benchmarking full object hydration with fetch joins and mixed values
2017-07-23 10:16:33 +02:00
Marco Pivetta
608b3ed6a4
Benchmarking mixed fetch-join with partial hydration
2017-07-23 10:16:32 +02:00
Marco Pivetta
131aac531a
Removing unused $entityManager variable
2017-07-23 10:16:31 +02:00
Marco Pivetta
1e16cb83f8
Full object hydration benchmark
2017-07-23 10:16:30 +02:00
Marco Pivetta
97735cdb68
Partial hydration bench
2017-07-23 10:16:29 +02:00
Marco Pivetta
f23359c1f3
Renaming bench methods, for clarity
2017-07-23 10:16:28 +02:00
Marco Pivetta
0fdcc71887
CS (alignment)
2017-07-23 10:16:27 +02:00
Marco Pivetta
8774b02c88
Testing mixed array hydration (with scalars and fetch-joined results)
2017-07-23 10:16:26 +02:00
Marco Pivetta
d8ddc47f83
Array hydration benchmark
2017-07-23 10:16:25 +02:00
Marco Pivetta
88ea1d33fa
Full hydration + query benchmark
2017-07-23 10:16:24 +02:00
Marco Pivetta
f95c81b210
Simple array hydration benchmark
2017-07-23 10:16:23 +02:00
Marco Pivetta
94adf97550
Factory used to create a new entity manager
2017-07-23 10:16:22 +02:00
Marco Pivetta
37cb2c0722
Benchmark autoloading definitions
2017-07-23 10:16:20 +02:00
Marco Pivetta
25669c51b6
PHPBench base config
2017-07-23 10:16:17 +02:00
Marco Pivetta
c8a41598c9
Not a performance test
2017-07-23 10:16:04 +02:00
Luís Cobucci
9826d9c29a
Merge pull request #6485 from elt/versionWithCustomTypePrimaryKey
...
#5804 Versioning doesn't work with a custom type primary key
2017-07-22 23:29:12 +02:00
Luís Cobucci
6bf9f6f72f
Remove unnecessary annotation from test
2017-07-22 22:41:07 +02:00
Luís Cobucci
eba8fec1fb
Move identifier types extraction to a method
2017-07-22 22:39:47 +02:00
Alessandro Frangioni
60a2628f9d
Iteration simplified
2017-07-22 22:26:31 +02:00
Alessandro Frangioni
82c87081b4
Changed SQL declaration for custom type
2017-07-22 22:26:31 +02:00
Alessandro Frangioni
f6907b9503
Applied patches as for #6496
2017-07-22 22:26:31 +02:00
Alessandro Frangioni
4ef0a238bf
Inferring id's field types
2017-07-22 22:26:31 +02:00
Alessandro Frangioni
af3591fbca
Fixes #5804
2017-07-22 22:26:31 +02:00
Marco Pivetta
1d8c7f9bac
Merge pull request #6556 from lcobucci/fix/command-list
...
Update ConsoleRunner's command list
2017-07-22 22:19:57 +02:00
Luís Cobucci
5109322f7d
Make explicit the design decisions of ConsoleRunner
2017-07-22 21:56:59 +02:00
Luís Cobucci
d4b94e097a
Ensure that ConsoleRunner has the right command list
2017-07-22 21:56:56 +02:00
Luís Cobucci
2b824ea9df
Update ConsoleRunner command list
...
Adding L2C commands and DBAL reserved words command.
2017-07-22 21:56:42 +02:00
Marco Pivetta
2fb3cfdba2
Merge pull request #6143 from chihiro-adachi/patch-1
...
fixed #5622 - mysql 5.7 ONLY_FULL_GROUP_BY
2017-07-22 21:41:51 +02:00
Luís Cobucci
5389ad7261
Make LimitSubqueryOutputWalker a bit more readable
...
Also simplifying the REGEX to remove the ORDER BY type (ASC/DESC) with a
substr() since OrderByItem#type is always defined.
2017-07-22 20:34:18 +02:00
Luís Cobucci
3d5acd607b
Bump up doctrine/instantiator version
2017-07-22 19:30:47 +02:00
Luís Cobucci
4a736f48f8
Add MySQL 5.7 to Travis configuration
...
Following the same setup of doctrine/dbal#2764 .
2017-07-22 19:28:29 +02:00
chihiro-adachi
60601a9323
fix query and tests
2017-07-22 19:28:28 +02:00
Martin Kirilov
854ff17ab9
Should fix MySQL 5.7 issues caused by ONLY_FULL_GROUP_BY
...
Should fix MySQL 5.7 issues caused by ONLY_FULL_GROUP_BY
2017-07-22 19:28:28 +02:00
Greg Bell
624af3df22
Add note clarifying WHERE, WITH and HAVING
...
- A per Ocramius' explanation in #6563
2017-07-22 17:40:56 +10:00
Greg Bell
80573038ed
Add additional detail and clarifications on SELECT
...
- Also the effect of WHERE on result array.
2017-07-22 17:28:48 +10:00
Marco Pivetta
668ad4cc29
Merge pull request #6550 from alcaeus/fix-persistent-collection-return
...
Fix return value of removeElement for extra lazy collections
2017-07-22 09:26:15 +02:00
Marco Pivetta
fb3ec7648d
Merge pull request #6569 from stoccc/patch-1
...
Added a test case for postLoad on fetch-joined entities - fetch joined entities should have lifecycle events fired as well
2017-07-21 18:30:38 +02:00
Luís Cobucci
39572a8b6e
Merge pull request #6570 from stloyd/patch-1
...
Prevent Travis-CI failure if xdebug is not available
2017-07-21 11:19:30 +02:00
Joseph Bielawski
247fb6ef0d
Prevent Travis-CI failure if xdebug is not available
2017-07-21 11:03:05 +02:00
stoccc
17892bb327
added named parameter and LifecycleCallbackCascader::getId()
2017-07-21 10:47:32 +02:00
stoccc
c47cf1de34
Added a test case for postLoad on fetch-joined entities
...
see https://github.com/doctrine/doctrine2/issues/6568
2017-07-21 10:33:28 +02:00
Marco Pivetta
63519be69c
Merge pull request #6562 from bitwombat/doc_changes
...
Make minor English fixes.
2017-07-21 02:15:19 +02:00
Greg Bell
34c25a3ee3
Make minor English fixes.
...
- Remove the apparently dangling text at the bottom of
reference/query-builder.rst
2017-07-19 11:14:46 +10:00
Andreas Braun
45e1817f6f
Add test for removing element not in collection
2017-07-13 16:39:06 +02:00
Andreas Braun
260cc6e3e0
Fix return of removeElement on collections
...
Fixes #5745
2017-07-13 08:16:00 +02:00
Marco Pivetta
e3ecec36ad
Merge pull request #6545 from Landerstraeten/patch-1
...
Fix newline in annotation example in documentation
2017-07-12 08:23:18 +02:00
Lander Vanderstraeten
c678577f8f
Fix newline
2017-07-11 13:18:52 +02:00
Luís Cobucci
c32ba8f5d1
Merge pull request #6535 from Majkl578/phpstan
...
[master] PHPStan integration - levels 0 + 1
2017-07-07 10:36:08 +02:00
Michael Moravec
74c48c201d
Push PHPStan to level 1
2017-06-30 00:27:50 +02:00
Ondrej Mirtes
1231861b09
Initial PHPStan integration (level 0)
2017-06-30 00:27:49 +02:00
Alessandro Lai
c7ef9085fb
Merge additional fix (and master changes) from taueres/fix-instance-of-subclasses
2017-06-26 09:45:44 +02:00
Sergio Santoro
e91dcf8fb4
Fix discriminator resolution when using parameters
2017-06-24 13:35:44 +02:00
Alessandro Lai
b1f7c59ed5
Adding a failing test case for parameter binding using metadata with INSTANCE OF
2017-06-24 10:58:18 +02:00
Alessandro Lai
2fd8752818
Simplify stubs used in tests
2017-06-24 10:58:18 +02:00
Alessandro Lai
d2f7514248
Put all tests classes in a single namespace
2017-06-24 10:58:18 +02:00
Alessandro Lai
167dfde00f
Apply additional fixes to the SqlWalker to fix tests
2017-06-24 10:58:18 +02:00
Alessandro Lai
5181eae8d6
Refactor a bit the SqlWalker modifications
2017-06-24 10:58:18 +02:00
Alessandro Lai
31d2d84160
Fix test
2017-06-24 10:58:18 +02:00
Alessandro Lai
bd47ec95a1
Move tests to ticket namespace (and rename them)
2017-06-24 10:58:18 +02:00
Alessandro Lai
0e88f1b654
Split SqlWalker::walkInstanceOfExpression method
2017-06-24 10:58:18 +02:00
Alessandro Lai
aa233f8e57
Fix small CS issues as per review
2017-06-24 10:58:18 +02:00
Alessandro Lai
04acde667a
Fix as per review
2017-06-24 10:58:18 +02:00
Sergio Santoro
7d98135084
[QUERY] "INSTANCE OF" now behaves correctly with subclasses
...
There was a bug in the "INSTANCE OF" operator as described in
https://groups.google.com/forum/#!topic/doctrine-user/B8raq8CNMgg
"INSTANCE OF" was not taking into account subclasses.
It was merely translating the class to its discriminator.
This is not correct since the class can have subtypes and those
are, indeed, still instance of the superclass.
Also, classes may not have a discriminator (e.g. abstract classes).
This commit also provides useful tests to avoid regression.
2017-06-24 10:58:18 +02:00
Marco Pivetta
388afb46d0
Merge pull request #6245 from lcobucci/l2c-use-getMultiple
...
Use `getMultiple()` to fetch associations as well in L2 cache fetch operations
2017-06-24 09:17:55 +02:00
Marco Pivetta
5d98247178
Merge pull request #5756 from whyte624/master
...
s/__tostring()/__toString() in Expr\OrderBy
2017-06-24 04:12:55 +02:00
Marco Pivetta
b66dd0b6fa
Merge pull request #5787 from iBet7o/patch-doc
...
Fix bug: orderBy documentation
2017-06-24 04:05:41 +02:00
Marco Pivetta
807f1422a3
Merge branch 'fix/#1515-clean-hydrator-listeners-on-hydration-end'
...
Close #1515
2017-06-24 03:41:00 +02:00
Marco Pivetta
995054d884
#1515 dropping DDC-3146 test, which was moved to the hydration tests
2017-06-24 03:40:46 +02:00
Marco Pivetta
0b5d877d5f
Migrating #1515 tests to AbstractHydratorTest
2017-06-24 03:40:12 +02:00
Marco Pivetta
067e01e0d7
#1515 cleaning up test case, since the PHPUnit 5.4+ API is much nicer
2017-06-24 03:32:58 +02:00
Marco Pivetta
aba486ea2d
#1515 removing redundant assignment, short array notation
2017-06-24 03:27:12 +02:00
Emiel Nijpels
9eb2d6139e
DDC-3146 remove event listener from event listener in abstract hydrator in cleanup function
2017-06-24 03:22:12 +02:00
Marco Pivetta
41bcdb3268
Merge pull request #6494 from astepin/gh-6356
...
Add failing test for #6314 and PR #6356
2017-06-23 12:54:29 +02:00
Marco Pivetta
95b30c1d40
Merge pull request #6515 from lcobucci/use-updated-environment
...
Use the Travis' Trusty build environment
2017-06-23 11:33:15 +02:00
Luís Cobucci
21ad7a1913
Create schema based on config file (on MySQL & MariaDB)
2017-06-23 11:21:36 +02:00
Alessandro Lai
d4cdc6e1fe
Adding a failing test case for parameter binding using metadata with INSTANCE OF
2017-06-22 09:50:53 +02:00
Marco Pivetta
af1ea1ae1d
Merge pull request #5623 from Jean85/patch-1
...
[DOCUMENTATION] Update tests README
2017-06-22 08:03:42 +02:00
Marco Pivetta
379acd9dfd
Merge pull request #5734 from amerryma/master
...
Update tools.rst
2017-06-22 08:02:40 +02:00
Luís Cobucci
e8332a45de
Use the Travis' Trusty build environment
...
To see if that solves the XML validation issues (since the issues are
possibly happening due to old libxml versions).
2017-06-22 08:01:13 +02:00
Luís Cobucci
3df6b7316b
Merge pull request #6243 from enumag/patch-3
...
Fix CountOutputWalker for queries with GROUP BY
2017-06-22 07:16:38 +02:00
Jáchym Toušek
fc609271e0
Fix CountOutputWalker for queries with GROUP BY
2017-06-22 07:09:20 +02:00
Alessandro Lai
ba69cc8f7a
Simplify stubs used in tests
2017-06-21 13:25:31 +02:00
Alessandro Lai
8b9c29738d
Put all tests classes in a single namespace
2017-06-21 10:26:31 +02:00
Alessandro Lai
11c54b7715
Apply additional fixes to the SqlWalker to fix tests
2017-06-21 10:11:31 +02:00
Alessandro Lai
30256e7a08
Refactor a bit the SqlWalker modifications
2017-06-21 09:34:16 +02:00
Marco Pivetta
b925cce6c4
Merge branch 'docs/#5677-upgrade-getting-started-documentation'
...
Close #5677
2017-06-21 08:29:31 +02:00
NateC
b446afd937
Updating the Getting Started guide's documentation
2017-06-21 08:29:20 +02:00
Marco Pivetta
9cfdf1ef81
#6325 documenting minor BC break introduced by adding a required parameter to the exception named constructor
2017-06-21 08:20:20 +02:00
Marco Pivetta
9b9128ae77
Merge branch 'improvement/#6325-improve-dql-exception-message-for-single-valued-inverse-association-path'
...
Close #6325
2017-06-21 08:16:49 +02:00
Marco Pivetta
b21cb3e2a0
#6325 adding IDE hints, type hints, replacing double quotes with single quotes
2017-06-21 08:16:24 +02:00
Tomasz Darmetko
633a442046
Add path expresion to QueryException::associationPathInverseSideNotSupported()
2017-06-21 08:12:04 +02:00
Marco Pivetta
33cee11e6f
Merge pull request #6389 from mikeSimonson/xml-dtd-improvements
...
XSD definition improvements
2017-06-21 08:08:14 +02:00
Marco Pivetta
98aa25b0ea
Merge branch 'fix/#5798-undefined-schema-tool-index'
...
Close #5798
2017-06-21 06:34:57 +02:00
Marco Pivetta
6e9c1d8a4b
#5798 adding void test method return declaration, using ::class reference over string reference
2017-06-21 06:34:45 +02:00
Sergey Fedotov
d13327eca2
Fix undefined index for discriminator column in SchemaTool
2017-06-21 06:27:15 +02:00
Marco Pivetta
fe8259a094
Merge branch 'fix/#5715-fix-metadata-filtering-in-cli-tools'
...
Close #5715
2017-06-21 06:21:52 +02:00
Marco Pivetta
01d226aff0
#5715 removed superfluous mapping information
2017-06-21 06:21:22 +02:00
Marco Pivetta
29fe76cced
#5715 short array notation
2017-06-21 06:20:30 +02:00
Marco Pivetta
2ce40a6aeb
#5715 s/CLASSNAME/class
2017-06-21 06:18:24 +02:00
Marco Pivetta
f0e403211b
#5715 adding return hints \(void\) to test methods
2017-06-21 06:17:18 +02:00
Guilliam Xavier
a9cc522e8a
Add regex tests for MetadataFilter (PR #507 )
2017-06-21 06:14:01 +02:00
Guilliam Xavier
1afa8a915d
Add more basic tests for MetadataFilter
2017-06-21 06:14:01 +02:00
Guilliam Xavier
87e9879edd
Fix MetadataFilter not testing filters after first
2017-06-21 06:14:01 +02:00
Guilliam Xavier
652358a4de
Add failing test for #5715 (unit test for MetadataFilter)
2017-06-21 06:14:01 +02:00
Marco Pivetta
07a9b10f36
Merge branch 'fix/#6168-#6167-force-nextval-selection-on-the-master-server'
...
Close #6167
Close #6168
2017-06-21 06:04:34 +02:00
Marco Pivetta
a97c2659fc
#6167 #6168 rewrote SequenceGeneratorTest for better readability and error messages
2017-06-21 06:04:06 +02:00
Marco Pivetta
462481ebbe
#6167 #6168 - better connection mock documentation/docblocks/return-types
2017-06-21 05:47:19 +02:00
Marco Pivetta
d2be4a2b48
#6167 #6168 - clarifying on the reasoning why query is used instead of fetchColumn
2017-06-21 05:44:58 +02:00
Michał Kurzeja
571115cf18
#6167 Code review updates, better readability
2017-06-21 05:42:26 +02:00
Michał Kurzeja
71b040c849
#6167 - tests - throw exception if wrong method used to get sequence nextval
2017-06-21 05:42:26 +02:00
Michał Kurzeja
edffb4d449
#6167 - fixed tests and added info why query is used in SequenceGenerator
2017-06-21 05:42:26 +02:00
Michał Kurzeja
60b6073643
Fixes #6167 - nextval issue on master-slave PostgreSQL setup
2017-06-21 05:42:26 +02:00
Marco Pivetta
1e3bf6562e
Merge branch 'feature/#6162-report-that-subqueries-are-not-allowed-in-from-and-join'
...
Close #6162
2017-06-21 05:39:01 +02:00
Marco Pivetta
3260d220e8
#6162 adding @group annotation, spacing
2017-06-21 05:38:42 +02:00
Marco Pivetta
a7dcdd8d48
Documenting thrown exception type, spacing #6162
2017-06-21 05:36:13 +02:00
SimonHeimberg
1dbc67cce1
Tests for Subqueries set expectations directly before their occurrence
2017-06-21 05:34:12 +02:00
SimonHeimberg
5b6d766961
Tests for not supported Subqueries in FROM and JOIN
2017-06-21 05:33:28 +02:00
SimonHeimberg
f5d4db7d9c
Report that FROM and JOIN do not support Subqueries
2017-06-21 05:31:25 +02:00
Marco Pivetta
7523513be5
Merge pull request #6511 from lcobucci/make-scrutinizer-more-strict
...
Define build failure conditions on scrutinizer
2017-06-20 17:34:46 +02:00
Luís Cobucci
aa9f34b600
Configure build failure conditions
...
So that contributors receive some automated feedback in case maintainers
are not fast enough.
2017-06-20 14:06:40 +02:00
Luís Cobucci
1bdc61f932
Remove tools that are not supported anymore
2017-06-20 09:43:43 +02:00
Marco Pivetta
93f617536b
Merge pull request #6501 from mpdude/patch-1
...
Clarify the impact of changing the fetch mode
2017-06-20 07:31:36 +02:00
Marco Pivetta
256091282e
Merge pull request #6500 from SamKnows/feature/override-aggregate-functions
...
Allow internal functions to be overridden.
2017-06-20 07:29:51 +02:00
Mathew Davies
747c1857d6
Make the new aggregate function definitions final.
2017-06-20 07:27:32 +02:00
Mathew Davies
05758f4564
Documented changes in UPGRADE.md
2017-06-20 07:27:30 +02:00
Mathew Davies
49e4b1004c
Update LimitSubqueryOutputWalkerTest
2017-06-20 07:27:29 +02:00
Mathew Davies
3e3751cfd9
Remove aggregate function conditional in SqlWalker.
2017-06-20 07:27:27 +02:00
Mathew Davies
966f9a84c2
phpDoc and type hint changes.
2017-06-20 07:27:26 +02:00
Mathew Davies
e4847534a4
Remove @throws in Configuration where necessary.
2017-06-20 07:27:25 +02:00
Mathew Davies
866418e40f
No longer treat aggregate functions as a special case.
2017-06-20 07:27:24 +02:00
Mathew Davies
e4ff7a35a8
Write a test case for a custom function override.
2017-06-20 07:27:22 +02:00
Mathew Davies
914c400a7d
Check for custom functions first.
2017-06-20 07:27:20 +02:00
Marco Pivetta
e80cd74c3e
Merge pull request #6507 from lcobucci/upgrade-dependencies
...
Upgrade dependencies
2017-06-20 07:18:28 +02:00
Luís Cobucci
ad5014decc
Merge pull request #6508 from magnetik/patch-1
...
[Doc] Fix links to api doc in the second level cache documentation page
2017-06-20 07:09:42 +02:00
Luís Cobucci
9fa456b9f0
Bump versions of some dependencies
2017-06-19 17:43:38 +02:00
Luís Cobucci
e123f16ec9
Require PHP 7.1
2017-06-19 17:43:37 +02:00
Luís Cobucci
99dc8aa2a9
Drop HHVM support
2017-06-19 17:43:16 +02:00
Baptiste Lafontaine
177c48107d
Fix links to api doc
2017-06-19 13:31:10 +02:00
Matthias Pigulla
8f9f41ea89
Fix typo
2017-06-15 01:03:38 +02:00
Matthias Pigulla
5a2a771173
Clarify the impact of changing the fetch mode
...
Seems to work for one-to-many as well, but with a negative performance impact.
2017-06-15 01:02:45 +02:00
Marco Pivetta
fc67b398a1
Merge pull request #6479 from lcobucci/fix-risky-tests
...
Fix all risky tests
2017-06-13 01:20:57 +03:00
Luís Cobucci
5c02e0c1e8
Remove APC dependency on tests
...
By using a shared array cache so that we can reproduce different cache
instances that shares the stored data.
2017-06-12 23:05:58 +02:00
Luís Cobucci
a9c711ad7e
Register custom types to not skip model set validation
...
Also removing an empty and unused model set.
2017-06-12 23:05:57 +02:00
Luís Cobucci
ee5f222c58
Rename data provider so that it doesn't get executed as test
2017-06-12 23:05:56 +02:00
Luís Cobucci
8dccd27b52
Add the correct assertions for tests that don't have any
2017-06-12 23:05:55 +02:00
Luís Cobucci
d8663cd9ee
Use a more appropriate assertion on some tests
2017-06-12 23:05:54 +02:00
Luís Cobucci
8796e2d938
Expect an exception instead of failing the test
...
Since that's the assertion we're actually doing.
2017-06-12 23:05:53 +02:00
Luís Cobucci
19fc91482e
Validate if optimistic locks are released properly
...
By trying to update an entry using a different connection.
2017-06-12 23:05:52 +02:00
Luís Cobucci
99df158fc8
Allow passing a connection while creating an entity manager
...
Also removing unsed arguments.
2017-06-12 23:05:51 +02:00
Luís Cobucci
1bf884970f
Increment assertion count manually
...
Which is needed to test void methods that shouldn't raise any exception
on a certain condition. If the interpreter gets to the point where the
assertion count is incremented it means that no exceptions have been
thrown and our test is successful.
Important to note that some tests were slighly refactored to simplify
things a bit.
2017-06-12 23:04:56 +02:00
Luís Cobucci
8d144daf01
Remove duplicated tests (keeping them on unit test suite only)
2017-06-12 23:04:55 +02:00
Luís Cobucci
043ca69f0b
Fix some code style issues in tests
2017-06-12 23:04:54 +02:00
Benjamin Eberlei
3dc0f471fe
Merge pull request #6481 from lcobucci/improve-build-extensions
...
Improve build extensions
2017-06-12 20:45:25 +02:00
Marco Pivetta
c0c08d92ba
Merge pull request #6493 from astepin/small-code-improvements
...
Minor fixes: typos, documentation, etc.
2017-06-11 12:14:30 +03:00
Artem Stepin
799190d5e4
- fixed columnPrefix generator for the embedded annotation
2017-06-09 22:25:19 +02:00
Artem Stepin
351b6972a4
Merge branch 'original-pr-6356' into gh-6356
2017-06-09 21:58:57 +02:00
Artem Stepin
7a63e81c94
Add failing test for gh-#6314 (gh-#6356)
2017-06-08 23:18:47 +02:00
Artem Stepin
43009682a4
minor code work:
...
- method calls with incorrect case
- removed unused imports
- typos and some other minor code smells
- documentation update (wrong return types etc. )
2017-06-08 22:04:07 +02:00
Marco Pivetta
049ad1e079
Merge pull request #6491 from SamKnows/fix/mock-implementations
...
Fix Mock Implementations.
2017-06-08 19:06:25 +02:00
Mathew Davies
b42c36f472
Update phpDoc
2017-06-08 16:43:18 +01:00
Mathew Davies
9f13557d14
Be consistent with the rest of the file.
2017-06-08 16:42:11 +01:00
Mathew Davies
633b821e18
Update StatementArrayMock to implement the right interface.
2017-06-08 16:31:59 +01:00
Mathew Davies
a59367423a
Update StatementMock to implement the right interface.
2017-06-08 16:25:57 +01:00
Mathew Davies
1559db7ac1
Update HydratorMockStatement to implement the right interface.
2017-06-08 16:25:03 +01:00
Marco Pivetta
971c400025
Merge pull request #6462 from mkosiedowski/proxy-embedded-fields-fix
...
Fix #6460 - \Doctrine\ORM\Mapping\ClassMetadataInfo::hasField should return true for embedded fields
2017-06-01 15:52:07 +02:00
Luís Cobucci
2359360149
Disable XDebug based on PHPUnit flags instead
...
Then we don't need to keep changing versions information.
2017-06-01 07:40:28 +02:00
Marco Pivetta
22ecc2d58c
Merge pull request #5938 from Ma27/feature/DDC5934-allow-fetch-override
...
#5934 - add `fetch` option to `AssociationOverride` in order to override fetch strategy for subclasses of entities
2017-05-31 20:24:57 +02:00
Maximilian Bosch
49bb345533
#5934 - #5938 - fix accidentally introduced regression with wrong target of ::class expression
2017-05-31 15:01:25 +02:00
Maximilian Bosch
fcfaa13df9
#5934 - #5938 - use ClassMetadata::class expression rather than FQCN in config drivers as of @Ocramius's review
2017-05-31 14:52:55 +02:00
Maximilian Bosch
92476b5953
#5934 - add fetch option to AssociationOverride in order to override fetch strategy for subclasses of entities
2017-05-30 18:19:48 +02:00
Marco Pivetta
205ee72e33
Merge pull request #6478 from lcobucci/fix-yaml-tests
...
Fix YAML related tests
2017-05-30 14:05:19 +02:00
Luís Cobucci
f9062d9931
Force YAML parser to convert keys to string
...
Since Symfony 3.3 implicit conversion is not enabled by default so we
need to pass that flag manually.
Related to: https://github.com/symfony/symfony/pull/21774
2017-05-30 13:53:45 +02:00
Luís Cobucci
f18e178960
Fix wrong YAML mapping
...
We had duplicated keys and that's no longer valid on symfony/yaml 3.3.
2017-05-30 12:51:51 +02:00
Luís Cobucci
2a239be45e
Merge pull request #6466 from fmagnan/patch-1
...
Update QueryBuilder.php
2017-05-23 18:44:10 +02:00
Franck Magnan
db528a44b1
Update QueryBuilder.php
...
Hello,
thank you very much for your work, it's awesome!
I found a minor error in PHPDOC for method setParameter. Argument "type" can be a string or null but can be also an int if it comes from \PDO::PARAM_*. So I've changed typehint "string" into "mixed".
2017-05-23 18:42:01 +02:00
Simone Gentili
4bf2e890fb
remove loosely comparison
2017-05-23 10:28:45 +02:00
Maciej Kosiedowski
76f0fe45af
fixes in tests
2017-05-22 15:52:19 +02:00
Maciej Kosiedowski
f304685c68
Fix #6460 - \Doctrine\ORM\Mapping\ClassMetadataInfo::hasField should return true for embedded fields
2017-05-22 14:41:06 +02:00
Marco Pivetta
6ea30f0354
Merge pull request #6456 from bitwombat/doc_changes
...
Fixes and clarifications to Association Mapping document
2017-05-21 15:17:40 +02:00
Greg Bell
00aba32c67
Resolve conflicts
2017-05-21 16:56:16 +10:00
Greg Bell
46cebfb33d
Clarify concepts, fix minor English issues.
...
- Globally change 'Shipping' to 'Shipment' - shipment is a noun and thus a clearer name for an object.
- Add definition of unidirectional to the top of the document.
- Explain inversedBy and mappedBy the first time they are used.
- Clarify some ownership and bidirectionality text.
- Minor English and punctuation fixes.
2017-05-21 16:39:06 +10:00
Greg Bell
89bf6152a6
Merge branch 'doc_changes' of https://github.com/bitwombat/doctrine2 into doc_changes
2017-05-21 14:14:52 +10:00
Greg Bell
75821e75f5
Clarify English and a few concepts
...
- Globally change 'Shipping' to 'Shipment' - shipment is a noun and thus a
clearer name for an object.
- Move definition of unidirectional from example to the top of the document.
- Explain inversedBy and mappedBy the first time they are used.
- Clarify some ownership and bidirectionality text.
- Minor English and punctuation fixes.
2017-05-21 14:14:28 +10:00
Greg Bell
7bfd172156
Clarify English and a few concepts
...
- Globally change 'Shipping' to 'Shipment' - shipment is a noun and thus a
clearer name for an object.
- Move definition of unidirectional from example to the to of the document.
- Explain inversedBy and mappedBy the first time they are used.
- Clarify some ownership and bidirectionality text.
- Minor English and punctuation fixes.
2017-05-21 14:10:38 +10:00
Marco Pivetta
ee066cc5de
Merge pull request #6451 from nicolas-grekas/sf4
...
Allow Symfony 4.0
2017-05-18 12:59:19 +02:00
Nicolas Grekas
7ce2381bdd
Allow Symfony 4.0
2017-05-18 12:57:36 +02:00
Marco Pivetta
334b7e68a7
Merge pull request #6442 from sensorario/performance-improvement
...
Compute size of loaders in the test suite beforehand, and not on each iteration
2017-05-16 13:40:17 +02:00
Marco Pivetta
95c60219d5
Merge pull request #6446 from eibt/update-docs-theme-submodule
...
Update theme submodule
2017-05-16 13:21:34 +02:00
Ivan
73770ac090
Update git submodule "docs/en/_theme"
...
- This fixes the broken image at the footer of Doctrine 2 ORM's docs
2017-05-15 14:53:23 -06:00
Simone Gentili
0a801b895e
compute size of loaders beforehand and not on each iteration
2017-05-15 07:43:15 +02:00
Luís Cobucci
e9b54de488
Merge pull request #6439 from sensorario/align-equals-signs
...
align equals signs
2017-05-14 10:21:42 +02:00
Simone Gentili
fac7e8facb
align equals signs
2017-05-13 23:05:37 +02:00
Marco Pivetta
c222c1d17a
Merge pull request #6433 from mpdude/patch-1
...
Remove dead code in the schema tool
2017-05-10 19:31:40 +02:00
Luís Cobucci
2695f5e3a5
Merge pull request #6436 from lcobucci/fix-result-set-cache-eviction
...
Pass the connections parameters for cache key generation
2017-05-10 18:07:12 +02:00
Luís Cobucci
885c431bd9
Pass the connection parameters for cache key generation
...
That argument was added to not have key collisions for different
connections.
More info: https://github.com/doctrine/dbal/pull/713
2017-05-10 17:52:38 +02:00
Matthias Pigulla
5c1908d82f
Remove dead code
...
Hopefully this does not do anything...?
2017-05-09 19:21:49 +02:00
Marco Pivetta
7bb02d0dbd
Merge pull request #6417 from lcobucci/fix-expire-result-cache
...
Fix expire result cache
2017-05-03 12:40:33 +02:00
Alessandro Lai
96bcee4fa9
Fix test
2017-05-03 11:42:51 +02:00
Alessandro Lai
21e12ef4a9
Move tests to ticket namespace (and rename them)
2017-05-03 11:06:43 +02:00
Alessandro Lai
11c84c7b20
Split SqlWalker::walkInstanceOfExpression method
2017-05-03 11:00:26 +02:00
Alessandro Lai
3219fe5316
Fix small CS issues as per review
2017-05-03 10:46:24 +02:00
Luís Cobucci
e71272e2b4
Evict result set cache if Query#expireResultCache() was called
2017-05-02 23:25:56 +02:00
bruno da silva
85a52d781e
add a not weel writend/nammed test testing Query::expireResultCache()
2017-05-02 23:25:56 +02:00
Marco Pivetta
2c1ebc4ef1
Merge pull request #6416 from lcobucci/fix-quote-on-inheritance
...
Fix quoting when using inheritance as well
2017-05-02 09:42:03 +02:00
Marco Pivetta
77ee69f1a8
Merge pull request #6367 from SirWaddles/fix-inheritance-alias
...
Fix inheritance alias
2017-05-02 09:25:18 +02:00
Timothy Clissold
0a10f347d3
Fix inheritance join alias
2017-05-02 00:17:16 +02:00
Luís Cobucci
6c0654c144
Merge pull request #6274 from Necsord/issue/5887-one-to-one-with-custom-id-object-relationship-fix
...
Fixing #5887 - lazy loading of one-to-one relationship with custom id object
2017-04-30 20:10:37 +02:00
Marcin Szulc
a360da5a7e
Fix lazy loading of 1-to-1 relationship with custom id object
...
Fixing case when lazy loading of entity in one-to-one relationship on the side without foreign key
did not return eht entity because of custom type not being detected and properly formatted before
applying to database query.
Closes https://github.com/doctrine/doctrine2/issues/5887
2017-04-30 19:53:28 +02:00
Luís Cobucci
0aef63b350
Fix quoting also when using inheritance
2017-04-30 19:36:41 +02:00
Luís Cobucci
4ebf27de35
Use "quoted" from existing data if exists
...
In order to keep that information for inheritance mapping.
2017-04-30 19:36:40 +02:00
Luís Cobucci
942bb6cb1f
Remove dead code from OrmFunctionalTestCase
2017-04-30 19:36:39 +02:00
lemartin
7c6c5d87c8
Fix quoting issues related to ticket #6402
...
Apply quoting strategy to foreign key columns of one-to-one relation so
that correct select statements are generated. And use unquoted column
names in result mapping instead of quoted ones, as consumers (namely
IdentifierFlattener) expect unquoted column names.
2017-04-30 13:51:49 +02:00
Luís Cobucci
ccaa4b8ce1
Use getMultiple() to fetch associations as well
2017-04-30 13:43:29 +02:00
Vytautas Stankus
a557c97a93
Add support for STARTS_WITH and ENDS_WITH comparison operators
2017-04-30 13:19:51 +02:00
Jarek Jakubowski
38bfcc6a7a
Fix notice in ClassMetadata when there is no ID Column defined
...
When you forget about defining the ID/PK Column, then this ugly Notice appear.
Now it will throw nice Exception.
2017-04-30 11:38:47 +02:00
Marco Pivetta
03972c9c3a
Merge pull request #6410 from PowerKiKi/patch-2
...
Minor typo naming strategy documentation
2017-04-23 14:25:39 +02:00
Adrien Crivelli
692a1afa86
Minor typo naming strategy documentation
2017-04-22 00:05:57 +09:00
Alessandro Lai
4eb4465169
Fix as per review
2017-04-18 11:57:49 +02:00
Marco Pivetta
318e9a5596
Merge pull request #6400 from neobyteUK/master
...
Fix incorrect YAML datetime version field.
2017-04-15 02:23:56 +02:00
Richard Henry
e44a83fc7b
Fix incorrect YAML datetime version field.
2017-04-15 01:18:44 +01:00
Marco Pivetta
b88480212a
Merge pull request #6399 from neobyteUK/master
...
Fix incorrect YAML example for versioning a field.
2017-04-15 01:24:06 +02:00
Richard Henry
6b6c300319
Fix incorrect YAML example for versioning a field.
2017-04-15 00:12:53 +01:00
Marco Pivetta
7c5b27da2c
Merge pull request #6395 from yannickl88/master
...
Updated broken links
2017-04-12 23:14:30 +02:00
Yannick de Lange
7e50a965fa
Updated broken links
...
Updated all links pointing to
http://www.doctrine-project.org/documentation/ * to their
http://docs.doctrine-project.org counterparts
2017-04-12 23:09:48 +02:00
Sergio Santoro
e798bfe34a
[QUERY] "INSTANCE OF" now behaves correctly with subclasses
...
There was a bug in the "INSTANCE OF" operator as described in
https://groups.google.com/forum/#!topic/doctrine-user/B8raq8CNMgg
"INSTANCE OF" was not taking into account subclasses.
It was merely translating the class to its discriminator.
This is not correct since the class can have subtypes and those
are, indeed, still instance of the superclass.
Also, classes may not have a discriminator (e.g. abstract classes).
This commit also provides useful tests to avoid regression.
2017-04-11 17:50:01 +02:00
mike
0865181702
Do not force an order of definition in the entity elements
2017-04-11 09:43:50 +02:00
mike
b43325760d
Add a type for the class FQCN
2017-04-11 09:43:31 +02:00
mike
f537eb2915
Add a table name type that accept quoted table name
2017-04-11 09:43:25 +02:00
chihiro-adachi
2c5e76c961
fix class name.
2017-04-07 14:33:41 +02:00
Marco Pivetta
03b4397557
Merge pull request #6378 from Sam-Burns/phpunit6
...
PHPUnit 6
2017-04-01 06:49:33 +02:00
Sam-Burns
3d7a7346f7
Quieting risky test warnings where tests do actually perform assertions
2017-03-31 23:23:22 +01:00
Sam-Burns
5bd7bd8d48
Updating to PHPUnit 6
2017-03-31 21:59:02 +01:00
Marco Pivetta
904f4d5021
Merge pull request #6377 from Sam-Burns/minimum-dependencies
...
Minimum dependencies
2017-03-31 20:46:14 +02:00
Sam-Burns
7aab261c24
Switching to a PHPUnit version that doesn't throw a stty-related PHP warning on Travis
2017-03-31 15:46:04 +01:00
Sam-Burns
f5b4e8c823
Specifying minimum version of doctrine/annotations with which tests pass
2017-03-31 15:24:07 +01:00
Sam-Burns
60cc11461d
Bumping doctrine/cache minimum version, to make tests pass
2017-03-31 15:07:53 +01:00
Sam-Burns
f2edf36248
Bumping doctrine/collections minimum version, to make tests pass
2017-03-31 15:07:53 +01:00
Sam-Burns
d6049f8631
Adding breaking build testing with minimum Composer dependencies
2017-03-31 15:07:29 +01:00
Adam Gąsowski
5507e0be29
Fix wrong variable name
...
Fix $fieldMapping to $embeddedClass in generateEmbeddedPropertyDocBlock
2017-03-23 19:12:40 +01:00
Marco Pivetta
1aa02f9afc
Merge pull request #6326 from SenseException/check-option
...
[Documentation] Add column check-option to documentation
2017-03-12 11:53:13 -04:00
Boris Yonchev
bd1efaf528
DDC-2780 - Fixed issue with IS NULL on join aliases
2017-03-07 18:34:50 +01:00
Claudio Zizza
504e701020
Add existing column check-option to documentation
2017-03-06 00:34:18 +01:00
Marco Pivetta
e4704beaf9
Merge pull request #6287 from lcobucci/fix-test-suite
...
Fix EntityManagerDecorator tests
2017-02-13 01:46:01 +01:00
Luís Cobucci
dcc80af7d9
Fix EntityManagerDecorator tests
...
We were expecting a return value for all methods but on 6a56df9a24
we changed some methods to be void and of course that affected the
ORM.
2017-02-12 18:38:21 +01:00
Marco Pivetta
10935dd843
Merge pull request #6285 from svencan/doc-typos
...
Fix typos and wording in NamingStrategy documentation
2017-02-10 18:55:05 +01:00
Sven Cannivy
260c8d0113
Fix typos and wording in NamingStrategy documentation
2017-02-10 18:48:57 +01:00
Marco Pivetta
23ae83e351
Merge pull request #6268 from enumag/patch-4
...
Fix annotation
2017-01-31 12:00:42 +01:00
Jáchym Toušek
64ab53a243
Fix annotation
2017-01-31 11:57:01 +01:00
mikeSimonson
e42d0bdda5
Merge pull request #6262 from mikeSimonson/doc
...
Fix a link to a ref in another page
2017-01-27 09:30:38 +01:00
mike
f3df000d29
Fix a link to a ref in another page
2017-01-27 09:27:25 +01:00
mikeSimonson
5989ea1752
Merge pull request #6260 from mikeSimonson/doc
...
Document the Custom option of the generated value annotation
2017-01-26 14:12:34 +01:00
Marco Pivetta
888f1be7c9
Merge pull request #6257 from weaverryan/add-criteria-note
...
Adding a note about the `Doctrine\ORM\QueryBuilder#addCriteria()` method
2017-01-25 16:56:12 +01:00
Ryan Weaver
63bd6c359c
[Docs] Adding a note about the addCriteria method on QueryBuilder
2017-01-25 10:52:17 -05:00
mike
773af5b306
Document the Custom option of the generated value annotation
2017-01-25 15:54:03 +01:00
Marco Pivetta
9c76c3766f
Merge pull request #6251 from mbeccati/ddc2660-test-fix
...
Add missing group to DDC2660Test.php
2017-01-24 13:43:59 +01:00
Matteo Beccati
c816d375e8
Add missing group to DDC2660Test.php
...
With the current PHPUnit version and PHP 7.2/master, the test fails with:
1) Doctrine\Tests\ORM\Functional\Ticket\DDC2660Test::testIssueWithExtraColumn
array_flip(): Can only flip STRING and INTEGER values!
2) Doctrine\Tests\ORM\Functional\Ticket\DDC2660Test::testIssueWithoutExtraColumn
array_flip(): Can only flip STRING and INTEGER values!
Due to the group being NULL vs "" on older PHP versions.
I will also file a bug report or fix to PHPUnit and/or PHP itself, but it sounds
like the missing group was just a typo.
2017-01-24 12:46:19 +01:00
Marco Pivetta
b181228d69
Merge pull request #6250 from johndodev/patch-1
...
Note on Entity listeners
2017-01-23 09:57:58 +01:00
John
57f560401b
Note on Entity listeners
...
As requested here https://github.com/doctrine/doctrine2/issues/6247#issuecomment-274123780 I thought it should be interesting to note that.
The note could be longer, like "You should avoid to have multiple methods for the same event (e.g. multiple @PrePersist) since the execution order is not guaranteed".
2017-01-23 09:35:26 +01:00
Luís Cobucci
119aa4e46c
Merge pull request #6244 from lcobucci/l2c-ensure-root-classname-everywhere
...
Make sure we're using the rootEntityName on all places
2017-01-20 00:05:48 +01:00
Luís Cobucci
1f53afa9cd
Make sure we're using the rootEntityName on all places
...
Otherwise we might end up with duplicated cache entries and weird
results (specially regarding associations).
2017-01-19 17:24:47 +01:00
Luís Cobucci
4f28aaa206
Refactor to use class_map() instead
2017-01-16 23:22:52 +01:00
Mikhail Polyanin
bb943afabe
Optimization. Multiple get in QueryCache
2017-01-16 23:02:23 +01:00
mikeSimonson
247b085fce
Merge pull request #6239 from mikeSimonson/travis-update
...
Travis update
2017-01-16 18:17:36 +01:00
mike
5968b9e62f
Removing php 7.1 from the allowed failure
2017-01-16 17:09:49 +01:00
mike
a831bb82ce
Adding hhvm as allowed to fail in the test matrix
2017-01-16 17:08:47 +01:00
Marco Pivetta
41a377948b
Documenting BC Break introduced by the removal of Doctrine\ORM\Query\SqlWalker#walkCaseExpression()
...
Ref: https://github.com/doctrine/doctrine2/pull/5600
2017-01-15 23:56:44 +01:00
Marco Pivetta
09cbb9ff48
Merge pull request #5600 from billschaller/remove-dead-code-walk-case-expression
...
Remove dead code SQLWalker::walkCaseExpression
2017-01-15 23:52:38 +01:00
Marco Pivetta
730db5fd2e
Merge pull request #6232 from gadelkareem/patch-3
...
Allow gearman env vars
2017-01-14 01:18:13 +01:00
Marco Pivetta
3d7ddc89b4
Merge pull request #6231 from gadelkareem/patch-2
...
Allow gearman environment vars
2017-01-14 01:15:46 +01:00
Waleed Gadelkareem
109ac5f827
Allow gearman env vars
2017-01-13 18:11:10 +01:00
Waleed Gadelkareem
d137ffe0a4
Allow gearman environment vars
2017-01-13 18:09:36 +01:00
Marco Pivetta
31c40f8342
Merge pull request #6216 from malukenho/enhancement/remove-unused-param
...
Remove unused "$className" argument
2017-01-12 17:04:01 +01:00
Jefersson Nathan
5208187f1a
rewording upgrade sentence
2017-01-12 13:02:10 -03:00
Marco Pivetta
9e35d9712d
Merge pull request #6227 from ThomasLandauer/patch-3
...
Minor formatting improvements
2017-01-12 16:13:59 +01:00
Thomas Landauer
4fccf84c82
Added link
...
Sorry, I don't know how to link to the exact section 8.8
2017-01-12 14:23:55 +01:00
Thomas Landauer
38636e7db4
Minor formatting improvements
...
Numbered lists aren't displayed nicely, see e.g. http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/reference/working-with-associations.html#persistence-by-reachability-cascade-persist - is this a rendering bug?
2017-01-12 13:59:24 +01:00
Thomas Landauer
63e4eea9e2
Complete re-write of "Transitive persistence / Cascade Operations" ( #6219 )
...
Follow-up of https://github.com/doctrine/doctrine2/pull/6171
2017-01-12 12:49:46 +01:00
Jefersson Nathan
df5f480b4c
document change as minor BC Break
2017-01-11 17:35:28 -03:00
Marco Pivetta
4e304df495
Merge pull request #6223 from lcobucci/fix-l2c-region-namespace
...
Appends cache namespace when it exists (for L2C regions)
2017-01-11 11:33:41 +01:00
Luís Cobucci
eaedc37d7b
Fix alignment issues on DefaultCacheFactoryTest.php
2017-01-11 11:04:43 +01:00
Luís Cobucci
5a562b3571
Appends cache namespace when it exists (for L2C regions)
...
We're overriding the namespace without even checking if it was previously
set, what causes problems when people uses that feature 😉
2017-01-11 11:01:39 +01:00
Marco Pivetta
4e573038be
Merge pull request #6220 from enumag/patch-2
...
Fix annotations
2017-01-10 12:50:39 +01:00
Jáchym Toušek
617ec9219e
Fix annotations
2017-01-10 09:12:18 +01:00
Marco Pivetta
ce4abdea55
Merge pull request #6171 from ThomasLandauer/patch-3
...
Include example of a cascaded "persist" operation
2017-01-09 14:08:31 +01:00
Thomas Landauer
7c168c2047
Update working-with-associations.rst
...
As requested: https://github.com/doctrine/doctrine2/pull/6171#pullrequestreview-15695400
2017-01-09 14:07:17 +01:00
Marco Pivetta
145c44630e
Merge pull request #6215 from malukenho/doc/#2190-add-link
...
Added link to `Transitive Persistence`
2017-01-05 22:22:07 +01:00
Jefersson Nathan
eaeecc3857
Remove unused arguments
2017-01-05 18:21:49 -03:00
Jefersson Nathan
f570eb5922
#2190 — Refer link to proper section and links more occurrence from Transitive Persistence
2017-01-05 12:46:01 -03:00
Jefersson Nathan
a1839048dd
#2190 — added link to Transitive Persistence
2017-01-05 11:48:16 -03:00
Luís Cobucci
c86865aa71
Merge pull request #6212 from malukenho/hotfix/#1808-fix-sql-example
...
Fix wrong DQL example
2017-01-04 07:34:18 +01:00
Jefersson Nathan
8b499a4791
#1808 — Fix wrong DQL example
2017-01-03 21:37:07 -03:00
Marco Pivetta
06691e0150
Merge pull request #6207 from gabidavila/master
...
Documentation: Fixes missing namespaces on class call
2017-01-02 19:40:44 +01:00
gabidavila
fc8ede844d
Fixes missing namespaces on class call
2017-01-02 16:11:46 -02:00
Marco Pivetta
443902f9f9
Merge pull request #6205 from railto/master
...
Remove support for PHP 5.x
2017-01-02 09:42:07 +01:00
Mark Railton
563c79bd80
Removes support for PHP 5.x
2017-01-02 08:36:42 +00:00
Marco Pivetta
d0c3f961ef
Merge pull request #6204 from alcohol/rip-5.6
...
rip 5.6
2017-01-02 09:28:08 +01:00
Rob Bast
a8d7b327ef
rip 5.6
2017-01-02 09:27:34 +01:00
Marco Pivetta
c24a89f4a3
Merge pull request #6197 from BenMorel/patch-2
...
getSingleScalarResult() returns NULL when the query yields no results
2016-12-26 04:41:20 +01:00
Benjamin Morel
3ce833fb62
getSingleScalarResult() returns NULL when the query yields no results
...
`NoResultException` is not thrown in this case.
2016-12-26 02:11:50 +01:00
Thomas Landauer
f3909ae885
Update working-with-associations.rst
2016-12-23 20:09:25 +01:00
Marco Pivetta
22b5fb1ad4
Merge pull request #6179 from biggianteye/getting-started-fixes
...
Minor fixes to the 'getting started' page
2016-12-23 04:03:05 +01:00
Burhan Ali
f64d543d0c
Add minor fixes to the 'getting started' page
2016-12-19 03:34:51 +00:00
Thomas Landauer
eecf4382b0
Update working-with-associations.rst
2016-12-18 23:05:10 +01:00
Thomas Landauer
a8a3a8c9e7
Update working-with-associations.rst
2016-12-18 21:58:44 +01:00
Thomas Landauer
1a8eeacfba
Update working-with-associations.rst
2016-12-18 21:42:08 +01:00
Marco Pivetta
cd1a5fcadc
Merge pull request #6177 from doctrine/fix/#6174-#5570-merging-new-entities-should-also-trigger-prepersist-lifecycle-callbacks
...
Fix #6174 #5570 : merging new entities should also trigger prepersist lifecycle callbacks with merged entity data
2016-12-18 16:42:44 +01:00
Marco Pivetta
21a5d8ca1b
#6174 #5570 removed modifications applied to the CompanyContractListener, since UnitOfWorkTest now completely encapsulates the scenarios being covered
2016-12-18 15:48:10 +01:00
Marco Pivetta
cfd595b699
#6174 #5570 removed unused imports
2016-12-18 15:46:49 +01:00
Marco Pivetta
018a5db08f
#6174 #5570 renamed entity for better fitting the use-cases it's in
2016-12-18 15:46:34 +01:00
Marco Pivetta
f39f1a2e11
#6174 #5570 removed unused test class
2016-12-18 15:45:03 +01:00
Marco Pivetta
262d13a047
#6174 #5570 adding group annotations to newly introduced test
2016-12-18 15:44:48 +01:00
Marco Pivetta
f4595d3a2f
#6174 #5570 prePersist listeners should never be called when entities are merged, but are already in the UoW
2016-12-18 15:43:29 +01:00
Marco Pivetta
30cd2d172b
#6174 #5570 started moving tests around prePersist event subscriber triggering on UnitOfWork into the UnitOfWorkTest
2016-12-18 15:37:49 +01:00
Marco Pivetta
9582ffc982
#6174 #5570 CS fixes around the EntityListenersOnMergeTest
2016-12-18 14:53:54 +01:00
Marco Pivetta
00c67ba2db
#6174 #5570 adding group annotation to newly introduced tests
2016-12-18 14:47:55 +01:00
Marco Pivetta
0c2edcd08a
#6174 #5570 CS - spacing/variable naming
2016-12-18 14:47:16 +01:00
Marco Pivetta
a22f165026
#6174 #5570 removed unused/dead code
2016-12-18 14:45:08 +01:00
Marco Pivetta
ab0e854830
#6174 #5570 CS - spacing
2016-12-18 14:39:46 +01:00
Marco Pivetta
85e2dc8f22
#6174 #5570 CS - spacing
2016-12-18 14:38:10 +01:00
Marco Pivetta
3ce262a61a
#6174 #5570 flattened nested conditionals
2016-12-18 14:36:39 +01:00
Marco Pivetta
81d44d4d6e
#6174 #5570 documenting thrown exception types
2016-12-18 14:32:31 +01:00
Marco Pivetta
754f36ef65
#6174 #5570 CS - alignment
2016-12-18 14:27:35 +01:00
bilouwan
1be226cf63
Rename test
2016-12-15 15:12:29 +01:00
bilouwan
7f4de25a26
Cherry pick unit test from PR #5570 (Fix PrePersist EventListener when using merge instead of persist)
2016-12-15 13:03:53 +01:00
bilouwan
493d39f5df
doMerge will mergeEntityStateIntoManagedCopy BEFORE persistNew to let lifecyle events changes be persisted
2016-12-15 12:49:11 +01:00
bilouwan
d1c8d378cf
Create failing test to reveal the issue
2016-12-15 12:47:45 +01:00
Thomas Landauer
879d4e7df0
Update working-with-associations.rst
2016-12-14 21:46:18 +01:00
Thomas Landauer
29062fb42e
Update working-with-associations.rst
2016-12-14 21:39:47 +01:00
Thomas Landauer
a06f8d4759
Update working-with-associations.rst
2016-12-14 21:38:10 +01:00
Thomas Landauer
6aa81d1d36
Include example of a cascaded "persist" operation
...
Following up on https://github.com/doctrine/doctrine2/issues/2943 I started to clarify how it's supposed to be done.
Please check if this would be necessary (at line 511):
`$myFirstComment->setUser($user);`
...and add it (in case).
2016-12-14 00:10:39 +01:00
Marco Pivetta
6e6be3fdd9
Merge pull request #6164 from eyepin/patch-1
...
Update EntityGenerator.php
2016-12-12 08:30:16 +01:00
Marco Pivetta
24377156b4
Merge pull request #6166 from lcobucci/use-php56-features
...
Normalise codebase with PHP 5.6 features
2016-12-12 08:03:43 +01:00
Luís Cobucci
ba9fecc43f
Remove commented code that seems to not be important
2016-12-08 18:16:11 +01:00
Luís Cobucci
62d122bd54
Remove old "CLASSNAME" constants from test models
2016-12-08 18:15:48 +01:00
Luís Cobucci
fda6fdd9fb
Use "::class" syntax on "tests" directory
2016-12-08 18:13:39 +01:00
Luís Cobucci
512aa8a3c7
Use "::class" syntax on "lib" directory
2016-12-08 17:09:35 +01:00
Luís Cobucci
234989d069
Use short-array syntax on "lib" directory
2016-12-08 00:31:12 +01:00
Luís Cobucci
c609072ce1
Use short-array syntax on "bin" directory
2016-12-07 23:34:14 +01:00
Luís Cobucci
74c8a08828
Use short-array syntax on "tests" directory
2016-12-07 23:33:41 +01:00
Luís Cobucci
1d5e16e9d9
Use short-array syntax on "tools" directory
2016-12-07 23:32:17 +01:00
eyepin
521588f498
Update EntityGenerator.php
...
orm:generate:entities genrates 2 blank lines
PSR2: All PHP files MUST end with a single blank line.
this worked for me
2016-12-07 13:13:21 +01:00
Marco Pivetta
6af1d2843f
Bumping doctrine/common dependency to allow ^2.7.1
2016-12-04 06:55:26 +01:00
Marco Pivetta
555e8ae641
Merge branch 'fix/#6017-check-entity-name-in-clear-call-should-be-a-string'
...
Close #6017
2016-11-27 18:39:55 +01:00
Marco Pivetta
dc3b166811
#6017 replaced random_int() with rand(), since we still support oldstable PHP (5.6.x)
2016-11-27 18:38:57 +01:00
Marco Pivetta
44a6141235
#6017 removed clear($entityName) tests from UnitOfWorkTest: now covered in EntityManagerTest
2016-11-27 18:37:45 +01:00
Marco Pivetta
53c5824a6b
#6017 removed clear($entityName) parameter validity checks
...
The `UnitOfWork` is advanced stuff: don't touch if you don't know what you are doing.
2016-11-27 18:37:45 +01:00
Marco Pivetta
1d7397caf0
#6017 moving entity name validity checks into the EntityManager API, documenting newly thrown exception types
2016-11-27 18:37:45 +01:00
Marco Pivetta
92274124f9
#6017 moving tests around clear() into the EntityManager tests
...
`UnitOfWork` assumptions are OK, since we don't want to clutter the API even more down there
2016-11-27 18:37:45 +01:00
Marco Pivetta
49333867f8
FQCN reference correction
2016-11-27 18:36:49 +01:00
Marco Pivetta
9894dcb4b0
#6017 clear($proxyClassName) should behave like clear($realClassName)
2016-11-27 18:36:49 +01:00
Marco Pivetta
fdb2af07e7
#6017 hardened clear() logic, which now ensures that persisted entries are correctly cleared
2016-11-27 18:36:49 +01:00
Marco Pivetta
dffd765b1e
#6017 requesting clear('nonExistingEntityName') now raises a MappingException
2016-11-27 18:36:48 +01:00
Marco Pivetta
c1038096e0
#6017 requesting clear('nonExistingEntityName') should raise a MappingException
2016-11-27 18:36:48 +01:00
Marco Pivetta
8f77afdc34
#6017 removed unused ORMException::invalidEntityName
2016-11-27 18:36:48 +01:00
Marco Pivetta
754e1f5d42
#6017 throwing an ORMInvalidArgumentException when clearing with non-string data. Also removing duplicate null checking
2016-11-27 18:36:48 +01:00
Marco Pivetta
c97799f151
#6017 expecting an ORMInvalidArgumentException when clearing with invalid data
2016-11-27 18:36:48 +01:00
Marco Pivetta
56598596a4
#6017 adding @group annotation to newly introduced tests
2016-11-27 18:36:48 +01:00
Marco Pivetta
6ad9c9ea04
#6017 test coverage for ORMInvalidArgumentException::invalidEntityName
2016-11-27 18:36:48 +01:00
Marco Pivetta
c4d41fe56a
#6017 moved ORMException::invalidEntityName to ORMInvalidArgumentException::invalidEntityName
2016-11-27 18:36:48 +01:00
Jeremy Benoist
6b1d64d484
Remove unecessary persist in tests
2016-11-27 18:36:48 +01:00
Jeremy Benoist
be4aafd4f6
Use ORMException instead of a default exception
2016-11-27 18:36:48 +01:00
Jeremy Benoist
2a7d21ad18
Throw an exception instead of a workaround
2016-11-27 18:36:48 +01:00
Jeremy Benoist
4a87f00fab
Avoid error when entityName isn't a string
2016-11-27 18:36:48 +01:00
Marco Pivetta
77a338e0fd
Merge branch 'fix/#5935-#5684-#6020-#6152-id-generator-convert-to-custom-dbal-id-type'
...
Close #5935
Close #5684
Close #6020
Close #6152
2016-11-27 17:49:54 +01:00
Marco Pivetta
cff5c07014
#5935 #5684 #6020 #6152 removed useless NAME constant from the test
2016-11-27 17:49:09 +01:00
Marco Pivetta
73ea0ba8f3
#5935 #5684 #6020 #6152 adding description to the test scenario
2016-11-27 17:45:50 +01:00
Marco Pivetta
e736d19677
#5935 #5684 #6020 #6152 extracted identifier conversion to a private method
2016-11-27 17:42:12 +01:00
Christian Hammerl
0a86c324ad
Add test case for autoincremented id of custom type
2016-11-27 01:45:56 +01:00
Renan Gonçalves
52badf1cdd
Convert generated id value to its PHP representation.
...
According to the conversion rules of a specific DBAL mapping type.
2016-11-27 01:43:50 +01:00
Marco Pivetta
4c59ec9282
Merge pull request #5834 from ismailbaskin/patch-1
...
Fix custom-id-generator class attribute type
2016-11-26 07:04:02 +01:00
Marco Pivetta
dc7c6ed72c
Merge pull request #5897 from mikaelz/patch-1
...
Check for Xcache from INI setting
2016-11-26 06:48:55 +01:00
Marco Pivetta
28025b8230
Merge branch 'cleanup/#5914-cleanup-sql-walker-code'
...
Close #5914
2016-11-26 06:45:16 +01:00
Marco Pivetta
0ed18fb062
#5914 removed unused conditional inside EntityGenerator, replaced with array_filter() instead
2016-11-26 06:44:53 +01:00
Marco Pivetta
5d477cdbbc
#5914 ClassMetadataInfo#$lifecycleCallbacks is a multi-dimensional array
2016-11-26 06:42:46 +01:00
ReenExe
b2f5da19a4
clear code
2016-11-26 06:40:56 +01:00
ReenExe
401300b295
decrease nested if
2016-11-26 06:40:56 +01:00
ReenExe
12465e08ad
agree with scrutinizer
2016-11-26 06:40:32 +01:00
Marco Pivetta
89a00860e4
Merge branch 'fix/#6068-docblock-entity-generation-for-nullable-types'
...
Close #6068
2016-11-26 06:35:33 +01:00
Marco Pivetta
f8002ca27e
#6068 hardened test logic to verify that nothing is present after the |null in @var and @return types
2016-11-26 06:35:23 +01:00
Marco Pivetta
a4f76bda34
#6068 corrected nullable field expression generator, made it private to avoid misuse
2016-11-26 06:26:53 +01:00
Marco Pivetta
1d2baedfd5
#6068 simplified variable docblock codegen for nullable instance properties
2016-11-26 06:22:25 +01:00
Marco Pivetta
3341781f52
#6068 inlined code generating expression
2016-11-26 06:20:12 +01:00
Javier Spagnoletti
1dfadef221
Removed surplus semicolon at EntityGenerator::generateFieldMappingPropertyDocBlock()
2016-11-26 06:12:31 +01:00
Javier Spagnoletti
ad6469b64a
Update tests
2016-11-26 06:12:31 +01:00
Javier Spagnoletti
087d081601
Fix CS
2016-11-26 06:12:31 +01:00
Javier Spagnoletti
d3c604567b
Update docblock generation for nullable fields
2016-11-26 06:12:31 +01:00
Marco Pivetta
c148059593
Merge branch 'fix/#6110-collection-clear-should-also-clear-keys'
...
Close #6110
2016-11-26 06:06:59 +01:00
Marco Pivetta
20190605a0
#6110 CS (whitespace removal)
2016-11-26 06:06:49 +01:00
Marco Pivetta
9acf170292
#6110 split test into multiple sub-scenarios involving PersistentCollection key checking
2016-11-26 06:02:16 +01:00
Steevan BARBOYON
fa09a95023
Clear $this->collection even when empty, to reset indexes
2016-11-26 05:57:56 +01:00
Marco Pivetta
b06dcb89b3
Merge pull request #5947 from alexryderwhytewaters/patch-1
...
Missing `ClassMetadataExporter` instantiation in the reverse engineering code samples
2016-11-26 05:47:34 +01:00
Marco Pivetta
f11697361d
Merge pull request #5948 from Michal-sk/patch-1
...
Update association-mapping.rst to ease understanding of what associations mean
2016-11-26 05:46:39 +01:00
Marco Pivetta
a9c2778f30
Merge pull request #6085 from arjank/fix/Call_correct_method_in_test
...
More specific named native query throw exceptions test
2016-11-26 05:28:28 +01:00
Marco Pivetta
be1fd130f1
Merge pull request #6025 from ywarnier/ywarnier-patch-1
...
Fix typo in batch-processing doc
2016-11-26 05:26:20 +01:00
Marco Pivetta
a9230b8546
Merge branch 'cleanup/#5987-code-simplifications'
...
Close #5987
2016-11-26 05:25:01 +01:00
Marco Pivetta
3cd7b8c951
#5987 CS: spacing after ! (not) operator
2016-11-26 05:23:04 +01:00
Marco Pivetta
24da9061b9
#5987 inlined check for boolean 'true' literal
2016-11-26 05:22:43 +01:00
Javier Spagnoletti
e2b198112e
[minor] Add missing type hints, add strictness for some checks, remove some useless calls
2016-11-26 05:18:46 +01:00
Marco Pivetta
e7f2e35383
Merge pull request #5977 from gadelat/cleanup-1
...
Remove unneeded ternary operator from Query::contains
2016-11-26 05:05:37 +01:00
Marco Pivetta
979fede80c
Merge pull request #6038 from ReenExeContributor/cleanup-UnitOfWork
...
remove excess `check`
2016-11-26 04:59:16 +01:00
Marco Pivetta
8c38f5775d
Merge pull request #6121 from kalessil/sca
...
Static Code Analysis with Php Inspections (EA Extended)
2016-11-26 04:57:48 +01:00
Marco Pivetta
899393d3bb
Merge pull request #6142 from mbeccati/php72-count-fix
...
Fix incompatibility w/ PHP7.2+
2016-11-26 04:56:39 +01:00
Marco Pivetta
bfa9a31ad7
Merge pull request #6145 from lcobucci/improve-test-documentation
...
Improving the documentation of enums as discriminators test
2016-11-23 19:35:20 +01:00
Luís Cobucci
6344fd34cb
Improving the documentation of enums as discriminators test
...
@Ocramius was too eager to merge stuff
Related to: https://github.com/doctrine/doctrine2/pull/6141
2016-11-23 19:20:47 +01:00
Marco Pivetta
7789df39c5
Merge pull request #6141 from lcobucci/object-as-discriminators
...
Allow using objects as discriminators
2016-11-23 19:14:53 +01:00
Luís Cobucci
1b39cd87ad
Allow using objects as discriminators
2016-11-23 18:56:36 +01:00
Marco Pivetta
86fd0c5aa9
Merge pull request #6028 from lcobucci/fix/l2c-inheritance-query-cache
...
Make child entity share the timestamp region with parent class
2016-11-23 18:06:52 +01:00
Matteo Beccati
39dcf3e4c6
Fix incompatibility w/ PHP7.2+
...
Mock_ParserResult_*::getParameterMappings() was returning null, which
was then passed to count() on Query.php:308, causing a "Parameter must
be an array or an object that implements Countable" error.
2016-11-22 07:42:06 +01:00
Luís Cobucci
317e86802d
Make child entity share the timestamp region with parent class
2016-11-20 19:27:53 +00:00
Marco Pivetta
95d9c64aec
Merge pull request #6138 from WhiteEagle88/version-docs
...
Added examples for version column in the xml and yml formats
2016-11-19 23:04:47 +01:00
Dmytro Boiko
53cd9c4ca8
Added examples for version column in the xml and yml formats
2016-11-19 23:34:10 +02:00
Marco Pivetta
e7856f90d8
Merge branch 'feature/#6136-better-exception-message-on-invalid-connection-object'
...
Close #6136
2016-11-18 09:21:18 +01:00
Marco Pivetta
d2643eeb8b
#6136 Removed regex assertion - constant assertion is sufficient
2016-11-18 09:19:27 +01:00
SpacePossum
e37041aa94
Update message.
2016-11-18 08:06:11 +01:00
Marco Pivetta
f1bf045af3
Merge pull request #6130 from kalimatas/fix-xml-option-boolean
...
#6129 Added unit test for boolean option values.
2016-11-17 21:24:44 +01:00
Alexander Guz
8d433cdb39
#6129 Fixed code style and @depends in test.
2016-11-17 21:05:58 +01:00
SpacePossum
f9a605f6ca
Add details about invalid Connection passed at creation.
2016-11-17 17:23:22 +01:00
Alexander Guz
7bf206adb4
#6129 Moved test to AbstractMappingDriverTest.
2016-11-16 20:01:11 +01:00
Alexander Guz
8580f02c6a
#6129 Use User::class to get metadata instead of string.
2016-11-16 18:07:58 +01:00
Alexander Guz
cdf4af5f27
Added unit test for boolean option values.
...
It fail now. In `XmlDriver::_parseOptions` we need somehow to maintain
a list of options, that are supposed to be boolean, and then call
`$this->evaluateBoolean()` on them.
2016-11-16 17:56:07 +01:00
Marco Pivetta
05e77868ab
Merge pull request #6120 from mschroeder/patch-3
...
Fixed typos regarding the strategy for composite keys (xml mapping)
2016-11-06 18:50:00 +01:00
Vladimir Reznichenko
db375a22cc
Static Code Analysis with Php Inspections (EA Extended): revert unsets
2016-11-06 17:58:45 +01:00
Vladimir Reznichenko
0bf3d7f84c
Static Code Analysis with Php Inspections (EA Extended)
2016-11-06 14:22:47 +01:00
Martin Schröder
155672af40
Fixed typos regarding the strategy for composite keys (xml mapping reference)
...
The strategy for composite primary keys must be "NONE" although the id generator class is \Doctrine\ORM\Id\AssignedGenerator. Calling the strategy "ASSIGNED" is misleading.
2016-11-06 14:05:50 +01:00
Marco Pivetta
bd58e4de4f
Merge pull request #6119 from mschroeder/patch-2
...
Fixed typo regarding the id generator mandatory for composite keys
2016-11-06 13:38:50 +01:00
Martin Schröder
3e98fdb082
Fixed typo regarding the id generator mandatory for composite primary keys
...
The strategy for composite primary keys must be "NONE" although the id generator class is \Doctrine\ORM\Id\AssignedGenerator. Calling the strategy "ASSIGNED" is misleading.
2016-11-06 13:37:07 +01:00
Marco Pivetta
3b6309318b
Merge pull request #6014 from photodude/patch-1
...
As of HHVM 3.15 pgsql is supported, add php 7.1 to tests
2016-11-05 10:03:49 +01:00
mikeSimonson
60a967bb1d
Merge pull request #6113 from mikeSimonson/master
...
Fix documentation
2016-11-03 21:10:41 +01:00
mike
b8b5c2d686
Merge branch 'master' of github.com:doctrine/doctrine2
2016-11-03 20:42:59 +01:00
mike
11c2d815ef
Correcting a use statment in the documentation
2016-11-03 20:40:48 +01:00
Marco Pivetta
56741a3fee
Merge pull request #6063 from kormik/patch-1
...
Fix PHP version in readme.
2016-10-27 02:11:19 +02:00
Marco Pivetta
c8df209409
Merge pull request #6065 from adiq/patch-1
...
Update Autoloader namespace [docs]
2016-10-27 02:10:43 +02:00
Marco Pivetta
fb95116a26
Merge pull request #6101 from malukenho/add-license-checker
...
Add license checker to the build
2016-10-27 01:16:18 +02:00
Jefersson Nathan
83da3d4b04
Revert "composer require --dev malukenho/docheader"
...
This reverts commit 81fefb40db .
2016-10-26 13:27:38 -03:00
Jefersson Nathan
5c6ecdcf1b
Revert "add license template file"
...
This reverts commit e4050edb4e .
2016-10-26 13:27:29 -03:00
Jefersson Nathan
dc07fc609e
Revert "add license checker to the build"
...
This reverts commit ca1a9473d3 .
2016-10-26 13:27:18 -03:00
Jefersson Nathan
dbe843fc4b
remove license from header of test files
2016-10-26 13:24:33 -03:00
Jefersson Nathan
b8a18cd0a1
fix license header inconsistencies
2016-10-25 23:58:42 -03:00
Jefersson Nathan
ca1a9473d3
add license checker to the build
2016-10-25 23:53:17 -03:00
Jefersson Nathan
e4050edb4e
add license template file
2016-10-25 23:52:07 -03:00
Jefersson Nathan
81fefb40db
composer require --dev malukenho/docheader
2016-10-25 23:51:31 -03:00
Marco Pivetta
26cf90e1c5
Merge pull request #6095 from mschroeder/patch-1
...
Fixed typo in annotations reference
2016-10-25 05:56:54 +02:00
Marco Pivetta
cf1ba3183d
Merge pull request #6089 from damour/master
...
Remove duplicated enum type comment from declaration.
2016-10-25 05:48:57 +02:00
Garanzha Dmitriy
3861cbf317
Remove duplicated enum type comment from declaration.
2016-10-21 11:30:27 +03:00
Martin Schröder
cdad5a82c5
Fixed typo in annotations reference
2016-10-20 13:32:59 +02:00
Marco Pivetta
d6eddab94f
Revert "Merge pull request #6092 from ThomasLandauer/patch-2"
...
This reverts commit ade3f3a7f3 , reversing
changes made to a6e44d9305 .
2016-10-18 10:00:10 -07:00
Marco Pivetta
ade3f3a7f3
Merge pull request #6092 from ThomasLandauer/patch-2
...
Updated a link (hopefully :-)
2016-10-18 09:46:53 -07:00
Thomas Landauer
d3c2c40452
Updated a link (hopefully :-)
2016-10-18 18:21:46 +02:00
Marco Pivetta
a6e44d9305
Merge pull request #6087 from chihiro-adachi/fix-namespace
...
Fix namespace
2016-10-18 07:12:22 -07:00
chihiro-adachi
42c4938a8b
cache -> cached
2016-10-18 12:09:43 +09:00
chihiro-adachi
fb1136cc9a
adjust the appearance of the table
2016-10-15 15:47:49 +09:00
chihiro-adachi
03da85e19e
fix namespace
2016-10-15 15:41:10 +09:00
Arjan
a4379cc9e2
Fixes named native query test
...
- Makes sure the correct method is called in the test
- Verifies that the correct method is called by checking the exception message
2016-10-13 22:54:32 +02:00
Marco Pivetta
a353cb81a3
Merge pull request #6080 from ThomasLandauer/patch-1
...
Fixed typo + added link
2016-10-11 17:02:07 +02:00
Thomas Landauer
277833b487
Fixed typo + added link
2016-10-11 16:59:03 +02:00
Marco Pivetta
47cb963731
Merge pull request #6070 from Dreamlex/master
...
Update events.rst
2016-10-06 02:40:04 +02:00
alexndlm
fc81760b54
Update events.rst
...
https://github.com/doctrine/doctrine2/pull/169
2016-10-05 14:16:47 +03:00
Adrian Zmenda
96b3797ad6
Update Autoloader namespace
2016-10-03 12:25:49 +02:00
Tomas Kormanak
974a9f4b9e
Fix PHP version in readme.
2016-10-02 22:38:40 +02:00
ReenExe
2ee56a595b
remove excess check
2016-09-15 19:41:34 +03:00
Yannick Warnier
05db15f7ee
Fix typo in batch-processing doc
...
See http://www.dictionary.com/misspelling?term=apparant&s=t
2016-09-12 12:22:49 -05:00
Marco Pivetta
cd11723e63
Merge branch 'fix/#5768-#5755-clone-proxy-private-properties-in-multi-level-inheritances'
...
Close #5768
Close #5755
2016-09-10 20:51:27 +02:00
Marco Pivetta
3fca33bdc4
#5768 #5755 cleaned up test scenario, using new mocking logic as per PHPUnit 5.4+
2016-09-10 20:45:01 +02:00
Ed Hartwell Goose
67e205b36a
Fixes #5755 , uses '->getReflectionProperties()' instead of '->getReflectionClass()->getProperties()' to ensure all fields are copied, and adds test to confirm behaviour
2016-09-10 20:37:20 +02:00
Marco Pivetta
22105058fa
Merge branch 'fix/#5689-avoid-object-hash-conflicts-due-to-merge-operations'
...
Close #5689
2016-09-10 20:22:52 +02:00
Marco Pivetta
503b211a22
#5689 removed unused reflection access
2016-09-10 20:19:15 +02:00
Marco Pivetta
f8436b2165
#5689 removed OidReuseTest, which was moved to UnitOfWork tests
2016-09-10 20:15:59 +02:00
Marco Pivetta
75bf197e11
#5689 moved OidReuseTest contents into the UnitOfWork tests
2016-09-10 20:15:33 +02:00
Walt Sorensen
99d704ff45
Drop mariadb: 5.5 tests
...
reorder matrix so all HHVM tests are at the bottom
2016-09-10 12:15:25 -06:00
Walt Sorensen
29f51b4a26
Remove the last hhvm3.15 tag
2016-09-09 18:00:40 -06:00
Walt Sorensen
1f521d26f3
Set to HHVM latest (currently 3.15 until next release)
...
Move sudo: false to the top line to be more clear about use of containers as default vs the trusty builds for HHVM
2016-09-09 17:21:03 -06:00
Walt Sorensen
fda2cd7d0e
Set all HHVM-3.15 to allowed failure
2016-09-09 15:59:23 -06:00
Walt Sorensen
a879811b6c
Fast finish to avoid waiting on allowed failures
...
Also Allow HHVM 3.15 with pgsql to fail
2016-09-09 15:51:34 -06:00
Walt Sorensen
e52ca954f0
fixing the xdebug error with php 7.1, nightly and HHVM-3.15
2016-09-09 15:42:31 -06:00
Walt Sorensen
d7a0ed0611
pin to HHVM 3.15 and add PHP 7.1
...
Stop testing against old HHVM 3.9 and test against current LTS 3.15
2016-09-09 15:35:33 -06:00
Mathieu De Zutter
44af69c5d2
Additional assertion to check that unreferenced objects are not in UOW.
2016-09-09 23:22:31 +02:00
Mathieu De Zutter
b8c7d871be
Remove old code in comments.
2016-09-09 23:22:31 +02:00
Mathieu De Zutter
01d51bfca3
Avoid conflicts due to spl_object_hash().
...
When merging an entity with a to-many association, it will store the
original entity data using the object hash of the to-be-merged entity
instead of the managed entity. Since this to-be-merged entity is not
managed by Doctrine, it can disappear from the memory. A new object
can reuse the same memory location and thus have the same object hash.
When one tries to persist this object as new, Doctrine will refuse it
because it thinks that the entity is managed+dirty.
This patch is a very naive fix: it just disables storing the original
entity data in case of to-many associations. It may not be the ideal
or even a good solution at all, but it solves the problem of object
hash reuse.
The test case relies on the immediate reusing of memory locations by
PHP. The variable $user has twice the same object hash, though referring
a different object. Tested on PHP 5.6.17
Without the fix, the test fails on the last line with:
A managed+dirty entity Doctrine\Tests\Models\CMS\CmsUser@[...] can not
be scheduled for insertion.
2016-09-09 23:22:31 +02:00
Walt Sorensen
48dcbe9d35
As of HHVM 3.15 pgsql is supported
2016-09-09 15:18:48 -06:00
Marco Pivetta
3e3bfbf6d8
Merge pull request #6013 from guhelski/fix_typo
...
Documentation - Fix typo
2016-09-09 21:31:41 +02:00
guhelski
60346e0046
Fix typo
2016-09-09 16:46:35 +02:00
Guilherme Blanco
81f4d3b0fb
Merge pull request #6011 from lcobucci/refactor/use-method-instead
...
Use `ClassMedatada#isIdGeneratorIdentity()` instead of constant to add the ID on query
2016-09-09 10:25:00 -04:00
Luís Cobucci
e43b9e9e3a
Use isIdGeneratorIdentity() to add the ID on query
...
It's quite handy when creating CUSTOM id generators that should also
rely on AUTO_INCREMENT stuff (one can just extend the `ClassMedatadaFactory`
and create a different instance of `ClassMetadata` that overrides that
method).
2016-09-09 07:52:44 +00:00
Marco Pivetta
e7e142ea4a
Merge pull request #6010 from phansys/entity_repo_count
...
Update exception message at `EntityRepository::__call()`
2016-09-08 19:21:06 +02:00
Javier Spagnoletti
5353137617
Update exception message at EntityRepository::__call()
2016-09-08 13:32:06 -03:00
Marco Pivetta
009e94720b
Merge branch 'fix/#6001-second-level-cache-query-cache-timestamp-from-region'
...
Close #6001
2016-09-08 14:02:16 +02:00
Marco Pivetta
d27cffa8e6
#6001 documenting minor BC break in QueryCacheEntry#time type - specific version used
2016-09-08 13:51:21 +02:00
Luís Cobucci
dd476094af
The timestamp verification is now done by the validator
...
So it's useless to keep it here too.
2016-09-08 13:50:06 +02:00
Luís Cobucci
b431332cef
Evict query cache when entities are updated
2016-09-08 13:50:06 +02:00
Luís Cobucci
b49026b657
Add timestamp key to QueryCacheKey
2016-09-08 13:50:06 +02:00
Luís Cobucci
16a3a2a132
Use microtime to have more precision on cache time
2016-09-08 13:50:06 +02:00
Marco Pivetta
5eebdcf630
Merge branch 'fix/#6004-#5989-fix-hydration-in-a-joined-inheritance-with-simple-array-or-json-array'
...
Close #6004
Close #5989
2016-09-08 13:39:10 +02:00
Carl Vuorinen
43d22984ae
Add unit test for SimpleObjectHydrator
2016-09-08 13:37:00 +02:00
Carl Vuorinen
d2cbd5e872
PR fixes (public properties & correct letter case in annotations)
2016-09-08 13:37:00 +02:00
Carl Vuorinen
00bbf4f523
Use yoda condition in the null check
2016-09-08 13:37:00 +02:00
Carl Vuorinen
95546d68c5
Fix hydration in a joined inheritance with simple array or json array
...
SimpleArrayType and JsonArrayType convert NULL value to an empty array, which fails the null check that is used to prevent overwrite
Fixes issue #5989
2016-09-08 13:37:00 +02:00
Carl Vuorinen
12b5e79ff2
Create a failing test for issue #5989
...
Field with type=simple_array in a joined inheritance gets overridden by empty array in the hydrator
2016-09-08 13:37:00 +02:00
Marco Pivetta
8a87fa2d01
Merge branch 'feature/#6003-count-on-repositories'
...
Close #6003
2016-09-08 00:56:34 +02:00
Marco Pivetta
c5c56a9dad
#6003 clarifying thrown exception
2016-09-08 00:55:49 +02:00
Marco Pivetta
36e9904082
#6003 inlined persister retrieval
2016-09-08 00:55:09 +02:00
Marco Pivetta
e2cba87662
#6003 corrected return type definition
2016-09-08 00:54:49 +02:00
Marco Pivetta
7bf4a65c92
#6003 imported used symbol
2016-09-08 00:53:35 +02:00
Marco Pivetta
de4c854ac9
#6003 removed useless count() call
2016-09-08 00:48:52 +02:00
Marco Pivetta
5e51a985b7
#6003 no default parameter needed
2016-09-08 00:47:39 +02:00
Marco Pivetta
6f79a378d5
#6003 removed useless method parameter count checking duplication
2016-09-08 00:43:29 +02:00
Javier Spagnoletti
61f6b667c0
Remove default clause at EntityRepository::resolveMagicCall()
2016-09-08 00:32:15 +02:00
Javier Spagnoletti
591bae0855
Swap logic from EntityRespository::__call()
2016-09-08 00:32:15 +02:00
Javier Spagnoletti
bea3c653bc
Updated docs
2016-09-08 00:32:15 +02:00
Javier Spagnoletti
a90035e81a
Expose EntityPersister::count() through EntityRepository::count()
2016-09-08 00:32:15 +02:00
Marco Pivetta
35341769ea
Merge pull request #5972 from giginos/patch-1
...
Wrong return type of getResult()
2016-09-07 23:31:19 +02:00
Marco Pivetta
2814d6e2fa
Merge branch 'fix/#5975-fix_hydrating_fetch_join_with_composite_pk'
...
Close #5975
Close #5762
Close #5776
2016-09-07 23:22:51 +02:00
Marco Pivetta
50f321f2e9
#5975 minor test cleanups
2016-09-07 23:18:39 +02:00
Marco Pivetta
140960ebb1
#5975 short array syntax
2016-09-07 23:17:40 +02:00
Alexander Kurilo
74ec055d57
Use ::class const instead of FQCN string ( #5762 )
2016-09-07 23:15:00 +02:00
Alexander Kurilo
c6ea8b1129
Remove irrelevant accessors ( #5762 )
2016-09-07 23:15:00 +02:00
John Keller
3bec698fed
add functional test and bug fix for issue #5762
2016-09-07 23:15:00 +02:00
Marco Pivetta
a90f23dfc7
Merge pull request #6005 from cvuorinen/fix-functional-test-query-logger
...
Improve functional test query logger
2016-09-07 22:35:00 +02:00
Carl Vuorinen
0da6669fac
Fix functional test query logger
...
DebugStack starts queries array from index 1 rather than 0 so the last query was never printed.
Also array params caused an 'Array to string conversion' error
2016-09-03 23:52:34 +03:00
Gabriel Potkány
75f44008d6
Remove unneeded ternary operator from Query::contains
2016-08-16 01:31:46 +02:00
giginos
eb62ae5933
Wrong return type of getResult()
...
@see https://github.com/doctrine/doctrine2/issues/5971
2016-08-12 16:26:08 +02:00
Marco Pivetta
31a0c02b06
Merge pull request #5713 from OndraM/remove-coveralls
...
Cleanup no longer used coveralls settings; use scrutinizer badges
2016-07-31 03:19:42 +02:00
Michal-sk
f18d279710
Update association-mapping.rst
...
Added spoken word examples of the relationship methods
2016-07-21 13:41:21 +02:00
Michal-sk
718ee42e8e
Update association-mapping.rst
...
Added pointers on how to interpret the method names. This helped me to quicker grasp the concept of the Relations and there methods. Added a @var annotation to the `Collection` interface to make it clear that the `$groups` is a child of the `Collection` interface.
2016-07-21 07:39:07 +02:00
Alex Ryder
20fb340375
missing $cme under reverse eng code sample
2016-07-21 13:52:27 +12:00
Marco Pivetta
184f7d3285
Merge pull request #5942 from Erikvv/patch-1
...
Add @CustomIdGenerator to documentation
2016-07-20 15:25:22 +02:00
Erik van Velzen
b785a8dc02
Add @CustomIdGenerator to documentation
2016-07-18 18:16:34 +02:00
Marco Pivetta
2b47670831
Merge pull request #5931 from bitwombat/tutorial_fix
...
Clarify language regarding ArrayCollections.
2016-07-12 08:08:26 +02:00
Greg Bell
da43aa2d49
Clarify language regarding ArrayCollections.
...
See https://groups.google.com/forum/#!topic/doctrine-user/yJ8ABqBP5mI
2016-07-12 16:05:20 +10:00
Marco Pivetta
44feacd327
Corrected SLC test expected query count: since the identity map is now consistently hashing identifiers
2016-07-07 23:46:09 +02:00
Steve Müller
355d2c3d19
Merge pull request #5924 from doctrine/fix/allow-empty-identifier-string-as-proxy-identifier
...
Allow empty string identifiers
2016-07-07 23:11:54 +02:00
Marco Pivetta
d330da898f
Correcting order of deletes: cache_token relies on cache_complex_action
2016-07-07 22:24:37 +02:00
Marco Pivetta
5d12593e70
Rewrote ManyToOne SLC tests to not rely on multi-level auto-generated identifiers
...
Background:
Test relied on an `A->B->C` association:
* `A#id` being `B`
* `B#id` being `C`
* `C#id` being an auto-generated identifier (post-insert)
This cannot work, because it breaks the UnitOfWork's identity map.
Specifically, no entries for `A` and `B` can exist in the identity map until `C` entries
are persisted (post-insert).
That means that the identifier generator for `A` and `B` should not be an "assigned"
generator, but should instead be a post-insert generator waiting for other entities
to be persisted.
We cannot fix this in ORM 2.x, but we'll need to invent something for 3.x in order to
fix that (directed graph, or caching the order of operations in the metadata graph).
2016-07-07 21:29:10 +02:00
Marco Pivetta
dbcdc1d42a
Empty identifiers must be disallowed
2016-07-07 20:57:49 +02:00
Marco Pivetta
0d82128b2e
Registering a managed entity with an empty identifier is to be disallowed
2016-07-07 20:57:02 +02:00
Marco Pivetta
7544934158
Removing note that is not valid anymore
2016-07-07 20:39:52 +02:00
Marco Pivetta
1cb8d790b6
Disallowing null as part of the entity identifier
2016-07-07 20:29:00 +02:00
Marco Pivetta
2829174267
Simplified test: invalid entities must make it in the UnitOfWork manually, via registerManaged
2016-07-07 20:28:21 +02:00
Marco Pivetta
5b8b548bd4
When invalid (null) identifiers are provided, an exception should be thrown
2016-07-07 20:08:24 +02:00
Marco Pivetta
9abccba109
When invalid (null) identifiers are provided, an exception should be thrown
2016-07-07 19:58:43 +02:00
Marco Pivetta
da7582d329
Typo fix: s/$booleanTrue/$booleanFalse (C&P mistake)
2016-07-07 19:43:03 +02:00
Marco Pivetta
aa1fda6d5f
Checking for boolean true/false identifiers
2016-07-07 19:38:48 +02:00
Marco Pivetta
29d9f344e8
Non-empty composite key identifiers should also be supported
2016-07-07 19:35:39 +02:00
Marco Pivetta
549bfe127c
Correcting test case: expecting identifier hashes to support empty strings
2016-07-07 19:34:24 +02:00
Marco Pivetta
12789ee6ca
Basic tests around addToIdentityMap with valid string identifiers (empty string allowed)
2016-07-07 19:27:49 +02:00
Marco Pivetta
5761d07c46
Merge pull request #5918 from tonynelson19/master
...
Make setSQL and setDQL function calls case-sensitive.
2016-07-05 19:50:59 +02:00
Tony Nelson
cd36407f28
Update EntityManager.php
2016-07-05 12:48:00 -05:00
Tony Nelson
1880cbd8b6
Update dql-doctrine-query-language.rst
2016-07-05 12:46:16 -05:00
Marco Pivetta
27e9b49215
Merge pull request #5911 from ReenExeContributor/scrutinizer-clear-code
...
Scrutinizer clear code
2016-07-05 18:21:08 +02:00
ReenExe
bcc7983934
after review
2016-07-05 19:15:47 +03:00
Marco Pivetta
ab4b761110
Merge pull request #5913 from ReenExeContributor/clear-code-metadata-info
...
Clear code metadata info
2016-07-05 18:09:18 +02:00
ReenExe
f7c16ab364
remove else
2016-07-03 00:21:00 +03:00
ReenExe
99b1eaaabb
clear code - double condition after isset
2016-07-03 00:17:51 +03:00
ReenExe
1dba0b8545
clear code
2016-07-03 00:14:33 +03:00
ReenExe
0e8491a474
clear code
2016-07-03 00:11:44 +03:00
ReenExe
511b27517a
refactoring: extract method
2016-07-03 00:10:43 +03:00
ReenExe
a81458a0aa
1. merge conditions
...
2. convert `if` to `condition`
2016-07-03 00:05:31 +03:00
ReenExe
b108a2af52
merge conditions
2016-07-03 00:01:07 +03:00
ReenExe
f7317d700c
logical remove double condition
2016-07-02 23:58:29 +03:00
ReenExe
2301fb3ff2
move common cascades
2016-07-02 23:53:23 +03:00
ReenExe
eccec87796
clear code
2016-07-02 23:47:21 +03:00
ReenExe
c0fc4f1158
use internal function
2016-07-02 23:02:13 +03:00
ReenExe
52b2d9022a
use ternary
2016-07-02 23:00:40 +03:00
ReenExe
a7c4ca82fd
use ternary
2016-07-02 22:59:16 +03:00
ReenExe
6bf6bae219
clear code
2016-07-02 22:51:44 +03:00
ReenExe
c6675b0ce3
use ternary
2016-07-02 22:42:46 +03:00
ReenExe
db6c593463
clear code
2016-07-02 22:37:12 +03:00
ReenExe
347d1625bc
merge conditions
2016-07-02 22:33:23 +03:00
ReenExe
16cddd4693
claar code from Scrutinizer
2016-07-02 22:13:06 +03:00
Marco Pivetta
ffd1465af2
Merge pull request #5910 from ReenExeContributor/clear-code
...
Code cleanups: early return/internal function usage
2016-07-01 01:05:16 +02:00
ReenExe
8eef0beacb
clear code
2016-07-01 01:20:52 +03:00
ReenExe
015ec444c5
use PHP common functions
2016-07-01 01:17:25 +03:00
Marco Pivetta
32ea9112fa
Merge pull request #5898 from radmax/patch-1
...
Typo
2016-06-30 15:08:18 +02:00
Marco Pivetta
b55ef58025
Merge pull request #5902 from holtkamp/patch-1
...
Fixed typo (serves => servers)
2016-06-26 09:15:21 +02:00
Menno Holtkamp
a3e9529c02
Fixed typo (serves => servers)
2016-06-25 17:29:04 +02:00
radmax
2ab752bfc3
typo
2016-06-22 17:06:16 +02:00
Michal Zuber
7ef3e3a60c
Check for Xcache from INI setting
...
On a shared webhosting the Xcache module is loaded, but it can be disabled with .htaccess `php_flag xcache.cacher Off` which causes issues.
2016-06-22 08:50:36 +02:00
Marco Pivetta
04b48ae12b
Merge pull request #5892 from BreiteSeite/5882-documentation
...
#5882 recommend using latest stable PHP version in the getting started guide
2016-06-20 22:10:15 +02:00
Michael Kühn
58d8b86bd5
#5882 recommend using latest stable PHP version in the getting started guide
2016-06-20 21:17:36 +02:00
Marco Pivetta
8237760c1b
Merge pull request #5891 from Chrisp1tv/master
...
Fix typo in PHPDoc block of QueryBuilder.php
2016-06-20 15:11:54 +02:00
Christopher Anciaux
76badc296a
Fix typo in PHPDoc block of QueryBuilder.php
2016-06-20 14:20:36 +02:00
Marco Pivetta
1162440d55
Merge pull request #5837 from foaly-nr1/patch-1
...
Use constant consistently
2016-06-19 19:41:37 +02:00
Marco Pivetta
8c49ba6128
Merge pull request #5886 from gadelat/remove-unused-variables
...
removed some unused variables
2016-06-19 18:35:24 +02:00
Gabriel Potkány
56a6505294
removed some unused variables
2016-06-19 14:46:02 +02:00
Marco Pivetta
3dfc180720
Merge branch 'fix/#5867-allow-embeddable-usage-in-inheritance'
...
Close #5867
Close #4097
Close #4277
2016-06-19 12:44:37 +02:00
Marco Pivetta
18e3cb4440
#5867 @group annotations, describing scenario
2016-06-19 12:44:19 +02:00
Marco Pivetta
aa8cf7bae9
#5867 simplifying test case by inlining all required models into the test case
2016-06-19 12:42:49 +02:00
Luís Cobucci
27f3bc1e2c
Allow the usage of embedded objects on parent classes.
...
The `ClassMetadataInfo` was always using the "current class" to
fetch the reflection of a property even when a field is declared
on the parent class (which causes `ReflectionProperty` to throw
an exception).
2016-06-19 12:35:57 +02:00
Marco Pivetta
b59b966cc2
Merge pull request #5884 from doctrine/cleanup/drop-php-5.5-support
...
Drop PHP 5.5 support
2016-06-19 09:37:40 +02:00
Marco Pivetta
a9bca86d4d
Merge pull request #5885 from doctrine/fix/proxy-failure-fixes
...
Partially reverting #5860 due to type juggling horrors
2016-06-19 09:37:25 +02:00
Marco Pivetta
d00069e38b
Reverting 741da7806c, which was causing issues due to loose type checking
...
See this example on why the revert is needed: https://3v4l.org/8T34v
Code copied for reference:
```php
<?php
$a = 1;
switch ($a) {
case "1";
echo "FUCK YOU, STUPID LANGUAGE!";
break;
case 1;
echo __LINE__;
break;
}
```
2016-06-19 09:28:12 +02:00
Marco Pivetta
e409c10209
Requiring at least PHP 5.6 as minimum installed PHP version
2016-06-19 08:51:48 +02:00
Marco Pivetta
1610d916a4
Stop testing against PHP 5.5
2016-06-19 08:51:24 +02:00
Marco Pivetta
765e102d01
Merge pull request #5856 from doctrine/fix/#5854-default-query-cache-test-using-wrong-reflection-instance
...
#5854 workaround to avoid populating Second Level Cache from DQL queries with multiple nested DQL aliases
2016-06-19 08:48:38 +02:00
Marco Pivetta
ed7f658437
Testing against PHP nightly, but allowing it to fail
2016-06-19 08:41:00 +02:00
Marco Pivetta
659f6a3864
Merge pull request #5883 from sebastianbergmann/phpunit-5.4
...
Make test suite compatible with PHPUnit 5.4.
2016-06-18 16:44:00 +02:00
Sebastian Bergmann
9da83cfae8
Make test suite compatible with PHPUnit 5.4.
...
* Use createMock() and getMockBuilder() instead of getMock()
* Use expectException() and expectExceptionMessage() instead of setExpectedException()
2016-06-18 13:01:59 +02:00
FabioBatSilva
163dac4a91
#5854 - Fix SLC queries with multiple nested DQL aliases
2016-06-17 00:11:18 -04:00
Marco Pivetta
c834ccf3fa
#5854 added PHP 7.1 to the build matrix
2016-06-16 23:00:59 -04:00
Marco Pivetta
be090e2f75
#5854 removing failure caused by a ReflectionProperty being instantiated against the wrong class name in a test
2016-06-16 23:00:59 -04:00
Marco Pivetta
288e3191ce
#5854 - simple workaround to avoid populating SLC cache from DQL queries with multiple nested DQL aliases
2016-06-16 23:00:59 -04:00
Marco Pivetta
d3f6c5ec70
Merge pull request #5873 from vudaltsov/patch-1
...
Update query-builder.rst
2016-06-14 04:39:57 +02:00
Valentin Udaltsov
6ac7480df4
Update query-builder.rst
...
Removed one brace
2016-06-14 04:32:20 +03:00
Marco Pivetta
81fe6a82b3
Merge branch 'fix/#5858-yaml-exporter-should-only-introspect-join-column-on-owning-association-side'
...
Close #5858
2016-06-08 13:33:43 +02:00
Thomas Ploch
ea788fb734
Exporters should only inspect joinColumns for owning side in bi-directional OneToOne
...
rebased commits:
- Added test case for bi-directional OneToOne in YamlExporter
- Only inspect joinColumns for owning side in bi-directional OneToOne in YamlExporter
- Adding bi-directional test case without joinColumn to XmlExporter test
- Same testcase also applied to PhpExporter
- Fixing bi-directional issue in PhpExporter when inspecting joinColumns index
- Implemented @Ocramius suggestions
2016-06-08 13:24:43 +02:00
Marco Pivetta
7e4106d47c
Merge pull request #5860 from peter-gribanov/master
...
Removed hacky switch/case, migrated to if/else and early return statements
2016-06-08 12:39:03 +02:00
Marco Pivetta
9b902263d5
Merge pull request #5863 from tPl0ch/feature-drop-54
...
Remove EOL PHP 5.4 from `.travis.yml` and `composer.json` - Fixes #5862
2016-06-08 12:36:21 +02:00
Thomas Ploch
650d49ee81
Tightened PHP version constraint in composer.json
2016-06-08 12:19:31 +02:00
Thomas Ploch
68b0060595
Fixing PHP version constraint in composer.json
2016-06-08 12:11:11 +02:00
Thomas Ploch
649ff94b38
Remove EOL PHP 5.4 from .travis.yml - Fixes #5862
2016-06-08 12:08:50 +02:00
Peter Gribanov
fa7799cec1
return check EventManager
2016-06-08 12:24:41 +03:00
Peter Gribanov
c0a87597fa
correct code style
2016-06-08 11:47:09 +03:00
Peter Gribanov
0b5b7190d7
not check EventManager
2016-06-08 11:29:43 +03:00
Peter Gribanov
fadd0a338f
add createConnection static method
2016-06-08 10:58:44 +03:00
Peter Gribanov
741da7806c
change switch/case to if/else
2016-06-08 10:29:39 +03:00
Marco Pivetta
3bc61d5f5e
Merge branch 'fix/#5850-clearing-specific-entity-name-should-clear-also-its-entity-insertions'
...
Close #5850
Close #5849
2016-06-06 00:35:44 +02:00
Marco Pivetta
68c5d761a8
#5849 #5850 minor performance optimization - avoiding get_class() calls on all entity insertions
2016-06-06 00:25:48 +02:00
Marco Pivetta
b9b952ce8a
#5849 #5850 renamed clearEntityInsertions to clearEntityInsertionsForEntityName, for clarity
2016-06-06 00:13:39 +02:00
Marco Pivetta
20d86c5b27
#5849 #5850 refactored clearIdentityMapForEntityName to remove useless looping
2016-06-06 00:11:19 +02:00
Marco Pivetta
14e0800293
#5849 #5850 renamed clearIdentityMap to clearIdentityMapForEntityName, for clarity
2016-06-06 00:10:18 +02:00
Marco Pivetta
34d8e00df7
#5849 #5850 correcting test scenario: identity map could not be built with auto-generated identities+persist
2016-06-06 00:08:26 +02:00
Marco Pivetta
313e4a33e5
#5849 #5850 adding group annotations to the newly introduced test case
2016-06-05 23:54:16 +02:00
Rico Humme
beb2641492
Correct naming convention of function. Was confusing otherwise
2016-06-05 23:16:09 +02:00
Rico Humme
4d48781e2b
Split of functionality in separate functions
2016-06-05 23:16:09 +02:00
Rico Humme
3df494ddc8
Test Case for Clear entityInsertions for specific entityName
2016-06-05 23:16:09 +02:00
Rico Humme
70603ee3db
Clear entityInsertions for specific entityName
2016-06-05 23:16:09 +02:00
Marco Pivetta
90b7450747
Merge pull request #5853 from lcobucci/patch-1
...
Fix typo
2016-06-05 22:34:07 +02:00
Luís Otávio Cobucci Oblonczyk
2c1818d513
Fix typo
2016-06-05 10:25:08 +00:00
Marco Pivetta
1c2b7c9685
Merge pull request #5813 from jeanCarloMachado/issue_5786
...
Add embedded and embeddable annotations in annotations reference index
2016-05-26 00:58:40 +02:00
Jonny Schmid
a6eb7f7c96
Use constant consistently
2016-05-25 10:23:03 +01:00
ismail BASKIN
fafb8166f4
Fix custom-id-generator class attribute type
...
custom-id-generator tag's attribute type must be FQCN. But NMTOKEN type doesn't support backslash character.
2016-05-22 19:36:15 +03:00
Marco Pivetta
b3aa8254e4
Merge pull request #5823 from munkie/unused-code
...
Optimize imports. Remove full qualified class names. Remove dead code.
2016-05-13 04:47:26 +02:00
Marco Pivetta
2f60d6a1f8
Merge pull request #5817 from primozcigler/master
...
Added missing - in the in getting started docs.
2016-05-12 07:27:03 +02:00
Primoz Cigler
964d510357
Added missing - in the in getting started docs.
2016-05-11 09:11:55 +02:00
Mikhail Shamin
b173763bbb
Remove full qualified class names in tests
2016-05-11 03:00:44 +07:00
Mikhail Shamin
bf322b903d
Optimize imports. Remove full qualified class names
2016-05-11 01:55:12 +07:00
Jean Carlo Machado
56daa67f94
add embedded and embeddable annotations in annotations reference index
2016-05-09 22:25:22 -03:00
Maks Rafalko
c5283eea87
Fix typo
...
`cached` -> `catched`
2016-05-01 15:03:40 +03:00
Guilherme Blanco
59a0410951
Merge pull request #5729 from funivan/patch-1
...
Fix typo
2016-04-21 11:26:15 -04:00
iBet7o
165722cf05
Fix bug: orderBy documentation
2016-04-17 17:31:48 -05:00
Marco Pivetta
76a5229fac
Merge pull request #5771 from teohhanhui/patch-1
...
Remove note on findBy not supporting entity
2016-04-12 13:39:55 +02:00
Teoh Han Hui
6c2463b905
Remove note on findBy not supporting entity
2016-04-12 15:05:16 +08:00
Andrei Sozonov
2f2236a1d6
fix typo
2016-04-01 15:54:17 +03:00
Guilliam Xavier
60e2224e6b
Fix PHP syntax error in composite-primary-keys.rst
...
Add missing semicolon after `private $year` on line 12 of `Car` class example code to fix `Parse error: syntax error, unexpected 'public' (T_PUBLIC), expecting ',' or ';' in [...]/VehicleCatalogue/Model/Car.php on line 14`
2016-03-24 18:08:58 +01:00
Aaron Merryman
b3df49b2f3
Update tools.rst
2016-03-23 18:54:20 -07:00
ivan
01e53ba44a
Fix typo
2016-03-21 14:16:07 +02:00
Ondřej Machulda
f06f383a38
Cleanup no longer used coveralls settings
2016-03-12 01:24:56 +00:00
Marco Pivetta
c1943624ab
Merge pull request #5686 from mbeccati/build-fix
...
Fixed test failing due to changes in AnnotationReader
2016-03-04 19:37:47 +01:00
Matteo Beccati
82588c0af9
Fixed test failing due to changes in AnnotationReader
...
Doctrine\Tests\ORM\Mapping\AnnotationDriverTest::testLoadMetadataForNonEntityThrowsException
Argument 1 passed to Doctrine\Common\Annotations\AnnotationReader::__construct() must be an instance of Doctrine\Common\Annotations\DocParser, instance of Doctrine\Common\Cache\ArrayCache given, called in .../tests/Doctrine/Tests/ORM/Mapping/AnnotationDriverTest.php on line 19 and defined
See: https://revive.beccati.com/bamboo/browse/PHP-DOCTR-PHP55-646/test/case/11813971
2016-02-29 11:06:23 +01:00
mikeSimonson
4b45183dbd
Merge pull request #5670 from mikeSimonson/doc
...
Add precision on the time units
2016-02-23 17:15:24 +01:00
Marco Pivetta
6ed05a9670
Merge pull request #5675 from jeanCarloMachado/fix_broken_links_doc
...
Fixed broken links on getting-started tutorial
2016-02-21 14:44:07 +01:00
Jean Carlo Machado
4c2ced8fee
fixed broken links on getting-started tutorial
2016-02-21 10:31:14 -03:00
Marco Pivetta
aef8f63dd0
Merge pull request #5673 from svycka/patch-1
...
removed unused use statement
2016-02-19 11:38:00 +00:00
Vytautas Stankus
9c320ca64f
removed unused use statement
2016-02-19 12:26:53 +02:00
mikeSimonson
1fa71f15d9
Merge pull request #5671 from mikeSimonson/jira-update
...
Removing section about jira as it has been removed.
2016-02-17 12:13:43 +01:00
mike
38efda33e1
Removing section about jira as it has been removed.
2016-02-17 11:02:19 +01:00
mike
13473e8b4e
Add precision on the time units
2016-02-17 10:57:05 +01:00
Guilherme Blanco
9b4c50e81e
Final work around entity changeset fix
2016-02-16 05:03:11 +00:00
Guilherme Blanco
b784a04cf7
Fixed only variables should be passed by reference issue
2016-02-16 04:46:34 +00:00
Guilherme Blanco
86cde3a9df
Fixed #5605
2016-02-16 03:21:53 +00:00
Guilherme Blanco
d814ad7234
Merge pull request #5668 from petitchevalroux/many-to-many-criteria-fixes
...
Many to many criteria fixes
2016-02-15 21:07:17 -05:00
Patrick Poulain
9461839d42
Fix PostgreSql Tests
2016-02-15 21:07:09 +01:00
Patrick Poulain
e8296e8e7d
Fix ORM Driver Tests
2016-02-15 21:06:34 +01:00
Patrick Poulain
cbde629bf0
Fix MySql Tests
2016-02-15 21:06:01 +01:00
Marco Pivetta
02eaf6a17a
Merge pull request #5667 from JeroenDeDauw/ORMException
...
Add missing @throws tags
2016-02-15 15:38:44 +01:00
jeroendedauw
34dbefaf22
Add missing @throws tags
2016-02-15 15:15:32 +01:00
jeremygiberson@gmail.com
dd64161ece
forgot to delete from relational table first
2016-02-14 18:00:15 -07:00
jeremygiberson@gmail.com
cc7ef71a13
added teardown for new cmstag table
2016-02-14 17:48:53 -07:00
jeremygiberson@gmail.com
1e660abeb8
cascade all operations on cmstags
2016-02-14 17:43:58 -07:00
jeremygiberson@gmail.com
3ed64dcec2
changed relation table column name to match
2016-02-14 17:37:25 -07:00
Jeremy Giberson
dd3f67d862
updated manytomany so it maps field names to column names in criteria ordering
2016-02-11 13:39:31 -07:00
Jeremy Giberson
0feaf92348
improve test readability
2016-02-10 20:27:43 -07:00
Jeremy Giberson
ae785757a1
Merge branch 'fix-many-many-criteria' of github.com:petitchevalroux/doctrine2 into many-to-many-criteria-fixes
...
Conflicts:
lib/Doctrine/ORM/Persisters/Collection/ManyToManyPersister.php
2016-02-10 20:04:48 -07:00
Jeremy Giberson
0adeade045
merged git@github.com:SammyK/doctrine2.git:many-to-many-order-by-fix
2016-02-10 19:52:03 -07:00
Jeremy Giberson
f0accca99d
Merge branch 'DDC-3719-fix' of github.com:jeanCarloMachado/doctrine2 into many-to-many-criteria-fixes
2016-02-10 19:40:45 -07:00
Patrick Poulain
cfeda903e3
Fix many-to-many matching ignoring offset/limit
2016-02-05 11:14:47 +01:00
Jean Carlo Machado
468fe315ba
fixed indentation
2016-01-29 10:03:44 -02:00
Jean Carlo Machado
375b0369ae
added test of matching non-owing side with criteria
2016-01-28 19:36:52 -02:00
Marco Pivetta
788143dc03
Merge pull request #5634 from alexislefebvre/travis-ci-remove-duplicate-condition
...
Remove duplicate code in .travis.yml
2016-01-26 23:00:55 +01:00
Alexis Lefebvre
a1ca73d1e1
Remove duplicate code in .travis.yml
...
The "$TRAVIS_PHP_VERSION != '7.0'" condition was duplicated
See #5580 .
2016-01-26 22:28:56 +01:00
Alessandro Lai
1e97cf21e8
Reverting removal of lock tests paragraph; minor fixes
2016-01-20 16:52:13 +01:00
Alessandro Lai
2c70f4edf7
[DOCUMENTATION] Update tests README
2016-01-20 16:42:58 +01:00
Marco Pivetta
a4d84e0cd8
Merge pull request #5599 from zeroedin-bill/fix/5598-having-regression-fix
...
Fix #5598 issue with /, * in DQL not translating query components properly
2016-01-16 10:29:49 -06:00
Steve Müller
b491e75d64
Merge pull request #5612 from issei-m/patch-2
...
[Doc] Is it a typo?
2016-01-15 02:48:44 +01:00
Issei.M
5535690b75
[Doc] Fix typo
2016-01-14 19:39:16 +09:00
Bill Schaller
744c308337
Remove dead code SQLWalker::walkCaseExpression
2016-01-08 13:58:02 -05:00
Bill Schaller
55d4f515af
Fix issue were identifier operands in /,* arithmetic terms were not checked to see if they're query components
2016-01-08 12:53:05 -05:00
Alessandro Lai
d7e7baf2a2
Regression test: HAVING clause does not translate variable name when used with * and / math operators
2016-01-08 17:56:41 +01:00
Marco Pivetta
196ea2d0c5
Merge pull request #5597 from deeky666/DDC-5596
...
Fix documentation of schema tool's "save mode"
2016-01-08 16:14:14 +01:00
Steve Müller
f9217cf6f2
fix documentation of schema tool's "save mode"
...
fixes #5596
2016-01-08 15:37:19 +01:00
Steve Müller
1697293591
Merge pull request #1563 from rawkode/bugfix/incorrect-rollback-method-name
...
Fixing method name 'rollBack', which was documented as 'rollback'
2016-01-06 11:49:32 +01:00
Steve Müller
22b9574a0f
Merge pull request #5591 from doctrine/docs/remove-2-4-from-readme
...
Removing 2.4 from README
2016-01-06 00:49:59 +01:00
Marco Pivetta
5bd476209d
Removing 2.4 from README
2016-01-06 00:48:26 +01:00
Marco Pivetta
ebe11c7bcf
Merge pull request #5590 from zeroedin-bill/fix-discriminator-column-defaults
...
Fix discriminator column defaults
2016-01-05 23:42:56 +01:00
Bill Schaller
8bde0c8a90
Fix AnnotationDriver, XmlDriver, YamlDriver to properly set DiscriminatorColumn defaults for type and length.
...
Note: Even though the column definition generated for a discriminator column
would eventually default the type to string and length to 255, the docs specify
defaults that should be reflected explicitly in the discriminatorColumn mapping.
2016-01-05 12:32:25 -05:00
Bill Schaller
6963fd8f20
Update docs for @DiscriminatorColumn to indicate that it is optional.
2016-01-05 12:30:29 -05:00
Bill Schaller
d97fad26a5
Add tests to ensure DiscriminatorColumn is optional, and that optional params type and length have proper defaults.
2016-01-05 12:29:49 -05:00
Marco Pivetta
7f16e5bc51
Merge pull request #5585 from mikeSimonson/cpr-year
...
Replacing the hardcoded year with a function call
2016-01-04 11:06:01 +01:00
mike
50d7ed98ca
Replacing the hardcoded year with a function call
2016-01-04 10:47:37 +01:00
Marco Pivetta
b792e959cd
Merge pull request #5584 from harikt/patch-2
...
Fix broken links to blog post.
2016-01-02 18:03:26 +01:00
Hari K T
30eb4646f7
Fix broken links to blog post.
2016-01-02 22:30:32 +05:30
Marco Pivetta
b22cdab1bb
Merge pull request #5580 from doctrine/hotfix/move-from-coveralls-to-scrutinizer-coverage
...
Move from coveralls to scrutinizer coverage
2015-12-29 20:18:34 +01:00
Marco Pivetta
43787447d6
Test suite is SLOOOOOOOOWWWWWW
2015-12-29 17:11:14 +01:00
Marco Pivetta
75957ee3e7
We can safely run coverage reporting on PHP7 only
2015-12-29 17:07:38 +01:00
Marco Pivetta
3e87a1c4b8
Uploading coverage information via ocular.phar
2015-12-29 16:54:36 +01:00
Marco Pivetta
e37e1818c6
Adding scrutinizer-ci config
2015-12-29 16:51:44 +01:00
Marco Pivetta
86e13f9c5d
Removing coveralls dependency
2015-12-29 16:47:20 +01:00
Marco Pivetta
5849dec16f
Shameless plug
2015-12-29 16:46:59 +01:00
Marco Pivetta
3ca6828544
Allowing doctrine/common 2.6
2015-12-25 15:58:57 +01:00
Marco Pivetta
5e53e92fc5
Merge branch 'hotfix/common-2.6-upgrade-compat'
2015-12-25 15:26:30 +01:00
Marco Pivetta
e0148f14e2
doctrine/common 2.6.0 compat
...
Less strict assertion - no need to check the exact file name
2015-12-25 15:20:35 +01:00
Marco Pivetta
6e6d3e27ab
Common 2.6 compatibility
...
Internal structure of the ArrayCache has changed, therefore we should fix the tests depending on it instead
2015-12-25 15:10:21 +01:00
Marco Pivetta
eb62e4d6c3
Merge branch 'hotfix/#4884-support-proxy-php7-hints-generation'
...
Close #4884
2015-12-25 14:46:30 +01:00
Marco Pivetta
7057d3607e
#4884 - allow installation of doctrine/common 2.6.x, which allows generating type-hints on proxies
2015-12-25 14:46:11 +01:00
Marco Pivetta
3260291aef
Merge pull request #5572 from greg0ire/patch-2
...
Guess missing words
2015-12-25 14:40:29 +01:00
Grégoire Paris
f9715ac24a
Guess missing words
2015-12-22 17:44:00 +01:00
Marco Pivetta
24e4215ab3
Merge pull request #5557 from malukenho/enhancement/remove-unecessary-namespace-use-and-import
...
Remove unnecessary namespaces imports and usage
2015-12-16 10:50:51 +01:00
Jefersson Nathan
156075682f
Remove unnecessary namespaces imports and usage
2015-12-16 05:45:55 -03:00
Marco Pivetta
6099e45eef
Merge branch 'hotfix/#1572-target-entity-resolver-dql-with-interfaces-support-2.6.x'
...
Close #1572
2015-12-11 21:34:57 +01:00
Marco Pivetta
0c6b510c2a
#1572 - test coverage - interfaces should also resolve to target entities when in DQL
2015-12-11 21:34:11 +01:00
oprokidnev
e390dbd5ba
Target entity resolver for DQL
...
Since we have target entity resolver in doctrine this class check is not enought.
To gain interface resolution it is better to add interface check in addition to class_check here.
2015-12-11 21:33:59 +01:00
Marco Pivetta
b341d5c453
Merge pull request #5548 from doctrine/cleanup/classmetadata-get-column-names-simplification
...
Cleanup - `ClassMetadataInfo#getColumnNames()` simplification
2015-12-11 21:20:12 +01:00
Marco Pivetta
044b202379
Simplifying getColumnNames logic (can be an array_map call)
2015-12-11 20:50:18 +01:00
Marco Pivetta
b2a6f8aa0e
Adding test case for fetching column names by field names
2015-12-11 20:48:59 +01:00
Marco Pivetta
276a22fb6f
Merge branch 'cs/#1228-minor-php-cs-fixes'
...
Close #1228
2015-12-11 20:32:28 +01:00
Jeroen Thora
6dcb97a20e
Fixed many small phpcs issues
2015-12-11 20:30:41 +01:00
Marco Pivetta
0a1fa8920e
Merge pull request #1396 from Padam87/embeddable_docs
...
[Documentation] Initializing embeddables doc
2015-12-11 20:24:44 +01:00
Marco Pivetta
3971e8c55b
Merge branch 'hotfix/#1573-merge-associated-versioned-entity'
...
Close #1573
2015-12-11 20:17:05 +01:00
Marco Pivetta
996db42029
#1573 - correcting test asset namespace, removing unused properties and bi-directional association
2015-12-11 20:14:53 +01:00
Marco Pivetta
cf3a54ab95
Removing empty newline
2015-12-11 20:00:59 +01:00
Marco Pivetta
16baa8d60f
#1573 - correcting docblock arguments/description
2015-12-11 20:00:08 +01:00
Marco Pivetta
41235f61de
#1573 removing unused API
2015-12-11 19:59:08 +01:00
Marco Pivetta
21a250fc02
Merge pull request #1472 from PowerKiKi/mariadb
...
Add test for MariaDB 5.5 and 10.1 on Travis
2015-12-11 19:45:09 +01:00
Marco Pivetta
9ac7c3bf70
Merge pull request #5547 from doctrine/hotfix/php7-xdebug-incompatibility-fixes
...
Correcting minor test case incompatibility with XDebug 2.4.x
2015-12-11 19:39:43 +01:00
Marco Pivetta
342ab2f7f1
Correcting minor test case incompatibility with XDebug 2.4.x
...
In PHP 5.x + XDebug < 2.4, the output would be "string:..."
In PHP 7.x + XDebug >= 2.4, the output would be "the/file/name.php:11:string:..."
This is an improvement in XDebug that is quite annoying for our purposes, but is actually welcome to most users anyway.
This commit simply fixes that incompatibility
2015-12-11 19:15:48 +01:00
Marco Pivetta
84f2bf7204
Merge branch 'docs/#1497-update-orm-documentation-for-utc-datetime-type'
...
Close #1497
2015-12-11 18:53:28 +01:00
Marco Pivetta
8c086d1a6e
#1497 - minor CS fixes
2015-12-11 18:53:18 +01:00
Marco Pivetta
df129635cf
#1497 - simplifying UTC datetime handling logic in the examples
...
Highly performance sensitive code should avoid method calls, sadly
2015-12-11 18:52:26 +01:00
Marco Pivetta
a130ff96ba
#1497 - Using a PHP code block to describe how a datetime+utc type can be set up
2015-12-11 18:48:23 +01:00
Marco Pivetta
5b22e59383
Removing symfony-specific documentation
2015-12-11 18:43:53 +01:00
Marco Pivetta
624fcb4486
Merge branch 'docs/#1496-docblock-fixes'
...
Close #1496
2015-12-11 18:27:36 +01:00
Marco Pivetta
00718f6bf7
#1496 s/$this/self
2015-12-11 18:27:19 +01:00
Damien Gavard
9b4dadade0
Use @return $this instead of @return static for consistency
2015-12-11 18:22:26 +01:00
Damien Gavard
5687347d60
Fix invalid return type documentation
2015-12-11 18:22:26 +01:00
Damien Gavard
15aafaa11d
Use @return $this instead of return explicitly QueryBuilder
2015-12-11 18:22:26 +01:00
Damien Gavard
8d62aadf55
Fix invalid return type in docblock
2015-12-11 18:22:26 +01:00
Marco Pivetta
b1bf57db48
Merge pull request #1408 from baileylo/patch-1
...
[doc] Remove unused variable from sample code
2015-12-11 18:19:26 +01:00
Marco Pivetta
9e68a5adc7
Merge pull request #1579 from aschempp/proxy-initialized-cs
...
Reduce code duplication in ProxyFactory::createInitializer
2015-12-11 18:16:53 +01:00
Benjamin Eberlei
a6ddac0a96
Remove link to issue tracker
2015-12-08 22:51:45 +01:00
Marco Pivetta
bd94931201
Merge pull request #1574 from Ma27/patch-1
...
deduplication of internal UnitOfWork methods
2015-12-08 19:02:28 +01:00
Andreas Schempp
4df7699ced
Reduce code duplication in ProxyFactory::createInitialized
...
The only difference between the ~30 lines in the IF-statement
is that the __wakup method is called on the proxy object.
2015-12-06 14:56:36 +01:00
bilouwan
fb4d02c69b
Refactor testing Proxy not initilized
2015-12-04 14:49:01 +01:00
StoshSeb
da4a29c0e2
Fixed DDC-3740
...
The count must return an integer, not a string
2015-12-03 13:15:12 +01:00
bilouwan
d2cbdd1866
Fix superflous whitespaces & empty lines
2015-12-02 14:09:14 +01:00
Maximilian Bosch
f840f0d464
DDC-4022 execute callback parameter directly instead of using call_user_func
2015-12-01 22:31:27 +01:00
Maximilian Bosch
11f9b00d53
DDC-4022 method naming
2015-12-01 22:31:26 +01:00
Maximilian Bosch
33476d8c34
DDC-4022 minor improvements
2015-12-01 22:31:25 +01:00
Maximilian Bosch
c337f8f5c7
DDC-4022 deduplication of internal UnitOfWork methods
...
the methods UnitOfWork#afterTransactionRolledBack() and UnitOfWork#afterTransactionComplete do almost the same, so it can be abstracted into another private method.
2015-12-01 22:31:25 +01:00
Guilherme Blanco
3c3b7364ba
Hotfix for missing reverse dependency in case of non-implicit change tracking policies
2015-12-01 20:24:16 +00:00
Guilherme Blanco
9b77ba2c1a
Merge pull request #1570 from doctrine/DDC-2524
...
[RFC] Tests around reported cases over DDC-2524
2015-12-01 00:27:34 -05:00
David McKay
3c7d92e4cc
Fixed incorrect case of another two references of rollback
2015-11-30 16:53:31 +00:00
bilouwan
e8f40f58a1
Fix compatibility with php5.4
2015-11-30 10:35:42 +01:00
Guilherme Blanco
8ea62b95b8
Tests around reported cases over DDC-2524
2015-11-27 18:44:23 +00:00
bilouwan
832adae6b4
Unit test & fix for merge versionned entity
2015-11-27 17:28:45 +01:00
Guilherme Blanco
599f99471e
Merge pull request #1571 from montaniasystemab/patch-1
...
Fixed typo in QueryBuilder->where() docblock
2015-11-26 15:30:56 -05:00
montaniasystemab
b48fca543c
Fixed typo in QueryBuilder->where() docblock
2015-11-26 10:01:29 +01:00
Guilherme Blanco
57b22bd646
Merge pull request #1568 from guiwoda/patch-ddc-3967
...
Identifier is cached with wrong type
2015-11-24 22:17:59 -05:00
Guido Contreras Woda
e3627f1886
Test that reflects the issue described in http://www.doctrine-project.org/jira/browse/DDC-3967
2015-11-24 10:35:31 -03:00
Marco Pivetta
b980e98ba3
Merge pull request #1566 from BenMorel/typofix
...
Fix typos in DQL doc
2015-11-23 14:27:26 +01:00
Benjamin Morel
6d8778fd69
Fix typos in DQL doc
2015-11-23 12:18:18 +01:00
David McKay
f8ba3a3434
Fixing method name 'rollBack', which was documented as 'rollback'
2015-11-21 18:18:56 +00:00
Guilherme Blanco
3cff0f88bd
Merge pull request #1562 from deeky666/fix-empty-expression
...
Fix empty expression on PHP 5.4
2015-11-19 10:45:21 -05:00
Steve Müller
e0cb90d426
fix empty expression on PHP 5.4
2015-11-19 16:43:33 +01:00
Marco Pivetta
9c5cea3e95
Merge pull request #1561 from deeky666/DDC-4006
...
[DDC-4006] Inherit ID generator strategy mapping from embeddables
2015-11-19 16:34:32 +01:00
Guilherme Blanco
22e76e8624
Merge pull request #1559 from guiwoda/wrong-entity-cache-read-inheritance
...
Entity cache key is built differently on read than on write
2015-11-19 10:30:37 -05:00
Steve Müller
86c81da7ce
inherit ID generator strategy mapping from embeddables
2015-11-19 16:10:48 +01:00
Guido Contreras Woda
6c96e23a47
Test to verify the bug and the fix
2015-11-19 12:02:51 -03:00
Guilherme Blanco
0b45d96c74
Merge pull request #1560 from gitname/patch-2
...
Fix broken links
2015-11-17 21:40:13 -05:00
gitname
001d5b7ed3
Fix relative links
...
Fix 2 relative links to other docs files
2015-11-17 12:30:32 -08:00
Guido Contreras Woda
427642aaba
Entity cache key is built differently on read than on write
2015-11-17 16:10:17 -03:00
Guilherme Blanco
84eb175dbf
Merge pull request #1436 from dadamssg/DDC-3785
...
allow ManyToManyPersister to handle custom identification types
2015-11-15 22:24:01 -05:00
Guilherme Blanco
50ee47cc70
Merge pull request #1492 from nicolas-grekas/doc-fix
...
Fix misleading docblock example
2015-11-15 22:19:27 -05:00
Guilherme Blanco
04789dfec7
Merge pull request #1443 from meeuw/unsigned
...
Unsigned
2015-11-15 22:16:15 -05:00
Guilherme Blanco
7fc36b4110
Merge pull request #1450 from davidfuhr/doc-version
...
Link annotation ref to locking explanation
2015-11-15 22:14:36 -05:00
Guilherme Blanco
cdfcca2ff2
Merge pull request #1455 from xoeoro/patch-1
...
Update ExprTest.php
2015-11-15 22:12:36 -05:00
Guilherme Blanco
9f93999758
Merge pull request #1487 from xxccdef/DDC-3864
...
[DDC-3864] Support any ordering of fields in partial object query with embeddable
2015-11-15 22:03:25 -05:00
Guilherme Blanco
e8acfb5891
Merge pull request #1481 from mikeSimonson/composer-bin-fix
...
Remove the execution bit on the bin/doctrine.php
2015-11-15 22:02:19 -05:00
Guilherme Blanco
5ec9a62e2b
Merge pull request #1558 from doctrine/DDC-3922
...
[RFC] remove indexes overruled by primary key
2015-11-15 22:01:05 -05:00
vershnik
96398ba30f
remove indexes overruled by primary key
...
There can be unique indexes automatically created for join column.
If join column is also primary key we should keep only primary key on this column.
Oracle does not allow having both unique index and primary key on the same column, it is useless for mysql too.
(Previously it was done by DBAL, but now it allows duplicate indexes)
2015-11-16 02:49:41 +00:00
Guilherme Blanco
c561223d1b
Merge pull request #1557 from gitname/patch-1
...
Reduce ambiguity in Entities description
2015-11-15 21:25:30 -05:00
gitname
8192d5bb3e
Reduce ambiguity in Entities description
2015-11-15 13:27:51 -08:00
Jan Langer
91ce78815f
Second level cache stores identifier with correct type even if findById is called with wrong identifier type
2015-11-14 11:17:16 +01:00
Guilherme Blanco
71bb27a62f
Merge pull request #1555 from doctrine/DDC-3979
...
[RFC] DDC-3979
2015-11-13 11:38:55 -05:00
Guilherme Blanco
e64f44ec9b
Fix one to one inverse side cached entity association key generation
2015-11-13 15:58:52 +00:00
Marco Pivetta
802cc82c8d
Merge pull request #1554 from tai2/fix_document_transactional
...
Fix a documentation error.
2015-11-13 07:00:30 +01:00
tai2
50d87bd111
Fix a documentation error.
2015-11-13 12:07:21 +09:00
Guilherme Blanco
3a44a3dada
Merge pull request #1551 from doctrine/DDC-3976
...
[RFC] DDC-3976
2015-11-12 10:21:37 -05:00
Marco Pivetta
3452f5ccc3
Merge pull request #1553 from OskarStark/patch-1
...
doc fix
2015-11-12 11:50:15 +01:00
Oskar Stark
d49cd4aa1e
doc fix
2015-11-12 11:45:37 +01:00
Guilherme Blanco
58992ad523
Fixed support for inverse side second level cache
2015-11-12 05:00:08 +00:00
Guilherme Blanco
089a0ac60b
Merge pull request #1552 from guiwoda/l2-invalid-collection-cache-key
...
Collection cache key is built differently on read than on write
2015-11-11 10:22:46 -05:00
Guido Contreras Woda
d57ecc12c0
Collection cache key is built differently on read than on write
2015-11-11 12:10:29 -03:00
Guilherme Blanco
1187c51a89
Merge pull request #1529 from tkleinhakisa/2.1-upgrade
...
Update Upgrade.md after minor bc break in 2.5.0
2015-11-08 22:54:20 -05:00
Guilherme Blanco
46dec5478a
Merge pull request #1505 from qu1m/master
...
Fixed issue with entity manager when using LockMode::NONE
2015-11-08 22:51:38 -05:00
Guilherme Blanco
49bb687aaf
Merge pull request #1540 from pantelm/master
...
[DDC-3711] Correct Error on manyToMany with composite primary key + add Tests
2015-11-08 22:43:36 -05:00
Guilherme Blanco
664925d7f4
Merge pull request #1550 from doctrine/cache-for-travis
...
[RFC] Added composer cache on travis
2015-11-08 22:41:48 -05:00
Guilherme Blanco
370dbf12de
Added composer cache on travis
2015-11-09 03:40:18 +00:00
Guilherme Blanco
3e0529db53
Merge pull request #1493 from alireza-m/master
...
Pass orderings, maxRresults and firstResult when call getHash
2015-11-08 22:36:06 -05:00
Guilherme Blanco
bad0f17c10
Merge pull request #1549 from doctrine/DDC-3697
...
[RFC] DDC-3697
2015-11-08 22:30:50 -05:00
Guilherme Blanco
443259f629
Some extra refinement over patch
2015-11-09 03:19:11 +00:00
Matthias Pigulla
b7bd42638d
Fix for DDC-3697 and DDC-3701
...
Also fix Lexer::match() so it does not accept T_WHERE when T_WITH is supposed to be matched. (DDC-3701)
2015-11-09 03:19:11 +00:00
Guilherme Blanco
ada97d55ce
Merge pull request #1375 from webimpress/fix/DDC-3671
...
DDC-3671 prevent duplicate unique index
2015-11-07 11:44:02 -05:00
Guilherme Blanco
6dfafad33c
Merge pull request #1547 from doctrine/fix-result-cache
...
[RFC] fixes result cache setting query caching
2015-11-07 11:22:14 -05:00
Alex Vasilenko
c8d2ac40f4
fixes result cache setting query caching
2015-11-07 16:14:54 +00:00
Guilherme Blanco
d7a3154954
Merge pull request #1397 from giosh94mhz/concat_expr_variable_arguments
...
Add Expr::concat support for multiple arguments
2015-11-07 10:45:04 -05:00
Guilherme Blanco
d88cf97bef
Merge pull request #1507 from deguif/fix-wrong-property
...
Fixed wrong property name
2015-11-07 10:09:06 -05:00
Marco Pivetta
28cebeca1c
Merge pull request #1407 from aivus/patch-1
...
Add return to removeMethodTemplate
2015-11-06 23:11:42 -05:00
Marco Pivetta
e7685c89da
Merge pull request #1405 from taueres/master
...
EntityManager#getReference throw ORMException for unrecognized id
2015-11-06 23:07:21 -05:00
Marco Pivetta
378f6546b4
Merge pull request #1545 from doctrine/general-fixes
...
[RFC] General fixes
2015-11-06 22:56:00 -05:00
Guilherme Blanco
843966ac50
General fixes across CS, type resolving, test fixes, etc
2015-11-07 03:55:05 +00:00
Marco Pivetta
9e085ca0b3
Merge pull request #1308 from z38/override-inversedby
...
[DDC-3579] Allow override of inversedBy
2015-11-05 15:10:43 -05:00
Marco Pivetta
2fa289edee
Merge pull request #1514 from Metabor/patch-2
...
check if collection is empty without loading it
2015-11-05 14:46:15 -05:00
z38
ff28507b88
Allow override of inversedBy
2015-11-05 12:11:29 +01:00
Marco Pivetta
2383ccfba5
Merge branch 'feature/#1354-one-to-many-orphan-removal'
...
Close #1354
2015-11-05 00:24:29 -05:00
Marco Pivetta
f097478437
#1354 - DDC-3644 - short array syntax
2015-11-05 00:13:19 -05:00
Marco Pivetta
a7ded16204
#1354 - DDC-3644 - s/protected/private
2015-11-05 00:11:43 -05:00
Guilherme Blanco
1587aac4ff
Added support for OneToMany with orphanRemoval. Replacing entire collection now deletes the replaced collection (scheduled for deletion). No event handling is done as it happens at DBAL level.
2015-11-05 00:08:44 -05:00
Marco Pivetta
06c194310a
Merge pull request #1310 from nicolas-grekas/patch-1
...
Allow symfony 3.0 components
2015-11-04 23:23:06 -05:00
Marco Pivetta
d39a73cce6
Merge pull request #1541 from aleeeftw/master
...
Minor docblock correction
2015-11-01 12:07:35 +01:00
aleeeftw
5481e0fb8b
Minor docblock correction
...
The documentation for the method ‘addJoinedEntityFromClassMetadata’ is
wrong. As we can see currently says you need to pass an object and that
is wrong. The $relation variable is passed to ‘addJoinedEntityResult’
which is using it as a ‘string’.
2015-11-01 10:43:03 +00:00
Pantel
43b2419a3c
[DDC-3711] add Test that check if the association key are composite
2015-10-31 17:19:39 +01:00
Pantel
7de2e04ccd
[DDC-3711] add Tests that check if the association key are composite
2015-10-31 17:15:06 +01:00
Pantel
96687e04a6
[DDC-3711] Correct Error on manyToMany with composite primary key
2015-10-31 16:02:14 +01:00
Steve Müller
b1451cda52
Merge pull request #1533 from sergeyz/patch-1
...
Fix argument type
2015-10-22 09:38:06 +02:00
Marco Pivetta
b15e8b79dc
Merge pull request #1536 from AngelFQC/patch-1
...
Minor - Fix PHP Doc - Update Expr.php
2015-10-20 15:16:25 -07:00
Angel Fernando Quiroz Campos
47441666df
Update Expr.php
2015-10-20 16:55:43 -05:00
Ilya Antipenko
60b80c95cc
Add phpdoc tests for addXxx() and removeXxx() methods
...
Add tests for return types for addXxx() and removeXxx() methods
2015-10-17 17:14:56 +03:00
Marco Pivetta
290dc8989d
Merge pull request #1534 from senkal/gramma-fix/start-sentence-with-capital-letter
...
Use capital letter at the beginning of a sentence
2015-10-11 21:49:07 +02:00
Marcin Sekalski
52817cedfc
Use capital letter and the beginning of a sentence
2015-10-11 13:59:09 +01:00
Sergey Zhuravel
e354ebb162
Fix argument type
2015-10-09 13:53:25 +03:00
Klein Thomas
8535e01115
Move to 2.5 section
2015-10-09 07:12:28 +00:00
Klein Thomas
e682f48422
Update Upgrade.md after minor bc break in 2.5.1
...
The introduction of the second parameter in EntityRepository#createQueryBuilder generates a runtime notice if you have a sub-class of EntityRepository that has a second parameter in the createQueryBuilder method
2015-10-09 07:10:07 +00:00
Marco Pivetta
e91bce5f2a
Merge pull request #1528 from sprain/fix-typo-doc
...
Fixed typo in 9.6.7 of docs
2015-10-05 16:45:19 -03:00
Manuel Reinhard
c86ab7d239
Fixed typo in 9.6.7 of docs
2015-10-05 21:43:03 +02:00
Marco Pivetta
88f43a947d
Merge pull request #1518 from guiwoda/custom-generator-field-builder
...
Added custom ID generator definition to the FieldBuilder
2015-10-04 19:56:17 -03:00
Marco Pivetta
dd2068777c
Merge pull request #1526 from zinovyev/break-on-autoloader-selected
...
Break on autoloader selected
2015-10-04 15:04:42 -03:00
Ivan Zinovyev
1ddb63c88a
Break on autoloader selected
2015-10-04 19:58:57 +03:00
Guido Contreras Woda
3a7d2da2e5
Added custom ID generator definition to the FieldBuilder
2015-10-02 13:51:07 -03:00
Marco Pivetta
5c6f0edb23
Merge pull request #1516 from brabeji/patch-1
...
Clarify @DiscriminatorMap requirement
2015-10-02 05:30:09 -03:00
Marco Pivetta
b5799ae569
Merge pull request #1523 from BenMorel/expr
...
Documentation and case fixes in QueryBuilder
2015-10-01 15:49:29 -03:00
Benjamin Morel
7d4016a757
Documentation and case fixes in QueryBuilder
2015-10-01 20:04:16 +02:00
Marco Pivetta
61ad1bd137
Merge pull request #1520 from maqnouch/patch-1
...
Updated year range
2015-09-30 07:12:43 -03:00
AQNOUCH Mohammed
d02b059269
Updated year range
2015-09-29 22:52:45 +00:00
Jiří Brabec
4b87f5827f
Clarify @DiscriminatorMap reqirement
...
When trying to setup MTI with doctrine, this was always the sentence where I stopped reading as it seems useless if you are forced to specify list of children when you don't even know them. Today I accidentaly read further and found out that this is not necessary.
2015-09-25 12:47:51 +02:00
Oliver Tischlinger
60beca3760
changes after code review
2015-09-25 10:44:30 +02:00
Oliver Tischlinger
03523c67d5
add Unit Test for isEmpty change in LazyCriteriaCollection
2015-09-24 11:39:14 +02:00
Oliver Tischlinger
3e26330c53
check if collection is empty without loading it
...
Actually isEmpty() is always loading the collection in LazyCriteriaCollection.
A lazy version should use the existing functionality of count() to check if there are no elements if the collection is not initialized.
2015-09-23 17:34:11 +02:00
Marco Pivetta
b055d78ea1
Merge pull request #1510 from webfactory/doctrine-cache-removed-DoctrineNamespaceCacheKey
...
Fix tests
2015-09-19 10:39:39 +02:00
Marco Pivetta
2242a4c652
Merge pull request #1511 from BlueM/master
...
Fix class name: AbstractCache -> CacheProvider
2015-09-19 10:22:44 +02:00
Carsten Blüm
42a500a73d
Fix class name: AbstractCache -> CacheProvider
2015-09-19 08:34:00 +02:00
Matthias Pigulla
84f51b68af
Fix tests
...
dd47003641 removes the 'DoctrineNamespaceCacheKey[]' entry from the cache. Thus, all tests counting cache entries were off by one.
2015-09-19 01:15:39 +02:00
François-Xavier de Guillebon
ae243643e5
Added test
2015-09-14 18:35:49 +02:00
François-Xavier de Guillebon
4b7d8511f8
Fixed wrong variable used as array key
2015-09-14 18:34:55 +02:00
François-Xavier de Guillebon
a18ff95fc4
Fixed wrong property name
2015-09-11 17:17:28 +02:00
Marco Pivetta
8b79fe9d9b
Merge pull request #1506 from Tobion/patch-1
...
Fix variable reference in phpdoc of ClassMetadataInfo
2015-09-11 09:51:12 +01:00
Tobias Schultze
c03996d3b3
Fix variable reference in phpdoc of ClassMetadataInfo
2015-09-11 00:19:18 +02:00
Giorgio Premi
16172534bb
Add Expr::concat support for multiple arguments
2015-09-10 17:01:09 +02:00
Quim Manrique
1dbacec0e4
Fixed issue with entity manager when using LockMode::NONE
2015-09-08 00:31:03 +02:00
Marco Pivetta
1b09bb75b0
Merge pull request #1504 from phansys/doc_uuid_generator_strategy_2
...
Updated docs for basic mapping
2015-09-06 02:08:52 +02:00
Javier Spagnoletti
2e2921690a
Updated docs for basic mapping
...
Added note about UUID identifier generator strategy, which was added in 2.3 version:
0a83560
2015-09-05 15:40:37 -03:00
Marco Pivetta
a0a0c731bb
Merge pull request #1457 from phansys/short_types
...
Updated syntax for "integer" and "boolean" types
2015-09-05 17:21:05 +02:00
Marco Pivetta
d1b24dfe12
Merge pull request #1500 from zeroedin-bill/docs-build-improvements
...
Update docs dependency install script and readme to target Ubuntu 14.04
2015-09-04 08:41:38 +01:00
Marco Pivetta
5c8cca2f44
Merge pull request #1485 from hasumedic/php-version-docs
...
Changed references from PHP6 to PHP7
2015-09-04 08:40:37 +01:00
Marco Pivetta
8aa0cdd0b9
Merge pull request #1483 from longkey1/fix-typo
...
Fix typo
2015-09-04 08:37:40 +01:00
Marco Pivetta
2d00a9bcbf
Merge pull request #1482 from bocharsky-bw/patch-1
...
Add type hint for entity manager
2015-09-04 08:34:35 +01:00
Marco Pivetta
29c2b807ce
Merge pull request #1474 from localheinz/fix/unused-imports
...
Fix: Remove unused imports
2015-09-04 08:30:46 +01:00
Marco Pivetta
41ee7e0f1a
Merge pull request #1444 from cezarykluczynski/tutorial-opening-tags-fix
...
Missing opening tags added in one of the tutorials
2015-09-04 08:24:29 +01:00
Marco Pivetta
b062ffdead
Merge pull request #1452 from TomasVotruba/patch-1
...
composer: dev is now by default
2015-09-04 08:22:29 +01:00
Bill Schaller
3e5bf819e3
Update docs dependency install script and readme to target Ubuntu 14.04
2015-09-03 13:58:40 -04:00
Steve Müller
233ebb0ba1
Merge pull request #1499 from issei-m/patch-2
...
minor: removed useless line breaks
2015-09-03 16:40:59 +02:00
Issei.M
df461601f7
removed useless line breaks
2015-09-03 17:55:14 +09:00
Benjamin Eberlei
2b3648c725
[DCOM-293] Fix security misconfiguration vulnerability allowing local remote arbitrary code execution.
2015-08-31 14:16:50 +02:00
Adrien Crivelli
93806a8036
Update DateTime cookbook code
...
It seems that existing code was outdated and lacked ``use`` statement in order to work correctly.
We also added instructions on how to configure the new type, since it may not be straightforward for newcomers.
2015-08-27 15:39:26 +09:00
Alireza Meskin
dfa874642a
Pass orderings, maxRresults and firstResult when call getHash
2015-08-16 15:22:06 +04:30
Nicolas Grekas
df820a5695
Fix misleading docblock example
2015-08-14 14:35:25 +02:00
Bill Schaller
f88896cc9d
Merge pull request #1463 from ehimen/paginate-order-by-subselect
...
Fixed issue when paginator orders by a subselect expression
2015-08-04 14:17:50 -04:00
Egidijus Jucevičius
d4d9a2ba3c
Support any ordering of fields in partial object query with embeddable [DDC-3864]
2015-08-04 10:56:50 +03:00
Alex Salguero
5393bc9956
Removed outdated PHP6 reference in "best practices" docs.
...
Changed references from PHP6 to PHP7 in tests.
2015-07-31 12:25:19 +01:00
Bocharsky Victor
dbd3fa4501
Add type hint for entity manager
2015-07-30 15:32:04 +03:00
longkey1
a3b1f85fd4
typo
2015-07-30 13:16:55 +09:00
mike
1d6adcaf4a
Remove the execution bit on the bin/doctrine.php
2015-07-29 08:41:33 +02:00
Marco Pivetta
71b1dde096
Merge pull request #1473 from ilyar/docs_fix_ref_and_title
...
Docs fix ref and title
2015-07-26 01:19:44 +03:00
Andreas Möller
8a9f6849a2
Fix: Remove unused imports
2015-07-24 12:48:34 +02:00
Ilya Rogov
f10f4b7c52
Fixed WARNING: Title underline too short
2015-07-24 11:09:33 +03:00
Ilya Rogov
bb8f1c77cc
Pretty Ref and Fixed WARNING: Duplicate explicit target name
2015-07-24 11:02:42 +03:00
Adrien Crivelli
57ca849848
Add test for MariaDB 5.5 and 10.1 on Travis
...
This use the brand new supported addon mariadb (not yet officially announced).
This is unfortunately a bit verbose, but I don't think there is any
alternative because we cannot install the addon when testing against mysql
otherwise it would overwrite mysql install.
2015-07-23 12:51:21 +09:00
Andy Cook
26c295b06b
Added non-functional tests for row number over function subselect expression fix; syntax fixes.
2015-07-17 13:24:19 +01:00
Marco Pivetta
f5e79fa0c0
Merge pull request #1466 from Majkl578/travis-container-infrastructure
...
Travis: Switch to container-based infrastructure
2015-07-16 22:18:33 +01:00
Michael Moravec
e87c94052d
Travis: Switch to container-based infrastructure
2015-07-16 22:47:33 +02:00
Marco Pivetta
1370424fed
Merge pull request #1400 from photodude/patch-1
...
mysqli is supported by HHVM
2015-07-16 21:08:32 +01:00
Marco Pivetta
ad056ebdc6
Merge pull request #1462 from DHager/document_transactional
...
Add a note to documentation for transactional()'s return values
2015-07-16 20:56:04 +01:00
Marco Pivetta
506df640b5
Merge pull request #1433 from goetas/slc-check-to-classmetadatainfo
...
Check for non-cacheable entities on metadata level, not at runtime
2015-07-16 20:41:30 +01:00
Asmir Mustafic
3a7b2991e8
PSR-2 CS improvements
2015-07-16 16:20:36 +02:00
Andy Cook
61488d955e
Fixed issue when paginator orders by a subselect expression on platforms supporting ROW_NUMBER OVER() function.
2015-07-16 11:20:22 +01:00
Darien Hager
72d848901b
Add reminder to README for initializing git submodules
2015-07-15 18:59:14 -07:00
Darien Hager
8503c1247f
Document return-value substitution in EntityManager::transactional()
2015-07-15 18:58:18 -07:00
Marco Pivetta
6bf6db3533
Merge pull request #1451 from TomasVotruba/psr-4
...
composer: autoload via PSR-4
2015-07-15 22:24:59 +01:00
Marco Pivetta
70a22b6a73
Merge pull request #1390 from deviantintegral/chaincache-docs
...
Document the ChainCache class
2015-07-15 21:58:20 +01:00
Marco Pivetta
06a00cf073
Merge branch 'hotfix/#1387-DDC-3699-do-not-merge-managed-uninitialized-entities'
...
Close #1387
2015-07-15 21:51:21 +01:00
Marco Pivetta
eb5d87cd94
DDC-3699 - #1387 - leveraging the OrmFunctionalTestCase API
2015-07-15 21:51:04 +01:00
Marco Pivetta
12183b7e6c
DDC-3699 - #1387 - catching specific exceptions
2015-07-15 21:47:37 +01:00
Marco Pivetta
74883e535f
DDC-3699 - #1387 - simpifying tests, clarifying on test method names
2015-07-15 21:46:23 +01:00
Lenard Palko
cbfd71cec6
Added test cases for both one-to-one and one-to-many cases.
2015-07-15 21:26:45 +01:00
Lenard Palko
977f0a5b5c
Fix skipping properties if they are listed after a not loaded relation.
2015-07-15 21:26:45 +01:00
Marco Pivetta
67cda0cd75
Merge branch 'hotfix/#1381-wakeup-reflection-with-embeddable-and-staticreflection-serialization-fix'
...
Close #1381
2015-07-15 20:49:40 +01:00
Nico Vogelaar
b3af5590f9
Fixes ClassMetadata wakeupReflection with embeddable and StaticReflectionService
2015-07-15 20:49:16 +01:00
Marco Pivetta
34eb4fdec5
Merge branch 'hotfix/#1380-non-cache-persister-bug'
...
Close #1380
2015-07-15 20:37:30 +01:00
Marco Pivetta
56cedc5d4f
DDC-3683 - #1380 - reverting BC break, annotating correct types, cs fixes
2015-07-15 20:35:21 +01:00
Darien Hager
77d03ec745
Remove runtime assertion
2015-07-15 20:29:44 +01:00
Darien Hager
6f1107c4ee
Clarify state-changes, replace array_key_exists() with isset() for speed
2015-07-15 20:29:43 +01:00
Darien Hager
1659fab44f
Whitespace formatting tweaks
2015-07-15 20:29:43 +01:00
Darien Hager
d0892b21fb
Remove now-superfluous EntityManager check
2015-07-15 20:29:43 +01:00
Darien Hager
6d6a6a7fbd
Refactor LoadClassMetadataEventArgs to ensure it contains an EntityManager
2015-07-15 20:29:43 +01:00
Darien Hager
e8854b68bb
Change the test listener than layers on second-level-caching so that it is more conservative, only turning on caching-associations when it knows the target entity is cache-able.
2015-07-15 20:29:43 +01:00
Darien Hager
cddbbf00b4
Stumbled across a bug where signatures didn't match, but also the current persister-type didn't support getCacheRegion(). Unsure of exact mechanism, but clearly the constructor doesn't take the second argument anyway, may be old code.
2015-07-15 20:29:43 +01:00
Marco Pivetta
4b1851467b
Merge pull request #1458 from phansys/patch-1
...
[Paginator] Fixed boolean casting
2015-07-15 08:11:43 +01:00
Javier Spagnoletti
cedff7715e
[Paginator] Fixed boolean casting in Paginator
...
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
2015-07-14 16:48:42 -03:00
Javier Spagnoletti
97cc49033e
Updated syntax for ``integer` and `boolean`` types
...
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Used short syntax for ```integer``` and ```boolean``` types.
**Before**
```php
/**
* @var integer
*
* @ORM\Column(name="some_integer_field", type="integer")
*/
private $someIntegerField;
/**
* @var boolean
*
* @ORM\Column(name="some_boolean_field", type="boolean")
*/
private $someBooleanField;
```
**After**
```php
/**
* @var int
*
* @ORM\Column(name="some_integer_field", type="integer")
*/
private $someIntegerField;
/**
* @var bool
*
* @ORM\Column(name="some_boolean_field", type="boolean")
*/
private $someBooleanField;
```
2015-07-14 15:30:13 -03:00
xoeoro
44557a5afa
Update ExprTest.php
...
expr()->countDistinct allows to create COUNT(DISTINCT) expression with mulltiple fields but parser requires only one field.
\Doctrine\ORM\Query\Parser::AggregateExpression
some body, please, fix this problem
2015-07-13 10:45:17 +03:00
Dick Marinus
4a39754e76
unsigned is in fieldMapping['options']
2015-07-09 20:54:04 +02:00
Tomáš Votruba
e0872c55a9
composer: dev is now by default
2015-07-08 14:31:43 +02:00
Tomas Votruba
726383cafb
composer: autoload via PSR-4
2015-07-08 01:51:16 +02:00
David Fuhr
de424be9f7
[DX] Link annotation ref to locking explanation
...
The annotation reference contained no cross reference to the great
transaction and concurrency page. But this might be very useful for the
reader.
2015-07-07 18:45:56 +02:00
Guilherme Blanco
33c2ae465d
Merge pull request #1449 from dunglas/patch-1
...
minor: code quality in Paginator
2015-07-07 11:03:03 -04:00
Kévin Dunglas
abf6b8bee5
minor: Code quality in Paginator
2015-07-07 10:09:06 +02:00
Guilherme Blanco
96b065b282
Merge pull request #1447 from krispypen/patch-1
...
Fix second level caching for queries with multiple joins
2015-07-06 09:49:35 -04:00
Kris Pypen
5780f3209c
wrote a Test for second level cache with multiple levels of associations
2015-07-06 14:18:38 +02:00
Kris Pypen
a2a400b8fb
Fix second level caching for queries with multiple joins
...
The $metadata of the main entity is not always the metadata you need here, for example when you do join A with B and then B with C. For the second join it was using the metadata from A.
2015-07-03 14:45:25 +02:00
Cezary Kluczyński
793fe9d2d1
Missing opening tags added in one of the tutorials
2015-07-01 19:49:11 +02:00
Dick Marinus
9715f3dfcc
add field options as array
2015-06-30 19:42:22 +02:00
Matthew Turland
af2f6a6fff
Corrected bad class reference in "Adding own commands"
2015-06-29 22:58:48 -05:00
David Adams
6fa20062f3
allow ManyToManyPersister to handle identification types
2015-06-23 17:55:56 +00:00
Asmir Mustafic
32f0fefec7
Test XML driver with failing SLC mapping
2015-06-20 14:33:36 +02:00
Asmir Mustafic
4da0ee9db8
Test PHP driver with failing SLC mapping
2015-06-20 14:33:36 +02:00
Asmir Mustafic
5f2922b3a7
Test annotation driver with failing SLC mapping
2015-06-20 14:32:15 +02:00
Asmir Mustafic
012367a371
Removed runtime check test for non-cacheable entities
2015-06-20 14:32:14 +02:00
Asmir Mustafic
acbda4bc0e
YAML driver uses getAssociationCacheDefaults for SLC mapping
2015-06-20 14:32:14 +02:00
Asmir Mustafic
7d64be915c
XML driver uses getAssociationCacheDefaults for SLC mapping
2015-06-20 14:32:14 +02:00
Asmir Mustafic
f4f32a5213
Annotation driver uses getAssociationCacheDefaults for SLC mapping
2015-06-20 14:32:14 +02:00
Asmir Mustafic
11be4fae86
Do not check at runtime for non-cacheable associations
2015-06-20 14:32:14 +02:00
Asmir Mustafic
c685255fe3
Check for non-cacheable associations directly on the class metada info
2015-06-20 14:32:14 +02:00
Asmir Mustafic
6a428c6064
Allow to retreive association cache defaults
2015-06-20 14:32:14 +02:00
Bill Schaller
6b3056ff8c
Merge pull request #1430 from michael-lavaveshkul/master
...
"INSTANCE OF" example doesn't match description.
2015-06-18 10:30:14 -04:00
michael-lavaveshkul
073f570c67
Updated "INSTANCE OF" example code.
2015-06-17 22:15:17 -07:00
Marco Pivetta
37a409aa1f
Merge pull request #1429 from hallabro/update-preupdate-documentation
...
Update events.rst to reflect behaviour of preUpdate
2015-06-17 08:25:37 +01:00
Robin Hallabro
63a543d6a0
Update events.rst to reflect behaviour of preUpdate
2015-06-17 07:57:11 +02:00
Thomas Lallement
f41e59258c
Failing Test - Paginator with sorted collection
2015-06-16 16:34:37 -04:00
Benjamin Eberlei
ae5b8178e7
Merge pull request #1406 from XitasoChris/patch-1
...
add default value for GeneratedValue
2015-06-16 22:25:49 +02:00
Benjamin Eberlei
5ae40d571a
Merge pull request #1409 from haeber/patch-1
...
Added PHPDoc return type false of next method in Hydration/IterableResult
2015-06-16 22:21:20 +02:00
Benjamin Eberlei
8d1be42924
[DDC-3741] Add test for AbstractQuery#setHydrationCacheProfile(null)
2015-06-16 21:56:25 +02:00
Benjamin Eberlei
6423a33a23
Merge pull request #1411 from icambridge/patch-1
...
Allow null to be passed to setHydrationCacheProfile
2015-06-16 21:54:08 +02:00
Benjamin Eberlei
545e448024
Merge pull request #1416 from Restless-ET/patch-1
...
[2.5][Bug] Fix ConvertDoctrine1Schema->getMetadata
2015-06-16 21:38:35 +02:00
Benjamin Eberlei
5aded88cf6
Merge pull request #1418 from mageekguy/patch-2
...
Remove (useless?) call to parser::getLexer()
2015-06-16 21:36:14 +02:00
Benjamin Eberlei
1e7e8f216a
Merge pull request #1419 from c960657/cancel-orphan-removal
...
[DDC-3382] Allow orphan removal to be cancelled
2015-06-16 21:23:20 +02:00
Benjamin Eberlei
ac03c9d851
Add section about entities, proxies and reflection to "Limitations and Known Issues" chapter.
2015-06-16 21:11:29 +02:00
Christian Schmidt
96dbecec24
[DDC-3382] Allow orphan removal to be cancelled
2015-06-12 16:44:13 +02:00
Marco Pivetta
14ff7f50cf
Updating contributing notes to latest composer standard
2015-06-11 14:08:34 +01:00
Frédéric Hardy
b6d29c8b72
Remove (useless?) call to parser::getLexer()
...
The `$lexer` variable is not used, the method `parser::getLexer()` is just a dumb getter and do nothing, so in my opinion, the call to `parser::getLexer()` is useless in this context.
Can you confirm?
2015-06-08 16:04:58 +02:00
Restless-ET
b33612f9e7
[2.5][Bug] Fix ConvertDoctrine1Schema->getMetadata
...
This bug was introduced at #1205 while resolving #1200 .
2015-06-05 17:08:50 +01:00
Iain Cambridge
8625ca5187
Allow null to be passed to setHydrationCacheProfile
...
Currently null can be passed and is set as default, however if you do this you get an exception. This allows null to be passed and set.
There is an if statement later on to see if $this->_hydrationCacheProfile is null so it seems logical you can set it to be null.
2015-05-20 15:10:01 +02:00
Thomas Häber
d92785811b
Added PHPDoc return type false of next method
...
Because hydrateRow can return false, too. The PHPDoc return type of the next method has return false in addition to array.
2015-05-15 12:06:56 +02:00
Logan Bailey
272e8aa6f1
[doc] Remove unused variable from sample code
...
Removes lexer since it's not used.
2015-05-14 11:51:01 -07:00
Ilya Antipenko
6a98f0391d
Add return to removeMethodTemplate
2015-05-13 15:52:38 +03:00
Christopher Gross
702b8b3309
add default value for GeneratedValue
2015-05-12 14:16:02 +02:00
Sergio Santoro
8c6607532b
EntityManager#getReference throw ORMException for unrecognized id
...
- Unreachable statements have been removed
- Throw ORMException for unrecognized identifier field (same
behavior as EntityManager#find)
2015-05-10 00:28:28 +02:00
Marco Pivetta
900b55d16a
Merge pull request #1404 from stephan281094/typo
...
Fix PHPDoc typo
2015-05-07 13:36:20 +01:00
Stephan de Vries
f61526d3ff
Fix PHPDoc typo
2015-05-07 14:05:20 +02:00
photodude
4d6dfb2b81
PostgreSQL currently unsupported by HHVM
...
- Supported but you have to [install an officially supported dependency.](https://github.com/PocketRent/hhvm-pgsql/tree/releases )
2015-05-06 19:45:36 -06:00
photodude
652f999e83
pgsql and mysqli are supported by HHVM
...
- reference to [Known compatible extensions for HHVM](http://docs.hhvm.com/manual/en/extensions.alphabetical.php )
2015-05-06 19:45:24 -06:00
Marco Pivetta
330f88e44b
Merge pull request #1401 from stof/patch-2
...
Remove HHVM-nightly builds
2015-05-05 10:03:25 +01:00
Christophe Coevoet
1b9e197ff3
Remove HHVM-nightly builds
...
hhvm-nightly is not available anymore on Travis because HHVM dropped support for Ubuntu Precise, which is still used by Travis.
2015-05-05 10:41:44 +02:00
Wojciech Zylinski
af2295b73a
Switch to relationToTargetKeyColumns when matching non-owning side with Criteria. Fixes DDC-3719.
2015-05-03 18:39:51 +01:00
Adam Prager
961bff6a80
Initializing embeddables doc
2015-04-27 17:23:40 +02:00
Andrew Berry
f91fadd00c
Not all cache drivers are explicitly documented.
2015-04-19 20:51:46 -04:00
Andrew Berry
3d0f44f596
Document the ChainCache class.
2015-04-19 20:47:36 -04:00
Steve Müller
71d134fcc0
Merge pull request #1379 from holtkamp/patch-1
...
Added missing 'new' keyword for logger instantiation
2015-04-18 11:13:31 +02:00
Steve Müller
b8ef6cfd2f
Merge pull request #1384 from TomasVotruba/patch-1
...
cs
2015-04-18 11:07:17 +02:00
Steve Müller
2706812b37
Merge pull request #1385 from TomasVotruba/patch-2
...
duplicated param in phpdoc
2015-04-18 11:03:09 +02:00
Steve Müller
5ac291d0f4
Merge pull request #1386 from TomasVotruba/patch-3
...
PersisterException: missing license added
2015-04-18 10:57:12 +02:00
Tomáš Votruba
b3b0f6bd5b
PersisterException: missing license added
2015-04-17 12:46:52 +02:00
Tomáš Votruba
6fae618669
duplicated param in phpdoc
2015-04-17 10:13:40 +02:00
Tomáš Votruba
a71f2ba76f
cs
2015-04-17 10:12:18 +02:00
Guilherme Blanco
5f18618355
Merge pull request #1382 from holtkamp/patch-second-level-cache-association-hydration
...
Patch second level cache association hydration
2015-04-14 11:37:54 -04:00
Menno Holtkamp
5f891435f1
Use early return
2015-04-14 16:02:36 +02:00
Menno Holtkamp
34b6ce9259
Introduced getCacheEntryKey() to combine region name and cache key
2015-04-14 09:52:25 +02:00
Menno Holtkamp
dbc29d28d2
Simplified way to fetch multiple entries when index does not matter
2015-04-14 09:47:57 +02:00
Menno Holtkamp
012f33524b
Fixed some typo's
2015-04-14 09:43:22 +02:00
Menno Holtkamp
c236a67096
Used index as key to retrieve proper entry
2015-04-13 23:33:09 +02:00
Menno Holtkamp
74964e7d85
Improved testing region->getMultiple()
2015-04-13 23:31:19 +02:00
Menno Holtkamp
eef81b6eb9
Added missing 'new' keyword for logger instantiation
2015-04-09 15:06:41 +02:00
Bill Schaller
3f84be7b7c
Merge pull request #1377 from fprochazka/bugfix/paginator
...
LimitSubqueryOutputWalker: fix aliasing of property in OrderBy from MappedSuperclass
2015-04-08 20:05:51 -04:00
Filip Procházka
e501137d1a
LimitSubqueryOutputWalker: fix aliasing of property in OrderBy from MappedSuperclass
2015-04-09 01:43:05 +02:00
Filip Procházka
192da14842
Failing test case for broken paginator case
2015-04-09 01:42:46 +02:00
Michał Bundyra
699a6e1783
prevent duplicate unique index
2015-04-08 10:49:21 +01:00
Marco Pivetta
2c90930068
Merge pull request #1374 from mbeccati/fix-DDC767Test-php7-pg94
...
Fix DDC767Test failing on php7 + pg94
2015-04-06 04:22:24 +01:00
Marco Pivetta
6a41b73318
Merge pull request #1373 from aivus/patch-1
...
Add note about "symfony/yaml" dependency for yml mappings
2015-04-06 04:09:51 +01:00
Matteo Beccati
e7397ff62e
Fix DDC767Test failing on php7 + pg94
...
The failure happens when running the full suite or even just:
phpunit tests/Doctrine/Tests/ORM/Functional/Ticket
2015-04-05 21:50:25 +02:00
Ilya Antipenko
a14517dc9d
Add note about "symfony/yaml" dependency for yml mappings
2015-04-05 15:26:12 +03:00
Bill Schaller
354ccdc58b
Merge pull request #1361 from Ocramius/hotfix/array-property-initialization
...
Hotfix: Reverting BC Break - PersistentCollection should accept `null` and `array` as constructor parameter
2015-04-04 20:26:19 -04:00
Marco Pivetta
ea824f39a9
Merge branch 'hotfix/#1365-query-dql-function-test-determinism'
2015-04-05 00:09:47 +01:00
Bill Schaller
f93f601715
fix rare query test failures due to nondeterminism without order by clause
2015-04-05 00:09:38 +01:00
Marco Pivetta
19e24eeb23
Merge pull request #1369 from DavidPrevot/clean-up
...
Drop empty file
2015-04-05 00:03:10 +01:00
Marco Pivetta
63d86c2e0f
Merge pull request #1371 from TomasVotruba/patch-2
...
Readme: drop "Downloads" link
2015-04-05 00:02:02 +01:00
Tomáš Votruba
c162b593be
Readme: drop "Downloads" link
...
Probably deprecated option
2015-04-05 00:38:43 +02:00
Marco Pivetta
a661a7371d
Merge pull request #1370 from TomasVotruba/vendor-clean
...
drop doctrine/common git submodule
2015-04-04 22:49:20 +01:00
Tomas Votruba
8f758dc932
drop doctrine/common git submodule
2015-04-04 22:43:50 +02:00
David Prévot
6f033a2c47
Drop empty file
2015-04-04 15:37:59 -04:00
Marco Pivetta
c7c6822c56
Merge pull request #1368 from TomasVotruba/patch-2
...
Readme: coverage badge for 2.4 added
2015-04-04 18:49:35 +01:00
Tomáš Votruba
257bf81a3b
Readme: coverage badge for 2.4 added
2015-04-04 19:47:43 +02:00
Marco Pivetta
fb055b5eab
Merge pull request #1366 from shieldo/patch-3
...
[Documentation] typo fixes
2015-04-04 00:29:33 +01:00
Douglas Greenshields
fb96a65733
[Documentation] typo fixes
2015-04-04 00:22:00 +01:00
Bill Schaller
052b8e802f
Merge pull request #1364 from shieldo/embeddedables
...
[Documentation] correct naming of Embeddable Objects feature
2015-04-03 12:08:37 -04:00
Douglas Greenshields
16a3d0d769
[Documentation] correct naming of Embeddable Objects feature
2015-04-03 17:05:47 +01:00
Bill Schaller
4a358284f6
Merge pull request #1363 from shieldo/patch-2
...
merged #1363
2015-04-03 10:53:48 -04:00
Douglas Greenshields
08b66f09b1
remove disclaimer about ORM 2.5 being in beta
2015-04-03 15:52:22 +01:00
Marco Pivetta
2a81adc1fc
Correcting ObjectHydrator logic: if an array is a default value for a collection-valued property, it should be cast to a Collection
2015-04-03 15:28:53 +01:00
Marco Pivetta
f0d2e8d150
Correcting static introspection issue in cache specific tests (null was being passed to a PersistentCollection)
2015-04-03 15:28:13 +01:00
Marco Pivetta
95b128ce8f
Removing irrelevant tests (as per discussion with @guilhermeblanco and @stof
2015-04-03 15:27:13 +01:00
Marco Pivetta
d49c907934
a PersistentCollection should only allow another collection as a wrapped collection
2015-04-03 15:26:38 +01:00
Tomas Votruba
e5efc23642
Readme: renamed to standard md suffix
2015-04-03 14:55:28 +02:00
Tomas Votruba
23fb24e2be
Readme: nicer badges
2015-04-03 14:55:09 +02:00
Marco Pivetta
ad5de6f67a
Merge pull request #1362 from TomasVotruba/patch-2
...
Readme: badges for 2.5 added; 2.3- dropped
2015-04-03 13:49:55 +01:00
Tomáš Votruba
8a4d1e2cf6
Readme: badges for 2.5 added; 2.3- dropped
...
If I understand [2.5 release info](https://github.com/doctrine/doctrine2/releases/tag/v2.5.0 ) correctly, 2.4 will have last bugfix, then security fixes. I suppose then 2.3 and lower are in EOL, thus not needed to check badge for. Also they don't have any branch.
2015-04-03 14:16:48 +02:00
Marco Pivetta
1993aecd4c
Reverting BC break: PersistentConnection#__construct() now accepts null|array|Collection again
2015-04-02 23:45:46 +01:00
Marco Pivetta
6b5188fee8
FQCN reference (class was not imported correctly)
2015-04-02 23:45:12 +01:00
Marco Pivetta
670972d5c3
PersistentCollection should still accept null and array as constructor argument, as it did before
2015-04-02 23:44:12 +01:00
Marco Pivetta
3bc3aeeb52
Minor docblock correction (discovered during testing)
2015-04-02 23:43:41 +01:00
Marco Pivetta
21b70577d3
Hydration of fetch-joined results fails when an entity has a default value of array for the collection property
2015-04-02 23:43:16 +01:00
Marco Pivetta
6b94dc61c6
Merge branch 'hotfix/#1360-docs-fix-misleading-embeddable-documentation-prefix'
2015-04-02 23:25:02 +01:00
Stefan Blanke
293c6f6313
Fixed misleading typo in Embeddables tutorial
2015-04-02 23:19:26 +02:00
Marco Pivetta
f495dfcc9c
Merge branch 'docs/#1359-correcting-mapping-in-working-with-objects-reference'
2015-04-02 21:55:57 +01:00
Juti Noppornpitak
3b6616fe65
Fixed typo in the documentation
2015-04-02 16:46:25 -04:00
Marco Pivetta
f20de54281
Bumping version to 2.6.0-DEV
2015-04-02 21:42:47 +01:00
Marco Pivetta
aa80c7d2c5
Preparing for v2.5.0 release
2015-04-02 21:40:18 +01:00
Marco Pivetta
f8270d7bb2
Bumping branch alias for master to 2.6.x-dev
2015-04-02 21:40:05 +01:00
Marco Pivetta
7ecadb4c61
Merge pull request #1358 from zerocrates/patch-1
...
Update docs for clear-cache commands
2015-04-02 20:33:51 +01:00
Marco Pivetta
014d554c28
Merge pull request #1355 from scaytrase/patch-1
...
[Docs] TablePrefix example - Check for being the owning side
2015-04-02 20:31:27 +01:00
Marco Pivetta
8d186528e6
Merge pull request #1357 from DavidPrevot/exec
...
Drop useless execution bit
2015-04-02 20:30:23 +01:00
John Flatness
5058312d6d
Update clear-cache command docs
2015-04-01 17:10:40 -04:00
David Prévot
b7cf41ca45
Drop useless execution bit
2015-04-01 16:01:22 -04:00
Pavel Batanov
ac70c18d50
Check for the being owning side
...
* Small fix do get rid of notice `undefined index 'joinTable'` as the inverse side does not declare `joinTable` at all.
* Shortened access to `$classMetadata->associationMappings[$fieldName]` for read accesses to increase readability
2015-04-01 14:55:52 +03:00
Marco Pivetta
61bcfda167
Bumping version to v2.5.0-DEV
2015-03-31 22:13:40 +01:00
Marco Pivetta
afd0f28c5f
Bumping version for v2.5.0-RC2 release
2015-03-31 22:12:50 +01:00
Marco Pivetta
13ef9fd179
Merge branch 'hotfix/#1350-default-property-value-for-sql-filter'
...
Close #1350
2015-03-31 22:03:20 +01:00
Marco Pivetta
9a2afd1a9a
#1350 - parameters should be an array by default
2015-03-31 22:02:48 +01:00
mmoreram
f6a1ea4859
Assigned default value to array
...
* For strict configurations of PHP, we were accessing to a non-array element
2015-03-31 22:02:05 +01:00
Marco Pivetta
82230cc427
Merge branch 'hotfix/#1353-#1347-#1351-fix-paginator-sorting-and-fetch-joining'
...
Close #1353
2015-03-31 21:55:27 +01:00
Marco Pivetta
ba00fc1e90
#1353 #1347 #1351 - s/inSubselect/inSubSelect (with docblock documentation)
2015-03-31 21:51:56 +01:00
Marco Pivetta
6c5dbd8d4c
#1353 #1347 #1351 - Removing double quotes (confusing)
2015-03-31 21:50:08 +01:00
Bill Schaller
5c93e61686
Fix issue in LimitSubqueryOutputWalker with entities having field names different from column names
2015-03-31 21:39:21 +01:00
Kristopher Wilson
9d7aa9ba39
Adding failing test case for PaginationTest
...
The failure comes into play when an entity has an attribute named
differently from its corresponding column name.
2015-03-31 21:39:21 +01:00
Bill Schaller
608dfa2f57
Add more detection in LimitSubqueryWalker for conditions that must be handled by LimitSubqueryOutputWalker
2015-03-31 21:39:20 +01:00
Bill Schaller
b76107e20f
resolve review comments from @stof
2015-03-31 21:39:20 +01:00
Bill Schaller
edcc0fc024
Fix paginator when ordering by while selecting entities using joined table inheritance
2015-03-31 21:39:20 +01:00
Bill Schaller
09d28819b5
Fix issue where paginating on a query with a subquery in the where clause crashed
2015-03-31 21:38:58 +01:00
Bill Schaller
af3f5c5c5a
Add test for paginating on a query with a subquery in the where clause
...
Conflicts:
tests/Doctrine/Tests/ORM/Tools/Pagination/LimitSubqueryOutputWalkerTest.php
2015-03-31 21:38:58 +01:00
Kristopher Wilson
a4aa18f796
test case for joined table inheritance pagination
2015-03-31 21:38:58 +01:00
Bill Schaller
010d52378c
Fix LimitSubqueryOutputWalkerTest
2015-03-31 21:36:33 +01:00
Bill Schaller
a8342a4be2
Cleanup
2015-03-31 21:36:33 +01:00
Alexander Orabey
f92307d06d
problem with LimitSubqueryOutputWalker when use InheritanceType
...
Conflicts:
tests/Doctrine/Tests/OrmFunctionalTestCase.php
2015-03-31 21:36:32 +01:00
Bill Schaller
ff75a3ad49
Fix paginator issues when ordering by a joined column from a to-many association.
...
Manual merge testcase from #1351
2015-03-31 21:36:32 +01:00
Bill Schaller
54d7efd92c
Fix LimitSubqueryOutputWalker when used on tables with joined table inheritance
2015-03-31 21:32:28 +01:00
Marco Pivetta
b923c937e2
Merge branch 'hotfix/#1352-entity-generator-new-class-metadata-hotfix'
...
Close #1352
2015-03-31 08:45:48 +01:00
Fedik
5cd8334897
fix EntityGenerator RegenerateEntityIfExists
2015-03-27 13:10:14 +02:00
Marco Pivetta
60bacda685
Bumping version to 2.5.0-DEV
2015-03-25 23:16:30 +00:00
Marco Pivetta
df902c9c6a
Preparing release v2.5.0-RC1
2015-03-25 23:14:52 +00:00
Marco Pivetta
cf1ecffb14
Merge pull request #1339 from BenMorel/dqlcustomtype
...
[DDC-2224] Honor convertToDatabaseValueSQL() in DQL query parameters
2015-03-25 01:27:05 +00:00
Benjamin Morel
9eb458caa6
Query::_getQueryCacheId() directly accesses $this->_parsedTypes
2015-03-24 17:14:45 +01:00
Marco Pivetta
dc99ed286a
Merge branch 'hotfix/#1342-paginator-functional-test-integration-take2'
...
Close #1342
Close #1337
Close #1325
2015-03-24 00:39:03 +00:00
Marco Pivetta
d97d3ec0e5
Minor CS fixes (braces)
2015-03-24 00:37:17 +00:00
Marco Pivetta
45d39dd50d
Making preserveSqlOrdering API private
2015-03-24 00:36:13 +00:00
Marco Pivetta
6dfff304f3
Merge branch 'hotfix/#1337-fix-oracle-postgresql-paginator-sorting-issues' into hotfix/#1342-paginator-functional-test-integration
2015-03-24 00:25:12 +00:00
Bill Schaller
147bdd8ede
Fixed nitpicks from @stof
2015-03-24 00:25:12 +00:00
Bill Schaller
81ccd93b74
Add thorough functional tests for Paginator, expand existing ones.
2015-03-24 00:25:12 +00:00
Marco Pivetta
06998d015f
Skipping DDC-3634 tests when a post-insert generator is unavailable
2015-03-24 00:20:03 +00:00
Marco Pivetta
70c8591bbe
Merge pull request #1343 from karlrixon/master
...
Support embeddables in partial object query expression [DDC-3621]
2015-03-23 23:43:36 +00:00
Marco Pivetta
22d699008c
Merge branch 'hotfix/#1346-post-insert-big-integer-cast-avoidance'
...
Close #1346
2015-03-23 23:38:21 +00:00
Marco Pivetta
4c119c44a1
Completed test coverage for DDC-3634
2015-03-23 23:37:36 +00:00
Marco Pivetta
cbdf23ca65
Verifies that identifiers are kept as strings when dealing with large numbers
2015-03-23 23:29:22 +00:00
Marco Pivetta
34168d7085
Merge pull request #1345 from zeroedin-bill/fix-crash-in-convertmapping-command
...
Fix crashes in ConvertMappingCommand and GenerateEntitiesCommand...
2015-03-23 22:35:33 +00:00
Jonathan H. Wage
525c77d4a1
Update docs theme submodule.
2015-03-23 22:10:06 +00:00
Josef Kříž
e57be9da5e
Fix: generated IDs are converted to integer
2015-03-23 17:51:04 +01:00
Karl Rixon
6070c9395d
Functional tests for partial selection with embeddables [DDC-3630]
2015-03-23 15:44:06 +00:00
Josef Kříž
d1a695b42b
Typo in phpdoc
2015-03-23 15:57:41 +01:00
Bill Schaller
4b10db3a43
Fix crashes in ConvertMappingCommand and GenerateEntitiesCommand when using entities with joined table inheritance
...
ConvertMappingCommand and GenerateEntitiesCommand both use the DisconnectedClassMetadataFactory, which allows metadata manipulation without loading the associated classes. Commit a36bea broke these two commands by adding a bailout condition in ClassMetadataFactory::populateDiscriminatorValue which checks $metadata->reflClass->isAbstract(). If the DisconnectedClassMetadataFactory is being used, $metadata->reflClass will always be null, causing a fatal error, "Fatal error: Call to a member function isAbstract() on null".
This commit adds a check to see if $metadata->reflClass is set before checking isAbstract.
2015-03-20 13:59:27 -04:00
Guilherme Blanco
e6887954ec
Merge pull request #1344 from zeroedin-bill/fix-slc-tests-console-decoration
...
Fix tests for SLC console commands failing due to console output decoration
2015-03-20 13:52:00 -04:00
Bill Schaller
b057b64c1c
Fix tests for SLC console commands failing due to comparison with decorated console output.
2015-03-20 13:45:49 -04:00
Bill Schaller
4c84f54493
Fix failures on SQL Server due to scalar select items not having an alias
2015-03-19 17:09:47 -04:00
Bill Schaller
591fd00d73
Fix capitalization of mapping annotations in PaginationTestCase.php
2015-03-19 16:47:04 -04:00
Marco Pivetta
24425436b0
Bumping version constants to 2.5.0-DEV
2015-03-18 22:38:42 +00:00
Marco Pivetta
483d48cc54
Bumping version constants for the 2.5.0-BETA1 release
2015-03-18 22:38:18 +00:00
Marco Pivetta
05db65d034
Merge pull request #1341 from javiereguiluz/patch-6
...
[doc] Minor fixes and typos
2015-03-18 22:02:15 +00:00
Javier Eguiluz
be18915ed6
Minor fixes and typos
2015-03-18 17:27:31 +01:00
Benjamin Eberlei
b3a6fb7fde
[DDC-3461] Renamed AssocationBuilder::isPrimaryKey() to makePrimaryKey(). Same for FieldBuilder and depreceating isPrimaryKey(). Adjust tests. Revert change in ClassMetadataInfo and fix bug.
2015-03-18 17:06:30 +01:00
Marco Pivetta
df8be6f31e
Correcting import that was colliding with another already imported User type
2015-03-17 23:58:53 +00:00
Marco Pivetta
4daf383e4f
Merge pull request #1303 from mrkrstphr/querybuilder-get-all-aliases
...
make QueryBuilder::getAllAliases public
2015-03-17 23:33:43 +00:00
Marco Pivetta
3b0fb6b4b8
Merge pull request #1274 from doctrine/persistent-collection-as-lazy-collection
...
PersistentCollection now extends AbstractLazyCollection.
2015-03-17 23:32:17 +00:00
Marco Pivetta
1add0a04fa
Merge pull request #1302 from goetas/pr1301
...
Store column values of not cache-able associations
2015-03-17 23:27:04 +00:00
Benjamin Morel
517cb7e2a2
Honor convertToDatabaseValueSQL() in DQL query parameters
2015-03-18 00:24:41 +01:00
Marco Pivetta
0738571b7d
Merge branch 'feature/#1316-allow-non-public-schema-join-tables'
...
Close #1316
2015-03-17 23:16:26 +00:00
Marco Pivetta
648fde8914
#1316 - removing useless null check (redundant with isset()), cs cleanups
2015-03-17 23:16:16 +00:00
Marco Pivetta
4095bbaa92
#1316 - adding @group annotation to newly introduced tests
2015-03-17 23:15:07 +00:00
Marco Pivetta
0c0d3a1a7c
#1316 - removing unused API from stub class
2015-03-17 23:14:29 +00:00
Marco Pivetta
bfd628e153
#1316 - refactoring test code to reduce the number of actual involved systems (quote strategy)
2015-03-17 23:14:13 +00:00
molchanoviv
ab740abe96
Add DefaultQuoteStrategyTest::testGetJoinTableName() test
2015-03-17 23:03:03 +00:00
molchanoviv
f244db80fb
Allow to join non-public schema tables
2015-03-17 23:03:03 +00:00
Marco Pivetta
8f0b3398d3
Merge branch 'hotfix/#1327-entity-generator-default-property-value-export'
...
Close #1327
2015-03-17 22:47:50 +00:00
Jeremy
ac9a5e69ec
Properly generate default value from yml & xml mapping
2015-03-17 22:47:11 +00:00
Bill Schaller
5c4b6a2140
resolve nitpicks from @Ocramius and @deeky666
2015-03-17 18:44:03 -04:00
Marco Pivetta
ce41e35c1f
Merge branch 'hotfix/#1338-identity-map-garbage-collection-prevention-on-canceled-remove'
...
Close #1338
2015-03-17 22:38:19 +00:00
Marco Pivetta
0a2d9fa130
#1338 - Removing redundant test case
2015-03-17 22:36:00 +00:00
Bill Schaller
d710555265
Remove shameful hack in LimitSubqueryOutputWalker - replace with significantly less shameful hack
2015-03-17 18:32:57 -04:00
Marco Pivetta
504552e779
Adding @group annotations for newly introduced tests
2015-03-17 22:31:05 +00:00
Marco Pivetta
b721841c73
#1338 DDC-3619 - moved test to unit of work tests
2015-03-17 22:30:06 +00:00
nclavaud
b492d61398
Update identityMap when entity gets managed again
...
http://www.doctrine-project.org/jira/browse/DDC-3619
When using SoftDeleteable doctrine extension, an entity can be scheduled
for deletion, then persisted before flushing. In such a case, the entity
was removed from the unit of work identity map and no reference was
hold. This could lead to spl_object_hash collisions, and prevent
another, new entity to be persisted later.
This fix makes sure the unit of work identity map holds a reference to
the entity after it has been soft-deleted.
2015-03-17 22:19:10 +00:00
Bill Schaller
df0875c596
Fix Paginator OrderBy clauses when ordering by columns from non-fetched joined tables
2015-03-17 17:32:28 -04:00
Marco Pivetta
da72f3e62c
Merge branch 'hotfix/#1336-handle-custom-object-type-identifiers-in-uow'
...
Close #1336
2015-03-17 21:31:03 +00:00
Marco Pivetta
5c89bb8c6b
#1336 DDC-3622 - removing implicit cast from string to CustomIdObject in entity API (confusing)
2015-03-17 21:29:30 +00:00
Marco Pivetta
712b6a7a64
#1336 DDC-3622 - adding @group annotations for newly introduced tests
2015-03-17 21:23:16 +00:00
Marco Pivetta
11da060668
#1336 - class constants over string references in tests - removing useless QueryBuilder usage
2015-03-17 21:21:20 +00:00
Marco Pivetta
40c41857e8
#1333 - Removing unused is_string() function call and cast (always a string)
2015-03-17 21:12:20 +00:00
Marco Pivetta
d6687e070e
#1333 - Removing useless is_string() function call, clarifying docblock parameters
2015-03-17 21:11:43 +00:00
Stefano Torresi
5d6a39d14c
fix tests tear down
2015-03-17 21:08:07 +00:00
Stefano Torresi
904bcfa4f9
add docs notice about custom object types as IDs
2015-03-17 21:08:07 +00:00
Stefano Torresi
c7ad932b5f
fix copyright notices
2015-03-17 21:08:07 +00:00
Stefano Torresi
1b850fbb23
add missing return statement
2015-03-17 21:08:07 +00:00
Stefano Torresi
2bdc1142fe
add string casting to id hashes
2015-03-17 21:08:06 +00:00
Stefano Torresi
41e873bd72
add failing functional test for custom id object types
2015-03-17 21:08:06 +00:00
Marco Pivetta
32137c72e4
Merge branch 'hotfix/#1333-datetime-immutable-dql-parameter-inference'
...
Close #1333
2015-03-17 21:01:05 +00:00
Marco Pivetta
376e74fb7e
#1333 - minor CS fixes - spacing/PSR-2
2015-03-17 20:59:56 +00:00
Jan Langer
8ac66bb608
Allow DateTimeInterface as parameter value
2015-03-17 20:58:20 +00:00
Bill Schaller
eebce88146
Revert "Revert "Merge branch 'hotfix/#1220-sort-paginator-subquery-output-only-once'""
...
This reverts commit 6a1755972d .
2015-03-17 13:58:50 -04:00
Karl Rixon
778ed04eac
Support embeddables in partial object query expression [DDC-3621]
2015-03-17 15:46:01 +00:00
Marco Pivetta
2fb11cdf05
Merge pull request #1335 from BenMorel/queryreturntype
...
Fix AbstractQuery::getParameter() documented return type
2015-03-17 14:58:21 +00:00
Benjamin Morel
8d7ba1aebb
Fixed AbstractQuery::getParameter() documented return type
2015-03-17 15:53:09 +01:00
Marco Pivetta
89ab4b3f48
Merge pull request #1334 from acrobat/internal-phpdoc-fix
...
Changed some wrong usage of the @internal phpdoc
2015-03-15 19:08:02 +01:00
Jeroen Thora
a409e7591d
Changed some wrong usage of the @internal phpdoc
2015-03-15 16:53:34 +01:00
Marco Pivetta
6cf76158a0
Merge pull request #1329 from Wilt/patch-1
...
Fix for inconsistent use of getSQLDeclaration
2015-03-13 17:44:40 +01:00
Marco Pivetta
d87118437e
Merge pull request #1330 from coolmic/patch-1
...
Fix @Column options sections in documentation
2015-03-12 22:16:28 +01:00
Marco Pivetta
cdc739b7f8
Merge pull request #1331 from 1ed/patch-2
...
[DOCS] Fixed class name in aggregate fields example
2015-03-12 22:14:38 +01:00
Gábor Egyed
6a75bf078b
[DOCS] Fixed class name in aggregate fields example
2015-03-12 19:27:54 +01:00
Coolmic
f2d8b6d762
Fix @Column options sections
...
I lose hours to find out how to make column collation works, mostly because of incorrect docs.
Annotations options is the equivalent of customSchemaOptions in https://github.com/doctrine/dbal/blob/master/docs/en/reference/schema-representation.rst
See d1e5034659/lib/Doctrine/ORM/Tools/SchemaTool.php (L443)
2015-03-12 12:22:59 +01:00
Wilt
228dc895ca
getSqlDeclaration -> getSQLDeclaration
...
Fixed inconsistent use of getSQLDeclaration method
2015-03-11 14:14:29 +01:00
Wilt
a6931dedaf
getSqlDeclaration -> getSQLDeclaration
...
Fixed inconsistent use of getSQLDeclaration method
2015-03-11 14:07:04 +01:00
Wilt
5ae888b853
getSqlDeclaration -> getSQLDeclaration
...
Fixed inconsistent use of getSQLDeclaration method
2015-03-11 14:06:36 +01:00
Wilt
ea70e080c2
getSqlDeclaration -> getSQLDeclaration
...
Fixed inconsistent use of getSQLDeclaration method
2015-03-11 14:05:36 +01:00
Marco Pivetta
cfc7236599
Merge pull request #1319 from TomasVotruba/patch-1
...
travis: PHP 7.0 nightly added
2015-03-11 01:12:18 +01:00
Marco Pivetta
a3f9f153dd
Merge pull request #1321 from vvh-empora/master
...
embeddedClasses support...
2015-03-10 21:53:05 +01:00
Marco Pivetta
73d4d88ba1
Merge pull request #1326 from guiwoda/orphan-removal-association-builder
...
Allow AssociationBuilder to set a relation as orphan removal
2015-03-09 23:18:59 +01:00
Guido Contreras Woda
71821bb7a3
Allow AssociationBuilder to set a relation as orphan removal
2015-03-09 18:54:35 -03:00
Volker von Hoesslin
0824c6136d
unittest DDC3597: fix for PHP 5.4
2015-03-04 11:55:08 +01:00
Marco Pivetta
34b7f07344
Merge pull request #1322 from dennisbirkholz/patch-1
...
Typo in documentation
2015-03-04 03:07:37 +00:00
Volker von Hoesslin
2aef87c9b2
add unittest for DDC3597
2015-03-03 16:59:48 +01:00
Dennis Birkholz
69e5562de4
Typo in documentation
...
Two list items where just one
2015-03-03 16:57:51 +01:00
vvh-empora
6afcac84d0
embeddedClasses support...
...
...for JoinedSubclassPersister.php
2015-03-03 11:40:19 +01:00
Tomas Votruba
0e14136fad
travis: PHP 7.0 nightly added
2015-03-02 20:41:50 +01:00
Marco Pivetta
f2f47930e6
Merge pull request #1320 from joshdifabio/patch-1
...
Fix 'entitiy' typo in Getting Started tutorial
2015-03-02 16:58:05 +00:00
Joshua Di Fabio
dce76bba60
Fix 'entitiy' typo in Getting Started tutorial
2015-03-02 16:53:44 +00:00
Guilherme Blanco
b1d918b124
Fixed more broken tests.
2015-03-01 23:57:38 -05:00
Guilherme Blanco
588c92875d
Removed fragile test.
2015-03-01 00:32:43 -05:00
Guilherme Blanco
19f18fa069
PersistentCollection now extends AbstractLazyCollection.
2015-03-01 00:30:21 -05:00
Guilherme Blanco
6e40361fe7
Merge pull request #1311 from jankramer/DDC-3582-nested-embeddable-hydration
...
[DDC-3582] Wrong class is instantiated when using nested embeddables
2015-02-27 10:31:58 -05:00
Jan Kramer
f09b9895b6
Fix embeddable instantiation in nested situations
2015-02-27 15:09:58 +01:00
Jan Kramer
c059de9e60
Implement test to show nested embeddables are not instantiated properly
2015-02-27 15:09:22 +01:00
Marco Pivetta
a41e774bb1
Merge pull request #1314 from FabioBatSilva/date-add-second
...
DATE_ADD - Support for seconds
2015-02-26 10:20:52 +00:00
Marco Pivetta
94223621dc
Merge pull request #1315 from GeekMode/GeekMode-patch-url-fix
...
Fixed broken url for implementing Serializable interface
2015-02-26 08:49:22 +00:00
Niro
1afaec9cbf
Fixed broken url for implementing Serializable interface
2015-02-26 02:53:37 -05:00
Guilherme Blanco
7fc1dc9209
Merge pull request #1313 from doctrine/querybuilder-indexby
...
Added programmatical support to define indexBy on root aliases.
2015-02-25 14:42:13 -05:00
FabioBatSilva
57bcd7cd3d
DATE_ADD - Support for seconds
2015-02-25 14:32:51 -05:00
Guilherme Blanco
5ab4c3d50c
Added programatical support to define indexBy on root aliases.
2015-02-25 14:29:10 -05:00
Guilherme Blanco
1369cdda2b
Merge pull request #1312 from ThomasLomas/master
...
Add proper pluralization into UpdateCommand
2015-02-24 13:37:34 -05:00
Thomas Lomas
37f5c82d15
Add proper pluralization into UpdateCommand
2015-02-24 18:13:13 +00:00
Asmir Mustafic
d33ee5e7ff
Removed unnecessary API from test cases
2015-02-24 08:53:22 +01:00
Nicolas Grekas
bad6593460
Allow symfony 3.0 components
...
Tests should tell if any deprecated interfaces of Symfony are used. If not, then the bundle is defacto compatible with 3.0
2015-02-22 20:13:44 +01:00
Guilherme Blanco
4680a7b861
Fixed bug where embedded reflection fields were never exposed to userland.
2015-02-20 14:10:28 -05:00
Asmir Mustafic
4d43f5ca52
Tested composite keys on non cache-able entities
2015-02-20 19:00:32 +01:00
Asmir Mustafic
d72ad9cc50
Handling composite keys on non cache-able entities
2015-02-20 10:00:36 +01:00
Marco Pivetta
38c819ae04
Merge pull request #1305 from guillaumerobin/patch-2
...
Documentation : fix table prefix with STI
2015-02-16 21:35:28 +00:00
Guillaume Robin
1661d96b92
Documentation : fix table prefix with STI
...
If an Entity use STI, it gets its table name from the parent class. In this case, we need to check that the class is the root class of the hierarchy when adding prefix, otherwise children class are prefixed twice.
2015-02-16 22:11:30 +01:00
Kristopher Wilson
a6448f5c77
make QueryBuilder::getAllAliases public
2015-02-16 08:31:14 -05:00
Asmir Mustafic
24dd0c6a55
Fixed delete order on tearDown method
2015-02-16 08:55:27 +01:00
Asmir Mustafic
b9577bf2f3
Added tests for many-to-one non cache-able relations
2015-02-16 08:55:27 +01:00
Asmir Mustafic
60164931b8
Handled one-to-many non cache-able relations
2015-02-16 08:55:27 +01:00
Asmir Mustafic
a2461d6d5f
Use identifier flattener to retrevie entity identifiers
2015-02-16 08:55:27 +01:00
Asmir Mustafic
58e20c70c6
Store column values of not cache-able associations
2015-02-16 08:55:27 +01:00
Michaël Gallego
ed6fa0deb4
Add failing test
2015-02-16 08:55:27 +01:00
Marco Pivetta
a13143b1ac
Merge branch 'feature/#1229-to-one-association-builder'
...
Close #1229
2015-02-16 02:06:32 +00:00
Marco Pivetta
1f67218dc5
#1229 - code style fixes (alignment/spacing)
2015-02-16 02:06:22 +00:00
Guido Contreras Woda
baeab5d4f4
More consistent test naming
2015-02-16 02:02:29 +00:00
Guido Contreras Woda
51881fed94
Added tests and validation on joinColumns being set before checking if its a composite key.
2015-02-16 02:02:29 +00:00
Guido Contreras Woda
cd728344e9
Allow an association to be set as primary key through the builder
2015-02-16 02:02:29 +00:00
Marco Pivetta
b5238966d1
Merge branch 'hotfix/#1295-fix-join-when-re-creating-query-builder-from-parts'
...
Close #1295
2015-02-16 01:23:54 +00:00
Dries De Peuter
4a6afb46e2
Fix join when recreation of query from parts.
2015-02-16 01:23:27 +00:00
Marco Pivetta
f90897465c
Merge branch 'hotfix/#1113-composite-pk-improved-support'
...
Close #1113
2015-02-16 01:17:48 +00:00
Marco Pivetta
2a99d5a19b
#1113 - minor CS fixes (spacing/alignment)
2015-02-16 01:02:56 +00:00
Asmir Mustafic
8eea7c86f7
Resolve association entries on multi get cache
2015-02-16 00:53:48 +00:00
Asmir Mustafic
cb52782e5e
Default Version Value identifier is always an array
2015-02-16 00:53:47 +00:00
Asmir Mustafic
c9e66e464d
Changed getSelectConditionStatementColumnSQL return docblock
2015-02-16 00:53:47 +00:00
Asmir Mustafic
1630ec1ebd
Fixed owing-inverse side search by criteria
2015-02-16 00:53:47 +00:00
Asmir Mustafic
4d531d8855
Right type detection on to-many relations
2015-02-16 00:53:47 +00:00
Asmir Mustafic
4323d9ce4c
Removed unused methods
2015-02-16 00:53:47 +00:00
Asmir Mustafic
7948b0c160
Identity map check
2015-02-16 00:53:47 +00:00
Asmir Mustafic
5838115582
Fixed type checking on to-many relations
2015-02-16 00:53:47 +00:00
Asmir Mustafic
2e890362c5
Tested second level cache with composite primary keys
2015-02-16 00:53:46 +00:00
Asmir Mustafic
51b34919ba
Second level cache check with composite primary keys
2015-02-16 00:53:46 +00:00
Asmir Mustafic
7222991b13
Tested composite primary key support
2015-02-16 00:53:46 +00:00
Asmir Mustafic
5e29bbd41f
Improved composite primary key support
2015-02-16 00:53:46 +00:00
Asmir Mustafic
2eb7dedf4f
Refactored IdentifierFlattener
2015-02-16 00:53:46 +00:00
Marco Pivetta
081ad0efbe
Merge pull request #1297 from eugene-dounar/docs-embeddable-mapping
...
[DDC-3480] Docs: Embeddable supported mappings
2015-02-14 23:20:09 +01:00
Marco Pivetta
eb90cf0c3b
Merge pull request #1298 from eugene-dounar/docs-clean-up-toc
...
Docs: Remove empty pages from TOC
2015-02-14 23:18:48 +01:00
Guilherme Blanco
4c68a38bd6
Merge pull request #1294 from weaverryan/target-platform-when-needed
...
Avoid Connection error when calling ClassMetadataFactor::getAllMetadata()
2015-02-04 16:42:55 -05:00
Ryan Weaver
0e08633790
Adding docblock
2015-02-04 13:51:02 -05:00
Ryan Weaver
75bb3a0de3
Small code change thanks to the comments and adding a test
2015-02-04 13:49:51 -05:00
Steve Müller
a0f3b75ec0
Merge pull request #1299 from javiereguiluz/patch-5
...
Fixed missing quote in one DQL example
2015-02-04 11:40:57 +01:00
Javier Eguiluz
aa0f18def3
Fixed missing quote in one DQL example
2015-02-04 11:12:15 +01:00
Eugene Dounar
f996f6583a
Remove empty pages from TOC
...
Remove Installation page from TOC as it was moved to "Installation and
Configuration"
2015-02-04 00:44:57 +03:00
Eugene Dounar
cd7f91910b
Docs: Embeddable supported mappings
...
Mention that only basic mapping is supported by embeddables
2015-02-04 00:17:13 +03:00
Marco Pivetta
78d3f51140
Merge pull request #1296 from joenivl/patch-1
...
Flip key value in $namespaces array
2015-02-03 14:48:44 +00:00
Jeroen van Leeuwen
f9cf2b6a95
Flip key value in $namespaces array
...
Key value should be other way around.
2015-02-03 14:54:21 +01:00
Guilherme Blanco
64ef89ce4c
Merge pull request #1292 from goetas/private-method-mark
...
Mark getSelectConditionStatementColumnSQL method as private
2015-01-28 22:11:49 -05:00
Ryan Weaver
b30d1dd39c
Only getting the target platform when it's *actually* needed to avoid errors
...
initialize() is called sometimes, even when the following code doesn't need
the targetPlatform property. Specifically, in AbstractClassMetadataFactory::getAllMetadata().
But as of DBAL 2.5.0, calling Connection::getDatabasePlatform() will make a
connection to the database, which means that sometimes it may fail (e.g. you
haven't configured your database yet). As a result, calling a method like
AbstractClassMetadataFactory::getAllMetadata() - which does not need the
targetPlatform - will fail, because determining the targetPlatform requires
a connection, which fails.
This avoids that - we only get the targetPlatform *when* we need it, which
are cases where we're doing things that do indeed need a connection.
2015-01-28 20:17:28 -05:00
Asmir Mustafic
fb5cd928ee
Mark getSelectConditionStatementColumnSQL method as private
2015-01-28 23:55:20 +01:00
Marco Pivetta
17a23ea825
Merge pull request #1222 from guiwoda/embeddables-in-metadata-builder
...
Embeddables in metadata builder
2015-01-28 22:25:10 +00:00
Marco Pivetta
3ed73b4a60
Merge pull request #1288 from Ocramius/hotfix/#1169-extra-lazy-one-to-many-is-noop-when-not-doing-orphan-removal
...
Hotfix - #1169 - extra lazy one to many must be no-op when not doing orphan removal
2015-01-28 20:27:22 +00:00
Marco Pivetta
e76b20b109
#1169 DDC-3343 - removing note about query count assertion
2015-01-28 20:01:57 +00:00
Marco Pivetta
ffaffa0b8a
Merge pull request #1290 from phansys/doc-slc
...
[Doc] [Reference] [Second Level Cache]
2015-01-27 16:37:22 +00:00
Javier Spagnoletti
c6158ae3f4
Updated reference for Second Level Cache (fixed some typos and docblocks).
2015-01-27 13:24:35 -03:00
Marco Pivetta
969788d928
Merge pull request #1289 from deeky666/improve-testsuite
...
Improve test suite
2015-01-27 12:24:36 +00:00
Steve Müller
3b61d2d0fe
initialize database schema only once and avoid unnecessary connections
2015-01-27 12:28:31 +01:00
Steve Müller
75e41eefb5
fix indentation
2015-01-27 10:02:57 +01:00
Steve Müller
5795d53ca7
remove temporary database dependencies from Travis build
2015-01-27 09:44:06 +01:00
Steve Müller
2fbc483fe3
apply current implementation from DBAL @ dcdf744e3fdd2ba99239ee41009e08a4b6450eff
2015-01-27 09:40:45 +01:00
Marco Pivetta
c7a6352b08
#1169 DDC-3343 - eagerly evicting cache if a persister passes a delete operation down to the DB
2015-01-27 09:04:28 +01:00
Marco Pivetta
a9671fdc2e
#1169 DDC-3343 - eagerly evicting cache if a persister passes a delete operation down to the DB
2015-01-27 09:04:00 +01:00
Marco Pivetta
c4019d96b9
#1169 DDC-3343 - when a deletion fails for some reason, related cache entries should be evicted to avoid collisions with DB state
2015-01-27 09:03:36 +01:00
Marco Pivetta
f32766c00d
#1169 DDC-3343 - when using one-to-many extra-lazy with orphan-removal, referenced entities should be deleted directly
2015-01-27 07:46:31 +01:00
Marco Pivetta
3f28adf9b6
#1169 DDC-3343 - correcting collection name used in tests
2015-01-27 07:45:58 +01:00
Marco Pivetta
a0eb6005f3
#1169 DDC-3343 - adding tests for orphan-removal + extra-lazy + one-to-many element removal behavior
2015-01-27 07:42:48 +01:00
Marco Pivetta
9eaac13615
#1169 DDC-3343 - correcting one-to-many persister - association should not be updated directly if no orphan removal is involved
2015-01-27 06:27:37 +01:00
Marco Pivetta
539c364ca6
#1169 DDC-3343 - updating test expectations - one-to-many changes should be no-op unless orphan removal is specified.
2015-01-27 06:26:55 +01:00
Marco Pivetta
9839c400b8
#1169 DDC-3343 - updating test expectations - one-to-many changes should be no-op unless orphan removal is specified.
2015-01-27 06:19:26 +01:00
Marco Pivetta
7e8d27d41a
Merge pull request #1287 from BenMorel/patch-1
...
Typo fix
2015-01-26 01:53:41 +01:00
Benjamin Morel
58e2510f41
Typo fix
2015-01-25 23:54:59 +01:00
Marco Pivetta
146354d835
Merge pull request #1280 from Ocramius/hotfix/#1277-find-one-with-eager-loads-is-failing
...
[DDC-3346] #1277 find one with eager loads is failing
2015-01-25 06:00:47 +01:00
Marco Pivetta
d024193cc0
Merge pull request #1272 from Ocramius/hotfix/DDC-2704-merge-inherited-transient-properties
...
[DDC-2704] - merge inherited transient properties - merge properties into uninitialized proxies
2015-01-25 05:55:53 +01:00
Marco Pivetta
d62cb6237f
Merge pull request #1286 from Ocramius/feature/remove-xdebug-from-non-coverage-builds
...
Removing XDebug from non-coverage builds
2015-01-25 05:51:11 +01:00
Marco Pivetta
5bf18298b1
Merge pull request #1281 from Ocramius/hotfix/#1169-extra-lazy-one-to-many-should-not-delete-referenced-entities
...
Hotfix/#1169 extra lazy one to many should not delete referenced entities
2015-01-25 05:43:34 +01:00
Marco Pivetta
3570f4a49a
#1277 DDC-3346 - disabling XDebug only for non-hhvm builds
2015-01-25 05:42:24 +01:00
Marco Pivetta
670acfc693
Removing XDebug from non-coverage builds
2015-01-25 05:35:31 +01:00
Marco Pivetta
d4b278c809
#1277 DDC-3346 - removing leftover comments
2015-01-25 05:03:19 +01:00
Marco Pivetta
cb780e8bb6
#1169 DDC-3343 - factoring logging into cached collection persister changes
2015-01-25 04:45:45 +01:00
Marco Pivetta
7e85c94f48
#1169 DDC-3343 - adapting cached collection persister logic to EXTRA_LAZY collection behavior
2015-01-25 04:40:30 +01:00
Marco Pivetta
4a05e19f37
Merge pull request #1283 from Ocramius/hotfix/#1267-order-by-broken-in-pagination-logic
...
#1267 - order by broken in pagination logic (reverts #1220 )
2015-01-24 19:20:00 +01:00
Marco Pivetta
97ea6a7d85
#1277 DDC-3346 - removing array-based persister context handling (better to just use private props)
2015-01-24 14:39:47 +01:00
Marco Pivetta
dff365318d
#1277 DDC-3346 DDC-3531 - enforcing 0 offset to avoid persisting more than 1 row
2015-01-24 14:39:47 +01:00
Marco Pivetta
186c593058
#1277 DDC-3346 DDC-3531 - proper bi-directional association setup
2015-01-24 14:39:46 +01:00
Marco Pivetta
39a8941d1b
#1277 DDC-3346 DDC-3531 - minor CS fixes/cleanups: avoiding setters
2015-01-24 14:39:46 +01:00
Marco Pivetta
04a271a04e
#1277 DDC-3346 DDC-3531 - refactoring test assets for readability
2015-01-24 14:39:46 +01:00
Marco Pivetta
36bc448880
#1277 DDC-3346 DDC-3531 - refactoring test code for simplicity/readability
2015-01-24 14:39:46 +01:00
Marco Pivetta
16f447d1ac
#1277 DDC-3346 DDC-3531 - correct usage of the model set (setUp/tearDown of model-related tables)
2015-01-24 14:39:46 +01:00
Marco Pivetta
6e3ad496e2
#1277 DDC-3346 DDC-3531 - constants over string references
2015-01-24 14:39:45 +01:00
Marco Pivetta
157bf203bc
#1277 DDC-3346 DDC-3531 - additional tests for LIMIT and OFFSET repository API (must not hydrate collections)
2015-01-24 14:39:45 +01:00
Marco Pivetta
1672448993
#1277 DDC-3346 DDC-3531 - renaming persister context switch for clarity
2015-01-24 14:39:45 +01:00
Marco Pivetta
a37fa97be3
#1277 DDC-3346 DDC-3531 - skipping joining of associations when limiting and fetch-joining to-many eager associations
2015-01-24 14:39:45 +01:00
Marco Pivetta
67f60f2286
#1277 DDC-3346 DDC-3531 - switching persister context at runtime, depending on choices
2015-01-24 14:39:44 +01:00
Marco Pivetta
23a0d9a1fb
#1277 DDC-3346 DDC-3531 - switch persister context at runtime
2015-01-24 14:39:44 +01:00
Marco Pivetta
8b9171c8ad
#1277 DDC-3346 DDC-3531 - caching the currently in use persister context
2015-01-24 14:39:44 +01:00
Marco Pivetta
ebdfab8f2c
#1277 DDC-3346 DDC-3531 - moved sqlTableAliases into the newly created CachedPersisterContext
2015-01-24 14:39:44 +01:00
Marco Pivetta
2a7f149029
#1277 DDC-3346 DDC-3531 - moved sqlAliasCounter into the newly created CachedPersisterContext
2015-01-24 14:39:44 +01:00
Marco Pivetta
b9f698c98c
#1277 DDC-3346 DDC-3531 - moved selectJoinSql into the newly created CachedPersisterContext
2015-01-24 14:39:43 +01:00
Marco Pivetta
55930a3402
#1277 DDC-3346 DDC-3531 - moved selectColumnListSql into the newly created CachedPersisterContext
2015-01-24 14:39:43 +01:00
Marco Pivetta
4c62d3bfda
#1277 DDC-3346 DDC-3531 - moved resultsetmapping into the newly created CachedPersisterContext
2015-01-24 14:39:43 +01:00
Pavel Batanov
981cebbf4c
Update test according to @Ocramius notes
2015-01-24 14:39:43 +01:00
Pavel Batanov
e36c7b0c2a
DDC-3346 failing test example
2015-01-24 14:39:42 +01:00
Marco Pivetta
28e0da4321
#1272 DDC-2704 - reverting classmetadata API changes (moved all to reflection property getter API)
2015-01-24 14:32:23 +01:00
Marco Pivetta
d952077d04
#1272 DDC-2704 - using the property getter utility rather than metadata API when fetching reflection properties for a class
2015-01-24 14:30:40 +01:00
Marco Pivetta
05a8e1c77d
#1272 DDC-2704 - test assets for the property getter utility tests
2015-01-24 14:30:07 +01:00
Marco Pivetta
1aa453d493
#1272 DDC-2704 - property getter utility is package private
2015-01-24 14:29:40 +01:00
Marco Pivetta
5ec300452a
#1272 DDC-2704 - implementation for a property getter utility
2015-01-24 14:29:09 +01:00
Marco Pivetta
1b0a5e38d9
#1272 DDC-2704 - specification for a property getter utility
2015-01-24 14:28:54 +01:00
Marco Pivetta
8910c2c482
DDC-2704 - data should be merged only into initialized proxies
2015-01-24 13:22:16 +01:00
Marco Pivetta
91f4ed8b92
DDC-2704 - data should be merged only into initialized proxies
2015-01-24 13:22:16 +01:00
Marco Pivetta
21995a8b10
DDC-2704 - more explicit value checking
2015-01-24 13:22:16 +01:00
Marco Pivetta
30dcece125
DDC-2704 - covering code handling class metadata skipping of static properties
2015-01-24 13:22:16 +01:00
Marco Pivetta
3df9b4d122
DDC-2704 - synchronized model classes to new test code
2015-01-24 13:22:16 +01:00
Marco Pivetta
885700d38c
DDC-2704 - should initializeAllReflectionProperties also on initializeReflection
2015-01-24 13:22:16 +01:00
Marco Pivetta
bd667b82d9
DDC-2704 - carefully checking defined classes in getAllReflectionProperties
2015-01-24 13:22:16 +01:00
Marco Pivetta
a4982a8dc2
DDC-2704 - handling partial initialization of the class as expected (class metadata may not hold reflection class after wakeup)
2015-01-24 13:22:15 +01:00
Marco Pivetta
1e6c071bb8
DDC-2704 - trying to get all reflection properties from a partially initialized class metadata instance will result in a failure
2015-01-24 13:22:15 +01:00
Marco Pivetta
4e08c99b86
DDC-2704 - trying to get all reflection properties from an unitialized class metadata instance will result in a failure
2015-01-24 13:22:15 +01:00
Marco Pivetta
0a3d6966d6
DDC-2704 - providing hotfix - also storing inherited transient properties in the class metadata
2015-01-24 13:22:15 +01:00
Marco Pivetta
5ae980e0f9
DDC-2704 - reducing test case clutter
2015-01-24 13:22:15 +01:00
Marco Pivetta
302e6218bb
DDC-2704 - renaming test case for clarity
2015-01-24 13:22:15 +01:00
Marco Pivetta
942004226c
DDC-2704 - basic test case verifying that merged transient properties are not handled when in an inheritance
2015-01-24 13:22:15 +01:00
Marco Pivetta
6a1755972d
Revert "Merge branch 'hotfix/#1220-sort-paginator-subquery-output-only-once'"
...
This reverts commit 8f097ab304 , reversing
changes made to b23a8dd429 .
Conflicts:
tests/Doctrine/Tests/ORM/Tools/Pagination/LimitSubqueryOutputWalkerTest.php
2015-01-24 13:10:25 +01:00
Austin Morris
c8160fcd0e
Failing test for an ORDER BY that is INNER JOINED in a subquery
2015-01-24 13:07:56 +01:00
Marco Pivetta
01a9dadee7
#1169 DDC-3343 - removed unused imports
2015-01-24 12:54:40 +01:00
Marco Pivetta
b7b716a6bb
#1169 DDC-3343 - moved tests to correct test class
2015-01-24 12:53:48 +01:00
Marco Pivetta
d443d4f3b6
#1169 DDC-3343 - additional test cases: removing proxies from an extra-lazy collection still updates the owning side values
2015-01-24 12:21:21 +01:00
Marco Pivetta
6a2b7c2a8e
#1169 DDC-3343 - correcting query count assertions on extra-lazy specific tests (some DELETE operations became UPDATE operations)
2015-01-24 12:20:33 +01:00
Marco Pivetta
99c5650ba4
#1169 DDC-3343 - removing duplicate test
2015-01-24 11:59:21 +01:00
Marco Pivetta
a8796fa489
#1169 DDC-3343 - integrating tests into the existing test suite
2015-01-24 11:58:57 +01:00
Marco Pivetta
ff986a9bf5
#1169 DDC-3343 - importing used classe
2015-01-24 11:54:58 +01:00
Marco Pivetta
ed0331d25a
#1169 DDC-3343 - optimized imports
2015-01-24 11:54:32 +01:00
Marco Pivetta
43f301fdad
#1169 DDC-3343 - refactoring test to use pre-existing test models
2015-01-24 11:54:17 +01:00
Marco Pivetta
15397bbe40
#1169 DDC-3343 - refactoring test to use pre-existing test models
2015-01-24 11:54:03 +01:00
Marco Pivetta
aed01ea571
#1169 DDC-3343 - minor refactoring: constant over string reference
2015-01-24 11:41:20 +01:00
Marco Pivetta
f184956d3a
#1169 DDC-3343 - one-to-many extra-lazy should not delete associated values when they are removed, but just update the owning side
2015-01-24 11:40:48 +01:00
Andrea Sprega
c2b3348f99
[DDC-3343] Failing test case (updated)
2015-01-24 11:30:17 +01:00
Andrea Sprega
db3697433b
[DDC-3343] Failing test case
2015-01-24 11:30:17 +01:00
Marco Pivetta
3f360d7fbc
Merge branch 'hotfix/#1257-discriminator-map-changes-documentation'
2015-01-24 09:21:27 +01:00
Marco Pivetta
52fb4e53bc
#1257 DDC-3300 DDC-3503 - describing new inheritance map requirements in the upgrade notes/blogpost
2015-01-24 09:21:13 +01:00
Marco Pivetta
efa375ac96
#1257 DDC-3300 DDC-3503 - providing upgrade notes for the breaking change in discriminator map declarations
2015-01-24 09:14:58 +01:00
Marco Pivetta
22533042a5
Merge pull request #1279 from phansys/doc-slc
...
[Doc][Reference][2nd level cache]
2015-01-23 16:25:53 +01:00
Javier Spagnoletti
72785eb27e
[Doc][Reference][2nd level cache]
...
* Fixed typo in TimestampRegion title.
* Normalized php snippets (comments, indentation).
2015-01-23 11:23:21 -03:00
Marco Pivetta
b889e18a9a
Merge branch 'hotfix/#1176-merging-entities-with-composite-association-identifier'
...
Close #1176
2015-01-22 12:11:16 +01:00
Marco Pivetta
a67332fb51
#1176 DDC-3378 - minor CS fixes (imports, spacing, IDE hints)
2015-01-22 12:11:03 +01:00
Marco Pivetta
8305649a45
#1176 DDC-3378 - refactored test logic to use the newly introduced test assets
2015-01-22 12:10:39 +01:00
Marco Pivetta
8987c9ab37
#1176 DDC-3378 - moved test asset entities to proper models directory
2015-01-22 12:07:42 +01:00
Adrien Brault
f189c1aaf0
Update test to valid use case
2015-01-22 11:18:12 +01:00
Adrien Brault
fc8191f557
Naive fix
2015-01-22 11:18:12 +01:00
Adrien Brault
4058ad3958
Add test exposing UnitOfWork merge bug
2015-01-22 11:18:12 +01:00
Marco Pivetta
dfa4bbd67a
Merge branch 'hotfix/resolve-target-entity-also-in-discriminator-map'
...
Close #1257
2015-01-22 09:52:17 +01:00
Marco Pivetta
6547d5462e
#1257 DDC-3300 - strengthening test case (missing assertion, test name)
2015-01-22 09:51:43 +01:00
Marco Pivetta
c1cc768aee
#1257 DDC-3300 - correcting further incomplete discriminator maps in the test suite
2015-01-22 09:50:59 +01:00
Marco Pivetta
cd3ffa8f14
#1130 DDC-3300 - removing typo causing parse error
2015-01-22 09:44:40 +01:00
Marco Pivetta
e969a6be85
#1130 DDC-3300 - rewording and clarifying logic that re-maps discriminator values when needed
2015-01-22 09:44:39 +01:00
Marco Pivetta
635d2c141f
#1130 DDC-3300 - minor CS fix (EOF EOL)
2015-01-22 09:44:39 +01:00
Marco Pivetta
fbe294927f
#1130 DDC-3300 - cleaning up test code
2015-01-22 09:44:39 +01:00
Marco Pivetta
8a6b1b48e3
#1130 DDC-3300 - removing unused ResolveDiscriminatorMapListener and related test
2015-01-22 09:44:39 +01:00
Marco Pivetta
b7c28924b1
#1130 DDC-3300 - fixed inheritance maps where inheritance members were missing
2015-01-22 09:44:39 +01:00
Marco Pivetta
a36bea2951
#1130 DDC-3300 - optimizing performance (looping over existing classes first): throwing exceptions if the class is not found in the discriminator map
2015-01-22 09:44:39 +01:00
Marco Pivetta
8579baf28c
#1130 DDC-3300 - minor refactoring (else removal, spacing)
2015-01-22 09:44:39 +01:00
Marco Pivetta
786c34faa5
#1130 DDC-3300 - refactoring auto-remapping of discriminator value into a private method
2015-01-22 09:44:38 +01:00
Marco Pivetta
c589b5d013
#1130 DDC-3300 - re-mapping discriminator column at runtime (based on modified class metadata)
2015-01-22 09:44:38 +01:00
mmoreram
5a1a32297b
Tested DDC-3300
2015-01-22 09:44:38 +01:00
mmoreram
93b6eeca54
Full resolveTargetEntities as constructor argument
2015-01-22 09:44:38 +01:00
mmoreram
fa45c0834d
Removed unused construct param
2015-01-22 09:44:38 +01:00
mmoreram
2a6c844953
Using constructor to define environment
2015-01-22 09:44:38 +01:00
mmoreram
7a73d27600
Added resolve entities support in discrim. map
2015-01-22 09:44:38 +01:00
Marco Pivetta
39c36f6037
Merge pull request #1232 from PowerKiKi/doc-partial-indexes
...
Explicit example of partial indexes
2015-01-22 09:21:57 +01:00
Adrien Crivelli
3caaf26069
Explicit example of partial indexes
2015-01-22 16:38:24 +09:00
Marco Pivetta
3930fd50a7
Merge pull request #1273 from TrkiSF2/master
...
Incorrect @throws doc. in getSingleScalarResult
2015-01-20 22:42:11 +01:00
Lukáš Lukáč
ea213ef23c
Merge pull request #1 from TrkiSF2/TrkiSF2-getSingleScalarResult-Doc
...
Incorrect @throws doc. in getSingleScalarResult
2015-01-20 17:24:29 +01:00
Lukáš Lukáč
5e6ec8ebf3
Incorrect @throws doc. in getSingleScalarResult
2015-01-20 17:21:43 +01:00
Guilherme Blanco
335492aed7
Merge pull request #1269 from spdionis/patch-1
...
[DDC-3520] self-update composer before install
2015-01-20 09:19:27 -05:00
Marco Pivetta
f019bf4379
Merge branch 'docs/#1264-2.5-upgrade-notes'
...
Close #1264
2015-01-20 12:12:57 +01:00
Marco Pivetta
542d9b664b
#1264 - removing backtick
2015-01-20 12:11:39 +01:00
Marco Pivetta
daf2763894
Merge pull request #1271 from kix/patch-1
...
Update migration_2_5.rst
2015-01-20 11:41:32 +01:00
Stepan Anchugov
6ac0ae3c87
Update migration_2_5.rst
...
Fixed some formatting issues and typos.
2015-01-20 15:35:47 +05:00
Spinei Dionis
2528d0b3fc
self-update composer before install
...
Updating composer before install seems like a good idea. At the moment for example the travis build is failing because of the new composer syntax with '^' and it would be fixed by composer self-update.
2015-01-20 03:31:42 +02:00
Guilherme Blanco
2418f8f5e6
Removed todo by implementing it.
2015-01-18 22:21:18 -05:00
Benjamin Eberlei
cd616ff40e
Update changelog docs
2015-01-18 22:52:30 +01:00
Marco Pivetta
d8d4ec6eb2
Merge branch 'hotfix/#1265-sti-persister-one-to-one-association-notices'
...
Close #1265
2015-01-18 18:27:33 +01:00
Marco Pivetta
544add9e8b
Merge branch 'hotfix/#1265-sti-persister-one-to-one-association-notices-fix' into hotfix/#1265-sti-persister-one-to-one-association-notices
2015-01-18 18:27:01 +01:00
Marco Pivetta
9abbdb9e7f
#1265 DDC-3517 - moved test assets to separate models dir, namespaced table names
2015-01-18 18:25:46 +01:00
Marco Pivetta
185f22668c
#1265 DDC-3517 - correcting test docblocks
2015-01-18 18:15:03 +01:00
Marco Pivetta
bffc99a116
#1265 DDC-3517 - failing test - finding via a STI root class fails if there is a one-to-one association in a subclass
2015-01-18 18:13:15 +01:00
Anderson Müller
d48093886d
Fix error undefined index "targetEntity"
2015-01-18 15:54:43 +01:00
Benjamin Eberlei
79ba8c6be8
Add Changelog/Migration to 2.5 documentation chapter.
2015-01-18 15:18:18 +01:00
Marco Pivetta
61e07e5907
Handling minor HHVM incompatibility (dumped value is different between PHP and HHVM)
2015-01-18 02:54:18 +01:00
Marco Pivetta
7cba76082e
Corrected test: metadata should be retrieved from a specific entity manager
...
Metadata is subject to modification depending on the active database platform (generator strategies, usually),
therefore it is not safe to pull it from an entity manager and sharing metadata across multiple entity managers.
2015-01-18 02:32:02 +01:00
Marco Pivetta
39766e645c
Merge branch 'feature/#1248-better-exception-messages-on-invalid-association-data'
...
Close #1248
2015-01-18 01:07:08 +01:00
Marco Pivetta
c7f5ee8e9e
#1228 DDC-3490 - Remove unused method
2015-01-18 01:05:53 +01:00
Marco Pivetta
b1d7a057fd
#1228 DDC-3490 - avoid catching unknown exceptions, remove unused method call
2015-01-18 01:05:36 +01:00
Marco Pivetta
1cd03625a5
#1228 DDC-3490 - fixed exception catching in BasicFunctionalTest logic
2015-01-18 00:59:58 +01:00
Marco Pivetta
66479334d4
#1228 DDC-3490 - computing changes of invalid objects should also fail
2015-01-18 00:55:40 +01:00
Marco Pivetta
9c1275bb1f
#1228 DDC-3490 - persistence of invalid values should also cause exceptions
2015-01-18 00:54:18 +01:00
Marco Pivetta
d0c0f43c79
#1228 DDC-3490 - preventing invalid association values from being persisted
2015-01-18 00:53:57 +01:00
Marco Pivetta
71a6a88de8
#1228 DDC-3490 -better/more complete exception message for invalid populated associations
2015-01-18 00:53:34 +01:00
Marco Pivetta
5e76f12000
#1228 DDC-3490 - tests for invalid association values handled in the UnitOfWork
2015-01-18 00:37:21 +01:00
flip111
83de071c00
Update ORMInvalidArgumentException.php
...
remove added `value` to exception
2015-01-18 00:16:10 +01:00
flip111
d1a2655090
Update UnitOfWork.php
...
rename duplicate method
2015-01-18 00:16:10 +01:00
flip111
b5dd999f84
Update ORMInvalidArgumentException.php
...
rename duplicate method
2015-01-18 00:16:10 +01:00
flip111
059c33e69d
Update UnitOfWork.php
...
removed one `)` too many
2015-01-18 00:16:10 +01:00
flip111
1ae153d315
Update UnitOfWork.php
2015-01-18 00:16:10 +01:00
flip111
643ae78691
Update ORMInvalidArgumentException.php
...
Add unused parameters for `invalidAssociation`
2015-01-18 00:16:09 +01:00
flip111
04e4940607
Update ORMInvalidArgumentException.php
...
`@return self` trend break with `@return ORMInvalidArgumentException`
2015-01-18 00:16:09 +01:00
flip111
88e071d22d
moved exception constructors out of UoW
2015-01-18 00:16:09 +01:00
flip111
b120dafb70
Added new exception constructors
2015-01-18 00:16:09 +01:00
flip111
00a2c8e09c
improved error handling for invalid association values
...
Possibly to do:
1. Make custom Exception for line 713
2. Make custom Exception for line 817
3. Does the object check on line 816 slow down the code too much? Alternatively a try-catch could be put around line 1415 or higher up.
2015-01-18 00:16:09 +01:00
Marco Pivetta
84562bca82
Merge branch 'hotfix/#1252-include-class-name-when-calling-naming-strategy-join-column-name'
...
Close #1252
2015-01-18 00:12:54 +01:00
Marco Pivetta
025565005d
#1252 DDC-3496 - reverting interface BC break
2015-01-18 00:11:47 +01:00
Marco Pivetta
369a9934a5
#1252 DDC-3496 - moving stub naming strategy to tests directory
2015-01-18 00:07:54 +01:00
Marco Pivetta
29007e7d79
#1252 DDC-3496 - minor test cleanups (avoiding private static method)
2015-01-18 00:03:49 +01:00
Jack Sleight
60523d1b62
Update docblock for joinColumnName to include className details
2015-01-17 23:57:52 +01:00
Jack Sleight
04d8f66b72
Tests for new class based join column NamingStrategy
2015-01-17 23:57:52 +01:00
Jack Sleight
be9d92bb26
Example NamingStrategy for using class name in join column names.
2015-01-17 23:57:52 +01:00
Jack Sleight
82163a3301
Include className in calls to NamingStrategy joinColumnName method.
2015-01-17 23:57:52 +01:00
Marco Pivetta
4cde35dc18
Merge branch 'feature/#954-multi-get-slc-regions'
...
Close #954
2015-01-17 23:49:40 +01:00
Marco Pivetta
d5f6b4440a
#954 DDC-2982 - s/CacheProvider/Cache in documentation
2015-01-17 23:44:40 +01:00
Marco Pivetta
b1474768fe
#954 DDC-2982 - Better type-safety in Doctrine\ORM\Cache\Region\DefaultMultiGetRegion instantiation logic
2015-01-17 23:43:34 +01:00
Marco Pivetta
624b98544a
#954 DDC-2982 - DefaultCacheFactory now supports generic Doctrine\Common\Cache\Cache instances
2015-01-17 23:42:49 +01:00
Marco Pivetta
95fe03b182
#954 DDC-2982 - Coverage for different instantiation of single-/multi-get cache regions
2015-01-17 23:42:15 +01:00
Marco Pivetta
564624814b
#954 DDC-2982 - Evicting all cache entries is not supported with a generic cache adapter
2015-01-17 23:30:37 +01:00
Marco Pivetta
0e4a7caf0b
#954 DDC-2982 - Evicting all cache entries is not supported with a generic cache adapter
2015-01-17 23:30:20 +01:00
Marco Pivetta
95c6cca336
#954 DDC-2982 - Minor CS fixes/IDE hints
2015-01-17 23:17:07 +01:00
Marco Pivetta
8ddcc4b270
#954 DDC-2982 - No need to check if a Region is a MultiGetRegion
2015-01-17 23:11:14 +01:00
Marco Pivetta
3c5a794691
#954 DDC-2982 - Making cache Region always a MultiGetRegion (no need to segregate the interface here)
2015-01-17 23:10:49 +01:00
Asmir Mustafic
3f64f3252b
Changed some tests to be compatible with the new implementation of
...
multiget region
2015-01-17 22:27:59 +01:00
Asmir Mustafic
e73bd9e9bb
New buildCacheEntry way bo build a entry for a cached collection
2015-01-17 22:27:59 +01:00
Asmir Mustafic
1b4eee6d0d
Fixed strange test case with CmsUser and second-level cache
2015-01-17 22:27:59 +01:00
Asmir Mustafic
5ec2014051
MultiGetCollectionHydrator depends knows the multi-get region
2015-01-17 22:27:59 +01:00
Asmir Mustafic
1bfa68d94f
Removed dependency with Region interface
2015-01-17 22:27:59 +01:00
Asmir Mustafic
779af8ce8e
Added dependency with doctrine/cache 1.4
2015-01-17 22:27:59 +01:00
Asmir Mustafic
77c2e24215
Added test case for buildCachedCollectioHydrator on DefaultCacheFactory
2015-01-17 22:27:59 +01:00
Asmir Mustafic
b0792330e4
Added test case for MultiGetRegion
2015-01-17 22:27:58 +01:00
Asmir Mustafic
74e93e4cad
Added multi-get support for second level cached collections
2015-01-17 22:27:58 +01:00
Marco Pivetta
8f097ab304
Merge branch 'hotfix/#1220-sort-paginator-subquery-output-only-once'
...
Close #1220
2015-01-17 22:13:36 +01:00
Bill Schaller
3fd3da3d46
Fixed removal of ASC and DESC keywords from orderby items that will be included in select list
2015-01-17 22:12:26 +01:00
Bill Schaller
39aeb9935b
Added failing testcase for Limit queries on entities with column names containing 'asc' or desc'
2015-01-17 22:12:26 +01:00
Bill Schaller
8350de781f
Doc fix
2015-01-17 22:12:26 +01:00
Bill Schaller
dfc0910756
Fixed how order by items are included in the select list of the select distinct wrapper statement
2015-01-17 22:12:26 +01:00
Bill Schaller
7031539314
Fixed SQL that could be considered invalid on the targeted platforms in LimitSubqueryOutputWalkerTest
2015-01-17 22:12:26 +01:00
Bill Schaller
ed800e4b86
Added function to LimitSubqueryOutputWalker which takes an order by clause and rebuilds it to work in the scope of the wrapping query
2015-01-17 22:12:25 +01:00
Bill Schaller
42bea80a6a
Added failing test cases for limit queries with with complex scalar order by items
2015-01-17 22:12:25 +01:00
Bill Schaller
a4ebc08c4f
* Modified tests in LimitSubqueryOutputWalkerTest.php to not have duplicated order by clauses
...
* Modified LimitSubqueryOutputWalker to not duplicate order by clauses
2015-01-17 22:12:25 +01:00
Marco Pivetta
b23a8dd429
Merge branch 'hotfix/#1262-restore-run-dql-command-functionality'
...
Close #1262
2015-01-17 21:31:11 +01:00
Marco Pivetta
fea0425a4f
#1262 DDC-3513 - RunDqlCommand should write to the output object rather than to the output buffer
2015-01-17 21:31:00 +01:00
Marco Pivetta
f06d652393
#1262 DDC-3513 - RunDqlCommand should display the generated SQL when asked to do so
2015-01-17 21:30:34 +01:00
Marco Pivetta
1c6fd512a5
#1262 DDC-3513 - providing basic coverage for the RunDqlCommand logic
2015-01-17 21:27:32 +01:00
Bob van de Vijver
3c2ed7d8a8
Fixes the broken DQL command
...
Now it can again output more than only the created SQL query.
See cdb62a70cd (comments)
2015-01-17 13:21:30 +01:00
Marco Pivetta
fe4d46014d
Merge branch 'hotfix/#1212-fix-regression-that-hid-join-aliases-in-criteria-expressions'
...
Close #1212
2015-01-17 08:35:27 +01:00
Kiel Goodman
0c5ea34fd4
[DDC-3436] Fix changes requested 2/2
2015-01-17 08:33:23 +01:00
Kiel Goodman
dc98da585d
[DDC-3436] Fix changes requested 1/2
2015-01-17 08:33:23 +01:00
Kiel Goodman
349966832f
[DDC-3436] Convert short array syntax to legacy style
2015-01-17 08:33:23 +01:00
Kiel Goodman
918d2910d9
[DDC-3108] Fix regression introduced in DDC-2764 where join aliases were no longer accessible in Criteria expressions
2015-01-17 08:33:23 +01:00
Marco Pivetta
6ba5211310
Merge branch 'hotfix/#1206-matching-should-not-modify-criteria'
...
Close #1206
2015-01-17 08:30:26 +01:00
Marco Pivetta
e9fd5678a5
#1206 DDC-3430 - PersistentCollection should not mutate the given Criteria instances when matching()
2015-01-17 08:30:16 +01:00
Oliver Tischlinger
f8072dd8e0
Fixed typo
2015-01-17 08:20:24 +01:00
Oliver Tischlinger
b5ba84f667
matching should not change critera
...
The matching should behave like in ArrayCollection, where it is not changed.
The criteria should be cloned so that it could be used for more than one matching operation.
2015-01-17 08:20:24 +01:00
Marco Pivetta
6164f17229
Merge branch 'hotfix/#1086-identifier-type-in-proxies'
...
Close #1086
2015-01-17 08:15:50 +01:00
Marco Pivetta
f13b085582
Using PersisterHelper instead of the unreliable ClassMetadataInfo#getTypeOfColumn()
2015-01-17 08:14:04 +01:00
Marco Pivetta
f1170c84a4
#1086 - Passing type information when building meta-mappings for JTI and STI inheritances
2015-01-17 08:09:55 +01:00
Marco Pivetta
40849f8ae1
#1086 - Minor CS fixes applied to the test case (simplifying)
2015-01-17 08:09:55 +01:00
Thomas Lallement
a0165858c4
Delete DDC0003Test.php
2015-01-17 08:09:55 +01:00
Thomas Lallement
033b8e51e9
Create DDC3223Test.php
2015-01-17 08:09:55 +01:00
Thomas Lallement
556c562258
Failing test (get id return string type)
2015-01-17 08:09:54 +01:00
Marco Pivetta
dad3a6bae1
Merge branch 'hotfix/#1178-correct-association-links-dbal-types-conversion'
...
Close #1178
2015-01-17 08:03:00 +01:00
Marco Pivetta
67f59dc256
Revert " #1178 - simplified ValueConversionType tests by using a single model-set for the entire subset of tests (faster as well)"
...
This reverts commit 2702540930 .
2015-01-17 08:01:31 +01:00
Marco Pivetta
2702540930
#1178 - simplified ValueConversionType tests by using a single model-set for the entire subset of tests (faster as well)
2015-01-17 07:59:03 +01:00
Marco Pivetta
131a39bad4
#1178 - s/getValue/getIdentifierValues
2015-01-17 07:59:03 +01:00
Marco Pivetta
584839d38a
#1178 - moved private method to the bottom of the class
2015-01-17 07:59:03 +01:00
Marco Pivetta
edf054cd0c
#1178 - removing duplicate configuration of the rot13 DBAL type
2015-01-17 07:59:03 +01:00
Marco Pivetta
b32c779c37
#1178 - minor typo (method names)
2015-01-17 07:59:02 +01:00
Marco Pivetta
d47f724f16
#1178 - restoring correct getJoinTableRestrictionsWithKey logic as per @jaspernbrouwer's previous implementation
2015-01-17 07:59:02 +01:00
Marco Pivetta
f88f5ce454
#1178 - fetching actual target entity when resolving column types of it
2015-01-17 07:59:02 +01:00
Marco Pivetta
a39b6869ca
#1178 - mapping between criteria parameters and types when fetching on one-to-many with additional criterions
2015-01-17 07:59:02 +01:00
Marco Pivetta
ce446a6f03
#1178 - correcting filtering when initializing a one-to-many collection that has composite complex (custom DBAL types) identifiers
2015-01-17 07:59:02 +01:00
Marco Pivetta
096bd90aed
#1178 - using the PersisterHelper to extract type of associated meta-result columns
2015-01-17 07:59:02 +01:00
Marco Pivetta
e5c4e65764
#1178 - proxy identifiers should be correctly converted
2015-01-17 07:59:02 +01:00
Marco Pivetta
0743238b43
#1178 - minor code duplication removal
2015-01-17 07:59:01 +01:00
Marco Pivetta
4eaa7ea821
#1178 - correcting class from which the type of a column should be fetched (source class when relationToSourceKeyColumns is used)
2015-01-17 07:59:01 +01:00
Marco Pivetta
6e2179aa8e
#1178 - handling custom types when filtering/removing by element in extra-lazy many-to-many associations
2015-01-17 07:59:01 +01:00
Marco Pivetta
5e49aeef6f
#1178 - handling custom types when filtering by key in extra-lazy many-to-many associations
2015-01-17 07:59:01 +01:00
Marco Pivetta
e39f08f6bd
#1178 - handling correct parameter binding when counting extra-lazy collections with custom-type referenced identifiers
2015-01-17 07:59:01 +01:00
Marco Pivetta
c82794bff7
#1178 - handling traversal of association mapping data in lazy-loading many-to-many requests on the inverse side
2015-01-17 07:59:01 +01:00
Marco Pivetta
1e606d1ed3
#1178 - adding note about ClassMetadataInfo#getTypeOfColumn() being unreliable/dangerous
2015-01-17 07:59:01 +01:00
Marco Pivetta
41900dca76
#1178 - correctly handling initialization of collections referenced via custom DBAL types
2015-01-17 07:59:00 +01:00
Marco Pivetta
91bceca7ee
#1178 - correcting collection insert/update logic to correctly cast values for custom typed columns
2015-01-17 07:59:00 +01:00
Marco Pivetta
aaa6443954
#1178 - PersisterHelper::getTypeOfColumn() should not fail silently, as that makes persister bugs impossible to spot
2015-01-17 07:59:00 +01:00
Marco Pivetta
a80532a538
#1178 - correcting association column type when dealing with multiple derived associations/identifier levels
...
Since the ClassMetadata can only know about internal state, any `joinColumn` association details on the
inverse side of an association need to be computed by fetching associated metadata.
2015-01-17 07:59:00 +01:00
Marco Pivetta
445798ed46
#1178 - reverting patch and keeping tests (rebase gone awry)
...
Also cleaning up `OrmFunctionalTestCase`
2015-01-17 07:59:00 +01:00
Jasper N. Brouwer
5c1d1931b7
Fixed typehints and use statements
2015-01-17 07:59:00 +01:00
Jasper N. Brouwer
fe21f18991
Fixed doc-blocks
2015-01-17 07:59:00 +01:00
Jasper N. Brouwer
a0b43d0a7f
Don't alias PersisterHelper to Helper
2015-01-17 07:58:59 +01:00
Jasper N. Brouwer
7b9c6a69bd
Add tests for extra lazy many-to-many associations
...
and fixed production code
2015-01-17 07:58:59 +01:00
Jasper N. Brouwer
ba3df8577b
Refined and added tests, fixed found issues
...
- Renamed id properties so they don't coexist between entities in a test
- Added tests for extra lazy one-to-many associations
- Fixed production code to make tests green
2015-01-17 07:58:59 +01:00
Jasper N. Brouwer
f7b14085f2
Abstracted infering binding types away in a helper
2015-01-17 07:58:59 +01:00
Jasper N. Brouwer
4f9f7eedf5
Removed DDC-3380 mentions in production code
2015-01-17 07:58:59 +01:00
Jasper N. Brouwer
f60f2a567a
Fixed associations using a value-conversion type for identifiers
2015-01-17 07:58:59 +01:00
Marco Pivetta
f6445d5a3e
Fixing build using a dedicated in-memory connection to stub out two real connections for DB-access checks
2015-01-17 07:58:35 +01:00
Marco Pivetta
074ec358ab
Merge branch 'hotfix/#1172-avoid-proxy-initialization-when-proxy-is-merged-into-uow'
...
Close #1172
2015-01-16 22:56:03 +01:00
Marco Pivetta
57ce6ccfcf
#1172 - fixed minor CS issues (spacing)
2015-01-16 22:54:30 +01:00
Marco Pivetta
45e733eb60
#1172 - adding @method annotation to simplify static introspection
2015-01-16 22:50:52 +01:00
Marco Pivetta
42c9ff026e
#1172 - renaming test class for clarity
2015-01-16 22:47:00 +01:00
Marco Pivetta
937113e234
#1172 - simplified logic, re-using existing generic model
2015-01-16 22:46:31 +01:00
Marco Pivetta
cd3fc6e6ea
#1172 - adding required @group annotations for newly introduced tests
2015-01-16 22:43:52 +01:00
Marco Pivetta
94724b7a56
#1172 - reverted: moving MergeUninitializedProxyTest tests into EntityManagerTest (invalid, as they are functional tests)
2015-01-16 22:43:03 +01:00
Marco Pivetta
3769cd1119
#1172 - adding required @group annotations for newly introduced tests
2015-01-16 22:37:38 +01:00
Marco Pivetta
70840131ff
#1172 - moved MergeUninitializedProxyTest tests into EntityManagerTest
2015-01-16 22:36:30 +01:00
Marco Pivetta
438feccd55
#1172 - removing redundant test logic
2015-01-16 22:25:41 +01:00
Marco Pivetta
de4e980389
#1172 - covering merging of unmanaged, un-initialized proxies bound to a different entity manager
2015-01-16 22:25:00 +01:00
Marco Pivetta
b7566dc65b
#1172 - correcting test: all connections should have a saved file instance
2015-01-16 22:20:58 +01:00
Marco Pivetta
d1e7960f99
#1172 - tests to verify that proxies keep distinct entity manager instances even across merging operations
2015-01-16 22:12:42 +01:00
Marco Pivetta
4ed0a6ce53
#1172 - removing redundant tests
2015-01-16 21:25:25 +01:00
Marco Pivetta
3df119f4fe
#1172 - when merging an initialized proxy, the managed proxy must be initialized before merging
2015-01-16 21:23:47 +01:00
Marco Pivetta
a18f258b4d
#1172 - covering merging of managed proxies
2015-01-16 21:15:39 +01:00
Marco Pivetta
0329ac5074
#1172 - covering also detached proxies - merging operations should not initialize either proxy
2015-01-16 21:14:13 +01:00
Marco Pivetta
dde09872df
#1172 - writing a more concise test case about merging detached proxies
2015-01-16 21:09:53 +01:00
Mathieu De Zutter
318b23097b
Don't load uninitialized proxies after merging.
...
Previous patch avoided initialization of proxies before merging, mainly to
fix a bug with merging. However, later on, doctrine tries again to load
the proxy. This is unnecessary and thus has been removed. This way, a
round trip to the database is saved.
2015-01-16 20:54:15 +01:00
Mathieu De Zutter
ec35d4886c
Don't load detached proxies when merging them.
...
Ticket DDC-1392 fixed an issue where uninitialized proxies could not be merged
because the merge routine couldn't get the identifier from them. The soution
was to initialize the proxy.
Ticket DDC-1734 fixed the merging of *unserialized* uninitialized proxies by
resetting their internals, so these proxies were able to initialize, as required
by the fix for DDC-1392.
Somehow, in the meanwhile, the fix for DDC-1392 is not needed anymore:
reverting the patch will not break the associated test (but it does break the
test for DDC-1734). This means it is not needed anymore to initialize the proxy
when merging.
Uninitialized proxies that get merged should not be loaded at all. Since they
are not initialized, the entity data for sure hasn't changed, so it can be
safely ignored. Actually, the only thing the data is needed for while merging,
is to copy it into the managed entity, but that one is already supposed to be
up to date. By not initializing the proxy, a potential database roundtrip is
saved, and the fix for DDC-1734 is not needed anymore.
Besides optimizing the merge, this patch also solves an issue with merging.
Currently, when a detached uninitialized proxy is merged while there is already a
corresponding managed entity (proxy or not), the ORM returns a blank entity
instead of returning the already managed entity. This patch makes sure that
already existing managed entities are re-used.
2015-01-16 20:54:15 +01:00
Marco Pivetta
f28654de12
Merge branch 'hotfix/#1133-better-exception-message-on-missing-embeddable-class-in-metadata'
...
Close #1133
2015-01-16 19:50:26 +01:00
Marco Pivetta
935a79e15f
#1133 DDC-3305 - minor cs fix (spacing)
2015-01-16 19:46:04 +01:00
Marco Pivetta
7e4dab17ec
#1133 DDC-3305 - test case with embeddable without referenced embeddable class
2015-01-16 19:45:16 +01:00
Javier Spagnoletti
705a7d2cc2
[Embeddables] Improved exception message when embeddables is missing 'class' attribute.
2015-01-16 19:18:46 +01:00
Marco Pivetta
655394d433
Merge branch 'hotfix/abstract-id-generator-revert-bc-break'
2015-01-16 18:53:36 +01:00
Marco Pivetta
6acfdc1439
Removing Doctrine\ORM\Id\AbstractIdGenerator#generate(EntityManagerInterface $em, $entity) from upgrade notes (BC break reverted)
2015-01-16 18:53:27 +01:00
Marco Pivetta
f799986be1
Reverting BC break in AbstractIdGenerator signature
2015-01-16 18:52:58 +01:00
Marco Pivetta
de589799e8
Merge pull request #1209 from Ocramius/hotfix/DDC-3427-allow-entitymanagerinterface-globally
...
s/EntityManager/EntityManagerInterface in type-hints
2015-01-16 15:06:58 +01:00
Marco Pivetta
efe9e3ab28
#1209 DDC-3427 - documenting s/EntityManager/EntityManagerInterface signature BC breaks
2015-01-16 14:55:16 +01:00
Marco Pivetta
339bd23ac8
#1209 DDC-3427 - removing leftover EntityManager hints (using interface instead)
2015-01-16 14:44:31 +01:00
Marco Pivetta
dd8db1acd2
DDC-3427 - s/EntityManager/EntityManagerInterface in relevant tests about identifier generation
2015-01-16 14:22:03 +01:00
Marco Pivetta
6fc0d84b7a
DDC-3427 - s/EntityManager/EntityManagerInterface in type-hints
2015-01-16 14:21:30 +01:00
Marco Pivetta
0e7646cf4b
Merge branch 'namespace-persisters'
...
Close #1258
2015-01-16 00:10:56 +01:00
Guilherme Blanco
f90475772d
Classify persisters into more granular namespaces.
2015-01-16 00:10:25 +01:00
Fabio B. Silva
f97bb00dff
Merge pull request #1259 from Ocramius/hotfix/cache-region-cache-namespace-mutability-removal
...
Hotfix: Cache region should not mutate injected cache instance settings
2015-01-15 15:26:23 -05:00
Marco Pivetta
0f2c117f3e
Cloning and configuring the cache adapter for each newly created cache region (fixes cache namespacing)
2015-01-15 21:17:49 +01:00
Marco Pivetta
6564f95260
Typo fix (region should be named 'bar', not 'foo'
2015-01-15 21:17:25 +01:00
Marco Pivetta
a82eecfc07
Each cache region built by the DefaultCacheFactory should have its own cache with its own unique namespace
2015-01-15 21:15:38 +01:00
Marco Pivetta
514fd008b9
Cache regions will not modify the injected cache instance settings
2015-01-15 21:01:35 +01:00
Marco Pivetta
f38d4551f1
Cache regions should not modify the injected cache instance settings
2015-01-15 21:01:02 +01:00
Guilherme Blanco
0b2fb7fd78
Fixed identifier quoting in functional tests.
2015-01-15 03:55:29 +00:00
Guilherme Blanco
8a0989aa50
Fixed identifier quoting in functional tests.
2015-01-15 03:50:18 +00:00
Marco Pivetta
5bd921139e
Merge branch 'hotfix/#1250-DDC-3493-fix-class-pseudo-constant-parsing-in-entitygenerator'
2015-01-15 04:16:44 +01:00
Guilherme Blanco
a1d77bdc65
Renamed coll to collection and some small updates to tests.
2015-01-15 03:14:48 +00:00
Marco Pivetta
5be57d0f4a
Merge branch 'hotfix/#1256-DDC-3493-fix' into hotfix/#1250-DDC-3493-fix-class-pseudo-constant-parsing-in-entitygenerator
...
Close #1250
Close #1256
2015-01-15 04:13:28 +01:00
Andrea Sprega
243210e896
DDC-3493 - fixed EntityGenerator parsing for php 5.5 "::class" syntax
2015-01-15 04:13:09 +01:00
lukasmaz
41dd584f62
Test case for "class" keyword
...
Test case for http://www.doctrine-project.org/jira/browse/DDC-3493
2015-01-15 04:12:31 +01:00
Marco Pivetta
55a75bfb1b
Merge pull request #1249 from doctrine/extra-lazy-get-m2m
...
Support for extra lazy get for both owning and inverse side on many to many associations.
2015-01-15 03:36:35 +01:00
Steve Müller
d343617f13
Merge pull request #1255 from Ocramius/cleanup/php-5.3-support-end
...
Cleanup: PHP 5.3 support end
2015-01-15 01:29:00 +01:00
Marco Pivetta
934e4fdde4
Merge pull request #1251 from TomasVotruba/travis-optimize
...
travis: optimize to run coverage only once
2015-01-15 01:20:02 +01:00
Marco Pivetta
a88726d84e
Merge branch 'hotfix/#1072-fix-iteration-of-file-lock-region-on-no-match'
...
Close #1072
2015-01-15 00:55:16 +01:00
Marco Pivetta
8b223c5c83
#1072 DDC-3191 - test cleanup: reflection is better than mixing up I/O operations and global state
2015-01-15 00:54:25 +01:00
Marco Pivetta
e2acd74cb4
#1072 DDC-3191 - minor performance optimization
2015-01-15 00:37:41 +01:00
Marco Pivetta
aca719be41
#1072 DDC-3191 - adding test for failing glob() operations on the FileLockRegion
2015-01-15 00:36:26 +01:00
Alexander Kurilo
58cd520e32
Fix attempt of traversing bool in FileLockRegion
2015-01-14 23:51:41 +01:00
Tomas Votruba
57cad1f232
travis: optimize to run coverage only once
2015-01-14 23:08:15 +01:00
Marco Pivetta
a1e40fc3f1
Removing PHP 5.3 references, simplified getting started docs
2015-01-14 21:02:15 +01:00
Marco Pivetta
3ee47bef41
Updating readme minimum required PHP version
2015-01-14 21:00:59 +01:00
Marco Pivetta
89520b1f38
Updating readme minimum required PHP version
2015-01-14 21:00:37 +01:00
Marco Pivetta
9024c04c72
Removing conditionals checking for PHP 5.4 support
2015-01-14 20:14:39 +01:00
Marco Pivetta
541e7bdf72
Refactoring test method: no need to test for PHP version
2015-01-14 20:13:46 +01:00
Marco Pivetta
8e28cb9119
Removing useless $self use statements, as PHP 5.4 supports $this in closures
2015-01-14 20:12:27 +01:00
Marco Pivetta
effe33096d
Dropping PHP 5.3 from the build matrix
2015-01-14 20:03:49 +01:00
Marco Pivetta
e05858b09c
Requiring PHP 5.4 as a minimum runtime
2015-01-14 20:02:48 +01:00
Marco Pivetta
e030dac3d0
Merge pull request #1253 from SofHad/fix-dbal-configuration-404
...
Fix dead link
2015-01-14 19:43:03 +01:00
Marco Pivetta
1d4b96eed0
Merge branch 'hotfix/#881-support-schema-on-platform-without-schema-emulation'
...
Close #881
2015-01-14 19:18:22 +01:00
Marco Pivetta
0106cba602
#881 DDC-2825 - reusing mapping files that already exist in models, where applicable
2015-01-14 19:17:39 +01:00
Marco Pivetta
7164e28138
#881 DDC-2825 - renaming table/schema name for clarity and to avoid collisions
2015-01-14 19:16:42 +01:00
Marco Pivetta
7b168de236
#881 DDC-2825 - removing unused imports
2015-01-14 19:05:40 +01:00
Marco Pivetta
962f479318
#881 DDC-2825 - refactoring test logic, removing dead private method
2015-01-14 19:04:58 +01:00
Marco Pivetta
80ce601eae
#881 DDC-2825 - refactoring test logic to use data-provider instead of code repetitions
2015-01-14 19:02:44 +01:00
Marco Pivetta
f874189456
#881 DDC-2825 - refactoring tests for clarity/readability and ease of use
2015-01-14 18:56:37 +01:00
Marco Pivetta
9d6890e6ca
#881 DDC-2825 - expectations are the first parameter in an assertion
2015-01-14 18:50:17 +01:00
Marco Pivetta
67788d89b5
#881 DDC-2825 - simplifying/extracting test logic: moved verifying metadata into separate test method
2015-01-14 18:47:17 +01:00
SofHad
9ba7c9a74d
Fix dead link
2015-01-14 18:43:46 +01:00
Marco Pivetta
0a91b83e27
#881 DDC-2825 - exploding test case into smaller units
2015-01-14 18:34:58 +01:00
Marco Pivetta
6f85ca3356
#881 DDC-2825 - exploding test case into smaller units
2015-01-14 18:31:11 +01:00
Marco Pivetta
3ba9689448
#881 DDC-2825 - aligning assignments
2015-01-14 18:19:22 +01:00
Marco Pivetta
f0102a69f9
#881 DDC-2825 - refactoring mapping driver to use ClassMetadata#setPrimaryTable() instead of duplicating explode() logic
2015-01-14 18:12:12 +01:00
Marco Pivetta
eefa3b2e53
#881 DDC-2825 - correcting YAML driver implementation (wasn't using extracted schema)
2015-01-14 18:06:29 +01:00
Marco Pivetta
04467218a3
#881 DDC-2825 - providing YAML mappings for explicit schema definition
2015-01-14 18:05:58 +01:00
Marco Pivetta
7911beaf1c
#881 DDC-2825 - providing YAML mappings for implicit schema definition
2015-01-14 18:05:38 +01:00
Marco Pivetta
51bf82b7e7
#881 DDC-2825 - correcting PHP mapping behavior when using implicit schema in table name
2015-01-14 17:54:00 +01:00
Marco Pivetta
0fd51cf852
#881 DDC-2825 - providing PHP mappings for implicit schema definition
2015-01-14 17:53:01 +01:00
Marco Pivetta
d96cd1b690
#881 DDC-2825 - providing PHP mappings for explicit schema definition
2015-01-14 17:52:51 +01:00
Marco Pivetta
53845b79e1
#881 DDC-2825 - providing XML mappings for implicit schema definition
2015-01-14 17:34:44 +01:00
Marco Pivetta
3820fa57d3
#881 DDC-2825 - XML mappings should handle explicitly defined schema name
2015-01-14 17:33:17 +01:00
Marco Pivetta
941bfca68c
#881 DDC-2825 - providing XML mappings for explicit schema definition
2015-01-14 17:27:53 +01:00
Marco Pivetta
617fd6cfdc
#881 DDC-2825 - moving YAML and XML mapping tests to base mapping driver tests. Excluding Static PHP mapping tests
2015-01-14 16:59:01 +01:00
Marco Pivetta
cf641cd0a3
#881 DDC-2825 - testing annotation driver with table name defining schema name as part of the name
2015-01-14 16:47:05 +01:00
Marco Pivetta
8b2b54c033
#881 DDC-2825 - typo fix (causing test failure)
2015-01-14 16:32:02 +01:00
Marco Pivetta
c6d839869b
#881 DDC-2825 - annotation mapping tests for explicitly defined schema name on mappings
2015-01-14 16:30:20 +01:00
Michaël Perrin
0dbc6a12ee
Update mapping documentation for schema support
...
Updated documentation:
* Annotations
* XML
* Yaml
* PHP
2015-01-14 15:48:49 +01:00
Michaël Perrin
54b3c0548d
Fix persistence exception on a table with a schema on a platform without schema support
2015-01-14 15:48:49 +01:00
Marco Pivetta
c571f6f6a9
Correctly dealing with emulated cascades in ExtraLazyCollectionTest
2015-01-14 14:36:01 +01:00
Steve Müller
00a8265fb9
Merge pull request #1181 from Ocramius/feature/#385-support-fetching-entities-by-aliased-name
...
Support fetching entities by aliased name
2015-01-14 13:54:33 +01:00
Marco Pivetta
ba5378fecc
#385 #1181 DDC-3385 - fixing Events docblocks as per @deeky666's review
2015-01-13 21:15:34 +01:00
Marco Pivetta
ae8ab0812e
#385 #1181 DDC-3385 - fixing OnClassMetadataNotFoundEventArgs docblocks as per @deeky666's review
2015-01-13 21:14:32 +01:00
Marco Pivetta
d712ad97a5
#385 #1181 DDC-3385 - test coverage for OnClassMetadataNotFoundEventArgs impl
2015-01-13 21:04:50 +01:00
Marco Pivetta
662b49608c
#385 #1181 DDC-3385 - aligning tests and implementation to new OnClassMetadataNotFoundEventArgs API
2015-01-13 20:56:57 +01:00
Marco Pivetta
6debf2c909
#385 #1181 DDC-3385 - aligning tests to new OnClassMetadataNotFoundEventArgs API
2015-01-13 20:56:40 +01:00
Marco Pivetta
762e798d22
#385 #1181 DDC-3385 - extending OnClassMetadataNotFoundEventArgs from ManagerEventArgs instead of generic EventArgs
2015-01-13 20:56:21 +01:00
Marco Pivetta
6021e3a1b8
#385 #1181 DDC-3385 - Updating docblock of OnClassMetadataNotFoundEventArgs
2015-01-13 20:49:08 +01:00
Marco Pivetta
06f256b410
#385 #1181 DDC-3385 - documenting onClassMetadataNotFound event
2015-01-13 20:45:00 +01:00
Marco Pivetta
f14063def5
#385 #1181 DDC-3385 - splitting test case to verify interface-first fetching of metadata (via fallback logic)
2015-01-13 20:38:01 +01:00
Marco Pivetta
94a2036d50
#385 #1181 DDC-3385 - adding @group annotation to newly introduced tests
2015-01-13 20:37:28 +01:00
Marco Pivetta
eaa9187dd8
#385 #1181 DDC-3385 - minor CS fix (spacing)
2015-01-13 20:33:30 +01:00
Marco Pivetta
8ea394e778
#385 #1181 DDC-3385 - removing @todo that was discussed/cleared
2015-01-13 20:33:10 +01:00
Marco Pivetta
a710706c81
#385 #1181 DDC-3385 - optimized imports, removing duplicate imports (caused by rebase conflicts)
2015-01-13 20:00:40 +01:00
Marco Pivetta
ce4df761df
Explicitly requiring doctrine/common with at least version 2.5
2015-01-13 19:51:35 +01:00
Marco Pivetta
e4cbdb57ad
Enabling fallback logic in metadata loading
2015-01-13 19:50:55 +01:00
Marco Pivetta
d91b0b4938
Minor CS fixes in the ResolveTargetEntityListener
2015-01-13 19:50:17 +01:00
Marco Pivetta
f5eb20b63d
OnClassMetadataNotFoundEventArgs should support setting the actually resolved ClassMetadata as a mutable event result vector
2015-01-13 19:50:17 +01:00
Marco Pivetta
efd4500e6b
ClassMetadataFactory should support fallback (event-based) logic for hooking into failed ClassMetadata loading
2015-01-13 19:50:15 +01:00
Bart van den Burg
d66356542d
added use statement
2015-01-13 19:49:58 +01:00
Bart van den Burg
3be43a1def
Rebased and renamed PreLoadClassMetadata to OnClassMetadataNotFound
2015-01-13 19:49:57 +01:00
Bart van den Burg
437f812718
Added new event to allow actions to be done before trying to load class metadata
2015-01-13 19:49:57 +01:00
Bart van den Burg
19c52e4ae1
added failing test
2015-01-13 19:49:57 +01:00
Bart van den Burg
51528fbdea
set metadata for interface to be able to fetch entites by interface name
2015-01-13 19:49:57 +01:00
Guilherme Blanco
25b7c64dc6
Implemented support for extra lazy get for both owning and inverse side on many to many associations.
2015-01-13 17:50:20 +00:00
Marco Pivetta
9c3cb57931
Merge branch 'optimize-persisters'
...
Close #1246
2015-01-13 15:05:45 +01:00
Marco Pivetta
35dd7f8e2b
#1246 DDC-3487 - docblock args fixes
2015-01-13 15:03:04 +01:00
Marco Pivetta
278b8bfa08
#1246 DDC-3487 - minor alignment fixes
2015-01-13 14:58:56 +01:00
Marco Pivetta
7f71cbc8c7
#1246 DDC-3487 - removed unused assignment, minor alignment fixes
2015-01-13 14:54:00 +01:00
Marco Pivetta
97d1d5343e
#1246 DDC-3487 - removed unused assignment, making $association variable overwrite more obvious
2015-01-13 14:46:34 +01:00
Marco Pivetta
c4366124c7
#1246 DDC-3487 - removed unused assignment, direct return instead
2015-01-13 14:45:13 +01:00
Marco Pivetta
17a865ec7f
#1246 DDC-3487 - correcting docblock (static introspection fix)
2015-01-13 14:39:05 +01:00
Marco Pivetta
b99f4461be
#1246 DDC-3487 - re-aligning SQL string concatenation for readability, fixed docblock return value hint
2015-01-13 14:37:32 +01:00
Marco Pivetta
5942b6c302
#1246 DDC-3487 - re-aligning SQL string concatenation for readability
2015-01-13 14:31:22 +01:00
Marco Pivetta
77234d6aec
#1246 DDC-3487 - removing unused assignment
2015-01-13 14:30:51 +01:00
Marco Pivetta
a8dcc2acf3
#1246 DDC-3487 - removing possible undefined value path for $newValId for clarity
2015-01-13 14:05:27 +01:00
Guilherme Blanco
c49b0795db
Update UPGRADE.md
2015-01-12 22:53:55 -05:00
Guilherme Blanco
de4723883f
Merge pull request #1171 from jaimz22/master
...
Improvements for complex select statements when using new object expression
2015-01-12 22:48:56 -05:00
Guilherme Blanco
bc268da8c2
Small optimization.
2015-01-13 03:30:07 +00:00
Guilherme Blanco
678f47f494
More deprecated code removal.
2015-01-13 02:52:31 +00:00
Guilherme Blanco
965cdbdbbb
Optimized column to field resolutions.
2015-01-13 02:18:49 +00:00
Guilherme Blanco
96955d6e79
Some small improvements to persisters.
2015-01-13 02:05:33 +00:00
Marco Pivetta
5630c37b35
Merge branch 'feature/#1240-include-identifiers-in-exception-messages'
...
Close #1240
2015-01-13 02:56:06 +01:00
Marco Pivetta
1bfa7ea754
#1240 DDC-3479 - Basic coverage for EntityNotFoundException
2015-01-13 02:55:51 +01:00
Marco Pivetta
fc72b41953
#1240 DDC-3479 - Using a static proxy constructor rather than the default constructor
2015-01-13 02:51:47 +01:00
Marco Pivetta
66c556fbfd
#1240 DDC-3479 - Fixing minor CS issues (naming, alignment)
2015-01-13 02:48:57 +01:00
Lars Strojny
8e4092750d
Include IDs in the exception message to ease debugging
2015-01-13 02:41:05 +01:00
Marco Pivetta
1ac688644a
Merge branch 'hotfix/#1242-lock-uninitialized-proxies'
...
Close #1242
2015-01-13 02:37:09 +01:00
Carnage
00b6f62287
Fixed issue
2015-01-13 02:36:58 +01:00
Carnage
36f9822466
Added test to demonstrate issue
2015-01-13 02:36:58 +01:00
Marco Pivetta
ef113e52ab
Merge branch 'feature/#1054-DDC-3161-allow-connection-access-in-filters'
...
Close #1054
2015-01-13 02:06:49 +01:00
Marco Pivetta
ef5a3f1bb7
#1054 DDC-3161 - adding @group annotation for newly introduced tests
2015-01-13 02:06:39 +01:00
Vladislav Veselinov
759836113f
assertion fix
2015-01-13 02:05:49 +01:00
Vladislav Veselinov
79bf84e1ad
revert typehint change
2015-01-13 02:05:49 +01:00
Vladislav Veselinov
9cb17d2915
EntityManagerInterface instead of EntityManager
...
Make connection available in filters
Add test for the changes
2015-01-13 02:05:49 +01:00
Marco Pivetta
14c3adbec0
Merge branch 'hotfix/#470-DDC-54-postLoad-deferred-event-triggering-tests'
...
Close #470
2015-01-13 01:43:44 +01:00
Marco Pivetta
b81209c278
#470 DDC-54 DDC-3005 - documenting postLoad and Doctrine\ORM\AbstractQuery#iterate() partial incompatibility
2015-01-13 01:43:12 +01:00
Marco Pivetta
f571a9ef88
#470 DDC-54 DDC-3005 - query iteration must cause eager hydrationComplete logic to be fired
2015-01-13 01:42:38 +01:00
Marco Pivetta
0ffc752f6f
#470 DDC-54 DDC-3005 - simple-object hydration should also trigger postLoad events when iterating over single results
2015-01-13 01:42:03 +01:00
Marco Pivetta
5cd73f0d12
#470 DDC-54 DDC-3005 - reverting assertion
...
`postLoad` should be triggered eagerly when using `iterate()`, as worse problems may be experienced with
missed initialization via listeners.
2015-01-13 01:36:13 +01:00
Marco Pivetta
0a19fbb376
#470 DDC-54 DDC-3005 - minor test cleanups, changing test according to current limitation to document the actual expected behavior
2015-01-13 01:26:04 +01:00
Marco Pivetta
a884452ffc
#470 DDC-54 DDC-3005 - removing unused PostLoadEventDispatcher
2015-01-13 01:16:46 +01:00
Marco Pivetta
b1144e74ea
#470 DDC-54 DDC-3005 - reverting hydrator changes, as patch DDC-3005 already deals with the issue
2015-01-13 01:09:23 +01:00
Lukasz Cybula
aa4796cd0d
Moved postLoad dispatching from UnitOfWork to object hydrators
2015-01-13 01:03:48 +01:00
Marco Pivetta
a906295c65
Merge branch 'hotfix/#1001-DDC-3005-defer-postload-event-after-fully-populated-associations'
...
Close #1001
2015-01-13 00:54:31 +01:00
Marco Pivetta
d09280a1dc
#1001 DDC-3005 - HydrationCompleteHandler cs fixes (line-wrap)
2015-01-13 00:52:12 +01:00
Marco Pivetta
45221b1951
#1001 DDC-3005 - removed HydrationCompleteHandler#invokeAllDeferredPostLoadEvents() (useless method call indirection)
2015-01-13 00:51:44 +01:00
Marco Pivetta
c9ccd91421
#1001 DDC-3005 - optimized HydrationCompleteHandler imports
2015-01-13 00:50:19 +01:00
Marco Pivetta
730c2a81f7
#1001 DDC-3005 - HydrationCompleteHandler static introspection cleanups, as well as memory and performance improvements
2015-01-13 00:50:05 +01:00
Marco Pivetta
8c54a65aa5
#1001 DDC-3005 - Verifying HydrationCompleteHandler skips over registered deferred loads that were already handled by hydrationComplete
2015-01-13 00:48:53 +01:00
Marco Pivetta
29d4d342bd
#1001 DDC-3005 - Testing HydrationCompleteHandler with multiple deferred entities postLoads
2015-01-13 00:45:07 +01:00
Marco Pivetta
948d6c2b9f
#1001 DDC-3005 - Testing HydrationCompleteHandler against all possible ListenersInvoker flags
2015-01-13 00:39:28 +01:00
Marco Pivetta
833058fd2e
#1001 DDC-3005 - Testing HydrationCompleteHandler when no events should be triggered
2015-01-13 00:36:17 +01:00
Marco Pivetta
7b81cfb6ea
#1001 DDC-3005 - Minor CS fixes in HydrationCompleteHandler
2015-01-13 00:33:15 +01:00
Marco Pivetta
89530f88f7
#1001 DDC-3005 - Removing dead assignment HydrationCompleteHandler#__construct()
2015-01-13 00:32:10 +01:00
Marco Pivetta
516d04c391
#1001 DDC-3005 - Removing useless dependency from the HydrationCompleteHandler to the UnitOfWork
2015-01-13 00:31:32 +01:00
Marco Pivetta
fccd08afa5
#1001 DDC-3005 - Basic coverage for the HydrationCompleteHandler
2015-01-13 00:29:50 +01:00
Marco Pivetta
af93539576
#1001 DDC-3005 - HydrationCompleteHandler should accept EntityManagerInterface instances
2015-01-13 00:06:07 +01:00
Marco Pivetta
22e12e0043
#1001 DDC-3005 - coverage annotations, minor CS fixes
2015-01-12 23:50:16 +01:00
Guilherme Blanco
dd883f2136
Moved delete() and update() to proper locations.
2015-01-12 22:04:04 +00:00
Strate
0c8a31bf2b
DDC-3005. Revert empty line. Removed @since annotation
2015-01-12 22:34:24 +01:00
Strate
96184b9541
DDC-3005.Removed warning in documentation
2015-01-12 22:34:24 +01:00
Strate
367a79206d
DDC-3005. Renamed class by removing underscore
2015-01-12 22:34:24 +01:00
Strate
35ea399d33
DDC-3005 Defer invoking of postLoad event to the end of hydration cycle.
...
1. Refactor handling of hydration complete: delegate this task to special object
2. Write test case for situation, when inside postLoad listener other entity is loading.
3. Make test, written on second step, be able to pass :)
2015-01-12 22:34:24 +01:00
Strate
f3b31c2807
DDC-3005 Defer invoking of postLoad event to the end of hydration cycle.
...
This feature makes guarantee, that postLoad event fires after all associations are populated
2015-01-12 22:33:40 +01:00
Marco Pivetta
b9c0868f08
Merge branch 'one-to-many-extra-lazy-joined-inheritance'
...
Close #1245
2015-01-12 22:05:12 +01:00
Marco Pivetta
0f362b0650
#1245 DDC-2504 - removing duplicate test
2015-01-12 22:03:54 +01:00
Marco Pivetta
ebf5811761
#1245 DDC-2504 - extracting test:
...
Removing an unmanaged/persisted/new item from a one-to-many extra-lazy association to a JTI does not initialize the collection
2015-01-12 21:55:57 +01:00
Marco Pivetta
25d40caf1e
#1245 DDC-2504 - extracting test:
...
Removing a managed item from a one-to-many extra-lazy association to a JTI does not initialize the collection
2015-01-12 21:43:37 +01:00
Marco Pivetta
ec08286173
#1245 DDC-2504 - constants over string references
2015-01-12 21:37:53 +01:00
Marco Pivetta
7a0cb1c370
#1245 DDC-2504 - splitting test method into a test about count() and one about contains() on a lazy persistent collection
2015-01-12 21:34:12 +01:00
Marco Pivetta
8d287b17d7
#1245 DDC-2504 - splitting test method into single feature checks
2015-01-12 21:29:48 +01:00
Guilherme Blanco
932a56f26f
Internalize UnitOfWork in CollectionPersisters. Updated related code.
2015-01-12 19:52:27 +00:00
Guilherme Blanco
c5f1b99721
Fixed wrong return.
2015-01-12 18:18:15 +00:00
Guilherme Blanco
73afcec22a
Implemented support for one to many extra lazy with joined inheritance.
2015-01-12 18:15:13 +00:00
Marco Pivetta
573153669c
Merge pull request #1244 from BenMorel/static
...
Change $this return type to static in AbstractQuery
2015-01-11 18:02:45 +01:00
Benjamin Morel
fbcf18cf33
Changed $this return type to static in AbstractQuery
...
This allows IDEs and static code analysis tools to properly understand the return type when chaining methods, for example when using the QueryBuilder.
2015-01-11 16:48:09 +00:00
Guilherme Blanco
4dbfdfb9d6
Merge pull request #1243 from doctrine/composer-autoloader-dev
...
Fixed phpunit tests autoload requirements and moved to composer autoload-dev
2015-01-10 16:05:14 -05:00
Guilherme Blanco
9201d09ab7
Fixed phpunit tests autoload requirements and moved to composer autoload-dev configuration.
2015-01-10 20:28:57 +00:00
Marco Pivetta
be91cc9bb3
Merge pull request #1239 from deeky666/fix-index-duplication
...
Fix index duplication for unique association join columns
2015-01-09 23:07:50 +01:00
Marco Pivetta
664b6bf4c5
Merge pull request #1227 from c960657/production-settings-query-cache
...
Ensure query cache is not ArrayCache in production
2015-01-09 16:58:38 +01:00
Steve Müller
d1e5034659
fix index duplication for unique association join columns
2015-01-08 15:39:41 +01:00
Marco Pivetta
0cbab230bf
Merge branch 'feature/#1238-allow-skipping-column-prefixing-in-xml-mapped-embeddables'
...
Close #1238
2015-01-08 13:33:52 +01:00
Marco Pivetta
6fdb100793
#1238 DDC-3293 DDC-3477 - exploding tests with set use-column-prefix="true" and use-column-prefix="false" xml mappings
2015-01-08 13:33:38 +01:00
Marco Pivetta
43db4a4182
#1238 DDC-3293 DDC-3477 - adding @group annotations for newly introduced tests
2015-01-08 13:28:11 +01:00
Andrey Knupp Vital
a701c9d046
Removing warning about non-availability of no-prefix in XML mappings
2015-01-08 10:11:22 -02:00
Andrey Knupp Vital
74a2cfc83b
Also adding docs for the new attribute use-column-prefix
2015-01-08 09:37:41 -02:00
Andrey Knupp Vital
08e8af9372
Type-hinting SimpleXMLElement (_getCascadeMappings)
2015-01-08 09:28:15 -02:00
Andrey Knupp Vital
b90943c56b
Minor improvements
2015-01-08 09:04:37 -02:00
Andrey Knupp Vital
bacadbf366
Adding tests for the attribute use-column-prefix
2015-01-08 00:11:34 -02:00
Andrey Knupp Vital
4935da138d
Respecting use-column-prefix instead of relying on false/0 of column-prefix
2015-01-08 00:10:24 -02:00
Andrey Knupp Vital
c964dd0cd2
Adding use-column-prefix attribute as proposed (DDC-3293) #1239
2015-01-08 00:09:30 -02:00
Andrey Knupp Vital
8bbc492978
Removing weird strict comparison on different types
2015-01-07 17:24:44 -02:00
Andrey Knupp Vital
82cda1ecb0
Prevents prefixing a column when false on column-prefix (XML)
2015-01-07 17:22:48 -02:00
Guilherme Blanco
ef65270387
Merge pull request #1230 from johannes/master
...
Allow dumping SQL query when passing DQL on cli
2015-01-06 21:39:11 -05:00
Marco Pivetta
6448627bc9
Merge pull request #1233 from SofHad/refactoring-duplicate-code
...
[Minor] Refactoring to avoid duplicate code
2015-01-04 22:59:05 +01:00
SofHad
eb22db0dcf
remove the unnecessary check
2015-01-04 21:01:32 +01:00
Marco Pivetta
5237692979
Merge pull request #1236 from abackstrom/patch-1
...
Minor docs fix: missing word 'do'
2014-12-31 09:59:33 +01:00
Marco Pivetta
d13e2fbb83
Merge branch 'hotfix/#1235-consistent-joined-subclass-persister-return-types'
...
Close #1235
2014-12-31 09:46:31 +01:00
Marco Pivetta
0f165bce50
#1235 DDC-3470 - coverage annotations
2014-12-31 09:46:19 +01:00
Marco Pivetta
a93e5fa1c2
#1235 DDC-3470 - license headers
2014-12-31 09:45:46 +01:00
Marco Pivetta
74f00327bd
#1235 DDC-3470 - adding @group annotation for newly introduced test cases
2014-12-31 09:45:33 +01:00
Marco Pivetta
e2b34ff5d2
#1235 DDC-3470 - joined subclass persister empty executeInserts() method return type test
2014-12-31 09:44:39 +01:00
Annika Backstrom
27fe4d78b7
Minor docs fix: missing word 'do'
2014-12-30 20:12:11 -05:00
Martin Prebio
8f15c5e905
Consistent return type confirming with interface
2014-12-31 01:28:05 +01:00
Sofiane HADDAG
8d91f7de60
Rename handleCache to updateCache
2014-12-30 14:49:12 +01:00
shaddag
ccb09ad0ac
Rename the private method
2014-12-30 14:10:56 +01:00
shaddag
12b5a0cdd7
Extracted ony the common logic
2014-12-30 14:06:48 +01:00
shaddag
50ef1369c3
[Minor] Refactoring to avoid duplicate code
2014-12-30 10:03:49 +01:00
Johannes Schlüter
cdb62a70cd
Allow dumping SQL query when passing DQL on cli
2014-12-24 14:15:23 +01:00
Christian Schmidt
61c72e4aa7
Ensure query cache is not ArrayCache in production
2014-12-19 20:18:45 +01:00
James Murray
d9cbe1a8b7
removed unnecessary fieldIdentificationVariable property check
2014-12-19 14:10:47 -05:00
James Murray
2f76571d3a
Added a fix for ObjectHydrator when the same number of scalar results and new object results exist
...
Adding additional tests for mixed New object and scalar query
2014-12-19 14:06:03 -05:00
Marco Pivetta
193e31f22a
Merge pull request #1226 from stof/patch-2
...
Update Travis badges to use the SVG version
2014-12-19 19:19:48 +01:00
Christophe Coevoet
92efd887e2
Update Travis badges to use the SVG version
2014-12-19 19:04:04 +01:00
Guido Contreras Woda
82847e1851
Added more docblock
2014-12-16 22:37:50 -03:00
Guido Contreras Woda
8fd28fcd8f
Added embedded and embeddables to ClassMetadataBuilder
2014-12-16 22:30:28 -03:00
Marco Pivetta
5a6bbbd624
Merge branch 'hotfix/#1216-tests-for-#1214-xml-driver-exporting'
...
Close #1216
Close #1214
2014-12-10 01:33:23 +01:00
Marco Pivetta
b6bbf6ac22
#1214 #1216 - adding @group annotation for newly introduced test cases
2014-12-10 01:33:09 +01:00
Fedik
68ed56ce27
test for #1214 , XML export the field options
2014-12-09 20:49:51 +02:00
Marco Pivetta
1cc42d6a63
Merge branch 'hotfix/#1202-nullable-options-should-be-allowed'
...
Close #1202
2014-12-08 01:35:11 +01:00
Marco Pivetta
78ba7f1073
#1202 - simplified test and test asset
2014-12-08 01:34:30 +01:00
Gareth Evans
c1000d23db
Added test that passes following previous commit
2014-12-08 01:31:14 +01:00
Gareth Evans
2fac6272a1
Checks key exists rather than isset
...
If the default value is set to `null`, `isset` will return `false` even though the key is actually there for a reason.
2014-12-08 01:31:14 +01:00
Marco Pivetta
9509bec79a
Merge branch 'hotfix/#1213-DDC-3437-reflection-embeddable-with-abstract-embeddable-ancestor'
...
Close #1213
2014-12-08 01:22:31 +01:00
Marco Pivetta
cf1b16a505
#1213 - DDC-3437 - renaming variables/alignment/clarifications in docblocks
2014-12-08 01:22:20 +01:00
Marco Pivetta
357292de44
#1213 - DDC-3437 - removing unused test assets
2014-12-08 01:20:00 +01:00
Marco Pivetta
55bcc193ae
#1213 - DDC-3437 - removing redundant test method
2014-12-08 01:19:15 +01:00
Marco Pivetta
af0be57538
#1213 - DDC-3437 - integrating new tests into the pre-existing data-provider
2014-12-08 01:18:36 +01:00
Marco Pivetta
d75d6ffb11
#1213 - DDC-3437 - adding relevant test assets
2014-12-08 01:17:57 +01:00
Marco Pivetta
d259ba91b3
#1213 - DDC-3437 - refactoring tests to support embeddable class name != embeddable class property declaring class
2014-12-08 01:17:25 +01:00
Austin Morris
d48546d2dd
fix instantiation of embedded object in ReflectionEmbeddedProperty
2014-12-08 01:06:11 +01:00
Guilherme Blanco
9900d35367
Merge pull request #1214 from Fedik/fix-xml-export-options
...
XML export driver: fix the options export
2014-12-07 10:52:45 -05:00
Fedik
c1eff7045a
XML export driver: fix export options
2014-12-07 13:05:19 +02:00
Guilherme Blanco
0059e01936
Merge pull request #1208 from Ocramius/hotfix/DDC-3427-class-metadata-factory-should-accept-entitymanagerinterface-instances
...
DDC-3427 - class metadata factory should accept `EntityManagerInterface` instances
2014-12-05 12:22:23 -05:00
Marco Pivetta
590d971f83
Merge pull request #1211 from Ocramius/hotfix/DDC-3434-paginator-ignores-hidden-fields-in-order-by-query
...
DDC-3434 - paginator ignores `HIDDEN` fields in `ORDER BY` query
2014-12-05 18:02:39 +01:00
Marco Pivetta
ac67a10d4c
DDC-3434 - adding note on why restoring 'HIDDEN' selected fields is relevant
2014-12-05 18:02:12 +01:00
Marco Pivetta
6169175a89
DDC-3434 - HIDDEN modifier marked fields in ORDER BY clause are always preserved when creating a paginator subquery
2014-12-05 17:11:57 +01:00
Marco Pivetta
6e8057b6ea
DDC-3434 - adding test case for HIDDEN modifier fields in ORDER BY sequences: should be preserved in any case
2014-12-05 17:10:39 +01:00
Marco Pivetta
0c9a898ccd
DDC-3434 - removed unneeded escaping sequences
2014-12-05 17:09:59 +01:00
Guilherme Blanco
a6cf714f41
Merge pull request #1210 from Ocramius/hotfix/DDC-3336-undefined-property-with-paginator-and-scalar-expression-select
...
DDC-3336 - undefined property with paginator walker and scalar expression in ORDER BY clause
2014-12-05 10:42:55 -05:00
Marco Pivetta
e53e8bfe8e
DDC-3336 - applied hotfix: only PathExpression instances have a $field property
2014-12-05 14:56:47 +01:00
Marco Pivetta
c689ff081d
DDC-3336 - adding missing type-hint docblock
2014-12-05 14:55:56 +01:00
Marco Pivetta
2bc8811e62
DDC-3336 - renamed test method for clarity
2014-12-05 14:55:26 +01:00
Marco Pivetta
42e0e6b0b8
DDC-3336 - adding failing test case: scalar expressions in the ORDER BY clause crash the LimitSubqueryOutputWalker
2014-12-05 14:54:26 +01:00
Marco Pivetta
529a268bbc
DDC-3336 - importing platform classes
2014-12-05 14:53:42 +01:00
Steve Müller
38650b748d
Merge pull request #1207 from Ocramius/hotfix/embedded-classes-reflection-new-instance-creation
...
Embedded classes reflection new instance creation with internal PHP classes
2014-12-05 14:24:23 +01:00
Marco Pivetta
e65417f1f6
DDC-3427 - Adding setting an EntityManagerInterface instance in the ClassMetadataFactory#setEntityManager()
2014-12-05 13:49:42 +01:00
Marco Pivetta
d20e018081
DDC-3427 - Adding a test to verify that the ClassMetadataFactory supports setting an EntityManagerInterface instance
2014-12-05 13:38:45 +01:00
Marco Pivetta
dcf824688a
Verifying that reflection properties that don't contain an embeddable will not crash reading properties, but will return null instead
2014-12-05 13:15:15 +01:00
Marco Pivetta
b4a23e97a9
ReflectionEmbeddedProperty should be like any ReflectionProperty, and should therefore extend it for type compatibility
2014-12-05 13:06:41 +01:00
Marco Pivetta
112fdf46d0
Using instantiator to work with internal PHP classes as embeddables
2014-12-05 13:00:54 +01:00
Marco Pivetta
a8b0ac82b4
Adding a data-provider case for a generic model (non-internal class)
2014-12-05 12:57:48 +01:00
Marco Pivetta
ecf028490f
Test to verify that Doctrine\ORM\Mapping\ReflectionEmbeddedProperty is able to interact with internal PHP classes
2014-12-05 12:56:34 +01:00
Marco Pivetta
7f84bc76a6
Namespace correction
2014-12-05 12:43:12 +01:00
Marco Pivetta
56cb47c585
Adding a test asset to play around with reflection and internal classes
2014-12-05 12:41:22 +01:00
Marco Pivetta
fc3f233923
Yodaism good for you: is.
2014-12-05 11:18:10 +01:00
Marco Pivetta
1d5a0a0a1b
Adding docblocks
2014-12-05 11:17:43 +01:00
Marco Pivetta
b9506ac64a
Merge pull request #1195 from decoursin/patch-1
...
Correction Events.rs - Entity Listeners Resolver
2014-12-04 14:03:09 +01:00
Marco Pivetta
8d4b46d014
Merge branch 'hotfix/#1204-metadata-xml-exporter-should-export-sequence-generator-info'
...
Close #1204
2014-12-04 14:00:34 +01:00
Marco Pivetta
c35f1310bc
#1204 - using specific XML assertions to build a less-fragile test (asserting on the entire string may cause failures if the XML structure changes)
2014-12-04 14:00:05 +01:00
Marco Pivetta
ce308dc476
#1204 - refactored sequence-generator metadata exporting into own private method for simplicity
2014-12-04 14:00:05 +01:00
Paulo de Freitas
aa1454562c
Fix sequence-generator in MetaData exporter for XML Driver.
2014-12-04 14:00:05 +01:00
Marco Pivetta
798a8b6d91
Merge pull request #1205 from Ocramius/hotfix/#1200-Yaml-parse-does-not-accept-files-in-symfony-2-6-fix
...
Hotfix - #1200 - Symfony 2.7.x deprecation fixes
2014-12-04 13:59:02 +01:00
Marco Pivetta
351707f1f1
#1200 - bumping symfony/console dependency to ~2.5 because of the Symfony\Component\Console\Helper\Table not being available in < 2.5
2014-12-04 13:42:38 +01:00
Marco Pivetta
9d2c0481ae
#1200 - removing console deprecation errors by using the new Symfony\Component\Console\Helper\Table instead of the deprecated TableHelper
2014-12-04 13:40:22 +01:00
Marco Pivetta
d3b1bf571b
#1200 - removing Yaml::parse() deprecation errors by passing in file contents instead of file paths
2014-12-04 13:37:59 +01:00
Guilherme Blanco
30bf192cf4
Merge pull request #1201 from marcosdsanchez/master
...
Update working-with-objects.rst
2014-12-01 10:52:56 -05:00
Marcos Sánchez
8e26705693
Update working-with-objects.rst
...
Fix syntax error in constructor.
2014-12-01 12:50:11 -03:00
Marco Pivetta
c2ad338707
Merge pull request #1198 from Bilge/patch-2
...
Tables for buttons.
2014-11-28 12:23:23 +01:00
Marco Pivetta
18fd892c85
Merge pull request #1199 from kormik/patch-1
...
minor typo
2014-11-28 11:14:09 +01:00
Tomas Kormanak
27e671378b
minor typo
2014-11-28 08:40:00 +00:00
Bilge
13c03b573c
Tables for buttons.
2014-11-28 05:18:18 +00:00
Marco Pivetta
ee13405a13
Merge pull request #1197 from Bilge/patch-1
...
Minor grammar fix.
2014-11-27 19:16:00 +01:00
Marco Pivetta
9eae0d5ce8
Merge branch 'hotfix/#1196-inherit-mapped-superclass-indexes'
...
See DDC-3418
See DDC-3419
Close #1196
2014-11-27 19:10:57 +01:00
Marco Pivetta
b3fe0904eb
#1196 DDC-3418 DDC-3419 - Minor CS fixes, explicit setExpectedException calls
2014-11-27 19:10:45 +01:00
Marco Pivetta
71135972c6
#1196 DDC-3418 DDC-3419 - Renamed _factory to cmf
2014-11-27 19:08:10 +01:00
Marco Pivetta
291b68634e
#1196 DDC-3418 DDC-3419 - Adding missing docblock for test private property
2014-11-27 19:07:16 +01:00
Bilge
f9b4df70ff
Minor grammar fix.
2014-11-27 18:07:10 +00:00
Marco Pivetta
34d2af8a77
#1196 DDC-3418 DDC-3419 - assertArrayHasKey() instead of assertTrue(isset(...))
2014-11-27 19:06:42 +01:00
Marco Pivetta
084ce7ecc0
#1196 DDC-3418 DDC-3419 - reducing test assets annotations spacing for readability
2014-11-27 18:57:49 +01:00
Marco Pivetta
b761d84d4f
#1196 DDC-3418 DDC-3419 - refactoring class metadata factory to avoid duplicate checks
2014-11-27 18:54:10 +01:00
Marco Pivetta
7648a3c590
#1196 DDC-3418 DDC-3419 - refactoring inherited indexes copying logic into separate private method
2014-11-27 18:52:03 +01:00
Dustin Thomson
17ec1aab77
Modified class metadata factory to have entity tables inherit indexes from mapped superclasses
2014-11-27 18:41:33 +01:00
Marco Pivetta
ec6781954a
Merge branch 'hotfix/#1188-support-count-queries-with-parameters-in-removed-query-parts'
...
Close #1188
2014-11-27 18:16:22 +01:00
Marco Pivetta
f536daa1e4
#1188 - Simplified and optimized parameter un-setting logic
2014-11-27 18:08:11 +01:00
Marco Pivetta
ac0f1b2ce2
#1188 - Importing parser class
2014-11-27 17:59:12 +01:00
Marco Pivetta
64752532dd
#1188 - assertCount instead of assertEquals
2014-11-27 17:57:42 +01:00
Marco Pivetta
42547234d2
#1188 - minor CS fixes (avoiding DQL one-liner)
2014-11-27 17:54:02 +01:00
Marco Pivetta
ecb09b5627
#1188 - accessing Doctrine\ORM\Tools\Pagination\Paginator#getCountQuery() via reflection for test purposes
2014-11-27 17:50:27 +01:00
Marco Pivetta
69064ac13d
#1188 - making Doctrine\ORM\Tools\Pagination\Paginator#getCountQuery() private, as it is an implementation detail
2014-11-27 17:48:37 +01:00
Marco Pivetta
a80117a4ee
#1188 - removing unused variable assignments
2014-11-27 17:42:14 +01:00
Paweł Kolanowski
af39fce6e5
Missing doc block, removed parse() parameter.
...
Missing doc block, removed parse() parameter.
2014-11-27 17:27:22 +01:00
Merixstudio
18244161f7
Filtering by auto-increnement field causes test error.
...
Executing the same test many times causes error because AI fields.
2014-11-27 17:27:22 +01:00
Merixstudio
de1843ad30
Testing SQLs in functional test is not necessary
2014-11-27 17:27:22 +01:00
Merixstudio
fa014ee55d
Test parameter removing parameters passed to select part of query.
2014-11-27 17:27:22 +01:00
Merixstudio
d02ea224df
Allowed to get count query from paginator.
2014-11-27 17:27:22 +01:00
Merixstudio
42aff75108
Fixed counting exception
...
Fixed "Invalid parameter number: number of bound variables does not match number of tokens " exception during execution count on Query where select part of query contains :parameters.
2014-11-27 17:27:22 +01:00
Nick DeCoursin
82c5547931
Correction Events.rs - Entity Listeners Resolver
...
Configuring the Entity Listener Resolver can only be done before Entity Manager is initialized as described here: https://github.com/doctrine/doctrine2/pull/1193
2014-11-26 19:29:58 -05:00
Steve Müller
bf5003f25e
Merge pull request #1192 from javiereguiluz/patch-4
...
Fixed a very minor typo
2014-11-25 09:42:10 +01:00
Javier Eguiluz
7e64d606d2
Fixed a very minor typo
2014-11-25 09:41:13 +01:00
Marco Pivetta
88ce68e733
Merge pull request #1190 from c960657/autogenerate-integer
...
Document that AUTOGENERATE_ constants are allowed
2014-11-21 21:54:00 +01:00
Christian Schmidt
89684b4ce9
Document that AUTOGENERATE_ constants are allowed
2014-11-21 21:11:32 +01:00
Marco Pivetta
e7be0c4dc9
Merge pull request #1184 from goetas/patch-2
...
Postgres SERIAL is not a post-insert identifier generation strategy
2014-11-12 10:31:52 +01:00
Asmir Mustafic
a1660997ff
Postgres SERIAL is not a post-insert identifier generation strategy
2014-11-12 10:10:06 +01:00
Marco Pivetta
9280a4621d
Merge pull request #1183 from NAYZO/patch-2
...
Update tools.rst
2014-11-12 10:04:49 +01:00
Ala Eddine Khefifi
44304c30b3
Update tools.rst
2014-11-12 09:55:51 +01:00
Marco Pivetta
ab62914f87
Merge pull request #1089 from encoder32/EntityRepositoryGeneratorDefaultRepository
...
EntityRepositoryGenerator default repository
2014-11-11 16:22:51 +01:00
Marco Pivetta
f987cf77b5
Merge branch 'hotfix/#1173-merge-association-to-identical-entities'
...
Close #1173
2014-11-11 12:38:08 +01:00
Marco Pivetta
2888791e5c
#1173 - test CS fixes, reduced clutter code, made method names more explicit
2014-11-11 12:37:16 +01:00
Marco Pivetta
511893e182
#1173 - applying CS fixes on top of the patch
2014-11-11 12:27:57 +01:00
Mathieu De Zutter
2ead9e23ab
Fix merging of entities with associations to identical entities.
...
Without this patch, when an entity that refers multiple times to the same
associated entity gets merged, the second references becomes null.
The main issue is that even though doMerge returns a managed copy, that value
is not used while cascading the merge. These identicial entities are already
detected through the visitor map, but they are ignored. There should be some
refactoring so cascadeMerge calls a function that checks if the parent must be
updated, based on the return value of its call to doMerge. However, this patch
tries to impact the code as little as possible, and only introduces a new
function to avoid duplicate code.
The secondary issue arises when using inverted associations. In that case, it
is possible that an entity to be merged is already merged, so the the visitor
map is looked up by the hash of a managed copy instead of the original entity.
This means that in this case the visitor map entries should also be set to the
entity, instead of being set to 'true'.
2014-11-11 12:12:25 +01:00
Mathieu De Zutter
9caef62489
Test case for merging entities with associations to identical entities.
2014-11-11 12:12:25 +01:00
Marco Pivetta
25849a3412
Merge pull request #1177 from c960657/production-settings-arraycache
...
Ensure metadata cache is not ArrayCache in production
2014-11-11 10:43:29 +01:00
Christian Schmidt
3287ce12a4
Fix namespace collission
2014-11-11 08:31:36 +01:00
Christian Schmidt
c973d8df1a
Code style fixes.
2014-11-11 07:35:52 +01:00
jaimz22
dd012dfd90
oops.. forgot to add a condition
2014-11-08 16:56:42 +00:00
jaimz22
e2f1ea7f23
stupid cloud 9 ide broke my code :( sorry
2014-11-08 16:45:58 +00:00
jaimz22
c47a072815
fixed for failing test case. when a single DTO is specified in the query, you no longer get a multidimensional array returned.
2014-11-08 16:36:55 +00:00
jaimz22
2ffda34f23
fixing a missing index error
2014-11-08 10:15:33 -05:00
Christian Schmidt
0990d64756
Ensure metadata cache is not ArrayCache in production
2014-11-08 15:05:56 +01:00
Marco Pivetta
76e1a469ef
Merge pull request #1027 from PowerKiKi/feature-partial-indexes
...
Support for Partial Indexes for PostgreSql and Sqlite
2014-11-05 13:19:29 +01:00
James Murray
da7e4ed8de
removing orphaned scalar results and allowing mixed results when use new object expressions
2014-10-28 17:59:37 -04:00
James Murray
85eac7200d
Adding the ability to alias new object expressions
2014-10-28 17:34:57 -04:00
Marco Pivetta
20c6bfd360
Aligning expected exception test to typo fix in doctrine/doctrine2@b7d104d2a2 , which was breaking the build
2014-10-23 07:01:59 +02:00
Guilherme Blanco
b7d104d2a2
Fixed typo
2014-10-21 22:43:26 -04:00
Guilherme Blanco
3a0d7d1d6b
Merge pull request #1146 from c960657/order-by-assoc
...
Allow orderBy to reference associations
2014-10-21 21:40:04 -04:00
Guilherme Blanco
3924ede3ad
Merge pull request #1128 from Erikvv/patch-1
...
Add QueryBuilder::addSelect()
2014-10-21 21:35:26 -04:00
Kim Hemsø Rasmussen
6fc6d18882
Merge pull request #1165 from Ocramius/feature/#1120-metadata-info-command
...
[DDC-3205] #1120 - metadata info command
2014-10-20 20:46:33 +02:00
Marco Pivetta
ea6f2130b4
#1120 - downgrading requirement for symfony/console to ~2.3
...
Just need `Symfony\Component\Console\Helper\TableHelper` availability
2014-10-20 18:51:39 +02:00
Marco Pivetta
95bc0fb456
#1120 - using the Symfony\Component\Console\Helper\TableHelper for symfony/symfony:~2.3 compatibility
...
(Instead of `Symfony\Component\Console\Helper\Table`)
2014-10-20 18:49:54 +02:00
Marco Pivetta
a0e107249f
Removing public properties validation (supported)
2014-10-20 15:15:05 +02:00
Marco Pivetta
9ccb56a7ab
#1120 - applying CS fixes as per @dantleech's review
2014-10-19 19:56:21 +02:00
Marco Pivetta
9bf8f6ed4c
DDC-3261 - fixed link to DBAL documentation (should always reference latest)
2014-10-19 19:18:11 +02:00
Marco Pivetta
29e99b2b89
#1120 - removed duplication: field and association mappings actually use the same dump format
2014-10-19 18:57:58 +02:00
Marco Pivetta
d5d64b756d
#1120 - removed redundant if block
2014-10-19 18:42:14 +02:00
Marco Pivetta
1208cc836a
#1120 - registering the new MappingDescribeCommand with the ORM's ConsoleRunner
2014-10-19 18:41:14 +02:00
Marco Pivetta
806068b0df
#1120 - removing useless variables, refactoring
2014-10-19 18:36:08 +02:00
Marco Pivetta
39a8a31de9
#1120 - removing unused private properties
2014-10-19 18:34:42 +02:00
Marco Pivetta
574f3ea909
#1120 - map functions over array iteration/mutation
2014-10-19 18:34:06 +02:00
Marco Pivetta
254a46e79c
#1120 - avoiding mutable state for rows/output
2014-10-19 18:32:12 +02:00
Marco Pivetta
250b38710c
#1120 - missing docblock parameter
2014-10-19 18:23:50 +02:00
Marco Pivetta
db74efbe34
#1120 - test coverage annotations
2014-10-19 18:22:28 +02:00
Marco Pivetta
0f289a1270
#1120 - cs cleanups - moving success cases at the end of methods
2014-10-19 18:21:45 +02:00
Marco Pivetta
97fdd0adb7
#1120 - cleaning up try-catch code when fetching metadata
2014-10-19 18:14:33 +02:00
Marco Pivetta
100766e360
#1120 - Removing example array('Foo', 'Bar', 'Boo') dumped data
2014-10-19 18:13:46 +02:00
Marco Pivetta
dcdffbffc7
#1120 - assuming existence of Symfony\Component\Console\Helper\Table
2014-10-19 18:13:01 +02:00
Marco Pivetta
a762158e99
#1120 - since we want to use Symfony\Component\Console\Helper\Table, symfony/console:~2.5 is required
2014-10-19 18:11:42 +02:00
Marco Pivetta
7cf427cfbf
#1120 - avoiding version comparisons when working with version-dependant constants
2014-10-19 17:53:40 +02:00
Marco Pivetta
ed79648d7d
#1120 - avoiding storing the Doctrine\ORM\EntityManager in the command itself
2014-10-19 17:51:17 +02:00
Marco Pivetta
cf078d8da8
#1120 - avoiding storing the Doctrine\ORM\EntityManager in the command itself
2014-10-19 17:49:28 +02:00
Marco Pivetta
e9d7c23261
#1120 - MappingDescribeCommand can be final
2014-10-19 17:43:32 +02:00
dantleech
37de75b2ae
Split new functionality into new command
2014-10-19 17:40:50 +02:00
dantleech
c71b489e9e
Added preg_quote and doc blocks
2014-10-19 17:40:50 +02:00
dantleech
b5552a82e3
Code review fixes
2014-10-19 17:40:50 +02:00
dantleech
51cd8f7ce8
Added test
2014-10-19 17:40:50 +02:00
dantleech
45ce6a41a3
Expanded scope of orm:info to include metadata information
2014-10-19 17:40:50 +02:00
Marco Pivetta
a9bd51c0e4
Merge branch 'hotfix/#615-enforce-A-to-Z-sql-table-aliases'
...
Close #615
2014-10-19 17:25:09 +02:00
Marco Pivetta
b989175754
#615 - Removing unused assignment
2014-10-19 17:24:07 +02:00
Marco Pivetta
264cd8ee11
#615 - Refactoring test case to remove duplication
2014-10-19 17:21:13 +02:00
Marco Pivetta
69494dc624
#615 - sql table aliases should stay constant over time
2014-10-19 17:18:30 +02:00
Marco Pivetta
10da2eb85b
#615 - Using a data provider to build aliases for the SqlWalkerTest
2014-10-19 17:16:07 +02:00
Marco Pivetta
17c9388473
#615 - Test coverage annotations
2014-10-19 17:10:39 +02:00
Marco Pivetta
435befd25c
#615 - EOF EOL fixes
2014-10-19 17:09:41 +02:00
Marco Pivetta
d557a0e01b
#615 - assignment alignment
2014-10-19 17:09:27 +02:00
Marco Pivetta
a4e9c235f8
#615 - assignment alignment
2014-10-19 17:08:33 +02:00
Mike Meier
109b0444f5
add SqlWalkerTest for getSQLTableAlias method
2014-10-19 17:05:34 +02:00
Mike Meier
fb5f76f025
rewrite tablePrefixAlias
2014-10-19 17:05:34 +02:00
Mike Meier
ebc996c820
Update SqlWalker.php
...
Always be sure that only a-z characters are used for table alias, otherwise use generic "t" for "table"
2014-10-19 17:05:34 +02:00
Steve Müller
06b5c84728
Merge pull request #1160 from Ocramius/hotfix/#1159-multiple-entity-managers-per-repository-factory
...
#1159 - multiple entity managers per repository factory should be supported
2014-10-19 14:58:04 +02:00
Marco Pivetta
0f26c62e73
Merge pull request #1143 from MajorCaiger/master
...
Fixed a bug so that a versioned entity with a oneToOne id can be created
2014-10-19 11:52:37 +02:00
Marco Pivetta
d361ed904e
Merge pull request #1164 from AlphaStream/fix-querybuilder-on-hhvm
...
[QueryBuilder] Remove unused method parameters to run on HHVM/PHP7
2014-10-19 10:56:32 +02:00
Marco Pivetta
697640f561
Setting default timezone, as HHVM is misconfigured on travis-ci
2014-10-19 10:54:35 +02:00
Alex Bakhturin
b33c9befb7
[QueryBuilder] Remove unused method parameters that are shadowed by local variables
...
PHP5 treats the left part of such assignment as an independent local variable, while HHVM treats it as a reference to the method parameter. This leads to the value of the parameter being changed, which, in turn, causes func_get_args() to return not what is expected.
This commit is a part of the effort to make Symfony run flawlessly on HHVM. This issue causes a bunch of Symfony tests to fail on HHVM.
2014-10-17 11:17:33 -07:00
Marco Pivetta
f5ecabbc21
Merge pull request #1163 from taavit/patch-1
...
Update xml-mapping.rst
2014-10-17 00:13:28 +02:00
Dawid Królak
143f87960e
Update xml-mapping.rst
...
Fixed closing entity tag.
2014-10-17 00:11:56 +02:00
Marco Pivetta
35d4405727
Merge pull request #1161 from gammamatrix/patch-1
...
Fixing error with from() parameters in example
2014-10-14 13:18:27 +02:00
Jeremy Postlethwaite
abe97bf0df
Fixing error with from() parameters in example
...
The from method requires $from and the $alias to be separate parameters.
public function from($from, $alias, $indexBy = null);
The examples show: from('User u')
2014-10-13 20:37:19 -07:00
Marco Pivetta
f28fa2d3a1
#1159 - EOF EOL CS fixes for Doctrine\ORM\Repository\DefaultRepositoryFactory tests
2014-10-14 01:49:57 +02:00
Marco Pivetta
b61496a36b
#1159 - adding UPGRADE.md notes for Doctrine\ORM\Repository\DefaultRepositoryFactory becoming final
2014-10-14 01:48:25 +02:00
Marco Pivetta
8093c6ddb0
#1159 - protecting Doctrine\ORM\Repository\DefaultRepositoryFactory API by making it final and its protected members private
2014-10-14 01:46:50 +02:00
Marco Pivetta
a9847533e5
#1159 - Doctrine\ORM\Repository\DefaultRepositoryFactory keeps separate caches per entity manager used to build repositories
2014-10-14 01:46:14 +02:00
Marco Pivetta
56378b9bf0
#1159 - optimized imports
2014-10-14 01:40:38 +02:00
Marco Pivetta
7142c9029c
#1159 - Doctrine\ORM\Repository\DefaultRepositoryFactory should create different repositories for different entity managers
2014-10-14 01:40:19 +02:00
Marco Pivetta
9ef3285ebb
#1159 - verifying that Doctrine\ORM\Repository\DefaultRepositoryFactory considers custom repository class from metadata when instantiating repositories
2014-10-14 01:35:51 +02:00
Marco Pivetta
1e467fd23c
#1159 - verifying that Doctrine\ORM\Repository\DefaultRepositoryFactory caches instantiated repositories locally
2014-10-14 01:32:04 +02:00
Marco Pivetta
5adce9a1e3
#1159 - base coverage for the Doctrine\ORM\Repository\DefaultRepositoryFactory implementation
2014-10-14 01:29:45 +02:00
Marco Pivetta
3ca0dae606
Merge pull request #1156 from NAYZO/patch-1
...
Fixed missed initialization in CommitOrderCalculator.php
2014-10-13 02:36:00 +02:00
Marco Pivetta
1e6ca40ffa
Merge pull request #1157 from gennadiylitvinyuk/patch-1
...
Fixing calls of schema-update tools
2014-10-13 02:32:42 +02:00
Marco Pivetta
1d8ef5ed18
Merge pull request #1158 from josemalonsom/update-query-builder-ref-doc
...
Update QueryBuilder reference documentation.
2014-10-13 02:26:42 +02:00
Jose M. Alonso M
82887d0361
Update QueryBuilder reference documentation.
...
- Updated the signature of methods "from", "innerJoin" and "leftJoin"
since it does not match the actual implementation.
- Added reference to the "join" method.
2014-10-12 20:31:33 +02:00
Gennadiy Litvinyuk
83cd44697d
Fixing calls of schema-update tools
...
composer-generated binaries should be called without php interpreter.
Added reminder to update schema.
2014-10-12 17:50:47 +02:00
Ala Eddine Khefifi
f2bdfe102e
Fixed missed initialization in CommitOrderCalculator.php
2014-10-12 14:04:41 +01:00
Marco Pivetta
10b801dec0
Adding note about a minor BC break: d2 does not call __clone on new objects anymore.
2014-10-06 14:57:03 +02:00
Christian Schmidt
94f5f53d2a
Allow orderBy to reference associations
2014-10-05 10:16:58 +02:00
Marco Pivetta
0bff6aadbc
Merge pull request #1147 from naitsirch/master
...
Extended the docs for mapping attributes precision and scale
2014-10-03 00:50:00 +02:00
Rob Caiger
dd398ce577
- Fixed the basic entity persister so that versioned OneToOne entities can be created
...
- Created an IdentifierFlattener utility class
- Moved the logic for the flatten identifier method into the new utility class
- Replaced calls for private flattenIdentifier to use new utility
- Added appropriate unit tests
2014-10-01 14:01:44 +01:00
Steve Müller
05045d9544
Merge pull request #1148 from naitsirch/hotfix/DWEB-118
...
[DWEB-118] Fixed small typo in documentation about extra lazy associations
2014-09-27 18:19:53 +02:00
naitsirch
547a902bd3
Fixed small typo in documentation about extra lazy associations #DWEB-118
2014-09-26 19:49:12 +02:00
Christian Stoller
d93f648230
Extended the docs for mapping attributes precision and scale
2014-09-25 09:38:34 +02:00
Marco Pivetta
3f8865c6fb
Merge pull request #1092 from birko/pagination-count-walker
...
[DDC-2794] Arbitrary Join count walkers solution
2014-09-23 00:30:30 +02:00
Marco Pivetta
15a00ea807
Clearing cache by --id, --regex, --prefix and --suffix is not supported anymore.
2014-09-14 17:30:47 +02:00
Marco Pivetta
f12c311a79
Merge pull request #1135 from deeky666/DDC-3304
...
[DDC-3304] Add support for embeddables in entity generator
2014-09-12 21:54:45 +02:00
Steve Müller
b291d8d589
add support for embeddables in entity generator
2014-09-12 20:29:37 +02:00
Steve Müller
b249aa9f65
Merge pull request #1132 from Ocramius/hotfix/DDC-3272-entity-generator-mapped-superclass-casing
...
DDC-3272 entity generator mapped superclass casing
2014-09-10 18:27:51 +02:00
Marco Pivetta
4974edc70a
DDC-3272 - fixing issue with mapped superclass name, minor refactoring
2014-09-10 17:00:06 +02:00
Marco Pivetta
dd9a6bea0a
DDC-3272 - minor cleanups - inspecting a test failure related with @Doctrine\ORM\Mapping\Table autoloading
2014-09-10 16:57:35 +02:00
Marco Pivetta
ffe38e5088
DDC-3272 - cleanups, importing classes, optimized imports
2014-09-10 16:41:49 +02:00
Marco Pivetta
b9090ef73e
DDC-3272 - failing test (to be run in insulation because of autoloading) that verifies that a wrong annotation is generated for @MappedSuperclass
2014-09-10 16:40:17 +02:00
Marco Pivetta
e2fea427a4
Merge pull request #1127 from crybat/master
...
Document embeddables column prefixing
2014-09-10 16:12:22 +02:00
encoder64
6bc003e47d
simple fixes
2014-09-10 01:07:22 +03:00
encoder64
e295a6d05e
visibility changed && few simple fixes
2014-09-09 22:17:10 +03:00
encoder64
409f6b4bc1
Unit Tests && simple fixes
2014-09-07 18:26:09 +03:00
encoder64
cd547fecea
Corrected names to DDC3231
2014-09-06 18:29:14 +03:00
encoder64
859a5f88cb
Unit Tests && simple fixes
2014-09-06 18:14:16 +03:00
encoder64
dc3bc45d1d
Merge remote-tracking branch 'upstream/master' into EntityRepositoryGeneratorDefaultRepository
2014-09-06 15:33:48 +03:00
Mauro Pinto
857fed0310
Make embeddable doc more succinct, fix xml
2014-09-03 11:13:28 +01:00
Erik van Velzen
ba50f978a5
Add QueryBuilder::addSelect()
2014-09-02 13:52:52 +02:00
František Bereň
589d26fc5e
Changed calling $from[0] to using reset($from)
...
changed usage $from[0] according suggestion from @Ocramius to use array
reset function
2014-09-02 08:39:29 +02:00
Mauro Pinto
3bd916f763
Document embeddables column prefixing
2014-09-01 12:48:10 +01:00
Marco Pivetta
d9b43dc649
Merge pull request #1116 from deeky666/DDC-3265
...
[DDC-3265] Fix DocBlock
2014-08-30 04:22:47 +02:00
Marco Pivetta
6e79515a75
Merge pull request #1123 from stof/patch-1
...
Fixed the structure of the reverse-engineered mapping
2014-08-30 04:19:55 +02:00
Marco Pivetta
6e34985b51
Merge pull request #1126 from phansys/master
...
Fixed new line in docblock
2014-08-30 04:13:55 +02:00
Javier Spagnoletti
f731a66e1c
Removed extra line breaks for docblocks in set, get, add and remove method templates.
2014-08-29 23:11:49 -03:00
Javier Spagnoletti
1378626937
Fixed new line in docblock ( 247803715b).
2014-08-29 22:49:23 -03:00
Guilherme Blanco
2a80e34179
Merge pull request #1125 from kcassam/patch-1
...
Update improving-performance.rst
2014-08-29 18:40:20 -04:00
Ka
2120d41029
add a link to said chapter
2014-08-29 08:47:28 +02:00
Ka
398688ab38
Update improving-performance.rst
2014-08-29 08:42:14 +02:00
František Bereň
d48be34696
CS Fixes
2014-08-28 13:17:25 +02:00
Guilherme Blanco
4b504c9436
Merge pull request #1109 from doctrine/hotfix/DDC-3120-php-5.6-RC3-compat
...
DDC-3120 - PHP 5.6-RC3 compatibility
2014-08-27 12:27:05 -04:00
Christophe Coevoet
f0c02bb6d9
Fixed the test expectations for the DatabaseDriver
2014-08-27 14:00:34 +02:00
Christophe Coevoet
00eb0d3b67
Fixed the structure of the reverse-engineered mapping
2014-08-27 13:56:02 +02:00
Guilherme Blanco
3d4113bd1b
Merge pull request #1122 from Ocramius/feature/support-arithmetic-expressions-in-count
...
Support arithmetic expressions in `COUNT()`
2014-08-26 21:01:56 -04:00
Marco Pivetta
48a86511cb
DDC-3276 - #1122 - updating EBNF in documentation to reflect new syntax support
2014-08-27 02:17:08 +02:00
Marco Pivetta
45d74e7220
DDC-3276 - #1122 - updating EBNF in docblock to reflect new syntax support
2014-08-27 02:12:08 +02:00
Marco Pivetta
a2e0133a94
Adding DDC-3276 test group
2014-08-27 02:01:56 +02:00
Marco Pivetta
097840dc93
Allowing expression in COUNT() DQL aggregation functions
2014-08-27 01:56:11 +02:00
Marco Pivetta
02ba144c8d
Adding test to verify SQL generation with an expression in COUNT()
2014-08-27 01:55:28 +02:00
Marco Pivetta
91fa4c9be3
Merge pull request #1121 from deeky666/DDC-3274
...
[DDC-3274] Improve schema validator error message for invalid bi-directional relations
2014-08-26 23:27:23 +02:00
encoder64
c8565c2772
Visibility for EntityRepositoryGenerator::generateClassName()
2014-08-26 21:42:55 +03:00
Steve Müller
8d3fba5540
improve schema validator error message for invalid bi-directional relations
2014-08-26 19:46:17 +02:00
Steve Müller
65f8357b46
Merge pull request #1119 from stof/travis_colors
...
Enabled colors for the PHPUnit output on Travis
2014-08-22 14:00:20 +02:00
Christophe Coevoet
e7739d9411
Enabled colors for the PHPUnit output on Travis
2014-08-22 13:42:43 +02:00
Steve Müller
ad1f228ef6
fix DocBlock
2014-08-22 09:26:54 +02:00
Guilherme Blanco
400acad533
Merge pull request #1105 from deeky666/nested-embeddables
...
Add support for nesting embeddables
2014-08-21 16:33:44 -04:00
Steve Müller
e47b31845c
Merge pull request #1115 from armetiz/patch-1
...
Fix wrong variable name
2014-08-21 11:22:35 +02:00
Thomas Tourlourat
613119599f
Fix wrong variable name
2014-08-21 10:42:22 +02:00
Marco Pivetta
ff80187930
Merge pull request #1098 from encoder32/DDC-1590
...
#DDC-1590: Fix Inheritance in Code-Generation
2014-08-18 22:35:52 +02:00
Marco Pivetta
c20b3a7cf2
Merge branch 'hotfix/#1112-single-repository-for-aliased-entity'
...
Close #1112
2014-08-18 15:22:13 +02:00
Marco Pivetta
dfbaac0401
#1112 - Fixed type-hint that is incompatible with most IDEs
2014-08-18 15:18:59 +02:00
Marco Pivetta
aab7fce2d4
#1112 - Elvis operator reduces code duplication even more
2014-08-18 15:17:54 +02:00
Marco Pivetta
bf03694e28
#1112 - Yoday need you may, better IDE hinting as well needed is.
2014-08-18 15:16:45 +02:00
Marco Pivetta
19d3552f2a
#1112 - Removing useless trimming of the entity name being passed in
2014-08-18 15:14:53 +02:00
Marco Pivetta
36bbd28b75
#1112 - adding test to verify that leading backslash is not relevant when fetching repositories
2014-08-18 15:11:39 +02:00
Marco Pivetta
ae16afa428
#1112 - adding DDC-3257 group to test method
2014-08-18 15:07:07 +02:00
Marco Pivetta
01f22988b1
#1112 - cleaning up repository test - makes assertions more clear/simpler to read
2014-08-18 15:06:37 +02:00
Marco Pivetta
3fed769b40
#1112 - avoiding useless assignments/splitted return statement
2014-08-18 15:02:34 +02:00
Marco Pivetta
7865de92ab
#1112 - renamed $class to $className
2014-08-18 15:01:52 +02:00
Giorgio Premi
a665cb0229
DefaultRepositoryFactory: single repository for aliased entities
2014-08-18 14:52:01 +02:00
Marco Pivetta
5ff67c92ee
Merge pull request #1111 from eko/master
...
Fix inheritance hierarchy wrong exception message
2014-08-15 16:13:33 +02:00
Vincent Composieux
edc2ed9512
Fix QueryException::instanceOfUnrelatedClass() message
2014-08-15 15:39:56 +02:00
Guilherme Blanco
ebc70d1baf
Merge pull request #1110 from baileylo/patch-2
...
Changed table name to be more appropriate.
2014-08-14 20:16:34 -04:00
Logan Bailey
9b7318ab4c
Changed table name to be more appropriate.
...
This change assumes that the Article object references the articles tables, not the user table.
2014-08-14 17:07:05 -07:00
Marco Pivetta
7b145f8269
DDC-3120 - requiring doctrine\instantiator:~1.0.1 as of doctrine/instantiator#4
2014-08-14 16:55:32 +02:00
Marco Pivetta
361ec2a474
DDC-3120 - using Doctrine\Instantiator when building new instances
2014-08-14 15:51:48 +02:00
Marco Pivetta
f8a8437c95
DDC-3120 - need to wakeup reflection BEFORE using any ClassMetadata API
2014-08-14 15:51:17 +02:00
Marco Pivetta
c2993bcdeb
DDC-3120 - add failing test for un-serialization of an internal PHP class from cached metadata instance
2014-08-14 15:39:58 +02:00
Marco Pivetta
d52dd39592
DDC-3120 - add failing test for un-serialization of an internal PHP class
2014-08-14 15:38:55 +02:00
Marco Pivetta
2c3126353c
DDC-3120 - adding instantiator dependency
2014-08-14 15:33:09 +02:00
Steve Müller
6ac19b04bf
Merge pull request #1108 from umpirsky/patch-1
...
Minor CS fix
2014-08-12 10:16:17 +02:00
Saša Stamenković
133bd288bf
Minor CS fix
2014-08-12 09:57:19 +02:00
Steve Müller
0768916a06
fix handling infinite nesting of embeddables
2014-08-12 07:56:39 +02:00
Steve Müller
bca9d31531
add support for nesting embeddables
2014-08-11 16:53:18 +02:00
encoder64
cd4bc93483
Simple Fixes
2014-08-09 13:27:38 +03:00
encoder64
20b72ef344
Visibility for EntityRepositoryGenerator::$repositoryName
2014-08-09 13:20:27 +03:00
Adrien Crivelli
1003466a5f
Surround ! with spaces according to code style
2014-08-05 18:07:00 +09:00
encoder64
94ba6e2dfc
#DDC-1590: Simple Fixes
2014-08-04 20:18:26 +03:00
Marco Pivetta
723529ffff
Merge pull request #1069 from anho/reuse-console-app
...
added method to be able to reuse the console application
2014-08-04 16:17:11 +02:00
encoder64
4e805bb59a
#DDC-1590: Fix Inheritance in Code-Generation: Code Style Fixes
2014-08-03 17:07:20 +03:00
encoder64
e0ae7634d5
#DDC-1590: Fix Inheritance in Code-Generation
2014-08-03 17:02:33 +03:00
Marco Pivetta
2ae8538f96
Merge pull request #1096 from simonharris/master
...
Changes for grammar and clarity
2014-07-31 18:02:34 +02:00
Simon Harris
7c2ab7fff8
Changes for grammar and clarity
2014-07-31 16:45:33 +01:00
Simon Harris
bf91d03adf
Merge pull request #1 from doctrine/master
...
Update from original
2014-07-31 16:24:31 +01:00
František Bereň
54ac6a0535
Updated Asset queries
...
Missing braces and selected fields
2014-07-31 09:01:58 +02:00
František Bereň
458b953522
fixed typos in tests
2014-07-31 08:43:02 +02:00
František Bereň
164352562b
Added Tests for Arbitrary Join
2014-07-31 08:31:39 +02:00
Marco Pivetta
0650bb954f
Merge pull request #1094 from thekeyboardbum/master
...
Fix bulk insert code example
2014-07-31 00:06:05 +02:00
Justin
2d23c95c3f
Fix bulk insert code example
...
Previous code example did not flush all entities when entity count was not a multiple of batch count.
2014-07-30 15:00:35 -07:00
Marco Pivetta
66d67445c9
Merge pull request #1093 from malukenho/patch-2
...
Use `null` comparation instead of `is_null()`
2014-07-30 21:58:55 +02:00
Jefersson Nathan
1b9f42ae67
Use null comparation instead of is_null()
2014-07-30 16:54:24 -03:00
František Bereň
a37f99f242
Root selection according other pagination tools
...
changed root selection in Walkers from looping queryComponents to using
$AST->fromClause as other walkers have
2014-07-30 15:55:14 +02:00
František Bereň
114bd2435f
Arbitrary Join count walkers solution
...
Possible solution for Arbitrary Join problem in pagination count
walkers:
https://groups.google.com/forum/#!topic/doctrine-user/rpPYCDNKOU8
Added a condition to test query component against SelectStatement from
clause
2014-07-30 09:56:22 +02:00
encoder64
df80d82aab
Reverted visibility for EntityRepositoryGenerator::generateEntityRepositoryNamespace()
2014-07-27 20:15:18 +03:00
encoder64
5d608b6206
Private method EntityRepositoryGenerator::generateEntityRepositoryNamespace() changed to protected
2014-07-27 19:05:42 +03:00
encoder64
a4c7a89507
className fix: If namespace is not set then ClassName will be cut of
2014-07-27 17:28:06 +03:00
encoder64
c04b01cbd7
Added NS checking
2014-07-27 17:02:19 +03:00
encoder64
3dc2a68583
simple fixes
2014-07-27 15:22:51 +03:00
encoder64
90efaeec42
Code Style fixes
2014-07-27 14:54:35 +03:00
encoder64
c0ee57ae55
Default/Custom Entity Repository for Entity Repository Generator
2014-07-27 14:44:31 +03:00
Marco Pivetta
089cca636e
Merge pull request #1088 from austinsmorris/fix-clt-autoload-path
...
Fix the composer autoload paths for the doctrine CLT
2014-07-24 17:34:21 +02:00
Austin Morris
a6a9c72a75
Fix the composer autoload paths for the doctrine CLT
2014-07-24 09:52:55 -04:00
Andreas Hörnicke
a76506c3fd
amended documentation
2014-07-24 09:38:08 +02:00
Andreas Hörnicke
1d16e5322f
added a simple test
2014-07-24 09:23:36 +02:00
Marco Pivetta
2b24478f05
Merge pull request #1087 from malukenho/patch-1
...
Remove the error control operator
2014-07-24 00:35:18 +02:00
Jefersson Nathan
70fe21b30a
Remove the error control operator
2014-07-23 17:09:47 -03:00
Adrien Crivelli
bb5345b330
Adapt formatting to pre-existing content
2014-07-22 10:44:45 +09:00
Adrien Crivelli
27adf8d6e9
Refactor partial into options array
...
This coherent with what is done for Table. All platform specific things
are grouped into an options array. Eventually flags should be migrated
into options as well.
2014-07-22 10:32:31 +09:00
Adrien Crivelli
eeb7ff4a6d
Support for Partial Indexes for PostgreSql and Sqlite
...
Support for Partial Indexes was available in Doctrine 1 following
http://www.doctrine-project.org/jira/browse/DC-82 . This commit
reintroduce support for Doctrine 2. We use the same syntax with an
optionnal "where" attribute for Index and UniqueConstraint.
2014-07-22 10:32:30 +09:00
Marco Pivetta
499f09fc99
Merge pull request #1084 from hartca/master
...
Update advanced-field-value-conversion-using-custom-mapping-types.rst
2014-07-18 01:25:50 +02:00
hartca
0ab2672872
Update advanced-field-value-conversion-using-custom-mapping-types.rst
2014-07-18 00:10:47 +01:00
Marco Pivetta
205a5de4e5
Merge pull request #1083 from deeky666/DDC-3073
...
[DDC-3073] Add documentation about how to map column options
2014-07-17 11:56:40 +02:00
Steve Müller
040c445297
add documentation about how to map column options
2014-07-17 11:28:43 +02:00
Guilherme Blanco
c019047d6c
Merge pull request #1082 from scotam/invalid-parameter-count
...
added more informative error messages when invalid parameter count
2014-07-15 11:06:53 -04:00
Rhodri Pugh
ad10a18071
added more informative error messages when invalid parameter count
2014-07-15 13:17:22 +01:00
Marco Pivetta
85fbf68436
Merge branch 'hotfix/#1019-detached-entity-exception-rewording'
...
Close #1019
2014-07-14 11:25:42 +02:00
Andreas Flack
0ade3aa62a
Improve phrasing on exception message instead of trying to fix callers
2014-07-14 11:25:04 +02:00
flack
b8ef3af982
Small grammar fix
...
The exception was reading
```
A detached entity was found during {removed|persisted} [entityName]
```
I changed the verbs to infinitive now. Alternatively, the text in ``ORMInvalidArgumentException::detachedEntityCannot`` could also be changed to read
```
Detached entity [entityName] cannot be {removed|persisted}
```
2014-07-14 11:25:04 +02:00
Marco Pivetta
5361676bba
Merge pull request #1038 from Greenflex/doc/dql-hidden-keyword
...
Add documentation for the `HIDDEN` keyword in DQL
2014-07-14 11:18:30 +02:00
Marco Pivetta
90dee7036d
Merge pull request #1067 from albertvolkman/add-fullstop-and-newline
...
Add fullstop and newline after property description.
2014-07-14 11:09:40 +02:00
Marco Pivetta
b80149344d
Merge pull request #1073 from kamazee/add_passing_type_to_rsm_in_sql_walker
...
Add missing type mapping
2014-07-14 10:51:13 +02:00
Alexander Kurilo
38fcc66c16
Add missing type mapping
...
Fixes DDC-3192
Refs DDC-2494
This is essentially a fix from DDC-2494 applied to SQLWalker.
The issue: type was not converted to PHP value when the result is fetched by
executing DQL query rather than using entity manager's findX(). Similar issue
for BasicEntityPersister (which is used when em's findX is executed) was fixed
in DDC-2494, but SQLWalker made the issue valid for any custom query.
2014-07-14 11:22:08 +03:00
Marco Pivetta
ae0ee72425
Merge pull request #1080 from danielsippel/DDC-2021
...
possible fix for DDC-2021
2014-07-11 21:35:34 +02:00
Daniel Sippel
ae2235fd3c
DDC-2021 sql generation test: remove comment
2014-07-10 00:32:24 +02:00
Daniel Sippel
b31ba98076
DDC-2021 add sql generation test
2014-07-10 00:27:28 +02:00
Daniel Sippel
45358bf5d0
possible fix for DDC-2021
2014-07-09 16:39:44 +02:00
Marco Pivetta
bf1e7e150e
Merge pull request #1078 from renan/patch-1
...
Removing Value Objects from limitations
2014-07-07 20:20:59 +02:00
Renan Gonçalves
c9901c9017
Removing Value Objects from limitations as per #835
2014-07-07 20:17:56 +02:00
Marco Pivetta
a8035f25a2
Merge pull request #1074 from zimmermanj42/DDC-3160
...
[DDC-3160] Alternate fix for DDC-2996 bug
2014-07-06 16:07:43 +02:00
Justin Zimmerman
6a4867512e
Fix test issues.
2014-07-04 11:15:57 -04:00
Justin Zimmerman
65e7cc9143
[DDC-3160] Change to fix that was implemented for DDC-2996.
...
A fix for DDC-2996 was implemented that broke quite a few extensions.
This commit is an attempt to fix the DDC-2996 bug without the adverse side effects seen in DDC-3160.
Basically, if changes are detected that would cause a changeset to be made, but the entity is awaiting insertion, the code will not save the changeset nor flag the entity as awaiting updating in the Unit of Work.
Some styling tweaks based on Pull Request guidelines.
2014-07-04 10:51:04 -04:00
Guilherme Blanco
8c0166d3bf
Merge pull request #1076 from velosipedist/fix-typos
...
Fix switch non-uniform syntax
2014-07-01 23:11:53 -04:00
velosipedist
60cb01be1f
Fix switch non-uniform syntax
2014-06-29 18:00:02 +04:00
Marco Pivetta
c370426792
Merge pull request #1075 from vilartoni/master
...
Fixed query cache id generation: added platform to hash
2014-06-27 22:37:36 +02:00
Antonio Vilar
4e61ceb0df
Added platform key
2014-06-27 22:36:02 +02:00
Antonio Vilar
0dde8585c3
Fixed query cache id generation: added platform to hash
2014-06-27 20:29:55 +02:00
Marco Pivetta
9e36a95a97
Merge pull request #1065 from egeloen/DDC-3179
...
[DDC-3179] EntityNotFoundException on the postRemove event if the entity is a proxy
2014-06-26 18:25:53 +02:00
Eric GELOEN
20f96cc9d3
[DDC-3179] Document postRemove limitation
2014-06-26 18:09:32 +02:00
Marco Pivetta
22d71de2c3
Merge pull request #1071 from VasekPurchart/fix-setup-cache
...
Setup::createConfiguration breaks Cache interface contract
2014-06-26 02:15:54 +02:00
Vasek Purchart
ee5f465a2f
set namespace in setup only on CacheProvider instances
2014-06-26 01:29:35 +02:00
Andreas Hörnicke
eef32d4372
added method to be able to reuse the console application
2014-06-24 11:02:24 +02:00
Marco Pivetta
d98b4a5124
Merge pull request #1068 from jkavalik/patch-1
...
Fix typo in documentation
2014-06-24 08:25:19 +02:00
jkavalik
d5dd21dd79
Fix typo in documentation
2014-06-24 08:00:45 +02:00
Albert Volkman
247803715b
Add fullstop and newline after property description.
2014-06-23 09:53:27 -04:00
Guilherme Blanco
38187a31d6
Merge pull request #1032 from bakura10/optimized-contains
...
Add support for optimized contains in LazyCriteria
2014-06-21 08:56:47 -04:00
Guilherme Blanco
381cf8022f
Merge pull request #1063 from FlorianLB/master
...
singularize variable name on add/remove methods for EntityGenerator
2014-06-21 08:49:53 -04:00
Marco Pivetta
84a0fddaf4
Merge branch 'hotfix/#1064-xsd-on-update-removal'
2014-06-19 16:06:03 +02:00
Marco Pivetta
19b5e87cab
on-update is not supported anymore
2014-06-19 16:05:12 +02:00
Marco Pivetta
e940ce1df6
Replacing " with ' to avoid escaping warnings
2014-06-19 15:54:43 +02:00
Marco Pivetta
59720370f9
Corrected FQCN reference in @expectedException
2014-06-19 15:53:37 +02:00
Marco Pivetta
7dfca09ff6
Minor CS fixes (use statements compliant with PSR-2)
2014-06-19 15:53:11 +02:00
Marco Pivetta
85c02e57b1
Merge pull request #1064 from stefanotorresi/update-xsd
...
remove on-update from join-column
2014-06-19 14:33:58 +02:00
Stefano Torresi
391847d627
remove on-update from join-column
2014-06-19 14:27:56 +02:00
FlorianLB
fdca5d7584
singularize variable name on add/remove methods for EntityGenerator
2014-06-19 10:00:40 +02:00
Guilherme Blanco
f7c5a0684a
Merge pull request #1060 from ureimers/master
...
[DDC-3170] SimpleObjectHydrator fails to get discriminator column from mapped SQL result
2014-06-17 10:44:16 -04:00
Ulf
a7aa634247
Fixed mapping of discriminator column
...
Added fix for [DDC-3170] (http://www.doctrine-project.org/jira/browse/DDC-3170 ).
When querying a simple entity which uses single table- or class table inheritance using simple object hydration (``AbstractQuery::HYDRATE_SIMPLEOBJECT``), the mapped discriminator column was not retrieved correctly.
If the column got an alias during result set mapping other than it's actual name (e.g. ``type34`` insteaad of ``type``) than this alias wasn't reverted when retrieving the discriminator column from the SQL result set.
2014-06-17 14:51:19 +02:00
Ulf
7aa1c0a907
Create DDC3170Test.php
...
Added test for [DDC-3170] (http://www.doctrine-project.org/jira/browse/DDC-3170 )
2014-06-17 14:45:59 +02:00
Marco Pivetta
ef43b223fd
Merge pull request #1059 from iampersistent/patch-3
...
fix spacing for yaml example
2014-06-16 20:21:30 +02:00
Richard Shank
9a5fc49690
fix spacing for yaml example
2014-06-16 08:20:14 -07:00
Marco Pivetta
ca37f87c27
Merge pull request #1058 from DavidPrevot/Unicode
...
Drop Unicode character
2014-06-15 12:19:45 +02:00
David Prévot
3ff92f587f
Drop Unicode character
...
It broke the LaTeX build.
2014-06-14 23:14:42 -04:00
Andreas Flack
a5cf6417b3
Add failing test for DDC-3160
2014-06-12 17:28:13 +02:00
Marco Pivetta
5c447cfb71
Merge branch 'hotfix/build-fix'
2014-06-07 15:12:09 +02:00
Marco Pivetta
50d7975fd6
Allowing failures on hhvm-nightly, as the build chokes on composer installation for now (unrecognized console flags)
2014-06-07 15:11:51 +02:00
Marco Pivetta
32b24ba155
Fixed mismatch in expected exception message, see doctrine/doctrine2#1048
2014-06-07 14:55:59 +02:00
Marco Pivetta
3ade0cf6a5
Merge pull request #1048 from MidnightDesign/patch-1
...
Fix typo in exception message
2014-06-06 04:34:50 +02:00
Marco Pivetta
d71159c6c5
Merge pull request #1049 from deeky666/DDC-3152
...
[DDC-3152] Fix redeclaration of methods on entity generation update
2014-06-06 03:48:24 +02:00
Steve Müller
dcf8d6a86e
ignore case when checking for existing methods to avoid redeclaration on update
2014-06-05 15:58:54 +02:00
Rudolph Gottesheim
daa90bf32d
Fix typo in exception message
2014-06-04 15:59:57 +02:00
Benjamin Eberlei
6f622ab1f7
Merge branch 'master' of github.com:doctrine/doctrine2
2014-06-03 21:42:38 +02:00
Benjamin Eberlei
46ebb57b45
Fix wrong version
2014-06-03 21:41:26 +02:00
Marco Pivetta
b3d01b6036
Merge pull request #1047 from simonharris/master
...
Minor grammatical corrections
2014-06-03 17:52:45 +02:00
Simon Harris
7dac285de6
A few minor changes for English and clarity
2014-06-03 16:46:37 +01:00
Simon Harris
8b1f5d71e1
Fix minor grammatical error
2014-06-03 16:26:54 +01:00
Benjamin Eberlei
e577e77867
Cleanup 93c276d
2014-06-03 17:05:02 +02:00
Marco Pivetta
2101a8fdc6
Merge branch 'hotfix/php-version-id-check-in-metadata-prototype-instantiation'
2014-05-31 13:37:50 +02:00
Marco Pivetta
72750b05e6
Using PHP_VERSION_ID instead of version_compare to see if we're using PHP 5.4+
2014-05-31 13:37:39 +02:00
Guilherme Blanco
a851dd68fb
Merge pull request #1045 from marmotz/master
...
Fix the "Erroneous data format for unserializing" error message
2014-05-30 09:11:34 -04:00
Renaud LITTOLFF
93c276d059
Fix the "Erroneous data format for unserializing" error message
2014-05-30 10:43:11 +02:00
Marco Pivetta
5d1275e938
Merge pull request #1044 from ronanguilloux/patch-2
...
Use of ->andWhere() whithout any ->where() before is valid
2014-05-29 22:42:09 +02:00
Ronan Guilloux
526c757901
Update query-builder.rst
2014-05-29 16:36:22 +02:00
Ronan Guilloux
495fe6002d
Update query-builder.rst
...
->andWhere() can be used directly, without any ->where() before, and we can just always use ->andWhere(). This is why ->hasWhere() is useless, cf. #1043 .
2014-05-29 16:29:49 +02:00
Marco Pivetta
5ee286e7e0
Merge pull request #1041 from c960657/entity-manager-interface
...
Allow all EntityManagerInterface implementations
2014-05-28 14:40:22 +02:00
Marco Pivetta
f941264b5e
Merge pull request #1042 from bakura10/patch-1
...
Fix second level cache doc
2014-05-28 13:57:15 +02:00
Michaël Gallego
3d32bc47a7
Fix second level cache doc
2014-05-28 13:07:01 +02:00
Christian Schmidt
a7d072f525
Allow all EntityManagerInterface implementations
...
This is necessary if Doctrine\ORM\Decorator\EntityManagerDecorator is used.
2014-05-28 12:30:40 +02:00
Marco Pivetta
466808bf48
Merge pull request #1039 from iampersistent/patch-1
...
Add yml example to single table inheritance
2014-05-27 16:56:08 +02:00
Richard Shank
edaeaf48a8
Add yml example to single table inheritance
2014-05-27 07:47:07 -07:00
Michaël Perrin
b400ad52cc
Add documentation for the HIDDEN keyword in DQL
2014-05-27 11:43:15 +02:00
Marco Pivetta
20e47ae52d
Merge pull request #1037 from spiechu/patch-1
...
I can't look at those semicolons, sorry ;-)
2014-05-27 09:55:42 +02:00
Dawid Spiechowicz
9c24e0b510
I can't look at those semicolons, sorry ;-)
2014-05-27 09:37:40 +02:00
Marco Pivetta
b421d03f69
Merge pull request #1036 from albertvolkman/entity-mapper-remove-extra-space
...
Move space addition to implementation.
2014-05-22 00:15:22 +02:00
Albert Volkman
49bca5171b
Move space addition to implementation.
2014-05-21 16:27:36 -04:00
Marco Pivetta
7debf736a6
Merge pull request #1034 from hashnz/master
...
Update caching.rst
2014-05-19 22:59:06 +02:00
hashnz
43c4c80388
Update caching.rst
...
Remove documentation referencing delete by regex/prefix.
2014-05-20 08:53:41 +12:00
Michaël Gallego
140dc92e5f
Enforce Criteria
2014-05-18 12:47:59 +02:00
Marco Pivetta
04aea73a85
Merge branch 'tests/lazy-collection-tests'
...
Tests for doctrine/doctrine2@d30e3ab43c
2014-05-17 19:08:37 +02:00
Marco Pivetta
a259138180
The count in a LazyCriteriaCollection is null on initialization
2014-05-17 19:08:25 +02:00
Marco Pivetta
c68ed4c204
Verifying that the persister is used only once when matching on a lazy criteria collection
2014-05-17 19:06:16 +02:00
Marco Pivetta
d2174a893a
Verifying that count is not called on the persister when the collection is initialized
2014-05-17 18:56:42 +02:00
Marco Pivetta
546bb53ef9
Verifying that count on the lazy criteria collection is cached even with 0 count
2014-05-17 18:51:33 +02:00
Marco Pivetta
c46b63f6b4
Verifying that count on the lazy criteria collection is cached
2014-05-17 18:51:01 +02:00
Marco Pivetta
81fbb049a5
LazyCriteriaCollection test setUp
2014-05-17 18:48:25 +02:00
Marco Pivetta
7cb40ed915
Mocking up tests for the lazy-criteria-collection
2014-05-17 18:45:33 +02:00
Michaël Gallego
9d7d731090
Remove BC notice
2014-05-17 16:59:43 +02:00
Michaël Gallego
8a8c6ea3a6
Remove extra phpdoc
2014-05-17 14:53:06 +02:00
Michaël Gallego
ddfc951a0e
Remove useless docblock
2014-05-17 14:33:15 +02:00
Michaël Gallego
239b862665
Add missing typehint
2014-05-17 13:00:47 +02:00
Michaël Gallego
f52a512c59
Add UPGRADE note
2014-05-17 12:57:39 +02:00
Michaël Gallego
a04113f410
Add support for optimized contains
2014-05-17 12:54:25 +02:00
Guilherme Blanco
d6c727dcc1
Update LazyCriteriaCollection.php
...
Fixed issue where count = 0
2014-05-16 14:03:20 -04:00
Marco Pivetta
8babb77d37
Merge pull request #1031 from mnapoli/custom-functions-callback-documentation
...
Documentation for #991
2014-05-16 14:40:17 +02:00
Matthieu Napoli
5a4c558865
Fixed #991 to support non-closure callables on PHP 5.3
2014-05-16 10:49:59 +02:00
Matthieu Napoli
b16423b26b
Documentation for #991
2014-05-16 09:32:52 +02:00
Guilherme Blanco
47ca10076b
Merge pull request #991 from mnapoli/custom-functions-callback
...
Ability to define custom functions with callback instead of class name
2014-05-16 00:27:30 -04:00
Guilherme Blanco
d30e3ab43c
Added count cache when lazy collection is not yet initialized. Some cosmetic changes (primarily, there's no ELSE).
2014-05-16 04:22:11 +00:00
Michaël Gallego
92a2b01c77
Fix tests by forcing collection initialization
2014-05-15 18:37:41 +02:00
Michaël Gallego
172df22281
Fix inconsistent mapping
2014-05-15 18:22:57 +02:00
Michaël Gallego
0a6c2027f5
Update tests
2014-05-15 18:22:57 +02:00
Michaël Gallego
45e9d6ed5a
Fix test on some RDBMS
2014-05-15 18:22:57 +02:00
Michaël Gallego
11de4c2e72
Only create lazy collection for EXTRA_LAZY
2014-05-15 18:22:57 +02:00
Michaël Gallego
50832fd3bc
Add tests for PersistentCollection
2014-05-15 18:22:57 +02:00
Michaël Gallego
876643e83e
Add test for Entity Repository
2014-05-15 18:22:57 +02:00
Michaël Gallego
6cb5097ea8
Add method visibility
2014-05-15 18:22:57 +02:00
Michaël Gallego
8514ec7320
Remove useless imports
2014-05-15 18:22:57 +02:00
Michaël Gallego
3c522f4984
Reuse Doctrine Collection Lazy Collection
2014-05-15 18:22:57 +02:00
Michaël Gallego
28afb52734
Typehint to interface to support second level cache
2014-05-15 18:22:56 +02:00
Michaël Gallego
ac15b184b6
Fix tests for inheritance support
2014-05-15 18:22:56 +02:00
Michaël Gallego
632382b069
Add missing methods to the mock
2014-05-15 18:22:56 +02:00
Michaël Gallego
7551b1ad00
Update to latest cache API
2014-05-15 18:22:56 +02:00
Michaël Gallego
9813c2d5f1
Add tests
2014-05-15 18:22:56 +02:00
Michaël Gallego
0fa7b45a0e
Also add efficient count for Persistent collection
2014-05-15 18:22:56 +02:00
Michaël Gallego
9b7dce1940
Use inner collection count if initialized
2014-05-15 18:22:56 +02:00
Michaël Gallego
b556bcb16c
Remove useless dependency
2014-05-15 18:22:56 +02:00
Michaël Gallego
f1a793f2ee
Initial work for efficient counting on criteria
2014-05-15 18:22:56 +02:00
Marco Pivetta
91df8f5649
Merge branch 'hotfix/DDC-3123-test-assertion-simplification'
2014-05-15 17:37:55 +02:00
Marco Pivetta
65e55a0c49
DDC-3123 - using assertAttributeEmpty (with message) instead of explicit reflection
2014-05-15 17:37:41 +02:00
Matthieu Napoli
c7eb42b04f
Ability to define custom functions with callback + tests
2014-05-15 12:06:21 +02:00
Guilherme Blanco
5c828fc6c8
Merge pull request #1023 from coma/DDC-3027
...
[DDC-3027] Avoid duplicated mapping using Embedded in MappedSuperclass
2014-05-14 22:37:24 -04:00
Guilherme Blanco
4874070b3f
Merge branch 'feature/default-query-hints' of https://github.com/Strate/doctrine2 into Strate-default-query-hints
2014-05-15 01:15:34 +00:00
Steve Müller
c16de21172
Merge pull request #1030 from doctrine/hotfix/DDC-3123-extra-updates-cleanup
...
DDC-3123 extra updates cleanup
2014-05-15 01:07:34 +02:00
Marco Pivetta
ccc789eadd
DDC-3123 - the UoW should clear extra updates immediately
2014-05-15 00:18:50 +02:00
Marco Pivetta
9cdcba3fbc
DDC-3123 - verifying that the UoW is not clearing extra inserts
2014-05-15 00:18:22 +02:00
Marco Pivetta
08347cf4f7
Adding PHP 5.6 and HHVM-nightly to build matrix
2014-05-11 17:51:23 +02:00
Marco Pivetta
94837a0105
Merge pull request #1026 from flack/patch-5
...
Remove some redundant clauses
2014-05-03 01:43:38 +02:00
flack
5cf906d76b
Remove some redundant clauses
2014-05-02 21:52:00 +02:00
Steve Müller
7fffba80c3
Merge pull request #1025 from josemalonsom/remove-duplicate-entry-in-toc
...
Removed duplicate entry in documentation TOC.
2014-05-01 14:23:56 +02:00
Jose M. Alonso M
204b7fe854
Removed duplicate entry in documentation TOC.
2014-05-01 13:02:29 +02:00
Eduardo García Sanz
8a3def097f
[DDC-3027] Avoid duplicated mapping using Embedded in MappedSuperclass
2014-04-30 11:46:54 +02:00
Marco Pivetta
7a305475e3
The proxy factory always expects non-null identifier values
2014-04-29 13:25:17 +02:00
Marco Pivetta
27845088e3
Merge branch 'hotfix/DDC-3103-#1020-serialize-isEmbedded-in-class-metadata'
...
Close #1020
2014-04-29 13:16:02 +02:00
Marco Pivetta
677cea4748
DDC-3103 - minor CS fixes/adjustments
2014-04-29 13:12:17 +02:00
Marco Jantke
f065a5c8b9
fixed bug
2014-04-29 09:30:37 +02:00
Marco Jantke
cf84183c18
created test case to reproduce error
2014-04-29 09:30:10 +02:00
Guilherme Blanco
48172f3a53
Readability update to hydrators.
2014-04-29 05:05:38 +00:00
Guilherme Blanco
9cd16ec56a
More optimizations around hydrators. Pretty much same performance, just better memory footprint (-0.25MB).
2014-04-28 13:47:57 +00:00
Guilherme Blanco
be94eb9d1f
Made ClassMetadata to be reused during gatherRowData() and also during hydrateRow() to share same fetches instead of recalculating all info again. Performance improvement after 100x runs comparison is around 4%.
2014-04-28 02:38:51 +00:00
Guilherme Blanco
35c8cd7f23
Added type conversion to meta column in case a type is specified (such as a foreign key or discriminator column).
2014-04-25 05:22:33 +00:00
Guilherme Blanco
21437bb276
Heavily simplified code on simple object hydrator. Code cleanup on column information cache; by reference cache variable is no longer needed and protected variable is used in a standardized way everywhere.
2014-04-25 03:41:14 +00:00
Guilherme Blanco
e8e86205f5
Merge pull request #1018 from chandon/master
...
DBAL-878 Wrong mapping type
2014-04-24 20:52:27 -04:00
Cédric Chandon
9ba31a394a
[DBAL-878] Wrong mapping type
...
the type should be the mapping type, and not the name of the type. This
does the difference for simple_array, as the result should be
simple_array and not simplearray
2014-04-25 01:59:15 +02:00
Guilherme Blanco
f7de00b401
Finalized fix for scalars and newObjects.
2014-04-24 05:21:24 +00:00
Guilherme Blanco
9692fc8c5b
Fixed issue if aliases were specific names, you would either get completely misleading results (dql alias: scalars) or a fatal error (dql alias: newObjects).
2014-04-24 04:47:13 +00:00
Guilherme Blanco
a3febd79de
Abstract cache information of field result for hydrators.
2014-04-23 18:50:29 +00:00
Guilherme Blanco
a4dac7a292
Highlighted intention of converting scalar types during single scalar or scalar hydration, but leaving it commented and added a note about the BC reason why we cannot do that for 2.X series.
2014-04-23 18:04:06 +00:00
Marco Pivetta
9ec54b8fed
Merge pull request #1015 from EvanDotPro/docs/expressionbuilder-contains
...
Add ExpressionBuilder::contains() to docs
2014-04-23 15:58:06 +02:00
Evan Coury
d2c2067aaf
Add ExpressionBuilder::contains() to docs
2014-04-23 06:54:03 -07:00
Guilherme Blanco
9ebce31a46
Made AbstractHydrator::gatherRowData() more understandable without breaking functionality.
2014-04-23 06:08:18 +00:00
Guilherme Blanco
29de3e00ff
Added support for NEW operator when using ArrayHydration if user desires to benefit from this funcionality.
2014-04-23 05:10:23 +00:00
Guilherme Blanco
63d21ca4b2
DDC-3085 Verify ResultVariable works in combination with NullComparisonExpression wihle in HAVING clause.
2014-04-21 04:01:32 +00:00
Guilherme Blanco
4185a9ce4b
Merge pull request #999 from doctrine/hotfix/DDC-3065-null-value-in-in-criteria-support
...
DDC-3065 null value in in criteria support
2014-04-20 23:30:14 -04:00
Guilherme Blanco
1e90fd1164
Merge pull request #1014 from bakura10/patch-1
...
Update second level cache doc
2014-04-20 18:24:01 -04:00
Michaël Gallego
9b847f1a04
Update second-level-cache.rst
2014-04-20 23:52:06 +02:00
Guilherme Blanco
6a8ee87268
Made DQL and EBNF in sync.
2014-04-20 20:27:57 +00:00
Guilherme Blanco
a3f95d919b
DDC-3075 Added support for subqueries in NEW operator.
2014-04-20 14:40:51 +00:00
Guilherme Blanco
38b6838386
DDC-2575 Fixed issue with associations when parent is not yet loaded, but child is being created and no link happens.
2014-04-18 05:21:27 +00:00
Guilherme Blanco
df806977c6
Updated fix for HHVM.
2014-04-18 03:05:41 +00:00
Guilherme Blanco
9441e063aa
Updated XML Exporter to deal with some HHVM weirdness.
2014-04-18 03:04:04 +00:00
Guilherme Blanco
10a0daf620
DDC-3068 DDC-3069 EntityManager::find accept array of object as id.
2014-04-18 02:03:47 +00:00
Fabio B. Silva
54d9f05e39
Merge pull request #1009 from doctrine/feature/hhvm-tests
...
HHVM compatibility
2014-04-17 16:21:06 -04:00
Marco Pivetta
e1259098f5
Fixed whitespace around imported classes
2014-04-17 15:37:24 -04:00
Marco Pivetta
9ab6ef723a
Removing too eager cache tests
2014-04-17 15:37:24 -04:00
Marco Pivetta
b4933d76c7
HHVM tests are not allowed to fail anymore
2014-04-17 15:37:24 -04:00
Marco Pivetta
abb4671bfc
Removing usage of memcache cache in tests (HHVM gets stuck on them on local setups)
2014-04-17 15:37:23 -04:00
Marco Pivetta
e263426cdf
Removing eager assertion on error suppression when generating schema via tools
2014-04-17 15:37:23 -04:00
Guilherme Blanco
6af3236ba6
Merge pull request #1012 from FabioBatSilva/DDC-3078-slc-cache-interface-ctor-removal
...
Ddc 3078 slc cache interface ctor removal
2014-04-17 15:34:36 -04:00
Guilherme Blanco
318f5032db
Missing documentation update.
2014-04-17 19:31:06 +00:00
Guilherme Blanco
be1cc14a9c
DDC-2890 Fixed pagination with association order by.
2014-04-17 19:29:18 +00:00
fabios
1dc3396ad4
DDC-3078 - Use CacheFactory instead of cache instantiator
2014-04-17 15:20:31 -04:00
Marco Pivetta
fa1cc9269c
DDC-3078 - removing unused imports
2014-04-17 15:16:59 -04:00
Marco Pivetta
d57d4b71f9
DDC-3078 - default cache instantiator class name was misstyped
2014-04-17 15:16:59 -04:00
Marco Pivetta
48e227167e
DDC-3078 - cache instantiator related exceptions are not needed anymore
2014-04-17 15:16:59 -04:00
Marco Pivetta
df6a411365
DDC-3078 - cache instantiator is used in the ORM instead of callables
2014-04-17 15:16:59 -04:00
Marco Pivetta
4b388b2ce8
DDC-3078 - coverage for the default cache instantiator
2014-04-17 15:16:58 -04:00
Marco Pivetta
a790639167
DDC-3078 - providing a default cache instantiator implementation
2014-04-17 15:16:58 -04:00
Marco Pivetta
6931cd08c4
DDC-3078 - using an explicit CacheInstantiator interface to replace callable cache instantiators
2014-04-17 15:16:58 -04:00
Marco Pivetta
d7f87cdd36
DDC-3078 - removing unused cache class name invalidity exception methods
2014-04-17 15:16:58 -04:00
Marco Pivetta
9b2ee88683
DDC-3078 - removing cache class name setter/getter from cache configuration API
2014-04-17 15:16:58 -04:00
Marco Pivetta
87a907f9dd
DDC-3078 - switching cache initialization to use cache instantiator from config
2014-04-17 15:16:57 -04:00
Marco Pivetta
cd0f94dd6c
DDC-3078 - removing tests for cache class setter/getter on cache configuration
2014-04-17 15:16:57 -04:00
Marco Pivetta
68f489ecbb
DDC-3078 - cache configuration tests for the newly introduced API for cache instantiators
2014-04-17 15:16:56 -04:00
Marco Pivetta
e5f79d1f73
DDC-3078 - adding API for cache instantiation to the configuration object
2014-04-17 15:16:56 -04:00
Marco Pivetta
1b5eb55ed9
DDC-3078 - adding exception methods for invalid cache instantiator
2014-04-17 15:16:56 -04:00
Marco Pivetta
04b52149ab
DDC-3078 - constructor should never be interfaced
2014-04-17 15:16:56 -04:00
Guilherme Blanco
841bdd5ca5
DDC-2827 Added support for AggregateExpressions in NullComparisonExpression.
2014-04-17 04:39:26 +00:00
Guilherme Blanco
ceada41b83
DDC-2934 Added support for function declarations in order by.
2014-04-17 04:15:35 +00:00
Guilherme Blanco
54898eca60
Added index by consideration when eagerly loading to-many associations.
2014-04-17 03:53:21 +00:00
Guilherme Blanco
13afde0140
Updated phpunit dependency.
2014-04-17 01:22:17 +00:00
Guilherme Blanco
f5e6044cf5
Provided more decriptive explanation when single scalar hydrator is used and it returns multiple columns.
2014-04-17 01:09:33 +00:00
Guilherme Blanco
1488a509b2
DDC-2937 More informative response when using single scalar hydrator when it returns single row but multiple columns.
2014-04-16 05:44:54 +00:00
Guilherme Blanco
6e9b15a48f
Merge pull request #951 from md2perpe/MoreInformationalEntityNotFoundException
...
More informational entity not found exception
2014-04-16 01:40:02 -04:00
Guilherme Blanco
b28fa9a05a
DDC-1632 Optimized query count for one-to-many associations with fetch eager.
2014-04-16 05:36:31 +00:00
Guilherme Blanco
4029dc2ea8
Merge pull request #988 from holtkamp/DDC-3047-Exporter-association-fetch-modes
...
Exporter support for association fetch modes
2014-04-16 00:52:51 -04:00
Guilherme Blanco
1cd0b26a40
DDC-3068 EntityManager clear() calls now follow cascade detach configuration.
2014-04-16 04:47:57 +00:00
Guilherme Blanco
5ce6dabe9b
Fixes DDC-2984. Made DDC-742 more resilient to recurring failures.
2014-04-16 04:20:18 +00:00
Marco Pivetta
68d477a4c6
Merge pull request #1011 from md2perpe/patch-2
...
Single quotes can't nest
2014-04-15 14:25:24 +02:00
Per Persson
38911076ad
Single quotes can't nest
...
I decided to use "... '...' ...", but perhaps you prefer '... \'...\' ...'?
2014-04-15 13:56:18 +02:00
Guilherme Blanco
2da74e5147
Merge pull request #1006 from Trainmaster/master
...
Handling invalid discriminator values
2014-04-15 00:07:03 -04:00
Marco Pivetta
3a1e24e680
Merge branch 'feature/#973-index-flags-in-mappings'
...
Close #973
2014-04-14 01:22:02 +02:00
Marco Pivetta
a87d3e080e
Minor CS fixes on top of #973
2014-04-14 01:21:23 +02:00
Adrian Olek
eccd8f85bc
cs fixes
2014-04-14 01:21:23 +02:00
Adrian Olek
72bb16173a
Added Comment entity mapping for StaticPHPDriver test
2014-04-14 01:21:23 +02:00
Adrian Olek
32ed32cf56
Added index flags test
2014-04-14 01:21:23 +02:00
Adrian Olek
b3a2988d2c
CS fixes
2014-04-14 01:21:23 +02:00
Adrian Olek
cc2fb1a070
Added index flags support in annotation, xml & yaml mapping drivers.
2014-04-14 01:21:23 +02:00
Benjamin Eberlei
da24133306
Merge pull request #980 from adrianolek/convert-mapping-options
...
Added options attribute export to Annotation, Xml & Yaml exporters.
2014-04-13 23:38:30 +02:00
Marco Pivetta
8b6b1c68a0
Merge pull request #1010 from BenMorel/validation-message
...
Fixed validation message
2014-04-12 01:49:16 +02:00
Benjamin Morel
1b4eafc873
Fixed validation message
2014-04-11 22:27:51 +00:00
Guilherme Blanco
ac956f2b8c
Merge pull request #1007 from umpirsky/patch-1
...
Minor dockblock change
2014-04-09 07:55:12 -04:00
Saša Stamenković
dc10bb69f6
Minor dockblock change
2014-04-09 13:53:56 +02:00
Frank Liepert
8740d54210
[DDC-3076] Add/Improve tests
2014-04-09 11:31:16 +02:00
Frank Liepert
df020e08a0
[DDC-3076] Fix ObjectHydrator
2014-04-09 11:30:11 +02:00
Frank Liepert
a054b59550
[DDC-3076] Add test
2014-04-09 10:19:48 +02:00
Frank
d1c722c1d0
Fix: handle invalid discriminator value
2014-04-09 01:55:54 +02:00
Frank
f7b95c1aa5
Add: invalidDiscriminatorValue method
2014-04-09 01:55:49 +02:00
Guilherme Blanco
73e5bbecbe
Merge pull request #1004 from giosh94mhz/removed_useless_testinit
...
Removed all useless occurrence of require_once TestInit.php
2014-04-07 08:38:39 -05:00
Giorgio Premi
6cb3fa8fb7
Removed all useless occurrence of require_once TestInit.php
2014-04-07 14:43:25 +02:00
Marco Pivetta
4d950a9e10
Merge pull request #1002 from BenMorel/propertyfix
...
Fixed wrongly initialized property.
2014-04-04 22:42:43 +02:00
Benjamin Morel
b3ec4df8ce
Fixed wrongly initialized property.
2014-04-04 20:05:16 +00:00
Guilherme Blanco
bfb66f1d85
Merge pull request #985 from doctrine/hotfix/DDC-3042-sql-alias-collisions-in-dql
...
[DDC-3042] SQL Alias collisions in DQL
2014-04-03 20:41:36 -05:00
Marco Pivetta
f80fceda0e
DDC-3042 - changing SQL generation tests to respect changes in naming strategy
2014-04-04 03:05:48 +02:00
Marco Pivetta
e6bf096583
Prefixing alias counter with _ to fix DDC-3042 and prevent collisions
2014-04-04 03:05:48 +02:00
Marco Pivetta
11b3065fd1
Verifying DDC-3042 - duplicate aliases in DQL SQL generation
2014-04-04 03:05:48 +02:00
Marco Pivetta
3680bb7ccc
Stubbing out test for DDC-3042 - DQL aliases cause collisions when selecting from tables with similar properties
2014-04-04 03:05:48 +02:00
Marco Pivetta
733102b4a1
DDC-3065 - applying hotfix that allows NULL in IN() criteria
2014-04-03 17:36:56 +02:00
Marco Pivetta
a8b96803a4
DDC-3065 - persister tests for criteria containing NULL values in IN() conditions
2014-04-03 17:36:56 +02:00
Marco Pivetta
eb6498544f
DDC-3065 - splitting tests and checking multiple values support
2014-04-03 17:36:56 +02:00
Marco Pivetta
f54d6157f4
DDC-3065 - hardening test - should support multiple values in IN(), also NULL ones
2014-04-03 17:36:56 +02:00
Marco Pivetta
f2f571e4ab
DDC-3065 - failing test - IN()-alike criteria should support NULL search values
2014-04-03 17:36:56 +02:00
Menno Holtkamp
26307a0cee
Added 'fetch="EXTRA_LAZY"' to many-to-many association
2014-03-31 11:55:04 +02:00
Menno Holtkamp
8d0a5958eb
Code-style improvement
2014-03-31 11:02:36 +02:00
Menno Holtkamp
59842e9bc6
Code-style improvement
...
Also to trigger Travis CI
2014-03-31 11:00:50 +02:00
Menno Holtkamp
3044009550
Added 'fetch="EAGER"' to one-to-one association
2014-03-30 16:01:46 +02:00
Marco Pivetta
da96f4938a
Merge pull request #994 from ThomasLomas/patch-1
...
Update EntityGenerator comment
2014-03-29 02:51:00 +01:00
Thomas Lomas
7d9630786b
Update EntityGenerator comment
...
fieldVisibility was referred to as a boolean, where it is actually a string.
2014-03-29 01:49:12 +00:00
Marco Pivetta
8f688509c8
Merge pull request #992 from BenMorel/docfix
...
Fixed typos
2014-03-28 14:05:20 +01:00
Benjamin Morel
b3ec87ab09
Fixed typos
2014-03-28 12:54:49 +00:00
Marco Pivetta
ca19db34d2
Merge pull request #990 from Remper/patch-1
...
Typo in documentation
2014-03-27 13:51:28 +01:00
Nechaev Yaroslav
46b16a5e10
Update dql-doctrine-query-language.rst
2014-03-27 15:49:04 +03:00
Nechaev Yaroslav
b145ebf955
Typo in documentation
...
This method from AbstractQuery accepts constants from ClassMetadata rather than string
2014-03-27 15:45:52 +03:00
Menno Holtkamp
798075931a
Exporter support for association fetch modes
2014-03-26 01:00:17 +01:00
Steve Müller
048c56bdb0
Merge pull request #987 from baileylo/patch-1
...
Fixes typo in dql-doctrine-query-language.rst
2014-03-25 19:11:28 +01:00
Logan Bailey
263d9f30f2
Fixes typo in dql-doctrine-query-language.rst
...
Changes "If you a query" to "If you have a query"
2014-03-25 11:10:43 -07:00
Benjamin Eberlei
927d69b61a
Merge pull request #957 from thealjey/master
...
makes doctrine less dependent upon the symfony yaml component
2014-03-23 15:41:27 +01:00
Benjamin Eberlei
8addb5ffa8
Merge pull request #960 from drealecs/fixes-EntityManagerInterface
...
allow passing EntityManagerInterface when creating a HelperSet
2014-03-23 15:36:38 +01:00
Benjamin Eberlei
5335b2a2ad
Merge pull request #955 from goatherd/patch-1
...
iteration risk note
2014-03-23 15:35:53 +01:00
Benjamin Eberlei
71fc425902
Merge pull request #963 from mdemo/master
...
SQLFilter -- allows to check if a parameter was set
2014-03-23 15:33:14 +01:00
Benjamin Eberlei
a03c8da683
Merge pull request #962 from netiul/master
...
Stop executeDeletions when there is nothing to to delete anymore
2014-03-23 15:32:28 +01:00
Benjamin Eberlei
dd8075ea95
Merge branch 'DDC-3018'
2014-03-23 15:16:15 +01:00
Benjamin Eberlei
2aea3036b6
[DDC-3018] Fix string literals in new operator.
2014-03-23 15:16:09 +01:00
Adrian Olek
0caeb4edbf
Initialize table options annotation, fixed condition in AnnotationDriver
2014-03-23 14:37:55 +01:00
Benjamin Eberlei
24d4fd17f3
Merge branch 'DDC-2996'
2014-03-23 13:19:04 +01:00
Benjamin Eberlei
d473824279
[DDC-2996] Fix bug in UnitOfWork#recomputeSingleEntityChangeSet
...
When calling UnitOfWork#recomputeSingleEntityChangeSet on an entity
that didn't have a changeset before, the computation was ignored.
This method however is suggested to be used in "onFlush" and "preFlush"
events in the documentation.
Also fix a bug where recomputeSingleEntityChangeSet was used
before calculating a real changeset for an object.
2014-03-23 13:16:33 +01:00
Benjamin Eberlei
e415da7f47
Merge branch 'DDC-3033'
2014-03-23 12:38:06 +01:00
Benjamin Eberlei
ecc2857e2d
[DDC-3033] Clarify restrictions in events.
2014-03-23 12:37:56 +01:00
Benjamin Eberlei
396337bd0d
[DDC-3033] Fix bug in UnitOfWork#recomputeSingleEntityChangeSet.
...
The fix for DDC-2624 had a side effect on recomputation of
changesets in preUpdate events. The method wasn't adjusted
to the changes in its sister method computeChangeSet() and
had wrong assumptions about the computation.
Especially:
1. Collections have to be skipped
2. Comparison was changed to strict equality only.
2014-03-23 12:35:54 +01:00
Benjamin Eberlei
fb2d2bce45
Merge pull request #984 from holtkamp/patch-1
...
Use boolean values for 'unique' attribute
2014-03-23 10:16:04 +01:00
Benjamin Eberlei
0621b5a161
Merge branch 'DDC-3045'
2014-03-23 09:58:38 +01:00
Benjamin Eberlei
c8836a008d
[DDC-3045] Check that EntityRepository APIs prevent SQL injection through field names. Improve EntityManager#find() error handling when invalid identifier fields are passed.
2014-03-23 09:58:31 +01:00
Menno Holtkamp
6e651b13c9
Added test to ensure boolean metadata is properly exported/serialized to XML
2014-03-20 21:29:52 +01:00
Guilherme Blanco
fdb9f90848
Merge pull request #983 from holtkamp/patch-new-dql-in-expression-builder
...
Added MEMBER OF and INSTANCE OF to ExpressionBuilder
2014-03-20 08:28:32 -05:00
Menno Holtkamp
ef4e73f987
Use boolean values for 'unique' attribute
...
As defined in: https://github.com/doctrine/doctrine2/blob/master/doctrine-mapping.xsd#L294
Same as 'nullable' attribute.
It was being exported as a "1" for TRUE and "0" for false
2014-03-20 11:08:29 +01:00
Menno Holtkamp
262e465e39
Processed code-review feedback
2014-03-20 09:02:39 +01:00
Menno Holtkamp
56e879b7aa
Removed double linebreaks
2014-03-19 13:03:26 +01:00
Menno Holtkamp
400f420925
Added MEMBER OF and INSTANCE OF helpers to ExpressionBuilder
2014-03-19 13:00:45 +01:00
Thomas Lallement
6bbc07ddbf
Update DDC3033Test.php
2014-03-18 22:10:15 +01:00
Thomas Lallement
7bf2bcb017
Update DDC3033Test.php
2014-03-18 15:04:48 +01:00
Thomas Lallement
263822fd19
Failing Test (since commit 53a5a48aed)
...
Hi,
It seems to be a regression since the commit 53a5a48aed
Doctrine\ORM\PersistentCollection can be populated in $changeSet if you set a PreUpdate and PostUpdate event.
Original issue: http://www.doctrine-project.org/jira/browse/DDC-3033
2014-03-18 15:00:43 +01:00
Marco Pivetta
9b4ae6d556
Removing note on m2m association filtering as of #885
2014-03-16 17:41:19 +01:00
Guilherme Blanco
383604d4b8
Merge pull request #978 from AntonStoeckl/embedded-empty-prefix
...
[DDC-2987] Enable empty prefixes for inlined embeddable
2014-03-16 11:35:25 -05:00
Guilherme Blanco
44c1dae1b9
Merge pull request #885 from bakura10/criteria-many-to-many
...
Add support for ManyToMany Criteria
2014-03-16 11:33:10 -05:00
Adrian Olek
49587776fa
Renamed _exportOptions method
2014-03-16 17:31:15 +01:00
Adrian Olek
e403bf207c
cs fix
2014-03-16 16:56:46 +01:00
Adrian Olek
553883bdd1
Added options attribute export to Annotation, Xml & Yaml
...
exporters.
2014-03-16 16:50:41 +01:00
Anton Stoeckl
83ef47c8d0
This fixes ticket DDC-3028
...
Enables columnPrefix to be "false" so no prefix is added.
Changed the structure a bit (to if/else) to be more readable with the additional condition.
2014-03-14 12:34:22 +01:00
Anton Stoeckl
871dc5d186
Test are for fix of ticket DDC-3028
...
Added 3 tests that check regression for:
- columnPrefix is empty
- columnPrefix is a string
- columnPrefix is false
Added some small entity / embeddable classes to support the test cases.
2014-03-14 12:32:49 +01:00
Anton Stoeckl
cd2043915c
columnPrefix must support string and boolean, so changing to mixed
2014-03-14 12:29:01 +01:00
Anton Stöckl
fa79de6ea4
Enable empty prefixes for inlined embeddable
...
This fixes http://www.doctrine-project.org/jira/browse/DDC-2987
This makes it possible to map a field from an embeddable to a database field with the same name, without any prefix added.
Example:
- an embeddable object "Id" with a property "id"
- per default this would map inline to id_id
- supplying null or '' as columnPrefix does not work due to the ! empty() check
- with my little change, if columnPrefix : false is supplied in the mapping config this will now map to a db column "id"
To build Ids as ValueObjects is a very common approach in DDD, so ihmo this is a must have.
2014-03-13 16:47:22 +01:00
Marco Pivetta
b30b1a5999
Merge pull request #977 from mvrhov/patch-2
...
Fix wrong annotation
2014-03-11 14:52:49 +01:00
Miha Vrhovnik
d888d7d1c0
Fix wrong annotation
...
Without above fix I'm getting
"[Semantical Error] The annotation "@array" in method Doctrine\ORM\Mapping\ClassMetadataInfo::mapEmbedded() was never imported. Did you maybe forget to add a "use" statement for this annotation?"
2014-03-11 14:44:42 +01:00
Marco Pivetta
02daf0049a
Merge branch 'docs/DDC-3020'
2014-03-11 11:30:18 +01:00
Marco Pivetta
fea200043e
Adding note about DDC-3020 - external XML entities may or may not work
2014-03-11 11:30:08 +01:00
Marco Pivetta
87505c8716
Merge pull request #975 from tkleinhakisa/doc-automatic-discriminator-map
...
Added info about automatic discriminator map
2014-03-11 10:08:58 +01:00
Klein Thomas
832127a0d6
Added info about automatic discriminator map
...
see https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Mapping/ClassMetadataFactory.php#L257
2014-03-11 09:54:46 +01:00
Guilherme Blanco
f197a9c9f1
Merge pull request #974 from FabioBatSilva/resolve-association-entry
...
[SLC] Resolve association cache entry
2014-03-06 22:38:26 -05:00
Fabio B. Silva
e9ec0a24da
[SLC] resolve association cache entry
2014-03-06 20:44:59 -05:00
Fabio B. Silva
ecf242f6d4
Merge pull request #971 from FabioBatSilva/slc-query-assoc-proxy
...
[SLC] Fix query association proxy
2014-03-06 15:43:58 -05:00
Marco Pivetta
8d4821b4dc
Merge pull request #972 from hallabro/patch-1
...
Capitalize @GeneratedValue (annotations-reference.rst)
2014-03-05 11:03:30 +01:00
Marco Pivetta
7843eed8bc
Merge pull request #969 from aitboudad/patch-2
...
[Doc] added note about Criteria limits on PersistentCollection
2014-03-05 10:59:10 +01:00
Robin Hallabro
a395921fdc
Capitalize @GeneratedValue (annotations-reference.rst)
2014-03-05 10:57:31 +01:00
Fabio B. Silva
cbdd8bc041
[SLC] Fix query association proxy
2014-03-05 04:10:07 -05:00
Abdellatif AitBoudad
5f429a5418
[Doc] added note Criteria limits.
2014-03-04 21:36:07 +00:00
Guilherme Blanco
15432fc55f
Merge pull request #967 from FabioBatSilva/slc-query-builder
...
[SLC] Add query builder options
2014-03-03 21:10:48 -05:00
fabios
6e64cc101a
[SLC] Add query builder options
2014-03-03 15:28:35 -05:00
Benjamin Eberlei
63d849b6f0
Merge pull request #966 from FabioBatSilva/simplify-build
...
Simplify build matrix
2014-03-02 12:36:50 +01:00
Fabio B. Silva
a91e05db9e
Simplify build matrix
2014-03-01 17:13:28 -05:00
Benjamin Eberlei
a522aa0a81
Merge pull request #965 from FabioBatSilva/slc-criteria
...
[SLC] Add support for criteria
2014-03-01 12:47:57 +01:00
Benjamin Eberlei
f0a6eb8723
Merge pull request #964 from FabioBatSilva/DDC-2943
...
[SLC][DDC-2943] Disable slc for pagination queries
2014-03-01 12:46:52 +01:00
Fabio B. Silva
8c2aef3f14
[DDC-2943] Disable slc for pagination queries
2014-03-01 01:15:09 -05:00
Fabio B. Silva
f4c63f8238
[SLC] Support criteria
2014-03-01 00:59:34 -05:00
Miro Demovic
1921c2f74a
Allow if parameter exists in SQLFilter
2014-02-26 08:55:47 +01:00
Zacharias Luiten
8a168bb2ce
stop executing executeDeletions when there is nothing to to delete anymore
2014-02-25 16:02:02 +01:00
Alexandru Patranescu
1fe6dbc1f2
allow passing EntityManagerInterface when creating a HelperSet
2014-02-23 20:01:14 +02:00
Benjamin Eberlei
f5897d4b0b
Merge branch 'master' of github.com:doctrine/doctrine2
2014-02-21 16:14:57 +01:00
Benjamin Eberlei
51e5db86b7
Add SECURITY.md and a chapter on security assumptions in Doctrine ORM.
2014-02-21 16:12:32 +01:00
Eugene Kuzmenko
c06201303d
makes doctrine less dependent upon the symfony yamp component
2014-02-20 09:28:44 +00:00
Marco Pivetta
dfe7a68053
Removing notice about public properties support (included since 2.4)
...
see doctrine/doctrine2#406
2014-02-19 22:02:07 +01:00
Marco Pivetta
5a2497d482
Merge pull request #935 from da-eto-ya/remove_public_validation
...
Remove incorrect (outdated) validation for public fields in SchemaValidator
2014-02-19 21:21:59 +01:00
Marco Pivetta
0797feeb0f
Travis must use --prefer-source because of Github API limitations
2014-02-18 10:28:13 +01:00
Michaël Gallego
b550d44cb9
CS fix
2014-02-18 10:26:26 +01:00
Michaël Gallego
a45ecb5733
Fix bug with hydrators
2014-02-18 10:26:25 +01:00
Michaël Gallego
6cbd643d4b
Add test
2014-02-18 10:26:25 +01:00
Michaël Gallego
f03f991a25
Functional test
2014-02-18 10:26:25 +01:00
Michaël Gallego
0d5de64c0f
Fix CS
2014-02-18 10:26:25 +01:00
Michaël Gallego
a55f2c48ca
Fix test
2014-02-18 10:26:25 +01:00
Michaël Gallego
e5ba28676d
fallback to persister count
2014-02-18 10:26:25 +01:00
Michaël Gallego
fbbe922cb6
Fix tests
2014-02-18 10:26:25 +01:00
Michaël Gallego
c69b7562ab
Remove useless exception
2014-02-18 10:26:25 +01:00
Michaël Gallego
bb1f71f1f9
Fix docblock
2014-02-18 10:26:25 +01:00
Michaël Gallego
be39afa2f4
Add method to interface
2014-02-18 10:26:24 +01:00
Michaël Gallego
9385a600cf
Fix wrong logic
2014-02-18 10:26:24 +01:00
Michaël Gallego
738cc250f8
Revert docblock
2014-02-18 10:26:24 +01:00
Michaël Gallego
07654ddd3f
Revert tab changes
2014-02-18 10:26:24 +01:00
Michaël Gallego
160b07d1e3
Rebase to master
2014-02-18 10:26:24 +01:00
Guilherme Blanco
0dbd742588
Merge pull request #886 from Strate/bugfix/join-with-condition-placement-fix
...
[DDC-1256] Fix applying ON/WITH conditions to first join in Class Table Inheritance
2014-02-17 12:12:05 -05:00
Maik Penz
0677423d14
iteration risk note
...
> instead of loading the whole result into memory at once
is not the full truth.
There is a certain risk of processes getting killed due to memory allocation with large iteration. This is caused by result buffering of the client not being visible to PHP and thus not from 'within' the process.
It is not certain that this occurs with all database clients but seems rather likely to at this point.
This is only a proposal for discussion as I am not certain how to best add the information or if to add it at all (was it obvious before?). Personally I got confused by the existing description and didn't notice the memory implication until further investigation using `top` reported the process to run at 3+GB memory while PHP reported 400M real peak usage.
2014-02-17 10:33:10 +01:00
Marco Pivetta
4382304e77
Merge pull request #953 from goetas/patch-1
...
Update doc with latest news about extra lazy assoc
2014-02-12 23:56:00 +01:00
Asmir Mustafic
e27d963784
Update extra-lazy-associations.rst
2014-02-12 23:42:52 +01:00
Asmir Mustafic
1f0d4197a9
Update doc with latest news about extra lazy assoc
2014-02-12 23:42:13 +01:00
Fabio B. Silva
a3b4104612
Merge pull request #950 from goetas/patch-1
...
[SLC] Cache empty collections
2014-02-12 04:26:27 -05:00
Asmir Mustafic
94896ce552
Typo fix on many-to-many assocaition cascade test
2014-02-12 08:18:34 +01:00
Asmir Mustafic
8cdbcf1263
Merge remote-tracking branch 'origin/master' into patch-1
2014-02-12 05:15:00 -02:00
Per Persson
3543ccea7f
Pass class name to constructor.
2014-02-11 23:48:31 +01:00
Per Persson
7ef1063007
Pass class name to constructor.
2014-02-11 23:44:24 +01:00
Per Persson
4b061a0e4c
Add class name as argument.
2014-02-11 23:40:38 +01:00
Marco Pivetta
9b0d7dde91
Merge pull request #952 from simshaun/patch-1
...
Add DB-level onDelete CASCADE example
2014-02-11 23:24:38 +01:00
Shaun
57ac3bd4be
Add DB-level onDelete CASCADE example
...
This adds `onDelete: CASCADE` to the `address` 1-1 relationship just to show how you would map a db-level cascade.
2014-02-11 17:23:19 -05:00
Asmir Mustafic
4a6d6e34f8
Test empty collections second level cache
2014-02-11 17:39:16 +01:00
Asmir Mustafic
a5fbb20fbb
Can cache many to many empty relations
2014-02-11 15:08:49 +01:00
Asmir Mustafic
1c94c16234
Can cache empty collections
...
I should be able to cache an "empty" collection.
I have a some objects, where 90% of these have on-to-many relations with zero associated elements.
This causes doctrine to run a query each time, instead of cache it as empty relation.
2014-02-11 14:59:31 +01:00
Marco Pivetta
e8f51acdb2
Merge pull request #947 from BenMorel/unused-imports
...
Cleaned up further unused imports.
2014-02-10 05:48:56 +01:00
Strate
324f200f1b
Merge branch 'master' into bugfix/join-with-condition-placement-fix
2014-02-10 08:22:11 +04:00
Benjamin Morel
08f6291350
Cleaned up further unused imports.
2014-02-09 23:45:22 +00:00
Marco Pivetta
c4b1d4fa28
Merge pull request #946 from BenMorel/unused-imports
...
Cleaned up unused imports
2014-02-09 23:33:26 +01:00
Benjamin Morel
412e4ab9da
Cleaned up unused imports
2014-02-09 22:12:51 +00:00
Steve Müller
6cd0861fa3
Merge pull request #945 from raziel057/patch-1
...
Fix CS
2014-02-09 16:54:22 +01:00
Thomas Lallement
2a77a739dc
Fix CS
2014-02-09 16:37:32 +01:00
Benjamin Eberlei
4c4e4f6d3d
Merge pull request #939 from doctrine/DDC-1985
...
[DDC-2939] Order Preservation
2014-02-09 15:43:57 +01:00
Benjamin Eberlei
288953aa6d
Merge pull request #944 from WouterJ/patch-1
...
Fixed InputOption modes
2014-02-09 15:43:14 +01:00
Wouter J
d7b917aa49
Fixed InputOption modes
2014-02-09 15:10:00 +01:00
Benjamin Eberlei
53a5a48aed
[DDC-2624] Fix bug when persistent collection is cloned and used in a new entity.
2014-02-09 14:27:42 +01:00
Benjamin Eberlei
3c2b626102
Merge pull request #943 from jankramer/handle-embeddables-in-embeddables
...
Validate embeddables do not contain other embeddables.
2014-02-09 11:06:43 +01:00
Jan Kramer
43e37d4f2f
Throw exception on embeddables in embeddables.
2014-02-09 10:09:28 +01:00
Marco Pivetta
496fa85641
Merge pull request #940 from WouterJ/patch-1
...
Fixed typo & horizontal scrolling
2014-02-08 20:22:39 +01:00
Wouter J
24feae84cd
Fixed typo & horizontal scrolling
2014-02-08 20:19:54 +01:00
Benjamin Eberlei
d31f7ebf57
[DDC-1985] Fix ordering preservation in SQL limit subquery output walker.
2014-02-08 17:01:55 +01:00
Benjamin Eberlei
1a08b52ab4
Cleanup test output.
2014-02-08 17:00:21 +01:00
Benjamin Eberlei
35511db4da
Merge pull request #898 from USvER/patch-1
...
Added note to STI
2014-02-08 16:34:30 +01:00
Benjamin Eberlei
50ba19d91b
Merge pull request #937 from goetas/contains-key
...
Extra-lazy for containsKey on collections
2014-02-08 16:28:44 +01:00
Benjamin Eberlei
8a0901c92b
Merge pull request #835 from schmittjoh/ValueObjects
...
Value objects (Based on #634 )
2014-02-08 16:24:47 +01:00
Benjamin Eberlei
8e3f4561c0
Merge pull request #858 from schmittjoh/rsmBuilder
...
lifts an unnecessary restriction on ResultSetMappingBuilder
2014-02-08 16:23:18 +01:00
Benjamin Eberlei
058e024f0e
Merge pull request #902 from gwagner/master
...
Fix Lifecycle Callbacks
2014-02-08 16:01:13 +01:00
Benjamin Eberlei
31a2870c3f
Merge pull request #912 from BenMorel/collection-count
...
Avoid PersistentCollection::isEmpty() to fully load the collection.
2014-02-08 16:00:10 +01:00
Benjamin Eberlei
960fbfc110
Merge pull request #908 from FabioBatSilva/DDC-2862
...
[DDC-2862][SLC] Fix lazy association load
2014-02-08 15:55:20 +01:00
Benjamin Eberlei
b76e95cbb9
Merge pull request #917 from doctrine/hotfix/DDC-2931
...
DDC-2931 - one-to-one self-referencing association broken by DCOM-96
2014-02-08 15:46:07 +01:00
Benjamin Eberlei
5fc7e653fe
Update UPGRADE.md notes with BC mention.
2014-02-08 15:42:24 +01:00
Benjamin Eberlei
105d9e998b
Merge pull request #927 from timdev/timdev-fixes
...
s/EntityManager/EntityManagerInterface/ in a few places
2014-02-08 15:30:15 +01:00
Benjamin Eberlei
f07c576e5f
Merge pull request #932 from deeky666/DDC-2919
...
[DDC-2919] Make lock mode usage consistent
2014-02-08 15:27:35 +01:00
Benjamin Morel
496f9a0176
Avoid PersistentCollection::isEmpty() to fully load the collection on extra lazy fetch.
2014-02-08 13:49:48 +00:00
Benjamin Eberlei
0c2c5006f8
Merge pull request #934 from shustrik/master
...
faild test with multiple HINT_CUSTOM_TREE_WALKERS
2014-02-08 14:34:35 +01:00
Asmir Mustafic
5475d616e3
more tests
2014-02-07 14:30:17 +01:00
shustrik
b167a64544
remove doc
2014-02-06 20:08:07 +03:00
Strate
ffe5bf1fe3
Merge pull request #2 from shustrik/multiplie_tree_walker
...
Multiplie tree walker bugfix
2014-02-06 20:04:24 +03:00
shustrik
12985b7811
add iterator to tree walker chain
2014-02-06 19:39:40 +03:00
Marco Pivetta
7ceb9b0b50
Merge pull request #938 from HermanPeeren/master
...
Missing join-tables added in example
2014-02-06 16:31:17 +01:00
HermanPeeren
128e83909b
Update working-with-associations.rst
...
removed some spaces that had come into it while editing last commit
2014-02-06 16:09:27 +01:00
HermanPeeren
9c19d1e5c4
Update working-with-associations.rst
...
There are 2 many-to-many associations between the users and comments. Both use another join-table. The join-tables user_favorite_comments and user_read_comments must be specified. Otherwise the default "user_comment" is taken twice. See https://groups.google.com/forum/#!topic/doctrine-user/Kti36_n6490 and https://groups.google.com/forum/#!topic/doctrine-user/TYwafhgYiSU
2014-02-06 15:59:56 +01:00
Asmir Mustafic
1d40c85c3c
Right owning side column selection
2014-02-06 14:26:06 +01:00
shustrik
6fe40b055f
fix return walker
2014-02-06 16:18:35 +03:00
shustrik
a6b43b93ac
fix TreeWalkerChain.
...
Create walker object in foreach.
2014-02-06 16:06:00 +03:00
Asmir Mustafic
2eb428df79
code style
2014-02-06 12:55:33 +01:00
Asmir Mustafic
724e69146c
typos and removed confusing ternary
2014-02-06 12:44:13 +01:00
Asmir Mustafic
557686aa0a
Entra-lazy for containsKey on collections
2014-02-06 12:27:12 +01:00
Ilya Pleshakov
1f3290faae
Remove incorrect (outdated) validation for public fields in SchemaValidator
2014-02-06 13:02:41 +04:00
shustrik
543ab500da
rename test
2014-02-06 10:53:34 +03:00
shustrik
7107a85041
faild test with multiple HINT_CUSTOM_TREE_WALKERS
...
failed test when we have more than 1 walker HINT_CUSTOM_TREE_WALKERS ,
because walkSelectStatement in TreeWalkerChain saves the last hint _queryComponents result.
2014-02-06 01:27:17 +03:00
Steve Müller
a6c8ab8a5f
make lock mode usage consistent
2014-02-05 15:13:53 +01:00
Strate
5c44dd3823
Allow to use object as a hint value.
2014-02-04 15:51:53 +01:00
Strate
352f38a77e
Fix comment
2014-02-04 15:51:53 +01:00
Strate
e8d47fa9a3
Added a new configuration option: defaultQueryHints, which allows to populate all queries by default set of hints.
2014-02-04 15:51:53 +01:00
Benjamin Eberlei
626efdafd4
Delete old phing build leftover.
2014-02-04 08:49:08 +01:00
Benjamin Eberlei
9653213914
Add warning about non scalar use in Criteria.
2014-02-04 00:02:09 +01:00
Tim Lieberman
25d71462e3
Make SchemaTool and SchemaValidator use EntityManagerInterface instead of EntityManager
2014-02-01 05:11:20 +00:00
Marco Pivetta
e322ab4deb
DDC-2931 - Removing previous broken fix for DDC-2931 - hardened
2014-02-01 02:00:10 +01:00
Marco Pivetta
7a32eca039
DDC-2931 - Safe comparison between proxies and entities when refreshing objects
2014-02-01 01:57:51 +01:00
Tim Lieberman
bf9fbd896b
Substitute EntityManagerInterface for EntityManager in Console EntityManagerHelper
2014-02-01 00:23:23 +00:00
Marco Pivetta
8c92e0f19f
DDC-2931 - adding test that verifies that fetch-joined entities get refreshed with hints
2014-02-01 01:05:34 +01:00
Tim Lieberman
43d94e7b5e
Console EntityManagerHelper now accepts EntityManagerInterface as constructor argument, instead of insisting on an EntityManager
2014-01-31 15:32:31 -08:00
Benjamin Eberlei
310afdf5d7
Merge pull request #910 from deeky666/DDC-2310
...
[DDC-2310] [DDC-2675] Fix SQL generation on table lock hint capable platforms
2014-01-31 11:33:30 -08:00
Fabio B. Silva
7e5a1c6b0d
Fix lazy association load
2014-01-28 12:26:10 -05:00
Fabio B. Silva
9b7e949025
Merge pull request #915 from mnapoli/patch-1
...
Improved DQL's "new" operator documentation
2014-01-25 08:36:54 -08:00
Marco Pivetta
b815a4b2d3
DDC-2931 - removing old comments
2014-01-24 02:52:30 +01:00
Marco Pivetta
596d2070ed
DDC-2931 - Removing refresh hints when fetching association data in hydrators
2014-01-24 02:45:28 +01:00
Marco Pivetta
9eafb11a02
DDC-2931 - Detailed explanation
2014-01-24 02:43:14 +01:00
Marco Pivetta
22bcfef523
DDC-2931 - cleaning up code formatting/simplifying test case
2014-01-23 20:19:36 +01:00
root
fabef48ca2
[DDC-2931] testcase to reproduce Jira 2931
2014-01-23 17:31:08 +00:00
Matthieu Napoli
30c3eb0465
Improved DQL's "new" operator documentation
2014-01-21 17:34:54 +01:00
Matthieu Napoli
330c66559c
Improved DQL's "new" operator documentation
...
I had to dig through the pull requests and issues to figure that out, so I believe it's best documented explicitly.
2014-01-21 10:54:13 +01:00
Strate
04e6061584
Added an exception when invalid case.
...
Fixes after code review.
2014-01-20 20:06:53 +04:00
Benjamin Eberlei
bba5ec27fb
Remove badges
2014-01-20 09:36:15 +01:00
Marco Pivetta
a83f5df47c
Merge pull request #913 from WouterJ/patch-1
...
Added exception class names
2014-01-19 22:02:34 -08:00
Marco Pivetta
0e5146b06b
Merge pull request #914 from liuggio/patch-2
...
added license badge
2014-01-19 21:36:50 -08:00
Strate
41ec5fd56d
Fix applying ON/WITH conditions to first join in Class Table Inheritance
...
Now we build nested joins for CTI when using ON/WITH clause.
2014-01-19 20:56:24 +04:00
Strate
b69481b639
Merge branch 'master' into bugfix/join-with-condition-placement-fix
2014-01-19 15:06:01 +04:00
Giulio De Donato
65f002d62c
added license badge
2014-01-18 23:44:44 +01:00
Wouter J
996499e6fc
Added exception class names
2014-01-18 11:09:22 +01:00
Steve Müller
b9ff877f14
fix SQL generation on table lock hint capable platforms
2014-01-15 22:46:09 +01:00
Steve Müller
cf43edd6a1
Merge pull request #911 from goatherd/fix-foreach-as-style
...
fix foreach coding style
2014-01-14 14:50:33 -08:00
goatherd
a485e791bb
fix foreach coding style
2014-01-14 23:44:38 +01:00
Benjamin Eberlei
b0736b5b6c
Merge pull request #909 from deeky666/fix-sqlserver-database-driver-test
...
Fix DatabaseDriverTest on SQL Server
2014-01-13 09:52:17 -08:00
Steve Müller
3eced21a01
add missing use statement for SQL Server testsuite to work
2014-01-13 15:57:18 +01:00
Geoffrey Wagner
b863b9b957
Fix some code standard things
2014-01-12 17:14:32 -06:00
Marco Pivetta
771da768ac
Merge pull request #906 from KevinBrogan/master
...
removed erroneous tip
2014-01-12 08:10:20 -08:00
Benjamin Eberlei
12556e2dfe
Add MyISAM limitation
2014-01-12 11:33:37 +01:00
Kevin Brogan
5989c0cb54
removed erroneous tip
...
I'm working through the tutorial myself and got to this point.
Don’t forget to add a require_once call for this class to the bootstrap.php
This advice is wrong. The class is located in the src directory and so is autoloaded when required. No require statement is necessary.
2014-01-10 20:28:41 -08:00
Geoffrey Wagner
e9739f8591
Fix some code standard things
2014-01-09 10:48:38 -06:00
Geoffrey Wagner
4772cbfae6
Add a test
...
addLifecycleCallback now only allows a callback once so we do not hook them twice
2014-01-08 20:58:50 -06:00
Geoffrey Wagner
db31c58102
Fix Lifecycle Callbacks
...
Remove a bit of code that breaks lifecycle callbacks of parent MappedSuperclasses
2014-01-08 17:17:47 -06:00
Benjamin Eberlei
93c1106735
Merge pull request #901 from deeky666/disable-travis-hhvm-unsupported-drivers
...
Exclude HHVM + PostgreSQL and HHVM + Mysqli from travis build matrix
2014-01-08 11:22:29 -08:00
Steve Müller
f4c30dcd1c
exclude unsupported HHVM + PostgreSQL and HHVM + Mysqli from travis build matrix for now
2014-01-08 20:19:10 +01:00
Guilherme Blanco
4e824ac6e1
Merge pull request #900 from deeky666/fix-connection-mock
...
Fix connection mock fetchColumn signature
2014-01-06 12:27:50 -08:00
Steve Müller
5f93c83059
fix connection mock fetchColumn signature
2014-01-06 21:24:01 +01:00
USvER
b23d0bec33
Added note to STI
...
http://www.doctrine-project.org/jira/browse/DDC-2886
2014-01-06 00:44:51 +02:00
Guilherme Blanco
b65d9e6c83
Merge pull request #896 from holtkamp/patch-2
...
Ensure <cascade/> elements preceed <join-columns/>
2014-01-05 11:32:31 -08:00
Guilherme Blanco
7f30c31e98
Merge pull request #897 from holtkamp/patch-3
...
Respected 'inheritanceType' at Entity level
2014-01-05 11:31:25 -08:00
Menno Holtkamp
fc2b9980ae
Exclude exporting inheritanceType for INHERITANCE_TYPE_NONE
2014-01-05 18:53:31 +01:00
Menno Holtkamp
797fb9c34a
Respected 'inheritanceType' at Entity level
...
It was (incorrectly) fetched from Table-level.
http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/reference/annotations-reference.html#annref-inheritancetype
2014-01-05 18:41:55 +01:00
Menno Holtkamp
85a16f9f28
Ensure <cascade/> elements preceed <join-columns/>
...
When converting annotations based metadata to XML, the position of the <cascade/> elements resulted in XSD validation errors caused by the definitions of the association ComplexTypes:
- https://github.com/doctrine/doctrine2/blob/master/doctrine-mapping.xsd#L463
- https://github.com/doctrine/doctrine2/blob/master/doctrine-mapping.xsd#L482
- https://github.com/doctrine/doctrine2/blob/master/doctrine-mapping.xsd#L495
- https://github.com/doctrine/doctrine2/blob/master/doctrine-mapping.xsd#L517
Since changing the XSD might result in validation problems in existing mappings, changing the XmlExporter seems a better approach.
Note that the '<cache/>' element is not yet generated by the XmlExporter, but according to the XML Schema, it should precede the '<cascade/>' element.
2014-01-05 15:34:59 +01:00
Johannes Schmitt
7020f4135f
skips DQL UPDATE/DELETE tests with SLC enabled
2014-01-04 18:32:06 +01:00
Johannes Schmitt
87b4155665
adds test for ResultSetMappingBuilder restriction
2014-01-04 18:06:16 +01:00
Johannes Schmitt
e879626d73
Merge branch 'master' of github.com:doctrine/doctrine2 into rsmBuilder
2014-01-04 17:57:39 +01:00
Johannes Schmitt
946419459c
fixes bad merge
2014-01-04 17:54:46 +01:00
Johannes Schmitt
4f585a3d63
Merge branch 'master' of github.com:doctrine/doctrine2 into ValueObjects
...
Conflicts:
UPGRADE.md
lib/Doctrine/ORM/Mapping/Driver/DoctrineAnnotations.php
2014-01-04 17:52:32 +01:00
Benjamin Eberlei
69cad4079d
Merge pull request #820 from apancutt/master
...
Added support for field options to FieldBuilder
2014-01-03 14:03:25 -08:00
Benjamin Eberlei
8de37de4f7
Merge branch 'DDC-2792'
2014-01-03 23:01:12 +01:00
Benjamin Eberlei
2a9351b8dc
[DDC-2792] Fix fatals
2014-01-03 23:01:05 +01:00
Vyacheslav Ganzin
1edf6b65b1
joinColumn is not required in manyToMany
...
annotation behavior copied
2014-01-03 22:27:27 +01:00
Benjamin Eberlei
c8c7cf0528
Fix tests after merge of QueryBuilder#addCriteria changes.
2014-01-03 21:28:06 +01:00
Steve Müller
5828e4c67c
Merge pull request #894 from piotrantosik/patch-2
...
Fix typos - QueryBuilder
2014-01-03 09:23:48 -08:00
Piotr Antosik
eb45690e10
Fix typos - QueryBuilder
2014-01-03 17:28:42 +01:00
Adam Pancutt
352f5394e5
Removed FieldBuilder::unsigned() method as it is only supported by MySQL
2014-01-03 09:48:38 +00:00
Benjamin Eberlei
9a3cf77919
[DDC-2128] Fix PR according to comments.
2014-01-03 00:15:14 +01:00
catalin
93c018668d
checking preg result. Should I raise an error
...
throw new ORMException("Error regular expression: " . $filter);
2014-01-03 00:15:14 +01:00
catalin
0d8f572661
added space after type cast (I could not find any rule in psr1/2 standard, but I modified in PhpStorm)
2014-01-03 00:15:14 +01:00
catalin
2326033e79
added preg_quote to $filter input
2014-01-03 00:15:13 +01:00
catalin
57e7559c1b
- Applied Phpstorm PSR format
...
- Changed RegExp format
2014-01-03 00:15:13 +01:00
Catalinux
6963bf6028
Now MetaDataFilter takess also regexp. For example whern you want to
...
extract metadata if you would filter like this: --filter="Article"
would extract also for "ArticleItems" (article_items table). Now you
can use --filter="Article$" if you want only that table (articl)
2014-01-03 00:15:13 +01:00
Benjamin Eberlei
8118dddc6a
Merge pull request #674 from TorbenBr/master
...
Shortcut for force
2014-01-02 15:02:46 -08:00
Benjamin Eberlei
0a2b5b8efd
Merge pull request #734 from caponica/patch-1
...
Cleaned up documentation
2014-01-02 15:00:11 -08:00
Benjamin Eberlei
22d4d2e812
Merge branch 'DDC-2700'
2014-01-02 23:50:21 +01:00
Benjamin Eberlei
53ed898684
[DDC-2700] Add test and fix CS.
2014-01-02 23:50:15 +01:00
Benjamin Eberlei
2feffe164a
Merge branch 'DDC-2732'
2014-01-02 23:33:56 +01:00
Benjamin Eberlei
b1e031a1b4
[DDC-2732] Add tests for XML id options fix.
2014-01-02 23:33:49 +01:00
Benjamin Eberlei
96ec3c1613
Merge pull request #830 from sandermarechal/sort-alias
...
[DDC-2764] Prefix criteria orderBy with rootAlias
2014-01-02 14:15:01 -08:00
Benjamin Eberlei
41581847b2
Merge pull request #833 from ronanguilloux/patch-console-entity-generator
...
Generate-Entities-Console-Command: Adding an 'avoid backup' flag
2014-01-02 14:13:27 -08:00
Benjamin Eberlei
e91ed74b25
[DDC-2775] cleanup test.
2014-01-02 23:11:35 +01:00
Benjamin Eberlei
17809abd29
Merge pull request #837 from mnapoli/DDC2775
...
DDC-2775 Tests and fix
2014-01-02 14:07:14 -08:00
Benjamin Eberlei
05576d3e1c
Merge pull request #844 from terite/orm-validate-skip
...
Teach orm:validate-schema to --skip-mapping and --skip-sync
2014-01-02 14:00:22 -08:00
Benjamin Eberlei
ea84cfbdd1
Merge pull request #845 from flack/avoid-update-on-delete
...
Don't compute changeset for entities that are going to be deleted
2014-01-02 13:59:25 -08:00
Benjamin Eberlei
10576286b8
[DDC-2803] Fix error in documentation.
2014-01-02 22:54:46 +01:00
Benjamin Eberlei
7a4a46a95c
[GH-855] fix CS
2014-01-02 22:50:36 +01:00
ptarjan
27c9074b71
don't rely on gc_collect_cycles for HHVM
2014-01-02 22:50:36 +01:00
Benjamin Eberlei
3a8aaea14a
Merge pull request #794 from stefankleff/patch-1
...
Multiple invokation of listeners on PreFlush event
2014-01-02 13:16:21 -08:00
Benjamin Eberlei
a2cdc7a1c7
Merge pull request #893 from yktd26/master
...
autoGenerate arg from bool to int
2014-01-02 13:03:33 -08:00
yktd26
c9e06a6854
Format code
2013-12-31 12:25:14 +01:00
yktd26
bee74f898d
autoGenerate arg from bool to int
...
For using all four modes of proxies generation, change the 4th arg of
ProxyFactory's constructor to integer
2013-12-31 11:58:36 +01:00
Guilherme Blanco
a7b9140d2f
Merge pull request #890 from deeky666/DBAL-563
...
[DBAL-563] Add general IDENTITY generator type support for sequence emulating platforms
2013-12-30 21:34:20 -08:00
Benjamin Eberlei
58c57c50bf
Merge pull request #891 from spolischook/patch-2
...
Allow to not generate extra use
2013-12-30 00:33:03 -08:00
Sergey Polischook
07f67c5d1a
Allow to not generate extra use
...
For case when we not generate annotation (by default at doctrine orm:generate-entities) allow to not generate extra use for it -
```php
use Doctrine\ORM\Mapping as ORM;
```
For example if generate entities for my project that use only dbal in pord but use orm for generate entities in dev mode.
2013-12-30 04:43:35 +02:00
Steve Müller
337857dc8a
add general IDENTITY generator type support for sequence emulating platforms
2013-12-29 05:55:16 +01:00
Marco Pivetta
7360231b4b
Merge pull request #888 from entering/docs-yaml-mapping-improve-example
...
Add an example to doc of YAML mapping
2013-12-25 14:12:38 -08:00
entering
2f0b4a5d81
Add an example to doc of YAML mapping
2013-12-25 22:11:15 +00:00
Matthieu Napoli
c9791fe97f
Inlined the model for the DCC2775 test case inside the test class
2013-12-23 09:55:10 +01:00
Strate
c6810861ca
Fix applying ON/WITH conditions to first join in Class Table Inheritance
2013-12-22 21:02:14 +04:00
Guilherme Blanco
5439a613d6
Merge pull request #884 from FabioBatSilva/slc-patch1
...
[SLC] Fix cache misses using one-to-one inverse side
2013-12-20 15:23:21 -08:00
fabios
cf4c805427
Fix cache misses using one-to-one inverse side
2013-12-20 15:37:07 -05:00
Guilherme Blanco
8554b04053
Merge pull request #883 from FabioBatSilva/hotfix-slc
...
[DDC-2862] Fix non initialized association proxy
2013-12-20 10:43:56 -08:00
fabios
22e3a76327
Fix non initialized association proxy
2013-12-20 10:39:03 -05:00
Benjamin Eberlei
f0546455d5
Remove left over ElementCollection code.
2013-12-20 15:01:10 +01:00
Guilherme Blanco
423ea00539
Merge pull request #590 from michaelperrin/feature/process-collection-value
...
DQL Query: process ArrayCollection values to ease development
2013-12-17 10:39:36 -08:00
Michaël Perrin
1032a16db2
Simpler way to handle Collection parameters in DQL queries (refs #DDC-2319)
2013-12-17 11:37:17 +01:00
Benjamin Eberlei
ad9366a1fc
Merge pull request #871 from elmariachi111/patch-1
...
XCache cannot be flushed on the CLI -> for pretty much the same reason as APC
2013-12-16 15:47:09 -08:00
Benjamin Eberlei
48ea45fad0
Add note about experimental nature of SLC feature
2013-12-17 00:05:43 +01:00
Guilherme Blanco
b081e5681d
Merge pull request #808 from FabioBatSilva/slc
...
Second level cache
2013-12-16 14:59:56 -08:00
fabios
4e0e1b8061
CS/Typo Fixes
2013-12-16 15:55:54 -05:00
fabios
0a66a2bc09
CS/Doc Fixes
2013-12-16 11:05:05 -05:00
fabios
71903c28a8
Region cache clear commands
2013-12-16 11:05:05 -05:00
fabios
fb98277783
Fix docs
2013-12-16 11:05:05 -05:00
fabios
d135e402bb
handle update/delete queries
2013-12-16 11:05:05 -05:00
Fabio B. Silva
61bff7d5f6
Fix CS and update docs
2013-12-16 11:05:04 -05:00
Fabio B. Silva
1438a59c00
Fix persister query cache invalidation
2013-12-16 11:05:04 -05:00
fabios
1bfa8f0fc3
Extract cache config
2013-12-16 11:05:04 -05:00
Fabio B. Silva
3140593e9b
Second level cache
2013-12-16 11:05:04 -05:00
Benjamin Eberlei
86ae6f18ab
Merge branch 'DDC-2645'
2013-12-15 23:31:49 +01:00
Pouyan Savoli
a5b7069fd7
[DDC-2645] Apply patch to fix issue
2013-12-15 23:31:35 +01:00
Matthieu Napoli
602c3be3fc
Cleaned up tests for DDC-2775
2013-12-14 19:57:53 +01:00
Aaron Muylaert
aa5df1dbac
Create failing test for DDC-2645.
...
Merge not dealing correctly with composite primary keys.
2013-12-14 15:59:10 +01:00
Marco Pivetta
6f1642b35d
Merge pull request #877 from aaronmu/DDC-1787
...
Hotfix for DDC-1787
2013-12-14 06:22:20 -08:00
Marco Pivetta
5fa1b10506
Merge pull request #832 from mnapoli/patch-4
...
Added "readOnly: true" to YAML reference
2013-12-14 05:41:27 -08:00
Marco Pivetta
bd4d27eabf
Merge pull request #842 from TheFrozenFire/tests/query-tests
...
Added EntityManager query creation tests
2013-12-14 05:26:46 -08:00
Marco Pivetta
ce914bef3f
Merge pull request #875 from doctrine/DDC-2844
...
Adding tests that confirm that DDC-2844 is fixed
2013-12-14 05:13:24 -08:00
Aaron Muylaert
3cc630798b
Fix DDC-1787.
...
Credit goes to Jack van Galen for fixing this issue.
Fix for JoinedSubclassPersister, multiple inserts with versioning throws
an optimistic locking exception.
2013-12-14 13:50:46 +01:00
Marco Pivetta
d20b136270
Adding tests to verify that dql aliases in criteria are correctly converted
2013-12-14 13:42:18 +01:00
Marco Pivetta
72e6de9417
Adding tests that confirm that DDC-2844 is fixed
2013-12-14 13:42:18 +01:00
Aaron Muylaert
600af3e617
Add failing test for DDC-1787.
...
Using joined table inheritance, when persisting multiple new entities
that are subclasses of a baseclass that has the @Version attribute set,
only the last persisted entity will have it's version set.
2013-12-14 13:24:47 +01:00
Marco Pivetta
8a38534be4
Merge pull request #876 from doctrine/hotfix/hhvm-allow-failures
...
Fixing wrong key for allowing HHVM failures
2013-12-14 04:22:59 -08:00
Marco Pivetta
940c1f3b1c
Fixing wrong key for allowing HHVM failures
2013-12-14 12:40:59 +01:00
Benjamin Eberlei
4ed96e2ab6
Update CONTRIBUTING.md
2013-12-14 11:29:07 +01:00
Benjamin Eberlei
d820c25eda
Merge branch 'GH-873'
2013-12-13 22:13:37 +01:00
Benjamin Eberlei
40f9facfd1
Add allowed failures for HHVM.
2013-12-13 22:13:28 +01:00
Paul Tarjan
b6a0c8b1ad
Try running unit tests on HHVM
2013-12-13 11:43:53 -08:00
Benjamin Eberlei
94a3e6c42b
Add missing LICENSE of documentation
2013-12-12 00:30:15 +01:00
Marco Pivetta
b461c9cf23
Merge pull request #872 from matheo/patch-1
...
Doctrine 2.4 now supports SQLite ALTER TABLE
2013-12-10 21:08:22 -08:00
Mateo Tibaquirá Palacios
3669321161
Doctrine 2.4 now supports SQLite ALTER TABLE
2013-12-11 00:07:07 -05:00
Stefan A
eded05d415
XCache cannot be cleared on CLI (like APC)
2013-12-10 19:51:41 +01:00
Stefan A
88a56ee8f8
XCache cannot be cleared on CLI (like APC)
2013-12-10 19:51:02 +01:00
Stefan A
53fbb0b2d1
XCache cannot be cleared on CLI (like APC)
2013-12-10 19:48:30 +01:00
Marco Pivetta
2cccb3cc62
Merge pull request #870 from lcobucci/master
...
Documenting interface methods (based on entity manager)
2013-12-10 06:36:44 -08:00
Luís Otávio Cobucci Oblonczyk
6d58824ac5
Use docblox from EntityManagerInterface
2013-12-10 12:09:36 -02:00
Luís Otávio Cobucci Oblonczyk
67135e5d6f
Fixing FQCN on docblox
2013-12-10 12:08:53 -02:00
Luís Otávio Cobucci Oblonczyk
877ba9bf17
Documenting interface methods (based on entity manager)
2013-12-10 11:18:27 -02:00
Johannes
f7f7c460f2
Merge pull request #1 from jankramer/ValueObjects
...
Update xml mapping driver and schema to work with embeddables
2013-12-07 08:44:09 -08:00
Jan Kramer
fbb7b5ad8e
Fix XmlDriver to accept embeddables
2013-12-07 16:40:54 +01:00
Jan Kramer
928c32d616
Update XML schema to reflect addition of embeddables
2013-12-07 16:38:32 +01:00
Guilherme Blanco
90a0d29b2b
Merge pull request #868 from mnapoli/patch-1
...
Added documentation section for Memcached
2013-12-02 07:00:40 -08:00
Matthieu Napoli
38c59ce5a4
Added documentation section for Memcached
2013-12-02 14:59:04 +01:00
Marco Pivetta
3caf1fdfa6
Merge pull request #866 from bountin/doc_refresh
...
Mentioning the 'refresh' cascading property in the documentation list
2013-12-01 14:07:21 -08:00
Martin Prebio
2828d7b5cd
Mentioning the 'refresh' cascading property in the documentation list
2013-12-01 22:43:06 +01:00
Johannes M. Schmitt
e5cab1db2d
adds embedded classes to cache
2013-11-28 17:32:47 +01:00
Marco Pivetta
606ae2e03d
Merge pull request #862 from stof/patch-2
...
Added a note about changing the fetch mode for to-many relations
2013-11-26 05:22:39 -08:00
Christophe Coevoet
dfbf996a50
Added a note about changing the fetch mode for to-many relations
2013-11-26 14:20:51 +01:00
Guilherme Blanco
0e3c57dbd3
Merge pull request #849 from bsahlhof/master
...
Error with Same Field, Multiple Values, Criteria and QueryBuilder
2013-11-25 21:20:14 -08:00
Guilherme Blanco
d63820755d
Merge pull request #860 from deeky666/add-sql-anywhere-documentation
...
Mention SQL Anywhere in basic mapping documentation
2013-11-25 09:44:04 -08:00
Steve Müller
45118a2811
mention SQL Anywhere in basic mapping docs
2013-11-25 18:24:54 +01:00
Guilherme Blanco
c460344994
Merge pull request #850 from FabioBatSilva/attach-entity-listeners
...
Event listener to programmatically attach entity listeners.
2013-11-25 08:21:36 -08:00
Johannes M. Schmitt
8ae48ad9db
lifts an unnecessary restriction on ResultSetMappingBuilder
2013-11-23 19:47:56 +01:00
Steve Müller
75d7ac2783
Merge pull request #854 from ptarjan/master
...
fix relative path to doctrine/common
2013-11-23 05:14:44 -08:00
Marco Pivetta
642d6e3033
Merge pull request #856 from ptarjan/reference_proxy_test
...
Fix dependency for tests/Doctrine/Tests/ORM/Functional/ReferenceProxyTest.php
2013-11-22 05:34:41 -08:00
ptarjan
1fe8ff756e
Fix dependency for tests/Doctrine/Tests/ORM/Functional/ReferenceProxyTest.php
2013-11-22 01:15:13 -08:00
ptarjan
a8ad9069c9
fix relative path to doctrine/common
2013-11-21 20:38:39 -08:00
fabios
9e3ad91225
Version 2.5.0-DEV
2013-11-19 11:50:43 -05:00
Guilherme Blanco
0fe6d75211
Merge pull request #851 from naitsirch/doc/instance_of
...
Documentation about how to use INSTANCE OF in inheritance
2013-11-19 08:12:29 -08:00
Brad Sahlhoff
96fb0d7e14
Changed logic to allow joining games, and becoming friends
...
Added Spacing
2013-11-19 11:09:23 -05:00
Christian Stoller
393b3d37f5
Documentation about how to use INSANCE OF in inheritance
2013-11-19 09:18:33 +01:00
fabios
e69cd37226
Event listener to programmatically attach entity listeners.
2013-11-18 15:03:00 -05:00
Brad Sahlhoff
c2997b3961
Add ability to test same parameter name for multiple values.
2013-11-18 10:36:46 -05:00
flack
3d12920cd4
Add note about changed behaviour
2013-11-17 12:06:47 +01:00
flack
88ae5883f3
Add testcase
2013-11-17 11:51:09 +01:00
flack
ffd858b238
Merge remote-tracking branch 'upstream/master' into avoid-update-on-delete
2013-11-17 11:36:06 +01:00
flack
9807718100
Also skip entities scheduled for deletion when committing multiple entities
2013-11-17 11:31:21 +01:00
Fabio B. Silva
3529cd4282
Merge pull request #797 from peterkokot/patch-1
...
CS fixes
2013-11-16 10:52:09 -08:00
Benjamin Eberlei
2925fea7bd
Make tests forward compatible with DBAL 2.5
2013-11-14 12:36:52 +01:00
Johannes M. Schmitt
0ee7b688c3
small fix
2013-11-13 00:07:20 +01:00
Johannes M. Schmitt
2a73a6f1f7
some cs fixes
2013-11-13 00:05:55 +01:00
Johannes M. Schmitt
fb3a06b9e7
adds support for XML/Yaml drivers
2013-11-13 00:03:21 +01:00
Johannes M. Schmitt
9ad376c006
adds docs
2013-11-12 23:49:25 +01:00
Benjamin Eberlei
6cdd65762f
Add 2.4 branch [ci skip]
2013-11-12 13:37:20 +01:00
David Stensland
e6be52af3a
Teach orm:validate-schema to --skip-mapping and --skip-sync
...
Use --skip-mapping to not check if the current mapping informaiton
is valid or not.
Use --skip-sync to not check if the database schema is in line with
the current schema mapping.
2013-11-11 18:12:28 -05:00
flack
9016a5a854
don't compute changeset for entities that are going to be deleted
2013-11-12 00:11:50 +01:00
Benjamin Eberlei
0edf2bc585
Add missing link to batch processing chapter
2013-11-07 16:43:36 +01:00
Justin Martin
8b4b8e7268
Test EntityManager::createNamedQuery.
...
Test EntityManager::createNamedNativeQuery.
2013-11-06 20:07:48 -08:00
Marco Pivetta
141213915e
Merge pull request #838 from flack/patch-2
...
Spelling fix
2013-11-04 10:21:49 -08:00
Marco Pivetta
271f952c4a
Merge pull request #839 from flack/patch-3
...
Spelling fix
2013-11-04 10:20:12 -08:00
flack
8ad6853e84
Spelling fix
2013-11-04 19:17:04 +01:00
flack
dc476b62d1
Spelling fix
2013-11-04 19:16:04 +01:00
Guilherme Blanco
c7d4077219
Merge pull request #834 from carlosbuenosvinos/patch-1
...
Add example use of repositoryClass in YAML
2013-11-04 07:46:42 -08:00
Guilherme Blanco
f3b8fe5255
Merge pull request #836 from Dragonrun1/master
...
Update annotations-reference.rst
2013-11-04 07:05:16 -08:00
Matthieu Napoli
1899bcf000
Fixed tests failing in pgsql because of used of a reserved keyword
2013-11-04 16:01:05 +01:00
Matthieu Napoli
791ec3bc6e
Fixed tests for pgsql: was using reserved keyword as table name
2013-11-04 12:53:18 +01:00
Matthieu Napoli
e018bb83f0
[DDC-2775] Bugfix
2013-11-04 12:42:23 +01:00
Matthieu Napoli
8bd54be4ec
[DDC-2775] Tests reproducing DDC-2775
2013-11-04 12:40:51 +01:00
Michael Cummings
01dc0e8273
Update annotations-reference.rst
...
@JoinTable because of mapping defaults does NOT have required attributes. Updated annotations reference to show them as optional.
2013-11-03 09:20:15 -08:00
Johannes M. Schmitt
17e0a7b2f8
makes column prefix configurable
2013-11-02 14:07:14 +01:00
Johannes M. Schmitt
2b2f4894cb
fixes declaring class
2013-11-02 13:55:19 +01:00
Johannes M. Schmitt
0cd6061fc2
fixes a bad merge
2013-11-02 13:35:41 +01:00
Johannes M. Schmitt
5586ddd6b7
removes restrictions on constructors of embedded objects
2013-11-02 13:31:44 +01:00
Johannes M. Schmitt
ece62d6ad7
adds support & tests for embeddables in inheritance schemes
2013-11-02 13:23:56 +01:00
Johannes M. Schmitt
d4e6618b28
Merge remote-tracking branch 'schmittjoh/ValueObjects'
2013-11-02 11:20:44 +01:00
Johannes M. Schmitt
97836ef8c6
some consistency fixes
2013-11-01 22:37:59 +01:00
Johannes M. Schmitt
f86abd81dd
fixes annotation context
2013-11-01 22:33:59 +01:00
Johannes M. Schmitt
4f6c15099a
fixes coding style
2013-11-01 21:47:56 +01:00
Johannes M. Schmitt
20fb8270dc
make use of NamingStrategy for columns of embedded fields
2013-11-01 21:44:57 +01:00
Johannes M. Schmitt
fd8b5bd045
removes outdated todos
2013-11-01 21:16:02 +01:00
Johannes M. Schmitt
41c937b983
adds test for non-existent field
2013-11-01 20:54:45 +01:00
Johannes M. Schmitt
30897c3115
adds tests for update/delete DQL queries
2013-11-01 20:46:08 +01:00
Johannes M. Schmitt
c67ac8a11b
adds support for selecting based on embedded fields
2013-11-01 20:38:19 +01:00
Johannes M. Schmitt
38b041d909
Merge remote-tracking branch 'origin/ValueObjects'
...
Conflicts:
lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php
2013-11-01 20:17:43 +01:00
Sander Marechal
35a62e9a05
Add rootAlias to Criteria where clauses
2013-11-01 13:43:03 +01:00
Sander Marechal
202039e853
Set rootAlias outside loop
2013-11-01 13:19:33 +01:00
Carlos Buenosvinos
6eac308ca3
Add example use of repositoryClass in YAML
2013-11-01 12:11:01 +01:00
Ronan Guilloux
48d078a856
no-backup instead of nobackup
2013-10-31 12:25:43 +01:00
Ronan Guilloux
5c01e8e99e
Generate-Entities-Console-Command: Adding an 'avoid creating backup files' flag
2013-10-31 12:00:32 +01:00
Matthieu Napoli
f3f9fe9daa
Added "readOnly: true" to YAML reference
...
The readOnly configuration is documented nowhere except in the annotations reference.
I added it to the example, for a lack of a better place. But at least it will be documented somewhere.
Can you also confirm that this is correct? I'm starting to use it, and I can't find a way to have doctrine validate it is really working. Even with the metadata validation tool, it won't raise an error if I put an invalid entry (`readOnlyFOOBAR: true`) or an invalid value (`readOnly: FOOBAR`), so I'm kind of blind here.
2013-10-31 10:50:44 +01:00
Sander Marechal
b6f8d53ff1
[DDC-2764] Prefix criteria orderBy with rootAlias
2013-10-29 11:11:46 +01:00
Benjamin Eberlei
514dd4e852
[DDC-2757] Update documentation with regard to manually closing the EntityManager when an Exception occurs.
2013-10-26 12:32:53 +02:00
Benjamin Eberlei
cedcac225f
Merge branch 'DDC-2759'
2013-10-26 11:16:21 +02:00
Benjamin Eberlei
9a3298347c
[DDC-2759] Fix regression in ArrayHydrator introduced in DDC-1884 at SHA c7b4c9bf0f
2013-10-26 11:16:07 +02:00
Chris Collins
7249804e3f
Added a failing test case for DDC-2759.
2013-10-24 13:02:42 +01:00
Marco Pivetta
b7cb1e98ee
Merge pull request #825 from flack/patch-1
...
Spelling fix
2013-10-23 02:32:45 -07:00
flack
195b1169ae
Spelling fix
2013-10-23 11:32:04 +02:00
Marco Pivetta
0a31ecb283
Merge pull request #824 from brikou/patch-3
...
s/PostgreSQLPlatform/PostgreSqlPlatform/
2013-10-21 00:45:51 -07:00
Brikou CARRE
84b980227f
s/PostgreSQLPlatform/PostgreSqlPlatform/
2013-10-21 09:44:48 +02:00
Marco Pivetta
a96fe8770c
Merge pull request #815 from nicolas-bastien/patch-2
...
Remove unused use statement
2013-10-18 03:46:09 -07:00
Marco Pivetta
d2e731174c
Merge pull request #821 from mnapoli/patch-4
...
Fixed documentation rendering
2013-10-17 07:18:12 -07:00
Matthieu Napoli
a90311cb44
Fixed documentation rendering
...
The 2 lists I've fixed render as citation in the docs: http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/index.html
If I didn't make any mistake, now they should render as simple lists.
2013-10-17 15:53:45 +02:00
Marco Pivetta
1e10fca66a
Merge pull request #818 from mfdj/master
...
Clarified tutorial context in section introducing `orm:scehma-tool:*` commands
2013-10-16 17:23:09 -07:00
Adam Pancutt
553086ae3d
Removed check for instantiated options array
2013-10-15 13:17:07 +01:00
Adam Pancutt
db5274113a
Code style fix
2013-10-15 12:49:34 +01:00
Adam Pancutt
25342b706d
Added support for field options to FieldBuilder
2013-10-15 12:37:06 +01:00
Guilherme Blanco
95ad926c95
Merge pull request #819 from vbourdeix/master
...
Fixes a Fatal Error when using a subexpression in parenthesis
2013-10-14 11:01:51 -07:00
Vincent BOURDEIX
5506d7adce
Fixes a Fatal Error when using a subexpression in parenthesis
...
When some dql contains a subselect with expression in parenthesis, the
expression of the $simpleSelectExpression parameter given to
walkSimpleSelectExpression is an instance of AST\ParenthesisExpression.
Before this commit, this case defaulted to
$this->walkEntityIdentificationVariable($expr) where $expr is supposed
to be a string. A fatal error was then yielded.
2013-10-14 15:04:52 +02:00
Guilherme Blanco
0d58e82b76
Merge pull request #817 from mfdj/patch-1
...
Removed "minimum-stability" : "dev" from composer.json
2013-10-11 19:34:57 -07:00
Mark Fox
2f8b0801cc
further tweaking of last commit pt.2
2013-10-11 15:22:39 -07:00
Mark Fox
126cd0bac2
further tweaking of last commit
2013-10-11 15:20:53 -07:00
Mark Fox
c5adfca0ed
Clarified tutorial context around introduction of orm:schema-tool:* commands
...
See: http://stackoverflow.com/questions/17473225/doctrine2-no-metadata-classes-to-process for evidence of this confusion
2013-10-11 15:16:46 -07:00
Mark Fox
006dac13a9
Removed "minimum-stability" : "dev" from composer.json
2013-10-11 14:34:49 -07:00
Guilherme Blanco
bb63058410
Merge pull request #780 from terite/DDC-2655
...
[DDC-2655] Don't let getOneOrNullResult throw NoResultException
2013-10-11 13:43:27 -07:00
Guilherme Blanco
be81b46d8e
Merge pull request #791 from myclabs/CriteriaContains
...
Implemented "contains" operator for Criteria expressions
2013-10-11 06:33:40 -07:00
Eduardo
333177da00
Options not respected for ID Fields in XML Mapping Driver (XSD update)
...
XSD update.
The same bug of the yaml driver: see http://www.doctrine-project.org/jira/browse/DDC-2661
2013-10-09 23:49:39 +02:00
Eduardo
aabb34f853
Options not respected for ID Fields in XML Mapping Driver
...
Same bug of the YAML driver, see: http://www.doctrine-project.org/jira/browse/DDC-2661
2013-10-09 22:40:29 +02:00
David Stensland
089006927e
[DDC-2655] Don't let getOneOrNullResult throw NoResultException
2013-10-09 11:38:33 -04:00
Guilherme Blanco
ded3d20630
Merge pull request #787 from flip111/patch-1
...
Update DDC719Test.php to be compatible with MsSQL
2013-10-07 11:22:14 -07:00
Nicolas Bastien
33ddb9c0ca
Remove unused use statement
2013-10-07 15:58:41 +02:00
Guilherme Blanco
3f883d57a6
Merge pull request #811 from flip111/patch-6
...
Update SingleScalarHydrator error message
2013-10-02 06:07:59 -07:00
flip111
62ae8dc81e
Update SingleScalarHydrator error message
...
bummed into this one. Now more developer friendly :)
2013-10-02 14:12:35 +02:00
Benjamin Eberlei
fc53bc8909
Fix some LGPL occurances to MIT
2013-10-02 12:07:37 +02:00
Guilherme Blanco
2021d12df8
Merge pull request #809 from FabioBatSilva/DDC-1514
...
Fix DDC-1514 test
2013-10-01 22:02:22 -07:00
fabios
dd4bdd776a
Fix DDC-1514 test
2013-10-01 12:00:52 -04:00
flip111
4282fa4787
Used ternary operator to reduce LOC
2013-10-01 17:25:49 +02:00
Guilherme Blanco
2c4c26c5d6
Merge pull request #801 from flip111/patch-4
...
Update SqlWalker.php fixed wrong GROUP BY clause on SQL Server platform
2013-10-01 08:21:20 -07:00
flip111
228a501014
Made the code prettier :)
2013-10-01 16:53:53 +02:00
Guilherme Blanco
4051d0da86
Merge pull request #807 from janbster/fix-optimisticlock
...
Fix for OptimisticLockingException
2013-10-01 07:41:57 -07:00
jan brunnert
f64d6695ce
Removed unnecessary is_object() check
2013-10-01 13:00:37 +02:00
Guilherme Blanco
0e8e5c9ba5
Merge pull request #788 from flip111/patch-3
...
Update DatabaseDriverTest.php
2013-09-30 11:08:41 -07:00
Guilherme Blanco
d8335eee7b
Merge pull request #793 from flip111/patch-2
...
Improved error messages in Paginator: LimitSubqueryOutputWalker
2013-09-30 11:07:49 -07:00
Guilherme Blanco
f02d18f465
Merge pull request #804 from diego-mazzaro/master
...
[bugfix] if BIGINT or SMALLINT version field was not incremented.
2013-09-30 07:46:35 -07:00
jan brunnert
a4e3921090
When the OptimisticLockingException is generated with the static function lockFailedVersionMismatch and the passed parameters are DateTime instances, the exception could not be thrown because the DateTime object is not implicitly converted to a string.
2013-09-30 11:32:46 +02:00
flip111
72ae7f5497
Changed GroupBy alias to real column name for all platforms and adjusted failing test accordingly. Has fallback in cases where real column name is not possible (example: Doctrine\Tests\ORM\Query\SelectSqlGenerationTest::testGroupBySupportsIdentificationVariable)
2013-09-30 11:08:42 +02:00
Diego Mazzaro
bd0e0c3fcf
[bugfix] if BIGINT or SMALLINT version field was not incremented.
...
Made version field accepted type coherent between ClassMetadataInfo and BasicEntityPersister
2013-09-29 16:17:10 +02:00
Marco Pivetta
1414cc315e
Merge pull request #803 from cleentfaar/patch-1
...
Appended newline to (newly) generated files for PSR2 compatibility
2013-09-28 10:46:09 -07:00
Cas
1fda797c8f
Appended newline to (newly) generated files for PSR2 compatibility
...
Appended newline to (newly) generated files for PSR2 compatibility
Additionally, slightly improved styling of concatenating return value
2013-09-28 17:47:35 +02:00
Benjamin Eberlei
008187982d
Merge pull request #792 from FabioBatSilva/DDC-2668
...
[DDC-2668] Fix trim leading zero string
2013-09-26 14:23:07 -07:00
Benjamin Eberlei
b7cffbde37
Merge pull request #802 from fasmide/patch-1
...
Respect unsigned fields when tables get converted to entities.
2013-09-26 14:12:24 -07:00
Kristian Mide
0326731348
Respect unsigned fields when tables get converted to entities.
...
This is working on our mysql setup, however i have no idea of the consequences of this change when using other RDBMSes.
2013-09-26 14:41:06 +02:00
flip111
76fda9562c
Update SqlWalker.php fixed wrong GROUP BY clause on SQL Server platform
...
Without this patch a query would like like:
```
SELECT c0_.Country AS sclr0
FROM Continent c0_ WITH (NOLOCK)
WHERE c0_.Country = 38
GROUP BY sclr0
```
Using the column alias in the GROUP BY clause. However this is not allowed on SQL Server. References:
1. http://stackoverflow.com/a/3841804
2. http://technet.microsoft.com/en-us/library/ms189499.aspx (Logical Processing Order of the SELECT statement)
The correct query should be:
```
SELECT c0_.Country AS sclr0
FROM Continent c0_ WITH (NOLOCK)
WHERE c0_.Country = 38
GROUP BY c0_.Country
```
2013-09-26 14:11:56 +02:00
Guilherme Blanco
bd7c7ebaf3
Merge pull request #799 from FabioBatSilva/leftover-test
...
remove unused test case
2013-09-23 18:10:22 -07:00
Fabio B. Silva
614eed7f86
remove unused test case
2013-09-23 19:29:50 -04:00
Alex Pogodin
a75d73b889
Identifier can be empty for MappedSuperclasses
...
When MappedSuperclass is inspected without identifier column been assigned, always return false. Solves "Undefined offset" notice.
2013-09-22 17:19:51 +03:00
Peter Kokot
dca09148ca
CS fixes
2013-09-22 02:12:30 +02:00
Marco Pivetta
2089df36e3
Merge pull request #795 from sabzeta/patch-1
...
Update query-builder.rst
2013-09-20 11:05:38 -07:00
sabzeta
a419c7c93b
Update query-builder.rst
...
expresion substr changed to substring as of
http://www.doctrine-project.org/jira/browse/DDC-382
2013-09-20 15:27:05 +03:00
Stefan Kleff
adf2b7cce7
Listener class prefix
2013-09-20 09:20:58 +02:00
Stefan Kleff
619c6a03ce
removed unused use statements, fixed typo and group tag
2013-09-19 15:16:51 +02:00
Stefan Kleff
d4a08f7ab7
Added unit test
2013-09-19 14:16:33 +02:00
Stefan Kleff
1ec5632a18
Multiple invokation of listeners on PreFlush event
...
Only lifecycle callbacks and entity listeners should be triggered here. The preFlush listener event is already triggered at the beginning of commit()
2013-09-19 12:13:12 +02:00
flip111
a18aba1bb6
Improved error messages in Paginator: LimitSubqueryOutputWalker
...
The already existing follow-up check throwing "Not all identifier properties can be found in the ResultSetMapping: %s" is a much more technical description.
If $sqlIdentifier is empty (count 0) it can be concluded that there are no mapped results. An alternative error message could thus be "The Paginator does not support queries without mapped results." (line 153).
Possibly '!=' on line 154 could be replaced by '>' because i think this is the only situation that can occur. But since i don't know this for sure, i left it like i found it.
Didn't use elseif in this commit as per Stof his suggestion.
2013-09-17 21:01:09 +02:00
flip111
b803f06c8f
Improved error messages in Paginator: LimitSubqueryOutputWalker
...
The already existing follow-up check throwing "Not all identifier properties can be found in the ResultSetMapping: %s" is a much more technical description.
If $sqlIdentifier is empty (count 0) it can be concluded that there are no mapped results. An alternative error message could thus be "The Paginator does not support queries without mapped results." (line 153).
Possibly '!=' on line 154 could be replaced by '>' because i think this is the only situation that can occur. But since i don't know this for sure, i left it like i found it.
2013-09-17 15:07:08 +02:00
Fabio B. Silva
689da2f36b
[DDC-2668] Fix trim leading zero string
2013-09-16 21:36:19 -04:00
Matthieu Napoli
6f538c509c
Implemented "contains" operator for Criteria expressions
2013-09-16 14:56:04 +02:00
Benjamin Eberlei
fe78977973
Merge pull request #790 from javer/hhvm-func_get_args
...
HHVM compatibility: func_get_args
2013-09-15 11:05:01 -07:00
javer
64a0161935
HHVM compatibility: func_get_args
...
All func_get_args() calls have been moved to the top of the methods
because HHVM doesn't keep a copy of the original args for performance
reasons.
See facebook/hiphop-php#1027 for details.
2013-09-15 20:57:30 +03:00
flip111
67dd32d9fb
A nicer way of detecting the platform
...
Inspired by https://github.com/doctrine/doctrine2/blob/master/tests/Doctrine/Tests/ORM/Functional/DatabaseDriverTest.php#L188
2013-09-13 16:35:34 +02:00
flip111
e49a673a01
Update DatabaseDriverTest.php
...
SQL Server does not support unsigned integers
2013-09-13 16:29:31 +02:00
flip111
a190dad0b1
Update DDC719Test.php to be compatible with MsSQL
...
Apparently Doctrine adds "with (nolock)" now for the mssql platform, but the test has not been updated yet.
2013-09-13 15:11:35 +02:00
Marco Pivetta
c72698a997
Merge pull request #786 from weaverryan/patch-1
...
Minor updates while reading the basic-mapping page
2013-09-12 19:11:37 -07:00
Ryan Weaver
1fcef3321e
Changes thanks to @Ocramius
2013-09-12 20:52:12 -05:00
Ryan Weaver
36d7d60c3b
Minor updates while reading the basic-mapping page
...
The only arguable changes involve a few spots where I either removed something I thought was too technical and not valuable (e.g. talking about the metadata mapping pattern).
2013-09-12 17:08:48 -05:00
Benjamin Eberlei
067ed7b1c6
Fix master dependening on DBAL 2.5-dev
2013-09-12 08:00:08 +02:00
Benjamin Eberlei
b6e624b6bf
Delete some very old, leftover code.
2013-09-11 22:43:38 +02:00
Marco Pivetta
237c1e24e6
Merge pull request #785 from Hawkeye0203/patch-1
...
Update dql-custom-walkers.rst
2013-09-11 07:32:58 -07:00
Daniel VanMullen
ef722066e3
Update dql-custom-walkers.rst
...
Fixed typo of "customer" to "custom"
2013-09-11 09:25:52 -04:00
Marco Pivetta
bb7f18ced7
Merge pull request #784 from eventhorizonpl/fix_docs
...
fix documentation warnings p1
2013-09-10 15:54:40 -07:00
Michal Piotrowski
bc37ceb58b
fix warnings p1
...
fix warnings p2
fix warnings p3
fix warnings p4
2013-09-10 23:57:41 +02:00
Benjamin Eberlei
9983fcbac3
Fix some more details in basic-mapping.rst
2013-09-10 23:15:43 +02:00
Benjamin Eberlei
a948cb49b8
Small fixes in basic-mapping.rst
2013-09-10 22:36:03 +02:00
Benjamin Eberlei
546c817f64
Move Custom Mapping Types into cookbook, restructure the chapter more.
2013-09-10 22:09:22 +02:00
Benjamin Eberlei
caf6ba65e8
Refactor Basic Mapping chapter to focus on the actual topic more. Rearrange apperance of topics. Introduce a sane example entity as example.
2013-09-10 22:09:22 +02:00
Benjamin Eberlei
f7108b40c3
Move Annotations introduction to the reference.
2013-09-10 22:09:22 +02:00
Marco Pivetta
4d51a0290b
Merge pull request #782 from mnapoli/patch-4
...
#DDC-2664 Document new Proxy factory flags usage as of DCOM-210
2013-09-09 03:35:17 -07:00
Marco Pivetta
0d246f7e9e
Merge pull request #783 from mnapoli/DDC-2664
...
#DDC-2664 Improving and fixing documentation for new Proxy factory flags usage as of DCOM-210
2013-09-09 03:13:56 -07:00
Matthieu Napoli
8875462241
#DDC-2664 Improving and fixing documentation for new Proxy factory flags usage as of DCOM-210
2013-09-09 11:30:18 +02:00
Matthieu Napoli
26e1ac6afd
#DDC-2664 Improving and fixing documentation for new Proxy factory flags usage as of DCOM-210
2013-09-09 11:20:12 +02:00
Matthieu Napoli
4a0a4094da
#DDC-2664 Document new Proxy factory flags usage as of DCOM-210
...
[Document new Proxy factory flags usage as of DCOM-210](http://www.doctrine-project.org/jira/browse/DDC-2664 )
2013-09-09 10:49:37 +02:00
Marco Pivetta
87d2ff8665
Merge pull request #781 from shieldo/patch-2
...
fixed English grammar
2013-09-08 13:47:39 -07:00
Douglas Greenshields
85f227372d
fixed English grammar
2013-09-08 21:40:35 +01:00
Benjamin Eberlei
4a50493ab7
[DDC-2608][DDC-2662] Fix SequenceGenerator requiring "sequenceName" and now throw exception. Fix a bug in quoting the sequenceName.
2013-09-08 15:59:58 +02:00
Benjamin Eberlei
c6760e0375
Merge pull request #762 from naitsirch/yaml_reference_ext
...
YAML mapping documentation of uniqueConstraint
2013-09-08 06:22:42 -07:00
Benjamin Eberlei
3770019e0b
Merge branch 'DDC-2660'
2013-09-08 14:39:10 +02:00
Benjamin Eberlei
5c2157219d
[DDC-2660] Fix error with NativeSQL, ResultSetMappingBuilder and Associations as Primary Key.
2013-09-08 14:38:59 +02:00
Benjamin Eberlei
f2fa47dedb
Fix RST bug
2013-09-08 13:04:08 +02:00
Benjamin Eberlei
275724fb46
Add missing documentation for 2.4 features
2013-09-08 12:13:47 +02:00
Benjamin Eberlei
6fcc091f88
Merge branch 'DDC-2661'
2013-09-08 10:37:23 +02:00
Benjamin Eberlei
3719a6f2f2
[DDC-2661] Fix bug in YamlDriver not passing options from id to mapField()
2013-09-08 10:37:13 +02:00
Benjamin Eberlei
fab3f5e146
More excludes
2013-09-07 18:27:27 +02:00
Benjamin Eberlei
90c89b3881
Travis should prefer dist.
2013-09-07 13:21:02 +02:00
Benjamin Eberlei
6139a61ff0
New Build process
...
- Switch from Phing to Ant
- Remove PEAR packaging
- Add Composer archiving
2013-09-07 12:56:49 +02:00
Benjamin Eberlei
490b501679
Fix tests running against Oracle not comparing SQL case-insenstive
2013-09-07 08:52:50 +02:00
Guilherme Blanco
da7146c4d5
Merge pull request #779 from Blazinn/patch-4
...
Fixed grammar in custom data types
2013-09-05 07:31:19 -07:00
Guilherme Blanco
7ed22819b5
Merge pull request #778 from Blazinn/patch-3
...
Fixed typo in property mapping
2013-09-05 07:29:43 -07:00
Nick Hazen
e808865e6f
Fixed grammar in custom data types
...
Changed 'are apply' to 'are applied'
2013-09-05 10:09:53 -04:00
Nick Hazen
1d247fbeaa
Fixed typo in property mapping
...
Changed 'pecify' to 'specify' line # 246
2013-09-05 09:48:00 -04:00
Guilherme Blanco
0a07207f59
Merge pull request #777 from Blazinn/patch-2
...
Fixed typo in mapping documentation
2013-09-05 06:43:28 -07:00
Nick Hazen
982840ac3c
Fixed typo in mapping documentation
...
"Classthat" to "Class that" line #69
2013-09-05 09:32:36 -04:00
Marco Pivetta
0a9ff77303
Merge pull request #775 from Blazinn/patch-1
...
Update create bug script
2013-09-04 15:18:36 -07:00
Nick Hazen
528fe40839
Update create bug script
...
This script is using the first argument twice and ignoring the second argument completely.
2013-09-04 16:55:06 -04:00
Benjamin Eberlei
340ae15ba7
Merge branch 'Docs'
2013-09-01 19:04:22 +02:00
Benjamin Eberlei
c603fe7ab9
Simplify Working with Associations a little
2013-08-31 16:38:00 +02:00
Benjamin Eberlei
aa369b4212
Cleanup Association Mapping chapter
2013-08-31 16:25:53 +02:00
Benjamin Eberlei
cf2580d284
Cleanup of Configuration and Mapping reference chapters.
2013-08-31 15:46:10 +02:00
Guilherme Blanco
6f025f78ec
Merge pull request #772 from pine3ree/patch-1
...
DO NOT OVERRIDE CUSTOM TREE WALKERS IN getIterator()
2013-08-29 07:27:35 -07:00
Maks Feltrin
f98dfc4758
DO NOT OVERRIDE CUSTOM TREE WALKERS IN getIterator()
2013-08-29 08:36:39 +02:00
Guilherme Blanco
fc7719d5fa
Merge pull request #771 from caponica/cqb-indexby
...
Added indexBy option to createQueryBuilder
2013-08-28 20:15:55 -07:00
Christian Morgan
b0513a7517
Added indexBy option to createQueryBuilder
...
Added way to access the underlying QueryBuilder#from() method's 'indexBy' parameter when using EntityRepository#createQueryBuilder()
2013-08-28 22:35:29 +01:00
Guilherme Blanco
78c3016f95
Merge pull request #770 from fulopattila122/master
...
Fix for entity generator discriminator column
2013-08-28 09:15:08 -07:00
Attila Fulop
5669aaf4a3
Fix for entity generator discriminator column
2013-08-28 18:26:16 +03:00
Marco Pivetta
f634ba343c
Merge pull request #759 from mfdj/patch-1
...
Fixed out of sync code examples in getting-started.rst
2013-08-25 07:23:20 -07:00
Marco Pivetta
e2a67c2f1c
Merge pull request #742 from caponica/patch-2
...
Cleaned up events.rst
2013-08-25 07:10:26 -07:00
Guilherme Blanco
c399c77dbe
Merge pull request #767 from doctrine/DDC-2627
...
Fixing missing table aliases when using Many2Many persister.
2013-08-21 20:56:18 -07:00
Guilherme Blanco
09d51f9df5
Fixing missing table aliases when using Many2Many persister.
2013-08-21 23:39:40 -04:00
Guilherme Blanco
44f9952063
Merge pull request #763 from Padam87/entgenparenttrait
...
Entity generator - trait in parent class
2013-08-20 05:38:02 -07:00
Adam Prager
b041c22814
Entity generator - trait in parent class
2013-08-20 12:15:17 +02:00
Christian Stoller
a765f2e3b6
added yaml mapping documentation of uniqueConstraint
2013-08-20 11:17:04 +02:00
Guilherme Blanco
cc83ac6ce8
Centralize InputParameter SQL generation.
2013-08-19 00:33:45 -04:00
Guilherme Blanco
43fc8bafa7
DDC-1858 Added missing support to ResultVariable in LikeExpression.
2013-08-18 23:52:32 -04:00
Mark Fox
29366bb9c7
Updated require version and my earlier errors dissolved
...
As stated, the tutorial was written for 2.4.x, but the composer.json settings proffered would install 2.3.4, which has a different enough API that basic parts of the tutorial code would fail.
2013-08-17 21:15:03 -07:00
Mark Fox
c89258a0ea
fixed spelling mistake "bootsrapped"
2013-08-17 14:25:37 -07:00
Mark Fox
3405659eba
Update getting-started.rst
...
The inline cli-config.php, bootstrap.php examples were out of sync with Doctrine 2.4.x — I referenced https://github.com/doctrine/doctrine2-orm-tutorial/ for correct examples
2013-08-17 14:07:29 -07:00
Guilherme Blanco
605c32dbb3
Merge pull request #758 from doctrine/DDC-2235
...
Fixed DDC-2235.
2013-08-15 21:36:22 -07:00
Guilherme Blanco
f674445486
Fixed DDC-2235.
2013-08-16 00:07:06 -04:00
Marco Pivetta
b038e6b083
Merge pull request #757 from mnapoli/patch-3
...
Update resolve-target-entity-listener.rst
2013-08-14 04:22:50 -07:00
Matthieu Napoli
ad2ae4c4b4
Update resolve-target-entity-listener.rst
...
Another syntax highlighting fix
2013-08-14 12:14:02 +02:00
Guilherme Blanco
eaeeee7740
Merge pull request #756 from peterjmit/master
...
Make yaml/xml configuration for "AttributeOverride" and "AssociationOverride" more discoverable
2013-08-13 14:43:22 -07:00
Guilherme Blanco
6e265686ec
Merge pull request #755 from shieldo/patch-2
...
corrected English grammar in docblocks
2013-08-13 14:42:52 -07:00
Peter Mitchell
c933ac1a4a
Update override field mapping tut
...
* Added reference to override section of inheritance-mapping.rst
* Added link to yaml/xml examples in override-field-association-mappings-in-subclasses.rst
2013-08-13 16:08:42 -04:00
Douglas Greenshields
494ab1fc2b
corrected English grammar in docblocks
2013-08-13 20:45:04 +01:00
Marco Pivetta
6372e60086
Merge pull request #754 from mnapoli/patch-3
...
Fixed syntax highlighting in working-with-associations.rst
2013-08-13 05:40:48 -07:00
Matthieu Napoli
036547e956
Update working-with-associations.rst
...
Fixed syntax highlighting
2013-08-13 14:39:17 +02:00
Guilherme Blanco
7f1c1d2b4a
Fixed DDC-2506 by manually updating code. Closes PR #708 .
2013-08-13 01:07:34 -04:00
Guilherme Blanco
0ae8aa36d7
Merge pull request #753 from 51systems/master
...
JoinedSubclassPersister doesn't properly bind on some versions of php
2013-08-11 20:11:11 -07:00
Dustin Thomson
27bae51fa0
Modified executeInserts method in JoinedSubclassPersister to only check for the presence of columns in a composite primary key
2013-08-11 19:41:10 -06:00
Benjamin Eberlei
b6bf47a148
Merge pull request #716 from Lumbendil/append-paginator-tree-walker
...
Appending the Paginator tree walker hint
2013-08-10 13:02:16 -07:00
Benjamin Eberlei
acb7dfb320
Merge pull request #729 from dbu/not-lifecycle-callback-hint
...
add missing hint about lifecycle callback
2013-08-10 13:00:00 -07:00
Benjamin Eberlei
1c8fa12b64
Merge branch 'DDC-2542'
2013-08-10 17:01:13 +02:00
Roger Llopart Pla
5a7efa2895
Fixed name colision.
2013-08-10 16:58:07 +02:00
Roger Llopart Pla
e755fe7842
Added a test which verifies that the tree walkers are kept.
2013-08-10 16:58:07 +02:00
Roger Llopart Pla
1bc6140394
Added docblock.
2013-08-10 16:58:07 +02:00
Roger Llopart Pla
7f1becf283
Appending the Paginator tree walker hint, instead of removing all the other hints.
2013-08-10 16:58:07 +02:00
Benjamin Eberlei
95af021ed9
Merge pull request #737 from Koc/fix-schema-validator-master
...
Skip not mapped public properties in SchemaValidator
2013-08-10 07:27:45 -07:00
Benjamin Eberlei
610e18949b
Merge pull request #744 from jbruni/patch-1
...
Corrected PHP type for "decimal" mapping type
2013-08-10 07:23:50 -07:00
Guilherme Blanco
5f5c0ffc32
Fixing pgsql test.
2013-08-08 23:57:41 -04:00
Guilherme Blanco
7853fb8529
Merge pull request #752 from doctrine/PgSqlSchemaFix
...
ORM side fixes.
2013-08-08 19:43:53 -07:00
Guilherme Blanco
b314476599
ORM side fixes.
2013-08-08 22:01:26 -04:00
Guilherme Blanco
0cb89435b5
Merge pull request #751 from doctrine/PostLoadCanQuery
...
Added coverage for querying support during postLoad.
2013-08-08 18:57:42 -07:00
Guilherme Blanco
3ec267e8a6
Added coverage for querying support during postLoad.
2013-08-08 20:53:11 -04:00
Fabio B. Silva
0a42401a43
[DDC-2572] Fix ResolveTargetEntityListener subscription example
2013-08-08 19:13:13 -04:00
Konstantin.Myakshin
3c1fd9a3a9
Skip not mapped public properties in SchemaValidator
2013-08-07 01:18:15 +03:00
Guilherme Blanco
34b855e253
Merge pull request #748 from makhov/master
...
Add hour to DATE_ADD and DATE_SUB
2013-08-06 14:50:14 -07:00
J. Bruni
14bc65bae7
Updated EntityGeneratorTest::testEntityTypeAlias
2013-08-06 11:23:15 -03:00
amakhov
d8fcdc0c54
Add hour to DATE_ADD and DATE_SUB. Excepcion message fix
2013-08-06 12:40:30 +04:00
amakhov
dd975fe53d
Add hour to DATE_ADD and DATE_SUB
2013-08-06 12:20:22 +04:00
Marco Pivetta
97762d21a4
Merge pull request #747 from bronze1man/pr-file-mode
...
fix some file mode 755->644
2013-08-05 23:41:30 -07:00
bronze1man
97d9ba62bb
fix some file mode 755->644
2013-08-06 14:12:05 +08:00
Guilherme Blanco
094236d4e0
Merge
2013-08-06 01:49:00 -04:00
Guilherme Blanco
7ec59878a1
Added postLoad behavioral event coverage as a set of functional test.
2013-08-06 01:47:42 -04:00
Guilherme Blanco
354d7050dc
Merge pull request #720 from bakura10/fix-paginator
...
Allow to have non-distinct queries
2013-08-05 20:59:12 -07:00
Guilherme Blanco
ea44ee1d55
Merge pull request #745 from jbruni/patch-2
...
Update basic-mapping.rst
2013-08-05 20:57:26 -07:00
Guilherme Blanco
e0fd377828
Removed ticket that was breaking the build. DDC-2524 is a circular dependency that is impossible to be fixed with our current codebase.
2013-08-03 19:03:10 -04:00
Guilherme Blanco
36e7e3ccde
Updated documentation.
2013-08-03 17:40:48 -04:00
Guilherme Blanco
d9c1782a4f
Properly fixed DDC-1858. Added support for ResultVariable in NullComparisons while using HavingClause.
2013-08-03 17:38:55 -04:00
J Bruni
13c1efb240
Update basic-mapping.rst
...
The attribute name is "name", not "column", isn't it?
2013-08-03 11:26:37 -03:00
J. Bruni
15c2c4dd23
Updated EntityGeneratorTest::testEntityTypeAlias
2013-08-03 10:44:02 -03:00
J Bruni
3c613b9c02
Corrected PHP type for "decimal" mapping type
...
"Basic Mapping" documentation says:
"decimal: Type that maps a SQL DECIMAL to a PHP string."
2013-08-03 05:44:15 -03:00
Christian Morgan
c715d91dc7
Updates based on feedback from Ocramius
...
Addresses all comments made so far, except the one about persists/updates
2013-08-01 17:56:45 +01:00
Guilherme Blanco
a19106b03d
Merge pull request #731 from austinsmorris/PersistentCollection-initialize-coll
...
[DDC-2564] - PersistentCollection - initialize coll
2013-07-30 22:36:15 -07:00
Guilherme Blanco
b070676797
Merge pull request #743 from doctrine/DDC-2524
...
Added coverage to DDC-2524. Updated DDC-1719 to fix related DBAL bug.
2013-07-30 22:29:44 -07:00
Guilherme Blanco
b3d0ad7a87
Added coverage to DDC-2524. Updated DDC-1719 to fix related DBAL bug.
2013-07-31 01:24:02 -04:00
Guilherme Blanco
08e38858ed
Merge pull request #741 from doctrine/DDC-1884
...
Fixed DDC-1884.
2013-07-30 10:48:37 -07:00
Guilherme Blanco
157588f6dc
CS fixes.
2013-07-30 12:11:08 -04:00
Christian Morgan
d5bc48623a
Cleaned up events.rst
...
Was a mix-up between TestEventSubscriber and EventTest (e.g. the definition of TestEventSubscriber referenced TestEvent::preFoo, which did not exist). To clarify this I've renamed EventTest to TestEvent.
Tried to clarify the text in the Naming Convention section.
Added note that onClear is not a lifecycle callback.
Tried to clarify the definition of Lifecycle Callbacks.
Separated key/value descriptions into XML and YAML parts since the details are different
Added note in Implementing Event Listeners section that since 2.4 you do have access to EntityManager and UnitOfWork from lifecycle callbacks.
Added example about how to use the computed changeset to modify a primitive value in preUpdate section
Added naming convention example to Entity listeners class section
The other changes are typos and small fixes.
2013-07-30 14:00:17 +01:00
Guilherme Blanco
c7b4c9bf0f
Fixed DDC-1884.
2013-07-30 01:29:34 -04:00
Guilherme Blanco
0e010994a7
Merge pull request #740 from doctrine/FilterCollectionEnhancement
...
Synchronized support of FilterCollection with ODM by adding missing method
2013-07-29 18:44:10 -07:00
Guilherme Blanco
d4814dec42
Synchronized support of FilterCollection with ODM by adding missing method.
2013-07-29 21:24:08 -04:00
Guilherme Blanco
7055ccbf9b
Merge pull request #739 from FabioBatSilva/DDC-2579
...
Fix DDC-2579
2013-07-29 16:54:30 -07:00
Fabio B. Silva
1fbe1ffc5a
fix DDC-2579
2013-07-29 19:31:44 -04:00
Guilherme Blanco
a53fe14fa2
Merge pull request #717 from hackedd/patch-1
...
Allow query parameters starting with an underscore
2013-07-29 13:37:51 -07:00
Guilherme Blanco
8d13601e39
Merge pull request #738 from doctrine/VolatileQueryHydrators
...
Modified Hydrators to be per-query instances instead of a singleton-like approach
2013-07-29 08:31:38 -07:00
Guilherme Blanco
2dd73d4def
Kept BC.
2013-07-29 10:46:47 -04:00
Christian Morgan
7535e9664e
Update getting-started.rst
...
Replaced ``class::$field`` with ``class#field`` to match Doctrine style
Cleaned up three paragraphs mentioned in https://github.com/doctrine/doctrine2/pull/734
2013-07-29 10:42:10 +01:00
Guilherme Blanco
c28b457221
Modified Hydrators to be per-query instances instead of a singleton-like approach.
2013-07-28 20:30:42 -04:00
Guilherme Blanco
eea8572238
Merge pull request #735 from FabioBatSilva/fix-proxy-performance-test
...
Fix proxy performance test
2013-07-27 07:53:18 -07:00
fabios
69d4fdda1b
Fix proxy performance test
2013-07-26 17:59:50 -04:00
Christian Morgan
bc7d06fe59
Updated method documentation to use # for instance methods instead of ::
2013-07-26 22:21:27 +01:00
Christian Morgan
7bc18d7888
Cleaned up documentation
...
Cleaned up documentation, tweaked some of the grammar, changed class#method() references to class::method(), added warning about performance impact of lazy loading
2013-07-26 16:16:24 +01:00
Marco Pivetta
d7881a1ec2
Merge pull request #733 from Lumbendil/master
...
Update Parser.php
2013-07-24 04:13:12 -07:00
Roger Llopart Pla
9b574ad53b
Update Parser.php
...
Fix the docummentation for Parser::Literal()
2013-07-24 13:07:06 +02:00
Austin Morris
5fc1184a49
convert PersistentCollection functional tests to unit tests
2013-07-23 09:40:46 -04:00
Austin Morris
0083cb8ca6
remove redundant require_once for TestInit.php
2013-07-23 09:01:01 -04:00
Guilherme Blanco
6f39a426a7
Merge pull request #732 from trsteel88/patch-1
...
Update working-with-associations.rst
2013-07-22 20:22:37 -07:00
trsteel88
23cc3ea4bc
Update working-with-associations.rst
...
Always use the constant for sorting. If you use 'asc' it will not work.
2013-07-23 12:30:33 +10:00
Austin Morris
1c8ae50557
do not initialize coll on add()
2013-07-22 18:54:02 -04:00
Austin Morris
6bae2eac29
Initialize coll when using Collection methods inside PersistentCollection
2013-07-22 14:42:03 -04:00
Austin Morris
5fd844d73e
PersistentCollection - initialize coll - create failing tests
2013-07-22 14:39:00 -04:00
Marco Pivetta
4bc8f7be16
Merge pull request #728 from armetiz/patch-1
...
Color message like the update tools
2013-07-22 08:19:50 -07:00
Thomas Tourlourat
4882ff1ef5
Add info tag around ATTENTION
2013-07-22 17:11:53 +02:00
Marco Pivetta
8d2826c633
Merge pull request #730 from NicolasN/patch-1
...
To avoid "SpacingAfterParams" error with PHPCS Symfony2 coding standard
2013-07-22 02:17:53 -07:00
Nicolas Nutten
eba933bb47
To avoid "SpacingAfterParams" error with PHPCS Symfony2 coding standard
...
Hello,
I added two blank lines in comments two avoid the following error with PHPCS Symfony2 coding standard :
Error Code: SpacingAfterParams
Error Description: Last parameter comment requires a blank new line after it.
2013-07-22 10:56:18 +02:00
David Buchmann
b4e9dafd10
add missing hint about lifecycle callback
2013-07-22 10:23:47 +02:00
Thomas Tourlourat
0c3581a1f8
Color message like the update tools
2013-07-19 11:33:35 +02:00
Guilherme Blanco
fbbb161987
Merge pull request #719 from tristanlins/fix/entity-generator-extensibility
...
Access properties via static:: instead of self::.
2013-07-17 17:18:01 -07:00
Guilherme Blanco
2a5652c807
Merge pull request #723 from morganprecision/patch-1
...
Remove extra semicolon before ->setParameter() calls
2013-07-15 16:38:05 -07:00
Eugene Morgan
0a151f2474
Remove extra semicolon before ->setParameter() calls
2013-07-15 15:01:33 -05:00
Marco Pivetta
0aed9595c3
Merge pull request #721 from alex88/patch-1
...
Updated batch-processing link extension
2013-07-11 04:56:13 -07:00
Alessandro Tagliapietra
d249a22f74
Updated batch-processing link extension
...
I've changed the batch processing link adding .html else the link is broken
2013-07-11 11:52:26 +02:00
Michaël Gallego
3f112db725
Allow to have non-distinct queries
2013-07-09 17:31:30 +02:00
Guilherme Blanco
78fc129614
Merge pull request #632 from Padam87/entgentrait
...
entity generator - ignore trait properties and methods
2013-07-07 12:37:55 -07:00
Tristan Lins
641774630b
Access properties via static:: instead of self::.
...
The properties of EntityGenerator are now protected instead of private.
But this does not make sense until they are accessed with static::.
Otherwise the templates cannot be overwritten within a sub class.
2013-07-05 13:40:57 +02:00
Paul Hooijenga
b5394fc5a0
Add test for query paremeters starting with underscore
2013-07-05 09:21:50 +02:00
Roger Llopart Pla
9f2994f462
Fixed name colision.
2013-07-04 08:29:46 +00:00
Paul
6aa58d9939
Allow query parameters starting with an underscore
2013-07-04 10:12:36 +02:00
Roger Llopart Pla
91638aadcf
Added a test which verifies that the tree walkers are kept.
2013-07-03 11:18:19 +00:00
Roger Llopart Pla
981fcb2c21
Added docblock.
2013-07-03 12:24:57 +02:00
Roger Llopart Pla
90a41fba8b
Appending the Paginator tree walker hint, instead of removing all the other hints.
2013-07-03 12:14:16 +02:00
Marco Pivetta
dc2be816a8
Merge pull request #713 from dave1010/grammar-fix
...
Quick grammar fix
2013-07-02 10:20:28 -07:00
Dave Hulbert
5e700db6d3
Fix grammar in CreateCommand
2013-07-02 16:29:36 +01:00
Dave Hulbert
c57f2c39f6
Fix grammar in DropCommand
2013-07-02 16:28:58 +01:00
Adam Prager
73e2aa54ef
moved php version check
2013-06-14 10:07:05 +02:00
Torben
997f22fbb9
add shortcut for force
2013-05-20 10:06:11 +02:00
Adam Prager
bf92a40171
skip test if php 5.3
2013-04-19 14:49:32 +02:00
Adam Prager
b7b107b08a
moved test entities from sandbox
2013-04-07 16:26:05 +02:00
Adam Prager
3b7b457d35
minor fixes
2013-04-04 20:07:21 +02:00
Adam Prager
b3414e3c1a
added unit test
2013-03-31 00:47:45 +01:00
Adam Prager
937ba6385e
fixed code duplication issue
2013-03-31 00:47:24 +01:00
Benjamin Eberlei
9613f1d8cb
[DDC-93] Rename ReflectionProxy to ReflectionEmbeddedProperty, Add DQL test with Object and Array Hydration.
2013-03-27 21:45:16 +01:00
Benjamin Eberlei
879ab6e52b
[DDC-93] Show CRUD with value objects with current change tracking assumptions.
2013-03-27 07:44:47 +01:00
Adam Prager
9797177193
check if ReflectionClass::getTraits() method exists
2013-03-27 02:48:35 +01:00
Benjamin Eberlei
011776f02f
[DDC-93] Add some TODOs in code.
2013-03-27 00:18:21 +01:00
Benjamin Eberlei
0204a8b69a
[DDC-93] Implement first working version of value objects using a ReflectionProxy object, bypassing changes to UnitOfWork, Persisters and Hydrators.
2013-03-27 00:10:30 +01:00
Benjamin Eberlei
32988b3cdf
[DDC-93] Parse @Embedded and @Embeddable during SchemaTool processing to make parsing work.
2013-03-26 21:45:15 +01:00
Adam Prager
8898c91dfc
only check for traits when class exists
2013-03-26 21:28:09 +01:00
Adam Prager
8e3e2e770a
Revert "only use already existing reflections"
...
This reverts commit bb5bdcf0f4 .
2013-03-26 21:17:59 +01:00
Adam Prager
bb5bdcf0f4
only use already existing reflections
2013-03-26 21:14:52 +01:00
Benjamin Eberlei
02d34bbba6
[DDC-93] Started ValueObjectsTest
2013-03-26 20:55:55 +01:00
Adam Prager
521276f1ed
entity generator - ignore trait properties and methods
2013-03-26 20:52:57 +01:00
Johannes M. Schmitt
b4b9709090
adds a new output format
2013-03-03 11:01:43 +01:00