doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-23 22:42:18 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #5570] Fix PrePersist EventListener when using merge instead of persist #9648

New Issue
Open
opened 2026-01-22 16:04:58 +01:00 by admin · 0 comments
admin commented 2026-01-22 16:04:58 +01:00
Owner
Copy Link

Original Pull Request: https://github.com/doctrine/orm/pull/5570

State: closed
Merged: No

The merge operation trigger PRE_PERSIST & POST_PERSIST events when we merge a new entity.

The bug that I encounter, is that the PRE_PERSIST event is trigger with the managed copy empty ! I that case my event listener can't access original data.

In order to fix this, I firstly merge entity state into managed copy. I think this is not the best move as it will be copied a second time at line 1888.

I tried to persist after this is done, but it break some unit tests.

**Original Pull Request:** https://github.com/doctrine/orm/pull/5570 **State:** closed **Merged:** No --- The merge operation trigger PRE_PERSIST & POST_PERSIST events when we merge a new entity. The bug that I encounter, is that the PRE_PERSIST event is trigger with the managed copy empty ! I that case my event listener can't access original data. In order to fix this, I firstly merge entity state into managed copy. I think this is not the best move as it will be copied a second time at line 1888. I tried to persist after this is done, but it break some unit tests.
admin added the pull-request label 2026-01-22 16:04:58 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#9648
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?