mirror of
https://github.com/doctrine/orm.git
synced 2026-03-23 22:42:18 +01:00
DDC-1148: [Patch] Auto infer parameter type in DQL #1443
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @doctrinebot on GitHub (May 11, 2011).
Originally assigned to: @guilhermeblanco on GitHub.
Jira issue originally created by user @guilhermeblanco:
Here is the patch:
http://pastie.org/1891023
http://pastie.org/1891030
@doctrinebot commented on GitHub (May 12, 2011):
Comment created by @beberlei:
instanceof DateTimeZone is just wrong. drop that whole branch, TZ only saves the timezone from a DateTime object, infering TYPE::DECIMAL sounds dangerous to me, i would drop that one aswell. The array check has a bug, you call key() and then do nothing with the $key instaed check is_integer on the $value again, which is always an array from the previous check.
@doctrinebot commented on GitHub (May 12, 2011):
Comment created by @beberlei:
I thought you wanted to infer the types from the left hand sides of the DQL conditions?
@doctrinebot commented on GitHub (May 13, 2011):
Comment created by @guilhermeblanco:
Implemented:
8e3fdc5adc@doctrinebot commented on GitHub (May 13, 2011):
Issue was closed with resolution "Fixed"