[PR #885] [MERGED] Add support for ManyToMany Criteria #8852

New Issue

admin · 2026-01-22T16:01:59+01:00

admin commented

2026-01-22 16:01:59 +01:00

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/885
Author: @bakura10
Created: 12/22/2013
Status: ✅ Merged
Merged: 3/16/2014
Merged by: @guilhermeblanco

Base: master ← Head: criteria-many-to-many

📝 Commits (10+)

160b07d Rebase to master
07654dd Revert tab changes
738cc25 Revert docblock
9385a60 Fix wrong logic
be39afa Add method to interface
bb1f71f Fix docblock
c69b756 Remove useless exception
fbbe922 Fix tests
e5ba286 fallback to persister count
a55f2c4 Fix test

📊 Changes

7 files changed (+169 additions, -28 deletions)

View changed files

📝 lib/Doctrine/ORM/Cache/Persister/AbstractCollectionPersister.php (+9 -0)
📝 lib/Doctrine/ORM/PersistentCollection.php (+4 -2)
📝 lib/Doctrine/ORM/Persisters/AbstractCollectionPersister.php (+10 -1)
📝 lib/Doctrine/ORM/Persisters/CollectionPersister.php (+11 -0)
📝 lib/Doctrine/ORM/Persisters/ManyToManyPersister.php (+111 -24)
📝 tests/Doctrine/Tests/ORM/Cache/Persister/AbstractCollectionPersisterTest.php (+2 -1)
📝 tests/Doctrine/Tests/ORM/Functional/ManyToManyBasicAssociationTest.php (+22 -0)

📄 Description

This replaces https://github.com/doctrine/doctrine2/pull/773

It adds support for ManyToMany but also do an efficient filtering instead of loading the whole collection. I think it can also benefits from https://github.com/doctrine/doctrine2/pull/882 when this one get merged.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/885 **Author:** [@bakura10](https://github.com/bakura10) **Created:** 12/22/2013 **Status:** ✅ Merged **Merged:** 3/16/2014 **Merged by:** [@guilhermeblanco](https://github.com/guilhermeblanco) **Base:** `master` ← **Head:** `criteria-many-to-many` --- ### 📝 Commits (10+) - [`160b07d`](https://github.com/doctrine/orm/commit/160b07d1e3107b9a8210fc73d456305b03146c39) Rebase to master - [`07654dd`](https://github.com/doctrine/orm/commit/07654ddd3f5940283248d05482b695828ba70413) Revert tab changes - [`738cc25`](https://github.com/doctrine/orm/commit/738cc250f83dcb6df70797ae092424a821435e2c) Revert docblock - [`9385a60`](https://github.com/doctrine/orm/commit/9385a600cfa363d3613ef5ba2f84c1078b474026) Fix wrong logic - [`be39afa`](https://github.com/doctrine/orm/commit/be39afa2f484aefb136e83afcbb164ff83bf0f4a) Add method to interface - [`bb1f71f`](https://github.com/doctrine/orm/commit/bb1f71f1f9429bdbb3f0595352df383d8b4173cd) Fix docblock - [`c69b756`](https://github.com/doctrine/orm/commit/c69b7562ab2f43d674fb73817dee27f6ec147c60) Remove useless exception - [`fbbe922`](https://github.com/doctrine/orm/commit/fbbe922cb636d56230773df8d2d09b6490021b96) Fix tests - [`e5ba286`](https://github.com/doctrine/orm/commit/e5ba28676d535f70ab136a5b06be69de9e46c433) fallback to persister count - [`a55f2c4`](https://github.com/doctrine/orm/commit/a55f2c48cac3ebadf36dd3cdbe6714ff7c51035f) Fix test ### 📊 Changes **7 files changed** (+169 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/Cache/Persister/AbstractCollectionPersister.php` (+9 -0) 📝 `lib/Doctrine/ORM/PersistentCollection.php` (+4 -2) 📝 `lib/Doctrine/ORM/Persisters/AbstractCollectionPersister.php` (+10 -1) 📝 `lib/Doctrine/ORM/Persisters/CollectionPersister.php` (+11 -0) 📝 `lib/Doctrine/ORM/Persisters/ManyToManyPersister.php` (+111 -24) 📝 `tests/Doctrine/Tests/ORM/Cache/Persister/AbstractCollectionPersisterTest.php` (+2 -1) 📝 `tests/Doctrine/Tests/ORM/Functional/ManyToManyBasicAssociationTest.php` (+22 -0) </details> ### 📄 Description This replaces https://github.com/doctrine/doctrine2/pull/773 It adds support for ManyToMany but also do an efficient filtering instead of loading the whole collection. I think it can also benefits from https://github.com/doctrine/doctrine2/pull/882 when this one get merged. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-22 16:01:59 +01:00

admin closed this issue

2026-01-22 16:02:00 +01:00

admin referenced this issue

2026-01-22 16:10:03 +01:00

[PR #8852] Remove possibility to extend the doctrine mapping xml schema with anything #11211

Sign in to join this conversation.