doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-23 22:42:18 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #518] [MERGED] regression fix for left joins (double ON) #8321

New Issue
Closed
opened 2026-01-22 15:59:22 +01:00 by admin · 0 comments
admin commented 2026-01-22 15:59:22 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/518
Author: @fran6co
Created: 11/20/2012
Status: ✅ Merged
Merged: 11/25/2012
Merged by: @beberlei

Base: master ← Head: fix-double-on

📝 Commits (2)

  • 9c59ed5 regression fix for left joins (double ON)
  • c840995 added outer left join

📊 Changes

2 files changed (+6 additions, -1 deletions)

View changed files

📝 lib/Doctrine/ORM/Query/SqlWalker.php (+1 -1)
📝 tests/Doctrine/Tests/ORM/Query/SelectSqlGenerationTest.php (+5 -0)

📄 Description

Before bbf092c6fd this was working fine

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/518 **Author:** [@fran6co](https://github.com/fran6co) **Created:** 11/20/2012 **Status:** ✅ Merged **Merged:** 11/25/2012 **Merged by:** [@beberlei](https://github.com/beberlei) **Base:** `master` ← **Head:** `fix-double-on` --- ### 📝 Commits (2) - [`9c59ed5`](https://github.com/doctrine/orm/commit/9c59ed5891e94abeff7088c148fc05f6069325fd) regression fix for left joins (double ON) - [`c840995`](https://github.com/doctrine/orm/commit/c84099508f8d245f63f28ed44a53ff6cde8b1d0c) added outer left join ### 📊 Changes **2 files changed** (+6 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/Query/SqlWalker.php` (+1 -1) 📝 `tests/Doctrine/Tests/ORM/Query/SelectSqlGenerationTest.php` (+5 -0) </details> ### 📄 Description Before bbf092c6fd04779cb792ef30af15a1dc68f5ebd9 this was working fine --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
admin added the pull-request label 2026-01-22 15:59:22 +01:00
admin closed this issue 2026-01-22 15:59:23 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#8321
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?