[PR #848] [CLOSED] eliminate duplicate placeholders in "walkComparison" function within Que... #8799

New Issue

admin · 2026-01-22T16:01:46+01:00

admin commented

2026-01-22 16:01:46 +01:00

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/848
Author: @bsahlhof
Created: 11/18/2013
Status: ❌ Closed

Base: master ← Head: patch-1

📝 Commits (1)

baf7645 eliminate duplicate placeholders in "walkComparison" function within QueryExpressionVisitor

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 lib/Doctrine/ORM/Query/QueryExpressionVisitor.php (+1 -1)

📄 Description

...ryExpressionVisitor

I've run into an issue when using Criteria with QueryBuilder when Criteria uses multiple checks on same variable in different context, example:
field1 = value OR (field1 in values AND field2 = true)... what happens is field 1 placeholder is duplicated, and an error occures in code complaining about invalid # of parameters. The fix eliminates this issue, making sure parametername is unique.

I have not had time to check any other possible issues this may cause, but a review of the code doesn't appear to impact any other function.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/848 **Author:** [@bsahlhof](https://github.com/bsahlhof) **Created:** 11/18/2013 **Status:** ❌ Closed **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`baf7645`](https://github.com/doctrine/orm/commit/baf7645f790ba9c7132a3cf254e062f84cec171c) eliminate duplicate placeholders in "walkComparison" function within QueryExpressionVisitor ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/Query/QueryExpressionVisitor.php` (+1 -1) </details> ### 📄 Description ...ryExpressionVisitor I've run into an issue when using Criteria with QueryBuilder when Criteria uses multiple checks on same variable in different context, example: field1 = value OR (field1 in values AND field2 = true)... what happens is field 1 placeholder is duplicated, and an error occures in code complaining about invalid # of parameters. The fix eliminates this issue, making sure parametername is unique. I have not had time to check any other possible issues this may cause, but a review of the code doesn't appear to impact any other function. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-22 16:01:46 +01:00

admin referenced this issue

2026-01-22 16:09:57 +01:00

[PR #8799] Combine consecutive issets and unsets #11180

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#8799