[PR #852] [CLOSED] Fixes column name yaml mapping #8798

Closed
opened 2026-01-22 16:01:46 +01:00 by admin · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/852
Author: @jfsimon
Created: 11/20/2013
Status: Closed

Base: masterHead: yaml-mapping-fix


📝 Commits (2)

  • d3b04fa fixed basic yaml mapping doc
  • 159db02 added name support to yaml field mapping

📊 Changes

2 files changed (+6 additions, -2 deletions)

View changed files

📝 docs/en/reference/basic-mapping.rst (+2 -2)
📝 lib/Doctrine/ORM/Mapping/Driver/YamlDriver.php (+4 -0)

📄 Description

Documentation about YAML field column name mapping is wrong:

  • the doc says that name attribute defines column name;
  • the code uses column as column name definition attribute.

This PR fixes documentation and adds name attribute supports to YAML field mapping.

Note that XML and annotations are using name attribute, then I think YAML should use it too. Feel free to tell me if I should remove one of these two commits.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/852 **Author:** [@jfsimon](https://github.com/jfsimon) **Created:** 11/20/2013 **Status:** ❌ Closed **Base:** `master` ← **Head:** `yaml-mapping-fix` --- ### 📝 Commits (2) - [`d3b04fa`](https://github.com/doctrine/orm/commit/d3b04fae448d061da8fab810430079b7667c315f) fixed basic yaml mapping doc - [`159db02`](https://github.com/doctrine/orm/commit/159db027c868ee2a65525d72e1f91305c860f7de) added name support to yaml field mapping ### 📊 Changes **2 files changed** (+6 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `docs/en/reference/basic-mapping.rst` (+2 -2) 📝 `lib/Doctrine/ORM/Mapping/Driver/YamlDriver.php` (+4 -0) </details> ### 📄 Description Documentation about YAML field column name mapping is wrong: - the doc says that `name` attribute defines column name; - the code uses `column` as column name definition attribute. This PR fixes documentation and adds `name` attribute supports to YAML field mapping. Note that XML and annotations are using `name` attribute, then I think YAML should use it too. Feel free to tell me if I should remove one of these two commits. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
admin added the pull-request label 2026-01-22 16:01:46 +01:00
admin closed this issue 2026-01-22 16:01:46 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#8798