isNull criteria doesn't work #6239

New Issue

admin · 2026-01-22T15:29:25+01:00

admin commented

2026-01-22 15:29:25 +01:00

Originally created by @BenWaNH on GitHub (May 22, 2019).

Originally assigned to: @BenWaNH on GitHub.

Hi,

i've an issue with isNull method from Expression class

this is an example i use in my entity :

public function getValidDiscountOffers(): Collection
{

        $expr = Criteria::expr();
        $criteria = Criteria::create()
            ->where($expr->eq('active', true))
            ->andWhere($expr->isNull('validityStart'))
        ;
        return $this->discountOffers->matching($criteria);
}

And this is the result SQL from log :

WHERE t.user_id = ? AND te.active = ? [145,false] []

No trace about IS NULL
And If i try to replace my validityStart variable by another whose doesn't exist, no error returned
But if i replace isNull method by eq method an error is trigger ... It seems to skip my expression when isNull...

Thanks for reading
BenWa

Originally created by @BenWaNH on GitHub (May 22, 2019). Originally assigned to: @BenWaNH on GitHub. Hi, i've an issue with isNull method from Expression class this is an example i use in my entity : ``` public function getValidDiscountOffers(): Collection { $expr = Criteria::expr(); $criteria = Criteria::create() ->where($expr->eq('active', true)) ->andWhere($expr->isNull('validityStart')) ; return $this->discountOffers->matching($criteria); } ``` And this is the result SQL from log : > WHERE t.user_id = ? AND te.active = ? [145,false] [] No trace about IS NULL And If i try to replace my validityStart variable by another whose doesn't exist, no error returned But if i replace isNull method by eq method an error is trigger ... It seems to skip my expression when isNull... Thanks for reading BenWa

admin added the Bug Missing Tests labels 2026-01-22 15:29:25 +01:00

admin closed this issue

2026-01-22 15:29:25 +01:00

admin commented

2026-01-22 15:29:26 +01:00

@Ocramius commented on GitHub (May 22, 2019):

@BenWaNH would you be able to write a test case that reproduces this issue? See https://github.com/doctrine/doctrine2/tree/master/tests/Doctrine/Tests/ORM/Functional/Ticket for examples.

@Ocramius commented on GitHub (May 22, 2019): @BenWaNH would you be able to write a test case that reproduces this issue? See https://github.com/doctrine/doctrine2/tree/master/tests/Doctrine/Tests/ORM/Functional/Ticket for examples.

admin commented

2026-01-22 15:29:26 +01:00

@BenWaNH commented on GitHub (May 22, 2019):

Yes, I will write it next week. I have to stay my time for this week and I will use the filter in the meantime.
Thanks

@BenWaNH commented on GitHub (May 22, 2019): Yes, I will write it next week. I have to stay my time for this week and I will use the filter in the meantime. Thanks

admin commented

2026-01-22 15:29:26 +01:00

@thicolares commented on GitHub (Oct 20, 2019):

Hey @BenWaNH , I've created a test case for that, but I was not able to reproduce the error (version 2.7). Looks good to me. I took the opportunity to create a functional test that demonstrates that. See #7874.

If so, maybe we could close this issue.

@thicolares commented on GitHub (Oct 20, 2019): Hey @BenWaNH , I've created a test case for that, but I was not able to reproduce the error (version 2.7). Looks good to me. I took the opportunity to create a functional test that demonstrates that. See #7874. If so, maybe we could close this issue.

admin commented

2026-01-22 15:29:27 +01:00

@hason commented on GitHub (Mar 18, 2020):

@thicolares This issue is valid for ManyToManyPersister and SqlValueVisitor https://github.com/doctrine/orm/blob/master/lib/Doctrine/ORM/Persisters/SqlValueVisitor.php#L32-L36

@hason commented on GitHub (Mar 18, 2020): @thicolares This issue is valid for ManyToManyPersister and SqlValueVisitor https://github.com/doctrine/orm/blob/master/lib/Doctrine/ORM/Persisters/SqlValueVisitor.php#L32-L36

admin commented

2026-01-22 15:29:27 +01:00

@ndench commented on GitHub (Aug 28, 2020):

I can confirm that this issue exists for ManyToMany relationships but not for ManyToOne relationships.
Our entity model looks like this:

Organisation:
    - OneToMany TemplateTypes
Template:
    - ManyToMany TemplateTypes
TemplateType:
    - ManyToOne Organisation
    - ManyToMany Template
    - ?DateTime archivedAt

Doing a Criteria::expr()->isNull('archivedAt') on Organisation::templateTypes correctly filters out archived TemplateTypes.

Doing a Criteria::expr()->isNull('archivedAt') on Template::templateTypes when templateTypes is uninitialized does not filter correctly because archived_at IS NULL is left off the SQL query.

However, if templateTypes is initialized, then Criteria uses array_filter and it works as expected.

So the issue is only present when calling PersistentCollection::matching with an uninitialized collection with an many to many association.

@ndench commented on GitHub (Aug 28, 2020): I can confirm that this issue exists for ManyToMany relationships but not for ManyToOne relationships. Our entity model looks like this: ``` Organisation: - OneToMany TemplateTypes Template: - ManyToMany TemplateTypes TemplateType: - ManyToOne Organisation - ManyToMany Template - ?DateTime archivedAt ``` Doing a `Criteria::expr()->isNull('archivedAt')` on `Organisation::templateTypes` correctly filters out archived TemplateTypes. Doing a `Criteria::expr()->isNull('archivedAt')` on `Template::templateTypes` when `templateTypes` is uninitialized does not filter correctly because `archived_at IS NULL` is left off the SQL query. However, if `templateTypes` is initialized, then Criteria uses `array_filter` and it works as expected. So the issue is only present when calling `PersistentCollection::matching` with an uninitialized collection with an many to many association.

admin commented

2026-01-22 15:29:27 +01:00

@ndench commented on GitHub (Dec 22, 2021):

For anyone else who stumbles across this, I've been manually filtering these as a workaround:

- $this->templateTypes->matching(Criteria::create()->andWhere(Criteria::expr()->isNull('archivedAt')));
+ $this->templateTypes->filter(fn (TemplatType $type) => null === $type->getArchivedAt());

@ndench commented on GitHub (Dec 22, 2021): For anyone else who stumbles across this, I've been manually filtering these as a workaround: ```diff - $this->templateTypes->matching(Criteria::create()->andWhere(Criteria::expr()->isNull('archivedAt'))); + $this->templateTypes->filter(fn (TemplatType $type) => null === $type->getArchivedAt()); ```

admin commented

2026-01-22 15:29:27 +01:00

@MatTheCat commented on GitHub (Mar 21, 2023):

Just got hit by this one while calling matching on a lazy (happens with both LAZY or EXTRA_LAZY) collection.

BTW this issue seems to duplicate https://github.com/doctrine/orm/issues/5587 and https://github.com/doctrine/orm/issues/5827

@MatTheCat commented on GitHub (Mar 21, 2023): Just got hit by this one while calling `matching` on a lazy (happens with both `LAZY` or `EXTRA_LAZY`) collection. BTW this issue seems to duplicate https://github.com/doctrine/orm/issues/5587 and https://github.com/doctrine/orm/issues/5827

admin referenced this issue

2026-01-22 16:05:49 +01:00

[PR #6239] Travis update #9915

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#6239