mirror of
https://github.com/doctrine/orm.git
synced 2026-03-23 22:42:18 +01:00
Consider PHP 7.2 for ORM.NEXT #5591
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Majkl578 on GitHub (Jun 27, 2017).
Primary motivation:
As an example, here's how EntityManagerInterface would look for 7.2. ☺️
PHP 7.2 is due to release before the end of year. There's already alpha 2 (without object typehint - should arrive in alpha 3 / beta 1).
Thoughts?
@Ocramius commented on GitHub (Jun 27, 2017):
I think this is more than feasible, and yes, it would allow us to add type hints to interfaces without breaking existing implementations. We just need to enforce the PHP constraint to be
^7.2there.Overall 👍
@alcaeus commented on GitHub (Jun 27, 2017):
FWIW, ODM ng (the upcoming 2.0 version) will most likely also require PHP 7.2, so we could let this change trickle down to the common libraries as well.
@Majkl578 commented on GitHub (Jul 6, 2017):
Initial Doctrine\Common 7.2 migration (for v. 3.x) here: https://github.com/doctrine/common/pull/805
@Majkl578 commented on GitHub (Jul 22, 2017):
PHP 7.2 is now BETA and Travis added support for it. 🎉
@eman1986 commented on GitHub (Aug 15, 2017):
this would be problematic for those who just got PHP 7 support, not everyone is on bleeding edge, just a thought.
@alcaeus commented on GitHub (Aug 15, 2017):
That is ok. If they are not on bleeding edge php, they most likely won’t want to be on bleeding edge ORM either.
@Ocramius commented on GitHub (Aug 15, 2017):
Pretty much what @alcaeus said: if you are developing new software, the target stable version should be the current one. If you are maintaining existing software, you are perfectly ok with using stable dependencies that won't get new shiny features, yet will receive security updates.
@eman1986 commented on GitHub (Aug 15, 2017):
True, though some people are stuck on web hosts that restrict their version. My webhost just got me on PHP 7, and they probably won't have 7.1 until next year. I'd love to work with 7.1, but my production environment prevents that unfortunately and I don't feel like babysitting my own server.
@Ocramius commented on GitHub (Aug 15, 2017):
That's perfectly ok, but on the counter side, we aren't babysitting your
hosting provider either
On 15 Aug 2017 7:54 PM, "Ed Lomonaco" notifications@github.com wrote:
True, though some people are stuck on web hosts that restrict their
version. My webhost just got me on PHP 7, and they probably won't have 7.1
until next year. I'd love to work with 7.1, but my production environment
prevents that unfortunately and I don't feel like babysitting my own server.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/doctrine/doctrine2/issues/6529#issuecomment-322540095,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJakMly0bmvET0FPQALz9QruzfNfwDsks5sYdtmgaJpZM4OGEyg
.
@eman1986 commented on GitHub (Aug 16, 2017):
fair enough, I said my piece :)
@Majkl578 commented on GitHub (Nov 30, 2017):
Merged into develop in 9f5fd3713fa0c8f34a47519ea78d2a6337d65a22.