[PR #999] [MERGED] DDC-3065 null value in in criteria support #9019

Open
opened 2026-01-22 16:02:48 +01:00 by admin · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/999
Author: @Ocramius
Created: 4/3/2014
Status: Merged
Merged: 4/21/2014
Merged by: @guilhermeblanco

Base: masterHead: hotfix/DDC-3065-null-value-in-in-criteria-support


📝 Commits (5)

  • f2f571e DDC-3065 - failing test - IN()-alike criteria should support NULL search values
  • f54d615 DDC-3065 - hardening test - should support multiple values in IN(), also NULL ones
  • eb64985 DDC-3065 - splitting tests and checking multiple values support
  • a8b9680 DDC-3065 - persister tests for criteria containing NULL values in IN() conditions
  • 733102b DDC-3065 - applying hotfix that allows NULL in IN() criteria

📊 Changes

3 files changed (+122 additions, -1 deletions)

View changed files

📝 lib/Doctrine/ORM/Persisters/BasicEntityPersister.php (+7 -1)
📝 tests/Doctrine/Tests/ORM/Functional/EntityRepositoryTest.php (+84 -0)
📝 tests/Doctrine/Tests/ORM/Persisters/BasicEntityPersisterTypeValueSqlTest.php (+31 -0)

📄 Description

See DDC-3065 (http://www.doctrine-project.org/jira/browse/DDC-3065)

This MAY be a breakage, since the following API now works as expected:

$repository->findBy(['fieldName' => [null]]);
$repository->findBy(['fieldName' => [123, null]]);

Where before, null was just ignored


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/999 **Author:** [@Ocramius](https://github.com/Ocramius) **Created:** 4/3/2014 **Status:** ✅ Merged **Merged:** 4/21/2014 **Merged by:** [@guilhermeblanco](https://github.com/guilhermeblanco) **Base:** `master` ← **Head:** `hotfix/DDC-3065-null-value-in-in-criteria-support` --- ### 📝 Commits (5) - [`f2f571e`](https://github.com/doctrine/orm/commit/f2f571e4aba340bfb07ad2296d1e4a1ab82d0c35) DDC-3065 - failing test - IN()-alike criteria should support NULL search values - [`f54d615`](https://github.com/doctrine/orm/commit/f54d6157f44ea1cdecede9bcd3f48cc5cb04b065) DDC-3065 - hardening test - should support multiple values in IN(), also NULL ones - [`eb64985`](https://github.com/doctrine/orm/commit/eb6498544f7c0689ea3f146d21b7b8710ba97709) DDC-3065 - splitting tests and checking multiple values support - [`a8b9680`](https://github.com/doctrine/orm/commit/a8b96803a4d8e994129aaa411c81661c3da16e2a) DDC-3065 - persister tests for criteria containing `NULL` values in `IN()` conditions - [`733102b`](https://github.com/doctrine/orm/commit/733102b4a109c0bb8ca026b1dbbadaa9bb62ae70) DDC-3065 - applying hotfix that allows `NULL` in `IN()` criteria ### 📊 Changes **3 files changed** (+122 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/Persisters/BasicEntityPersister.php` (+7 -1) 📝 `tests/Doctrine/Tests/ORM/Functional/EntityRepositoryTest.php` (+84 -0) 📝 `tests/Doctrine/Tests/ORM/Persisters/BasicEntityPersisterTypeValueSqlTest.php` (+31 -0) </details> ### 📄 Description See DDC-3065 (http://www.doctrine-project.org/jira/browse/DDC-3065) This _MAY_ be a breakage, since the following API now works as expected: ``` php $repository->findBy(['fieldName' => [null]]); $repository->findBy(['fieldName' => [123, null]]); ``` Where before, `null` was just ignored --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
admin added the pull-request label 2026-01-22 16:02:48 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#9019