[PR #5796] Catch Throwable instead of just catching Exception #9730

New Issue

admin · 2026-01-22T16:05:14+01:00

admin commented

2026-01-22 16:05:14 +01:00

Original Pull Request: https://github.com/doctrine/orm/pull/5796

State: closed
Merged: No

Several code blocks have a catch-all catch (\Exception) { ... }. This is OK in PHP 5, but not sufficient in PHP 7, as the new base interface is Throwable, and catching Exception does not catch Error instances.

This PR catches Throwable by default, then catches Exception for PHP 5. The fact that Throwable is not defined in PHP 5 is not a problem in a catch block.

This leads to a bit of code duplication, but there's not much we can do to avoid this I'm afraid.

**Original Pull Request:** https://github.com/doctrine/orm/pull/5796 **State:** closed **Merged:** No --- Several code blocks have a catch-all `catch (\Exception) { ... }`. This is OK in PHP 5, but not sufficient in PHP 7, as the new base interface is `Throwable`, and catching `Exception` does not catch `Error` instances. This PR catches `Throwable` by default, then catches `Exception` for PHP 5. The fact that `Throwable` is not defined in PHP 5 is not a problem in a catch block. This leads to a bit of code duplication, but there's not much we can do to avoid this I'm afraid.

admin added the pull-request label 2026-01-22 16:05:14 +01:00

admin referenced this issue

2026-01-22 16:12:03 +01:00

[PR #9730] Forward compatibility with DBAL 4 #11833

Sign in to join this conversation.