[PR #448] [MERGED] Fixed Parser problem for SELECT (((3))) as .... #8213

New Issue

admin · 2026-01-22T15:58:54+01:00

admin commented

2026-01-22 15:58:54 +01:00

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/448
Author: @stefanklug
Created: 9/18/2012
Status: ✅ Merged
Merged: 11/3/2012
Merged by: @guilhermeblanco

Base: master ← Head: master-parserFix

📝 Commits (4)

d344407 added test case
6ccf7a7 fixed Parser which incorrectly treated ((( as function
1e1f34f cleanup ScalarExpression
bf54c22 removed unneded variable

📊 Changes

2 files changed (+48 additions, -37 deletions)

View changed files

📝 lib/Doctrine/ORM/Query/Parser.php (+43 -37)
📝 tests/Doctrine/Tests/ORM/Query/LanguageRecognitionTest.php (+5 -0)

📄 Description

Hi this is the old PR https://github.com/doctrine/doctrine2/pull/438 ported to master.
I had to modify more than I expected to get it to work properly.

I had to apply some modifications to Parser::ScalarExpression and would like to discuss the desired coding style. After my modifications Parser::ScalarExpression looks a bit more like Parser::SelectExpression, but I don't know your preferred style.

I think there is some more cleanup we could apply to ScalarExpression, but I'd like to get some feedback first.

Stefan

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/448 **Author:** [@stefanklug](https://github.com/stefanklug) **Created:** 9/18/2012 **Status:** ✅ Merged **Merged:** 11/3/2012 **Merged by:** [@guilhermeblanco](https://github.com/guilhermeblanco) **Base:** `master` ← **Head:** `master-parserFix` --- ### 📝 Commits (4) - [`d344407`](https://github.com/doctrine/orm/commit/d3444076367c27d3bd41bd0cffe6432f5fa92cd5) added test case - [`6ccf7a7`](https://github.com/doctrine/orm/commit/6ccf7a7ac704242a5adef43695e4f35c2f9542c0) fixed Parser which incorrectly treated ((( as function - [`1e1f34f`](https://github.com/doctrine/orm/commit/1e1f34f9cb733a708e57fb8e5d5797a011a663af) cleanup ScalarExpression - [`bf54c22`](https://github.com/doctrine/orm/commit/bf54c22cd9ec731c93fb2ef2af2a2a12ee9a3e50) removed unneded variable ### 📊 Changes **2 files changed** (+48 additions, -37 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/Query/Parser.php` (+43 -37) 📝 `tests/Doctrine/Tests/ORM/Query/LanguageRecognitionTest.php` (+5 -0) </details> ### 📄 Description Hi this is the old PR https://github.com/doctrine/doctrine2/pull/438 ported to master. I had to modify more than I expected to get it to work properly. I had to apply some modifications to Parser::ScalarExpression and would like to discuss the desired coding style. After my modifications Parser::ScalarExpression looks a bit more like Parser::SelectExpression, but I don't know your preferred style. I think there is some more cleanup we could apply to ScalarExpression, but I'd like to get some feedback first. Stefan --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-22 15:58:54 +01:00

admin referenced this issue

2026-01-22 16:08:56 +01:00

[PR #8213] Fix: Typo #10863

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#8213