doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-23 22:42:18 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #6037] Added test for filtered eager joins #9826

New Issue
Open
opened 2026-01-22 16:05:32 +01:00 by admin · 0 comments
admin commented 2026-01-22 16:05:32 +01:00
Owner
Copy Link

Original Pull Request: https://github.com/doctrine/orm/pull/6037

State: closed
Merged: No

An SQLFilter is not called on collections with eager loading enabled. This PR contains a unit-test that shows the problem.

If I have

  • an order
  • with a product
  • and the product has a list of features
  • where the feature collection has fetch="EAGER" enabled
  • and only visible feature should be shown (enforced by an enabled SQLFilter).

then invisible features are still retrieved from the database!

This PR only contains a unit-test that shows the problem. The test passes if fetch="EAGER" is removed.

**Original Pull Request:** https://github.com/doctrine/orm/pull/6037 **State:** closed **Merged:** No --- An `SQLFilter` is not called on collections with eager loading enabled. This PR contains a unit-test that shows the problem. If I have - an order - with a product - and the product has a list of features - where the feature collection has `fetch="EAGER"` enabled - and only visible feature should be shown (enforced by an enabled `SQLFilter`). then invisible features are still retrieved from the database! This PR only contains a unit-test that shows the problem. The test passes if `fetch="EAGER"` is removed.
admin added the pull-request label 2026-01-22 16:05:32 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#9826
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?