doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-23 22:42:18 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #1008] [CLOSED] DDC-3078 SLC Cache interface ctor removal #9027

New Issue
Open
opened 2026-01-22 16:02:52 +01:00 by admin · 0 comments
admin commented 2026-01-22 16:02:52 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/1008
Author: @Ocramius
Created: 4/10/2014
Status: ❌ Closed

Base: master ← Head: hotfix/DDC-3078-slc-cache-interface-ctor-removal

📝 Commits (10+)

  • f63e755 DDC-3078 - constructor should never be interfaced
  • 96e1919 DDC-3078 - adding exception methods for invalid cache instantiator
  • d602e3d DDC-3078 - adding API for cache instantiation to the configuration object
  • 6b9e67a DDC-3078 - cache configuration tests for the newly introduced API for cache instantiators
  • c56e923 DDC-3078 - removing tests for cache class setter/getter on cache configuration
  • 11e17e7 DDC-3078 - switching cache initialization to use cache instantiator from config
  • 37aa3e8 DDC-3078 - removing cache class name setter/getter from cache configuration API
  • b384075 DDC-3078 - removing unused cache class name invalidity exception methods
  • 00ab465 DDC-3078 - using an explicit CacheInstantiator interface to replace callable cache instantiators
  • ba7094e DDC-3078 - providing a default cache instantiator implementation

📊 Changes

8 files changed (+139 additions, -43 deletions)

View changed files

📝 lib/Doctrine/ORM/Cache.php (+0 -7)
📝 lib/Doctrine/ORM/Cache/CacheConfiguration.php (+8 -17)
➕ lib/Doctrine/ORM/Cache/CacheInstantiator.php (+41 -0)
➕ lib/Doctrine/ORM/Cache/DefaultCacheInstantiator.php (+41 -0)
📝 lib/Doctrine/ORM/EntityManager.php (+1 -2)
📝 lib/Doctrine/ORM/ORMException.php (+0 -10)
📝 tests/Doctrine/Tests/ORM/Cache/CacheConfigTest.php (+19 -7)
➕ tests/Doctrine/Tests/ORM/Cache/DefaultCacheInstantiatorTest.php (+29 -0)

📄 Description

See DDC-3078 ( http://www.doctrine-project.org/jira/browse/DDC-3078 ) - the cache interface should NOT cover a constructor.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/1008 **Author:** [@Ocramius](https://github.com/Ocramius) **Created:** 4/10/2014 **Status:** ❌ Closed **Base:** `master` ← **Head:** `hotfix/DDC-3078-slc-cache-interface-ctor-removal` --- ### 📝 Commits (10+) - [`f63e755`](https://github.com/doctrine/orm/commit/f63e7555b3be245b69b607784cddeb0b2ebdc9d1) DDC-3078 - constructor should never be interfaced - [`96e1919`](https://github.com/doctrine/orm/commit/96e1919bcf069b51a76f6251a0b28fd30b2e9a25) DDC-3078 - adding exception methods for invalid cache instantiator - [`d602e3d`](https://github.com/doctrine/orm/commit/d602e3d359bd88bf1c118d1fd3c9d93b0da08e3e) DDC-3078 - adding API for cache instantiation to the configuration object - [`6b9e67a`](https://github.com/doctrine/orm/commit/6b9e67a11e5bd581a164df5bbc499032b7928531) DDC-3078 - cache configuration tests for the newly introduced API for cache instantiators - [`c56e923`](https://github.com/doctrine/orm/commit/c56e9232c22f320f380cadc0aca6cc74c2b2f9c8) DDC-3078 - removing tests for cache class setter/getter on cache configuration - [`11e17e7`](https://github.com/doctrine/orm/commit/11e17e772136d311ec12cfe519299f75b8ec49c8) DDC-3078 - switching cache initialization to use cache instantiator from config - [`37aa3e8`](https://github.com/doctrine/orm/commit/37aa3e88f56490b39b0ed4b6b059edb4bfe49714) DDC-3078 - removing cache class name setter/getter from cache configuration API - [`b384075`](https://github.com/doctrine/orm/commit/b3840752a47a11c88e6da6e9735e8a99e050f073) DDC-3078 - removing unused cache class name invalidity exception methods - [`00ab465`](https://github.com/doctrine/orm/commit/00ab465d3dec2c1fa6ee90a9a419d0fc391e30a9) DDC-3078 - using an explicit CacheInstantiator interface to replace callable cache instantiators - [`ba7094e`](https://github.com/doctrine/orm/commit/ba7094e8cd3220c00b7f02ac2aea299eb759d129) DDC-3078 - providing a default cache instantiator implementation ### 📊 Changes **8 files changed** (+139 additions, -43 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/Cache.php` (+0 -7) 📝 `lib/Doctrine/ORM/Cache/CacheConfiguration.php` (+8 -17) ➕ `lib/Doctrine/ORM/Cache/CacheInstantiator.php` (+41 -0) ➕ `lib/Doctrine/ORM/Cache/DefaultCacheInstantiator.php` (+41 -0) 📝 `lib/Doctrine/ORM/EntityManager.php` (+1 -2) 📝 `lib/Doctrine/ORM/ORMException.php` (+0 -10) 📝 `tests/Doctrine/Tests/ORM/Cache/CacheConfigTest.php` (+19 -7) ➕ `tests/Doctrine/Tests/ORM/Cache/DefaultCacheInstantiatorTest.php` (+29 -0) </details> ### 📄 Description See DDC-3078 ( http://www.doctrine-project.org/jira/browse/DDC-3078 ) - the cache interface should NOT cover a constructor. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
admin added the pull-request label 2026-01-22 16:02:52 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#9027
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?