[PR #564] [MERGED] Fix a wrong return type #8380

New Issue

admin · 2026-01-22T15:59:39+01:00

admin commented

2026-01-22 15:59:39 +01:00

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/564
Author: @BenMorel
Created: 2/3/2013
Status: ✅ Merged
Merged: 2/3/2013
Merged by: @guilhermeblanco

Base: master ← Head: f834c37f8a465ca3e23ee9ae62ef0bc4a525454c

📝 Commits (1)

f834c37 Fixed a wrong return type.

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 lib/Doctrine/ORM/Persisters/BasicEntityPersister.php (+1 -1)

📄 Description

BasicEntityPersister::executeInserts() is documented as:

@return array An array of any generated post-insert IDs. This will be an empty array
if the entity class does not use the IDENTITY generation strategy.

This PR fixes an empty return; that contradicted the documented return type.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/564 **Author:** [@BenMorel](https://github.com/BenMorel) **Created:** 2/3/2013 **Status:** ✅ Merged **Merged:** 2/3/2013 **Merged by:** [@guilhermeblanco](https://github.com/guilhermeblanco) **Base:** `master` ← **Head:** `f834c37f8a465ca3e23ee9ae62ef0bc4a525454c` --- ### 📝 Commits (1) - [`f834c37`](https://github.com/doctrine/orm/commit/f834c37f8a465ca3e23ee9ae62ef0bc4a525454c) Fixed a wrong return type. ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/Persisters/BasicEntityPersister.php` (+1 -1) </details> ### 📄 Description `BasicEntityPersister::executeInserts()` is documented as: ``` @return array An array of any generated post-insert IDs. This will be an empty array if the entity class does not use the IDENTITY generation strategy. ``` This PR fixes an empty `return;` that contradicted the documented return type. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-22 15:59:39 +01:00

admin referenced this issue

2026-01-22 16:09:13 +01:00

[PR #8380] [GH-7128] Improve OneToManyRequiresMappedBy Exception message #10958

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#8380