[PR #864] [CLOSED] Updated parser to support aggegrate functions in null comparisons #8823

Open
opened 2026-01-22 16:01:52 +01:00 by admin · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/864
Author: @curry684
Created: 11/29/2013
Status: Closed

Base: masterHead: patch-1


📝 Commits (1)

  • b134507 Updated parser to support aggegrate functions in null comparisons

📊 Changes

1 file changed (+8 additions, -2 deletions)

View changed files

📝 lib/Doctrine/ORM/Query/Parser.php (+8 -2)

📄 Description

Parser didn't support syntax like "SELECT i FROM entity i JOIN i.second s GROUP BY i HAVING max(s.something) IS NULL" which should be perfectly valid. Changed isAggregateFunction to support parameterless call which makes it consistent with isFunction.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/864 **Author:** [@curry684](https://github.com/curry684) **Created:** 11/29/2013 **Status:** ❌ Closed **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`b134507`](https://github.com/doctrine/orm/commit/b1345075030b736215be820a0e1dc9f6bed1f1c9) Updated parser to support aggegrate functions in null comparisons ### 📊 Changes **1 file changed** (+8 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/Query/Parser.php` (+8 -2) </details> ### 📄 Description Parser didn't support syntax like "SELECT i FROM entity i JOIN i.second s GROUP BY i HAVING max(s.something) IS NULL" which should be perfectly valid. Changed isAggregateFunction to support parameterless call which makes it consistent with isFunction. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
admin added the pull-request label 2026-01-22 16:01:52 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#8823