[PR #930] [CLOSED] Transactional callback isn't returning false #8913

New Issue

admin · 2026-01-22T16:02:17+01:00

admin commented

2026-01-22 16:02:17 +01:00

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/930
Author: @joni2back
Created: 2/4/2014
Status: ❌ Closed

Base: master ← Head: patch-1

📝 Commits (1)

66288c5 Transactional callback isn't returning false

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 lib/Doctrine/ORM/EntityManager.php (+1 -1)

📄 Description

Trying to fix any situation that if we've something callback with explicit FALSE return, like:

$rtn = $mgr->transactional(function() {...; return false;});
$rtn //true

Should be the return value of the callback method,
If the method is not returning any value (null), then.. we consider the callback was done, then return true.

Regards.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/930 **Author:** [@joni2back](https://github.com/joni2back) **Created:** 2/4/2014 **Status:** ❌ Closed **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`66288c5`](https://github.com/doctrine/orm/commit/66288c569c11b22aad35ae7a1f6cba402291c22b) Transactional callback isn't returning false ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/EntityManager.php` (+1 -1) </details> ### 📄 Description Trying to fix any situation that if we've something callback with explicit FALSE return, like: ``` php $rtn = $mgr->transactional(function() {...; return false;}); $rtn //true ``` Should be the return value of the callback method, If the method is not returning any value (null), then.. we consider the callback was done, then return true. Regards. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-22 16:02:17 +01:00

admin referenced this issue

2026-01-22 16:10:10 +01:00

[PR #8913] Merge release 2.9.4 into 2.10.x #11252

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#8913