mirror of
https://github.com/doctrine/orm.git
synced 2026-03-23 22:42:18 +01:00
[PR #115] [CLOSED] findByXXX does not accept orderBy/limit/offset #7727
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/doctrine/orm/pull/115
Author: @mpdeimos
Created: 9/2/2011
Status: ❌ Closed
Base:
2.1.x← Head:2.1.x📝 Commits (1)
59ca0e8findByXXX/findOneByXXX does now also accept orderBy, limit and offset args📊 Changes
1 file changed (+10 additions, -1 deletions)
View changed files
📝
lib/Doctrine/ORM/EntityRepository.php(+10 -1)📄 Description
Our modification to pass
findByXXXfunctionsorderBy/limit/offsetparams for entity repositories like one is used from normal findBy function.We're using an if cascade in favor of the
call_user_function_arraysince the latter is considered as slow.PS: If i need to target this pull request to your master, I'll resubmit - it's just that we're building against a stable codebase.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.