[PR #115] [CLOSED] findByXXX does not accept orderBy/limit/offset #7727

Open
opened 2026-01-22 15:56:34 +01:00 by admin · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/115
Author: @mpdeimos
Created: 9/2/2011
Status: Closed

Base: 2.1.xHead: 2.1.x


📝 Commits (1)

  • 59ca0e8 findByXXX/findOneByXXX does now also accept orderBy, limit and offset args

📊 Changes

1 file changed (+10 additions, -1 deletions)

View changed files

📝 lib/Doctrine/ORM/EntityRepository.php (+10 -1)

📄 Description

Our modification to pass findByXXX functions orderBy/limit/offset params for entity repositories like one is used from normal findBy function.

We're using an if cascade in favor of the call_user_function_array since the latter is considered as slow.

PS: If i need to target this pull request to your master, I'll resubmit - it's just that we're building against a stable codebase.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/115 **Author:** [@mpdeimos](https://github.com/mpdeimos) **Created:** 9/2/2011 **Status:** ❌ Closed **Base:** `2.1.x` ← **Head:** `2.1.x` --- ### 📝 Commits (1) - [`59ca0e8`](https://github.com/doctrine/orm/commit/59ca0e82d18c057960a6afd3ce29b26f5b97d626) findByXXX/findOneByXXX does now also accept orderBy, limit and offset args ### 📊 Changes **1 file changed** (+10 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/EntityRepository.php` (+10 -1) </details> ### 📄 Description Our modification to pass `findByXXX` functions `orderBy/limit/offset` params for entity repositories like one is used from normal findBy function. We're using an if cascade in favor of the `call_user_function_array` since the latter is considered as slow. PS: If i need to target this pull request to your master, I'll resubmit - it's just that we're building against a stable codebase. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
admin added the pull-request label 2026-01-22 15:56:34 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#7727