doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-24 06:52:09 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #5590] Fix discriminator column defaults #9656

New Issue
Closed
opened 2026-01-22 16:05:00 +01:00 by admin · 0 comments
admin commented 2026-01-22 16:05:00 +01:00
Owner
Copy Link

Original Pull Request: https://github.com/doctrine/orm/pull/5590

State: closed
Merged: Yes

DiscriminatorColumn mapping generated by all 3 metadata drivers (annot, yml, xml) was lacking length and type when only the name is specified in the mapping. Even though this results in a columnDef that generates a string column of length 255, the mapping for the discriminator column should have those fields set properly, and should be consistent with the behavior when no discriminator column mapping is specified at all.

Adjusted docs to properly reflect that the @DiscriminatorColumn annotation is optional.

Closes: #1601

**Original Pull Request:** https://github.com/doctrine/orm/pull/5590 **State:** closed **Merged:** Yes --- DiscriminatorColumn mapping generated by all 3 metadata drivers (annot, yml, xml) was lacking length and type when only the name is specified in the mapping. Even though this results in a columnDef that generates a string column of length 255, the mapping for the discriminator column should have those fields set properly, and should be consistent with the behavior when no discriminator column mapping is specified at all. Adjusted docs to properly reflect that the @DiscriminatorColumn annotation is optional. Closes: #1601
admin added the pull-request label 2026-01-22 16:05:00 +01:00
admin closed this issue 2026-01-22 16:05:01 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#9656
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?