doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-23 22:42:18 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #5987] Add missing type hints, add strictness for some checks, remove some useless calls #9806

New Issue
Open
opened 2026-01-22 16:05:28 +01:00 by admin · 0 comments
admin commented 2026-01-22 16:05:28 +01:00
Owner
Copy Link

Original Pull Request: https://github.com/doctrine/orm/pull/5987

State: closed
Merged: No

Q A
Branch master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #1126
License MIT
Doc PR n/a

CHANGELOG:

  • Remove calls to strlen(), count(), empty() when the intended behavior can be achieved via type juggling.
  • Add strictness for comparisons where possible.
  • Use Yoda conditions.
  • Add missing type hints.
**Original Pull Request:** https://github.com/doctrine/orm/pull/5987 **State:** closed **Merged:** No --- | Q | A | | --- | --- | | Branch | master | | Bug fix? | no | | New feature? | no | | BC breaks? | no | | Deprecations? | no | | Tests pass? | yes | | Fixed tickets | #1126 | | License | MIT | | Doc PR | n/a | CHANGELOG: - Remove calls to `strlen()`, `count()`, `empty()` when the intended behavior can be achieved via type juggling. - Add strictness for comparisons where possible. - Use Yoda conditions. - Add missing type hints.
admin added the pull-request label 2026-01-22 16:05:28 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#9806
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?