Doctrine 2 Doctrine\ORM\Persisters\Entity\BasicEntityPersister::getSelectSQL() method issue #5596

New Issue

Open

opened 2026-01-22 15:12:21 +01:00 by admin · 5 comments

admin commented 2026-01-22 15:12:21 +01:00

Owner

Copy Link

Originally created by @kbora504 on GitHub (Jul 1, 2017).

Originally assigned to: @Ocramius on GitHub.

There seems to be a bug in method
public function getSelectSQL($criteria, $assoc = null, $lockMode = null, $limit = null, $offset = null, array $orderBy = null)
As per documentation of Doctrine\ORM\Persisters\Entity\EntityPersister the $criteria parameter should be of type array; so, the below code

$conditionSql = ($criteria instanceof Criteria)
            ? $this->getSelectConditionCriteriaSQL($criteria)
            : $this->getSelectConditionSQL($criteria, $assoc);

will never execute $this->getSelectConditionCriteriaSQL($criteria) statement, because it is always of type array. Please fix this, so that it accepts single criteria object too.

++ Exception

#0 C:\projects\data\vendor\doctrine\orm\lib\Doctrine\ORM\Persisters\Entity\BasicEntityPersister.php(1704): Doctrine\ORM\ORMException::unrecognizedField(0)
#1 C:\projects\data\vendor\doctrine\orm\lib\Doctrine\ORM\Persisters\Entity\BasicEntityPersister.php(1582): Doctrine\ORM\Persisters\Entity\BasicEntityPersister->getSelectConditionStatementColumnSQL(0, NULL)
#2 C:\projects\data\vendor\doctrine\orm\lib\Doctrine\ORM\Persisters\Entity\BasicEntityPersister.php(1724): Doctrine\ORM\Persisters\Entity\BasicEntityPersister->getSelectConditionStatementSQL(0, Object(Doctrine\Common\Collections\Criteria), NULL)
#3 C:\projects\data\vendor\doctrine\orm\lib\Doctrine\ORM\Persisters\Entity\BasicEntityPersister.php(1058): Doctrine\ORM\Persisters\Entity\BasicEntityPersister->getSelectConditionSQL(Array, NULL)
#4 C:\projects\data\vendor\doctrine\orm\lib\Doctrine\ORM\Persisters\Entity\BasicEntityPersister.php(882): Doctrine\ORM\Persisters\Entity\BasicEntityPersister->getSelectSQL(Array, NULL, NULL, 20, 0, NULL)
#5 C:\projects\data\vendor\doctrine\orm\lib\Doctrine\ORM\EntityRepository.php(181): Doctrine\ORM\Persisters\Entity\BasicEntityPersister->loadAll(Array, NULL, 20, 0)
#6 C:\projects\data\module\MyModule\src\DAO\DataDao.php(231): Doctrine\ORM\EntityRepository->findBy(Array, NULL, 20, 0)
#7 C:\projects\data\module\MyModule\src\Service\DataService.php(47): MyModule\DAO\DataDao->findData(Object(MyModule\Form\Data\PaginationOptions))
#8 C:\projects\data\module\MyModule\src\Controller\DataController.php(54): MyModule\Service\DataService->findData(Object(MyModule\Form\Data\PaginationOptions))
#9 C:\projects\data\vendor\zendframework\zend-mvc\src\Controller\AbstractActionController.php(78): MyModule\Controller\DataController->dataAction()
#10 C:\projects\data\vendor\zendframework\zend-eventmanager\src\EventManager.php(322): Zend\Mvc\Controller\AbstractActionController->onDispatch(Object(Zend\Mvc\MvcEvent))
#11 C:\projects\data\vendor\zendframework\zend-eventmanager\src\EventManager.php(179): Zend\EventManager\EventManager->triggerListeners(Object(Zend\Mvc\MvcEvent), Object(Closure))
#12 C:\projects\data\vendor\zendframework\zend-mvc\src\Controller\AbstractController.php(106): Zend\EventManager\EventManager->triggerEventUntil(Object(Closure), Object(Zend\Mvc\MvcEvent))
#13 C:\projects\data\vendor\zendframework\zend-mvc\src\DispatchListener.php(138): Zend\Mvc\Controller\AbstractController->dispatch(Object(Zend\Http\PhpEnvironment\Request), Object(Zend\Http\PhpEnvironment\Response))
#14 C:\projects\data\vendor\zendframework\zend-eventmanager\src\EventManager.php(322): Zend\Mvc\DispatchListener->onDispatch(Object(Zend\Mvc\MvcEvent))
#15 C:\projects\data\vendor\zendframework\zend-eventmanager\src\EventManager.php(179): Zend\EventManager\EventManager->triggerListeners(Object(Zend\Mvc\MvcEvent), Object(Closure))
#16 C:\projects\data\vendor\zendframework\zend-mvc\src\Application.php(332): Zend\EventManager\EventManager->triggerEventUntil(Object(Closure), Object(Zend\Mvc\MvcEvent))
#17 C:\projects\data\public\index.php(40): Zend\Mvc\Application->run()
#18 {main}

Originally created by @kbora504 on GitHub (Jul 1, 2017). Originally assigned to: @Ocramius on GitHub. There seems to be a bug in method **[public function getSelectSQL($criteria, $assoc = null, $lockMode = null, $limit = null, $offset = null, array $orderBy = null)](https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Persisters/Entity/BasicEntityPersister.php#L1041)** As per documentation of **Doctrine\ORM\Persisters\Entity\EntityPersister** the **$criteria** parameter should be of type **array**; so, the below code ``` $conditionSql = ($criteria instanceof Criteria) ? $this->getSelectConditionCriteriaSQL($criteria) : $this->getSelectConditionSQL($criteria, $assoc); ``` will never execute `$this->getSelectConditionCriteriaSQL($criteria)` statement, because it is always of type **array**. Please fix this, so that it accepts single **criteria** object too. ++ **Exception** ``` #0 C:\projects\data\vendor\doctrine\orm\lib\Doctrine\ORM\Persisters\Entity\BasicEntityPersister.php(1704): Doctrine\ORM\ORMException::unrecognizedField(0) #1 C:\projects\data\vendor\doctrine\orm\lib\Doctrine\ORM\Persisters\Entity\BasicEntityPersister.php(1582): Doctrine\ORM\Persisters\Entity\BasicEntityPersister->getSelectConditionStatementColumnSQL(0, NULL) #2 C:\projects\data\vendor\doctrine\orm\lib\Doctrine\ORM\Persisters\Entity\BasicEntityPersister.php(1724): Doctrine\ORM\Persisters\Entity\BasicEntityPersister->getSelectConditionStatementSQL(0, Object(Doctrine\Common\Collections\Criteria), NULL) #3 C:\projects\data\vendor\doctrine\orm\lib\Doctrine\ORM\Persisters\Entity\BasicEntityPersister.php(1058): Doctrine\ORM\Persisters\Entity\BasicEntityPersister->getSelectConditionSQL(Array, NULL) #4 C:\projects\data\vendor\doctrine\orm\lib\Doctrine\ORM\Persisters\Entity\BasicEntityPersister.php(882): Doctrine\ORM\Persisters\Entity\BasicEntityPersister->getSelectSQL(Array, NULL, NULL, 20, 0, NULL) #5 C:\projects\data\vendor\doctrine\orm\lib\Doctrine\ORM\EntityRepository.php(181): Doctrine\ORM\Persisters\Entity\BasicEntityPersister->loadAll(Array, NULL, 20, 0) #6 C:\projects\data\module\MyModule\src\DAO\DataDao.php(231): Doctrine\ORM\EntityRepository->findBy(Array, NULL, 20, 0) #7 C:\projects\data\module\MyModule\src\Service\DataService.php(47): MyModule\DAO\DataDao->findData(Object(MyModule\Form\Data\PaginationOptions)) #8 C:\projects\data\module\MyModule\src\Controller\DataController.php(54): MyModule\Service\DataService->findData(Object(MyModule\Form\Data\PaginationOptions)) #9 C:\projects\data\vendor\zendframework\zend-mvc\src\Controller\AbstractActionController.php(78): MyModule\Controller\DataController->dataAction() #10 C:\projects\data\vendor\zendframework\zend-eventmanager\src\EventManager.php(322): Zend\Mvc\Controller\AbstractActionController->onDispatch(Object(Zend\Mvc\MvcEvent)) #11 C:\projects\data\vendor\zendframework\zend-eventmanager\src\EventManager.php(179): Zend\EventManager\EventManager->triggerListeners(Object(Zend\Mvc\MvcEvent), Object(Closure)) #12 C:\projects\data\vendor\zendframework\zend-mvc\src\Controller\AbstractController.php(106): Zend\EventManager\EventManager->triggerEventUntil(Object(Closure), Object(Zend\Mvc\MvcEvent)) #13 C:\projects\data\vendor\zendframework\zend-mvc\src\DispatchListener.php(138): Zend\Mvc\Controller\AbstractController->dispatch(Object(Zend\Http\PhpEnvironment\Request), Object(Zend\Http\PhpEnvironment\Response)) #14 C:\projects\data\vendor\zendframework\zend-eventmanager\src\EventManager.php(322): Zend\Mvc\DispatchListener->onDispatch(Object(Zend\Mvc\MvcEvent)) #15 C:\projects\data\vendor\zendframework\zend-eventmanager\src\EventManager.php(179): Zend\EventManager\EventManager->triggerListeners(Object(Zend\Mvc\MvcEvent), Object(Closure)) #16 C:\projects\data\vendor\zendframework\zend-mvc\src\Application.php(332): Zend\EventManager\EventManager->triggerEventUntil(Object(Closure), Object(Zend\Mvc\MvcEvent)) #17 C:\projects\data\public\index.php(40): Zend\Mvc\Application->run() #18 {main} ```

admin added the BugMissing Tests labels 2026-01-22 15:12:21 +01:00

admin commented 2026-01-22 15:12:22 +01:00

Author

Owner

Copy Link

@Ocramius commented on GitHub (Jul 1, 2017):

@kbora504 could you please write a failing test case that demonstrates the issue?

@Ocramius commented on GitHub (Jul 1, 2017): @kbora504 could you please write a failing test case that demonstrates the issue?

admin commented 2026-01-22 15:12:22 +01:00

Author

Owner

Copy Link

@kbora504 commented on GitHub (Jul 2, 2017):

It is very obvious from code written. Just check the passed parameter type is array and we are checking for instanceof Criteria.

@kbora504 commented on GitHub (Jul 2, 2017): It is very obvious from code written. Just check the passed parameter type is array and we are checking for `instanceof Criteria`.

admin commented 2026-01-22 15:12:22 +01:00

Author

Owner

Copy Link

@Ocramius commented on GitHub (Jul 2, 2017):

It doesn't really matter from our perspective: tests verify the behavior and prevent regressions. No tests = no fix/merge ;-)

@Ocramius commented on GitHub (Jul 2, 2017): It doesn't really matter from our perspective: tests verify the behavior and prevent regressions. No tests = no fix/merge ;-)

admin commented 2026-01-22 15:12:24 +01:00

Author

Owner

Copy Link

@kbora504 commented on GitHub (Jul 2, 2017):

@Ocramius I understand your point. But how can I write test case for a satement inside function?
:(

@kbora504 commented on GitHub (Jul 2, 2017): @Ocramius I understand your point. But how can I write test case for a satement inside function? :(

admin commented 2026-01-22 15:12:24 +01:00

Author

Owner

Copy Link

@Ocramius commented on GitHub (Jul 2, 2017):

@kbora504 you got a stack trace there: how did you get to that failure? Can you isolate it and make an example that reproduces the problem? See 388afb46d0/tests/Doctrine/Tests/ORM/Functional/Ticket for examples

@Ocramius commented on GitHub (Jul 2, 2017): @kbora504 you got a stack trace there: how did you get to that failure? Can you isolate it and make an example that reproduces the problem? See https://github.com/doctrine/doctrine2/tree/388afb46d0cb3ed0c51332e8df0de9e942c2690b/tests/Doctrine/Tests/ORM/Functional/Ticket for examples

admin referenced this issue 2026-01-22 16:05:01 +01:00

[PR #5597] Fix documentation of schema tool's "save mode" #9662

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

3.6.x

2.20.x

dependabot/github_actions/2.20.x/doctrine/dot-github/dot-github/workflows/composer-lint.yml-14.0.0

3.7.x

4.0.x

2.21.x

old-prototype-3.x

3.6.2

3.6.1

3.6.0

2.20.9

3.5.8

3.5.7

3.5.6

3.5.5

2.20.8

3.5.4

3.5.3

2.20.7

3.5.2

2.20.6

3.5.1

3.5.0

3.4.4

3.4.3

3.4.2

2.20.5

3.4.1

3.4.0

3.3.4

2.20.4

3.3.3

2.20.3

3.3.2

2.20.2

3.3.1

2.20.1

3.3.0

3.2.3

2.20.0

2.19.8

3.2.2

2.19.7

3.2.1

2.19.6

3.2.0

3.1.4

3.1.3

2.19.5

3.1.2

2.19.4

3.1.1

2.19.3

2.19.2

2.19.1

3.1.0

2.19.0

3.0.3

2.18.3

3.0.2

2.18.2

3.0.1

2.18.1

3.0.0

2.18.0

2.17.5

3.0.0-RC1

2.17.4

2.17.3

2.17.2

2.17.1

3.0.0-beta2

2.17.0

2.16.3

3.0.0-beta1

2.16.2

2.16.1

2.16.0

2.15.5

2.15.4

2.15.3

2.15.2

2.15.1

2.15.0

2.14.3

2.14.2

2.14.1

2.14.0

2.13.5

2.13.4

2.13.3

2.13.2

2.13.1

2.13.0

2.12.4

2.12.3

2.12.2

2.12.1

2.12.0

2.11.3

2.11.2

2.11.1

2.11.0

2.10.5

2.10.4

2.10.3

2.10.2

2.10.1

2.10.0

2.9.6

2.9.5

2.9.4

2.9.3

2.9.2

2.9.1

2.9.0

2.8.5

2.8.4

2.8.3

2.8.2

2.8.1

2.8.0

2.7.5

2.7.4

v2.7.3

v2.7.2

v2.7.1

v2.7.0

v2.6.6

v2.6.5

v2.6.4

v2.6.3

v2.6.2

v2.6.1

v2.6.0

v2.5.14

v2.5.13

v2.5.12

v2.5.11

v2.5.10

v2.5.9

v2.5.8

v2.5.7

v2.5.6

v2.5.5

v2.5.4

v2.5.3

v2.5.2

v2.4.8

v2.5.1

v2.5.0

v2.5.0-RC2

v2.5.0-RC1

v2.5.0-beta1

v2.5.0-alpha2

v2.5.0-alpha1

v2.4.7

v2.4.6

v2.4.5

v2.4.4

v2.4.3

v2.3.6

v2.4.2

2.3.5

v2.4.1

v2.4.0

2.4.0-RC2

2.4.0-RC1

2.4.0-BETA2

2.3.4

2.3.3

2.4.0-BETA1

2.3.2

2.3.1

2.3.0

2.3.0-RC4

2.3.0-RC3

2.3.0-RC2

2.2.3

2.3.0-RC1

2.3.0-BETA1

2.1.7

2.2.2

2.2.1

2.1.6

2.2.0

2.2.0-RC1

2.2.0-BETA2

2.2.0-BETA1

2.1.5

2.1.4

2.1.3

2.1.2

2.1.1

2.0.7

2.1.0

2.1.0RC3

2.1.0RC2

2.1.0RC1

2.0.6

2.1.0BETA1

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

2.0.0RC2

2.0.0RC1

2.0.0-BETA4

2.0.0-BETA3

2.0.0-BETA2

2.0.0-BETA1

Labels

Clear labels

BC Break

Bug

Can't Fix

Deprecation

Documentation

DQL

Duplicate

Failing Test

Hacktoberfest

Improvement

Improvement

Incomplete

Invalid

Missing Tests

New Feature

PR Created

pull-request

Mirrored from GitHub Pull Request

Question

Regression

Status: Waiting feedback

Waiting feedback

WIP

Won't Fix

No Label Bug Missing Tests

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

admin

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#5596