doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-24 06:52:09 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #830] [MERGED] [DDC-2764] Prefix criteria orderBy with rootAlias #8765

New Issue
Open
opened 2026-01-22 16:01:37 +01:00 by admin · 0 comments
admin commented 2026-01-22 16:01:37 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/830
Author: @sandermarechal
Created: 10/29/2013
Status: ✅ Merged
Merged: 1/2/2014
Merged by: @beberlei

Base: master ← Head: sort-alias

📝 Commits (3)

  • b6f8d53 [DDC-2764] Prefix criteria orderBy with rootAlias
  • 202039e Set rootAlias outside loop
  • 35a62e9 Add rootAlias to Criteria where clauses

📊 Changes

4 files changed (+51 additions, -29 deletions)

View changed files

📝 lib/Doctrine/ORM/Query/QueryExpressionVisitor.php (+18 -10)
📝 lib/Doctrine/ORM/QueryBuilder.php (+3 -2)
📝 tests/Doctrine/Tests/ORM/Query/QueryExpressionVisitorTest.php (+14 -14)
📝 tests/Doctrine/Tests/ORM/QueryBuilderTest.php (+16 -3)

📄 Description

This fixes DDC-2764 by prefixing the QueryBuilder rootAlias to sortBy criteria.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/830 **Author:** [@sandermarechal](https://github.com/sandermarechal) **Created:** 10/29/2013 **Status:** ✅ Merged **Merged:** 1/2/2014 **Merged by:** [@beberlei](https://github.com/beberlei) **Base:** `master` ← **Head:** `sort-alias` --- ### 📝 Commits (3) - [`b6f8d53`](https://github.com/doctrine/orm/commit/b6f8d53ff1ed0b113d7faba728e7142734d3caba) [DDC-2764] Prefix criteria orderBy with rootAlias - [`202039e`](https://github.com/doctrine/orm/commit/202039e8530368f618a4b3e9978cc5ff42aed4d0) Set rootAlias outside loop - [`35a62e9`](https://github.com/doctrine/orm/commit/35a62e9a05a85ab7b2df5a5bee7b63a517dd76df) Add rootAlias to Criteria where clauses ### 📊 Changes **4 files changed** (+51 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/Query/QueryExpressionVisitor.php` (+18 -10) 📝 `lib/Doctrine/ORM/QueryBuilder.php` (+3 -2) 📝 `tests/Doctrine/Tests/ORM/Query/QueryExpressionVisitorTest.php` (+14 -14) 📝 `tests/Doctrine/Tests/ORM/QueryBuilderTest.php` (+16 -3) </details> ### 📄 Description This fixes DDC-2764 by prefixing the QueryBuilder rootAlias to sortBy criteria. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
admin added the pull-request label 2026-01-22 16:01:37 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#8765
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?