doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-23 22:42:18 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #406] [MERGED] [DCOM-96] Moving proxy generation and autoloading to common #8140

New Issue
Open
opened 2026-01-22 15:58:36 +01:00 by admin · 0 comments
admin commented 2026-01-22 15:58:36 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/406
Author: @Ocramius
Created: 7/21/2012
Status: ✅ Merged
Merged: 2/14/2013
Merged by: @beberlei

Base: master ← Head: DCOM-96

📝 Commits (3)

  • 8272ffd Proxy generation as of doctrine/common#168 - DCOM-96
  • 271f5cf Adding fix and tests for DDC-1734
  • a58d4ae Cleaning up logic of the proxy factory by moving closure generation to own private methods

📊 Changes

18 files changed (+508 additions, -795 deletions)

View changed files

📝 .gitignore (+2 -1)
📝 lib/Doctrine/ORM/Id/AssignedGenerator.php (+1 -1)
📝 lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php (+6 -5)
📝 lib/Doctrine/ORM/PersistentCollection.php (+4 -3)
📝 lib/Doctrine/ORM/Proxy/Autoloader.php (+3 -74)
📝 lib/Doctrine/ORM/Proxy/Proxy.php (+1 -1)
➖ lib/Doctrine/ORM/Proxy/ProxyException.php (+0 -69)
📝 lib/Doctrine/ORM/Proxy/ProxyFactory.php (+103 -339)
📝 lib/Doctrine/ORM/Tools/DebugUnitOfWorkListener.php (+1 -1)
📝 lib/Doctrine/ORM/UnitOfWork.php (+26 -5)
📝 lib/vendor/doctrine-common (+1 -1)
📝 tests/Doctrine/Tests/ORM/Functional/ProxiesLikeEntitiesTest.php (+18 -16)
➕ tests/Doctrine/Tests/ORM/Functional/Ticket/DDC1734Test.php (+89 -0)
➕ tests/Doctrine/Tests/ORM/Performance/ProxyPerformanceTest.php (+165 -0)
➖ tests/Doctrine/Tests/ORM/Proxy/AutoloaderTest.php (+0 -62)
➖ tests/Doctrine/Tests/ORM/Proxy/ProxyClassGeneratorTest.php (+0 -204)
➕ tests/Doctrine/Tests/ORM/Proxy/ProxyFactoryTest.php (+88 -0)
➖ tests/Doctrine/Tests/ORM/Proxy/fixtures/NonNamespacedProxies.php (+0 -13)

📄 Description

This PR is related to doctrine/common#168.

In this PR, the ProxyFactory has been reduced to an object builder and it's public API has been kept intact (While the proxy Autoloader has been moved to doctrine/common). It would be interesting to define what this builder could do with the ProxyFactory to get its own customizations introduced.

Also fixes DDC-1734

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/406 **Author:** [@Ocramius](https://github.com/Ocramius) **Created:** 7/21/2012 **Status:** ✅ Merged **Merged:** 2/14/2013 **Merged by:** [@beberlei](https://github.com/beberlei) **Base:** `master` ← **Head:** `DCOM-96` --- ### 📝 Commits (3) - [`8272ffd`](https://github.com/doctrine/orm/commit/8272ffd23fd66bac13a0dc074c868a00b82c7707) Proxy generation as of doctrine/common#168 - DCOM-96 - [`271f5cf`](https://github.com/doctrine/orm/commit/271f5cf03349da4be7fb044e0a7c92537c3c6ebc) Adding fix and tests for DDC-1734 - [`a58d4ae`](https://github.com/doctrine/orm/commit/a58d4ae46292cc9d07cc9976477156611820ce9c) Cleaning up logic of the proxy factory by moving closure generation to own private methods ### 📊 Changes **18 files changed** (+508 additions, -795 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+2 -1) 📝 `lib/Doctrine/ORM/Id/AssignedGenerator.php` (+1 -1) 📝 `lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php` (+6 -5) 📝 `lib/Doctrine/ORM/PersistentCollection.php` (+4 -3) 📝 `lib/Doctrine/ORM/Proxy/Autoloader.php` (+3 -74) 📝 `lib/Doctrine/ORM/Proxy/Proxy.php` (+1 -1) ➖ `lib/Doctrine/ORM/Proxy/ProxyException.php` (+0 -69) 📝 `lib/Doctrine/ORM/Proxy/ProxyFactory.php` (+103 -339) 📝 `lib/Doctrine/ORM/Tools/DebugUnitOfWorkListener.php` (+1 -1) 📝 `lib/Doctrine/ORM/UnitOfWork.php` (+26 -5) 📝 `lib/vendor/doctrine-common` (+1 -1) 📝 `tests/Doctrine/Tests/ORM/Functional/ProxiesLikeEntitiesTest.php` (+18 -16) ➕ `tests/Doctrine/Tests/ORM/Functional/Ticket/DDC1734Test.php` (+89 -0) ➕ `tests/Doctrine/Tests/ORM/Performance/ProxyPerformanceTest.php` (+165 -0) ➖ `tests/Doctrine/Tests/ORM/Proxy/AutoloaderTest.php` (+0 -62) ➖ `tests/Doctrine/Tests/ORM/Proxy/ProxyClassGeneratorTest.php` (+0 -204) ➕ `tests/Doctrine/Tests/ORM/Proxy/ProxyFactoryTest.php` (+88 -0) ➖ `tests/Doctrine/Tests/ORM/Proxy/fixtures/NonNamespacedProxies.php` (+0 -13) </details> ### 📄 Description This PR is related to doctrine/common#168. In this PR, the `ProxyFactory` has been reduced to an object builder and it's public API has been kept intact (While the proxy `Autoloader` has been moved to doctrine/common). It would be interesting to define what this builder could do with the `ProxyFactory` to get its own customizations introduced. Also fixes [DDC-1734](http://www.doctrine-project.org/jira/browse/DDC-1734) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
admin added the pull-request label 2026-01-22 15:58:36 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#8140
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?