[PR #958] [CLOSED] wrong access modifiers "private" instead of "protected" #8962

New Issue

admin · 2026-01-22T16:02:31+01:00

admin commented

2026-01-22 16:02:31 +01:00

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/958
Author: @grytysek
Created: 2/20/2014
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (1)

dd9a51b wrong access modifiers "private" instead of "protected"

📊 Changes

1 file changed (+5 additions, -5 deletions)

View changed files

📝 lib/Doctrine/ORM/Mapping/Driver/XmlDriver.php (+5 -5)

📄 Description

In symfony2 in file: https://github.com/doctrine/DoctrineBundle/blob/master/Resources/config/orm.xml
In configuration is parameter:

<parameter key="doctrine.orm.metadata.xml.class">Doctrine\ORM\Mapping\Driver\SimplifiedXmlDriver</parameter>

that suggest that is designed to override in private bundles but when you try to do that it's nessesary to repeat entire body of methods in own class because of "private" access modifiers, i suggest to change them to 'protected' because without that it's makes extending this class more difficult and not clear to understand what is going on inside of this classes. I need to override this class to create own versioning system, and i need to extend xml mapping of entities.

I see this mistake often in symfony2 but now i see this also in doctrine2 itself, I suggest to change this modifiers not only in this class...

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/958 **Author:** [@grytysek](https://github.com/grytysek) **Created:** 2/20/2014 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`dd9a51b`](https://github.com/doctrine/orm/commit/dd9a51b5b46505fee0a1a33b1a6c0977b0317b66) wrong access modifiers "private" instead of "protected" ### 📊 Changes **1 file changed** (+5 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/Mapping/Driver/XmlDriver.php` (+5 -5) </details> ### 📄 Description In symfony2 in file: https://github.com/doctrine/DoctrineBundle/blob/master/Resources/config/orm.xml In configuration is parameter: ``` <parameter key="doctrine.orm.metadata.xml.class">Doctrine\ORM\Mapping\Driver\SimplifiedXmlDriver</parameter> ``` that suggest that is designed to override in private bundles but when you try to do that it's nessesary to repeat entire body of methods in own class because of "private" access modifiers, i suggest to change them to 'protected' because without that it's makes extending this class more difficult and not clear to understand what is going on inside of this classes. I need to override this class to create own versioning system, and i need to extend xml mapping of entities. I see this mistake often in symfony2 but now i see this also in doctrine2 itself, I suggest to change this modifiers not only in this class... --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-22 16:02:31 +01:00

admin closed this issue

2026-01-22 16:02:32 +01:00

admin referenced this issue

2026-01-22 16:10:18 +01:00

[PR #8962] Stop swallowing exceptions #11290

admin referenced this issue

2026-01-22 16:11:34 +01:00

[PR #9526] Make creating test models more straightforward and revert to swallowing exceptions #11681

Sign in to join this conversation.