doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-23 22:42:18 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #1380] Fix issue with second-level-cache tests and versioned entities #9438

New Issue
Closed
opened 2026-01-22 16:04:19 +01:00 by admin · 0 comments
admin commented 2026-01-22 16:04:19 +01:00
Owner
Copy Link

Original Pull Request: https://github.com/doctrine/orm/pull/1380

State: closed
Merged: No

I'm not sure why this bug doesn't show normally within master, but I ran across it with pull-request build 3930.1, where it complained since $targetPersister was not an instance of CachedPersister.

The immediate fix seems straightforward, because DefaultCollectionHydrator doesn't even accept the second argument.

@FabioBatSilva : Please let me know if you see some better resolution to this, or if it indicates some edge-case in the second-level-cache logic that requires a new test.

**Original Pull Request:** https://github.com/doctrine/orm/pull/1380 **State:** closed **Merged:** No --- I'm not sure why this bug doesn't show normally within `master`, but I ran across it with pull-request build [3930.1](https://travis-ci.org/doctrine/doctrine2/jobs/57975906), where it complained since `$targetPersister` was not an instance of `CachedPersister`. The immediate fix seems straightforward, because `DefaultCollectionHydrator` doesn't even accept the second argument. @FabioBatSilva : Please let me know if you see some better resolution to this, or if it indicates some edge-case in the second-level-cache logic that requires a new test.
admin added the pull-request label 2026-01-22 16:04:19 +01:00
admin closed this issue 2026-01-22 16:04:20 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#9438
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?