[PR #564] Fix a wrong return type #8384

New Issue

admin · 2026-01-22T15:59:40+01:00

admin commented

2026-01-22 15:59:40 +01:00

Original Pull Request: https://github.com/doctrine/orm/pull/564

State: closed
Merged: Yes

BasicEntityPersister::executeInserts() is documented as:

@return array An array of any generated post-insert IDs. This will be an empty array
if the entity class does not use the IDENTITY generation strategy.

This PR fixes an empty return; that contradicted the documented return type.

**Original Pull Request:** https://github.com/doctrine/orm/pull/564 **State:** closed **Merged:** Yes --- `BasicEntityPersister::executeInserts()` is documented as: ``` @return array An array of any generated post-insert IDs. This will be an empty array if the entity class does not use the IDENTITY generation strategy. ``` This PR fixes an empty `return;` that contradicted the documented return type.

admin added the pull-request label 2026-01-22 15:59:40 +01:00

admin closed this issue

2026-01-22 15:59:40 +01:00

admin referenced this issue

2026-01-22 16:09:13 +01:00

[PR #8384] [GH-6394] Bugfix: IdentifierFlattener support for association non-object values. #10959

Sign in to join this conversation.