DDC-1743: [GH-315] [WIP] Allowing proxies to be passed to ORM public API #2190

New Issue

admin · 2026-01-22T13:43:45+01:00

admin commented

2026-01-22 13:43:45 +01:00

Originally created by @doctrinebot on GitHub (Mar 31, 2012).

Originally assigned to: @beberlei on GitHub.

Jira issue originally created by user @beberlei:

This issue is created automatically through a Github pull request on behalf of Ocramius:

Url: https://github.com/doctrine/doctrine2/pull/315

Message:

Basically, following happens:

$proxy = some_unserialization();
$em->persist($proxy); // exception because the class name is not recognized

Fortunately, just some replacements of get_class($entity) with Doctrine\Common\Util\ClassUtils::getClass($entity) fix the issue.

I wanted to leave this as [WIP] because I need some feedback on the test cases. All three tests fail without the patch, while with it applied.

What is a bit tricky is the status of the proxies.

Cases where $*_initialized__ = false; && $*identifier = array(); and others fail because of notices and weird issues that are very difficult to hunt down. That is because of the strange nature of proxies obviously. I just wanted to know if this should be somehow fixed in here.

Another issue is probably performance, as there is some minor overhead introduced. What I'd like to know is if https://github.com/doctrine/common/blob/master/lib/Doctrine/Common/Util/ClassUtils.php#L56 could be reduced to a if ($object instanceof Proxy) { ... }.

Originally created by @doctrinebot on GitHub (Mar 31, 2012). Originally assigned to: @beberlei on GitHub. Jira issue originally created by user @beberlei: This issue is created automatically through a Github pull request on behalf of Ocramius: Url: https://github.com/doctrine/doctrine2/pull/315 Message: Basically, following happens: ``` php $proxy = some_unserialization(); $em->persist($proxy); // exception because the class name is not recognized ``` Fortunately, just some replacements of `get_class($entity)` with `Doctrine\Common\Util\ClassUtils::getClass($entity)` fix the issue. I wanted to leave this as [WIP] because I need some feedback on the test cases. All three tests fail without the patch, while [![Build Status](https://secure.travis-ci.org/Ocramius/doctrine2.png?branch=getclass-on-proxies-refactoring)](http://travis-ci.org/Ocramius/doctrine2) with it applied. What is a bit tricky is the status of the proxies. Cases where `$*_initialized__ = false;` && `$*identifier = array();` and others fail because of notices and weird issues that are very difficult to hunt down. That is because of the strange nature of proxies obviously. I just wanted to know if this should be somehow fixed in here. Another issue is probably performance, as there is some minor overhead introduced. What I'd like to know is if https://github.com/doctrine/common/blob/master/lib/Doctrine/Common/Util/ClassUtils.php#L56 could be reduced to a `if ($object instanceof Proxy) { ... }`.

admin added the Bug label 2026-01-22 13:43:45 +01:00

admin referenced this issue

2026-01-22 16:05:46 +01:00

[PR #6215] Added link to `Transitive Persistence` #9897

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#2190