[PR #583] [CLOSED] accept more than 2 parameters in CONCAT function #8409

New Issue

admin · 2026-01-22T15:59:47+01:00

admin commented

2026-01-22 15:59:47 +01:00

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/583
Author: @broncha
Created: 2/19/2013
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (5)

369e433 accept more than 2 parameters in CONCAT function
9604cde Tested and parser validates at least 2 parameters given
7dac400 test added for CONCAT function and indentation fixed
3a3d053 calling getConcatExpression using call_user_func_array as number of arguments is not known removing dependency to patch DBAL
6ac8f90 maintaining backward compatibility

📊 Changes

2 files changed (+67 additions, -8 deletions)

View changed files

📝 lib/Doctrine/ORM/Query/AST/Functions/ConcatFunction.php (+24 -8)
📝 tests/Doctrine/Tests/ORM/Query/SelectSqlGenerationTest.php (+43 -0)

📄 Description

The DBAL Platform supports more then 2 parameters but the ConcatFunction only validates 2 parameters to CONCAT. This commit allows to pass more than 2 parameters to CONCAT. Also this change would require that getConcatExpression accept array as a parameter. I have opened a pull request for that as well.

Here is the pull request : https://github.com/doctrine/dbal/pull/275

I also propose that the function getConcatExpression only accept array of string rather than multiple string arguments.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/583 **Author:** [@broncha](https://github.com/broncha) **Created:** 2/19/2013 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (5) - [`369e433`](https://github.com/doctrine/orm/commit/369e433fa0a5d2a53c3167d9c2948dcde5d64dcc) accept more than 2 parameters in CONCAT function - [`9604cde`](https://github.com/doctrine/orm/commit/9604cdecd334139d68640667229fc31086e9fbe9) Tested and parser validates at least 2 parameters given - [`7dac400`](https://github.com/doctrine/orm/commit/7dac40039bd2adf91c100c3cdf7336305cb872d8) test added for CONCAT function and indentation fixed - [`3a3d053`](https://github.com/doctrine/orm/commit/3a3d053de0ee3bd78dc9e2b23bacfa9b2944c15d) calling getConcatExpression using call_user_func_array as number of arguments is not known removing dependency to patch DBAL - [`6ac8f90`](https://github.com/doctrine/orm/commit/6ac8f909ce5dfed82c0299974db4397348ed5b0d) maintaining backward compatibility ### 📊 Changes **2 files changed** (+67 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/Query/AST/Functions/ConcatFunction.php` (+24 -8) 📝 `tests/Doctrine/Tests/ORM/Query/SelectSqlGenerationTest.php` (+43 -0) </details> ### 📄 Description The DBAL Platform supports more then 2 parameters but the ConcatFunction only validates 2 parameters to CONCAT. This commit allows to pass more than 2 parameters to CONCAT. Also this change would require that `getConcatExpression` accept array as a parameter. I have opened a pull request for that as well. Here is the pull request : https://github.com/doctrine/dbal/pull/275 I also propose that the function `getConcatExpression` only accept array of string rather than multiple string arguments. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-22 15:59:47 +01:00

admin closed this issue

2026-01-22 15:59:48 +01:00

admin referenced this issue

2026-01-22 16:09:16 +01:00

[PR #8409] bump psalm, fix some issues on level 6 and improve type coverage #10973

admin referenced this issue

2026-01-22 16:09:50 +01:00

[PR #8713] Stop using Webmozart to fix error in Query/Parser #11134

Sign in to join this conversation.