doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-23 22:42:18 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

Use ON for join conditions for arbitrary DQL joins instead of using WITH #7557

New Issue
Closed
opened 2026-01-22 15:53:25 +01:00 by admin · 0 comments
admin commented 2026-01-22 15:53:25 +01:00
Owner
Copy Link

Originally created by @stof on GitHub (Oct 7, 2025).

Feature Request

What

DQL supports 2 kinds of joins:

  • relation joins, which can either load the full relation or apply an adhoc condition with WITH
  • arbitrary joins, which today also use the WITH keyword, even though the conditions in this case have exactly the same semantic than the ON conditions of SQL joins

This is about changing that second case (not changing the first one) to support ON as keyword and deprecating the support of WITH for that case

Why

This inconsistency with SQL causes lots of confusion in the ecosystem. The fact that Expr\Join has a ON constant while DQL did not support parsing it causes even more confusion when using the QueryBuilder.
See #7891 and #3544,

How

Change the parsing of JOIN to distinguish the 2 kinds of joins in the handling of conditions.

Originally created by @stof on GitHub (Oct 7, 2025). ### Feature Request #### What DQL supports 2 kinds of joins: - relation joins, which can either load the full relation or apply an adhoc condition with `WITH` - arbitrary joins, which today also use the `WITH` keyword, even though the conditions in this case have exactly the same semantic than the `ON` conditions of SQL joins This is about changing that second case (**not** changing the first one) to support `ON` as keyword and deprecating the support of `WITH` for that case #### Why This inconsistency with SQL causes lots of confusion in the ecosystem. The fact that `Expr\Join` has a `ON` constant while DQL did not support parsing it causes even more confusion when using the QueryBuilder. See #7891 and #3544, #### How Change the parsing of `JOIN` to distinguish the 2 kinds of joins in the handling of conditions.
admin closed this issue 2026-01-22 15:53:25 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#7557
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?