[PR #1395] Fix for DDC-3697 and DDC-3701 #9453

New Issue

admin · 2026-01-22T16:04:22+01:00

admin commented

2026-01-22 16:04:22 +01:00

Original Pull Request: https://github.com/doctrine/orm/pull/1395

State: closed
Merged: No

This is about the DQL parser generating wrong SQL because conditions may end in the "ON" clause of a LEFT JOIN instead of the WHERE clause (http://www.doctrine-project.org/jira/browse/DDC-3697).

It also fixes that the parser may be too sloppy on expected tokens, for example accepting a WHERE instead of WITH (http://www.doctrine-project.org/jira/browse/DDC-3701) or identifiers with backslashes like in SELECT \foo.bar\baz FROM.... The first problem probably would have surfaced earlier with this strict check in place.

**Original Pull Request:** https://github.com/doctrine/orm/pull/1395 **State:** closed **Merged:** No --- This is about the DQL parser generating wrong SQL because conditions may end in the "ON" clause of a LEFT JOIN instead of the WHERE clause (http://www.doctrine-project.org/jira/browse/DDC-3697). It also fixes that the parser may be too sloppy on expected tokens, for example accepting a WHERE instead of WITH (http://www.doctrine-project.org/jira/browse/DDC-3701) or `identifier`s with backslashes like in `SELECT \foo.bar\baz FROM...`. The first problem probably would have surfaced earlier with this strict check in place.

admin added the pull-request label 2026-01-22 16:04:22 +01:00

admin referenced this issue

2026-01-22 16:11:22 +01:00

[PR #9453] Support enums in findBy() calls #11626

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#9453