mirror of
https://github.com/doctrine/orm.git
synced 2026-03-24 06:52:09 +01:00
Allow EntityRepository::FindBy to accept a Criteria object or array. #6136
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @PyRowMan on GitHub (Dec 14, 2018).
Feature Request
In order to do advanced where clauses select (greaterThan, lesserThan, equals...).
Would it be possible to allow the method EntityRepository::FindBy to take a Criteria object OR an array of params.
It would be easier to perform some advanced where clauses.
Summary
Since I don't usually work inside the doctrine project, I don't really know what are the impacts of this request. I saw that there is one or two interfaces to modify, and some recovering parameter way, but this is only for the MySQL driver.
@Ocramius commented on GitHub (Dec 14, 2018):
I'd rather say that a separate
findByCriteria()would be preferable, over having a union type.@dlgoodchild commented on GitHub (Aug 12, 2020):
I've just come across this from wondering how to specify operators for the
findBycriteria array.I think having a
findByCriteriaandfindOneByCriteriawould be a great addition here.@Ocramius commented on GitHub (Aug 12, 2020):
Are you perhaps looking for https://github.com/doctrine/orm/blob/v2.7.3/lib/Doctrine/ORM/EntityRepository.php#L281?
@dlgoodchild commented on GitHub (Aug 12, 2020):
Mmm that seems to be quite different to the
find...methods and it recieves only a single Criteria object (and returns a Collection), seems a bit inconsistent and I can't find the documentation coveringmatching.@beberlei commented on GitHub (Dec 6, 2020):
Yes
EntityRepository::matchingis the solution here. Different API is needed so you can support lazy and subfiltering.