[PR #845] Don't compute changeset for entities that are going to be deleted #8792

Closed
opened 2026-01-22 16:01:44 +01:00 by admin · 0 comments
Owner

Original Pull Request: https://github.com/doctrine/orm/pull/845

State: closed
Merged: Yes


This is somewhat related to

http://www.doctrine-project.org/jira/browse/DDC-2761

I'm not sure if it fixes that particular problem, but it certainly helps with some unrelated issues I'm seeing in my code. My theory is that doctrine doesn't even need to compute changesets when an entity is scheduled to be removed, because all that would accomplish is to insert an UPDATE statement immediately before the DELETE statement for the entity.

The test suite passes, but I have not added a test specifically for this change (mostly because I wouldn't know exactly what to test). I could try to create one if necessary, though

**Original Pull Request:** https://github.com/doctrine/orm/pull/845 **State:** closed **Merged:** Yes --- This is somewhat related to http://www.doctrine-project.org/jira/browse/DDC-2761 I'm not sure if it fixes that particular problem, but it certainly helps with some unrelated issues I'm seeing in my code. My theory is that doctrine doesn't even need to compute changesets when an entity is scheduled to be removed, because all that would accomplish is to insert an UPDATE statement immediately before the DELETE statement for the entity. The test suite passes, but I have not added a test specifically for this change (mostly because I wouldn't know exactly what to test). I could try to create one if necessary, though
admin added the pull-request label 2026-01-22 16:01:44 +01:00
admin closed this issue 2026-01-22 16:01:45 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#8792