doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-23 22:42:18 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #698] [CLOSED] Fix for [DDC-2506] CTI JOINs and WITH conditionals #8577

New Issue
Open
opened 2026-01-22 16:00:36 +01:00 by admin · 0 comments
admin commented 2026-01-22 16:00:36 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/698
Author: @mattjanssen
Created: 6/14/2013
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (10+)

  • 29f41b5 Fix to SqlWalker for CTI table join with conditional.
  • 5c45de1 Added unit test for DDC-2506.
  • 0feed7d Implemented support for RepositoryFactory.
  • bc270c4 Fixed wrong interface.
  • 4ed4a87 Reducing dependency on RepositoryFactory by providing EntityManager as a getRepository argument.
  • f16f1e4 Reduced granularity of DefaultRepositoryFactory reference to ObjectRepository instances, in cases where consumers are completely rewrote EntityRepository.
  • 00fb1ab Updated since php doc tag.
  • 3e838a6 Update getting-started.rst
  • ffb9b4d list_bugs.php needs to call to getters for protected vars
  • 1495afc added badges

📊 Changes

18 files changed (+699 additions, -64 deletions)

View changed files

📝 .travis.yml (+0 -3)
📝 README.markdown (+3 -0)
📝 docs/en/tutorials/getting-started.rst (+4 -4)
📝 lib/Doctrine/ORM/Configuration.php (+36 -10)
📝 lib/Doctrine/ORM/EntityManager.php (+15 -31)
➕ lib/Doctrine/ORM/Mapping/AnsiQuoteStrategy.php (+97 -0)
📝 lib/Doctrine/ORM/PersistentCollection.php (+11 -0)
📝 lib/Doctrine/ORM/Persisters/ManyToManyPersister.php (+18 -0)
📝 lib/Doctrine/ORM/Persisters/OneToManyPersister.php (+18 -0)
📝 lib/Doctrine/ORM/Query/Parser.php (+6 -0)
📝 lib/Doctrine/ORM/Query/SqlWalker.php (+10 -9)
➕ lib/Doctrine/ORM/Repository/DefaultRepositoryFactory.php (+77 -0)
➕ lib/Doctrine/ORM/Repository/RepositoryFactory.php (+41 -0)
📝 tests/Doctrine/Tests/ORM/Functional/ExtraLazyCollectionTest.php (+98 -6)
📝 tests/Doctrine/Tests/ORM/Functional/Ticket/DDC2359Test.php (+4 -1)
➕ tests/Doctrine/Tests/ORM/Functional/Ticket/DDC2519Test.php (+85 -0)
➕ tests/Doctrine/Tests/ORM/Mapping/AnsiQuoteStrategyTest.php (+148 -0)
📝 tests/Doctrine/Tests/ORM/Query/SelectSqlGenerationTest.php (+28 -0)

📄 Description

http://www.doctrine-project.org/jira/browse/DDC-2506

Moved SqlWalker::walkConditionalExpression() out of walkJoin() and into walkJoinAssociationDeclaration() after the base class JOIN but before _generateClassTableInheritanceJoins() thus fixing WITH conditions in Class Table Inheritance JOINs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/698 **Author:** [@mattjanssen](https://github.com/mattjanssen) **Created:** 6/14/2013 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`29f41b5`](https://github.com/doctrine/orm/commit/29f41b5b3a898751ee595881248418b7560846c5) Fix to SqlWalker for CTI table join with conditional. - [`5c45de1`](https://github.com/doctrine/orm/commit/5c45de1240439a8e75f3283614082042609f28bb) Added unit test for DDC-2506. - [`0feed7d`](https://github.com/doctrine/orm/commit/0feed7d5c4ca322fcf060a02af1d06fbfebca536) Implemented support for RepositoryFactory. - [`bc270c4`](https://github.com/doctrine/orm/commit/bc270c4f212a9ba1a0a847212acdc0fdc4b0c8f8) Fixed wrong interface. - [`4ed4a87`](https://github.com/doctrine/orm/commit/4ed4a876e6dec2b5d12f3696b2bd60d56d8e1a55) Reducing dependency on RepositoryFactory by providing EntityManager as a getRepository argument. - [`f16f1e4`](https://github.com/doctrine/orm/commit/f16f1e4278f9020964b3e62a6c130f5375bd5dff) Reduced granularity of DefaultRepositoryFactory reference to ObjectRepository instances, in cases where consumers are completely rewrote EntityRepository. - [`00fb1ab`](https://github.com/doctrine/orm/commit/00fb1abaa7894fcf64846143a45eed95e6b76a54) Updated since php doc tag. - [`3e838a6`](https://github.com/doctrine/orm/commit/3e838a664f7fa4e75f04fca71c160f6d5db2f606) Update getting-started.rst - [`ffb9b4d`](https://github.com/doctrine/orm/commit/ffb9b4d8d6b44a923c3f32752a274cf542786a2b) list_bugs.php needs to call to getters for protected vars - [`1495afc`](https://github.com/doctrine/orm/commit/1495afcdb7a497b74bee274abc581798e086efff) added badges ### 📊 Changes **18 files changed** (+699 additions, -64 deletions) <details> <summary>View changed files</summary> 📝 `.travis.yml` (+0 -3) 📝 `README.markdown` (+3 -0) 📝 `docs/en/tutorials/getting-started.rst` (+4 -4) 📝 `lib/Doctrine/ORM/Configuration.php` (+36 -10) 📝 `lib/Doctrine/ORM/EntityManager.php` (+15 -31) ➕ `lib/Doctrine/ORM/Mapping/AnsiQuoteStrategy.php` (+97 -0) 📝 `lib/Doctrine/ORM/PersistentCollection.php` (+11 -0) 📝 `lib/Doctrine/ORM/Persisters/ManyToManyPersister.php` (+18 -0) 📝 `lib/Doctrine/ORM/Persisters/OneToManyPersister.php` (+18 -0) 📝 `lib/Doctrine/ORM/Query/Parser.php` (+6 -0) 📝 `lib/Doctrine/ORM/Query/SqlWalker.php` (+10 -9) ➕ `lib/Doctrine/ORM/Repository/DefaultRepositoryFactory.php` (+77 -0) ➕ `lib/Doctrine/ORM/Repository/RepositoryFactory.php` (+41 -0) 📝 `tests/Doctrine/Tests/ORM/Functional/ExtraLazyCollectionTest.php` (+98 -6) 📝 `tests/Doctrine/Tests/ORM/Functional/Ticket/DDC2359Test.php` (+4 -1) ➕ `tests/Doctrine/Tests/ORM/Functional/Ticket/DDC2519Test.php` (+85 -0) ➕ `tests/Doctrine/Tests/ORM/Mapping/AnsiQuoteStrategyTest.php` (+148 -0) 📝 `tests/Doctrine/Tests/ORM/Query/SelectSqlGenerationTest.php` (+28 -0) </details> ### 📄 Description http://www.doctrine-project.org/jira/browse/DDC-2506 Moved `SqlWalker::walkConditionalExpression()` out of `walkJoin()` and into `walkJoinAssociationDeclaration()` after the base class JOIN but **before** `_generateClassTableInheritanceJoins()` thus fixing WITH conditions in _Class Table Inheritance_ JOINs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
admin added the pull-request label 2026-01-22 16:00:36 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#8577
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?