[PR #761] [CLOSED] Add table alias to column names #8673

New Issue

admin · 2026-01-22T16:01:00+01:00

admin commented

2026-01-22 16:01:00 +01:00

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/761
Author: @patrickli
Created: 8/19/2013
Status: ❌ Closed

Base: master ← Head: m2m-table-alias

📝 Commits (10+)

3e53d9d Changed commands to use command.name in the help
5b55739 Moved implementation from EntityRepository to EntityManager. This decouples ER implementation from EM, as it should be.
2389f77 Fixed DefaultRepositoryClassName which should follow the Persistence interface, not ORM class.
2158a07 [2.3] Use HelperSet in cli-config.php
ac9df05 Fixed is_subclass_of comparing an interface which brought our requirement to 5.3.9. Changed to reflection approach which still keep us at the same dependency as before.
369a30a Added the new DBAL 2.3 types in the EntityGenerator typehint map
bd1e6ac Merge pull request #410 from igorw/helper-set
13d32e6 Merge remote-tracking branch 'origin/2.3' into 2.3
ef27721 Merge remote-tracking branch 'origin/2.3' into 2.3
dfa6ff6 DDC-1939 - Removing references to non-existing AssociationMapping class

📊 Changes

104 files changed (+3434 additions, -678 deletions)

View changed files

📝 UPGRADE.md (+8 -0)
📝 composer.json (+2 -2)
📝 doctrine-mapping.xsd (+1 -0)
📝 lib/Doctrine/ORM/AbstractQuery.php (+17 -1)
📝 lib/Doctrine/ORM/EntityRepository.php (+5 -3)
➕ lib/Doctrine/ORM/Id/BigIntegerIdentityGenerator.php (+66 -0)
📝 lib/Doctrine/ORM/Id/IdentityGenerator.php (+9 -5)
📝 lib/Doctrine/ORM/Internal/Hydration/ArrayHydrator.php (+30 -23)
📝 lib/Doctrine/ORM/Internal/Hydration/ObjectHydrator.php (+4 -3)
📝 lib/Doctrine/ORM/Internal/Hydration/SimpleObjectHydrator.php (+4 -1)
📝 lib/Doctrine/ORM/Mapping/ClassMetadataFactory.php (+18 -12)
📝 lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php (+8 -3)
📝 lib/Doctrine/ORM/Mapping/DefaultNamingStrategy.php (+1 -1)
📝 lib/Doctrine/ORM/Mapping/Driver/AnnotationDriver.php (+0 -37)
📝 lib/Doctrine/ORM/Mapping/Driver/DatabaseDriver.php (+6 -1)
📝 lib/Doctrine/ORM/Mapping/Driver/XmlDriver.php (+29 -11)
📝 lib/Doctrine/ORM/Mapping/Driver/YamlDriver.php (+8 -1)
📝 lib/Doctrine/ORM/Mapping/MappingException.php (+2 -2)
📝 lib/Doctrine/ORM/Mapping/NamingStrategy.php (+1 -2)
📝 lib/Doctrine/ORM/Mapping/UnderscoreNamingStrategy.php (+1 -1)

...and 80 more files

📄 Description

ManyToManyPersister does not add table alias to column names in multi-table SELECT queries. This will cause SQL servers complain about condition columns in where clause are ambiguous.

Replaces #760.

The commit I want to merge is 6229f3e.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/761 **Author:** [@patrickli](https://github.com/patrickli) **Created:** 8/19/2013 **Status:** ❌ Closed **Base:** `master` ← **Head:** `m2m-table-alias` --- ### 📝 Commits (10+) - [`3e53d9d`](https://github.com/doctrine/orm/commit/3e53d9d79c62dd401232561277900db29077aaed) Changed commands to use command.name in the help - [`5b55739`](https://github.com/doctrine/orm/commit/5b55739990e9407fc8c815de29763b7da065e0c2) Moved implementation from EntityRepository to EntityManager. This decouples ER implementation from EM, as it should be. - [`2389f77`](https://github.com/doctrine/orm/commit/2389f77d915230974146621cff2b18c59f0c2298) Fixed DefaultRepositoryClassName which should follow the Persistence interface, not ORM class. - [`2158a07`](https://github.com/doctrine/orm/commit/2158a0788eb5a92132ca1f163f8d900147d2c123) [2.3] Use HelperSet in cli-config.php - [`ac9df05`](https://github.com/doctrine/orm/commit/ac9df05c92394a93b07e0b109e535a6d0caf1272) Fixed is_subclass_of comparing an interface which brought our requirement to 5.3.9. Changed to reflection approach which still keep us at the same dependency as before. - [`369a30a`](https://github.com/doctrine/orm/commit/369a30ad3d481de58f7d8a50e4d1b3b07053f668) Added the new DBAL 2.3 types in the EntityGenerator typehint map - [`bd1e6ac`](https://github.com/doctrine/orm/commit/bd1e6ac30941796b70c172445b1e3341ccc5f7b9) Merge pull request #410 from igorw/helper-set - [`13d32e6`](https://github.com/doctrine/orm/commit/13d32e6de59e7a428ea26f0688145efefb2d88ae) Merge remote-tracking branch 'origin/2.3' into 2.3 - [`ef27721`](https://github.com/doctrine/orm/commit/ef27721db2abb6be8d674c954caa921419601390) Merge remote-tracking branch 'origin/2.3' into 2.3 - [`dfa6ff6`](https://github.com/doctrine/orm/commit/dfa6ff64c414d4d11a5d1873f6c648fe7d906285) DDC-1939 - Removing references to non-existing AssociationMapping class ### 📊 Changes **104 files changed** (+3434 additions, -678 deletions) <details> <summary>View changed files</summary> 📝 `UPGRADE.md` (+8 -0) 📝 `composer.json` (+2 -2) 📝 `doctrine-mapping.xsd` (+1 -0) 📝 `lib/Doctrine/ORM/AbstractQuery.php` (+17 -1) 📝 `lib/Doctrine/ORM/EntityRepository.php` (+5 -3) ➕ `lib/Doctrine/ORM/Id/BigIntegerIdentityGenerator.php` (+66 -0) 📝 `lib/Doctrine/ORM/Id/IdentityGenerator.php` (+9 -5) 📝 `lib/Doctrine/ORM/Internal/Hydration/ArrayHydrator.php` (+30 -23) 📝 `lib/Doctrine/ORM/Internal/Hydration/ObjectHydrator.php` (+4 -3) 📝 `lib/Doctrine/ORM/Internal/Hydration/SimpleObjectHydrator.php` (+4 -1) 📝 `lib/Doctrine/ORM/Mapping/ClassMetadataFactory.php` (+18 -12) 📝 `lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php` (+8 -3) 📝 `lib/Doctrine/ORM/Mapping/DefaultNamingStrategy.php` (+1 -1) 📝 `lib/Doctrine/ORM/Mapping/Driver/AnnotationDriver.php` (+0 -37) 📝 `lib/Doctrine/ORM/Mapping/Driver/DatabaseDriver.php` (+6 -1) 📝 `lib/Doctrine/ORM/Mapping/Driver/XmlDriver.php` (+29 -11) 📝 `lib/Doctrine/ORM/Mapping/Driver/YamlDriver.php` (+8 -1) 📝 `lib/Doctrine/ORM/Mapping/MappingException.php` (+2 -2) 📝 `lib/Doctrine/ORM/Mapping/NamingStrategy.php` (+1 -2) 📝 `lib/Doctrine/ORM/Mapping/UnderscoreNamingStrategy.php` (+1 -1) _...and 80 more files_ </details> ### 📄 Description `ManyToManyPersister` does not add table alias to column names in multi-table `SELECT` queries. This will cause SQL servers complain about condition columns in where clause are ambiguous. Replaces #760. The commit I want to merge is 6229f3e. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-22 16:01:00 +01:00

admin closed this issue

2026-01-22 16:01:01 +01:00

admin referenced this issue

2026-01-22 16:09:48 +01:00

[PR #8673] Add hint for ->iterate() deprecation #11123

Sign in to join this conversation.