doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-24 06:52:09 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #433] [MERGED] DDC-2003 - DateTime conditions in Criteria objects result in errors #8188

New Issue
Open
opened 2026-01-22 15:58:48 +01:00 by admin · 0 comments
admin commented 2026-01-22 15:58:48 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/433
Author: @Josiah
Created: 8/31/2012
Status: ✅ Merged
Merged: 9/5/2012
Merged by: @beberlei

Base: master ← Head: DDC-2003

📝 Commits (5)

  • 783c53d Added a failing test for DDC-2003
  • c7f5d9d Fixed DDC-2003 using closures to reference the functionality of the calling entity persister from the SQL value visitor.
  • a6b6b25 Removed the closure keyword as it isn't supported in PHP 5.3
  • e0d1633 Fixed formatting issues identified by Stof
  • 959c4f0 Refactored the SqlValueVisitor to move all type processing to the entity persister.

📊 Changes

3 files changed (+105 additions, -30 deletions)

View changed files

📝 lib/Doctrine/ORM/Persisters/BasicEntityPersister.php (+16 -2)
📝 lib/Doctrine/ORM/Persisters/SqlValueVisitor.php (+2 -28)
➕ tests/Doctrine/Tests/ORM/Functional/EntityRepositoryCriteriaTest.php (+87 -0)

📄 Description

No description provided

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/433 **Author:** [@Josiah](https://github.com/Josiah) **Created:** 8/31/2012 **Status:** ✅ Merged **Merged:** 9/5/2012 **Merged by:** [@beberlei](https://github.com/beberlei) **Base:** `master` ← **Head:** `DDC-2003` --- ### 📝 Commits (5) - [`783c53d`](https://github.com/doctrine/orm/commit/783c53d57c622b10a182a2db99dab322296b4556) Added a failing test for DDC-2003 - [`c7f5d9d`](https://github.com/doctrine/orm/commit/c7f5d9d77de7c3ffde23e841d815bb2440b994bf) Fixed DDC-2003 using closures to reference the functionality of the calling entity persister from the SQL value visitor. - [`a6b6b25`](https://github.com/doctrine/orm/commit/a6b6b2526783a791ffa35c6811c7e220a375c7df) Removed the closure keyword as it isn't supported in PHP 5.3 - [`e0d1633`](https://github.com/doctrine/orm/commit/e0d16331a49d1146f66d04eab23df23cf0daa412) Fixed formatting issues identified by Stof - [`959c4f0`](https://github.com/doctrine/orm/commit/959c4f026f93aadbcf985a6eff47e56b445d6ebe) Refactored the SqlValueVisitor to move all type processing to the entity persister. ### 📊 Changes **3 files changed** (+105 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/Persisters/BasicEntityPersister.php` (+16 -2) 📝 `lib/Doctrine/ORM/Persisters/SqlValueVisitor.php` (+2 -28) ➕ `tests/Doctrine/Tests/ORM/Functional/EntityRepositoryCriteriaTest.php` (+87 -0) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
admin added the pull-request label 2026-01-22 15:58:48 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#8188
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?