Grégoire Paris
418587bc25
Merge remote-tracking branch 'origin/2.7' into 2.8.x
2020-12-03 20:18:13 +01:00
Grégoire Paris
01187c9260
Remove trailing whitespaces ( #8360 )
...
Stylistically, it's not great to have them, but more importantly, the
latest symfony/yaml version has issues with trailing whitespaces.
2020-12-03 09:52:14 +01:00
Benjamin Eberlei
404edd418b
[GH-8229] Prevent Illegal Inheritance Override ( #8348 )
...
* [GH-8229] Prevent AttributeOverride on fields from entities, only allowed for MappedSuperclass
* [GH-8229] Prevent AssociationOverride on fields from entities, only allowed for MappedSuperclass
* Revert "Fix SQL alias generation regression for simple inheritance (#8329 )"
This reverts commit f4ebded63c .
* [GH-8229] Finalize checks for illegal attribute/assocation overrides.
* [GH-8229] Revert ccae8f7176 PR #8234
* [GH-8229] Update documentation to clarify only mapped superclass or trait works with overrides
* [GH-8229] Fix style violations introduced by revert
* [GH-8229] Fix style violations introduced by revert
* [GH-8229] Temporarily disable the exception until 2.8.
* Make phpcs happy
2020-11-25 23:04:56 +01:00
Claudio Zizza
011d3c21eb
Update functionality of code examples ( #8336 )
2020-11-24 22:39:42 +01:00
Benjamin Eberlei
3d46e07887
PHP8 Support ( #8303 )
...
* Update doctrine/dbal to 2.12 for PHP 8 support.
* Change Query\Parser::match to Query\Parser::matchToken including DQL functions.
* Fix phpunit constraint to 9.4, adjust @group usage to workaround PHPUnit bug.
* Fix PHPUnit API related changes.
* Add PHP 8 support for EntityGenerator namespace detection.
* Use new assertEqualsWithDetla for QueryDqlFunctionTest with date comparisons
* Replace ReflectionParameter::getClass usage with non-deprecated ::getType instead.
* Revert "Change Query\Parser::match to Query\Parser::matchToken including DQL functions."
This reverts commit 279070491d50deaa4d41e17b28bb5a68f5a22796.
* More matchToken => match reverts
* Housekeeping: phpcs
* Housekeeping: phpcs
* Housekeeping: phpcs
* Housekeeping: phpcs
* Add PHP 8 testrunner, update composer.json and small fix in OrmFunctionalTestCase for new PHPUnit behvaior
* Update doctrine/coding-standard to 8.x
* Update rule names for doctrine/coding-standard v8.0
* Update to Psalm 4.
* Not failOnWarning anymore.
* Fix phpcs
* fix phpcs
* remove 7.2 for now until we can support in DBAL.
* Relax doctrine/dbal requirement and add 7.2 CI support again.
2020-11-15 13:24:31 +01:00
Roma
b1ac293a50
Add missing backtick in rst markup ( #8335 )
2020-11-10 20:37:36 +01:00
Romain Grégoire
f4ebded63c
Fix SQL alias generation regression for simple inheritance ( #8329 )
...
This fixes a regression from 099c5b42e1 .
Without the fix, "where part" in SQL is generated with incorrect aliases.
See https://github.com/doctrine/orm/issues/8229#issuecomment-722942180 .
2020-11-10 10:53:01 +01:00
Benjamin Eberlei
51bc596502
Update to Psalm 4. ( #8332 )
2020-11-08 10:38:21 +01:00
Grégoire Paris
95f1b48422
Merge remote-tracking branch 'origin/2.7' into 2.8.x
2020-11-07 20:19:45 +01:00
Grégoire Paris
385b5a2f80
Phpunit 8 ( #8330 )
...
* Revert to whitelist
coverage requires PHPunit 9, and we don't have that yet.
* Upgrade to PHPUnit 8
This unlocks PCOV usage for coverage
* Upload coverage files to Codecov
2020-11-07 19:41:15 +01:00
Benjamin Eberlei
f7d8b155db
Merge branch '2.7' into 2.8.x
2020-11-07 18:37:53 +01:00
Benjamin Eberlei
fa6fe09647
Ignore composer.lock
2020-11-07 18:37:46 +01:00
Benjamin Eberlei
539ffea390
Merge 2.7 into 2.8.x
2020-11-07 18:30:32 +01:00
Benjamin Eberlei
c270eba678
Start moving travis phpunit runs to Github actions. ( #8317 )
...
* Move PHPUnit runs from Travis to Github Actions
This removes all artifacts used for TravisCI testing and replaces them
with the existing infrastructure for Github Actions from DBAL component.
In addition some test changes were needed and triggered larger Coding
Style cleanups in 3 test files.
* Remove composer.lock and improve naming in CI workflow.
2020-11-07 18:11:42 +01:00
Michael Käfer
2f0eb95c90
Patch 1 ( #8325 )
...
* Update outdated doc parts
- The cache implementation moved from `Common` to `doctrine/cache`
- APCu is mor appropiate nowadays I guess
- AbstractQuery::useResultCache() is deprecated since 2.7
* Fix wrong argument
* Fix wrong arguments and remove useless line
2020-10-31 12:13:48 +01:00
Grégoire Paris
b13b2e8bab
Upgrade doctrine/coding-standard ( #8321 )
...
* Use a classname that exists
Doctrine\ORM\Mapping\TableGenerator does not exist, only
Doctrine\ORM\Id\TableGenerator does.
* Upgrade doctrine/coding-standard
That library has a dependency on another library that requires composer
plugin API v1. Updating both libs allow to use Composer v2.
* Account for doctrine/reflection deprecation
2020-10-28 11:14:10 +01:00
Simon Podlipsky
4bfc84f035
Rename getIterable() to toIterable() (part 2) ( #8293 )
2020-10-17 23:55:39 +02:00
Michael Voříšek
ca27cc3f72
Fix EOL of text files ( #8310 )
2020-10-17 19:04:42 +02:00
Mateusz Sip
53dc5b2ac3
Detect associations inside embeddables ( #8291 )
2020-10-17 18:49:16 +02:00
orklah
f1219f1418
Add psalm template support to several types ( #8289 )
2020-10-17 12:01:52 +02:00
Grégoire Paris
072066f746
Merge remote-tracking branch 'origin/2.7' into 2.8.x
2020-10-17 11:07:05 +02:00
Laurent VOULLEMIER
5fde5801c1
Fix many typos ( #8299 )
...
- Some uppercase letters were used in the middle of sentence
- Some dots were missing
- There was two sentences with wrong or missing words
2020-10-13 21:52:04 +02:00
Thomas Landauer
18d96fcc02
Update working-with-indexed-associations.rst ( #8298 )
...
* Update working-with-indexed-associations.rst
Fixing broken link
* Update docs/en/tutorials/working-with-indexed-associations.rst
Co-authored-by: Claudio Zizza <859964+SenseException@users.noreply.github.com >
Co-authored-by: Claudio Zizza <859964+SenseException@users.noreply.github.com >
2020-10-12 21:27:18 +02:00
Benjamin Eberlei
4d2908a065
Change <phpunit verbose="true" /> to false for better readability of test output.
2020-10-11 19:14:47 +02:00
Benjamin Eberlei
8d250f5921
Use SHELL_VERBOSITY=3 instead of LOG_LEVEL=DEBUG
2020-10-11 12:03:57 +02:00
Benjamin Eberlei
59fd9b5ea7
Change LOG_LEVEL to debug should expose more info from laminas/automatic-releases.
2020-10-11 00:17:52 +02:00
Benjamin Eberlei
8fcc70cfbe
Change LOG_LEVEL to debug should expose more info from laminas/automatic-releases.
2020-10-11 00:14:35 +02:00
Grégoire Paris
7d84a49980
Setup automated release workflow ( #8301 )
2020-10-10 19:11:26 +02:00
Claudio Zizza
bb64fc953d
Move website config to default branch ( #8287 )
...
Adds the website config to be compatible with the doctrine/doctrine-website#356 changes
2020-10-02 20:31:00 +02:00
orklah
e0eb82a3b1
psalm fixes ( #8286 )
2020-09-30 22:00:38 +02:00
orklah
79cdcde9ec
rename parameters to match parents ( #8284 )
2020-09-26 20:24:11 +02:00
orklah
f4524a8bb0
Fix psalm errors and upgrade strictness ( #8209 )
...
* Fixes and improvements
* fix param type
2020-09-25 20:44:07 +02:00
Simon Podlipsky
f1365b78d5
Rename getIterable to toIterable ( #8268 )
2020-09-25 20:42:09 +02:00
Grégoire Paris
d810ea4111
Use inline literals over escaping ( #8279 )
...
Escaping underscores does not work as expected.
See https://www.doctrine-project.org/projects/doctrine-orm/en/latest/cookbook/dql-custom-walkers.html#modify-the-output-walker-to-generate-vendor-specific-sql
2020-09-22 20:10:05 +02:00
Michael Voříšek
107ba93d79
Convert CRLF to LF in test file ( #8276 )
...
* Convert CRLF to LF in test file
* fix cs
2020-09-21 22:51:49 +02:00
Guillaume Simon
706670215d
Fix OrderByItem parser to proceed with SimpleArithmetic expression before function ( #8277 )
...
There is parser bug for OrderByItem(), where a function is detected
before a SimpleArithmeticExpression while it should be the reverse:
simple arithmetic expressions can start with a function too, and thus
they should be matched first if present.
This fix enables the use of expressions in sorting and with window
functions.
2020-09-20 18:56:57 +02:00
Yohann Durand
ab2b4987b3
Improve formatting ( #8028 )
2020-09-08 20:56:51 +02:00
Thomas Landauer
717ef9106c
Update events.rst ( #8257 )
...
* Update events.rst
Improved code formatting
* Update docs/en/reference/events.rst
I was wondering myself what the `#` was about ;-)
Co-authored-by: Claudio Zizza <859964+SenseException@users.noreply.github.com >
* Update events.rst
See https://github.com/doctrine/orm/pull/8257#discussion_r482305774
Co-authored-by: Claudio Zizza <859964+SenseException@users.noreply.github.com >
2020-09-03 22:44:28 +02:00
Christoph Ziegenberg
ccae8f7176
Fix for bug #8229 (id column from parent class renamed in child class) ( #8234 )
...
This fixes problems with id columns defined in the parent class but renamed in the child class using an attribute override. Before this change always the child column name was used (which was not present in the parent class), now the correct column names are used for the parent table when creating inserts, joins and deletions for it.
Co-authored-by: Crossjoin <crossjoin@users.noreply.github.com >
2020-08-29 13:25:18 +02:00
Grégoire Paris
da18985aca
Stop using the DBAL extension of PHPBench ( #8252 )
...
It has been removed, and the default XML storage driver is supposed to
be fine for our purposes.
2020-08-29 12:28:40 +02:00
Simon Podlipsky
60cd524443
Introduce getIterable() on AbstractQuery ( #7885 )
2020-08-14 11:12:40 +02:00
Simon Podlipsky
045d1f3bf2
Bump Doctrine CS to v6 ( #8241 )
2020-08-13 09:10:43 +02:00
Grégoire Paris
1ae6f18fe9
Merge remote-tracking branch 'origin/2.7' into 2.8.x
2020-08-12 22:26:19 +02:00
Simon Podlipsky
1e2ed07731
Use consistent formatting in command line ( #8238 )
2020-08-12 08:38:00 +02:00
Grégoire Paris
424241f29c
Use more accurate terminology ( #8236 )
...
I think this was a mistake when writing this documentation, and that the
original author meant to use attribute here, columns do not have
columns, they have attributes.
2020-08-09 22:48:52 +02:00
Grégoire Paris
8230afcde9
Fetch deeper
...
This is needed to preserve parent information and be able to find the
merge base with the head branch. The assumption here is that the common
ancestor can be found among the 10 parent commits.
2020-08-07 22:11:21 +02:00
Kirill Matasov
7cffba8743
Fix annotation in Expr
2020-08-07 22:11:21 +02:00
Zacharias Luiten
91b9dd90f4
Add DQL support for ORDER BY CASE ( #8188 )
2020-08-05 22:49:51 +02:00
Benjamin Cremer
7e5fe79349
Change preferred cache driver for metadata and query caches ( #8223 )
...
See: https://twitter.com/lcobucci/status/1289087725694484481
2020-08-03 21:40:52 +02:00
njutn95
efd25484f4
Update aggregate-fields.rst ( #8215 )
...
Minor typo fix
2020-07-20 21:19:16 +02:00
Andreas Möller
271f3480c8
Fix: Typo ( #8213 )
2020-07-15 22:46:25 +02:00
orklah
aab589b596
add/fix more types (checked by psalm) ( #8199 )
...
* add/fix more psalm types
* remove inexistant SimpleEntityExpression
* Declare template implements for TreeWalkerChainIterator
2020-07-10 22:08:13 +02:00
orklah
190218b267
Change list() syntax to array destructuring (short list syntax) ( #8204 )
2020-07-07 22:02:34 +02:00
Benjamin Eberlei
181114f2c7
[GH-8106] Move test into existing QueryTest testcase to reduce surface.
2020-07-05 21:51:35 +02:00
tom93
3689b76a86
Fix QueryBuilder::getParameter() on parameter names with colons ( #8107 )
...
* Fix type errors
(partially cherry picked from commit 17e7c2a42e )
* Fix QueryBuilder::getParameter() on parameter names with colons
Fixes #8106 .
Co-authored-by: Michael Moravec <mail@majkl578.cz >
2020-07-05 21:46:48 +02:00
Igor Pellegrini
75fe18ea5f
Add alert to "avoid persisting detached entities" ( #8109 )
...
The alert is hidden into the code of ``EntityManager``,
while it's useful to be mentioned in the documentation.
2020-07-05 20:24:08 +02:00
Grégoire Paris
6c73a6b720
Infer return type information with Psalter ( #8150 )
...
These changes are a subset of changes done with vendor/bin/psalm --alter
--issues=LessSpecificReturnType
--allow-backwards-incompatible-changes=false
2020-07-05 20:15:39 +02:00
Benjamin Eberlei
775d91c2a3
[GH-8122] Move test from AbstractMappingDriverTest to ClassMetadataFactoryTest case
2020-07-05 20:11:01 +02:00
Gildas Quéméner
64c3f68734
Prohibits class typo in the discriminator map ( #8122 )
...
* Prevents incorrect table aliases to be generated
When a defined subclass has a case typo, the query builder will be lost
and will generate exotic table alias. This commit fixes the issue at the
root by prohibiting case typo in discriminator map.
See https://github.com/doctrine/orm/pull/8112 for the consequence of
such typo.
* Controls growing rate of the abstract test class
* Fixes incorrect test case
The Cube class must be autoloaded with the correct case, otherwise
composer autoloader will complain.
* Removes non architecture compliant code
See https://github.com/doctrine/orm/pull/8122/files#r423952247
* Ensures discriminator map is case sensitive
2020-07-05 19:48:38 +02:00
Mohamed Ettaki Talbi
2a2a0b2980
Remove unwanted period ( #8198 )
2020-07-02 08:36:18 +02:00
Grégoire Paris
505d658e3d
Merge remote-tracking branch 'origin/2.7' into 2.8.x
2020-06-21 13:50:48 +02:00
vladyslavstartsev
a438e90046
add dev files to .gitattribute ( #8190 )
...
those files probably are not used by end user of the lib
2020-06-19 13:48:45 +02:00
Nicolas Grekas
6a670d7d6d
Allow using on PHP 7.1 with Composer 2 ( #8184 )
2020-06-18 23:05:13 +02:00
Grégoire Paris
765521d257
Use CodeCov instead of Scrutinizer ( #8187 )
...
* Document current branch status in the README
* Use CodeCov instead of Scrutinizer
2020-06-17 22:47:25 +02:00
Grégoire Paris
5ced62bf83
Run benchmark on PHP 7.4 ( #8186 )
...
phpbench recently dropped compatibilty with PHP 7.1
When this job was introduced, 7.1 was the latest version of PHP we
supported, so it makes sense to bump to 7.4 now.
See https://github.com/phpbench/phpbench/releases/tag/0.17.0
See e07c90df44
2020-06-17 22:06:42 +02:00
Grégoire Paris
bee8decd18
Require persistence 2 and common 3 ( #8166 )
...
This allows us to drop the autoload-calls-based BC layer.
2020-06-17 14:56:17 +02:00
Alexander Berl
93867f8d77
TASK: Replace "Blacklist" example with "Banlist" ( #8174 )
2020-06-08 23:06:53 +02:00
Laurent VOULLEMIER
6bce7e9cab
Add iterable support for IN criterias ( #8162 )
2020-06-03 18:40:53 +02:00
Grégoire Paris
4d8418fe6f
Merge remote-tracking branch 'origin/2.7' into drop-persistence-bc-layer
2020-06-02 18:40:48 +02:00
Grégoire Paris
d95e03ba66
Allow doctrine/common 3 and doctrine/persistence 2 ( #8158 )
2020-05-26 18:03:49 +02:00
Robert Basic
825ceb6b7a
Fix inline code example ( #8153 )
...
* Fix inline code example
* Remove extra backslash
2020-05-22 22:45:24 +02:00
orklah
de2e2a1d74
Add psalm types ( #7989 )
2020-05-18 21:48:28 +02:00
Benjamin Eberlei
850d57e791
[GH-8137] Update doctrine/inflector dependency to 1.4|2.0 ( #8147 )
...
* [GH-8137] Update doctrine/inflector dependency to 1.4|2.0 and resolve deprecations.
* [GH-8137] Address review comments
* Address phpcs issues.
* More CS
* Codingstyle
2020-05-17 19:58:02 +02:00
Grégoire Paris
c3dd71704b
Merge remote-tracking branch 'origin/2.7' into 2.8.x
2020-05-16 15:14:51 +02:00
Grégoire Paris
6780a963f7
Migrate git-phpcs to Github actions ( #8146 )
2020-05-16 14:01:10 +02:00
Philippe Le Van (@plv)
0b305e5bd3
Add possibility to use sql comments in the DQL syntax ( #8140 )
2020-05-15 08:04:58 +02:00
Benjamin Eberlei
4d172e2591
Revert changes to embeddable mapping in 2.7 ( #8138 )
...
* Revert "Fix inherited embeddables and nesting after AnnotationDriver change #8006 (#8036 )"
This reverts commit a9b6b72017 .
* Revert "Make Embeddable not transient"
This reverts commit 58677c29b4 .
* Housekeeping: CS fixes
2020-05-12 20:10:26 +02:00
Grégoire Paris
21a98234d0
Static analysis with Psalm ( #8116 )
...
* Remove useless ternaries
If these expressions are truish inside the condition, they will still be
truish inside the if.
* Describe properties more accurately
These are not objects, they are strings holding class names for classes
that implement TreeWalker.
* Remove duplicate key
Comparison::IS and Comparison::EQ are the same. I chose to remove IS
because it does not seem to exist anymore on master
* Remove unwanted . before = operator
This worked, but makes no sense.
* Setup static analysis with Psalm
* Move PHPStan to Github actions
2020-05-11 23:06:46 +02:00
Gabriel Birke
061207861b
Improve CLI config documentation ( #8130 )
...
Change code examples for `cli-config.php` to use
`ConsoleRunner::createHelperSet` instead of constructing the helper set
array yourself.
Remove DBAL-specific documentation
Co-authored-by: Claudio Zizza <859964+SenseException@users.noreply.github.com >
2020-05-11 21:43:26 +02:00
Grégoire Paris
8a9954e46c
Address deprecations from persistence ( #7953 )
...
A backwards-compatibility layer has been added to persistence to help
consumers move to the new namespacing. It is based on class aliases,
which means the type declaration changes should not be a BC-break: types
are the same.
See https://github.com/doctrine/persistence/pull/71
This means:
- using the new namespaces
- adding autoload calls for new types to types that may be extended and
use persistence types in type declarations of non-constructor methods,
so that signature compatibility is recognized by old versions of php.
More details on this at
https://dev.to/greg0ire/how-to-deprecate-a-type-in-php-48cf
2020-05-07 08:35:39 +02:00
Grzesiek
527fff53cc
removed repository class from metadata ( #8125 )
...
The annotation is required only in the next chapter of the tutorial, specifically the "Entity Repositories"
2020-05-03 21:58:20 +02:00
Maks Rafalko
70fb1ecd78
Warn users about performance issues with DateTime objects in setParameter() ( #8114 )
2020-04-25 22:16:17 +02:00
Jeroen van den Heuvel
73ec483e9d
Convert PHP to SQL for new object expression ( #8062 )
2020-04-16 23:01:43 +02:00
Mathieu
8d67eec812
Fix JoinColumn documentation ( #7966 )
2020-03-30 21:33:13 +02:00
Vincent Langlet
a418cf6418
Remove TODO ( #8078 )
2020-03-30 20:06:04 +02:00
Arne
6138afdca9
[Docs] Make clear that calling remove() detaches the object ( #8081 )
...
I changed a relationship from eager to lazy loading which broker the behaviour of my application in regards to object removal. It was not clear for me that removing an object detaches it and subsequent calls like contains() in a OneToMany relationship with the object scheduled for removal will return false afterwards.
2020-03-27 19:42:39 +01:00
Vincent Langlet
dafe298ce5
Fix phpdoc ( #8074 )
2020-03-19 07:41:02 +01:00
Matthias Pigulla
58b8130ea1
Fix regression in 2.7.1 when mysqli is used with discriminator column that is not a string ( #8055 )
...
* Add a test case showing the regression
* Cast the discriminator value to string
* Fix CS
2020-03-16 11:19:12 +01:00
Grégoire Paris
3c91792dd8
Address deprecation about PHPUnit annotations ( #8070 )
...
These changes have been done using Rector, this might not result in the
best placement for method calls, but it is not worse than the current
situation.
I used the configuration documented at
b398e8740c/docs/HowItWorks.md (221-order-of-rectors)
Fixes #8069
2020-03-16 08:56:59 +01:00
Benjamin Eberlei
a705f526fb
[GH-7633] disallow cache partial objects ( #8050 )
...
* [GH-7633] Bugfix: Partial queries were stored in 2LC.
There was a check in DefaultQueryCache that prevented partial queries,
because they are not supported. However the checked hint
Query::HINT_FORCE_PARTIAL_LOAD is optional, so cant be used to prevent
caching partial DQL queries.
Introduce a new hint that the SqlWalker sets on detecing a PARTIAL
query and throw an exception in the DefaultQueryCache if thats found.
* Housekeeping: CS
* [GH-7633] HINT_FORCE_PARTIAL_LOAD still needs to be checked.
* Housekeeping: Fix CS
2020-03-15 01:11:34 +01:00
Maciej Malarz
a9b6b72017
Fix inherited embeddables and nesting after AnnotationDriver change #8006 ( #8036 )
...
* Add test case
* Treat parent embeddables as mapped superclasses
* [GH-8031] Bugfix: Get working again on nested embeddables in inherited embeddables.
* Housekeeping: CS
* Update note on limitations
* [GH-8031] Verify assocations still do not work with Embeddables.
* Housekeeping: CS
Co-authored-by: Benjamin Eberlei <kontakt@beberlei.de >
2020-03-15 01:00:58 +01:00
Jorrit Schippers
cd905fff77
Fix documentation of default generated value behavior ( #8068 )
2020-03-13 20:40:31 +01:00
Claudio Zizza
431d0a3c5e
Remove ORM 2.0 version constraints from docs ( #8002 )
2020-03-06 21:47:40 +01:00
Andreas Möller
eb700405be
Fix: Use neutral pronouns ( #8059 )
2020-03-06 16:08:53 +01:00
Rosemary Orchard
9273057649
Annotations override naming strategy ( #8041 )
...
Add a note/warning that annotations override the naming strategy.
2020-03-01 14:01:26 +01:00
Soliman
1da002ca2f
Throw OptimisticLockException when connection::commit() returns… ( #7946 )
...
* Throw OptimisticLockException when connection::commit() returns false
* Update unit tests
* Fix doctrine persistence version to avoid deprecations changes
* Apply changes from 2.8.x
* Update from 2.8.x
2020-02-29 23:06:47 +01:00
Grégoire Paris
e04a79526e
Merge pull request #7230 from holtkamp/patch-2
...
Mention that lifecycle callbacks do not support Embeddables
2020-02-17 23:00:44 +01:00
Menno Holtkamp
d157a6cbeb
Mention that lifecycle callbacks do not support Embeddables
...
As discussed in https://github.com/doctrine/doctrine2/issues/6855
2020-02-17 22:25:00 +01:00
Benjamin Eberlei
ca57222010
Merge pull request #8023 from peterkeatingie/query-cache-fix
...
Put into cache using root entity name
2020-02-16 10:50:24 +01:00
Peter Keating
9bb2bf0cce
Put into cache using root entity name
2020-02-15 15:53:47 +00:00
Benjamin Eberlei
445796af0e
Travis: Use 7.4 instead of 7.4snapshot
2020-02-15 15:35:56 +01:00
Benjamin Eberlei
ab93285284
Remove nightly builds from .travis.yml
2020-02-15 15:34:36 +01:00
Benjamin Eberlei
ef639d4de6
Remove nightly builds from .travis.yml
2020-02-15 15:34:05 +01:00
Benjamin Eberlei
31f4dd671a
Merge remote-tracking branch 'origin/2.7' into 2.8.x
2020-02-13 21:31:29 +01:00
Benjamin Eberlei
a692670469
Merge pull request #8006 from doctrine/malarzm-patch-1
...
Make Embeddable not transient
2020-02-13 21:31:02 +01:00
Maciej Malarz
58677c29b4
Make Embeddable not transient
2020-02-13 21:05:52 +01:00
Benjamin Eberlei
60c4867ed3
Merge branch 2.7 into 2.8.x
2020-02-12 23:42:36 +01:00
Benjamin Eberlei
9a0fcb5a86
Merge pull request #7940 from doctrine/GH-7864-ExtraLazyRemoveElement
...
[GH-7864] Bugfix in PersistentCollection::removeElement for EXTRA_LAZY.
2020-02-12 23:42:06 +01:00
Benjamin Eberlei
0ee1716b26
Merge branch 2.7 into 2.8.x
2020-02-12 23:38:27 +01:00
Benjamin Eberlei
8104c65d6c
Merge pull request #7987 from beberlei/GH-7982-NoSqlExecutor
...
[GH-7982] no sql executor leads to parse error
2020-02-12 23:37:39 +01:00
Benjamin Eberlei
a64d254d07
[GH-7982] Bugfix: Passing string|null DQL to Lexer(string $input) leads to downstream notice.
2020-02-12 23:23:12 +01:00
Claudio Zizza
a236a83fa8
Merge pull request #7993 from SenseException/readme2-8
...
Update version and links in readme
2020-01-20 11:14:33 +01:00
Claudio Zizza
37f1bd7606
Update version and links in readme
2020-01-17 21:42:59 +01:00
Grégoire Paris
af4cb282ba
Merge pull request #7978 from alexeyshockov/patch-2
...
Stable PHP 7.4 in Travis
2020-01-17 07:49:48 +01:00
Benjamin Eberlei
ce4914ba0e
Merge 2.7 to 2.8.x
2020-01-17 00:08:23 +01:00
Benjamin Eberlei
fdad48278b
Merge pull request #7991 from greg0ire/7.4-sa
...
Try running phpstan on php 7.4
2020-01-17 00:06:40 +01:00
Benjamin Eberlei
fc94127d7f
Make ocramius/package-versions 1.2 the lowest version for phpstan
2020-01-16 23:51:17 +01:00
Grégoire Paris
dea3e5df44
Try running phpstan on php 7.4
...
It might be easier to find packages compatible with both our locked deps
and phpstan with that version of php.
2020-01-16 23:49:15 +01:00
Alexey Shokov
bdfd6c1677
Stable PHP 7.4 in Travis
2020-01-16 23:27:20 +01:00
Benjamin Eberlei
5d7d3e99a0
Downgrade ocramius/package-versions to lowest in composer.lock to support all PHP versions.
2020-01-16 23:18:00 +01:00
Benjamin Eberlei
3bc1096fd0
[GH-7982] Default Query state to dirty to fix execution of empty query.
2020-01-15 23:30:59 +01:00
Benjamin Eberlei
8e0157d97d
Merge branch '2.7' into 2.8.x
2020-01-15 22:57:06 +01:00
Benjamin Eberlei
a2f01f7ccc
Allow everything from ocramius/package-versions ^1.0.
2020-01-15 22:56:08 +01:00
Benjamin Eberlei
1767f4b8e7
Merge branch '2.7' into 2.8.x
2020-01-15 22:02:55 +01:00
Benjamin Eberlei
401db453a2
Merge pull request #7974 from beberlei/gh-7505
...
[GH-7505] Bug in SimpleObjectHydrator when using inheritance with same field
2020-01-15 22:02:25 +01:00
Benjamin Eberlei
6e59ec8f16
[GH-7505] Fix cs
2020-01-15 21:52:11 +01:00
Benjamin Eberlei
87e491465a
Add @group
2020-01-15 21:13:25 +01:00
Luís Cobucci
8b588eceb2
Merge pull request #7973 from DocFX/patch-1
...
Just a micro grammar update.
2020-01-14 11:26:21 +01:00
Benjamin Eberlei
edce36598f
Adjust tests back for 2.x.
2020-01-09 00:41:47 +01:00
Benjamin Eberlei
ca95b0ee13
Merge branch '2.7' into 2.8.x
2020-01-08 19:39:17 +01:00
Woody Gilk
20c46035d1
[Docs] Prefer PhpFileCache for caching and remove APC/XCache.
2020-01-08 19:36:08 +01:00
William Pinaud
324aacfb54
Just a micro grammar update.
2020-01-08 18:52:11 +01:00
Benjamin Eberlei
1edfcabead
Merge pull request #7894 from TomckySan/convert-default-value-to-boolean
...
Fix boolean properties default value when generating entities.
2020-01-05 16:11:33 +01:00
Luís Cobucci
2785cde792
Merge pull request #7957 from lcobucci/fix-version-information
...
Fix version information
2019-12-17 19:19:05 +01:00
Luís Cobucci
d67e3e8b1b
Rely on ocramius/package-versions to render the version
...
Since `Doctrine\ORM\Version` is now deprecated it shall not be updated
on future releases.
This ensures that our CLI tool will present the correct version number.
2019-12-17 15:47:55 +01:00
Luís Cobucci
d629c4e487
Remove build.xml and related files
...
We aren't using ant/phing to handle the releases any more.
2019-12-17 01:03:34 +01:00
Luís Cobucci
4a4226213f
Merge pull request #7875 from nicolas-grekas/schema-tool
...
Whilelist existing assets we know about from metadata in SchemaTool::getUpdateSchemaSql()
2019-12-16 23:59:31 +01:00
Andreas Braun
0ce1440884
Add upgrade note about schema_filter change
2019-12-16 23:45:49 +01:00
Laurent VOULLEMIER
9aa28b4e33
Test asset whitelisting on SchemaTool#getUpdateSchemasSql()
2019-12-16 23:45:49 +01:00
Nicolas Grekas
5c2b6870bf
Whitelist existing assets we know about from metadata in SchemaTool::getUpdateSchemaSql()
2019-12-16 23:22:50 +01:00
Luís Cobucci
4389b2c188
Merge pull request #7956 from lcobucci/fix-test-suite
...
Ignore Doctrine\Common\Persistence\ObjectManagerDecorator deprecation
2019-12-16 21:49:25 +01:00
Luís Cobucci
e481d9880b
Ignore Doctrine\Common\Persistence\ObjectManagerDecorator deprecation
...
Since applying the fixes requires bumping up the dependency, which isn't
done in a patch release.
This should be removed in v2.8.0.
2019-12-16 21:22:28 +01:00
Luís Cobucci
85528f28e2
Fix CS errors
2019-12-16 21:22:23 +01:00
Luís Cobucci
5873242fb5
Merge pull request #7937 from doctrine/GH-7930-SqliteForeignKeys
...
Revert SchemaTool change to check for foreign key support
2019-12-16 10:45:07 +01:00
Luís Cobucci
4aa09861dd
Merge pull request #7941 from Grafikart/feat-typed-functions
...
Allow DQL functions to specify return type
2019-12-12 19:50:23 +01:00
Grafikart
24e9a7caaf
Allow defining return types for DQL functions
2019-12-12 14:19:09 +01:00
Luís Cobucci
d90df59118
Merge pull request #7948 from beberlei/TravisSmokeTesting
...
Add stage that runs before Test to allow fast failures on Sqlite/phpcs
2019-12-12 11:54:41 +01:00
Benjamin Eberlei
f9103a7b41
Add another stage that runs before Test to allow fast failures on Sqlite, Quality + PHPCS-differ
2019-12-12 11:43:24 +01:00
Luís Cobucci
9891477094
Merge pull request #7928 from kokspflanze/2.7-patch-deprecated
...
Deprecate EntityRepository#clear()
2019-12-09 21:56:41 +01:00
kokspflanze
59e3a55110
Deprecate EntityRepository#clear()
2019-12-09 21:42:11 +01:00
Luís Cobucci
c9e41d0aa7
Merge pull request #7934 from BenMorel/php74
...
Fix Trying to access array offset on value of type null
2019-12-09 21:32:58 +01:00
Benjamin Morel
f37c12834d
Fix Trying to access array offset on value of type null
2019-12-09 21:24:29 +01:00
Benjamin Eberlei
041404e8b3
[GH-7864] Revert removeElement EXTRA_LAZY support.
2019-12-07 00:03:09 +01:00
Benjamin Eberlei
bfc68b3aba
Add warning about removeElement on extra lazy
2019-12-03 20:34:44 +01:00
Benjamin Eberlei
1e628370c4
[GH-7864] Address review comments.
2019-12-03 19:35:49 +01:00
Benjamin Eberlei
ae2b9b1921
Housekeeping: phpcbf to fix issues.
2019-12-01 21:11:09 +01:00
Benjamin Eberlei
419df77a09
[GH-7864] ExtraLazyCollectionTest is not cacahble and should not fail SLC suite.
2019-12-01 20:28:30 +01:00
Benjamin Eberlei
d6f6b2e97c
[GH-7864] Remove tests that checked invalid behavior.
2019-12-01 19:47:58 +01:00
Benjamin Eberlei
75d5adf599
[GH-7864] Bugfix in PersistentCollection::removeElement for EXTRA_LAZY.
2019-12-01 19:27:45 +01:00
Benjamin Eberlei
cfd6fadf9c
Revert " #7841 SchemaTool generates extra diff for platforms without FK support"
...
This reverts commit 3707c39124 .
2019-12-01 11:23:45 +01:00
Tomoka Baba
2bf7916c52
Fix to pass code quality check.
2019-11-20 17:03:34 +09:00
Tomoka Baba
253fd10cc0
Modified test to use assertTrue.
2019-11-20 17:02:25 +09:00
Tomoka Baba
2c956d55f2
Fix to pass code quality check.
2019-11-20 17:02:25 +09:00
Tomoka Baba
3db992e953
Add test code.
2019-11-20 17:01:52 +09:00
Tomoka Baba
6fc9b3ab16
Fix to pass code quality check.
2019-11-20 17:01:52 +09:00
Tomoka Baba
2d833a5e86
Fix boolean properties default value when generating entities.
2019-11-20 17:01:19 +09:00
Luís Cobucci
a416a9a8b2
Bump up version
2019-11-19 09:43:57 +01:00
Luís Cobucci
4d763ca4c9
Bump up version
2019-11-19 09:38:05 +01:00
Luís Cobucci
398d74deaa
Merge pull request #7911 from lcobucci/be-more-explicit-on-deprecation-messages
...
Be explicit about which Doctrine package in message
2019-11-19 09:36:14 +01:00
Luís Cobucci
3314322929
Be explicit about which Doctrine package in message
...
Avoiding possible confusion while reading the deprecation messages.
2019-11-19 09:03:36 +01:00
Luís Cobucci
ce93817bf7
Merge pull request #7909 from lcobucci/add-deprecation-messages
...
Add deprecation messages
2019-11-19 08:21:44 +01:00
Luís Cobucci
50992eafa2
Deprecated the usage of number unaware underscore naming strategy
2019-11-19 02:15:11 +01:00
Luís Cobucci
9ccb8837e7
Add deprecation message for EM#clear($entityName)
2019-11-19 01:34:50 +01:00
Luís Cobucci
d959744c0a
Merge pull request #7079 from mairo744/hotfix/sqlite-join-table-name
...
fix getJoinTableName for sqlite with schema attribute
2019-11-18 23:37:33 +01:00
mairo744
0264ba1759
Fix creation of join table names with schemas in SQLite
...
Join table name doesnt depending on the platform.
Table name was "schema.table" instead of "schema__table".
(cherry picked from commit 4878cd3f4ef30ffc6047c18e0f7b16aafeabc3b4)
2019-11-18 23:25:28 +01:00
Luís Cobucci
8332fa1855
Merge remote-tracking branch 'upstream/2.6' into 2.7
2019-11-18 23:06:28 +01:00
Luís Cobucci
4fae126459
Bump up version
2019-11-18 23:05:16 +01:00
Luís Cobucci
2d9b935183
Bump up version
2019-11-18 23:01:21 +01:00
Luís Cobucci
4804f602f8
Merge pull request #7908 from lcobucci/fix-bc-break-on-naming-strategy
...
Fix BC-break on underscore naming strategy
2019-11-18 22:57:27 +01:00
Luís Cobucci
3d17290eb5
Fix BC-break on underscore naming strategy
...
We broke our BC promises on the last patch release by changing how the
underscore naming strategy parses values with numbers.
This commit makes it possible to configure whether or not to make the
underscore naming strategy aware of numbers, keeping the old
configuration as default value.
2019-11-18 22:38:14 +01:00
Luís Cobucci
8420d24f90
Merge remote-tracking branch 'upstream/2.6' into 2.7
2019-11-18 19:59:58 +01:00
Luís Cobucci
52f2b37921
Bump up version
2019-11-18 12:17:41 +01:00
Luís Cobucci
16751d210f
Bump up version
2019-11-18 12:06:51 +01:00
Luís Cobucci
686f508576
Merge pull request #7905 from lcobucci/7890-paginator-objecti
...
[Paginator] Fix type conversion during hydration of pagination limit subquery
2019-11-18 10:50:54 +01:00
Luís Cobucci
00ef1eba90
Add paginator query hint to force type conversion
...
We're keeping a BC layer in the hydrator, which prevents type conversion
in scalar results.
This makes bypasses such layer in order to always convert the identifier
types when limiting the result set during a pagination.
The main goal here is to keep the conversion DB->PHP inside of the
hydrator components.
2019-11-18 10:27:10 +01:00
Gabriel Ostrolucký
3843eee5cb
[Paginator] Add test case for regression with custom id
...
Co-authored-by: Alexei Korolev <alexei.korolev@gmail.com >
2019-11-18 10:27:10 +01:00
Luís Cobucci
f576e6c41f
Merge pull request #7904 from greg0ire/validate-composer-json
...
Make sure composer files are valid
2019-11-16 11:47:02 +01:00
Grégoire Paris
c79d2e0dc2
Make sure composer files are valid
...
The composer.lock is put under version control and it often happens to
be out of sync with the composer.json, which could lead to
hard-to-understand issues.
Using the --strict option here because we might as well aim for a
perfectly valid composer.json
2019-11-16 10:59:39 +01:00
Grégoire Paris
33b8d020a7
Synchronize lock file and json manifest
2019-11-16 10:59:39 +01:00
Luís Cobucci
1b2daac25d
Merge pull request #7710 from rtek/pretty-tool-describe
...
Prettified arrays in tool command orm:mapping:describe
2019-11-16 02:15:31 +01:00
Luís Cobucci
977985f756
Merge pull request #7701 from someniatko/deprecate-use-result-cache
...
Split and deprecate AbstractQuery#useResultCache()
2019-11-16 02:12:29 +01:00
rtek
0c36f87935
Prettify arrays in orm:mapping:describe command
...
This will prevent excessive column width and wrapping in the output which uses Symfony\Component\Console\Style\SymfonyStyle::table().
2019-11-16 02:03:03 +01:00
someniatko
e8f265d480
Make ResultCacheTest tests slightly more logical
2019-11-16 01:59:57 +01:00
Illia Somov
7bcbad076d
Split and deprecate AbstractQuery#useResultCache()
2019-11-16 01:59:57 +01:00
Luís Cobucci
57496e32fd
Add minor BC-break notes on output walkers in paginator
...
As explained in
https://github.com/doctrine/orm/pull/7863#issuecomment-554578313 .
2019-11-16 01:48:37 +01:00
Luís Cobucci
797bfc53c4
Fix deprecation messages version
2019-11-16 01:32:15 +01:00
Luís Cobucci
8c47dcb6fc
Merge pull request #7863 from Seb33300/skip-limit-subquery
...
Paginator: Skip limit subquery if not required
2019-11-16 01:21:43 +01:00
Sébastien ALFAIATE
6347190886
Skip limit subquery if not required
2019-11-16 01:03:22 +01:00
Luís Cobucci
9162f3519d
Merge pull request #7900 from doctrine/2.6.x-merge-up-into-2.7
...
Merge up 2.6 to 2.7
2019-11-16 00:27:50 +01:00
Grégoire Paris
fc9314d9f5
Merge remote-tracking branch 'origin/2.7' into 7900--2.6.x-merge-up-into-2.7
2019-11-15 23:50:05 +01:00
Luís Cobucci
26806d08eb
Require more updated doctrine packages
2019-11-15 23:46:22 +01:00
Luís Cobucci
6a827d5b61
Merge pull request #7861 from ferrastas/bug_removing_collection
...
Delete statements will not be created using `clear`
2019-11-15 22:58:31 +01:00
Gabriel Ostrolucký
7d77984306
Restore ability to clear deferred explicit tracked collections
...
This was regression from #7862 which tried to respect tracking config
when clearing collections, but this logic can happen in UOW only,
PersistentCollection::clear is triggered too early to know what
is (going to be) persisted.
Fixes #7862
2019-11-15 22:49:06 +01:00
Ferran Vidal
ec93014713
Delete statements will not be created using clear.
2019-11-15 22:43:53 +01:00
Luís Cobucci
c83094bde0
Merge pull request #7684 from rharink/2.6
...
only replace '_id' at end of columnName
2019-11-15 16:50:16 +01:00
Robert den Harink
982d1519db
only replace '_id' at end of columnName
2019-11-15 16:36:48 +01:00
Marco Pivetta
f7c04ae537
Merge pull request #7901 from lcobucci/add-deprecation-notices
...
Add deprecation warnings for 2.7.x
2019-11-15 16:15:31 +01:00
Michael Moravec
f9a4258ded
Upgrading notes for 2.7
2019-11-15 14:43:33 +01:00
Michael Moravec
eb9f11bf96
Added deprecation warnings for 2.x
2019-11-15 14:43:15 +01:00
Luís Cobucci
2b8cb9de79
Add basic tool to verify deprecation messages
2019-11-15 14:42:48 +01:00
Luís Cobucci
570abb5bad
Fix PHP warnings in test suite
2019-11-15 14:42:47 +01:00
Luís Cobucci
855244fd10
Merge pull request #7865 from Ocramius/fix/#7837-paginate-with-custom-identifier-types-even-with-cached-dql-parsing
...
#7837 paginate with custom identifier types even with enabled DQL query cache
2019-11-15 11:08:22 +01:00
Guilherme Blanco
c62977412c
Merge pull request #7869 from BenMorel/patch-4
...
UnitOfWork::clear() misses $eagerLoadingEntities
2019-11-15 00:27:08 -05:00
Gabriel Ostrolucký
98e557b68e
Improve assertion failure message for testWillFindSongsInPaginatorEvenWithCachedQueryParsing
2019-11-14 23:37:13 +01:00
Mickaël RAYBAUD-ROIG
3a32c00dcf
Add a failing test for issue #7505
2019-11-14 23:28:42 +01:00
Gabriel Ostrolucký
1dde2c9e8e
Add test case verifying eager loads are clear
...
Otherwise, getClassMetadata would be triggered more times
2019-11-14 22:17:06 +01:00
Marco Pivetta
adfd010a78
Merge pull request #7889 from ajgarlag/hotfix/fix-tests-with-dbal-2.10
...
Use quoted collation declaration when available.
2019-11-05 15:52:18 +01:00
Antonio J. García Lagar
1bc4e1f594
Use quoted collation declaration when available.
2019-11-05 14:58:24 +01:00
Marco Pivetta
21680df9bd
Merge pull request #7884 from rogeriolino/patch-1
...
[Documentation] Advanced field value... - missing entity alias
2019-11-05 01:23:52 +01:00
Rogério Alencar Lino Filho
19aa3c125c
missing entity alias
2019-10-31 18:20:58 -03:00
Marco Pivetta
e9e012a037
Merge pull request #7880 from kuraobi/update-doc-dql-qb
...
Update documentation to recommend DQL over QueryBuilder when possible
2019-10-29 19:04:03 +01:00
Mathieu Lemoine
d1db0655ac
Update documentation to recommend DQL over QueryBuilder when possible
2019-10-29 16:26:17 +01:00
Luís Cobucci
2d643e6b7b
Merge pull request #7876 from nicolas-grekas/sf5-cmd
...
Fix compat of commands with Symfony 5
2019-10-23 16:12:18 +02:00
Nicolas Grekas
4d6b1f3e63
Fix compat of commands with Symfony 5
2019-10-23 16:00:19 +02:00
Jonathan H. Wage
d9c30e34c4
Merge pull request #7723 from nicolas-grekas/sf5
...
Allow Symfony 5.0
2019-10-23 15:57:25 +02:00
Nicolas Grekas
90c1ee0bd0
Allow Symfony 5.0
2019-10-23 15:57:25 +02:00
Marco Pivetta
cfcca3a63c
Merge pull request #7600 from Majkl578/travis-php7.4-2.7
...
[2.7] CI: Test against PHP 7.4snapshot instead of nightly (8.0)
2019-10-23 15:57:24 +02:00
Michael Moravec
af0949adab
Merge pull request #7382 from Majkl578/homepage-2.7
...
Update homepage
2019-10-23 15:57:24 +02:00
Michael Moravec
cdb652ad87
CI: Test against PHP 7.4snapshot instead of nightly (8.0)
2019-10-23 15:57:24 +02:00
Claudio Zizza
4fb1ebfc10
Create 2.7 upgrade headline for deprecation changes
2019-10-23 15:57:24 +02:00
Michael Moravec
46c1b57560
Update homepage
2019-10-23 15:57:24 +02:00
Claudio Zizza
fdbbf7edd1
Add deprecation of EntityManagerInterface::copy() to upgrade information
2019-10-23 15:57:23 +02:00
Claudio Zizza
2fed8204c1
Set copy-method as deprecated
2019-10-23 15:57:23 +02:00
Michael Moravec
76f03b5db0
Bump version to 2.7-dev
2019-10-23 15:57:19 +02:00
Guilherme Blanco
9fef4e86e4
Merge pull request #7871 from BenMorel/2.6
...
AbstractQuery::getSingleScalarResult() throws exception when no result
2019-10-18 10:37:53 -04:00
Benjamin Morel
4781dc03e9
AbstractQuery::getSingleScalarResult() throws exception when no result
2019-10-16 20:41:00 +02:00
Benjamin Morel
cc5f84ac22
UnitOfWork::clear() misses $eagerLoadingEntities
2019-10-16 10:11:55 +02:00
Marco Pivetta
023e94661a
#7837 force expiry of query cache when WhereInWalker is being used
...
In order to figure out the paginated query identifier type, we would
have to parse the DQL query into an AST+SQL anyway, so we'd have
to re-parse it manually: instead of doing that, we can force the
`WhereInWalker` to be reached at all times by forcing the
`$whereInQuery` to use no query cache.
While it is a sad performance regression, it is also not a
noticeable one, since we'll be performing an `O(1)` operation
around an I/O one (query execution, in this case).
2019-10-10 18:23:31 +02:00
Marco Pivetta
b59fc23f86
#7837 reproduced issue: DQL caching prevents WhereInWalker run
...
Since `WhereInWalker` does not run, query parameters are not translated
from their in-memory type to the expected SQL type when the paginator
is run again with the same DQL string. This is an architectural
issue, since (for the sake of simplicity) we moved parameter
translation into the SQL walker, we didn't consider that SQL
walkers only act when no cache is in place. The translatio
needs to be moved into the paginator logic again.
2019-10-10 17:30:43 +02:00
Luís Cobucci
d71dd5d94f
Bump up version
2019-10-08 20:04:50 +02:00
Luís Cobucci
63513e9a05
Merge pull request #7856 from lcobucci/fix/underscore-strategy-dont-work-with-numbers
...
Fix underscore naming strategy behaviour with numbers
2019-10-08 12:06:24 +02:00
Luís Cobucci
c802bc46a5
Format NamingStrategyTest according to our CS
2019-10-08 11:56:11 +02:00
Luís Cobucci
506bf0ee12
Allow numbers in property names on underscore naming strategy
2019-10-08 11:56:11 +02:00
Luís Cobucci
a36809db72
Merge pull request #7851 from peter-gribanov/reflFieldValue2.6
...
Remove not used variable $reflFieldValue in ObjectHydrator
2019-10-04 07:50:26 +02:00
Peter Gribanov
5b00d7ba5e
remove not used variable $reflFieldValue in ObjectHydrator
2019-10-03 11:14:24 +03:00
Luís Cobucci
b22604352d
Merge pull request #7849 from axi/patch-1
...
Mention SQL logger impact on batch processing
2019-10-02 14:14:48 +02:00
axi
00c6b1bc60
Update batch-processing.rst
...
Clarify note
2019-10-02 14:00:06 +02:00
Luís Cobucci
4b0d86ee92
Merge pull request #7842 from vpArth-php/gh-7841
...
#7841 SchemaTool generates extra diff for platforms without FK support
2019-10-02 10:50:42 +02:00
Alexander Deider
3707c39124
#7841 SchemaTool generates extra diff for platforms without FK support
2019-10-02 15:35:59 +07:00
Luís Cobucci
fe72b00df2
Merge pull request #7850 from nlx-lars/nlx-lars/bugfix/7836-dont-merge-criteria
...
Don't merge PersistentCollection orderBy with criteria in matching()
2019-10-02 10:02:38 +02:00
Lars Lauger
79a7ecc92f
Don't merge PersistentCollection orderBy with criteria in matching()
...
If no orderings are given to PersistentCollection::matching(), the
orderBy annotation will be used if present. If the criteria contains
orderings, those will be used without merging them with the orderBy.
See #7836
2019-10-02 09:23:38 +02:00
Luís Cobucci
16df8bfe0d
Merge pull request #7298 from dunglas/patch-2
...
Add a missing type in Query::getFirstResult PHPDoc
2019-10-02 04:27:19 +02:00
Kévin Dunglas
b37ceaa9f7
Add a missing type in Query::getFirstResult and Query::getDQL
2019-10-02 04:13:42 +02:00
Luís Cobucci
c41fdbce8a
Merge pull request #7727 from madand/patch-1
...
[doc] Finish incomplete definition of class UTCDateTimeType
2019-10-02 04:11:20 +02:00
Luís Cobucci
7526adc80a
Merge pull request #7443 from naitsirch/fix/issue6793
...
Added doc about exception in Query#getOneOrNullResult()
2019-10-02 04:07:25 +02:00
Andriy Kmit
766eb693fb
Finish incomplete definition of class UTCDateTimeType
2019-10-02 03:57:06 +02:00
Luís Cobucci
f9e2ae3488
Merge pull request #7667 from jschaedl/patch-1
...
Fixes example One-To-One, Self-referencing
2019-10-02 03:56:01 +02:00
Luís Cobucci
6bf2ff5d10
Merge pull request #7671 from jschaedl/patch-4
...
Added missing "the"
2019-10-02 03:45:50 +02:00
Jan Schädlich
27fcc01d81
Fixes example One-To-One, Self-referencing
2019-10-02 03:37:23 +02:00
Jan Schädlich
3ac1f8e680
Added missing "the"
2019-10-02 03:36:06 +02:00
Luís Cobucci
b63db53552
Merge pull request #7764 from guillaume-a/7763
...
#7763 escape quotes in field comments
2019-10-02 02:56:05 +02:00
Guillaume Aveline
bed8186573
Fix comment quoting in the EntityGenerator
...
Fixes: https://github.com/doctrine/orm/issues/7763
2019-10-02 02:42:09 +02:00
Luís Cobucci
f08ff83d0a
Merge pull request #7768 from mickaelandrieu/patch-1
...
EntityManagerHelper can't accept an array of paths
2019-10-01 22:51:13 +02:00
axi
7c8c0906be
Update batch-processing.rst
...
Looking for a way to improve one of our bulk update treatment, I went back to this page then found elsewhere that setting logger to null was a really effective way to improve time and memory consumption. Might be a right place to state it ? Don't know if my edit style is ok
2019-10-01 17:46:09 +02:00
Grégoire Paris
167cb44ea1
Merge pull request #7742 from bocharsky-bw/patch-1
...
Start i var from 1 instead of 0
2019-09-28 18:54:56 +02:00
Mickaël Andrieu
5d74bdb240
Remove misleading documentation
...
EntityManagerHelper does not have a second argument, see
ca38249f6c/lib/Doctrine/ORM/Tools/Console/Helper/EntityManagerHelper.php (L49)
2019-09-28 12:32:09 +02:00
Luís Cobucci
ca38249f6c
Merge pull request #7838 from samnela/fix/name-classmetadata
...
Fix the name of ClassMetadata in documentation
2019-09-27 22:31:49 +02:00
Samuel NELA
6a74f373b9
Fix the name of ClassMetadata in documentation
2019-09-27 21:59:32 +02:00
Luís Cobucci
b52ef5a100
Merge pull request #7322 from dennisenderink/fix/joinedsubclasspersister-pass-identifier-types-on-delete
...
JoinedSubclassPersister pass identifier types on delete
2019-09-20 16:30:26 +02:00
Luís Cobucci
ef783f7049
Make use of the PersisterHelper to get field type
...
Removing the unnecessary code duplication.
2019-09-20 16:17:43 +02:00
Luís Cobucci
435d624d33
Centralise functional test classes
...
Which provides better isolation and makes things a bit more
understandable.
2019-09-20 16:17:43 +02:00
Dennis Enderink
53775fe086
Added correct return types to docblock
2019-09-20 16:17:43 +02:00
Dennis Enderink
59f1679fed
Patched spacing
2019-09-20 16:17:43 +02:00
Dennis Enderink
390d081fca
Created new DBAL type and updated/reverted tests; also clarified new method return type
2019-09-20 16:17:43 +02:00
Dennis Enderink
37d1d57900
Added unit tests
2019-09-20 16:17:42 +02:00
Dennis Enderink
d7a537c941
Pass ClassMetadata object instead of string in parent classes loop
2019-09-20 16:17:42 +02:00
Dennis Enderink
cfe73cd74f
Separated class identifiers types retrieval in a separate method and implemented in JoinedSubclassPersister delete method
2019-09-20 15:40:03 +02:00
Luís Cobucci
d0e1da8c51
Merge pull request #7490 from vladyslavstartsev/patch-2
...
Fix broken link
2019-09-20 15:32:13 +02:00
vladyslavstartsev
7fbe663ea0
Fix broken link
...
closing #7489
2019-09-20 15:31:12 +02:00
Luís Cobucci
409f2f5d82
Merge pull request #7672 from jschaedl/patch-5
...
Added cross-links to relevant documentation
2019-09-20 15:30:14 +02:00
Luís Cobucci
3d8b672771
Merge pull request #7610 from smtchahal/patch-1
...
Change APC to OPcache in improving-performance.rst
2019-09-20 15:29:07 +02:00
Jan Schädlich
17650a6100
Added cross-links to relevant documentation
2019-09-20 15:19:49 +02:00
Luís Cobucci
1588ca7e1f
Merge pull request #7821 from Ocramius/bug/#7820-paginator-ignores-dbal-type-conversions-in-identifiers
...
Bug: #7820 paginator ignores dbal type conversions in identifiers
2019-09-20 15:13:58 +02:00
Marco Pivetta
0de17319d3
#7820 use PersisterHelper to figure out identifier types
...
This logic was pre-existing, but I forgot about it while writing
#7820 , therefore it was re-implemented inside this unit of
code. Now we just use the `PersisterHelper`, which does all
the nice and shiny identifier type discovery operations we need.
2019-09-20 15:03:22 +02:00
Marco Pivetta
681ff32e76
#7820 documented PersisterHelper#getTypeOfField() array return type
...
Array values are `string`, and the array is a packed array.
2019-09-20 14:57:44 +02:00
Marco Pivetta
caee6c8685
#7820 restricted return type of Doctrine\ORM\Mapping\ClassMetadataInfo#getTypeOfColumn()
...
This method will always return `string|null`, so we can safely
remove DBAL types from its possible return types.
2019-09-20 14:51:56 +02:00
Marco Pivetta
c67a515cc2
As per discussion with @lcobucci, it is better to keep dragons where
...
there be dragons, and this change does indeed rewrite the previous
approach by moving the responsibility of type conversion on a query
object from the `Paginator` to the `WhereInWalker`, which already
has access to class metadata for the root of the selection (and can
reliably detect the root of the selection too)
2019-09-19 20:05:34 +02:00
Luís Cobucci
24892779f7
Merge pull request #7818 from SenseException/simple-annotation-docs
...
Add note into docs about not using SimpleAnnotationReader
2019-09-18 10:49:43 +02:00
Marco Pivetta
39d2113549
Fixed #7820 - convert identifiers for WHERE IN(?) queries before binding parameters
...
This patch introduces new internal API on the `ResultSetMapping` class, which is responsible
for finding the type of the single column identifier of a DQL query selection root.
2019-09-17 16:54:25 +02:00
Marco Pivetta
65522d9775
Failing test case for #7820 - paginator doesn't use custom ID types
...
When using a `Doctrine\ORM\Tools\Pagination\Paginator` to iterate over a query that has entities with a custom DBAL type used in the identifier, then `$id->__toString()` is used implicitly by PDO, instead of being converted by the `Doctrine\DBAL\Types` system.
In order to reproduce this, you must have identifiers implementing `#__toString()` (to allow the `UnitOfWork` to hash them) and other accessors that are used by the custom DBAL type during DB/PHP conversions. If `#__toString()` and the DBAL type conversions are asymmetric, then the paginator will fail to find records.
Tricky situation, but this very much affects `ramsey/uuid-doctrine` and anyone relying on the `uuid_binary`.
2019-09-17 11:37:50 +02:00
Claudio Zizza
50eecf698c
Add note into docs about not using SimpleAnnotationReader
2019-09-15 22:50:46 +02:00
Luís Cobucci
20ab78e3c1
Merge pull request #7753 from SenseException/getting-started-annotation
...
Add ORM annotations in getting-started docs
2019-09-12 17:01:53 +02:00
Luís Cobucci
613ffe9bbd
Backport documentation sidebar
2019-09-10 16:31:41 +02:00
Luís Cobucci
61ff45f98e
Merge pull request #7785 from mlocati/php74-fixes
...
Fix "access array offset on value of type null" PHP 7.4 notices
2019-09-10 16:08:49 +02:00
Luís Cobucci
a8aa475d09
Add PHP 7.4 to test matrix
2019-09-10 15:48:05 +02:00
Luís Cobucci
a4215cfa59
Update locked dependencies
2019-09-10 15:48:04 +02:00
Luís Cobucci
a4ac9a721f
Upgrade PHPUnit to 7.5
2019-09-10 15:48:03 +02:00
Michele Locati
447183e235
Fix "access array offset on value of type null" PHP 7.4 notices
2019-09-10 15:47:57 +02:00
Luís Cobucci
642e543b4b
Merge pull request #7778 from umpirsky/fix/issue-7266
...
Guard L2C regions against corrupted data
2019-08-14 18:07:58 +02:00
Luís Cobucci
80503c4837
Guard cache regions against corrupted data
...
For some bizarre reason the underlying cache drivers are returning
unexpected values, which are leaking to the cache objects and causing
them to error.
This makes our cache regions much more strict about the types that are
fetched from the cache provider, ensuring that no invalid information is
ever sent to the hydrators.
2019-08-14 17:42:56 +02:00
Luís Cobucci
3577064f8c
Make closure static
...
To adhere to our coding standard.
2019-08-14 17:42:56 +02:00
Luís Cobucci
b6663733c0
Add type assertion to be more strict about persister type
2019-08-14 17:42:56 +02:00
Luís Cobucci
b9d6834213
Remove unnecessary function calls
2019-08-14 17:42:56 +02:00
Luís Cobucci
eafc4c5a0c
Remove unnecessary parentheses
2019-08-14 17:42:56 +02:00
Saša Stamenković
ecf80b47a0
Call to a member function resolveAssociationEntries() on boolean
...
The following mistakes occur occasionally:
```
Call to a member function resolveAssociationEntries() on boolean {"detail":"[object] (Symfony\\Component\\Debug\\Exception\\FatalThrowableError(code: 0): Call to a member function resolveAssociationEntries() on boolean at /www/vendor/doctrine/orm/lib/Doctrine/ORM/Cache/DefaultQueryCache.php:140)"}
```
On cache miss the parameter `$entityEntry` sometimes will be false. This fixes issue #7266 .
2019-08-14 17:42:56 +02:00
Luís Cobucci
5499555862
Merge pull request #7791 from Steveb-p/fix-docs
...
Fix preFlush event documentation stating incorrectly that flush can be called safely
2019-08-14 14:03:13 +02:00
Paweł Niedzielski
70df74f65f
Fix preFlush event documentation stating incorrectly that flush can be called safely
...
Original author: egonolieux
Supersedes #6858
2019-08-14 13:41:31 +02:00
Luís Cobucci
74415becce
Merge pull request #7737 from Smartel1/smartel1/patch1
...
Fix MEMBER_OF comparison when using criteria in query builder
2019-08-14 10:07:11 +02:00
drews
3a56cf8ad9
Add MEMBER_OF comparison to queryExpressionVisitor
2019-08-14 09:47:20 +02:00
Luís Cobucci
6b7f53f0f3
Merge pull request #7766 from stephanschuler/respect-collection-ordering-in-selectable-matching
...
Respect collection orderBy meta when matching()
Fixes https://github.com/doctrine/orm/issues/7767
2019-08-13 23:42:32 +02:00
Stephan Schuler
e51666e8be
Fix PersistentCollection::matching() not respecting collection ordering
...
The ordering of a Criteria is prefered over the collections default
ordering.
The default collection ordering used as additional sorting attributes.
2019-08-13 23:34:54 +02:00
Luís Cobucci
6e56bcd75f
Merge pull request #7750 from AlexSmerw/issue_7735_null_values_in_entities_cache_for_2.6
...
Fix incorrect return of null values in L2C
2019-08-12 01:28:20 +02:00
Luís Cobucci
48bfef1f7a
Merge pull request #7761 from paxal/persistent_collection/deferred_explicit_2.6
...
Do not modify UOW on PersistentCollection::clear() when owner has DEFFERED_EXPLICIT change tracking policy
2019-08-12 01:21:21 +02:00
A.Kuterev
e8f91434a7
Avoid reusing variable name
...
The same variable name is used below, and that causes a bug etc.
Fixes https://github.com/doctrine/orm/issues/7735
2019-08-12 01:18:48 +02:00
Luís Cobucci
7e26d82790
Merge pull request #7794 from lcobucci/fix-compatibility-with-dev-dependencies
...
Fix test compatibility with DBAL 2.10.x-dev
2019-08-12 00:00:45 +02:00
Luís Cobucci
869b70e4db
Use Ubuntu Xenial for MySQL 5.7 build
...
Since July 21st 2019 it's no longer possible to install MySQL 5.7 in
Ubuntu Trusty.
More info: https://docs.travis-ci.com/user/database-setup/#mysql-57
2019-08-11 23:41:32 +02:00
Luís Cobucci
33904cb9c1
Fix test compatibility with DBAL 2.10.x-dev
2019-08-11 23:41:32 +02:00
Cyril PASCAL
a42191eecf
Add functional test for ArrayCollection::clear() bug
2019-07-19 16:21:12 +02:00
Cyril PASCAL
3fbf163d34
Do not modify UOW on PersistentCollection::clear() when owner has DEFFERED_EXPLICIT change tracking policy
2019-06-26 16:07:15 +02:00
naitsirch
1c45e1b744
Fixed grammatical mistake in doc
...
Co-Authored-By: Grégoire Paris <postmaster@greg0ire.fr >
2019-06-24 22:07:56 +02:00
Claudio Zizza
c777aa62b6
Fix of ORM annotation in examples
2019-06-23 23:39:41 +02:00
Luís Cobucci
6296bd4e1d
Merge pull request #7744 from noobshow/patch-1
...
Fixed a typo-error
2019-06-18 08:30:35 +02:00
Luís Cobucci
5a236c19f5
Merge pull request #7731 from greg0ire/try-mysql-addon
...
Replace custom install script with add-on
2019-06-17 23:33:04 +02:00
Olumide Samson
4f8a1f92a3
Fixed a typo-error
...
exploitet changed to exploited
2019-06-17 09:00:45 +01:00
Victor Bocharsky
5612790307
Start i var from 1 instead of 0
...
Because (0 % $batchSize) === 0 but we don't want to execute flush() and clear() on the first iteration.
2019-06-11 13:19:56 +03:00
Jonathan H. Wage
0b5be00374
Merge pull request #7732 from lchrusciel/patch-1
...
[Documentation] Missing comma fix
2019-06-04 11:11:46 -05:00
Łukasz Chruściel
145cc782ff
[Documentation] Missing comma fix
2019-06-04 17:38:26 +02:00
Jonathan H. Wage
9712506be8
Merge pull request #7729 from JoppeDC/patch-1
...
Update DATE_ADD and DATE_SUB docs
2019-06-04 10:23:15 -05:00
Grégoire Paris
bd9ead11c5
Replace custom install script with add-on
...
Following this documentation:
https://docs.travis-ci.com/user/database-setup/#mysql-57
found via https://stackoverflow.com/a/49542847/353612
2019-06-03 22:12:54 +02:00
Joppe de Cuyper
a98ebf7344
Whitespace fixes
2019-06-03 20:21:19 +02:00
Joppe de Cuyper
c721ab63ee
Update DATE_ADD and DATE_SUB docs
2019-06-03 20:20:03 +02:00
Jonathan H. Wage
2820438afc
Merge pull request #7694 from darrylhein/patch-1
...
Change variable name in docs
2019-04-29 11:00:10 -05:00
Darryl Hein
180cfcc3e3
change variable name
...
to make it consistent throughout document
2019-04-28 21:07:22 -06:00
Marco Pivetta
52d806a34a
Merge pull request #7612 from spirlici/patch-1
...
Update ordered-associations.rst
2019-03-12 00:16:09 +01:00
Marco Pivetta
49a8f2ec96
Merge pull request #7630 from yethee/gh-7629
...
Fix #7629 - `scheduledForSynchronization` leaks memory when using `@ORM\ChangeTrackingPolicy("DEFERRED_EXPLICIT")`
2019-03-01 21:24:57 +01:00
yethee
7f5f4629e5
Ensure state is cleanup after empty commit
2019-03-01 23:00:01 +03:00
yethee
d91e0b3867
Failing tests
2019-02-28 17:12:54 +03:00
Sergiu Pirlici
b537758b32
Update ordered-associations.rst
...
Fixed some typos
2019-02-16 15:04:45 +02:00
Sumit Chahal
2ba6e473de
Change APC to OPcache in improving-performance.rst
...
OPcache is a lot better supported now than APC,
which is apparently not maintained anymore.
2019-02-16 16:44:21 +05:30
Marco Pivetta
de97061d65
Merge pull request #7596 from mbessolov/patch-1
...
Correct method names and broken link in docs
2019-02-09 15:47:17 +01:00
Michael Bessolov
624ee78081
Correct method names and broken link in docs
...
This basically applying the same documentation fix as in #7335 (master) to 2.6 branch
2019-02-08 22:29:10 -08:00
Marco Pivetta
e003bb2bb4
Merge pull request #7577 from SenseException/advanced-config-link
...
Fix of single link to dbal docs in advanced-configuration.rst
2019-01-23 07:48:12 +01:00
Claudio Zizza
5c5f310646
Fix of link to dbal docs
2019-01-22 22:42:13 +01:00
Marco Pivetta
c10433e512
Merge pull request #7572 from SenseException/remove-codeigniter
...
Remove codeigniter Framework example
2019-01-17 22:35:58 +01:00
Claudio Zizza
580c530041
Remove codeigniter example from docs
2019-01-17 21:54:33 +01:00
Marco Pivetta
4d461afbd6
Merge pull request #7571 from batwolf/patch-1
...
Fix typo in inheritance mappings docs
2019-01-17 21:42:45 +01:00
Marco Pivetta
536e31f343
Merge pull request #7385 from SenseException/links-and-typos
...
Update information and links of documentation
2019-01-17 21:11:50 +01:00
Marc Plotz
c6eb4df25e
fix typo
...
`has to allow null values` vs `has to allows null values`
2019-01-17 10:14:56 +01:00
Claudio Zizza
aae00e3987
Fix of links and php version after review
2019-01-07 14:40:26 +01:00
Claudio Zizza
b56800b15c
Fix of links and anchors
2019-01-07 14:40:17 +01:00
Claudio Zizza
be461be36b
Update getting help section
2019-01-07 14:40:10 +01:00
Claudio Zizza
85171a9490
Fix of reStructuredText format
2019-01-07 14:40:02 +01:00
Claudio Zizza
f5b9f2052a
Update MySQL links to current version
2019-01-07 14:39:54 +01:00
Claudio Zizza
3d652997d1
Remove changelog from documentation
...
This was removed in favour of the UPGRADE.md file, which
contains the changelog information needed.
2019-01-07 14:39:42 +01:00
Marco Pivetta
10393dca68
Merge pull request #7557 from doctrine/malarzm-patch-1
...
Change Stackoverflow tag to doctrine-orm
2019-01-05 17:48:41 +01:00
Maciej Malarz
597bfaea03
Change Stackoverflow tag to doctrine-orm
2019-01-04 22:20:24 +01:00
Jonathan H. Wage
98b8ced814
Merge pull request #7551 from Majkl578/repo-rename/2.6
...
[2.6] Migrate repository name doctrine/doctrine2 -> doctrine/orm
2019-01-03 17:18:59 -06:00
Michael Moravec
efaee8ce85
Migrate repository name doctrine/doctrine2 -> doctrine/orm
2019-01-03 09:07:03 +01:00
Luís Cobucci
6e93f5bb72
Merge pull request #7528 from Ocramius/fix/#7527-prevent-unit-of-work-lookup-for-known-value-types
...
Fix #7527 : prevent `UnitOfWork` lookup for DBAL types specified in `Doctrine\ORM\Query#setParameter()`
2018-12-21 21:54:20 +01:00
Marco Pivetta
a41f5673bc
#7527 automated CS checks
2018-12-20 22:59:46 +01:00
Marco Pivetta
ca436f0bae
#7527 performance benchmark - verifying performance impact of inferred query parameter types
...
As an example result:
```
./phpbench.phar run tests/Doctrine/Performance/Query --iterations=50 --revs=50 --report=aggregate
PhpBench 0.15-dev (dcbe193). Running benchmarks.
Using configuration file: /home/ocramius/Documents/doctrine/doctrine2/phpbench.json
\Doctrine\Performance\Query\QueryBoundParameterProcessingBench
benchExecuteParsedQueryWithInferredParameterTypeI49 P0 [μ Mo]/r: 643.684 634.664 (μs) [μSD μRSD]/r: 17.700μs 2.75%
benchExecuteParsedQueryWithDeclaredParameterTypeI49 P0 [μ Mo]/r: 97.673 94.251 (μs) [μSD μRSD]/r: 8.259μs 8.46%
2 subjects, 100 iterations, 100 revs, 0 rejects, 0 failures, 0 warnings
(best [mean mode] worst) = 88.460 [370.679 364.458] 127.400 (μs)
⅀T: 37,067.880μs μSD/r 12.980μs μRSD/r: 5.603%
suite: 133f0e30090f815142331ebec6af18241694e7c0, date: 2018-12-19, stime: 10:47:10
+------------------------------------+--------------------------------------------------+--------+--------+------+-----+------------+-----------+-----------+-----------+-----------+----------+--------+-------+
| benchmark | subject | groups | params | revs | its | mem_peak | best | mean | mode | worst | stdev | rstdev | diff |
+------------------------------------+--------------------------------------------------+--------+--------+------+-----+------------+-----------+-----------+-----------+-----------+----------+--------+-------+
| QueryBoundParameterProcessingBench | benchExecuteParsedQueryWithInferredParameterType | | [] | 50 | 50 | 5,970,568b | 604.680μs | 643.684μs | 634.664μs | 677.640μs | 17.700μs | 2.75% | 6.59x |
| QueryBoundParameterProcessingBench | benchExecuteParsedQueryWithDeclaredParameterType | | [] | 50 | 50 | 5,922,424b | 88.460μs | 97.673μs | 94.251μs | 127.400μs | 8.259μs | 8.46% | 1.00x |
+------------------------------------+--------------------------------------------------+--------+--------+------+-----+------------+-----------+-----------+-----------+-----------+----------+--------+-------+
```
This indicates that the performance impact for NOT declaring parameter types
explicitly is *MASSIVE*.
2018-12-19 10:52:11 +01:00
Marco Pivetta
d8212e8dd6
Merge pull request #7530 from vladyslavstartsev/patch-3
...
Documentation error fix
2018-12-17 16:00:44 +01:00
vladyslavstartsev
12eb9f42dc
Documentation error fix
2018-12-16 20:33:21 +02:00
Marco Pivetta
23af164d7a
Note: this will still lead to the UnitOfWork#getSingleIdentifierValue() still being
...
called when not specifying the type of a DQL parameter being bound via
`Doctrine\ORM\Query#setParameter()`:
```php
$query->setParameter('foo', $theValue, $theType);
```
A full parameter bind is required in order to gain back performance:
```php
$query->setParameter('foo', $theValue, $theType);
```
This is up for discussion with patch reviewers.
2018-12-16 18:05:02 +01:00
Marco Pivetta
960a437d46
#7527 failing test case: UnitOfWork#getSingleIdentifierValue() should not be called for a well specified parameter type
...
As previously reported by @flaushi in https://github.com/doctrine/doctrine2/pull/7471#discussion_r241949045 , we discovered
that binding a parameter causes a `ClassMetadataFactory#getClassMetadata()` call, which in turn leads to large performance
regression when using any `object` type as parameter.
Following two snippets lead to an internal `ClassMetadataFactory#getClassMetadata()` call, which in turn leads to an
exception being thrown and garbage collected, plus multiple associated performance implications:
```php
$query->setParameter('foo', new DateTime());
$query->getResult();
```
```php
$query->setParameter('foo', new DateTime(), DateTimeType::NAME);
$query->getResult();
```
This is due to following portion of code:
434820973c/lib/Doctrine/ORM/Query.php (L406-L409)
Notice how `$value = $this->processParameterValue($value);` happens before attempting to infer the type for the parameter value.
That call leads to this segment being reached, which leads to the regression:
434820973c/lib/Doctrine/ORM/AbstractQuery.php (L423-L433)
Assuming the bound parameter type is provided, we can completely skip attempting to introspect the given object:
```php
$query->setParameter('foo', new DateTime(), DateTimeType::NAME);
$query->getResult();
```
Processing the parameter value is not needed in this case, so we can safely skip that logic for all known parameters.
In order to not introduce a BC break or change the `AbstractQuery#processParameterValue()` implementation, we could filter
out all parameters for which the type is given upfront, and later on merge them back in instead.
The test expectation to be set is for `UnitOfWork#getSingleIdentifierValue()` to never be called.
2018-12-16 15:37:45 +01:00
Marco Pivetta
237bebe2ed
Merge pull request #7519 from koftikes/fix/#7518-phpdoc-error
...
#7518 Fixed type mismatch between `EntityRepository#__construct()` and its documented constructor arguments
2018-12-13 08:14:30 +01:00
Jonathan H. Wage
fc3dca772e
Merge pull request #7521 from doctrine/update-chat-link
...
Update chat link from Gitter to Slack.
2018-12-12 20:07:31 +00:00
Konstantin Litvinov
ee64d31f48
7518 Fixed PHPDoc Error.
2018-12-12 17:08:35 +03:00
Michael Moravec
493ff74a0d
Merge pull request #7473 from Majkl578/incremental-cs-2.x
...
Incremental CS checks in 2.x branches
2018-12-10 14:43:55 +01:00
Michael Moravec
78c7000962
Lock dependencies for Code Quality stage
2018-12-10 13:58:51 +01:00
Michael Moravec
6a05e01298
Perform incremental coding standard checks for pull requests
2018-12-10 13:58:51 +01:00
Gabriel Ostrolucký
7de3434733
Update doctrine/coding-standard in 2.x branch
...
Co-Authored-By: Michael Moravec <me@majkl.me >
2018-12-10 13:58:51 +01:00
Luís Cobucci
74e6189f3e
Merge pull request #7483 from javiereguiluz/patch-9
...
Fixed a minor syntax issue
2018-11-21 10:48:33 +01:00
Javier Eguiluz
2e7a3affba
Fixed a minor syntax issue
2018-11-21 09:06:54 +01:00
Luís Cobucci
505ec21f97
Bump up development version
2018-11-21 01:24:06 +01:00
Luís Cobucci
434820973c
Bump up version
2018-11-21 00:46:46 +01:00
Luís Cobucci
41ff526921
Merge pull request #6830 from Tobion/fix-collation-foreign-key
...
fix applying column options on foreign key columns
2018-11-21 00:41:17 +01:00
Luís Cobucci
0be52b0087
Isolate entities used by the new test
...
To ensure we don't have any unintended side-effect.
2018-11-21 00:20:20 +01:00
Tobias Schultze
ee8dc496d9
Fix applying collation on foreign key columns
2018-11-21 00:20:15 +01:00
Luís Cobucci
f80656cddf
Merge pull request #7317 from protecinnovations/fix/7316-xml-order-by-dir-many-to-many
...
[XML] Fix default value of many-to-many order-by to ASC
2018-11-20 13:11:22 +01:00
Alex Denvir
72121c01ec
[XML] Fix default value of many-to-many order-by to ASC
2018-11-20 12:33:29 +01:00
Luís Cobucci
ac505390dd
Merge pull request #7472 from seferov/patch-2
...
fix incorrect phpdoc typehint
2018-11-20 09:41:01 +01:00
Luís Cobucci
728e6e15c5
Merge pull request #7441 from asgrim/fix-getResult-type
...
$hydrationMode throughout can be a string as well as int (for custom modes)
2018-11-20 09:40:04 +01:00
Luís Cobucci
d21305378c
Merge pull request #7471 from alcaeus/fix-unloaded-metadata-parameter-processing
...
Fix parameter value processing for objects with unloaded metadata
2018-11-15 11:34:31 +01:00
Andreas Braun
0552749059
Fix parameter value processing for objects with unloaded metadata
2018-11-15 11:21:05 +01:00
Farhad Safarov
fbd3fe95e4
fix incorrect phpdoc typehint
2018-11-13 13:01:10 +03:00
James Titcumb
c6d02daee0
$hydrationMode throughout can be a string as well as int (for custom modes)
2018-11-12 13:58:42 +00:00
Luís Cobucci
5208035003
Merge pull request #7444 from naitsirch/fix/issue6968
...
Fixed URLs of doctrine-mapping.xsd in docs
2018-11-12 11:40:01 +01:00
Luís Cobucci
d93956eff0
Use HTTPS endpoint for XML schema location
2018-11-12 11:29:32 +01:00
naitsirch
b3b06d3e7d
Fixed URLs of doctrine-mapping.xsd in docs
...
Until now the references to the `doctrine-mapping.xsd` consisted of different URLs.
A grep of docs showed:
* /Users/robo/dev/php/Doctrine/doctrine-mapping.xsd
* http://doctrine-project.org/schemas/orm/doctrine-mapping.xsd
* http://www.doctrine-project.org/schemas/orm/doctrine-mapping.xsd
* https://raw.github.com/doctrine/doctrine2/master/doctrine-mapping.xsd
Now it is used http://doctrine-project.org/schemas/orm/doctrine-mapping.xsd everywhere.
2018-11-12 11:09:15 +01:00
Michael Moravec
427f815975
Merge pull request #7465 from unguul/patch-1
...
Fixes tiny typo in the 'Working with DateTime instances' documentation
2018-11-11 23:24:29 +01:00
Michael Moravec
bf601ce268
Merge pull request #7421 from seferov/patch-1
...
JIRA to Github issues on Limitations and Known Issues
2018-11-11 23:24:00 +01:00
Michael Moravec
8bfb363fcc
Merge pull request #7434 from naitsirch/fix/doc-faq-public-property
...
Removed FAQ paragraph stating public variables are disallowed
2018-11-11 23:22:58 +01:00
Michael Moravec
ebf2630a66
Merge pull request #7435 from oguzdumanoglu/patch-2
...
Fix a typo on Documentation
2018-11-11 23:22:25 +01:00
Michael Moravec
9018955e1f
Merge pull request #7412 from ThomasLandauer/patch-1
...
Some formatting improvements
2018-11-10 21:05:50 +01:00
Thomas Landauer
88d58ae0a3
Some formatting improvements
2018-11-10 20:45:03 +01:00
Michael Moravec
2fc99afd44
Merge pull request #7423 from ThomasLandauer/patch-2
...
Update association-mapping.rst
2018-11-10 20:40:44 +01:00
Michael Moravec
fa0885e25d
Merge pull request #7374 from SenseException/deprecate-yaml-docs
...
Deprecation message in documentation for YAML
2018-11-10 20:33:51 +01:00
Alexandru Ungureanu
0e4a0108d2
Fixes small typo
2018-11-08 13:59:21 +02:00
naitsirch
17bc627bf2
Added hint about exception in Query#getOneOrNullResult()
...
When calling `Query#getOneOrNullResult()` and there are more than one
objects in the result an `NonUniqueResultException` is thrown.
This information was missing in the documentation about the query result
formats.
This commit addresses #6793 .
2018-10-29 21:26:02 +01:00
Oguz Dumanoglu
58370256c0
Fix a typo
...
There was a typo in Working with Associations page.
2018-10-19 16:32:27 +02:00
naitsirch
d5364231c2
Removed FAQ paragraph stating public variables are disallowed
...
In #7427 @flaushi mentioned the outdated paragraph. This commit removes
this one.
2018-10-18 22:36:29 +02:00
Luís Cobucci
4df3a4d436
Merge pull request #7428 from Majkl578/php7.3
...
CI: Test against PHP 7.3
2018-10-14 09:39:26 +02:00
Michael Moravec
812989490c
CI: Test against PHP 7.3
2018-10-13 20:33:26 +02:00
Thomas Landauer
892ef9edb7
Update association-mapping.rst
...
Added info about owning and inverse side.
2018-10-09 21:33:42 +02:00
Farhad Safarov
982782f8c9
JIRA to Github issues
2018-10-09 11:52:22 +03:00
Michael Moravec
7319f524a3
Merge pull request #7397 from eibt/patch-1
...
Update getting-started.rst
2018-09-23 07:04:34 +02:00
Michael Moravec
1d71fbf77b
Merge pull request #7367 from timdev/fix/entitymanager-find-with-optimistic-lock-no-need-tx
...
Fix for BC break in 2.6.2 when calling EM::find() with LockMode::OPTIMISTIC outside of a TX
2018-09-23 06:43:26 +02:00
Ivan
7eacfec2c3
Fix typo in getting-started.rst
2018-09-23 06:39:11 +02:00
Michael Moravec
46f2a41cf7
Merge pull request #7377 from sserbin/fix-query-andx-doctype
...
Fix query andX doctype
2018-09-23 06:37:42 +02:00
Michael Moravec
fd2baf6f65
Merge pull request #7260 from stof/regression_commit_order
...
Fix the handling of circular references in the commit order calculator
2018-09-23 05:44:14 +02:00
Michael Moravec
c8bf06d549
Merge pull request #7401 from bobdenotter/patch-1
...
[docs] Fix docblock in `inheritance-mapping.rst`
2018-09-23 05:34:59 +02:00
Tim Lieberman
3acfa50214
Fix for BC break #7366 when calling EM::find() with LockMode::OPTIMISTIC outside of a TX
2018-09-23 05:33:05 +02:00
sserbin
3dbe205498
Query\Expr::andX(): added string as allowed parameter type
2018-09-23 05:23:49 +02:00
Michael Moravec
899cce8094
Merge pull request #7363 from philippe-unitiz/2.6
...
Fix compatibility with phan
2018-09-23 05:16:52 +02:00
Bob den Otter
7400d51444
Fix docblock in inheritance-mapping.rst
2018-09-23 05:12:55 +02:00
Michael Moravec
96c344d22b
Merge pull request #7345 from guilliamxavier/improve-DOMDocument-construct
...
Correct DOMDocument constructor in test
2018-09-23 05:11:21 +02:00
Michael Moravec
f48d71ecd0
Merge pull request #7378 from BenMorel/patch-2
...
Typo fix
2018-09-23 05:05:58 +02:00
philippe-unitiz
d3acbbf79b
Fix constructor argument type in Query\Base
2018-09-23 05:02:30 +02:00
philippe-unitiz
cb9ec8234b
Fix multiline parameter phpDoc in Query\Expr
...
See https://github.com/phan/phan/issues/1897 (parser won't accept `@param` spanning over several lines)
2018-09-23 05:02:01 +02:00
Guilliam Xavier
47c72e583e
correct load-only DOMDocument constructor in test
2018-09-23 04:52:52 +02:00
Christophe Coevoet
568c2d308c
Fix the computation of commit order for circular dependencies
...
When finding a circular dependencies, we must ensure that all dependencies
of a node have been visited before adding it to the sorted list.
2018-09-20 12:13:25 +02:00
Christophe Coevoet
11a7f359d1
Add a unit test reproducing the commit order regression
2018-09-20 12:11:44 +02:00
Christophe Coevoet
145f1f5198
Add a test reproducing GH7259
2018-09-20 11:53:08 +02:00
Claudio Zizza
ff1df41485
Add deprecation note to getting-started chapter
2018-09-07 21:06:08 +02:00
Claudio Zizza
d36aec8fb7
Add deprecation message for YAML into docs
2018-08-30 23:24:30 +02:00
Benjamin Morel
2779b5ee91
Typo fix
2018-08-28 14:56:01 +02:00
Pierre-Louis FORT
32efbd3edd
Handle removed parameters by tree walker in Paginator
2018-08-27 11:23:21 +02:00
Luís Cobucci
68718eac1b
Merge pull request #7360 from lcobucci/fix-partial-reference-docblock
...
Document getPartialReference() properly
2018-08-19 16:25:51 +02:00
Luís Cobucci
7b64b4a207
Document getPartialReference() properly
...
According to the current implementation that method also returns `null`,
however the interface's documentation was incorrect.
Ref: https://github.com/doctrine/doctrine2/blob/v2.6.2/lib/Doctrine/ORM/EntityManager.php#L514-L516
2018-08-18 14:52:17 +02:00
Michael Moravec
f1143f591f
Merge pull request #7325 from paxal/php73_compatible
...
Make code php 7.3 lint-compatible
2018-08-02 14:23:28 +02:00
Cyril PASCAL
07fc401d25
Make code php 7.3 lint-compatible
2018-07-26 14:32:52 +02:00
Luís Cobucci
96f166a7e9
Merge pull request #7307 from Majkl578/remaining-deprecations
...
Fix remaining usages of deprecated ClassLoader and Inflector from doctrine/common
2018-07-13 07:27:10 +02:00
Michael Moravec
f4b775323d
Fix remaining usages of deprecated ClassLoader and Inflector from doctrine/common
2018-07-13 05:31:39 +02:00
Michael Moravec
43d308116d
Bump version to 2.6.3-DEV
2018-07-12 23:24:26 +02:00
Michael Moravec
d2b4dd71d2
Preparing v2.6.2 release
2018-07-12 22:47:13 +02:00
Luís Cobucci
36e6a73d5b
Merge pull request #7296 from Majkl578/fix/2.6/#7286
...
Fix #7286 : StringPrimary no longer accepts aggregate functions as argument
2018-07-10 00:05:51 +02:00
Michael Moravec
e26158a45e
Fix #7286 : StringPrimary no longer accepts aggregate functions as argument
2018-07-09 19:12:39 +02:00
Marco Pivetta
3cfcd6a856
Merge pull request #7291 from Majkl578/fix/2.6/#7068
...
[2.6] Fix for #7068 : EntityManager::find() with pessimistic lock should check for transaction
2018-07-03 09:40:48 +02:00
Michael Kühn
ff68806bfa
Fix for #7068 : EntityManager::find() with pessimistic lock should check for transaction
2018-07-03 03:00:58 +02:00
Michael Moravec
4192c3abf4
Merge pull request #7290 from Majkl578/dbal-2.8-tests-compat
...
Fix compatibility with DBAL 2.8 (doctrine/dbal#3157 )
2018-07-03 02:58:02 +02:00
Michael Moravec
ac1e1c7d23
Fix compatibility with DBAL 2.8 where OFFSET 0 is no longer generated ( doctrine/dbal#3157 )
2018-07-03 02:14:23 +02:00
Luís Cobucci
9ab999618c
Merge pull request #7276 from Majkl578/entityrepository-count-upgrade
...
Add UPGRADE note for EntityRepository::count()
2018-07-03 02:05:46 +02:00
Michael Moravec
f2666a472f
Add UPGRADE note for EntityRepository::count()
2018-06-27 20:41:59 +02:00
Luís Cobucci
ceda5d3bc7
Merge pull request #7274 from Majkl578/non-deprecated-lexer-and-inflector
...
Use non-deprecated version of Lexer and Inflector
2018-06-25 23:56:32 +02:00
Michael Moravec
6d81d519b6
Use non-deprecated version of Lexer and Inflector
2018-06-25 14:20:52 +02:00
Marco Pivetta
88d1d79516
Merge pull request #7253 from JarJak/patch-2
...
Mention that Doctrine does not use Entities public API
2018-06-09 07:28:20 +02:00
Jarek Jakubowski
cfc6cfd1a3
Unnecessary newline removed, small improvements in text
2018-06-09 00:29:59 +02:00
Jarek Jakubowski
6b7d67b427
Add info about Doctrine not using constructor
2018-06-08 20:29:37 +02:00
Jarek Jakubowski
b6d08b15c0
Mention that Doctrine does not use Entities public API
2018-06-08 18:47:39 +02:00
Marco Pivetta
01f89a8cdc
Merge pull request #7190 from Tobion/patch-1
...
Fix wrong type in phpdoc of AbstractIdGenerator
2018-04-13 16:29:25 +01:00
mikeSimonson
efd7a5dca6
Merge pull request #7146 from Awkan/fix/7141-xml-order-by-default-asc
...
[XML] Fix default value of one-to-many order-by to ASC
2018-04-12 22:29:41 +02:00
Tobias Schultze
7ba0290643
entity should be nullable as in master
2018-04-10 19:15:48 +02:00
Tobias Schultze
8ceb47178b
Fix wrong type in phpdoc of AbstractIdGenerator
...
\Doctrine\ORM\Mapping\Entity is the annotation class which is not correct. The entity object itself is meant here as tests also assume see https://github.com/doctrine/doctrine2/blob/2.6/tests/Doctrine/Tests/ORM/Id/AssignedGeneratorTest.php#L28
Found this when running phpstan on our code that used a custom generator.
2018-04-10 18:31:36 +02:00
Donovan Bourlard
2560d4f419
Fix default value of one-to-many order-by to ASC, #7141
2018-03-22 14:51:02 +01:00
Marco Pivetta
87ee409783
Merge pull request #7082 from mariusklocke/issue-7062
...
Add failing test for issue #7062
2018-02-27 08:30:56 +01:00
Luís Cobucci
d47c1f3e9b
Fix basic entity persister type resolver
...
Which was using the wrong way to fetch the field type and using the
association type instead of the column type.
2018-02-26 14:39:06 +01:00
Marius Klocke
b952dac339
Add a failing test for issue 7062
2018-02-26 14:39:05 +01:00
Luís Cobucci
ffb7d4c79c
Merge pull request #7093 from lcobucci/patch-association-identifier-not-quoted
...
Fix updating entities with quoted identifier association
2018-02-25 20:28:33 +01:00
Jan Langer
e68717b725
Fix updating entities with quoted identifier association
2018-02-25 20:10:18 +01:00
Luís Cobucci
30a063ef9d
Merge pull request #6701 from vhenzl/pr/issue-6531-test
...
Add failing tests for #6531
Fixes https://github.com/doctrine/doctrine2/issues/6043
Fixes https://github.com/doctrine/doctrine2/issues/6531
Fixes https://github.com/doctrine/doctrine2/issues/7002
Fixes https://github.com/doctrine/doctrine2/pull/7003
2018-02-19 23:17:19 +01:00
Nicolas FRANÇOIS
35c3669ebc
Fix handling entities with post generated IDs as FK
...
This prevents a throw in UnitOfWork#addToIdentityMap because some fields
are null.
2018-02-19 23:05:13 +01:00
Vašek Henzl
23f4f03575
Add failing tests for #6531
...
Tests are based on examples from "Composite and Foreign Keys as Primary Key" tutorial:
http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/tutorials/composite-primary-keys.html
2018-02-19 22:14:57 +01:00
Luís Cobucci
a912fc09be
Add @group to delete query test
2018-02-19 22:04:28 +01:00
Marco Pivetta
a736a3713b
Merge pull request #6988 from kbond/inheritance-issue
...
Inheritance middle-layer doesn't get hydrated
2018-02-19 12:13:08 +01:00
Luís Cobucci
f2da5bc93e
Extract private method to retrieve discriminator values
2018-02-19 12:07:44 +01:00
Luís Cobucci
2905b435db
Remove loose comparison on discriminator values
...
According to mapping drivers the discriminator values can always be
converted to strings so it's safe to assume that we can actually do a
strict comparison during hydration.
2018-02-19 12:07:43 +01:00
Toni Cornelissen
48ca6dbcec
Use partial discriminator map on multi-inheritance
...
Hydrator was ignoring data from subclasses when using multiple
inheritance levels. With this patch it will now use the discriminator
values from all subclasses of the class being hydrated.
2018-02-19 12:07:42 +01:00
Kevin Bond
15a4302902
Inheritance middle-layer doesn't get hydrated with HYDRATE_OBJECT
2018-02-19 12:07:41 +01:00
Marco Pivetta
1f82a20312
Merge pull request #7077 from lcobucci/fix-delete-bc-break
...
Fix BC-break on delete without alias DQL
2018-02-19 11:32:46 +01:00
Luís Cobucci
fc943b70f6
Use early-returns to improve readability of the Parser
2018-02-19 00:53:42 +01:00
Luís Cobucci
f36470941c
Fix BC-break on delete queries with nasty workaround
...
The `v2.5.x` series of the ORM allowed to have DELETE DQLs without using
an alias, even though it didn't follow the grammar rules of the parser.
We fixed that issue on `v2.6.0` however that was a BC-breaking change
and lots of people were relying on this faulty behaviour.
This workaround fixes the BC-break, without even trying to be elegant.
In `v2.7.0.` we should raise a deprecation notice to notify people that
we'll drop that "feature" in `v3.0`.
2018-02-19 00:53:36 +01:00
Carnage
ae6d80daab
Adds sql generation test
2018-02-19 00:50:27 +01:00
Luís Cobucci
44e82e2720
Remove unused functions
2018-02-17 19:49:16 +01:00
Luís Cobucci
e94467d6da
Fix incorrect value in L2C+lock test
...
Which was causing the optimistic lock to fail in MySQL since it was
trying to update the data with exact same value.
2018-02-17 19:46:22 +01:00
Luís Cobucci
794c7708e8
Merge branch 'backport/fix/l2c-version' into 2.6
...
Backporting https://github.com/doctrine/doctrine2/pull/7069
2018-02-17 18:09:39 +01:00
‘Andrey Lukin’
8e73926359
Add version fields into L2C data
2018-02-17 18:05:32 +01:00
‘Andrey Lukin’
8fc1d74820
Add test for L2C using optimistic locks
...
As explained in #7067 , fields with `@ORM\Version` annotation were not
being added to L2C cached data.
2018-02-17 18:05:27 +01:00
Luís Cobucci
496c6a9f03
Merge branch 'backport/fix-date-issues-once-and-for-all' into 2.6
...
Backporting https://github.com/doctrine/doctrine2/pull/7055
2018-02-09 17:21:29 +01:00
Luís Cobucci
7873f700b0
Add missing tests for day calculation
...
For the DATE_SUB() and DATE_ADD() functions.
2018-02-09 17:21:06 +01:00
Luís Cobucci
46c0861f45
Fix date calculation in tests (again)
...
Now using PHP to calculate the expected date manipulation, keeping a day
as delta since PHP resets the hour when performing operations with
days/weeks/months/years.
February is a wonderful month, isn't it?
2018-02-09 17:21:06 +01:00
Luís Cobucci
5149c0ff25
Merge branch 'backport/fix/7031-tests-february' into 2.6
...
Backporting: https://github.com/doctrine/doctrine2/pull/7032
2018-02-02 09:07:25 +01:00
Michael Moravec
cf99d62472
QueryDqlFunctionTest: Increase delta for testDateAdd() to work in February
2018-02-02 08:59:35 +01:00
Luís Cobucci
5878797eae
Merge pull request #6971 from rolando-caldas/master
...
Exception Call to undefined method Doctrine\Common\Cache\MemcachedCache::setMemcache()
2018-01-30 01:53:35 +01:00
Rolando Caldas
8c2d090dc8
Exception Call to undefined method Doctrine\Common\Cache\MemcachedCache::setMemcache()
...
When memcached extension is loaded Doctrine\ORM\Tools\Setup.php calls to setMemcache method. The MemcachedCache class has the setMemcached method instead. Changed this call in Setup to setMemcached and $memcache to $memcached to keep the name like the extension
2018-01-30 01:38:56 +01:00
Luís Cobucci
3f772eac32
Merge pull request #7021 from lcobucci/fix-phpstan-check
...
Fix incorrect variable reference
2018-01-30 01:38:21 +01:00
Luís Cobucci
62c952d258
Fix wrong variable reference
2018-01-30 01:21:34 +01:00
Luís Cobucci
c2f698e56e
Merge pull request #6997 from NicolaF/fix/fix-6991-2.6
...
ManyToManyPersister fails to remove join table entry if there is multiple join columns
2018-01-30 01:19:12 +01:00
Nicolas FRANÇOIS
40f2a3efba
Add test case for many-to-many collection deletion, when owning side has a composite PK
2018-01-30 01:04:28 +01:00
Nicolas FRANÇOIS
333b9c0b99
Fix #6991 : correctly resolve identifer values in ManyToManyPersister
2018-01-19 12:19:02 +01:00
Luís Cobucci
90d19b4131
Bumping development version to v2.6.1-DEV
2017-12-20 02:01:05 +01:00
Luís Cobucci
374e7ace49
Preparing v2.6.0 release
2017-12-20 01:38:15 +01:00
Marco Pivetta
d752cafb47
Merge pull request #6911 from lcobucci/bump-dependencies
...
Require more up-to-date dependencies
2017-12-20 00:19:31 +01:00
Luís Cobucci
0e44271a40
Require more up-to-date dependencies
2017-12-20 00:10:05 +01:00
Marco Pivetta
4c89498359
Merge branch 'feature/#6767-allow-association-as-JTI-identifier'
...
Close #6767
2017-12-19 18:02:48 +01:00
Marco Pivetta
b6aa4bab15
#6767 using in_array rather than array_search
...
Ref: https://github.com/doctrine/doctrine2/pull/6767/files#r157355050
2017-12-19 18:01:38 +01:00
Marco Pivetta
27c42d418b
#6767 removed unused variable
...
Ref: https://github.com/doctrine/doctrine2/pull/6767/files#r157354726
2017-12-19 18:00:03 +01:00
Tyler Romeo
bb8970286d
Allow association mappings as IDs for joined-table inherited entity
...
SchemaTool has custom logic for creating the primary key of a
joined-table inherited entity. This logic overlooked association maps
as a possible source for identity columns, resulting in a fatal error
when fetching the primary key list for child entities.
Removed any custom logic for generating primary keys for root entities
in joined-table inheritance, deferring to the common logic used for
other entities.
Also adjusted the child entity logic, scanning association maps for
identity columns, and including the column as appropriate. It also
ensures that the primary key columns are in the correct order.
2017-12-19 17:58:31 +01:00
Luís Cobucci
b210c1e364
Merge pull request #6905 from Majkl578/setup-cache-7.1-compat
...
Setup: Switch Apc -> Apcu and Memcache -> Memcached
2017-12-19 08:21:02 +01:00
Guilherme Blanco
a16dc65cd2
Fixes #1391 , DDC-3693
2017-12-18 22:46:48 -05:00
Guilherme Blanco
0345f7b836
Merge pull request #1578 from StoshSeb/patch-1
...
Fixed DDC-3740
2017-12-18 22:41:18 -05:00
Michael Moravec
349724f05b
Setup: Switch Apc -> Apcu and Memcache -> Memcached
2017-12-19 02:43:03 +01:00
Michael Moravec
e1825e37ef
Merge pull request #6780 from aequasi/patch-1
...
getRepository actually returns ObjectRepository
2017-12-18 00:40:47 +01:00
Luís Cobucci
cfa1dfbfe6
Merge pull request #6887 from greg0ire/stable_stability
...
Use stable packages
2017-12-18 00:39:02 +01:00
Grégoire Paris
8e3c3f0bae
Add marker variable for Travis
2017-12-18 00:14:00 +01:00
Grégoire Paris
ad3c3f4114
Implement conditional build
...
This will make cron builds fail, which is a bit more noticeable than an
allowed failure.
2017-12-17 23:38:16 +01:00
Grégoire Paris
8ca7db8852
Use stable packages
...
This will make it easier to contribute. It will also make reviews safer
since you will be able to tell if a PR is reponsible for a broken build
or not. Catching errors early is still possible by having a look at
allowed failures.
2017-12-17 23:38:16 +01:00
Michael Moravec
ca42879f9e
Merge pull request #6898 from Majkl578/upgrade-typos
...
UPGRADE: Added method parenthesis, fixed method name
2017-12-17 04:43:43 +01:00
Michael Moravec
28b6ca3a16
UPGRADE: Added method parenthesis, fixed method name
2017-12-17 04:31:42 +01:00
Luís Cobucci
c4a5e5c3f8
Merge pull request #6748 from KonstantinKuklin/patch1
...
Fix missing null check on `AbstractQuery#setResultCacheProfile()`
2017-12-17 03:37:06 +01:00
Konstantin Kuklin
c308986a90
Fix insufficient variable check
...
To ensure that `AbstractQuery#setResultCacheProfile()` doesn't raise
errors when being called with `null`.
2017-12-17 03:21:52 +01:00
Luís Cobucci
739f518ebe
Merge pull request #6892 from thexpand/patch-1
...
Re-order attributes of relation complex types
2017-12-17 02:49:49 +01:00
Cvetomir
a46e794b60
Re-order attributes of relation complex types
...
This will provide the same look for all of the relations: one-to-many, many-to-one, one-to-one, many-to-many.
It helps during auto-completion of XML code when creating XML schema for an entity.
The order is as follows: field, target-entity, mapped-by, inversed-by, indexed-by, fetch, orphan-removal.
2017-12-17 02:36:41 +01:00
Luís Cobucci
d3ff823f97
Merge pull request #6812 from Deltachaos/bugfix/inheritance-joins-master
...
Fix syntax error when join unrelated entity with discriminator entity
2017-12-17 01:42:42 +01:00
Maximilian Ruta
32c125def1
Fix syntax error when join with discriminator
2017-12-17 01:25:50 +01:00
Michael Moravec
0837493a7c
Merge pull request #6894 from Majkl578/fix-readme-php-version
...
README: Fix PHP version
2017-12-17 01:16:50 +01:00
Luís Cobucci
260c2e899a
Merge pull request #6897 from lcobucci/update-phpstan
...
Upgrade PHPStan to 0.9.x
2017-12-17 01:08:48 +01:00
Luís Cobucci
74ce8913fc
Upgrade phpstan to 0.9
...
Applying the necessary fixes.
2017-12-17 00:55:50 +01:00
Luís Cobucci
80a94727ee
Run tests also with the stable version of dependencies
2017-12-17 00:54:12 +01:00
Luís Cobucci
d6212dd09e
Merge pull request #6896 from lcobucci/improve-build-stages
...
Run all code quality tools in the same stage
2017-12-17 00:04:58 +01:00
Luís Cobucci
122e9c3aa3
Run all code quality tools in the same stage
...
In order to execute things in parallel and speed up the build.
2017-12-16 23:52:20 +01:00
Luís Cobucci
8e4f624f90
Merge pull request #6895 from lcobucci/simplify-LimitSubqueryWalker
...
Reduce complexity of LimitSubqueryWalker#walkSelectStatement()
2017-12-16 23:50:24 +01:00
Luís Cobucci
441c5d138c
Reduce complexity of LimitSubqueryWalker#walkSelectStatement()
...
Ensuring that the code follows our code standards.
2017-12-16 23:31:50 +01:00
Michael Moravec
b3654f95d0
README: Fix PHP version
2017-12-16 22:05:22 +01:00
Michael Moravec
aacea65519
Merge pull request #6889 from carusogabriel/clean-elses
...
Clean elses
2017-12-16 05:30:33 +01:00
Gabriel Caruso
d0d802309c
Clean elses
2017-12-14 05:55:54 -02:00
Michael Moravec
a352c214a0
Merge pull request #6805 from yesdevnull/patch-1
...
[Docs] Corrected NamingStrategy demo code to match example
2017-12-12 04:30:01 +01:00
Dan Barrett
cd00ccae69
Updated table/column names example to be lowercase
2017-12-11 12:14:39 +11:00
Guilherme Blanco
e149f89cfe
Merge pull request #6820 from plfort/#6819-pagination-optim
...
#6819 Optimize LimitSubqueryWalker
2017-12-10 19:56:31 -05:00
Marco Pivetta
b79b26aa8b
Merge pull request #5805 from borNfreee/patch-1
...
Fix typo in documentation
2017-12-08 09:44:35 +01:00
Maks Rafalko
04d9bc40e4
Update validation-of-entities.rst
2017-12-08 09:33:41 +03:00
Michael Moravec
31816f6e2f
Merge pull request #1442 from elazar/patch-1
...
Corrected bad class reference in "Adding own commands"
2017-12-08 05:13:04 +01:00
Michael Moravec
d32a8634aa
Merge pull request #5736 from guilliamxavier/patch-3
...
Fix PHP syntax error in composite-primary-keys.rst
2017-12-08 04:39:56 +01:00
Luís Cobucci
f13f7ebe54
Merge pull request #6862 from OskarStark/typo
...
fixed closing tag
2017-12-03 11:27:52 +01:00
Oskar Stark
79e1be8c3d
fixed closing tag
2017-12-01 15:41:52 +01:00
Luís Cobucci
92dd27fe3f
Merge pull request #6826 from JKapitein/patch-1
...
Add Type::GUID to $typeAlias list in EntityGenerator
2017-11-28 00:38:11 +01:00
JKapitein
ad0a8c53fa
Add Type::GUID to $typeAlias list in EntityGenerator
...
Right now, when generating entities, a column of type 'guid' will generate the following PHPDoc:
```
/**
* Get id
*
* @return guid
*/
public function getId() {...}
```
Since guid is not a valid PHP type, this throws a warning in PHPStorm, and I assume most IDEs.
Adding the type to the type alias list fixes the problem.
2017-11-28 00:11:32 +01:00
Luís Cobucci
be18256a93
Merge pull request #6849 from lcobucci/fix/options-on-entity-generation
...
Make entity generator generate values for all supported options
Fixes: https://github.com/doctrine/doctrine2/issues/6703
2017-11-26 20:55:28 +01:00
Luís Cobucci
bc7aeb9d11
Make entity generator create the correct options
...
The `EntityGenerator` was not creating the field options for all
supported values.
2017-11-26 20:05:52 +01:00
Luís Cobucci
6e095f7c3b
Merge pull request #6801 from foaly-nr1/DDC6029
...
Improve misleading ORMInvalidArgumentException message
Fixes: https://github.com/doctrine/doctrine2/issues/6029
2017-11-26 18:54:01 +01:00
foaly-nr1
c0a505366f
Use the correct type for the exception message
...
Since the UoW checks each item of a *-to-many association to ensure
it has the correct type, we should never say that we expect an instance
of `Doctrine\Common\Collections\Collection` or an `array`.
2017-11-26 17:55:59 +01:00
foaly-nr1
b211dd4db7
Add failing test for misleading exception message
...
Describes: https://github.com/doctrine/doctrine2/issues/6029
2017-11-26 17:55:59 +01:00
Luís Cobucci
3ca65e28fc
Merge pull request #6683 from alextech/bugfix/xml_sequence_params
...
Supply default values for optional values in sequence mapping if omitted by driver.
Fixes: https://github.com/doctrine/doctrine2/issues/6682
2017-11-26 17:07:03 +01:00
Sasha Alex Romanenko
b3331b2237
Enforce sequence XSD requirement
...
Supply default values for allocationSize and initialValue optional parameters.
Related to: https://github.com/doctrine/doctrine2/issues/6682
2017-11-26 16:33:27 +01:00
Luís Cobucci
dfc31bc855
Merge pull request #6740 from mduplouy/DDC288
...
Fix operator when using criteria on ManyToMany
Fixes: https://github.com/doctrine/common/issues/600
2017-11-26 14:21:57 +01:00
Mathieu Duplouy
7c28a932ae
Add operator to walkComparison output
2017-11-26 14:03:54 +01:00
Mathieu Duplouy
15c145f3b3
Add failing test for DCOM-288
...
Reported on: https://github.com/doctrine/common/issues/600
2017-11-26 13:54:54 +01:00
Luís Cobucci
dda42f6c09
Merge pull request #6848 from lcobucci/cache-namespace-fix
...
Fix overwriting explicit cache namespace
Replaces: https://github.com/doctrine/doctrine2/pull/5904
2017-11-26 13:22:24 +01:00
Jan Jakes
99b2e57606
Fix overwriting explicit cache namespace
2017-11-26 12:48:12 +01:00
Luís Cobucci
d3759a2447
Fix incorrect arguments on SetupTest
...
Which was only caught by adding proper type declaration on private
methods.
2017-11-26 12:26:28 +01:00
Luís Cobucci
b7cace86a0
Merge pull request #6705 from Majkl578/ticket/6699
...
Fix parameter name comparison in AbstractQuery regarding different types (fixes #6699 )
Fixes https://github.com/doctrine/doctrine2/issues/6699
2017-11-24 03:00:07 +01:00
Luís Cobucci
b8fd708139
Fix parameter name comparison in QueryBuilder#setParameter() with different types
2017-11-24 02:43:01 +01:00
Michael Moravec
6cb5a9c50a
Fix parameter name comparison in AbstractQuery#setParameter() with different types
2017-11-24 02:43:00 +01:00
Michael Moravec
4bbb1067ac
Add failing test for #6699
2017-11-24 02:42:59 +01:00
Luís Cobucci
b47a39be64
Merge pull request #6655 from OskarStark/symfony-style
...
Use SymfonyStyle for command output
2017-11-24 01:52:00 +01:00
Oskar Stark
6b5eb11458
Use SymfonyStyle for command output
2017-11-24 01:25:17 +01:00
Luís Cobucci
43a88d539d
Format commands' tests
...
To simplify and organise the code (also replacing `$this->assert*`
with `self::assert*`).
2017-11-24 01:25:15 +01:00
Luís Cobucci
8a893068ce
Remove constants existence validation
...
These constants are available since PHP 5.4 and since we're requiring
PHP 7.1 there's no reason to require them.
I've also simplified the `array_map()` call since it's useless to
define a closure that simply calls a function.
2017-11-24 01:25:14 +01:00
Oskar Stark
214dc9896b
Use addOption()/addArgument() to configure commands
...
In order to simplify and standardise the definition of the commands.
2017-11-24 01:20:09 +01:00
Luís Cobucci
ba32237e2b
Merge pull request #6844 from lcobucci/configure-phpcs
...
Configure PHPCS
2017-11-23 13:30:18 +01:00
Luís Cobucci
984327d782
Update PHPStan
2017-11-23 11:29:39 +01:00
Luís Cobucci
2be1b7d0b8
Add configuration for PHPCS
...
And execute it on Travis (allowing it to fail for now to prevent a lot
of conflicts with `develop`).
2017-11-23 11:26:33 +01:00
Luís Cobucci
13197123c5
Sort dependencies definitions
2017-11-23 11:15:52 +01:00
Luís Cobucci
24408b42d3
Merge pull request #6843 from lcobucci/use-new-scrutinizer-config
...
Use new analyser on scrutinizer-ci
2017-11-23 11:08:52 +01:00
Luís Cobucci
8918bd3b8a
Use new analyser on scrutinizer-ci
...
Also preventing from running the tests (because that's already done on
Travis-CI) and simplifying the build failure conditions.
2017-11-23 10:24:18 +01:00
Pierre-Louis FORT
4ab9413675
Test that orderByItem is string
2017-11-10 10:45:57 +01:00
Pierre-Louis FORT
91408a3a54
#6819 Optimize LimitSubqueryWalker when resultVariable are involved and they are not used in "order by"
2017-11-09 14:34:11 +01:00
Dan Barrett
bccc46dc12
Corrected demo code to match example
...
Example paragraph mentions changing column titles to upper case, yet `strtolower` was being used.
2017-11-01 16:40:04 +11:00
Luís Cobucci
a82f6c5725
Merge pull request #6742 from Legenyes/feature/DDC-2938_Support_all_time_intervals_on_DATE_ADD
...
Add support second, minute, week, year on DATE_ADD and DATE_SUB
Fixes #5835
2017-10-31 20:46:02 +01:00
Luís Cobucci
59792654c0
Improve tests for DATE_ADD and DATE_SUB
...
So that we can do proper assertions and cover all the possibilities
of the functions.
2017-10-31 15:48:26 +01:00
Sébastien Lévêque
f277eef6ea
Add support second, minute, week, year on DATE_ADD and DATE_SUB
2017-10-29 21:48:40 +01:00
Andreas
ed86ee2567
Merge pull request #6800 from ErikJson/master
...
Fix some grammar and outdated information in docs
2017-10-29 05:53:58 +01:00
Erik Johansson
302c3a6640
Fix some grammar and outdated information in docs
2017-10-29 00:28:10 +03:00
Luís Cobucci
0497f50ba6
Merge pull request #6766 from ThomasLandauer/patch-1
...
Moved explanation out of PHP-Codeblock...
2017-10-26 09:49:48 +02:00
Marco Pivetta
2129801ac1
Merge pull request #6788 from kejwmen/fix/custom-types-docs
...
[Docs] Type::convertToDatabaseValue is always called
2017-10-24 08:46:02 +02:00
Mateusz Sip
620319f206
Type::convertToDatabaseValue is always called
2017-10-24 01:50:58 +02:00
Marco Pivetta
5f3afa4c4f
Merge pull request #6778 from stevepetcu/clarify-embedded-embeddable-docs
...
Clarify docs for embedded and embeddable.
2017-10-19 12:40:50 +02:00
Aaron Scherer
99db207a9f
getRepository actually returns ObjectRepository
2017-10-18 19:10:00 -07:00
Stefan Petcu
0bea6881da
Clarify docs for embedded and embeddable.
2017-10-17 19:21:34 +02:00
Guilherme Blanco
e279dfaa91
Merge pull request #6772 from greg0ire/disallow_many_to_one_orphan_removal
...
Disallow orphan removal attribute on many-to-one
2017-10-16 07:47:26 -04:00
Guilherme Blanco
87a6d0b77e
Merge pull request #6774 from greg0ire/proove_orphan_removal_is_useless
...
Proove orphan removal is useless
2017-10-15 22:12:31 -04:00
Grégoire Paris
ffd3d34f34
Disable uuid generation
...
Apparently, setting a value by hand is not enough to avoid it.
2017-10-14 12:39:58 +02:00
Grégoire Paris
57e9feffb2
Avoid uuid generation
...
pg needs an extra module to do this, so let's spare us that and set them
manually.
2017-10-14 12:39:58 +02:00
Grégoire Paris
6b5c97055c
Set null on delete, at database level
2017-10-14 12:39:57 +02:00
Grégoire Paris
30fccf8e83
Proove orphan-removal on many-to-one is useless
2017-10-14 12:39:57 +02:00
Grégoire Paris
2a865177b9
Disallow orphan removal attribute on many-to-one
...
It only makes sense for collections, and there is no collection here.
Plus the docs do not say it is supported.
See
http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/reference/working-with-associations.html#orphan-removal
2017-10-13 16:38:02 +02:00
Thomas Landauer
d560449661
Minor formating
2017-10-11 22:50:32 +02:00
Thomas Landauer
436b15e873
Moved explanation out of PHP-Codeblock...
...
...to make it visible for XML and YML too.
2017-10-11 22:45:42 +02:00
Marco Pivetta
aea970722e
Merge pull request #6764 from AlessandroMinoccheri/fix_doc
...
fixed little typo inside documentation
2017-10-11 20:44:16 +02:00
Alessandro Minoccheri
b1466e6d3e
fixed little typo inside documentation
2017-10-11 17:04:29 +02:00
Luís Cobucci
8e16748ff8
Merge pull request #6734 from ossinkine/issue-6734
...
Add DateInterval type parameter
2017-10-11 13:13:09 +02:00
Luís Cobucci
9e9e5628f5
Merge pull request #6755 from BenMorel/patch-2
...
EntityManager::getReference() can return null
2017-10-09 20:05:46 +02:00
Luís Cobucci
f2dc9a8f92
Merge pull request #6760 from doctrine/fix/#6759-showstopper-one-to-one-inverse-not-being-loaded-with-correct-identifier-restrictions
...
#6759 showstopper one-to-one inverse not being loaded with correct identifier restrictions when defining `joinColumn`
2017-10-08 14:47:15 +02:00
Marco Pivetta
66f903a38f
#6759 remove # symbol from @group annotation as per @lcobucci's review
...
Ref: https://github.com/doctrine/doctrine2/pull/6760#discussion_r143353225
2017-10-08 14:26:45 +02:00
Marco Pivetta
3dd7eb5888
#6759 removing outdated comment as per @alcaeus' review
...
Ref: https://github.com/doctrine/doctrine2/pull/6760#discussion_r143347881
2017-10-08 10:57:33 +02:00
Marco Pivetta
dd12ba88ee
#6759 avoiding reuse of the $identifier variable when constructing an identifier from the owning side value
...
Fixes #6759
2017-10-07 12:54:36 +02:00
Marco Pivetta
83e00d5010
#6759 cleaning up test case, using new models from the isolated namespace
2017-10-07 12:52:34 +02:00
Marco Pivetta
d831f4fd9f
#6759 segregating test models into their own namespace
2017-10-07 12:48:19 +02:00
Marco Pivetta
6ba2d1c317
#6759 cleaning up test case body
2017-10-07 10:09:44 +02:00
Jan Langer
5f99cad669
Failing test - inverse side OneToOne loaded without identifier condition
2017-10-06 17:34:34 +02:00
Benjamin Morel
fb7a96caf9
EntityManager::getReference() can return null
2017-10-05 00:27:11 +02:00
Jonathan H. Wage
13f838f8be
Merge pull request #6749 from KonstantinKuklin/patch2
...
sync type of property em with constructor value
2017-10-04 08:47:55 -04:00
Konstantin Kuklin
2d88e45240
sync type of property em with constructor value
2017-10-04 03:43:20 +03:00
Marco Pivetta
2ade863bca
Merge pull request #6746 from doctrine/malarzm-patch-1
...
[DOCS] Emphasize that Embeddable can only contain simple fields
2017-10-03 17:42:31 +02:00
Maciej Malarz
19dcd629c0
[DOCS] Emphasize that Embeddable can only contains simple fields
2017-10-03 17:14:06 +02:00
Gocha Ossinkine
4fdbdabae4
Add DateInterval type parameter
2017-09-28 13:15:40 +05:00
Marco Pivetta
53245e8a73
Merge pull request #6731 from guiajlopes/master
...
#6723 Remove variable from UnitOfWork#createEntity()
2017-09-26 13:10:39 +02:00
Guilherme Lopes
a7e13f89cc
#6723 Remove variable from UnitOfWork#createEntity()
2017-09-26 12:52:18 +02:00
Marco Pivetta
1d5c87ee4b
Merge pull request #6714 from guiajlopes/master
...
Remove unnecessary else
2017-09-21 14:30:25 +02:00
Marco Pivetta
f96dc3ba91
Merge pull request #6715 from PowerKiKi/patch-3
...
Promote nullable types from PHP 7.1
2017-09-21 14:29:23 +02:00
Adrien Crivelli
3d3ecc77bd
Drop PHP version specifics
2017-09-21 21:28:19 +09:00
Guilherme Lopes
df1250ee4b
Fix negation clause and also adding both conditions in the same if
2017-09-21 13:42:51 +02:00
Adrien Crivelli
d995203ee1
Promote nullable types from PHP 7.1
...
Also don't show type hinting in a bad light with sentences such as "If you insist on type-hinting"
2017-09-21 17:29:54 +09:00
Guilherme Lopes
8ecddc4fc1
Adding empty line between logic blocks
2017-09-21 10:13:19 +02:00
Guilherme Lopes
059cfd86df
Remove unnecessary else
2017-09-21 10:02:43 +02:00
Benjamin Eberlei
0c4f9a8866
Clarify some assumptions the object hydration makes.
2017-09-16 17:15:08 +02:00
Marco Pivetta
6a86175617
Merge pull request #6695 from wshafer/prefix-update
...
Update table prefix docs
2017-09-11 20:58:11 +02:00
Marco Pivetta
bf8e27b422
Merge pull request #6690 from bitwombat/issue_6686
...
Clarify association mapping language
2017-09-11 08:51:50 +02:00
Marco Pivetta
80f7824b3d
Merge pull request #6691 from keradus/php_syntax
...
Use newer PHP syntax
2017-09-11 08:50:05 +02:00
Westin Shafer
828bfdf4ae
Update docs for deprecated setTableName()
...
Updated docs to remove deprecated setTableName() and replace it with setPrimaryTable()
2017-09-07 13:59:32 -06:00
Dariusz Ruminski
c7d6d62393
Use newer PHP syntax
2017-09-06 01:32:49 +02:00
Greg Bell
c429f1c38b
Clarify association mapping language
...
- 5.3 was wrong - should really be 'inversedBy'
- 11.1 - change 'use' to 'have' for consistency. A class has an attribute.
- See https://github.com/doctrine/doctrine2/issues/6686
2017-09-06 07:58:34 +10:00
Marco Pivetta
8b81691e77
Merge pull request #6685 from votemike/update-maxresult-docblocks
...
Updating `Query#$_maxResults` to allow for `null` (no limit)
2017-09-04 11:40:06 +02:00
Michael Gwynne
d0d1e557d1
Adding change to appease scrutinizer
2017-09-04 10:11:43 +01:00
Michael Gwynne
fd9f96c766
Updating _maxResults to allow for null
2017-09-04 09:26:11 +01:00
Marco Pivetta
4bc29d1049
Merge branch 'fix/#5796-catch-also-throwable-in-transactional-abstraction'
...
Close #5796
2017-09-02 13:58:08 +02:00
Marco Pivetta
c016e2d434
Adding minimal test to verify EntityManager behavior against #5796
2017-09-02 13:55:07 +02:00
Marco Pivetta
12043cd845
#5796 minor CS fixes (imported symbols) and removing last PHP5 compliance bits
2017-09-02 13:47:58 +02:00
Marco Pivetta
a1c93bfd48
#5796 replacing Exception catching with Throwable catching, removing PHP5 compliance code
2017-09-02 13:44:12 +02:00
Benjamin Morel
874a5e3547
Catch Throwable in PHP 7
2017-09-02 13:41:53 +02:00
Marco Pivetta
68706034e5
Merge pull request #6658 from Majkl578/fix/allow-stable-yaml
...
Drop explicit conflict with stable symfony/yaml
2017-08-30 22:43:28 +02:00
Michael Moravec
bfc76adce0
Drop explicit conflict with stable symfony/yaml
...
As per discussion in #6639 , conflict with versions below 3.4
of the YAML component is superfluous, previous versions
would work just fine even with bb994b9e70 .
2017-08-30 22:06:19 +02:00
Marco Pivetta
8c7052c99c
Merge pull request #6652 from doctrine/fix/allow-batch-insert-test-to-run-in-multiple-revolutions
...
Correcting the `SimpleInsertPerformanceBench` duplicate record issues when run with multiple revolutions/iterations
2017-08-26 16:42:51 +02:00
Marco Pivetta
e1e7485e58
Correcting the SimpleInsertPerformanceBench, which was running into duplicate record integrity constraint violations when run with >1 revs
2017-08-26 16:41:03 +02:00
Marco Pivetta
7a0385634f
Merge pull request #6651 from doctrine/fix/use-quote-model-set-when-available
...
Replacing direct `quote` model-set schema creation with actually existing model-set setup
2017-08-26 14:23:26 +02:00
Marco Pivetta
922c55f5dd
Replacing direct quote model-set schema creation with actually existing model-set setup
2017-08-26 14:15:05 +02:00
Marco Pivetta
61404e2d6d
Merge pull request #6640 from doctrine/fix/#6284-#6217-avoid-passing-l2-cache-information-internals-to-the-uow
...
#6217 #6284 when hydrating an entity with a composite primary key that is both an `EAGER` and a `LAZY` association and also cached, the `DefaultQueryCache` tries to pass L2 cache implementation detail objects to the `UnitOfWork`
2017-08-25 09:22:45 +02:00
Marco Pivetta
660f164568
#6284 #6217 s/$this->assert/self::assert as per @lcobucci's review
2017-08-25 09:21:12 +02:00
Marco Pivetta
acfc890dbd
Merge pull request #6644 from AlessandroMinoccheri/fix_documentation_typo
...
fixed typo into native-sql documentation
2017-08-24 11:29:17 +02:00
Alessandro Minoccheri
a708d4076e
fixed typo into native-sql documentation
2017-08-24 11:27:54 +02:00
Marco Pivetta
aac0204611
Merge pull request #6642 from radmax/patch-1
...
Fixed typo in DQL docs
2017-08-24 10:57:11 +02:00
radmax
ed047520c3
fixed typo
2017-08-24 10:55:29 +02:00
Marco Pivetta
caa008b61d
#6284 #6217 removing hacks around the ClassMetadata details - invalid fix that was actually fixing the symptom
2017-08-23 00:25:29 +02:00
Marco Pivetta
07b397f341
#6284 fixing actual issue, which comes from an extremely tricky L2 caching issue.
...
We are not hydrating some of the cached association data into entities due to keys missing in the cache association definition.
Since this is an extreme edge case that is just a mismatch between db and cache, a detailed explanation was provided in the fix snippet as well
2017-08-23 00:19:49 +02:00
Marco Pivetta
c9d1f852de
#6284 removing unused lazy entity
2017-08-22 21:41:04 +02:00
Marco Pivetta
c29a1e96b7
#6284 removing unused separate class
2017-08-22 21:40:42 +02:00
Marco Pivetta
a2f4053a81
#6284 renaming variables, classes and properties to fit tested behavior
2017-08-22 21:38:44 +02:00
Marco Pivetta
3f09e20955
#6284 correcting alignment, removing stuff that isn't strictly needed
2017-08-22 21:31:01 +02:00
Marco Pivetta
220dc79ebf
#6284 renaming entities to match the scope of this test
2017-08-22 21:29:27 +02:00
Marco Pivetta
6f6e88cfb6
#6284 adding assertions about equality of the loaded classes
2017-08-22 21:27:46 +02:00
Marco Pivetta
dac1ce4172
#6284 removing profile entity, since it is not needed to reproduce the issue
2017-08-22 21:21:53 +02:00
Marco Pivetta
ca39abcd71
#6284 reducing annotation mapping clutter
2017-08-22 21:17:14 +02:00
Marco Pivetta
4e0b76ce69
#6284 eager fetching is strictly required to verify the issue
2017-08-22 21:14:38 +02:00
Marco Pivetta
805ba041ef
#6284 reducing annotation mapping clutter
2017-08-22 21:12:45 +02:00
Marco Pivetta
3842ad8ea1
#6284 simplifying tests to a minimum, removing unused auto-generated id field
2017-08-22 21:11:03 +02:00
Marco Pivetta
c7281f6ade
#6284 simplifying tests to a minimum, removing unused auto-generated id field
2017-08-22 21:08:06 +02:00
Marco Pivetta
a8453dda89
#6284 removing the "WTF" part of the logic - an association cache entry should never ever reach metadata
2017-08-22 21:03:14 +02:00
Waleed Gadelkareem
309b286ed3
Add tests for #6217
2017-08-22 19:45:26 +02:00
Marco Pivetta
8ad3dfd3bd
Merge branch 'fix/#1521-DDC-2922-defer-checking-non-persisted-entities-through-multiple-differently-mapped-cascading-associations'
...
Close #1521
Close DDC-2922
2017-08-22 10:26:15 +02:00
Marco Pivetta
645cccf2db
#1521 DDC-2922 adapting test so the UnitOfWork stops bragging about previous inconsistent states
2017-08-22 10:24:46 +02:00
Marco Pivetta
2be32f249c
#1521 DDC-2922 adapting UoW and exception implementation to the new specification
2017-08-22 09:57:57 +02:00
Marco Pivetta
4a007c76f5
#1521 DDC-2922 spec for a new exception endpoint that produces a multi-new-non-cascaded-entities error message
2017-08-22 09:56:43 +02:00
Marco Pivetta
a754eae0f0
#1521 DDC-2922 verifying that persistence operations will resume normally after a crash due to invalid new values detected on associations - tweaked test to make it fail
2017-08-22 08:51:27 +02:00
Marco Pivetta
89fbb6a060
#1521 DDC-2922 verifying that persistence operations will resume normally after a crash due to invalid new values detected on associations
2017-08-22 08:49:42 +02:00
Marco Pivetta
2751c0fff2
#1521 DDC-2922 minor code cleanup - renaming internal private methods, variables, removing redundant if/else
2017-08-21 20:08:20 +02:00
Marco Pivetta
87e8bccb11
#1521 DDC-2922 removed redundant integration test that was replaced by a unit test
2017-08-21 19:58:52 +02:00
Marco Pivetta
f39614136f
#1521 DDC-2922 reproducing test scenarios within the UnitOfWorkTest
2017-08-21 19:58:16 +02:00
Marco Pivetta
a3208f8d08
#1521 DDC-2922 removed unrelated model usage from test - using minimal models only
2017-08-21 19:47:16 +02:00
Marco Pivetta
e21b29c264
#1521 DDC-2922 simplified test case to a minimum reproducible unit
2017-08-21 19:44:38 +02:00
Darien Hager
b456cffa2d
Move final cascade-persist-checking so that it covers not just normal flushes, but also flushes where specific entities are singled out.
2017-08-21 09:08:31 +02:00
Darien Hager
17b996da8c
Speculative fix: Defer any errors for missing cascade-persist until object graph has been better-explored
2017-08-21 09:08:31 +02:00
Darien Hager
92dc39bfb9
Add extra assertions to test to ensure that flush actually succeeded in saving all items
2017-08-21 09:08:31 +02:00
Darien Hager
997000352a
Add another test to demonstrate the bug doesn't appear if everything is flushed at once.
2017-08-21 09:08:31 +02:00
Darien Hager
6f8a80be79
Move failing unit test into ticket-specific case
2017-08-21 09:08:31 +02:00
Darien Hager
c4465abaa0
Initial failing test-case to demonstrate cascade-persist problem.
2017-08-21 09:08:12 +02:00
Marco Pivetta
ddccd42bb1
Merge pull request #6636 from Kwadz/annot-ref-update
...
Mention the nullable default value for @column
2017-08-20 08:17:41 +02:00
Richard
9eaf23a5e0
Mention the nullable default value for @column
...
Related to #6632
2017-08-20 05:57:00 +02:00
Marco Pivetta
a30d8d85ea
Merge branch 'fix/#6303-#6304-check-for-null-discriminator-before-hydrating-inheritance-rows'
...
Close #6303
Close #6304
ge aborts
2017-08-19 18:37:04 +02:00
Marco Pivetta
44f2e22f14
#6303 #6304 documenting why collisions in field name hydration in STI/JTI require additional information and checks in the hydration process
2017-08-19 18:30:33 +02:00
Marco Pivetta
4cbcdb761a
#6303 #6304 documenting that the discriminator map order is extremely important for this test
2017-08-19 18:25:44 +02:00
Marco Pivetta
b66643d52e
#6303 #6304 removing useless union type usage
2017-08-19 17:49:14 +02:00
Marco Pivetta
42d9162bd5
#6303 #6304 re-enabling disabled test code data
2017-08-19 17:47:12 +02:00
Marco Pivetta
8af68614fc
#6303 #6304 correcting type mapping. For simple_array, [] == null (which is bullshit), so we use array here
2017-08-19 17:45:26 +02:00
Marco Pivetta
764ab59882
#6303 #6304 making unnecessary visible fields private
2017-08-19 17:06:27 +02:00
Marco Pivetta
468496be1a
#6303 #6304 using strict types in the tests
2017-08-19 17:05:44 +02:00
Marco Pivetta
e18fb6607d
#6303 #6304 removing duplicate test details
2017-08-19 17:04:26 +02:00
Marco Pivetta
2ab363ab82
#6303 #6304 adding void hints where applicable
2017-08-19 16:53:41 +02:00
Marco Pivetta
0882b10213
#6303 #6304 simplified tests, removing references to contract naming
2017-08-19 16:51:31 +02:00
Marco Pivetta
328467c226
#6303 #6304 simplified tests, removing references to contract naming
2017-08-19 16:48:50 +02:00
Marco Pivetta
f6ce69fe29
#6303 #6304 minor CS fixes in the test code - alignment/formatting
2017-08-19 16:37:24 +02:00
Marco Pivetta
aaad25a061
#6303 #6304 reverting changes to the OrmFunctionalTestCase
2017-08-19 16:25:20 +02:00
Marco Pivetta
c503b81421
#6303 #6304 removing += operator usage on arrays (scary\!), CS (alignment)
2017-08-19 16:02:30 +02:00
Marco Pivetta
7e7921e32f
#6303 #6304 documenting why the loose comparison is required
2017-08-19 15:58:50 +02:00
fullbl
8cc29e84a0
Update AbstractHydrator.php
...
revert strict comparison in hydration (fails on some dates)
2017-08-19 15:56:59 +02:00
Full
db9c12f1af
comparison on discriminator value with !==
2017-08-19 15:56:59 +02:00
fullbl
82db643b4f
clarified what's the problem in a comment
2017-08-19 15:56:59 +02:00
Full
4c7286f57b
removed trailing spaces
2017-08-19 15:56:59 +02:00
Full
0072054020
moved all test models into test class
2017-08-19 15:56:59 +02:00
Full
0b8e468f06
fix wrong pharenthesis
2017-08-19 15:56:59 +02:00
Full
bf06b7dbbc
check if array is set before assigning
2017-08-19 15:56:59 +02:00
Full
ad3b9de4b8
use dataMap also in first test function
2017-08-19 15:56:59 +02:00
Full
6d40859228
added tests on empty values
2017-08-19 15:56:59 +02:00
Full
aac523d155
tests with custom inheritance tree
2017-08-19 15:56:59 +02:00
Marco Pivetta
671fd50725
Merge pull request #6572 from bitwombat/doc_changes
...
Add additional detail and clarifications on SELECT
2017-08-18 21:45:17 +02:00
Marco Pivetta
1a0bb82e1d
Merge pull request #6392 from Jean85/pr_1441_rebased
...
Correct DQL `INSTANCE OF` to filter all possible child classes
2017-08-18 21:35:54 +02:00
Marco Pivetta
a426808a16
Merge branch 'fix/#6633-#3788-avoid-xml-external-entity-loading-errors-in-xml-mapping-driver'
...
Close #6633
Close #3788
2017-08-18 21:12:37 +02:00
Marco Pivetta
492fb50744
#6633 #3788 documenting why simplexml_load_file() was not used
2017-08-18 21:08:14 +02:00
Alessandro Lai
c799c6da8b
Add new functional test to check usage of INSTANCEOF with multiple parameters
2017-08-18 14:49:56 +02:00
Aljosha Papsch
eb762dea23
XmlDriver: Avoid PHP bug #62577 by avoiding simplexml_load_file.
...
Doctrine is affected by PHP bug #62577 . simplexml_load_file is not
able to load files if libxml_disable_entity_loader(true) has been
called. simplexml_load_file fails with the message:
I/O warning : failed to load external entity "/my/mappings/my_entity.dcm.xml"
in /path-to/lib/Doctrine/ORM/Mapping/Driver/XmlDriver.php on line 711
This error occurs even if there are no external entities in the XML file.
Waiting for the PHP bug to be resolved is infeasible, because it is
unresolved since years. Therefore Doctrine needs to circumvent the bug
by replacing simplexml_load_file with simplexml_load_string while getting
the file contents itself. simplexml_load_string is not affected by the
PHP bug.
2017-08-18 14:23:43 +02:00
Alessandro Lai
19bc4991ae
Add more CS fixes
2017-08-18 12:35:51 +02:00
Alessandro Lai
9864a5a9b9
Add unit test for HierarchyDiscriminatorResolverTest
2017-08-18 12:11:09 +02:00
Alessandro Lai
5224a89549
Apply various and CS fixes as per review
2017-08-18 11:02:28 +02:00
Alessandro Lai
d4db126bb0
Remove code duplication of the getAllDiscriminators method
2017-08-18 10:17:52 +02:00
Marco Pivetta
60e29b40a0
Merge branch 'fix/#5579-fix-performance-of-single-entity-flush-with-notify-tracking-policy'
...
Close #5579
2017-08-18 09:30:43 +02:00
Marco Pivetta
496c22db0e
#5579 completely removing a changeset when cleaning up
2017-08-18 09:27:47 +02:00
Marco Pivetta
1bf8465f43
#5579 correcting assertion static/instance method usage
2017-08-18 09:25:47 +02:00
Marco Pivetta
ff15a2bc79
#5579 correcting visibility of clearEntityChangeSet, which should be reverted to public
2017-08-18 09:23:28 +02:00
Marco Pivetta
9d7be0f927
#5579 s/clear/cleanup
2017-08-18 09:22:23 +02:00
Marco Pivetta
2921f068b7
#5579 cleaning up postCommitClear implementation
2017-08-18 09:21:53 +02:00
Marco Pivetta
9707701d10
#5579 isolating multi-entity-commit and single-entity-commit scenarios for the tracking policy changeset clearing
2017-08-18 09:15:48 +02:00
Marco Pivetta
df1577db0c
#5579 cleaning up test case, adding assertions critical to the understanding of the code
2017-08-18 09:13:56 +02:00
xhuberty
866a424963
Fix issue when using notify tracking policy with multiple flush on entity
2017-08-18 09:07:40 +02:00
Greg Bell
74c83f3cec
Fix format and content as-per discussion in PR
2017-08-18 15:20:17 +10:00
Marco Pivetta
5770459bfc
#6441 moving expected exception annotations into explicit method calls
2017-08-18 04:44:17 +02:00
Marco Pivetta
94640aca88
Merge pull request #6441 from sensorario/remove-loosely-comparison
...
Verify that the `fileLockRegionDirectory` passed to the `DefaultCacheFactory` cannot be empty
2017-08-18 04:38:20 +02:00
Marco Pivetta
fda770700a
Merge pull request #6579 from Nek-/patch-1
...
Add string type as possible parameter for between
2017-08-18 04:33:04 +02:00
Marco Pivetta
da109c36b7
Merge pull request #6630 from doctrine/fix/remove-reliance-on-yaml-deprecated-constants
...
Remove reliance on Symfony\Component\Yaml deprecated constants
2017-08-16 20:52:18 +02:00
Marco Pivetta
40515472c1
Bumping ORM YAML dependency to 3.4+, explicitly forbidding compatibility with older YAML component versions
2017-08-16 20:21:26 +02:00
Marco Pivetta
bb994b9e70
Removing reference to deprecated YAML component constant that is ignored after symfony 3.4
2017-08-16 20:20:22 +02:00
Marco Pivetta
76e2155fb3
Merge branch 'feature/#6593-#5864-export-metadata-should-contain-entity-listeners'
...
Close #6593
Close #5864
ge aborts
2017-08-16 19:58:23 +02:00
Marco Pivetta
894490c2a0
#6593 #5864 removing incorrect null return value in API marked as string
2017-08-16 19:57:26 +02:00
Marco Pivetta
e1acba3ae4
#6593 #5864 reverted all public/protected API parameter and return type changes
...
That's still to be considered a BC break, since child classes are broken if incompatible.
Sorry @tPl0ch :-(
2017-08-16 19:53:32 +02:00
Marco Pivetta
9005c5afdd
Merge branch 'fix/#6626-skip-proxy-generation-for-embeddable-classes'
...
Close #6626
Close #6625
2017-08-16 15:23:46 +02:00
Marco Pivetta
71218b66b9
#6626 #6625 minor CS fixes (removed useless assignments)
2017-08-16 15:23:20 +02:00
Issei.M
0bc91f8733
Replace double quote with single quote
2017-08-16 15:23:20 +02:00
Issei.M
de6d932e8c
Fix CS / Add annotation
2017-08-16 15:23:20 +02:00
Issei.M
9e837dc53c
Skip embeddable classes proxy generation
2017-08-16 15:23:20 +02:00
Marco Pivetta
57a9509dec
Merge branch 'fix/#6623-#1515-ensure-abstracthydrator-hydrateall-cleans-up-on-unit-of-work-clear'
...
Close #6623
2017-08-16 15:10:38 +02:00
Marco Pivetta
ff3c89d8b1
#6623 minor code cleanups (removing useless assignments, array callback syntax)
2017-08-16 15:10:27 +02:00
Marco Pivetta
7024926f10
#6623 splitting test scenario into two bits
2017-08-16 15:07:48 +02:00
Thomas Ploch
e4006e533c
[FX] Use single quotes for XML root in XmlExporter
2017-08-16 12:26:33 +02:00
Thomas Ploch
b1e091b0e1
[FX] Looking up PHP internal functions from the root namespace is faster
2017-08-16 12:25:31 +02:00
Thomas Ploch
599865528e
[CS] Remove obsolete doc blocks #2
2017-08-16 12:24:37 +02:00
Thomas Ploch
fe88422e68
[CS] Remove obsolete doc blocks
2017-08-16 12:24:00 +02:00
Thomas Ploch
741819f060
Revert "Minor coding style fixes and more docblock removal"
...
This reverts commit ec3eed68ca .
2017-08-15 10:28:43 +02:00
Thomas Ploch
ec3eed68ca
Minor coding style fixes and more docblock removal
2017-08-15 10:17:20 +02:00
Thomas Ploch
b7ae5b4afb
Entity listeners are now processed by exporters
...
The current implementation of the exporters are not taking the entity
listeners into account. I have added test cases for most of the edge
cases I could think of and implemented the Exporter handling.
This PR originates from https://github.com/doctrine/doctrine2/pull/5864 ,
I was overwhelmed by the amount of conflicts I had to resolve so I
started anew on a clean master HEAD.
Squashed commits:
- Code review aftermath
- Add even more return type declarations
- Added `return null` to methods declared with nullable return types
- Removed unneeded docblocks when types are self-explanatory
2017-08-15 10:08:50 +02:00
Nikolas Tsiongas
f0ed4e87b5
fix AbstractHydrator addEventListener on hydrateAll()
...
# Conflicts:
# tests/Doctrine/Tests/ORM/Functional/Ticket/DDC3146Test.php
2017-08-14 00:45:50 +02:00
Marco Pivetta
a0c0d3bf2a
Revert "Merge branch 'fix/#6499-#6533-fix-commit-order-calculation-consider-all-join-column-fields'"
...
This reverts commit 2a58645cb5 , reversing
changes made to 6d428c90e2 .
2017-08-11 22:29:45 +02:00
Marco Pivetta
2a58645cb5
Merge branch 'fix/#6499-#6533-fix-commit-order-calculation-consider-all-join-column-fields'
...
Close #6499
Close #6533
2017-08-11 22:17:02 +02:00
Marco Pivetta
1ede3c514f
#6499 #6533 simplifying nullable column check - null coalesce operator makes it *SOMEWHAT* more readable (no miracles)
2017-08-11 22:13:20 +02:00
Marco Pivetta
166c5816b6
#6499 #6533 calibrating test so that the association is populated after persistence in some edge cases
2017-08-11 22:10:02 +02:00
Marco Pivetta
25829ea450
#6499 #6533 simplifying test scenario to the bone, adding description of what happened at persistence-level
2017-08-11 22:05:00 +02:00
Marco Pivetta
ebd521c56e
#6499 #6533 minor CS fixes in the test
2017-08-11 21:55:02 +02:00
Marco Pivetta
b352cd3e22
#6499 #6533 minor CS fixes in the test
2017-08-11 21:54:30 +02:00
Gabe van der Weijde
da3cd04993
-- Transformed into a minimal example.
...
-- Processed Ocramius' feedback.
2017-08-11 21:51:17 +02:00
Gabe van der Weijde
db2530d6fd
-- Proposed fix due to logic error.
2017-08-11 21:51:17 +02:00
Gabe van der Weijde
16a14f2238
-- Created test for validation issue #6499 .
2017-08-11 21:51:17 +02:00
Marco Pivetta
6d428c90e2
Merge branch 'fix/#6464-#6475-correct-SQL-generated-with-JTI-and-WITH-condition'
...
Close #6464
Close #6475
2017-08-11 21:45:34 +02:00
Marco Pivetta
9ad91ddc1c
#6464 #6475 using PHP 7.1 void and string return hints where available
2017-08-11 21:45:23 +02:00
Marco Pivetta
91a5091612
#6464 #6475 cleaning up test - removed invalid fetch join, CS
2017-08-11 21:39:13 +02:00
Stefan Siegl
025ed1147b
#6464 code review updates
2017-08-11 21:36:33 +02:00
Stefan Siegl
99fdbf550d
generate nested join sql for CTIs, closes #6464
2017-08-11 21:36:33 +02:00
Stefan Siegl
55882ca7a6
#6464 add test
2017-08-11 21:36:33 +02:00
Marco Pivetta
633c8461c8
Merge branch 'fix/#6614-clean-modified-collection-causing-double-dirty-object-persistence'
...
Close #6613
Close #6614
Close #6616
2017-08-11 21:29:16 +02:00
Marco Pivetta
352b3ba6f6
#6613 #6614 #6616 adding void return type to newly introduced test methods
2017-08-11 21:28:18 +02:00
Marco Pivetta
c2dd274c42
#6613 #6614 #6616 adding void return type
2017-08-11 21:27:09 +02:00
Marco Pivetta
004ac51869
#6613 #6614 #6616 minor performance optimisations around the new restoreNewObjectsInDirtyCollection implementation
2017-08-11 21:14:05 +02:00
Marco Pivetta
3579997531
#6613 #6614 #6616 removing DDC6613 test, which was fully ported to unit tests
2017-08-11 21:11:31 +02:00
Marco Pivetta
a2ca6bbfaf
#6613 #6614 #6616 ensuring that the collection is marked as non-dirty if all new items are contained in the initialized ones
2017-08-11 21:09:34 +02:00
Andreas Braun
1174ec6e8a
Add failing test for dirty flag
2017-08-11 20:39:03 +02:00
Marco Pivetta
b064fe3d86
#6613 #6614 #6616 removing repeated PersistentCollectionTest chunks of code
2017-08-11 19:08:24 +02:00
Marco Pivetta
93c4064679
#6613 #6614 #6616 initializing a dirty collection that has new items that are also coming from initialization data de-duplicates new and persisted items
2017-08-11 19:02:39 +02:00
Marco Pivetta
04a5b122b0
#6613 #6614 #6616 moved integration test basics to a unit test that verifies basic dirty collection initialization semantics
2017-08-11 18:58:05 +02:00
Marco Pivetta
345cf1acf8
#6613 #6614 correcting broken test that isn't using objects against a PersistentCollection
2017-08-11 15:15:57 +02:00
Marco Pivetta
031e79e726
#6613 #6614 correcting broken test that isn't using objects against a PersistentCollection
2017-08-11 15:14:42 +02:00
Marco Pivetta
d44e6e1a9e
#6613 #6614 ensuring that only newly added items that weren't loaded are restored in the dirty state of the collection
2017-08-11 15:13:39 +02:00
Marco Pivetta
1fc7f81741
#6613 #6614 after initialization, the collection should be dirty anyway
2017-08-11 14:47:51 +02:00
Marco Pivetta
5e2257db04
#6613 #6614 adding assertions about collection initialization and dirty status
2017-08-11 14:46:11 +02:00
Marco Pivetta
d2c9b22397
#6613 #6614 removing IDE-generated header
2017-08-11 14:44:28 +02:00
Marco Pivetta
8c4b5a4b71
#6613 #6614 removing phone/user specifics, using ORM naming for associations
2017-08-11 14:44:04 +02:00
Marco Pivetta
80f12ed490
#6613 #6614 correcting column mapping (was integer, should be string), segregating phone creation away
2017-08-11 14:41:32 +02:00
Marco Pivetta
a4e547b691
#6613 #6614 remove superfluous mappings
2017-08-11 14:34:35 +02:00
Marco Pivetta
eca1d6b3ea
#6613 #6614 rewrote test logic to be less magic-constant-dependent
2017-08-11 14:27:34 +02:00
Marco Pivetta
c195064ba4
#6613 #6614 CS - applying @group annotation to the test
2017-08-11 14:23:21 +02:00
Marco Pivetta
625f792290
#6613 #6614 removing dedicated DDC6613 model directory
2017-08-11 14:22:31 +02:00
Marco Pivetta
112a402016
#6613 #6614 smashing entity definitions into the test
2017-08-11 14:21:56 +02:00
Marco Pivetta
0a1a84163e
#6613 #6614 better test specification - removing useless assertions
2017-08-11 14:20:07 +02:00
Marco Pivetta
594e60d3f7
#6613 #6614 simplifying entity definition - using auto-assigned string identifiers to reduce moving parts
2017-08-11 14:19:01 +02:00
Uladzimir Struts
874d60d8c7
It added the unit test #6613
2017-08-11 13:46:21 +03:00
Marco Pivetta
bbe005837e
Merge pull request #6607 from lcobucci/be-strict-with-risky-tests
...
Be strict with risky tests
2017-08-06 14:40:16 +02:00
Luís Cobucci
b960170fe1
Move test to the right place and add assertions
...
That test was removed from "performance" group but we forgot to move it
to the correct namespace.
It was also not doing any assertion, which is quite bad.
More info:
- https://github.com/doctrine/doctrine2/issues/3333
2017-08-06 12:51:58 +02:00
Luís Cobucci
27300bf4af
Make PHPUnit strict about risky tests
2017-08-06 12:51:16 +02:00
Luís Cobucci
aa13e49fdf
Merge pull request #6606 from lcobucci/add-exception-msg
...
Add message to NonUniqueResultException
2017-08-06 12:28:58 +02:00
Jean Carlo Machado
c2167664fc
add test of NonUniqueResultException message presence
2017-08-06 12:08:57 +02:00
Alfredo Costa
8952176c73
Add message to NonUniqueResultException
2017-08-06 12:07:47 +02:00
Marco Pivetta
2b8acb9907
Merge pull request #6601 from martin-georgiev/master
...
Fix double spacing in "cascade persist missing" exception message
2017-08-03 21:36:58 +02:00
Martin Georgiev
30088fe529
Fix double spacing in exception's message
2017-08-03 11:52:06 +01:00
Marco Pivetta
6744b48bc2
Merge pull request #6598 from mikeSimonson/xml-dtd-improvements2
...
More refinement of the xml dtd
2017-08-02 23:30:52 +02:00
mike
a54a258866
More refinement of the xml dtd
2017-08-02 22:58:05 +02:00
Marco Pivetta
97914c0f3e
Merge pull request #6588 from reypm/master
...
Updating docs to support for APCu as a cache driver
2017-07-31 17:00:36 +02:00
reypm
40ee7af9c8
Fixing issue in APC driver
2017-07-30 15:31:42 -04:00
reypm
0c30bab776
Adding extra tilde and updating APC references to APCu (APC is deprecated as per http://php.net/manual/en/intro.apc.php )
2017-07-30 14:40:19 -04:00
reypm
5d8dc1757f
Updating docs to support for APCu as a cache driver
2017-07-30 12:51:39 -04:00
Marco Pivetta
8149a1dd83
Merge pull request #6581 from Majkl578/travis-stages
...
Travis enhancements: Use Build Stages, added PHP 7.2
2017-07-25 04:44:41 +02:00
Michael Moravec
dbb0cdea51
Travis enhancements: Use Build Stages, added PHP 7.2
2017-07-25 03:54:04 +02:00
Maxime Veber
03d33ec900
Add string type as possible parameter for between
...
People may want to enter a date, or simply the parameter name. Linter may report an error while it's a good usage.
2017-07-24 14:23:16 +02:00
Luís Cobucci
84079572f7
Merge pull request #6575 from lcobucci/improvement/move-performance-tests-to-phpbench
...
Move performance tests to phpbench
2017-07-23 10:46:26 +02:00
Luís Cobucci
e07c90df44
Add PHPBench to Travis-CI matrix
...
Also separating the execution of the tests from other tools.
2017-07-23 10:30:19 +02:00
Marco Pivetta
cfa9d787fe
Removing old ProxyPerformanceTest
2017-07-23 10:16:51 +02:00
Marco Pivetta
f1bc1bbf12
Mocks required by the proxy performance benchmarks
2017-07-23 10:16:50 +02:00
Marco Pivetta
d8140d700a
Benchmarking proxy initialization logic
2017-07-23 10:16:49 +02:00
Marco Pivetta
d658364b59
Benchmarking instantiation of proxies
2017-07-23 10:16:48 +02:00
Marco Pivetta
77ce354f18
Removing old UnitOfWorkPerformanceTest
2017-07-23 10:16:47 +02:00
Marco Pivetta
b1bbad3b15
Unit of work changeset computation test
2017-07-23 10:16:46 +02:00
Marco Pivetta
7515dd20f2
Removing old PersisterPerformanceTest
2017-07-23 10:16:45 +02:00
Marco Pivetta
8ec186f095
Removing old inheritance persister test
2017-07-23 10:16:44 +02:00
Marco Pivetta
52402917a0
Benchmarking hydration of a STI
2017-07-23 10:16:43 +02:00
Marco Pivetta
c5a636ebfb
Corrected benchmark name: benchmark affects a STI
2017-07-23 10:16:42 +02:00
Marco Pivetta
2692435705
Benchmarking insert operations for a JTI
2017-07-23 10:16:41 +02:00
Marco Pivetta
29f55eaef9
Removing instantiation overhead from benchmark
2017-07-23 10:16:40 +02:00
Marco Pivetta
5401cb5329
Removed old InsertPerformanceTest (moved to benchmark)
2017-07-23 10:16:39 +02:00
Marco Pivetta
d51235f200
Removing useless imports
2017-07-23 10:16:37 +02:00
Marco Pivetta
cbb0c1bd04
Corrected class name - needs to end with Bench
2017-07-23 10:16:36 +02:00
Marco Pivetta
ef0edc8929
Benchmarking simple insert operations (batched)
2017-07-23 10:16:35 +02:00
Marco Pivetta
fd27b22ad1
Removing old HydrationPerformanceTest
2017-07-23 10:16:34 +02:00
Marco Pivetta
93dc028194
Benchmarking full object hydration with fetch joins and mixed values
2017-07-23 10:16:33 +02:00
Marco Pivetta
608b3ed6a4
Benchmarking mixed fetch-join with partial hydration
2017-07-23 10:16:32 +02:00
Marco Pivetta
131aac531a
Removing unused $entityManager variable
2017-07-23 10:16:31 +02:00
Marco Pivetta
1e16cb83f8
Full object hydration benchmark
2017-07-23 10:16:30 +02:00
Marco Pivetta
97735cdb68
Partial hydration bench
2017-07-23 10:16:29 +02:00
Marco Pivetta
f23359c1f3
Renaming bench methods, for clarity
2017-07-23 10:16:28 +02:00
Marco Pivetta
0fdcc71887
CS (alignment)
2017-07-23 10:16:27 +02:00
Marco Pivetta
8774b02c88
Testing mixed array hydration (with scalars and fetch-joined results)
2017-07-23 10:16:26 +02:00
Marco Pivetta
d8ddc47f83
Array hydration benchmark
2017-07-23 10:16:25 +02:00
Marco Pivetta
88ea1d33fa
Full hydration + query benchmark
2017-07-23 10:16:24 +02:00
Marco Pivetta
f95c81b210
Simple array hydration benchmark
2017-07-23 10:16:23 +02:00
Marco Pivetta
94adf97550
Factory used to create a new entity manager
2017-07-23 10:16:22 +02:00
Marco Pivetta
37cb2c0722
Benchmark autoloading definitions
2017-07-23 10:16:20 +02:00
Marco Pivetta
25669c51b6
PHPBench base config
2017-07-23 10:16:17 +02:00
Marco Pivetta
c8a41598c9
Not a performance test
2017-07-23 10:16:04 +02:00
Luís Cobucci
9826d9c29a
Merge pull request #6485 from elt/versionWithCustomTypePrimaryKey
...
#5804 Versioning doesn't work with a custom type primary key
2017-07-22 23:29:12 +02:00
Luís Cobucci
6bf9f6f72f
Remove unnecessary annotation from test
2017-07-22 22:41:07 +02:00
Luís Cobucci
eba8fec1fb
Move identifier types extraction to a method
2017-07-22 22:39:47 +02:00
Alessandro Frangioni
60a2628f9d
Iteration simplified
2017-07-22 22:26:31 +02:00
Alessandro Frangioni
82c87081b4
Changed SQL declaration for custom type
2017-07-22 22:26:31 +02:00
Alessandro Frangioni
f6907b9503
Applied patches as for #6496
2017-07-22 22:26:31 +02:00
Alessandro Frangioni
4ef0a238bf
Inferring id's field types
2017-07-22 22:26:31 +02:00
Alessandro Frangioni
af3591fbca
Fixes #5804
2017-07-22 22:26:31 +02:00
Marco Pivetta
1d8c7f9bac
Merge pull request #6556 from lcobucci/fix/command-list
...
Update ConsoleRunner's command list
2017-07-22 22:19:57 +02:00
Luís Cobucci
5109322f7d
Make explicit the design decisions of ConsoleRunner
2017-07-22 21:56:59 +02:00
Luís Cobucci
d4b94e097a
Ensure that ConsoleRunner has the right command list
2017-07-22 21:56:56 +02:00
Luís Cobucci
2b824ea9df
Update ConsoleRunner command list
...
Adding L2C commands and DBAL reserved words command.
2017-07-22 21:56:42 +02:00
Marco Pivetta
2fb3cfdba2
Merge pull request #6143 from chihiro-adachi/patch-1
...
fixed #5622 - mysql 5.7 ONLY_FULL_GROUP_BY
2017-07-22 21:41:51 +02:00
Luís Cobucci
5389ad7261
Make LimitSubqueryOutputWalker a bit more readable
...
Also simplifying the REGEX to remove the ORDER BY type (ASC/DESC) with a
substr() since OrderByItem#type is always defined.
2017-07-22 20:34:18 +02:00
Luís Cobucci
3d5acd607b
Bump up doctrine/instantiator version
2017-07-22 19:30:47 +02:00
Luís Cobucci
4a736f48f8
Add MySQL 5.7 to Travis configuration
...
Following the same setup of doctrine/dbal#2764 .
2017-07-22 19:28:29 +02:00
chihiro-adachi
60601a9323
fix query and tests
2017-07-22 19:28:28 +02:00
Martin Kirilov
854ff17ab9
Should fix MySQL 5.7 issues caused by ONLY_FULL_GROUP_BY
...
Should fix MySQL 5.7 issues caused by ONLY_FULL_GROUP_BY
2017-07-22 19:28:28 +02:00
Greg Bell
624af3df22
Add note clarifying WHERE, WITH and HAVING
...
- A per Ocramius' explanation in #6563
2017-07-22 17:40:56 +10:00
Greg Bell
80573038ed
Add additional detail and clarifications on SELECT
...
- Also the effect of WHERE on result array.
2017-07-22 17:28:48 +10:00
Marco Pivetta
668ad4cc29
Merge pull request #6550 from alcaeus/fix-persistent-collection-return
...
Fix return value of removeElement for extra lazy collections
2017-07-22 09:26:15 +02:00
Marco Pivetta
fb3ec7648d
Merge pull request #6569 from stoccc/patch-1
...
Added a test case for postLoad on fetch-joined entities - fetch joined entities should have lifecycle events fired as well
2017-07-21 18:30:38 +02:00
Luís Cobucci
39572a8b6e
Merge pull request #6570 from stloyd/patch-1
...
Prevent Travis-CI failure if xdebug is not available
2017-07-21 11:19:30 +02:00
Joseph Bielawski
247fb6ef0d
Prevent Travis-CI failure if xdebug is not available
2017-07-21 11:03:05 +02:00
stoccc
17892bb327
added named parameter and LifecycleCallbackCascader::getId()
2017-07-21 10:47:32 +02:00
stoccc
c47cf1de34
Added a test case for postLoad on fetch-joined entities
...
see https://github.com/doctrine/doctrine2/issues/6568
2017-07-21 10:33:28 +02:00
Marco Pivetta
63519be69c
Merge pull request #6562 from bitwombat/doc_changes
...
Make minor English fixes.
2017-07-21 02:15:19 +02:00
Greg Bell
34c25a3ee3
Make minor English fixes.
...
- Remove the apparently dangling text at the bottom of
reference/query-builder.rst
2017-07-19 11:14:46 +10:00
Andreas Braun
45e1817f6f
Add test for removing element not in collection
2017-07-13 16:39:06 +02:00
Andreas Braun
260cc6e3e0
Fix return of removeElement on collections
...
Fixes #5745
2017-07-13 08:16:00 +02:00
Marco Pivetta
e3ecec36ad
Merge pull request #6545 from Landerstraeten/patch-1
...
Fix newline in annotation example in documentation
2017-07-12 08:23:18 +02:00
Lander Vanderstraeten
c678577f8f
Fix newline
2017-07-11 13:18:52 +02:00
Luís Cobucci
c32ba8f5d1
Merge pull request #6535 from Majkl578/phpstan
...
[master] PHPStan integration - levels 0 + 1
2017-07-07 10:36:08 +02:00
Michael Moravec
74c48c201d
Push PHPStan to level 1
2017-06-30 00:27:50 +02:00
Ondrej Mirtes
1231861b09
Initial PHPStan integration (level 0)
2017-06-30 00:27:49 +02:00
Alessandro Lai
c7ef9085fb
Merge additional fix (and master changes) from taueres/fix-instance-of-subclasses
2017-06-26 09:45:44 +02:00
Sergio Santoro
e91dcf8fb4
Fix discriminator resolution when using parameters
2017-06-24 13:35:44 +02:00
Alessandro Lai
b1f7c59ed5
Adding a failing test case for parameter binding using metadata with INSTANCE OF
2017-06-24 10:58:18 +02:00
Alessandro Lai
2fd8752818
Simplify stubs used in tests
2017-06-24 10:58:18 +02:00
Alessandro Lai
d2f7514248
Put all tests classes in a single namespace
2017-06-24 10:58:18 +02:00
Alessandro Lai
167dfde00f
Apply additional fixes to the SqlWalker to fix tests
2017-06-24 10:58:18 +02:00
Alessandro Lai
5181eae8d6
Refactor a bit the SqlWalker modifications
2017-06-24 10:58:18 +02:00
Alessandro Lai
31d2d84160
Fix test
2017-06-24 10:58:18 +02:00
Alessandro Lai
bd47ec95a1
Move tests to ticket namespace (and rename them)
2017-06-24 10:58:18 +02:00
Alessandro Lai
0e88f1b654
Split SqlWalker::walkInstanceOfExpression method
2017-06-24 10:58:18 +02:00
Alessandro Lai
aa233f8e57
Fix small CS issues as per review
2017-06-24 10:58:18 +02:00
Alessandro Lai
04acde667a
Fix as per review
2017-06-24 10:58:18 +02:00
Sergio Santoro
7d98135084
[QUERY] "INSTANCE OF" now behaves correctly with subclasses
...
There was a bug in the "INSTANCE OF" operator as described in
https://groups.google.com/forum/#!topic/doctrine-user/B8raq8CNMgg
"INSTANCE OF" was not taking into account subclasses.
It was merely translating the class to its discriminator.
This is not correct since the class can have subtypes and those
are, indeed, still instance of the superclass.
Also, classes may not have a discriminator (e.g. abstract classes).
This commit also provides useful tests to avoid regression.
2017-06-24 10:58:18 +02:00
Marco Pivetta
388afb46d0
Merge pull request #6245 from lcobucci/l2c-use-getMultiple
...
Use `getMultiple()` to fetch associations as well in L2 cache fetch operations
2017-06-24 09:17:55 +02:00
Marco Pivetta
5d98247178
Merge pull request #5756 from whyte624/master
...
s/__tostring()/__toString() in Expr\OrderBy
2017-06-24 04:12:55 +02:00
Marco Pivetta
b66dd0b6fa
Merge pull request #5787 from iBet7o/patch-doc
...
Fix bug: orderBy documentation
2017-06-24 04:05:41 +02:00
Marco Pivetta
807f1422a3
Merge branch 'fix/#1515-clean-hydrator-listeners-on-hydration-end'
...
Close #1515
2017-06-24 03:41:00 +02:00
Marco Pivetta
995054d884
#1515 dropping DDC-3146 test, which was moved to the hydration tests
2017-06-24 03:40:46 +02:00
Marco Pivetta
0b5d877d5f
Migrating #1515 tests to AbstractHydratorTest
2017-06-24 03:40:12 +02:00
Marco Pivetta
067e01e0d7
#1515 cleaning up test case, since the PHPUnit 5.4+ API is much nicer
2017-06-24 03:32:58 +02:00
Marco Pivetta
aba486ea2d
#1515 removing redundant assignment, short array notation
2017-06-24 03:27:12 +02:00
Emiel Nijpels
9eb2d6139e
DDC-3146 remove event listener from event listener in abstract hydrator in cleanup function
2017-06-24 03:22:12 +02:00
Marco Pivetta
41bcdb3268
Merge pull request #6494 from astepin/gh-6356
...
Add failing test for #6314 and PR #6356
2017-06-23 12:54:29 +02:00
Marco Pivetta
95b30c1d40
Merge pull request #6515 from lcobucci/use-updated-environment
...
Use the Travis' Trusty build environment
2017-06-23 11:33:15 +02:00
Luís Cobucci
21ad7a1913
Create schema based on config file (on MySQL & MariaDB)
2017-06-23 11:21:36 +02:00
Alessandro Lai
d4cdc6e1fe
Adding a failing test case for parameter binding using metadata with INSTANCE OF
2017-06-22 09:50:53 +02:00
Marco Pivetta
af1ea1ae1d
Merge pull request #5623 from Jean85/patch-1
...
[DOCUMENTATION] Update tests README
2017-06-22 08:03:42 +02:00
Marco Pivetta
379acd9dfd
Merge pull request #5734 from amerryma/master
...
Update tools.rst
2017-06-22 08:02:40 +02:00
Luís Cobucci
e8332a45de
Use the Travis' Trusty build environment
...
To see if that solves the XML validation issues (since the issues are
possibly happening due to old libxml versions).
2017-06-22 08:01:13 +02:00
Luís Cobucci
3df6b7316b
Merge pull request #6243 from enumag/patch-3
...
Fix CountOutputWalker for queries with GROUP BY
2017-06-22 07:16:38 +02:00
Jáchym Toušek
fc609271e0
Fix CountOutputWalker for queries with GROUP BY
2017-06-22 07:09:20 +02:00
Alessandro Lai
ba69cc8f7a
Simplify stubs used in tests
2017-06-21 13:25:31 +02:00
Alessandro Lai
8b9c29738d
Put all tests classes in a single namespace
2017-06-21 10:26:31 +02:00
Alessandro Lai
11c54b7715
Apply additional fixes to the SqlWalker to fix tests
2017-06-21 10:11:31 +02:00
Alessandro Lai
30256e7a08
Refactor a bit the SqlWalker modifications
2017-06-21 09:34:16 +02:00
Marco Pivetta
b925cce6c4
Merge branch 'docs/#5677-upgrade-getting-started-documentation'
...
Close #5677
2017-06-21 08:29:31 +02:00
NateC
b446afd937
Updating the Getting Started guide's documentation
2017-06-21 08:29:20 +02:00
Marco Pivetta
9cfdf1ef81
#6325 documenting minor BC break introduced by adding a required parameter to the exception named constructor
2017-06-21 08:20:20 +02:00
Marco Pivetta
9b9128ae77
Merge branch 'improvement/#6325-improve-dql-exception-message-for-single-valued-inverse-association-path'
...
Close #6325
2017-06-21 08:16:49 +02:00
Marco Pivetta
b21cb3e2a0
#6325 adding IDE hints, type hints, replacing double quotes with single quotes
2017-06-21 08:16:24 +02:00
Tomasz Darmetko
633a442046
Add path expresion to QueryException::associationPathInverseSideNotSupported()
2017-06-21 08:12:04 +02:00
Marco Pivetta
33cee11e6f
Merge pull request #6389 from mikeSimonson/xml-dtd-improvements
...
XSD definition improvements
2017-06-21 08:08:14 +02:00
Marco Pivetta
98aa25b0ea
Merge branch 'fix/#5798-undefined-schema-tool-index'
...
Close #5798
2017-06-21 06:34:57 +02:00
Marco Pivetta
6e9c1d8a4b
#5798 adding void test method return declaration, using ::class reference over string reference
2017-06-21 06:34:45 +02:00
Sergey Fedotov
d13327eca2
Fix undefined index for discriminator column in SchemaTool
2017-06-21 06:27:15 +02:00
Marco Pivetta
fe8259a094
Merge branch 'fix/#5715-fix-metadata-filtering-in-cli-tools'
...
Close #5715
2017-06-21 06:21:52 +02:00
Marco Pivetta
01d226aff0
#5715 removed superfluous mapping information
2017-06-21 06:21:22 +02:00
Marco Pivetta
29fe76cced
#5715 short array notation
2017-06-21 06:20:30 +02:00
Marco Pivetta
2ce40a6aeb
#5715 s/CLASSNAME/class
2017-06-21 06:18:24 +02:00
Marco Pivetta
f0e403211b
#5715 adding return hints \(void\) to test methods
2017-06-21 06:17:18 +02:00
Guilliam Xavier
a9cc522e8a
Add regex tests for MetadataFilter (PR #507 )
2017-06-21 06:14:01 +02:00
Guilliam Xavier
1afa8a915d
Add more basic tests for MetadataFilter
2017-06-21 06:14:01 +02:00
Guilliam Xavier
87e9879edd
Fix MetadataFilter not testing filters after first
2017-06-21 06:14:01 +02:00
Guilliam Xavier
652358a4de
Add failing test for #5715 (unit test for MetadataFilter)
2017-06-21 06:14:01 +02:00
Marco Pivetta
07a9b10f36
Merge branch 'fix/#6168-#6167-force-nextval-selection-on-the-master-server'
...
Close #6167
Close #6168
2017-06-21 06:04:34 +02:00
Marco Pivetta
a97c2659fc
#6167 #6168 rewrote SequenceGeneratorTest for better readability and error messages
2017-06-21 06:04:06 +02:00
Marco Pivetta
462481ebbe
#6167 #6168 - better connection mock documentation/docblocks/return-types
2017-06-21 05:47:19 +02:00
Marco Pivetta
d2be4a2b48
#6167 #6168 - clarifying on the reasoning why query is used instead of fetchColumn
2017-06-21 05:44:58 +02:00
Michał Kurzeja
571115cf18
#6167 Code review updates, better readability
2017-06-21 05:42:26 +02:00
Michał Kurzeja
71b040c849
#6167 - tests - throw exception if wrong method used to get sequence nextval
2017-06-21 05:42:26 +02:00
Michał Kurzeja
edffb4d449
#6167 - fixed tests and added info why query is used in SequenceGenerator
2017-06-21 05:42:26 +02:00
Michał Kurzeja
60b6073643
Fixes #6167 - nextval issue on master-slave PostgreSQL setup
2017-06-21 05:42:26 +02:00
Marco Pivetta
1e3bf6562e
Merge branch 'feature/#6162-report-that-subqueries-are-not-allowed-in-from-and-join'
...
Close #6162
2017-06-21 05:39:01 +02:00
Marco Pivetta
3260d220e8
#6162 adding @group annotation, spacing
2017-06-21 05:38:42 +02:00
Marco Pivetta
a7dcdd8d48
Documenting thrown exception type, spacing #6162
2017-06-21 05:36:13 +02:00
SimonHeimberg
1dbc67cce1
Tests for Subqueries set expectations directly before their occurrence
2017-06-21 05:34:12 +02:00
SimonHeimberg
5b6d766961
Tests for not supported Subqueries in FROM and JOIN
2017-06-21 05:33:28 +02:00
SimonHeimberg
f5d4db7d9c
Report that FROM and JOIN do not support Subqueries
2017-06-21 05:31:25 +02:00
Marco Pivetta
7523513be5
Merge pull request #6511 from lcobucci/make-scrutinizer-more-strict
...
Define build failure conditions on scrutinizer
2017-06-20 17:34:46 +02:00
Luís Cobucci
aa9f34b600
Configure build failure conditions
...
So that contributors receive some automated feedback in case maintainers
are not fast enough.
2017-06-20 14:06:40 +02:00
Luís Cobucci
1bdc61f932
Remove tools that are not supported anymore
2017-06-20 09:43:43 +02:00
Marco Pivetta
93f617536b
Merge pull request #6501 from mpdude/patch-1
...
Clarify the impact of changing the fetch mode
2017-06-20 07:31:36 +02:00
Marco Pivetta
256091282e
Merge pull request #6500 from SamKnows/feature/override-aggregate-functions
...
Allow internal functions to be overridden.
2017-06-20 07:29:51 +02:00
Mathew Davies
747c1857d6
Make the new aggregate function definitions final.
2017-06-20 07:27:32 +02:00
Mathew Davies
05758f4564
Documented changes in UPGRADE.md
2017-06-20 07:27:30 +02:00
Mathew Davies
49e4b1004c
Update LimitSubqueryOutputWalkerTest
2017-06-20 07:27:29 +02:00
Mathew Davies
3e3751cfd9
Remove aggregate function conditional in SqlWalker.
2017-06-20 07:27:27 +02:00
Mathew Davies
966f9a84c2
phpDoc and type hint changes.
2017-06-20 07:27:26 +02:00
Mathew Davies
e4847534a4
Remove @throws in Configuration where necessary.
2017-06-20 07:27:25 +02:00
Mathew Davies
866418e40f
No longer treat aggregate functions as a special case.
2017-06-20 07:27:24 +02:00
Mathew Davies
e4ff7a35a8
Write a test case for a custom function override.
2017-06-20 07:27:22 +02:00
Mathew Davies
914c400a7d
Check for custom functions first.
2017-06-20 07:27:20 +02:00
Marco Pivetta
e80cd74c3e
Merge pull request #6507 from lcobucci/upgrade-dependencies
...
Upgrade dependencies
2017-06-20 07:18:28 +02:00
Luís Cobucci
ad5014decc
Merge pull request #6508 from magnetik/patch-1
...
[Doc] Fix links to api doc in the second level cache documentation page
2017-06-20 07:09:42 +02:00
Luís Cobucci
9fa456b9f0
Bump versions of some dependencies
2017-06-19 17:43:38 +02:00
Luís Cobucci
e123f16ec9
Require PHP 7.1
2017-06-19 17:43:37 +02:00
Luís Cobucci
99dc8aa2a9
Drop HHVM support
2017-06-19 17:43:16 +02:00
Baptiste Lafontaine
177c48107d
Fix links to api doc
2017-06-19 13:31:10 +02:00
Matthias Pigulla
8f9f41ea89
Fix typo
2017-06-15 01:03:38 +02:00
Matthias Pigulla
5a2a771173
Clarify the impact of changing the fetch mode
...
Seems to work for one-to-many as well, but with a negative performance impact.
2017-06-15 01:02:45 +02:00
Marco Pivetta
fc67b398a1
Merge pull request #6479 from lcobucci/fix-risky-tests
...
Fix all risky tests
2017-06-13 01:20:57 +03:00
Luís Cobucci
5c02e0c1e8
Remove APC dependency on tests
...
By using a shared array cache so that we can reproduce different cache
instances that shares the stored data.
2017-06-12 23:05:58 +02:00
Luís Cobucci
a9c711ad7e
Register custom types to not skip model set validation
...
Also removing an empty and unused model set.
2017-06-12 23:05:57 +02:00
Luís Cobucci
ee5f222c58
Rename data provider so that it doesn't get executed as test
2017-06-12 23:05:56 +02:00
Luís Cobucci
8dccd27b52
Add the correct assertions for tests that don't have any
2017-06-12 23:05:55 +02:00
Luís Cobucci
d8663cd9ee
Use a more appropriate assertion on some tests
2017-06-12 23:05:54 +02:00
Luís Cobucci
8796e2d938
Expect an exception instead of failing the test
...
Since that's the assertion we're actually doing.
2017-06-12 23:05:53 +02:00
Luís Cobucci
19fc91482e
Validate if optimistic locks are released properly
...
By trying to update an entry using a different connection.
2017-06-12 23:05:52 +02:00
Luís Cobucci
99df158fc8
Allow passing a connection while creating an entity manager
...
Also removing unsed arguments.
2017-06-12 23:05:51 +02:00
Luís Cobucci
1bf884970f
Increment assertion count manually
...
Which is needed to test void methods that shouldn't raise any exception
on a certain condition. If the interpreter gets to the point where the
assertion count is incremented it means that no exceptions have been
thrown and our test is successful.
Important to note that some tests were slighly refactored to simplify
things a bit.
2017-06-12 23:04:56 +02:00
Luís Cobucci
8d144daf01
Remove duplicated tests (keeping them on unit test suite only)
2017-06-12 23:04:55 +02:00
Luís Cobucci
043ca69f0b
Fix some code style issues in tests
2017-06-12 23:04:54 +02:00
Benjamin Eberlei
3dc0f471fe
Merge pull request #6481 from lcobucci/improve-build-extensions
...
Improve build extensions
2017-06-12 20:45:25 +02:00
Marco Pivetta
c0c08d92ba
Merge pull request #6493 from astepin/small-code-improvements
...
Minor fixes: typos, documentation, etc.
2017-06-11 12:14:30 +03:00
Artem Stepin
799190d5e4
- fixed columnPrefix generator for the embedded annotation
2017-06-09 22:25:19 +02:00
Artem Stepin
351b6972a4
Merge branch 'original-pr-6356' into gh-6356
2017-06-09 21:58:57 +02:00
Artem Stepin
7a63e81c94
Add failing test for gh-#6314 (gh-#6356)
2017-06-08 23:18:47 +02:00
Artem Stepin
43009682a4
minor code work:
...
- method calls with incorrect case
- removed unused imports
- typos and some other minor code smells
- documentation update (wrong return types etc. )
2017-06-08 22:04:07 +02:00
Marco Pivetta
049ad1e079
Merge pull request #6491 from SamKnows/fix/mock-implementations
...
Fix Mock Implementations.
2017-06-08 19:06:25 +02:00
Mathew Davies
b42c36f472
Update phpDoc
2017-06-08 16:43:18 +01:00
Mathew Davies
9f13557d14
Be consistent with the rest of the file.
2017-06-08 16:42:11 +01:00
Mathew Davies
633b821e18
Update StatementArrayMock to implement the right interface.
2017-06-08 16:31:59 +01:00
Mathew Davies
a59367423a
Update StatementMock to implement the right interface.
2017-06-08 16:25:57 +01:00
Mathew Davies
1559db7ac1
Update HydratorMockStatement to implement the right interface.
2017-06-08 16:25:03 +01:00
Marco Pivetta
971c400025
Merge pull request #6462 from mkosiedowski/proxy-embedded-fields-fix
...
Fix #6460 - \Doctrine\ORM\Mapping\ClassMetadataInfo::hasField should return true for embedded fields
2017-06-01 15:52:07 +02:00
Luís Cobucci
2359360149
Disable XDebug based on PHPUnit flags instead
...
Then we don't need to keep changing versions information.
2017-06-01 07:40:28 +02:00
Marco Pivetta
22ecc2d58c
Merge pull request #5938 from Ma27/feature/DDC5934-allow-fetch-override
...
#5934 - add `fetch` option to `AssociationOverride` in order to override fetch strategy for subclasses of entities
2017-05-31 20:24:57 +02:00
Maximilian Bosch
49bb345533
#5934 - #5938 - fix accidentally introduced regression with wrong target of ::class expression
2017-05-31 15:01:25 +02:00
Maximilian Bosch
fcfaa13df9
#5934 - #5938 - use ClassMetadata::class expression rather than FQCN in config drivers as of @Ocramius's review
2017-05-31 14:52:55 +02:00
Maximilian Bosch
92476b5953
#5934 - add fetch option to AssociationOverride in order to override fetch strategy for subclasses of entities
2017-05-30 18:19:48 +02:00
Marco Pivetta
205ee72e33
Merge pull request #6478 from lcobucci/fix-yaml-tests
...
Fix YAML related tests
2017-05-30 14:05:19 +02:00
Luís Cobucci
f9062d9931
Force YAML parser to convert keys to string
...
Since Symfony 3.3 implicit conversion is not enabled by default so we
need to pass that flag manually.
Related to: https://github.com/symfony/symfony/pull/21774
2017-05-30 13:53:45 +02:00
Luís Cobucci
f18e178960
Fix wrong YAML mapping
...
We had duplicated keys and that's no longer valid on symfony/yaml 3.3.
2017-05-30 12:51:51 +02:00
Luís Cobucci
2a239be45e
Merge pull request #6466 from fmagnan/patch-1
...
Update QueryBuilder.php
2017-05-23 18:44:10 +02:00
Franck Magnan
db528a44b1
Update QueryBuilder.php
...
Hello,
thank you very much for your work, it's awesome!
I found a minor error in PHPDOC for method setParameter. Argument "type" can be a string or null but can be also an int if it comes from \PDO::PARAM_*. So I've changed typehint "string" into "mixed".
2017-05-23 18:42:01 +02:00
Simone Gentili
4bf2e890fb
remove loosely comparison
2017-05-23 10:28:45 +02:00
Maciej Kosiedowski
76f0fe45af
fixes in tests
2017-05-22 15:52:19 +02:00
Maciej Kosiedowski
f304685c68
Fix #6460 - \Doctrine\ORM\Mapping\ClassMetadataInfo::hasField should return true for embedded fields
2017-05-22 14:41:06 +02:00
Marco Pivetta
6ea30f0354
Merge pull request #6456 from bitwombat/doc_changes
...
Fixes and clarifications to Association Mapping document
2017-05-21 15:17:40 +02:00
Greg Bell
00aba32c67
Resolve conflicts
2017-05-21 16:56:16 +10:00
Greg Bell
46cebfb33d
Clarify concepts, fix minor English issues.
...
- Globally change 'Shipping' to 'Shipment' - shipment is a noun and thus a clearer name for an object.
- Add definition of unidirectional to the top of the document.
- Explain inversedBy and mappedBy the first time they are used.
- Clarify some ownership and bidirectionality text.
- Minor English and punctuation fixes.
2017-05-21 16:39:06 +10:00
Greg Bell
89bf6152a6
Merge branch 'doc_changes' of https://github.com/bitwombat/doctrine2 into doc_changes
2017-05-21 14:14:52 +10:00
Greg Bell
75821e75f5
Clarify English and a few concepts
...
- Globally change 'Shipping' to 'Shipment' - shipment is a noun and thus a
clearer name for an object.
- Move definition of unidirectional from example to the top of the document.
- Explain inversedBy and mappedBy the first time they are used.
- Clarify some ownership and bidirectionality text.
- Minor English and punctuation fixes.
2017-05-21 14:14:28 +10:00
Greg Bell
7bfd172156
Clarify English and a few concepts
...
- Globally change 'Shipping' to 'Shipment' - shipment is a noun and thus a
clearer name for an object.
- Move definition of unidirectional from example to the to of the document.
- Explain inversedBy and mappedBy the first time they are used.
- Clarify some ownership and bidirectionality text.
- Minor English and punctuation fixes.
2017-05-21 14:10:38 +10:00
Marco Pivetta
ee066cc5de
Merge pull request #6451 from nicolas-grekas/sf4
...
Allow Symfony 4.0
2017-05-18 12:59:19 +02:00
Nicolas Grekas
7ce2381bdd
Allow Symfony 4.0
2017-05-18 12:57:36 +02:00
Marco Pivetta
334b7e68a7
Merge pull request #6442 from sensorario/performance-improvement
...
Compute size of loaders in the test suite beforehand, and not on each iteration
2017-05-16 13:40:17 +02:00
Marco Pivetta
95c60219d5
Merge pull request #6446 from eibt/update-docs-theme-submodule
...
Update theme submodule
2017-05-16 13:21:34 +02:00
Ivan
73770ac090
Update git submodule "docs/en/_theme"
...
- This fixes the broken image at the footer of Doctrine 2 ORM's docs
2017-05-15 14:53:23 -06:00
Simone Gentili
0a801b895e
compute size of loaders beforehand and not on each iteration
2017-05-15 07:43:15 +02:00
Luís Cobucci
e9b54de488
Merge pull request #6439 from sensorario/align-equals-signs
...
align equals signs
2017-05-14 10:21:42 +02:00
Simone Gentili
fac7e8facb
align equals signs
2017-05-13 23:05:37 +02:00
Marco Pivetta
c222c1d17a
Merge pull request #6433 from mpdude/patch-1
...
Remove dead code in the schema tool
2017-05-10 19:31:40 +02:00
Luís Cobucci
2695f5e3a5
Merge pull request #6436 from lcobucci/fix-result-set-cache-eviction
...
Pass the connections parameters for cache key generation
2017-05-10 18:07:12 +02:00
Luís Cobucci
885c431bd9
Pass the connection parameters for cache key generation
...
That argument was added to not have key collisions for different
connections.
More info: https://github.com/doctrine/dbal/pull/713
2017-05-10 17:52:38 +02:00
Matthias Pigulla
5c1908d82f
Remove dead code
...
Hopefully this does not do anything...?
2017-05-09 19:21:49 +02:00
Marco Pivetta
7bb02d0dbd
Merge pull request #6417 from lcobucci/fix-expire-result-cache
...
Fix expire result cache
2017-05-03 12:40:33 +02:00
Alessandro Lai
96bcee4fa9
Fix test
2017-05-03 11:42:51 +02:00
Alessandro Lai
21e12ef4a9
Move tests to ticket namespace (and rename them)
2017-05-03 11:06:43 +02:00
Alessandro Lai
11c84c7b20
Split SqlWalker::walkInstanceOfExpression method
2017-05-03 11:00:26 +02:00
Alessandro Lai
3219fe5316
Fix small CS issues as per review
2017-05-03 10:46:24 +02:00
Luís Cobucci
e71272e2b4
Evict result set cache if Query#expireResultCache() was called
2017-05-02 23:25:56 +02:00
bruno da silva
85a52d781e
add a not weel writend/nammed test testing Query::expireResultCache()
2017-05-02 23:25:56 +02:00
Marco Pivetta
2c1ebc4ef1
Merge pull request #6416 from lcobucci/fix-quote-on-inheritance
...
Fix quoting when using inheritance as well
2017-05-02 09:42:03 +02:00
Marco Pivetta
77ee69f1a8
Merge pull request #6367 from SirWaddles/fix-inheritance-alias
...
Fix inheritance alias
2017-05-02 09:25:18 +02:00
Timothy Clissold
0a10f347d3
Fix inheritance join alias
2017-05-02 00:17:16 +02:00
Luís Cobucci
6c0654c144
Merge pull request #6274 from Necsord/issue/5887-one-to-one-with-custom-id-object-relationship-fix
...
Fixing #5887 - lazy loading of one-to-one relationship with custom id object
2017-04-30 20:10:37 +02:00
Marcin Szulc
a360da5a7e
Fix lazy loading of 1-to-1 relationship with custom id object
...
Fixing case when lazy loading of entity in one-to-one relationship on the side without foreign key
did not return eht entity because of custom type not being detected and properly formatted before
applying to database query.
Closes https://github.com/doctrine/doctrine2/issues/5887
2017-04-30 19:53:28 +02:00
Luís Cobucci
0aef63b350
Fix quoting also when using inheritance
2017-04-30 19:36:41 +02:00
Luís Cobucci
4ebf27de35
Use "quoted" from existing data if exists
...
In order to keep that information for inheritance mapping.
2017-04-30 19:36:40 +02:00
Luís Cobucci
942bb6cb1f
Remove dead code from OrmFunctionalTestCase
2017-04-30 19:36:39 +02:00
lemartin
7c6c5d87c8
Fix quoting issues related to ticket #6402
...
Apply quoting strategy to foreign key columns of one-to-one relation so
that correct select statements are generated. And use unquoted column
names in result mapping instead of quoted ones, as consumers (namely
IdentifierFlattener) expect unquoted column names.
2017-04-30 13:51:49 +02:00
Luís Cobucci
ccaa4b8ce1
Use getMultiple() to fetch associations as well
2017-04-30 13:43:29 +02:00
Vytautas Stankus
a557c97a93
Add support for STARTS_WITH and ENDS_WITH comparison operators
2017-04-30 13:19:51 +02:00
Jarek Jakubowski
38bfcc6a7a
Fix notice in ClassMetadata when there is no ID Column defined
...
When you forget about defining the ID/PK Column, then this ugly Notice appear.
Now it will throw nice Exception.
2017-04-30 11:38:47 +02:00
Marco Pivetta
03972c9c3a
Merge pull request #6410 from PowerKiKi/patch-2
...
Minor typo naming strategy documentation
2017-04-23 14:25:39 +02:00
Adrien Crivelli
692a1afa86
Minor typo naming strategy documentation
2017-04-22 00:05:57 +09:00
Alessandro Lai
4eb4465169
Fix as per review
2017-04-18 11:57:49 +02:00
Marco Pivetta
318e9a5596
Merge pull request #6400 from neobyteUK/master
...
Fix incorrect YAML datetime version field.
2017-04-15 02:23:56 +02:00
Richard Henry
e44a83fc7b
Fix incorrect YAML datetime version field.
2017-04-15 01:18:44 +01:00
Marco Pivetta
b88480212a
Merge pull request #6399 from neobyteUK/master
...
Fix incorrect YAML example for versioning a field.
2017-04-15 01:24:06 +02:00
Richard Henry
6b6c300319
Fix incorrect YAML example for versioning a field.
2017-04-15 00:12:53 +01:00
Marco Pivetta
7c5b27da2c
Merge pull request #6395 from yannickl88/master
...
Updated broken links
2017-04-12 23:14:30 +02:00
Yannick de Lange
7e50a965fa
Updated broken links
...
Updated all links pointing to
http://www.doctrine-project.org/documentation/ * to their
http://docs.doctrine-project.org counterparts
2017-04-12 23:09:48 +02:00
Sergio Santoro
e798bfe34a
[QUERY] "INSTANCE OF" now behaves correctly with subclasses
...
There was a bug in the "INSTANCE OF" operator as described in
https://groups.google.com/forum/#!topic/doctrine-user/B8raq8CNMgg
"INSTANCE OF" was not taking into account subclasses.
It was merely translating the class to its discriminator.
This is not correct since the class can have subtypes and those
are, indeed, still instance of the superclass.
Also, classes may not have a discriminator (e.g. abstract classes).
This commit also provides useful tests to avoid regression.
2017-04-11 17:50:01 +02:00
mike
0865181702
Do not force an order of definition in the entity elements
2017-04-11 09:43:50 +02:00
mike
b43325760d
Add a type for the class FQCN
2017-04-11 09:43:31 +02:00
mike
f537eb2915
Add a table name type that accept quoted table name
2017-04-11 09:43:25 +02:00
chihiro-adachi
2c5e76c961
fix class name.
2017-04-07 14:33:41 +02:00
Marco Pivetta
03b4397557
Merge pull request #6378 from Sam-Burns/phpunit6
...
PHPUnit 6
2017-04-01 06:49:33 +02:00
Sam-Burns
3d7a7346f7
Quieting risky test warnings where tests do actually perform assertions
2017-03-31 23:23:22 +01:00
Sam-Burns
5bd7bd8d48
Updating to PHPUnit 6
2017-03-31 21:59:02 +01:00
Marco Pivetta
904f4d5021
Merge pull request #6377 from Sam-Burns/minimum-dependencies
...
Minimum dependencies
2017-03-31 20:46:14 +02:00
Sam-Burns
7aab261c24
Switching to a PHPUnit version that doesn't throw a stty-related PHP warning on Travis
2017-03-31 15:46:04 +01:00
Sam-Burns
f5b4e8c823
Specifying minimum version of doctrine/annotations with which tests pass
2017-03-31 15:24:07 +01:00
Sam-Burns
60cc11461d
Bumping doctrine/cache minimum version, to make tests pass
2017-03-31 15:07:53 +01:00
Sam-Burns
f2edf36248
Bumping doctrine/collections minimum version, to make tests pass
2017-03-31 15:07:53 +01:00
Sam-Burns
d6049f8631
Adding breaking build testing with minimum Composer dependencies
2017-03-31 15:07:29 +01:00
Adam Gąsowski
5507e0be29
Fix wrong variable name
...
Fix $fieldMapping to $embeddedClass in generateEmbeddedPropertyDocBlock
2017-03-23 19:12:40 +01:00
Marco Pivetta
1aa02f9afc
Merge pull request #6326 from SenseException/check-option
...
[Documentation] Add column check-option to documentation
2017-03-12 11:53:13 -04:00
Boris Yonchev
bd1efaf528
DDC-2780 - Fixed issue with IS NULL on join aliases
2017-03-07 18:34:50 +01:00
Claudio Zizza
504e701020
Add existing column check-option to documentation
2017-03-06 00:34:18 +01:00
Marco Pivetta
e4704beaf9
Merge pull request #6287 from lcobucci/fix-test-suite
...
Fix EntityManagerDecorator tests
2017-02-13 01:46:01 +01:00
Luís Cobucci
dcc80af7d9
Fix EntityManagerDecorator tests
...
We were expecting a return value for all methods but on 6a56df9a24
we changed some methods to be void and of course that affected the
ORM.
2017-02-12 18:38:21 +01:00
Marco Pivetta
10935dd843
Merge pull request #6285 from svencan/doc-typos
...
Fix typos and wording in NamingStrategy documentation
2017-02-10 18:55:05 +01:00
Sven Cannivy
260c8d0113
Fix typos and wording in NamingStrategy documentation
2017-02-10 18:48:57 +01:00
Marco Pivetta
23ae83e351
Merge pull request #6268 from enumag/patch-4
...
Fix annotation
2017-01-31 12:00:42 +01:00
Jáchym Toušek
64ab53a243
Fix annotation
2017-01-31 11:57:01 +01:00
mikeSimonson
e42d0bdda5
Merge pull request #6262 from mikeSimonson/doc
...
Fix a link to a ref in another page
2017-01-27 09:30:38 +01:00
mike
f3df000d29
Fix a link to a ref in another page
2017-01-27 09:27:25 +01:00
mikeSimonson
5989ea1752
Merge pull request #6260 from mikeSimonson/doc
...
Document the Custom option of the generated value annotation
2017-01-26 14:12:34 +01:00
Marco Pivetta
888f1be7c9
Merge pull request #6257 from weaverryan/add-criteria-note
...
Adding a note about the `Doctrine\ORM\QueryBuilder#addCriteria()` method
2017-01-25 16:56:12 +01:00
Ryan Weaver
63bd6c359c
[Docs] Adding a note about the addCriteria method on QueryBuilder
2017-01-25 10:52:17 -05:00
mike
773af5b306
Document the Custom option of the generated value annotation
2017-01-25 15:54:03 +01:00
Marco Pivetta
9c76c3766f
Merge pull request #6251 from mbeccati/ddc2660-test-fix
...
Add missing group to DDC2660Test.php
2017-01-24 13:43:59 +01:00
Matteo Beccati
c816d375e8
Add missing group to DDC2660Test.php
...
With the current PHPUnit version and PHP 7.2/master, the test fails with:
1) Doctrine\Tests\ORM\Functional\Ticket\DDC2660Test::testIssueWithExtraColumn
array_flip(): Can only flip STRING and INTEGER values!
2) Doctrine\Tests\ORM\Functional\Ticket\DDC2660Test::testIssueWithoutExtraColumn
array_flip(): Can only flip STRING and INTEGER values!
Due to the group being NULL vs "" on older PHP versions.
I will also file a bug report or fix to PHPUnit and/or PHP itself, but it sounds
like the missing group was just a typo.
2017-01-24 12:46:19 +01:00
Marco Pivetta
b181228d69
Merge pull request #6250 from johndodev/patch-1
...
Note on Entity listeners
2017-01-23 09:57:58 +01:00
John
57f560401b
Note on Entity listeners
...
As requested here https://github.com/doctrine/doctrine2/issues/6247#issuecomment-274123780 I thought it should be interesting to note that.
The note could be longer, like "You should avoid to have multiple methods for the same event (e.g. multiple @PrePersist) since the execution order is not guaranteed".
2017-01-23 09:35:26 +01:00
Luís Cobucci
119aa4e46c
Merge pull request #6244 from lcobucci/l2c-ensure-root-classname-everywhere
...
Make sure we're using the rootEntityName on all places
2017-01-20 00:05:48 +01:00
Luís Cobucci
1f53afa9cd
Make sure we're using the rootEntityName on all places
...
Otherwise we might end up with duplicated cache entries and weird
results (specially regarding associations).
2017-01-19 17:24:47 +01:00
Luís Cobucci
4f28aaa206
Refactor to use class_map() instead
2017-01-16 23:22:52 +01:00
Mikhail Polyanin
bb943afabe
Optimization. Multiple get in QueryCache
2017-01-16 23:02:23 +01:00
mikeSimonson
247b085fce
Merge pull request #6239 from mikeSimonson/travis-update
...
Travis update
2017-01-16 18:17:36 +01:00
mike
5968b9e62f
Removing php 7.1 from the allowed failure
2017-01-16 17:09:49 +01:00
mike
a831bb82ce
Adding hhvm as allowed to fail in the test matrix
2017-01-16 17:08:47 +01:00
Marco Pivetta
41a377948b
Documenting BC Break introduced by the removal of Doctrine\ORM\Query\SqlWalker#walkCaseExpression()
...
Ref: https://github.com/doctrine/doctrine2/pull/5600
2017-01-15 23:56:44 +01:00
Marco Pivetta
09cbb9ff48
Merge pull request #5600 from billschaller/remove-dead-code-walk-case-expression
...
Remove dead code SQLWalker::walkCaseExpression
2017-01-15 23:52:38 +01:00
Marco Pivetta
730db5fd2e
Merge pull request #6232 from gadelkareem/patch-3
...
Allow gearman env vars
2017-01-14 01:18:13 +01:00
Marco Pivetta
3d7ddc89b4
Merge pull request #6231 from gadelkareem/patch-2
...
Allow gearman environment vars
2017-01-14 01:15:46 +01:00
Waleed Gadelkareem
109ac5f827
Allow gearman env vars
2017-01-13 18:11:10 +01:00
Waleed Gadelkareem
d137ffe0a4
Allow gearman environment vars
2017-01-13 18:09:36 +01:00
Marco Pivetta
31c40f8342
Merge pull request #6216 from malukenho/enhancement/remove-unused-param
...
Remove unused "$className" argument
2017-01-12 17:04:01 +01:00
Jefersson Nathan
5208187f1a
rewording upgrade sentence
2017-01-12 13:02:10 -03:00
Marco Pivetta
9e35d9712d
Merge pull request #6227 from ThomasLandauer/patch-3
...
Minor formatting improvements
2017-01-12 16:13:59 +01:00
Thomas Landauer
4fccf84c82
Added link
...
Sorry, I don't know how to link to the exact section 8.8
2017-01-12 14:23:55 +01:00
Thomas Landauer
38636e7db4
Minor formatting improvements
...
Numbered lists aren't displayed nicely, see e.g. http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/reference/working-with-associations.html#persistence-by-reachability-cascade-persist - is this a rendering bug?
2017-01-12 13:59:24 +01:00
Thomas Landauer
63e4eea9e2
Complete re-write of "Transitive persistence / Cascade Operations" ( #6219 )
...
Follow-up of https://github.com/doctrine/doctrine2/pull/6171
2017-01-12 12:49:46 +01:00
Jefersson Nathan
df5f480b4c
document change as minor BC Break
2017-01-11 17:35:28 -03:00
Marco Pivetta
4e304df495
Merge pull request #6223 from lcobucci/fix-l2c-region-namespace
...
Appends cache namespace when it exists (for L2C regions)
2017-01-11 11:33:41 +01:00
Luís Cobucci
eaedc37d7b
Fix alignment issues on DefaultCacheFactoryTest.php
2017-01-11 11:04:43 +01:00
Luís Cobucci
5a562b3571
Appends cache namespace when it exists (for L2C regions)
...
We're overriding the namespace without even checking if it was previously
set, what causes problems when people uses that feature 😉
2017-01-11 11:01:39 +01:00
Marco Pivetta
4e573038be
Merge pull request #6220 from enumag/patch-2
...
Fix annotations
2017-01-10 12:50:39 +01:00
Jáchym Toušek
617ec9219e
Fix annotations
2017-01-10 09:12:18 +01:00
Marco Pivetta
ce4abdea55
Merge pull request #6171 from ThomasLandauer/patch-3
...
Include example of a cascaded "persist" operation
2017-01-09 14:08:31 +01:00
Thomas Landauer
7c168c2047
Update working-with-associations.rst
...
As requested: https://github.com/doctrine/doctrine2/pull/6171#pullrequestreview-15695400
2017-01-09 14:07:17 +01:00
Marco Pivetta
145c44630e
Merge pull request #6215 from malukenho/doc/#2190-add-link
...
Added link to `Transitive Persistence`
2017-01-05 22:22:07 +01:00
Jefersson Nathan
eaeecc3857
Remove unused arguments
2017-01-05 18:21:49 -03:00
Jefersson Nathan
f570eb5922
#2190 — Refer link to proper section and links more occurrence from Transitive Persistence
2017-01-05 12:46:01 -03:00
Jefersson Nathan
a1839048dd
#2190 — added link to Transitive Persistence
2017-01-05 11:48:16 -03:00
Luís Cobucci
c86865aa71
Merge pull request #6212 from malukenho/hotfix/#1808-fix-sql-example
...
Fix wrong DQL example
2017-01-04 07:34:18 +01:00
Jefersson Nathan
8b499a4791
#1808 — Fix wrong DQL example
2017-01-03 21:37:07 -03:00
Marco Pivetta
06691e0150
Merge pull request #6207 from gabidavila/master
...
Documentation: Fixes missing namespaces on class call
2017-01-02 19:40:44 +01:00
gabidavila
fc8ede844d
Fixes missing namespaces on class call
2017-01-02 16:11:46 -02:00
Marco Pivetta
443902f9f9
Merge pull request #6205 from railto/master
...
Remove support for PHP 5.x
2017-01-02 09:42:07 +01:00
Mark Railton
563c79bd80
Removes support for PHP 5.x
2017-01-02 08:36:42 +00:00
Marco Pivetta
d0c3f961ef
Merge pull request #6204 from alcohol/rip-5.6
...
rip 5.6
2017-01-02 09:28:08 +01:00
Rob Bast
a8d7b327ef
rip 5.6
2017-01-02 09:27:34 +01:00
Marco Pivetta
c24a89f4a3
Merge pull request #6197 from BenMorel/patch-2
...
getSingleScalarResult() returns NULL when the query yields no results
2016-12-26 04:41:20 +01:00
Benjamin Morel
3ce833fb62
getSingleScalarResult() returns NULL when the query yields no results
...
`NoResultException` is not thrown in this case.
2016-12-26 02:11:50 +01:00
Thomas Landauer
f3909ae885
Update working-with-associations.rst
2016-12-23 20:09:25 +01:00
Marco Pivetta
22b5fb1ad4
Merge pull request #6179 from biggianteye/getting-started-fixes
...
Minor fixes to the 'getting started' page
2016-12-23 04:03:05 +01:00
Burhan Ali
f64d543d0c
Add minor fixes to the 'getting started' page
2016-12-19 03:34:51 +00:00
Thomas Landauer
eecf4382b0
Update working-with-associations.rst
2016-12-18 23:05:10 +01:00
Thomas Landauer
a8a3a8c9e7
Update working-with-associations.rst
2016-12-18 21:58:44 +01:00
Thomas Landauer
1a8eeacfba
Update working-with-associations.rst
2016-12-18 21:42:08 +01:00
Marco Pivetta
cd1a5fcadc
Merge pull request #6177 from doctrine/fix/#6174-#5570-merging-new-entities-should-also-trigger-prepersist-lifecycle-callbacks
...
Fix #6174 #5570 : merging new entities should also trigger prepersist lifecycle callbacks with merged entity data
2016-12-18 16:42:44 +01:00
Marco Pivetta
21a5d8ca1b
#6174 #5570 removed modifications applied to the CompanyContractListener, since UnitOfWorkTest now completely encapsulates the scenarios being covered
2016-12-18 15:48:10 +01:00
Marco Pivetta
cfd595b699
#6174 #5570 removed unused imports
2016-12-18 15:46:49 +01:00
Marco Pivetta
018a5db08f
#6174 #5570 renamed entity for better fitting the use-cases it's in
2016-12-18 15:46:34 +01:00
Marco Pivetta
f39f1a2e11
#6174 #5570 removed unused test class
2016-12-18 15:45:03 +01:00
Marco Pivetta
262d13a047
#6174 #5570 adding group annotations to newly introduced test
2016-12-18 15:44:48 +01:00
Marco Pivetta
f4595d3a2f
#6174 #5570 prePersist listeners should never be called when entities are merged, but are already in the UoW
2016-12-18 15:43:29 +01:00
Marco Pivetta
30cd2d172b
#6174 #5570 started moving tests around prePersist event subscriber triggering on UnitOfWork into the UnitOfWorkTest
2016-12-18 15:37:49 +01:00
Marco Pivetta
9582ffc982
#6174 #5570 CS fixes around the EntityListenersOnMergeTest
2016-12-18 14:53:54 +01:00
Marco Pivetta
00c67ba2db
#6174 #5570 adding group annotation to newly introduced tests
2016-12-18 14:47:55 +01:00
Marco Pivetta
0c2edcd08a
#6174 #5570 CS - spacing/variable naming
2016-12-18 14:47:16 +01:00
Marco Pivetta
a22f165026
#6174 #5570 removed unused/dead code
2016-12-18 14:45:08 +01:00
Marco Pivetta
ab0e854830
#6174 #5570 CS - spacing
2016-12-18 14:39:46 +01:00
Marco Pivetta
85e2dc8f22
#6174 #5570 CS - spacing
2016-12-18 14:38:10 +01:00
Marco Pivetta
3ce262a61a
#6174 #5570 flattened nested conditionals
2016-12-18 14:36:39 +01:00
Marco Pivetta
81d44d4d6e
#6174 #5570 documenting thrown exception types
2016-12-18 14:32:31 +01:00
Marco Pivetta
754f36ef65
#6174 #5570 CS - alignment
2016-12-18 14:27:35 +01:00
bilouwan
1be226cf63
Rename test
2016-12-15 15:12:29 +01:00
bilouwan
7f4de25a26
Cherry pick unit test from PR #5570 (Fix PrePersist EventListener when using merge instead of persist)
2016-12-15 13:03:53 +01:00
bilouwan
493d39f5df
doMerge will mergeEntityStateIntoManagedCopy BEFORE persistNew to let lifecyle events changes be persisted
2016-12-15 12:49:11 +01:00
bilouwan
d1c8d378cf
Create failing test to reveal the issue
2016-12-15 12:47:45 +01:00
Thomas Landauer
879d4e7df0
Update working-with-associations.rst
2016-12-14 21:46:18 +01:00
Thomas Landauer
29062fb42e
Update working-with-associations.rst
2016-12-14 21:39:47 +01:00
Thomas Landauer
a06f8d4759
Update working-with-associations.rst
2016-12-14 21:38:10 +01:00
Thomas Landauer
6aa81d1d36
Include example of a cascaded "persist" operation
...
Following up on https://github.com/doctrine/doctrine2/issues/2943 I started to clarify how it's supposed to be done.
Please check if this would be necessary (at line 511):
`$myFirstComment->setUser($user);`
...and add it (in case).
2016-12-14 00:10:39 +01:00
Marco Pivetta
6e6be3fdd9
Merge pull request #6164 from eyepin/patch-1
...
Update EntityGenerator.php
2016-12-12 08:30:16 +01:00
Marco Pivetta
24377156b4
Merge pull request #6166 from lcobucci/use-php56-features
...
Normalise codebase with PHP 5.6 features
2016-12-12 08:03:43 +01:00
Luís Cobucci
ba9fecc43f
Remove commented code that seems to not be important
2016-12-08 18:16:11 +01:00
Luís Cobucci
62d122bd54
Remove old "CLASSNAME" constants from test models
2016-12-08 18:15:48 +01:00
Luís Cobucci
fda6fdd9fb
Use "::class" syntax on "tests" directory
2016-12-08 18:13:39 +01:00
Luís Cobucci
512aa8a3c7
Use "::class" syntax on "lib" directory
2016-12-08 17:09:35 +01:00
Luís Cobucci
234989d069
Use short-array syntax on "lib" directory
2016-12-08 00:31:12 +01:00
Luís Cobucci
c609072ce1
Use short-array syntax on "bin" directory
2016-12-07 23:34:14 +01:00
Luís Cobucci
74c8a08828
Use short-array syntax on "tests" directory
2016-12-07 23:33:41 +01:00
Luís Cobucci
1d5e16e9d9
Use short-array syntax on "tools" directory
2016-12-07 23:32:17 +01:00
eyepin
521588f498
Update EntityGenerator.php
...
orm:generate:entities genrates 2 blank lines
PSR2: All PHP files MUST end with a single blank line.
this worked for me
2016-12-07 13:13:21 +01:00
Marco Pivetta
6af1d2843f
Bumping doctrine/common dependency to allow ^2.7.1
2016-12-04 06:55:26 +01:00
Marco Pivetta
555e8ae641
Merge branch 'fix/#6017-check-entity-name-in-clear-call-should-be-a-string'
...
Close #6017
2016-11-27 18:39:55 +01:00
Marco Pivetta
dc3b166811
#6017 replaced random_int() with rand(), since we still support oldstable PHP (5.6.x)
2016-11-27 18:38:57 +01:00
Marco Pivetta
44a6141235
#6017 removed clear($entityName) tests from UnitOfWorkTest: now covered in EntityManagerTest
2016-11-27 18:37:45 +01:00
Marco Pivetta
53c5824a6b
#6017 removed clear($entityName) parameter validity checks
...
The `UnitOfWork` is advanced stuff: don't touch if you don't know what you are doing.
2016-11-27 18:37:45 +01:00
Marco Pivetta
1d7397caf0
#6017 moving entity name validity checks into the EntityManager API, documenting newly thrown exception types
2016-11-27 18:37:45 +01:00
Marco Pivetta
92274124f9
#6017 moving tests around clear() into the EntityManager tests
...
`UnitOfWork` assumptions are OK, since we don't want to clutter the API even more down there
2016-11-27 18:37:45 +01:00
Marco Pivetta
49333867f8
FQCN reference correction
2016-11-27 18:36:49 +01:00
Marco Pivetta
9894dcb4b0
#6017 clear($proxyClassName) should behave like clear($realClassName)
2016-11-27 18:36:49 +01:00
Marco Pivetta
fdb2af07e7
#6017 hardened clear() logic, which now ensures that persisted entries are correctly cleared
2016-11-27 18:36:49 +01:00
Marco Pivetta
dffd765b1e
#6017 requesting clear('nonExistingEntityName') now raises a MappingException
2016-11-27 18:36:48 +01:00
Marco Pivetta
c1038096e0
#6017 requesting clear('nonExistingEntityName') should raise a MappingException
2016-11-27 18:36:48 +01:00
Marco Pivetta
8f77afdc34
#6017 removed unused ORMException::invalidEntityName
2016-11-27 18:36:48 +01:00
Marco Pivetta
754e1f5d42
#6017 throwing an ORMInvalidArgumentException when clearing with non-string data. Also removing duplicate null checking
2016-11-27 18:36:48 +01:00
Marco Pivetta
c97799f151
#6017 expecting an ORMInvalidArgumentException when clearing with invalid data
2016-11-27 18:36:48 +01:00
Marco Pivetta
56598596a4
#6017 adding @group annotation to newly introduced tests
2016-11-27 18:36:48 +01:00
Marco Pivetta
6ad9c9ea04
#6017 test coverage for ORMInvalidArgumentException::invalidEntityName
2016-11-27 18:36:48 +01:00
Marco Pivetta
c4d41fe56a
#6017 moved ORMException::invalidEntityName to ORMInvalidArgumentException::invalidEntityName
2016-11-27 18:36:48 +01:00
Jeremy Benoist
6b1d64d484
Remove unecessary persist in tests
2016-11-27 18:36:48 +01:00
Jeremy Benoist
be4aafd4f6
Use ORMException instead of a default exception
2016-11-27 18:36:48 +01:00
Jeremy Benoist
2a7d21ad18
Throw an exception instead of a workaround
2016-11-27 18:36:48 +01:00
Jeremy Benoist
4a87f00fab
Avoid error when entityName isn't a string
2016-11-27 18:36:48 +01:00
Marco Pivetta
77a338e0fd
Merge branch 'fix/#5935-#5684-#6020-#6152-id-generator-convert-to-custom-dbal-id-type'
...
Close #5935
Close #5684
Close #6020
Close #6152
2016-11-27 17:49:54 +01:00
Marco Pivetta
cff5c07014
#5935 #5684 #6020 #6152 removed useless NAME constant from the test
2016-11-27 17:49:09 +01:00
Marco Pivetta
73ea0ba8f3
#5935 #5684 #6020 #6152 adding description to the test scenario
2016-11-27 17:45:50 +01:00
Marco Pivetta
e736d19677
#5935 #5684 #6020 #6152 extracted identifier conversion to a private method
2016-11-27 17:42:12 +01:00
Christian Hammerl
0a86c324ad
Add test case for autoincremented id of custom type
2016-11-27 01:45:56 +01:00
Renan Gonçalves
52badf1cdd
Convert generated id value to its PHP representation.
...
According to the conversion rules of a specific DBAL mapping type.
2016-11-27 01:43:50 +01:00
Marco Pivetta
4c59ec9282
Merge pull request #5834 from ismailbaskin/patch-1
...
Fix custom-id-generator class attribute type
2016-11-26 07:04:02 +01:00
Marco Pivetta
dc7c6ed72c
Merge pull request #5897 from mikaelz/patch-1
...
Check for Xcache from INI setting
2016-11-26 06:48:55 +01:00
Marco Pivetta
28025b8230
Merge branch 'cleanup/#5914-cleanup-sql-walker-code'
...
Close #5914
2016-11-26 06:45:16 +01:00
Marco Pivetta
0ed18fb062
#5914 removed unused conditional inside EntityGenerator, replaced with array_filter() instead
2016-11-26 06:44:53 +01:00
Marco Pivetta
5d477cdbbc
#5914 ClassMetadataInfo#$lifecycleCallbacks is a multi-dimensional array
2016-11-26 06:42:46 +01:00
ReenExe
b2f5da19a4
clear code
2016-11-26 06:40:56 +01:00
ReenExe
401300b295
decrease nested if
2016-11-26 06:40:56 +01:00
ReenExe
12465e08ad
agree with scrutinizer
2016-11-26 06:40:32 +01:00
Marco Pivetta
89a00860e4
Merge branch 'fix/#6068-docblock-entity-generation-for-nullable-types'
...
Close #6068
2016-11-26 06:35:33 +01:00
Marco Pivetta
f8002ca27e
#6068 hardened test logic to verify that nothing is present after the |null in @var and @return types
2016-11-26 06:35:23 +01:00
Marco Pivetta
a4f76bda34
#6068 corrected nullable field expression generator, made it private to avoid misuse
2016-11-26 06:26:53 +01:00
Marco Pivetta
1d2baedfd5
#6068 simplified variable docblock codegen for nullable instance properties
2016-11-26 06:22:25 +01:00
Marco Pivetta
3341781f52
#6068 inlined code generating expression
2016-11-26 06:20:12 +01:00
Javier Spagnoletti
1dfadef221
Removed surplus semicolon at EntityGenerator::generateFieldMappingPropertyDocBlock()
2016-11-26 06:12:31 +01:00
Javier Spagnoletti
ad6469b64a
Update tests
2016-11-26 06:12:31 +01:00
Javier Spagnoletti
087d081601
Fix CS
2016-11-26 06:12:31 +01:00
Javier Spagnoletti
d3c604567b
Update docblock generation for nullable fields
2016-11-26 06:12:31 +01:00
Marco Pivetta
c148059593
Merge branch 'fix/#6110-collection-clear-should-also-clear-keys'
...
Close #6110
2016-11-26 06:06:59 +01:00
Marco Pivetta
20190605a0
#6110 CS (whitespace removal)
2016-11-26 06:06:49 +01:00
Marco Pivetta
9acf170292
#6110 split test into multiple sub-scenarios involving PersistentCollection key checking
2016-11-26 06:02:16 +01:00
Steevan BARBOYON
fa09a95023
Clear $this->collection even when empty, to reset indexes
2016-11-26 05:57:56 +01:00
Marco Pivetta
b06dcb89b3
Merge pull request #5947 from alexryderwhytewaters/patch-1
...
Missing `ClassMetadataExporter` instantiation in the reverse engineering code samples
2016-11-26 05:47:34 +01:00
Marco Pivetta
f11697361d
Merge pull request #5948 from Michal-sk/patch-1
...
Update association-mapping.rst to ease understanding of what associations mean
2016-11-26 05:46:39 +01:00
Marco Pivetta
a9c2778f30
Merge pull request #6085 from arjank/fix/Call_correct_method_in_test
...
More specific named native query throw exceptions test
2016-11-26 05:28:28 +01:00
Marco Pivetta
be1fd130f1
Merge pull request #6025 from ywarnier/ywarnier-patch-1
...
Fix typo in batch-processing doc
2016-11-26 05:26:20 +01:00
Marco Pivetta
a9230b8546
Merge branch 'cleanup/#5987-code-simplifications'
...
Close #5987
2016-11-26 05:25:01 +01:00
Marco Pivetta
3cd7b8c951
#5987 CS: spacing after ! (not) operator
2016-11-26 05:23:04 +01:00
Marco Pivetta
24da9061b9
#5987 inlined check for boolean 'true' literal
2016-11-26 05:22:43 +01:00
Javier Spagnoletti
e2b198112e
[minor] Add missing type hints, add strictness for some checks, remove some useless calls
2016-11-26 05:18:46 +01:00
Marco Pivetta
e7f2e35383
Merge pull request #5977 from gadelat/cleanup-1
...
Remove unneeded ternary operator from Query::contains
2016-11-26 05:05:37 +01:00
Marco Pivetta
979fede80c
Merge pull request #6038 from ReenExeContributor/cleanup-UnitOfWork
...
remove excess `check`
2016-11-26 04:59:16 +01:00
Marco Pivetta
8c38f5775d
Merge pull request #6121 from kalessil/sca
...
Static Code Analysis with Php Inspections (EA Extended)
2016-11-26 04:57:48 +01:00
Marco Pivetta
899393d3bb
Merge pull request #6142 from mbeccati/php72-count-fix
...
Fix incompatibility w/ PHP7.2+
2016-11-26 04:56:39 +01:00
Marco Pivetta
bfa9a31ad7
Merge pull request #6145 from lcobucci/improve-test-documentation
...
Improving the documentation of enums as discriminators test
2016-11-23 19:35:20 +01:00
Luís Cobucci
6344fd34cb
Improving the documentation of enums as discriminators test
...
@Ocramius was too eager to merge stuff
Related to: https://github.com/doctrine/doctrine2/pull/6141
2016-11-23 19:20:47 +01:00
Marco Pivetta
7789df39c5
Merge pull request #6141 from lcobucci/object-as-discriminators
...
Allow using objects as discriminators
2016-11-23 19:14:53 +01:00
Luís Cobucci
1b39cd87ad
Allow using objects as discriminators
2016-11-23 18:56:36 +01:00
Marco Pivetta
86fd0c5aa9
Merge pull request #6028 from lcobucci/fix/l2c-inheritance-query-cache
...
Make child entity share the timestamp region with parent class
2016-11-23 18:06:52 +01:00
Matteo Beccati
39dcf3e4c6
Fix incompatibility w/ PHP7.2+
...
Mock_ParserResult_*::getParameterMappings() was returning null, which
was then passed to count() on Query.php:308, causing a "Parameter must
be an array or an object that implements Countable" error.
2016-11-22 07:42:06 +01:00
Luís Cobucci
317e86802d
Make child entity share the timestamp region with parent class
2016-11-20 19:27:53 +00:00
Marco Pivetta
95d9c64aec
Merge pull request #6138 from WhiteEagle88/version-docs
...
Added examples for version column in the xml and yml formats
2016-11-19 23:04:47 +01:00
Dmytro Boiko
53cd9c4ca8
Added examples for version column in the xml and yml formats
2016-11-19 23:34:10 +02:00
Marco Pivetta
e7856f90d8
Merge branch 'feature/#6136-better-exception-message-on-invalid-connection-object'
...
Close #6136
2016-11-18 09:21:18 +01:00
Marco Pivetta
d2643eeb8b
#6136 Removed regex assertion - constant assertion is sufficient
2016-11-18 09:19:27 +01:00
SpacePossum
e37041aa94
Update message.
2016-11-18 08:06:11 +01:00
Marco Pivetta
f1bf045af3
Merge pull request #6130 from kalimatas/fix-xml-option-boolean
...
#6129 Added unit test for boolean option values.
2016-11-17 21:24:44 +01:00
Alexander Guz
8d433cdb39
#6129 Fixed code style and @depends in test.
2016-11-17 21:05:58 +01:00
SpacePossum
f9a605f6ca
Add details about invalid Connection passed at creation.
2016-11-17 17:23:22 +01:00
Alexander Guz
7bf206adb4
#6129 Moved test to AbstractMappingDriverTest.
2016-11-16 20:01:11 +01:00
Alexander Guz
8580f02c6a
#6129 Use User::class to get metadata instead of string.
2016-11-16 18:07:58 +01:00
Alexander Guz
cdf4af5f27
Added unit test for boolean option values.
...
It fail now. In `XmlDriver::_parseOptions` we need somehow to maintain
a list of options, that are supposed to be boolean, and then call
`$this->evaluateBoolean()` on them.
2016-11-16 17:56:07 +01:00
Marco Pivetta
05e77868ab
Merge pull request #6120 from mschroeder/patch-3
...
Fixed typos regarding the strategy for composite keys (xml mapping)
2016-11-06 18:50:00 +01:00
Vladimir Reznichenko
db375a22cc
Static Code Analysis with Php Inspections (EA Extended): revert unsets
2016-11-06 17:58:45 +01:00
Vladimir Reznichenko
0bf3d7f84c
Static Code Analysis with Php Inspections (EA Extended)
2016-11-06 14:22:47 +01:00
Martin Schröder
155672af40
Fixed typos regarding the strategy for composite keys (xml mapping reference)
...
The strategy for composite primary keys must be "NONE" although the id generator class is \Doctrine\ORM\Id\AssignedGenerator. Calling the strategy "ASSIGNED" is misleading.
2016-11-06 14:05:50 +01:00
Marco Pivetta
bd58e4de4f
Merge pull request #6119 from mschroeder/patch-2
...
Fixed typo regarding the id generator mandatory for composite keys
2016-11-06 13:38:50 +01:00
Martin Schröder
3e98fdb082
Fixed typo regarding the id generator mandatory for composite primary keys
...
The strategy for composite primary keys must be "NONE" although the id generator class is \Doctrine\ORM\Id\AssignedGenerator. Calling the strategy "ASSIGNED" is misleading.
2016-11-06 13:37:07 +01:00
Marco Pivetta
3b6309318b
Merge pull request #6014 from photodude/patch-1
...
As of HHVM 3.15 pgsql is supported, add php 7.1 to tests
2016-11-05 10:03:49 +01:00
mikeSimonson
60a967bb1d
Merge pull request #6113 from mikeSimonson/master
...
Fix documentation
2016-11-03 21:10:41 +01:00
mike
b8b5c2d686
Merge branch 'master' of github.com:doctrine/doctrine2
2016-11-03 20:42:59 +01:00
mike
11c2d815ef
Correcting a use statment in the documentation
2016-11-03 20:40:48 +01:00
Marco Pivetta
56741a3fee
Merge pull request #6063 from kormik/patch-1
...
Fix PHP version in readme.
2016-10-27 02:11:19 +02:00
Marco Pivetta
c8df209409
Merge pull request #6065 from adiq/patch-1
...
Update Autoloader namespace [docs]
2016-10-27 02:10:43 +02:00
Marco Pivetta
fb95116a26
Merge pull request #6101 from malukenho/add-license-checker
...
Add license checker to the build
2016-10-27 01:16:18 +02:00
Jefersson Nathan
83da3d4b04
Revert "composer require --dev malukenho/docheader"
...
This reverts commit 81fefb40db .
2016-10-26 13:27:38 -03:00
Jefersson Nathan
5c6ecdcf1b
Revert "add license template file"
...
This reverts commit e4050edb4e .
2016-10-26 13:27:29 -03:00
Jefersson Nathan
dc07fc609e
Revert "add license checker to the build"
...
This reverts commit ca1a9473d3 .
2016-10-26 13:27:18 -03:00
Jefersson Nathan
dbe843fc4b
remove license from header of test files
2016-10-26 13:24:33 -03:00
Jefersson Nathan
b8a18cd0a1
fix license header inconsistencies
2016-10-25 23:58:42 -03:00
Jefersson Nathan
ca1a9473d3
add license checker to the build
2016-10-25 23:53:17 -03:00
Jefersson Nathan
e4050edb4e
add license template file
2016-10-25 23:52:07 -03:00
Jefersson Nathan
81fefb40db
composer require --dev malukenho/docheader
2016-10-25 23:51:31 -03:00
Marco Pivetta
26cf90e1c5
Merge pull request #6095 from mschroeder/patch-1
...
Fixed typo in annotations reference
2016-10-25 05:56:54 +02:00
Marco Pivetta
cf1ba3183d
Merge pull request #6089 from damour/master
...
Remove duplicated enum type comment from declaration.
2016-10-25 05:48:57 +02:00
Garanzha Dmitriy
3861cbf317
Remove duplicated enum type comment from declaration.
2016-10-21 11:30:27 +03:00
Martin Schröder
cdad5a82c5
Fixed typo in annotations reference
2016-10-20 13:32:59 +02:00
Marco Pivetta
d6eddab94f
Revert "Merge pull request #6092 from ThomasLandauer/patch-2"
...
This reverts commit ade3f3a7f3 , reversing
changes made to a6e44d9305 .
2016-10-18 10:00:10 -07:00
Marco Pivetta
ade3f3a7f3
Merge pull request #6092 from ThomasLandauer/patch-2
...
Updated a link (hopefully :-)
2016-10-18 09:46:53 -07:00
Thomas Landauer
d3c2c40452
Updated a link (hopefully :-)
2016-10-18 18:21:46 +02:00
Marco Pivetta
a6e44d9305
Merge pull request #6087 from chihiro-adachi/fix-namespace
...
Fix namespace
2016-10-18 07:12:22 -07:00
chihiro-adachi
42c4938a8b
cache -> cached
2016-10-18 12:09:43 +09:00
chihiro-adachi
fb1136cc9a
adjust the appearance of the table
2016-10-15 15:47:49 +09:00
chihiro-adachi
03da85e19e
fix namespace
2016-10-15 15:41:10 +09:00
Arjan
a4379cc9e2
Fixes named native query test
...
- Makes sure the correct method is called in the test
- Verifies that the correct method is called by checking the exception message
2016-10-13 22:54:32 +02:00
Marco Pivetta
a353cb81a3
Merge pull request #6080 from ThomasLandauer/patch-1
...
Fixed typo + added link
2016-10-11 17:02:07 +02:00
Thomas Landauer
277833b487
Fixed typo + added link
2016-10-11 16:59:03 +02:00
Marco Pivetta
47cb963731
Merge pull request #6070 from Dreamlex/master
...
Update events.rst
2016-10-06 02:40:04 +02:00
alexndlm
fc81760b54
Update events.rst
...
https://github.com/doctrine/doctrine2/pull/169
2016-10-05 14:16:47 +03:00
Adrian Zmenda
96b3797ad6
Update Autoloader namespace
2016-10-03 12:25:49 +02:00
Tomas Kormanak
974a9f4b9e
Fix PHP version in readme.
2016-10-02 22:38:40 +02:00
ReenExe
2ee56a595b
remove excess check
2016-09-15 19:41:34 +03:00
Yannick Warnier
05db15f7ee
Fix typo in batch-processing doc
...
See http://www.dictionary.com/misspelling?term=apparant&s=t
2016-09-12 12:22:49 -05:00
Marco Pivetta
cd11723e63
Merge branch 'fix/#5768-#5755-clone-proxy-private-properties-in-multi-level-inheritances'
...
Close #5768
Close #5755
2016-09-10 20:51:27 +02:00
Marco Pivetta
3fca33bdc4
#5768 #5755 cleaned up test scenario, using new mocking logic as per PHPUnit 5.4+
2016-09-10 20:45:01 +02:00
Ed Hartwell Goose
67e205b36a
Fixes #5755 , uses '->getReflectionProperties()' instead of '->getReflectionClass()->getProperties()' to ensure all fields are copied, and adds test to confirm behaviour
2016-09-10 20:37:20 +02:00
Marco Pivetta
22105058fa
Merge branch 'fix/#5689-avoid-object-hash-conflicts-due-to-merge-operations'
...
Close #5689
2016-09-10 20:22:52 +02:00
Marco Pivetta
503b211a22
#5689 removed unused reflection access
2016-09-10 20:19:15 +02:00
Marco Pivetta
f8436b2165
#5689 removed OidReuseTest, which was moved to UnitOfWork tests
2016-09-10 20:15:59 +02:00
Marco Pivetta
75bf197e11
#5689 moved OidReuseTest contents into the UnitOfWork tests
2016-09-10 20:15:33 +02:00
Walt Sorensen
99d704ff45
Drop mariadb: 5.5 tests
...
reorder matrix so all HHVM tests are at the bottom
2016-09-10 12:15:25 -06:00
Walt Sorensen
29f51b4a26
Remove the last hhvm3.15 tag
2016-09-09 18:00:40 -06:00
Walt Sorensen
1f521d26f3
Set to HHVM latest (currently 3.15 until next release)
...
Move sudo: false to the top line to be more clear about use of containers as default vs the trusty builds for HHVM
2016-09-09 17:21:03 -06:00
Walt Sorensen
fda2cd7d0e
Set all HHVM-3.15 to allowed failure
2016-09-09 15:59:23 -06:00
Walt Sorensen
a879811b6c
Fast finish to avoid waiting on allowed failures
...
Also Allow HHVM 3.15 with pgsql to fail
2016-09-09 15:51:34 -06:00
Walt Sorensen
e52ca954f0
fixing the xdebug error with php 7.1, nightly and HHVM-3.15
2016-09-09 15:42:31 -06:00
Walt Sorensen
d7a0ed0611
pin to HHVM 3.15 and add PHP 7.1
...
Stop testing against old HHVM 3.9 and test against current LTS 3.15
2016-09-09 15:35:33 -06:00
Mathieu De Zutter
44af69c5d2
Additional assertion to check that unreferenced objects are not in UOW.
2016-09-09 23:22:31 +02:00
Mathieu De Zutter
b8c7d871be
Remove old code in comments.
2016-09-09 23:22:31 +02:00
Mathieu De Zutter
01d51bfca3
Avoid conflicts due to spl_object_hash().
...
When merging an entity with a to-many association, it will store the
original entity data using the object hash of the to-be-merged entity
instead of the managed entity. Since this to-be-merged entity is not
managed by Doctrine, it can disappear from the memory. A new object
can reuse the same memory location and thus have the same object hash.
When one tries to persist this object as new, Doctrine will refuse it
because it thinks that the entity is managed+dirty.
This patch is a very naive fix: it just disables storing the original
entity data in case of to-many associations. It may not be the ideal
or even a good solution at all, but it solves the problem of object
hash reuse.
The test case relies on the immediate reusing of memory locations by
PHP. The variable $user has twice the same object hash, though referring
a different object. Tested on PHP 5.6.17
Without the fix, the test fails on the last line with:
A managed+dirty entity Doctrine\Tests\Models\CMS\CmsUser@[...] can not
be scheduled for insertion.
2016-09-09 23:22:31 +02:00
Walt Sorensen
48dcbe9d35
As of HHVM 3.15 pgsql is supported
2016-09-09 15:18:48 -06:00
Marco Pivetta
3e3bfbf6d8
Merge pull request #6013 from guhelski/fix_typo
...
Documentation - Fix typo
2016-09-09 21:31:41 +02:00
guhelski
60346e0046
Fix typo
2016-09-09 16:46:35 +02:00
Guilherme Blanco
81f4d3b0fb
Merge pull request #6011 from lcobucci/refactor/use-method-instead
...
Use `ClassMedatada#isIdGeneratorIdentity()` instead of constant to add the ID on query
2016-09-09 10:25:00 -04:00
Luís Cobucci
e43b9e9e3a
Use isIdGeneratorIdentity() to add the ID on query
...
It's quite handy when creating CUSTOM id generators that should also
rely on AUTO_INCREMENT stuff (one can just extend the `ClassMedatadaFactory`
and create a different instance of `ClassMetadata` that overrides that
method).
2016-09-09 07:52:44 +00:00
Marco Pivetta
e7e142ea4a
Merge pull request #6010 from phansys/entity_repo_count
...
Update exception message at `EntityRepository::__call()`
2016-09-08 19:21:06 +02:00
Javier Spagnoletti
5353137617
Update exception message at EntityRepository::__call()
2016-09-08 13:32:06 -03:00
Marco Pivetta
009e94720b
Merge branch 'fix/#6001-second-level-cache-query-cache-timestamp-from-region'
...
Close #6001
2016-09-08 14:02:16 +02:00
Marco Pivetta
d27cffa8e6
#6001 documenting minor BC break in QueryCacheEntry#time type - specific version used
2016-09-08 13:51:21 +02:00
Luís Cobucci
dd476094af
The timestamp verification is now done by the validator
...
So it's useless to keep it here too.
2016-09-08 13:50:06 +02:00
Luís Cobucci
b431332cef
Evict query cache when entities are updated
2016-09-08 13:50:06 +02:00
Luís Cobucci
b49026b657
Add timestamp key to QueryCacheKey
2016-09-08 13:50:06 +02:00
Luís Cobucci
16a3a2a132
Use microtime to have more precision on cache time
2016-09-08 13:50:06 +02:00
Marco Pivetta
5eebdcf630
Merge branch 'fix/#6004-#5989-fix-hydration-in-a-joined-inheritance-with-simple-array-or-json-array'
...
Close #6004
Close #5989
2016-09-08 13:39:10 +02:00
Carl Vuorinen
43d22984ae
Add unit test for SimpleObjectHydrator
2016-09-08 13:37:00 +02:00
Carl Vuorinen
d2cbd5e872
PR fixes (public properties & correct letter case in annotations)
2016-09-08 13:37:00 +02:00
Carl Vuorinen
00bbf4f523
Use yoda condition in the null check
2016-09-08 13:37:00 +02:00
Carl Vuorinen
95546d68c5
Fix hydration in a joined inheritance with simple array or json array
...
SimpleArrayType and JsonArrayType convert NULL value to an empty array, which fails the null check that is used to prevent overwrite
Fixes issue #5989
2016-09-08 13:37:00 +02:00
Carl Vuorinen
12b5e79ff2
Create a failing test for issue #5989
...
Field with type=simple_array in a joined inheritance gets overridden by empty array in the hydrator
2016-09-08 13:37:00 +02:00
Marco Pivetta
8a87fa2d01
Merge branch 'feature/#6003-count-on-repositories'
...
Close #6003
2016-09-08 00:56:34 +02:00
Marco Pivetta
c5c56a9dad
#6003 clarifying thrown exception
2016-09-08 00:55:49 +02:00
Marco Pivetta
36e9904082
#6003 inlined persister retrieval
2016-09-08 00:55:09 +02:00
Marco Pivetta
e2cba87662
#6003 corrected return type definition
2016-09-08 00:54:49 +02:00
Marco Pivetta
7bf4a65c92
#6003 imported used symbol
2016-09-08 00:53:35 +02:00
Marco Pivetta
de4c854ac9
#6003 removed useless count() call
2016-09-08 00:48:52 +02:00
Marco Pivetta
5e51a985b7
#6003 no default parameter needed
2016-09-08 00:47:39 +02:00
Marco Pivetta
6f79a378d5
#6003 removed useless method parameter count checking duplication
2016-09-08 00:43:29 +02:00
Javier Spagnoletti
61f6b667c0
Remove default clause at EntityRepository::resolveMagicCall()
2016-09-08 00:32:15 +02:00
Javier Spagnoletti
591bae0855
Swap logic from EntityRespository::__call()
2016-09-08 00:32:15 +02:00
Javier Spagnoletti
bea3c653bc
Updated docs
2016-09-08 00:32:15 +02:00
Javier Spagnoletti
a90035e81a
Expose EntityPersister::count() through EntityRepository::count()
2016-09-08 00:32:15 +02:00
Marco Pivetta
35341769ea
Merge pull request #5972 from giginos/patch-1
...
Wrong return type of getResult()
2016-09-07 23:31:19 +02:00
Marco Pivetta
2814d6e2fa
Merge branch 'fix/#5975-fix_hydrating_fetch_join_with_composite_pk'
...
Close #5975
Close #5762
Close #5776
2016-09-07 23:22:51 +02:00
Marco Pivetta
50f321f2e9
#5975 minor test cleanups
2016-09-07 23:18:39 +02:00
Marco Pivetta
140960ebb1
#5975 short array syntax
2016-09-07 23:17:40 +02:00
Alexander Kurilo
74ec055d57
Use ::class const instead of FQCN string ( #5762 )
2016-09-07 23:15:00 +02:00
Alexander Kurilo
c6ea8b1129
Remove irrelevant accessors ( #5762 )
2016-09-07 23:15:00 +02:00
John Keller
3bec698fed
add functional test and bug fix for issue #5762
2016-09-07 23:15:00 +02:00
Marco Pivetta
a90f23dfc7
Merge pull request #6005 from cvuorinen/fix-functional-test-query-logger
...
Improve functional test query logger
2016-09-07 22:35:00 +02:00
Carl Vuorinen
0da6669fac
Fix functional test query logger
...
DebugStack starts queries array from index 1 rather than 0 so the last query was never printed.
Also array params caused an 'Array to string conversion' error
2016-09-03 23:52:34 +03:00
Gabriel Potkány
75f44008d6
Remove unneeded ternary operator from Query::contains
2016-08-16 01:31:46 +02:00
giginos
eb62ae5933
Wrong return type of getResult()
...
@see https://github.com/doctrine/doctrine2/issues/5971
2016-08-12 16:26:08 +02:00
Marco Pivetta
31a0c02b06
Merge pull request #5713 from OndraM/remove-coveralls
...
Cleanup no longer used coveralls settings; use scrutinizer badges
2016-07-31 03:19:42 +02:00
Michal-sk
f18d279710
Update association-mapping.rst
...
Added spoken word examples of the relationship methods
2016-07-21 13:41:21 +02:00
Michal-sk
718ee42e8e
Update association-mapping.rst
...
Added pointers on how to interpret the method names. This helped me to quicker grasp the concept of the Relations and there methods. Added a @var annotation to the `Collection` interface to make it clear that the `$groups` is a child of the `Collection` interface.
2016-07-21 07:39:07 +02:00
Alex Ryder
20fb340375
missing $cme under reverse eng code sample
2016-07-21 13:52:27 +12:00
Marco Pivetta
184f7d3285
Merge pull request #5942 from Erikvv/patch-1
...
Add @CustomIdGenerator to documentation
2016-07-20 15:25:22 +02:00
Erik van Velzen
b785a8dc02
Add @CustomIdGenerator to documentation
2016-07-18 18:16:34 +02:00
Marco Pivetta
2b47670831
Merge pull request #5931 from bitwombat/tutorial_fix
...
Clarify language regarding ArrayCollections.
2016-07-12 08:08:26 +02:00
Greg Bell
da43aa2d49
Clarify language regarding ArrayCollections.
...
See https://groups.google.com/forum/#!topic/doctrine-user/yJ8ABqBP5mI
2016-07-12 16:05:20 +10:00
Marco Pivetta
44feacd327
Corrected SLC test expected query count: since the identity map is now consistently hashing identifiers
2016-07-07 23:46:09 +02:00
Steve Müller
355d2c3d19
Merge pull request #5924 from doctrine/fix/allow-empty-identifier-string-as-proxy-identifier
...
Allow empty string identifiers
2016-07-07 23:11:54 +02:00
Marco Pivetta
d330da898f
Correcting order of deletes: cache_token relies on cache_complex_action
2016-07-07 22:24:37 +02:00
Marco Pivetta
5d12593e70
Rewrote ManyToOne SLC tests to not rely on multi-level auto-generated identifiers
...
Background:
Test relied on an `A->B->C` association:
* `A#id` being `B`
* `B#id` being `C`
* `C#id` being an auto-generated identifier (post-insert)
This cannot work, because it breaks the UnitOfWork's identity map.
Specifically, no entries for `A` and `B` can exist in the identity map until `C` entries
are persisted (post-insert).
That means that the identifier generator for `A` and `B` should not be an "assigned"
generator, but should instead be a post-insert generator waiting for other entities
to be persisted.
We cannot fix this in ORM 2.x, but we'll need to invent something for 3.x in order to
fix that (directed graph, or caching the order of operations in the metadata graph).
2016-07-07 21:29:10 +02:00
Marco Pivetta
dbcdc1d42a
Empty identifiers must be disallowed
2016-07-07 20:57:49 +02:00
Marco Pivetta
0d82128b2e
Registering a managed entity with an empty identifier is to be disallowed
2016-07-07 20:57:02 +02:00
Marco Pivetta
7544934158
Removing note that is not valid anymore
2016-07-07 20:39:52 +02:00
Marco Pivetta
1cb8d790b6
Disallowing null as part of the entity identifier
2016-07-07 20:29:00 +02:00
Marco Pivetta
2829174267
Simplified test: invalid entities must make it in the UnitOfWork manually, via registerManaged
2016-07-07 20:28:21 +02:00
Marco Pivetta
5b8b548bd4
When invalid (null) identifiers are provided, an exception should be thrown
2016-07-07 20:08:24 +02:00
Marco Pivetta
9abccba109
When invalid (null) identifiers are provided, an exception should be thrown
2016-07-07 19:58:43 +02:00
Marco Pivetta
da7582d329
Typo fix: s/$booleanTrue/$booleanFalse (C&P mistake)
2016-07-07 19:43:03 +02:00
Marco Pivetta
aa1fda6d5f
Checking for boolean true/false identifiers
2016-07-07 19:38:48 +02:00
Marco Pivetta
29d9f344e8
Non-empty composite key identifiers should also be supported
2016-07-07 19:35:39 +02:00
Marco Pivetta
549bfe127c
Correcting test case: expecting identifier hashes to support empty strings
2016-07-07 19:34:24 +02:00
Marco Pivetta
12789ee6ca
Basic tests around addToIdentityMap with valid string identifiers (empty string allowed)
2016-07-07 19:27:49 +02:00
Marco Pivetta
5761d07c46
Merge pull request #5918 from tonynelson19/master
...
Make setSQL and setDQL function calls case-sensitive.
2016-07-05 19:50:59 +02:00
Tony Nelson
cd36407f28
Update EntityManager.php
2016-07-05 12:48:00 -05:00
Tony Nelson
1880cbd8b6
Update dql-doctrine-query-language.rst
2016-07-05 12:46:16 -05:00
Marco Pivetta
27e9b49215
Merge pull request #5911 from ReenExeContributor/scrutinizer-clear-code
...
Scrutinizer clear code
2016-07-05 18:21:08 +02:00
ReenExe
bcc7983934
after review
2016-07-05 19:15:47 +03:00
Marco Pivetta
ab4b761110
Merge pull request #5913 from ReenExeContributor/clear-code-metadata-info
...
Clear code metadata info
2016-07-05 18:09:18 +02:00
ReenExe
f7c16ab364
remove else
2016-07-03 00:21:00 +03:00
ReenExe
99b1eaaabb
clear code - double condition after isset
2016-07-03 00:17:51 +03:00
ReenExe
1dba0b8545
clear code
2016-07-03 00:14:33 +03:00
ReenExe
0e8491a474
clear code
2016-07-03 00:11:44 +03:00
ReenExe
511b27517a
refactoring: extract method
2016-07-03 00:10:43 +03:00
ReenExe
a81458a0aa
1. merge conditions
...
2. convert `if` to `condition`
2016-07-03 00:05:31 +03:00
ReenExe
b108a2af52
merge conditions
2016-07-03 00:01:07 +03:00
ReenExe
f7317d700c
logical remove double condition
2016-07-02 23:58:29 +03:00
ReenExe
2301fb3ff2
move common cascades
2016-07-02 23:53:23 +03:00
ReenExe
eccec87796
clear code
2016-07-02 23:47:21 +03:00
ReenExe
c0fc4f1158
use internal function
2016-07-02 23:02:13 +03:00
ReenExe
52b2d9022a
use ternary
2016-07-02 23:00:40 +03:00
ReenExe
a7c4ca82fd
use ternary
2016-07-02 22:59:16 +03:00
ReenExe
6bf6bae219
clear code
2016-07-02 22:51:44 +03:00
ReenExe
c6675b0ce3
use ternary
2016-07-02 22:42:46 +03:00
ReenExe
db6c593463
clear code
2016-07-02 22:37:12 +03:00
ReenExe
347d1625bc
merge conditions
2016-07-02 22:33:23 +03:00
ReenExe
16cddd4693
claar code from Scrutinizer
2016-07-02 22:13:06 +03:00
Marco Pivetta
ffd1465af2
Merge pull request #5910 from ReenExeContributor/clear-code
...
Code cleanups: early return/internal function usage
2016-07-01 01:05:16 +02:00
ReenExe
8eef0beacb
clear code
2016-07-01 01:20:52 +03:00
ReenExe
015ec444c5
use PHP common functions
2016-07-01 01:17:25 +03:00
Marco Pivetta
32ea9112fa
Merge pull request #5898 from radmax/patch-1
...
Typo
2016-06-30 15:08:18 +02:00
Marco Pivetta
b55ef58025
Merge pull request #5902 from holtkamp/patch-1
...
Fixed typo (serves => servers)
2016-06-26 09:15:21 +02:00
Menno Holtkamp
a3e9529c02
Fixed typo (serves => servers)
2016-06-25 17:29:04 +02:00
radmax
2ab752bfc3
typo
2016-06-22 17:06:16 +02:00
Michal Zuber
7ef3e3a60c
Check for Xcache from INI setting
...
On a shared webhosting the Xcache module is loaded, but it can be disabled with .htaccess `php_flag xcache.cacher Off` which causes issues.
2016-06-22 08:50:36 +02:00
Marco Pivetta
04b48ae12b
Merge pull request #5892 from BreiteSeite/5882-documentation
...
#5882 recommend using latest stable PHP version in the getting started guide
2016-06-20 22:10:15 +02:00
Michael Kühn
58d8b86bd5
#5882 recommend using latest stable PHP version in the getting started guide
2016-06-20 21:17:36 +02:00
Marco Pivetta
8237760c1b
Merge pull request #5891 from Chrisp1tv/master
...
Fix typo in PHPDoc block of QueryBuilder.php
2016-06-20 15:11:54 +02:00
Christopher Anciaux
76badc296a
Fix typo in PHPDoc block of QueryBuilder.php
2016-06-20 14:20:36 +02:00
Marco Pivetta
1162440d55
Merge pull request #5837 from foaly-nr1/patch-1
...
Use constant consistently
2016-06-19 19:41:37 +02:00
Marco Pivetta
8c49ba6128
Merge pull request #5886 from gadelat/remove-unused-variables
...
removed some unused variables
2016-06-19 18:35:24 +02:00
Gabriel Potkány
56a6505294
removed some unused variables
2016-06-19 14:46:02 +02:00
Marco Pivetta
3dfc180720
Merge branch 'fix/#5867-allow-embeddable-usage-in-inheritance'
...
Close #5867
Close #4097
Close #4277
2016-06-19 12:44:37 +02:00
Marco Pivetta
18e3cb4440
#5867 @group annotations, describing scenario
2016-06-19 12:44:19 +02:00
Marco Pivetta
aa8cf7bae9
#5867 simplifying test case by inlining all required models into the test case
2016-06-19 12:42:49 +02:00
Luís Cobucci
27f3bc1e2c
Allow the usage of embedded objects on parent classes.
...
The `ClassMetadataInfo` was always using the "current class" to
fetch the reflection of a property even when a field is declared
on the parent class (which causes `ReflectionProperty` to throw
an exception).
2016-06-19 12:35:57 +02:00
Marco Pivetta
b59b966cc2
Merge pull request #5884 from doctrine/cleanup/drop-php-5.5-support
...
Drop PHP 5.5 support
2016-06-19 09:37:40 +02:00
Marco Pivetta
a9bca86d4d
Merge pull request #5885 from doctrine/fix/proxy-failure-fixes
...
Partially reverting #5860 due to type juggling horrors
2016-06-19 09:37:25 +02:00
Marco Pivetta
d00069e38b
Reverting 741da7806c, which was causing issues due to loose type checking
...
See this example on why the revert is needed: https://3v4l.org/8T34v
Code copied for reference:
```php
<?php
$a = 1;
switch ($a) {
case "1";
echo "FUCK YOU, STUPID LANGUAGE!";
break;
case 1;
echo __LINE__;
break;
}
```
2016-06-19 09:28:12 +02:00
Marco Pivetta
e409c10209
Requiring at least PHP 5.6 as minimum installed PHP version
2016-06-19 08:51:48 +02:00
Marco Pivetta
1610d916a4
Stop testing against PHP 5.5
2016-06-19 08:51:24 +02:00
Marco Pivetta
765e102d01
Merge pull request #5856 from doctrine/fix/#5854-default-query-cache-test-using-wrong-reflection-instance
...
#5854 workaround to avoid populating Second Level Cache from DQL queries with multiple nested DQL aliases
2016-06-19 08:48:38 +02:00
Marco Pivetta
ed7f658437
Testing against PHP nightly, but allowing it to fail
2016-06-19 08:41:00 +02:00
Marco Pivetta
659f6a3864
Merge pull request #5883 from sebastianbergmann/phpunit-5.4
...
Make test suite compatible with PHPUnit 5.4.
2016-06-18 16:44:00 +02:00
Sebastian Bergmann
9da83cfae8
Make test suite compatible with PHPUnit 5.4.
...
* Use createMock() and getMockBuilder() instead of getMock()
* Use expectException() and expectExceptionMessage() instead of setExpectedException()
2016-06-18 13:01:59 +02:00
FabioBatSilva
163dac4a91
#5854 - Fix SLC queries with multiple nested DQL aliases
2016-06-17 00:11:18 -04:00
Marco Pivetta
c834ccf3fa
#5854 added PHP 7.1 to the build matrix
2016-06-16 23:00:59 -04:00
Marco Pivetta
be090e2f75
#5854 removing failure caused by a ReflectionProperty being instantiated against the wrong class name in a test
2016-06-16 23:00:59 -04:00
Marco Pivetta
288e3191ce
#5854 - simple workaround to avoid populating SLC cache from DQL queries with multiple nested DQL aliases
2016-06-16 23:00:59 -04:00
Marco Pivetta
d3f6c5ec70
Merge pull request #5873 from vudaltsov/patch-1
...
Update query-builder.rst
2016-06-14 04:39:57 +02:00
Valentin Udaltsov
6ac7480df4
Update query-builder.rst
...
Removed one brace
2016-06-14 04:32:20 +03:00
Marco Pivetta
81fe6a82b3
Merge branch 'fix/#5858-yaml-exporter-should-only-introspect-join-column-on-owning-association-side'
...
Close #5858
2016-06-08 13:33:43 +02:00
Thomas Ploch
ea788fb734
Exporters should only inspect joinColumns for owning side in bi-directional OneToOne
...
rebased commits:
- Added test case for bi-directional OneToOne in YamlExporter
- Only inspect joinColumns for owning side in bi-directional OneToOne in YamlExporter
- Adding bi-directional test case without joinColumn to XmlExporter test
- Same testcase also applied to PhpExporter
- Fixing bi-directional issue in PhpExporter when inspecting joinColumns index
- Implemented @Ocramius suggestions
2016-06-08 13:24:43 +02:00
Marco Pivetta
7e4106d47c
Merge pull request #5860 from peter-gribanov/master
...
Removed hacky switch/case, migrated to if/else and early return statements
2016-06-08 12:39:03 +02:00
Marco Pivetta
9b902263d5
Merge pull request #5863 from tPl0ch/feature-drop-54
...
Remove EOL PHP 5.4 from `.travis.yml` and `composer.json` - Fixes #5862
2016-06-08 12:36:21 +02:00
Thomas Ploch
650d49ee81
Tightened PHP version constraint in composer.json
2016-06-08 12:19:31 +02:00
Thomas Ploch
68b0060595
Fixing PHP version constraint in composer.json
2016-06-08 12:11:11 +02:00
Thomas Ploch
649ff94b38
Remove EOL PHP 5.4 from .travis.yml - Fixes #5862
2016-06-08 12:08:50 +02:00
Peter Gribanov
fa7799cec1
return check EventManager
2016-06-08 12:24:41 +03:00
Peter Gribanov
c0a87597fa
correct code style
2016-06-08 11:47:09 +03:00
Peter Gribanov
0b5b7190d7
not check EventManager
2016-06-08 11:29:43 +03:00
Peter Gribanov
fadd0a338f
add createConnection static method
2016-06-08 10:58:44 +03:00
Peter Gribanov
741da7806c
change switch/case to if/else
2016-06-08 10:29:39 +03:00
Marco Pivetta
3bc61d5f5e
Merge branch 'fix/#5850-clearing-specific-entity-name-should-clear-also-its-entity-insertions'
...
Close #5850
Close #5849
2016-06-06 00:35:44 +02:00
Marco Pivetta
68c5d761a8
#5849 #5850 minor performance optimization - avoiding get_class() calls on all entity insertions
2016-06-06 00:25:48 +02:00
Marco Pivetta
b9b952ce8a
#5849 #5850 renamed clearEntityInsertions to clearEntityInsertionsForEntityName, for clarity
2016-06-06 00:13:39 +02:00
Marco Pivetta
20d86c5b27
#5849 #5850 refactored clearIdentityMapForEntityName to remove useless looping
2016-06-06 00:11:19 +02:00
Marco Pivetta
14e0800293
#5849 #5850 renamed clearIdentityMap to clearIdentityMapForEntityName, for clarity
2016-06-06 00:10:18 +02:00
Marco Pivetta
34d8e00df7
#5849 #5850 correcting test scenario: identity map could not be built with auto-generated identities+persist
2016-06-06 00:08:26 +02:00
Marco Pivetta
313e4a33e5
#5849 #5850 adding group annotations to the newly introduced test case
2016-06-05 23:54:16 +02:00
Rico Humme
beb2641492
Correct naming convention of function. Was confusing otherwise
2016-06-05 23:16:09 +02:00
Rico Humme
4d48781e2b
Split of functionality in separate functions
2016-06-05 23:16:09 +02:00
Rico Humme
3df494ddc8
Test Case for Clear entityInsertions for specific entityName
2016-06-05 23:16:09 +02:00
Rico Humme
70603ee3db
Clear entityInsertions for specific entityName
2016-06-05 23:16:09 +02:00
Marco Pivetta
90b7450747
Merge pull request #5853 from lcobucci/patch-1
...
Fix typo
2016-06-05 22:34:07 +02:00
Luís Otávio Cobucci Oblonczyk
2c1818d513
Fix typo
2016-06-05 10:25:08 +00:00
Marco Pivetta
1c2b7c9685
Merge pull request #5813 from jeanCarloMachado/issue_5786
...
Add embedded and embeddable annotations in annotations reference index
2016-05-26 00:58:40 +02:00
Jonny Schmid
a6eb7f7c96
Use constant consistently
2016-05-25 10:23:03 +01:00
ismail BASKIN
fafb8166f4
Fix custom-id-generator class attribute type
...
custom-id-generator tag's attribute type must be FQCN. But NMTOKEN type doesn't support backslash character.
2016-05-22 19:36:15 +03:00
Marco Pivetta
b3aa8254e4
Merge pull request #5823 from munkie/unused-code
...
Optimize imports. Remove full qualified class names. Remove dead code.
2016-05-13 04:47:26 +02:00
Marco Pivetta
2f60d6a1f8
Merge pull request #5817 from primozcigler/master
...
Added missing - in the in getting started docs.
2016-05-12 07:27:03 +02:00
Primoz Cigler
964d510357
Added missing - in the in getting started docs.
2016-05-11 09:11:55 +02:00
Mikhail Shamin
b173763bbb
Remove full qualified class names in tests
2016-05-11 03:00:44 +07:00
Mikhail Shamin
bf322b903d
Optimize imports. Remove full qualified class names
2016-05-11 01:55:12 +07:00
Jean Carlo Machado
56daa67f94
add embedded and embeddable annotations in annotations reference index
2016-05-09 22:25:22 -03:00
Maks Rafalko
c5283eea87
Fix typo
...
`cached` -> `catched`
2016-05-01 15:03:40 +03:00
Guilherme Blanco
59a0410951
Merge pull request #5729 from funivan/patch-1
...
Fix typo
2016-04-21 11:26:15 -04:00
iBet7o
165722cf05
Fix bug: orderBy documentation
2016-04-17 17:31:48 -05:00
Marco Pivetta
76a5229fac
Merge pull request #5771 from teohhanhui/patch-1
...
Remove note on findBy not supporting entity
2016-04-12 13:39:55 +02:00
Teoh Han Hui
6c2463b905
Remove note on findBy not supporting entity
2016-04-12 15:05:16 +08:00
Andrei Sozonov
2f2236a1d6
fix typo
2016-04-01 15:54:17 +03:00
Guilliam Xavier
60e2224e6b
Fix PHP syntax error in composite-primary-keys.rst
...
Add missing semicolon after `private $year` on line 12 of `Car` class example code to fix `Parse error: syntax error, unexpected 'public' (T_PUBLIC), expecting ',' or ';' in [...]/VehicleCatalogue/Model/Car.php on line 14`
2016-03-24 18:08:58 +01:00
Aaron Merryman
b3df49b2f3
Update tools.rst
2016-03-23 18:54:20 -07:00
ivan
01e53ba44a
Fix typo
2016-03-21 14:16:07 +02:00
Ondřej Machulda
f06f383a38
Cleanup no longer used coveralls settings
2016-03-12 01:24:56 +00:00
Marco Pivetta
c1943624ab
Merge pull request #5686 from mbeccati/build-fix
...
Fixed test failing due to changes in AnnotationReader
2016-03-04 19:37:47 +01:00
Matteo Beccati
82588c0af9
Fixed test failing due to changes in AnnotationReader
...
Doctrine\Tests\ORM\Mapping\AnnotationDriverTest::testLoadMetadataForNonEntityThrowsException
Argument 1 passed to Doctrine\Common\Annotations\AnnotationReader::__construct() must be an instance of Doctrine\Common\Annotations\DocParser, instance of Doctrine\Common\Cache\ArrayCache given, called in .../tests/Doctrine/Tests/ORM/Mapping/AnnotationDriverTest.php on line 19 and defined
See: https://revive.beccati.com/bamboo/browse/PHP-DOCTR-PHP55-646/test/case/11813971
2016-02-29 11:06:23 +01:00
mikeSimonson
4b45183dbd
Merge pull request #5670 from mikeSimonson/doc
...
Add precision on the time units
2016-02-23 17:15:24 +01:00
Marco Pivetta
6ed05a9670
Merge pull request #5675 from jeanCarloMachado/fix_broken_links_doc
...
Fixed broken links on getting-started tutorial
2016-02-21 14:44:07 +01:00
Jean Carlo Machado
4c2ced8fee
fixed broken links on getting-started tutorial
2016-02-21 10:31:14 -03:00
Marco Pivetta
aef8f63dd0
Merge pull request #5673 from svycka/patch-1
...
removed unused use statement
2016-02-19 11:38:00 +00:00
Vytautas Stankus
9c320ca64f
removed unused use statement
2016-02-19 12:26:53 +02:00
mikeSimonson
1fa71f15d9
Merge pull request #5671 from mikeSimonson/jira-update
...
Removing section about jira as it has been removed.
2016-02-17 12:13:43 +01:00
mike
38efda33e1
Removing section about jira as it has been removed.
2016-02-17 11:02:19 +01:00
mike
13473e8b4e
Add precision on the time units
2016-02-17 10:57:05 +01:00
Guilherme Blanco
9b4c50e81e
Final work around entity changeset fix
2016-02-16 05:03:11 +00:00
Guilherme Blanco
b784a04cf7
Fixed only variables should be passed by reference issue
2016-02-16 04:46:34 +00:00
Guilherme Blanco
86cde3a9df
Fixed #5605
2016-02-16 03:21:53 +00:00
Guilherme Blanco
d814ad7234
Merge pull request #5668 from petitchevalroux/many-to-many-criteria-fixes
...
Many to many criteria fixes
2016-02-15 21:07:17 -05:00
Patrick Poulain
9461839d42
Fix PostgreSql Tests
2016-02-15 21:07:09 +01:00
Patrick Poulain
e8296e8e7d
Fix ORM Driver Tests
2016-02-15 21:06:34 +01:00
Patrick Poulain
cbde629bf0
Fix MySql Tests
2016-02-15 21:06:01 +01:00
Marco Pivetta
02eaf6a17a
Merge pull request #5667 from JeroenDeDauw/ORMException
...
Add missing @throws tags
2016-02-15 15:38:44 +01:00
jeroendedauw
34dbefaf22
Add missing @throws tags
2016-02-15 15:15:32 +01:00
jeremygiberson@gmail.com
dd64161ece
forgot to delete from relational table first
2016-02-14 18:00:15 -07:00
jeremygiberson@gmail.com
cc7ef71a13
added teardown for new cmstag table
2016-02-14 17:48:53 -07:00
jeremygiberson@gmail.com
1e660abeb8
cascade all operations on cmstags
2016-02-14 17:43:58 -07:00
jeremygiberson@gmail.com
3ed64dcec2
changed relation table column name to match
2016-02-14 17:37:25 -07:00
Jeremy Giberson
dd3f67d862
updated manytomany so it maps field names to column names in criteria ordering
2016-02-11 13:39:31 -07:00
Jeremy Giberson
0feaf92348
improve test readability
2016-02-10 20:27:43 -07:00
Jeremy Giberson
ae785757a1
Merge branch 'fix-many-many-criteria' of github.com:petitchevalroux/doctrine2 into many-to-many-criteria-fixes
...
Conflicts:
lib/Doctrine/ORM/Persisters/Collection/ManyToManyPersister.php
2016-02-10 20:04:48 -07:00
Jeremy Giberson
0adeade045
merged git@github.com:SammyK/doctrine2.git:many-to-many-order-by-fix
2016-02-10 19:52:03 -07:00
Jeremy Giberson
f0accca99d
Merge branch 'DDC-3719-fix' of github.com:jeanCarloMachado/doctrine2 into many-to-many-criteria-fixes
2016-02-10 19:40:45 -07:00
Patrick Poulain
cfeda903e3
Fix many-to-many matching ignoring offset/limit
2016-02-05 11:14:47 +01:00
Jean Carlo Machado
468fe315ba
fixed indentation
2016-01-29 10:03:44 -02:00
Jean Carlo Machado
375b0369ae
added test of matching non-owing side with criteria
2016-01-28 19:36:52 -02:00
Marco Pivetta
788143dc03
Merge pull request #5634 from alexislefebvre/travis-ci-remove-duplicate-condition
...
Remove duplicate code in .travis.yml
2016-01-26 23:00:55 +01:00
Alexis Lefebvre
a1ca73d1e1
Remove duplicate code in .travis.yml
...
The "$TRAVIS_PHP_VERSION != '7.0'" condition was duplicated
See #5580 .
2016-01-26 22:28:56 +01:00
Alessandro Lai
1e97cf21e8
Reverting removal of lock tests paragraph; minor fixes
2016-01-20 16:52:13 +01:00
Alessandro Lai
2c70f4edf7
[DOCUMENTATION] Update tests README
2016-01-20 16:42:58 +01:00
Marco Pivetta
a4d84e0cd8
Merge pull request #5599 from zeroedin-bill/fix/5598-having-regression-fix
...
Fix #5598 issue with /, * in DQL not translating query components properly
2016-01-16 10:29:49 -06:00
Steve Müller
b491e75d64
Merge pull request #5612 from issei-m/patch-2
...
[Doc] Is it a typo?
2016-01-15 02:48:44 +01:00
Issei.M
5535690b75
[Doc] Fix typo
2016-01-14 19:39:16 +09:00
Bill Schaller
744c308337
Remove dead code SQLWalker::walkCaseExpression
2016-01-08 13:58:02 -05:00
Bill Schaller
55d4f515af
Fix issue were identifier operands in /,* arithmetic terms were not checked to see if they're query components
2016-01-08 12:53:05 -05:00
Alessandro Lai
d7e7baf2a2
Regression test: HAVING clause does not translate variable name when used with * and / math operators
2016-01-08 17:56:41 +01:00
Marco Pivetta
196ea2d0c5
Merge pull request #5597 from deeky666/DDC-5596
...
Fix documentation of schema tool's "save mode"
2016-01-08 16:14:14 +01:00
Steve Müller
f9217cf6f2
fix documentation of schema tool's "save mode"
...
fixes #5596
2016-01-08 15:37:19 +01:00
Steve Müller
1697293591
Merge pull request #1563 from rawkode/bugfix/incorrect-rollback-method-name
...
Fixing method name 'rollBack', which was documented as 'rollback'
2016-01-06 11:49:32 +01:00
Steve Müller
22b9574a0f
Merge pull request #5591 from doctrine/docs/remove-2-4-from-readme
...
Removing 2.4 from README
2016-01-06 00:49:59 +01:00
Marco Pivetta
5bd476209d
Removing 2.4 from README
2016-01-06 00:48:26 +01:00
Marco Pivetta
ebe11c7bcf
Merge pull request #5590 from zeroedin-bill/fix-discriminator-column-defaults
...
Fix discriminator column defaults
2016-01-05 23:42:56 +01:00
Bill Schaller
8bde0c8a90
Fix AnnotationDriver, XmlDriver, YamlDriver to properly set DiscriminatorColumn defaults for type and length.
...
Note: Even though the column definition generated for a discriminator column
would eventually default the type to string and length to 255, the docs specify
defaults that should be reflected explicitly in the discriminatorColumn mapping.
2016-01-05 12:32:25 -05:00
Bill Schaller
6963fd8f20
Update docs for @DiscriminatorColumn to indicate that it is optional.
2016-01-05 12:30:29 -05:00
Bill Schaller
d97fad26a5
Add tests to ensure DiscriminatorColumn is optional, and that optional params type and length have proper defaults.
2016-01-05 12:29:49 -05:00
Marco Pivetta
7f16e5bc51
Merge pull request #5585 from mikeSimonson/cpr-year
...
Replacing the hardcoded year with a function call
2016-01-04 11:06:01 +01:00
mike
50d7ed98ca
Replacing the hardcoded year with a function call
2016-01-04 10:47:37 +01:00
Marco Pivetta
b792e959cd
Merge pull request #5584 from harikt/patch-2
...
Fix broken links to blog post.
2016-01-02 18:03:26 +01:00
Hari K T
30eb4646f7
Fix broken links to blog post.
2016-01-02 22:30:32 +05:30
Marco Pivetta
b22cdab1bb
Merge pull request #5580 from doctrine/hotfix/move-from-coveralls-to-scrutinizer-coverage
...
Move from coveralls to scrutinizer coverage
2015-12-29 20:18:34 +01:00
Marco Pivetta
43787447d6
Test suite is SLOOOOOOOOWWWWWW
2015-12-29 17:11:14 +01:00
Marco Pivetta
75957ee3e7
We can safely run coverage reporting on PHP7 only
2015-12-29 17:07:38 +01:00
Marco Pivetta
3e87a1c4b8
Uploading coverage information via ocular.phar
2015-12-29 16:54:36 +01:00
Marco Pivetta
e37e1818c6
Adding scrutinizer-ci config
2015-12-29 16:51:44 +01:00
Marco Pivetta
86e13f9c5d
Removing coveralls dependency
2015-12-29 16:47:20 +01:00
Marco Pivetta
5849dec16f
Shameless plug
2015-12-29 16:46:59 +01:00
Marco Pivetta
3ca6828544
Allowing doctrine/common 2.6
2015-12-25 15:58:57 +01:00
Marco Pivetta
5e53e92fc5
Merge branch 'hotfix/common-2.6-upgrade-compat'
2015-12-25 15:26:30 +01:00
Marco Pivetta
e0148f14e2
doctrine/common 2.6.0 compat
...
Less strict assertion - no need to check the exact file name
2015-12-25 15:20:35 +01:00
Marco Pivetta
6e6d3e27ab
Common 2.6 compatibility
...
Internal structure of the ArrayCache has changed, therefore we should fix the tests depending on it instead
2015-12-25 15:10:21 +01:00
Marco Pivetta
eb62e4d6c3
Merge branch 'hotfix/#4884-support-proxy-php7-hints-generation'
...
Close #4884
2015-12-25 14:46:30 +01:00
Marco Pivetta
7057d3607e
#4884 - allow installation of doctrine/common 2.6.x, which allows generating type-hints on proxies
2015-12-25 14:46:11 +01:00
Marco Pivetta
3260291aef
Merge pull request #5572 from greg0ire/patch-2
...
Guess missing words
2015-12-25 14:40:29 +01:00
Grégoire Paris
f9715ac24a
Guess missing words
2015-12-22 17:44:00 +01:00
Marco Pivetta
24e4215ab3
Merge pull request #5557 from malukenho/enhancement/remove-unecessary-namespace-use-and-import
...
Remove unnecessary namespaces imports and usage
2015-12-16 10:50:51 +01:00
Jefersson Nathan
156075682f
Remove unnecessary namespaces imports and usage
2015-12-16 05:45:55 -03:00
Marco Pivetta
6099e45eef
Merge branch 'hotfix/#1572-target-entity-resolver-dql-with-interfaces-support-2.6.x'
...
Close #1572
2015-12-11 21:34:57 +01:00
Marco Pivetta
0c6b510c2a
#1572 - test coverage - interfaces should also resolve to target entities when in DQL
2015-12-11 21:34:11 +01:00
oprokidnev
e390dbd5ba
Target entity resolver for DQL
...
Since we have target entity resolver in doctrine this class check is not enought.
To gain interface resolution it is better to add interface check in addition to class_check here.
2015-12-11 21:33:59 +01:00
Marco Pivetta
b341d5c453
Merge pull request #5548 from doctrine/cleanup/classmetadata-get-column-names-simplification
...
Cleanup - `ClassMetadataInfo#getColumnNames()` simplification
2015-12-11 21:20:12 +01:00
Marco Pivetta
044b202379
Simplifying getColumnNames logic (can be an array_map call)
2015-12-11 20:50:18 +01:00
Marco Pivetta
b2a6f8aa0e
Adding test case for fetching column names by field names
2015-12-11 20:48:59 +01:00
Marco Pivetta
276a22fb6f
Merge branch 'cs/#1228-minor-php-cs-fixes'
...
Close #1228
2015-12-11 20:32:28 +01:00
Jeroen Thora
6dcb97a20e
Fixed many small phpcs issues
2015-12-11 20:30:41 +01:00
Marco Pivetta
0a1fa8920e
Merge pull request #1396 from Padam87/embeddable_docs
...
[Documentation] Initializing embeddables doc
2015-12-11 20:24:44 +01:00
Marco Pivetta
3971e8c55b
Merge branch 'hotfix/#1573-merge-associated-versioned-entity'
...
Close #1573
2015-12-11 20:17:05 +01:00
Marco Pivetta
996db42029
#1573 - correcting test asset namespace, removing unused properties and bi-directional association
2015-12-11 20:14:53 +01:00
Marco Pivetta
cf3a54ab95
Removing empty newline
2015-12-11 20:00:59 +01:00
Marco Pivetta
16baa8d60f
#1573 - correcting docblock arguments/description
2015-12-11 20:00:08 +01:00
Marco Pivetta
41235f61de
#1573 removing unused API
2015-12-11 19:59:08 +01:00
Marco Pivetta
21a250fc02
Merge pull request #1472 from PowerKiKi/mariadb
...
Add test for MariaDB 5.5 and 10.1 on Travis
2015-12-11 19:45:09 +01:00
Marco Pivetta
9ac7c3bf70
Merge pull request #5547 from doctrine/hotfix/php7-xdebug-incompatibility-fixes
...
Correcting minor test case incompatibility with XDebug 2.4.x
2015-12-11 19:39:43 +01:00
Marco Pivetta
342ab2f7f1
Correcting minor test case incompatibility with XDebug 2.4.x
...
In PHP 5.x + XDebug < 2.4, the output would be "string:..."
In PHP 7.x + XDebug >= 2.4, the output would be "the/file/name.php:11:string:..."
This is an improvement in XDebug that is quite annoying for our purposes, but is actually welcome to most users anyway.
This commit simply fixes that incompatibility
2015-12-11 19:15:48 +01:00
Marco Pivetta
84f2bf7204
Merge branch 'docs/#1497-update-orm-documentation-for-utc-datetime-type'
...
Close #1497
2015-12-11 18:53:28 +01:00
Marco Pivetta
8c086d1a6e
#1497 - minor CS fixes
2015-12-11 18:53:18 +01:00
Marco Pivetta
df129635cf
#1497 - simplifying UTC datetime handling logic in the examples
...
Highly performance sensitive code should avoid method calls, sadly
2015-12-11 18:52:26 +01:00
Marco Pivetta
a130ff96ba
#1497 - Using a PHP code block to describe how a datetime+utc type can be set up
2015-12-11 18:48:23 +01:00
Marco Pivetta
5b22e59383
Removing symfony-specific documentation
2015-12-11 18:43:53 +01:00
Marco Pivetta
624fcb4486
Merge branch 'docs/#1496-docblock-fixes'
...
Close #1496
2015-12-11 18:27:36 +01:00
Marco Pivetta
00718f6bf7
#1496 s/$this/self
2015-12-11 18:27:19 +01:00
Damien Gavard
9b4dadade0
Use @return $this instead of @return static for consistency
2015-12-11 18:22:26 +01:00
Damien Gavard
5687347d60
Fix invalid return type documentation
2015-12-11 18:22:26 +01:00
Damien Gavard
15aafaa11d
Use @return $this instead of return explicitly QueryBuilder
2015-12-11 18:22:26 +01:00
Damien Gavard
8d62aadf55
Fix invalid return type in docblock
2015-12-11 18:22:26 +01:00
Marco Pivetta
b1bf57db48
Merge pull request #1408 from baileylo/patch-1
...
[doc] Remove unused variable from sample code
2015-12-11 18:19:26 +01:00
Marco Pivetta
9e68a5adc7
Merge pull request #1579 from aschempp/proxy-initialized-cs
...
Reduce code duplication in ProxyFactory::createInitializer
2015-12-11 18:16:53 +01:00
Benjamin Eberlei
a6ddac0a96
Remove link to issue tracker
2015-12-08 22:51:45 +01:00
Marco Pivetta
bd94931201
Merge pull request #1574 from Ma27/patch-1
...
deduplication of internal UnitOfWork methods
2015-12-08 19:02:28 +01:00
Andreas Schempp
4df7699ced
Reduce code duplication in ProxyFactory::createInitialized
...
The only difference between the ~30 lines in the IF-statement
is that the __wakup method is called on the proxy object.
2015-12-06 14:56:36 +01:00
bilouwan
fb4d02c69b
Refactor testing Proxy not initilized
2015-12-04 14:49:01 +01:00
StoshSeb
da4a29c0e2
Fixed DDC-3740
...
The count must return an integer, not a string
2015-12-03 13:15:12 +01:00
bilouwan
d2cbdd1866
Fix superflous whitespaces & empty lines
2015-12-02 14:09:14 +01:00
Maximilian Bosch
f840f0d464
DDC-4022 execute callback parameter directly instead of using call_user_func
2015-12-01 22:31:27 +01:00
Maximilian Bosch
11f9b00d53
DDC-4022 method naming
2015-12-01 22:31:26 +01:00
Maximilian Bosch
33476d8c34
DDC-4022 minor improvements
2015-12-01 22:31:25 +01:00
Maximilian Bosch
c337f8f5c7
DDC-4022 deduplication of internal UnitOfWork methods
...
the methods UnitOfWork#afterTransactionRolledBack() and UnitOfWork#afterTransactionComplete do almost the same, so it can be abstracted into another private method.
2015-12-01 22:31:25 +01:00
Guilherme Blanco
3c3b7364ba
Hotfix for missing reverse dependency in case of non-implicit change tracking policies
2015-12-01 20:24:16 +00:00
Guilherme Blanco
9b77ba2c1a
Merge pull request #1570 from doctrine/DDC-2524
...
[RFC] Tests around reported cases over DDC-2524
2015-12-01 00:27:34 -05:00
David McKay
3c7d92e4cc
Fixed incorrect case of another two references of rollback
2015-11-30 16:53:31 +00:00
bilouwan
e8f40f58a1
Fix compatibility with php5.4
2015-11-30 10:35:42 +01:00
Guilherme Blanco
8ea62b95b8
Tests around reported cases over DDC-2524
2015-11-27 18:44:23 +00:00
bilouwan
832adae6b4
Unit test & fix for merge versionned entity
2015-11-27 17:28:45 +01:00
Guilherme Blanco
599f99471e
Merge pull request #1571 from montaniasystemab/patch-1
...
Fixed typo in QueryBuilder->where() docblock
2015-11-26 15:30:56 -05:00
montaniasystemab
b48fca543c
Fixed typo in QueryBuilder->where() docblock
2015-11-26 10:01:29 +01:00
Guilherme Blanco
57b22bd646
Merge pull request #1568 from guiwoda/patch-ddc-3967
...
Identifier is cached with wrong type
2015-11-24 22:17:59 -05:00
Guido Contreras Woda
e3627f1886
Test that reflects the issue described in http://www.doctrine-project.org/jira/browse/DDC-3967
2015-11-24 10:35:31 -03:00
Marco Pivetta
b980e98ba3
Merge pull request #1566 from BenMorel/typofix
...
Fix typos in DQL doc
2015-11-23 14:27:26 +01:00
Benjamin Morel
6d8778fd69
Fix typos in DQL doc
2015-11-23 12:18:18 +01:00
David McKay
f8ba3a3434
Fixing method name 'rollBack', which was documented as 'rollback'
2015-11-21 18:18:56 +00:00
Guilherme Blanco
3cff0f88bd
Merge pull request #1562 from deeky666/fix-empty-expression
...
Fix empty expression on PHP 5.4
2015-11-19 10:45:21 -05:00
Steve Müller
e0cb90d426
fix empty expression on PHP 5.4
2015-11-19 16:43:33 +01:00
Marco Pivetta
9c5cea3e95
Merge pull request #1561 from deeky666/DDC-4006
...
[DDC-4006] Inherit ID generator strategy mapping from embeddables
2015-11-19 16:34:32 +01:00
Guilherme Blanco
22e76e8624
Merge pull request #1559 from guiwoda/wrong-entity-cache-read-inheritance
...
Entity cache key is built differently on read than on write
2015-11-19 10:30:37 -05:00
Steve Müller
86c81da7ce
inherit ID generator strategy mapping from embeddables
2015-11-19 16:10:48 +01:00
Guido Contreras Woda
6c96e23a47
Test to verify the bug and the fix
2015-11-19 12:02:51 -03:00
Guilherme Blanco
0b45d96c74
Merge pull request #1560 from gitname/patch-2
...
Fix broken links
2015-11-17 21:40:13 -05:00
gitname
001d5b7ed3
Fix relative links
...
Fix 2 relative links to other docs files
2015-11-17 12:30:32 -08:00
Guido Contreras Woda
427642aaba
Entity cache key is built differently on read than on write
2015-11-17 16:10:17 -03:00
Guilherme Blanco
84eb175dbf
Merge pull request #1436 from dadamssg/DDC-3785
...
allow ManyToManyPersister to handle custom identification types
2015-11-15 22:24:01 -05:00
Guilherme Blanco
50ee47cc70
Merge pull request #1492 from nicolas-grekas/doc-fix
...
Fix misleading docblock example
2015-11-15 22:19:27 -05:00
Guilherme Blanco
04789dfec7
Merge pull request #1443 from meeuw/unsigned
...
Unsigned
2015-11-15 22:16:15 -05:00
Guilherme Blanco
7fc36b4110
Merge pull request #1450 from davidfuhr/doc-version
...
Link annotation ref to locking explanation
2015-11-15 22:14:36 -05:00
Guilherme Blanco
cdfcca2ff2
Merge pull request #1455 from xoeoro/patch-1
...
Update ExprTest.php
2015-11-15 22:12:36 -05:00
Guilherme Blanco
9f93999758
Merge pull request #1487 from xxccdef/DDC-3864
...
[DDC-3864] Support any ordering of fields in partial object query with embeddable
2015-11-15 22:03:25 -05:00
Guilherme Blanco
e8acfb5891
Merge pull request #1481 from mikeSimonson/composer-bin-fix
...
Remove the execution bit on the bin/doctrine.php
2015-11-15 22:02:19 -05:00
Guilherme Blanco
5ec9a62e2b
Merge pull request #1558 from doctrine/DDC-3922
...
[RFC] remove indexes overruled by primary key
2015-11-15 22:01:05 -05:00
vershnik
96398ba30f
remove indexes overruled by primary key
...
There can be unique indexes automatically created for join column.
If join column is also primary key we should keep only primary key on this column.
Oracle does not allow having both unique index and primary key on the same column, it is useless for mysql too.
(Previously it was done by DBAL, but now it allows duplicate indexes)
2015-11-16 02:49:41 +00:00
Guilherme Blanco
c561223d1b
Merge pull request #1557 from gitname/patch-1
...
Reduce ambiguity in Entities description
2015-11-15 21:25:30 -05:00
gitname
8192d5bb3e
Reduce ambiguity in Entities description
2015-11-15 13:27:51 -08:00
Jan Langer
91ce78815f
Second level cache stores identifier with correct type even if findById is called with wrong identifier type
2015-11-14 11:17:16 +01:00
Guilherme Blanco
71bb27a62f
Merge pull request #1555 from doctrine/DDC-3979
...
[RFC] DDC-3979
2015-11-13 11:38:55 -05:00
Guilherme Blanco
e64f44ec9b
Fix one to one inverse side cached entity association key generation
2015-11-13 15:58:52 +00:00
Marco Pivetta
802cc82c8d
Merge pull request #1554 from tai2/fix_document_transactional
...
Fix a documentation error.
2015-11-13 07:00:30 +01:00
tai2
50d87bd111
Fix a documentation error.
2015-11-13 12:07:21 +09:00
Guilherme Blanco
3a44a3dada
Merge pull request #1551 from doctrine/DDC-3976
...
[RFC] DDC-3976
2015-11-12 10:21:37 -05:00
Marco Pivetta
3452f5ccc3
Merge pull request #1553 from OskarStark/patch-1
...
doc fix
2015-11-12 11:50:15 +01:00
Oskar Stark
d49cd4aa1e
doc fix
2015-11-12 11:45:37 +01:00
Guilherme Blanco
58992ad523
Fixed support for inverse side second level cache
2015-11-12 05:00:08 +00:00
Guilherme Blanco
089a0ac60b
Merge pull request #1552 from guiwoda/l2-invalid-collection-cache-key
...
Collection cache key is built differently on read than on write
2015-11-11 10:22:46 -05:00
Guido Contreras Woda
d57ecc12c0
Collection cache key is built differently on read than on write
2015-11-11 12:10:29 -03:00
Guilherme Blanco
1187c51a89
Merge pull request #1529 from tkleinhakisa/2.1-upgrade
...
Update Upgrade.md after minor bc break in 2.5.0
2015-11-08 22:54:20 -05:00
Guilherme Blanco
46dec5478a
Merge pull request #1505 from qu1m/master
...
Fixed issue with entity manager when using LockMode::NONE
2015-11-08 22:51:38 -05:00
Guilherme Blanco
49bb687aaf
Merge pull request #1540 from pantelm/master
...
[DDC-3711] Correct Error on manyToMany with composite primary key + add Tests
2015-11-08 22:43:36 -05:00
Guilherme Blanco
664925d7f4
Merge pull request #1550 from doctrine/cache-for-travis
...
[RFC] Added composer cache on travis
2015-11-08 22:41:48 -05:00
Guilherme Blanco
370dbf12de
Added composer cache on travis
2015-11-09 03:40:18 +00:00
Guilherme Blanco
3e0529db53
Merge pull request #1493 from alireza-m/master
...
Pass orderings, maxRresults and firstResult when call getHash
2015-11-08 22:36:06 -05:00
Guilherme Blanco
bad0f17c10
Merge pull request #1549 from doctrine/DDC-3697
...
[RFC] DDC-3697
2015-11-08 22:30:50 -05:00
Guilherme Blanco
443259f629
Some extra refinement over patch
2015-11-09 03:19:11 +00:00
Matthias Pigulla
b7bd42638d
Fix for DDC-3697 and DDC-3701
...
Also fix Lexer::match() so it does not accept T_WHERE when T_WITH is supposed to be matched. (DDC-3701)
2015-11-09 03:19:11 +00:00
Guilherme Blanco
ada97d55ce
Merge pull request #1375 from webimpress/fix/DDC-3671
...
DDC-3671 prevent duplicate unique index
2015-11-07 11:44:02 -05:00
Guilherme Blanco
6dfafad33c
Merge pull request #1547 from doctrine/fix-result-cache
...
[RFC] fixes result cache setting query caching
2015-11-07 11:22:14 -05:00
Alex Vasilenko
c8d2ac40f4
fixes result cache setting query caching
2015-11-07 16:14:54 +00:00
Guilherme Blanco
d7a3154954
Merge pull request #1397 from giosh94mhz/concat_expr_variable_arguments
...
Add Expr::concat support for multiple arguments
2015-11-07 10:45:04 -05:00
Guilherme Blanco
d88cf97bef
Merge pull request #1507 from deguif/fix-wrong-property
...
Fixed wrong property name
2015-11-07 10:09:06 -05:00
Marco Pivetta
28cebeca1c
Merge pull request #1407 from aivus/patch-1
...
Add return to removeMethodTemplate
2015-11-06 23:11:42 -05:00
Marco Pivetta
e7685c89da
Merge pull request #1405 from taueres/master
...
EntityManager#getReference throw ORMException for unrecognized id
2015-11-06 23:07:21 -05:00
Marco Pivetta
378f6546b4
Merge pull request #1545 from doctrine/general-fixes
...
[RFC] General fixes
2015-11-06 22:56:00 -05:00
Guilherme Blanco
843966ac50
General fixes across CS, type resolving, test fixes, etc
2015-11-07 03:55:05 +00:00
Marco Pivetta
9e085ca0b3
Merge pull request #1308 from z38/override-inversedby
...
[DDC-3579] Allow override of inversedBy
2015-11-05 15:10:43 -05:00
Marco Pivetta
2fa289edee
Merge pull request #1514 from Metabor/patch-2
...
check if collection is empty without loading it
2015-11-05 14:46:15 -05:00
z38
ff28507b88
Allow override of inversedBy
2015-11-05 12:11:29 +01:00
Marco Pivetta
2383ccfba5
Merge branch 'feature/#1354-one-to-many-orphan-removal'
...
Close #1354
2015-11-05 00:24:29 -05:00
Marco Pivetta
f097478437
#1354 - DDC-3644 - short array syntax
2015-11-05 00:13:19 -05:00
Marco Pivetta
a7ded16204
#1354 - DDC-3644 - s/protected/private
2015-11-05 00:11:43 -05:00
Guilherme Blanco
1587aac4ff
Added support for OneToMany with orphanRemoval. Replacing entire collection now deletes the replaced collection (scheduled for deletion). No event handling is done as it happens at DBAL level.
2015-11-05 00:08:44 -05:00
Marco Pivetta
06c194310a
Merge pull request #1310 from nicolas-grekas/patch-1
...
Allow symfony 3.0 components
2015-11-04 23:23:06 -05:00
Marco Pivetta
d39a73cce6
Merge pull request #1541 from aleeeftw/master
...
Minor docblock correction
2015-11-01 12:07:35 +01:00
aleeeftw
5481e0fb8b
Minor docblock correction
...
The documentation for the method ‘addJoinedEntityFromClassMetadata’ is
wrong. As we can see currently says you need to pass an object and that
is wrong. The $relation variable is passed to ‘addJoinedEntityResult’
which is using it as a ‘string’.
2015-11-01 10:43:03 +00:00
Pantel
43b2419a3c
[DDC-3711] add Test that check if the association key are composite
2015-10-31 17:19:39 +01:00
Pantel
7de2e04ccd
[DDC-3711] add Tests that check if the association key are composite
2015-10-31 17:15:06 +01:00
Pantel
96687e04a6
[DDC-3711] Correct Error on manyToMany with composite primary key
2015-10-31 16:02:14 +01:00
Steve Müller
b1451cda52
Merge pull request #1533 from sergeyz/patch-1
...
Fix argument type
2015-10-22 09:38:06 +02:00
Marco Pivetta
b15e8b79dc
Merge pull request #1536 from AngelFQC/patch-1
...
Minor - Fix PHP Doc - Update Expr.php
2015-10-20 15:16:25 -07:00
Angel Fernando Quiroz Campos
47441666df
Update Expr.php
2015-10-20 16:55:43 -05:00
Ilya Antipenko
60b80c95cc
Add phpdoc tests for addXxx() and removeXxx() methods
...
Add tests for return types for addXxx() and removeXxx() methods
2015-10-17 17:14:56 +03:00
Marco Pivetta
290dc8989d
Merge pull request #1534 from senkal/gramma-fix/start-sentence-with-capital-letter
...
Use capital letter at the beginning of a sentence
2015-10-11 21:49:07 +02:00
Marcin Sekalski
52817cedfc
Use capital letter and the beginning of a sentence
2015-10-11 13:59:09 +01:00
Sergey Zhuravel
e354ebb162
Fix argument type
2015-10-09 13:53:25 +03:00
Klein Thomas
8535e01115
Move to 2.5 section
2015-10-09 07:12:28 +00:00
Klein Thomas
e682f48422
Update Upgrade.md after minor bc break in 2.5.1
...
The introduction of the second parameter in EntityRepository#createQueryBuilder generates a runtime notice if you have a sub-class of EntityRepository that has a second parameter in the createQueryBuilder method
2015-10-09 07:10:07 +00:00
Marco Pivetta
e91bce5f2a
Merge pull request #1528 from sprain/fix-typo-doc
...
Fixed typo in 9.6.7 of docs
2015-10-05 16:45:19 -03:00
Manuel Reinhard
c86ab7d239
Fixed typo in 9.6.7 of docs
2015-10-05 21:43:03 +02:00
Marco Pivetta
88f43a947d
Merge pull request #1518 from guiwoda/custom-generator-field-builder
...
Added custom ID generator definition to the FieldBuilder
2015-10-04 19:56:17 -03:00
Marco Pivetta
dd2068777c
Merge pull request #1526 from zinovyev/break-on-autoloader-selected
...
Break on autoloader selected
2015-10-04 15:04:42 -03:00
Ivan Zinovyev
1ddb63c88a
Break on autoloader selected
2015-10-04 19:58:57 +03:00
Guido Contreras Woda
3a7d2da2e5
Added custom ID generator definition to the FieldBuilder
2015-10-02 13:51:07 -03:00
Marco Pivetta
5c6f0edb23
Merge pull request #1516 from brabeji/patch-1
...
Clarify @DiscriminatorMap requirement
2015-10-02 05:30:09 -03:00
Marco Pivetta
b5799ae569
Merge pull request #1523 from BenMorel/expr
...
Documentation and case fixes in QueryBuilder
2015-10-01 15:49:29 -03:00
Benjamin Morel
7d4016a757
Documentation and case fixes in QueryBuilder
2015-10-01 20:04:16 +02:00
Marco Pivetta
61ad1bd137
Merge pull request #1520 from maqnouch/patch-1
...
Updated year range
2015-09-30 07:12:43 -03:00
AQNOUCH Mohammed
d02b059269
Updated year range
2015-09-29 22:52:45 +00:00
Jiří Brabec
4b87f5827f
Clarify @DiscriminatorMap reqirement
...
When trying to setup MTI with doctrine, this was always the sentence where I stopped reading as it seems useless if you are forced to specify list of children when you don't even know them. Today I accidentaly read further and found out that this is not necessary.
2015-09-25 12:47:51 +02:00
Oliver Tischlinger
60beca3760
changes after code review
2015-09-25 10:44:30 +02:00
Oliver Tischlinger
03523c67d5
add Unit Test for isEmpty change in LazyCriteriaCollection
2015-09-24 11:39:14 +02:00
Oliver Tischlinger
3e26330c53
check if collection is empty without loading it
...
Actually isEmpty() is always loading the collection in LazyCriteriaCollection.
A lazy version should use the existing functionality of count() to check if there are no elements if the collection is not initialized.
2015-09-23 17:34:11 +02:00
Marco Pivetta
b055d78ea1
Merge pull request #1510 from webfactory/doctrine-cache-removed-DoctrineNamespaceCacheKey
...
Fix tests
2015-09-19 10:39:39 +02:00
Marco Pivetta
2242a4c652
Merge pull request #1511 from BlueM/master
...
Fix class name: AbstractCache -> CacheProvider
2015-09-19 10:22:44 +02:00
Carsten Blüm
42a500a73d
Fix class name: AbstractCache -> CacheProvider
2015-09-19 08:34:00 +02:00
Matthias Pigulla
84f51b68af
Fix tests
...
dd47003641 removes the 'DoctrineNamespaceCacheKey[]' entry from the cache. Thus, all tests counting cache entries were off by one.
2015-09-19 01:15:39 +02:00
François-Xavier de Guillebon
ae243643e5
Added test
2015-09-14 18:35:49 +02:00
François-Xavier de Guillebon
4b7d8511f8
Fixed wrong variable used as array key
2015-09-14 18:34:55 +02:00
François-Xavier de Guillebon
a18ff95fc4
Fixed wrong property name
2015-09-11 17:17:28 +02:00
Marco Pivetta
8b79fe9d9b
Merge pull request #1506 from Tobion/patch-1
...
Fix variable reference in phpdoc of ClassMetadataInfo
2015-09-11 09:51:12 +01:00
Tobias Schultze
c03996d3b3
Fix variable reference in phpdoc of ClassMetadataInfo
2015-09-11 00:19:18 +02:00
Giorgio Premi
16172534bb
Add Expr::concat support for multiple arguments
2015-09-10 17:01:09 +02:00
Quim Manrique
1dbacec0e4
Fixed issue with entity manager when using LockMode::NONE
2015-09-08 00:31:03 +02:00
Marco Pivetta
1b09bb75b0
Merge pull request #1504 from phansys/doc_uuid_generator_strategy_2
...
Updated docs for basic mapping
2015-09-06 02:08:52 +02:00
Javier Spagnoletti
2e2921690a
Updated docs for basic mapping
...
Added note about UUID identifier generator strategy, which was added in 2.3 version:
0a83560
2015-09-05 15:40:37 -03:00
Marco Pivetta
a0a0c731bb
Merge pull request #1457 from phansys/short_types
...
Updated syntax for "integer" and "boolean" types
2015-09-05 17:21:05 +02:00
Marco Pivetta
d1b24dfe12
Merge pull request #1500 from zeroedin-bill/docs-build-improvements
...
Update docs dependency install script and readme to target Ubuntu 14.04
2015-09-04 08:41:38 +01:00
Marco Pivetta
5c8cca2f44
Merge pull request #1485 from hasumedic/php-version-docs
...
Changed references from PHP6 to PHP7
2015-09-04 08:40:37 +01:00
Marco Pivetta
8aa0cdd0b9
Merge pull request #1483 from longkey1/fix-typo
...
Fix typo
2015-09-04 08:37:40 +01:00
Marco Pivetta
2d00a9bcbf
Merge pull request #1482 from bocharsky-bw/patch-1
...
Add type hint for entity manager
2015-09-04 08:34:35 +01:00
Marco Pivetta
29c2b807ce
Merge pull request #1474 from localheinz/fix/unused-imports
...
Fix: Remove unused imports
2015-09-04 08:30:46 +01:00
Marco Pivetta
41ee7e0f1a
Merge pull request #1444 from cezarykluczynski/tutorial-opening-tags-fix
...
Missing opening tags added in one of the tutorials
2015-09-04 08:24:29 +01:00
Marco Pivetta
b062ffdead
Merge pull request #1452 from TomasVotruba/patch-1
...
composer: dev is now by default
2015-09-04 08:22:29 +01:00
Bill Schaller
3e5bf819e3
Update docs dependency install script and readme to target Ubuntu 14.04
2015-09-03 13:58:40 -04:00
Steve Müller
233ebb0ba1
Merge pull request #1499 from issei-m/patch-2
...
minor: removed useless line breaks
2015-09-03 16:40:59 +02:00
Issei.M
df461601f7
removed useless line breaks
2015-09-03 17:55:14 +09:00
Benjamin Eberlei
2b3648c725
[DCOM-293] Fix security misconfiguration vulnerability allowing local remote arbitrary code execution.
2015-08-31 14:16:50 +02:00
Adrien Crivelli
93806a8036
Update DateTime cookbook code
...
It seems that existing code was outdated and lacked ``use`` statement in order to work correctly.
We also added instructions on how to configure the new type, since it may not be straightforward for newcomers.
2015-08-27 15:39:26 +09:00
Alireza Meskin
dfa874642a
Pass orderings, maxRresults and firstResult when call getHash
2015-08-16 15:22:06 +04:30
Nicolas Grekas
df820a5695
Fix misleading docblock example
2015-08-14 14:35:25 +02:00
Bill Schaller
f88896cc9d
Merge pull request #1463 from ehimen/paginate-order-by-subselect
...
Fixed issue when paginator orders by a subselect expression
2015-08-04 14:17:50 -04:00
Egidijus Jucevičius
d4d9a2ba3c
Support any ordering of fields in partial object query with embeddable [DDC-3864]
2015-08-04 10:56:50 +03:00
Alex Salguero
5393bc9956
Removed outdated PHP6 reference in "best practices" docs.
...
Changed references from PHP6 to PHP7 in tests.
2015-07-31 12:25:19 +01:00
Bocharsky Victor
dbd3fa4501
Add type hint for entity manager
2015-07-30 15:32:04 +03:00
longkey1
a3b1f85fd4
typo
2015-07-30 13:16:55 +09:00
mike
1d6adcaf4a
Remove the execution bit on the bin/doctrine.php
2015-07-29 08:41:33 +02:00
Marco Pivetta
71b1dde096
Merge pull request #1473 from ilyar/docs_fix_ref_and_title
...
Docs fix ref and title
2015-07-26 01:19:44 +03:00
Andreas Möller
8a9f6849a2
Fix: Remove unused imports
2015-07-24 12:48:34 +02:00
Ilya Rogov
f10f4b7c52
Fixed WARNING: Title underline too short
2015-07-24 11:09:33 +03:00
Ilya Rogov
bb8f1c77cc
Pretty Ref and Fixed WARNING: Duplicate explicit target name
2015-07-24 11:02:42 +03:00
Adrien Crivelli
57ca849848
Add test for MariaDB 5.5 and 10.1 on Travis
...
This use the brand new supported addon mariadb (not yet officially announced).
This is unfortunately a bit verbose, but I don't think there is any
alternative because we cannot install the addon when testing against mysql
otherwise it would overwrite mysql install.
2015-07-23 12:51:21 +09:00
Andy Cook
26c295b06b
Added non-functional tests for row number over function subselect expression fix; syntax fixes.
2015-07-17 13:24:19 +01:00
Marco Pivetta
f5e79fa0c0
Merge pull request #1466 from Majkl578/travis-container-infrastructure
...
Travis: Switch to container-based infrastructure
2015-07-16 22:18:33 +01:00
Michael Moravec
e87c94052d
Travis: Switch to container-based infrastructure
2015-07-16 22:47:33 +02:00
Marco Pivetta
1370424fed
Merge pull request #1400 from photodude/patch-1
...
mysqli is supported by HHVM
2015-07-16 21:08:32 +01:00
Marco Pivetta
ad056ebdc6
Merge pull request #1462 from DHager/document_transactional
...
Add a note to documentation for transactional()'s return values
2015-07-16 20:56:04 +01:00
Marco Pivetta
506df640b5
Merge pull request #1433 from goetas/slc-check-to-classmetadatainfo
...
Check for non-cacheable entities on metadata level, not at runtime
2015-07-16 20:41:30 +01:00
Asmir Mustafic
3a7b2991e8
PSR-2 CS improvements
2015-07-16 16:20:36 +02:00
Andy Cook
61488d955e
Fixed issue when paginator orders by a subselect expression on platforms supporting ROW_NUMBER OVER() function.
2015-07-16 11:20:22 +01:00
Darien Hager
72d848901b
Add reminder to README for initializing git submodules
2015-07-15 18:59:14 -07:00
Darien Hager
8503c1247f
Document return-value substitution in EntityManager::transactional()
2015-07-15 18:58:18 -07:00
Marco Pivetta
6bf6db3533
Merge pull request #1451 from TomasVotruba/psr-4
...
composer: autoload via PSR-4
2015-07-15 22:24:59 +01:00
Marco Pivetta
70a22b6a73
Merge pull request #1390 from deviantintegral/chaincache-docs
...
Document the ChainCache class
2015-07-15 21:58:20 +01:00
Marco Pivetta
06a00cf073
Merge branch 'hotfix/#1387-DDC-3699-do-not-merge-managed-uninitialized-entities'
...
Close #1387
2015-07-15 21:51:21 +01:00
Marco Pivetta
eb5d87cd94
DDC-3699 - #1387 - leveraging the OrmFunctionalTestCase API
2015-07-15 21:51:04 +01:00
Marco Pivetta
12183b7e6c
DDC-3699 - #1387 - catching specific exceptions
2015-07-15 21:47:37 +01:00
Marco Pivetta
74883e535f
DDC-3699 - #1387 - simpifying tests, clarifying on test method names
2015-07-15 21:46:23 +01:00
Lenard Palko
cbfd71cec6
Added test cases for both one-to-one and one-to-many cases.
2015-07-15 21:26:45 +01:00
Lenard Palko
977f0a5b5c
Fix skipping properties if they are listed after a not loaded relation.
2015-07-15 21:26:45 +01:00
Marco Pivetta
67cda0cd75
Merge branch 'hotfix/#1381-wakeup-reflection-with-embeddable-and-staticreflection-serialization-fix'
...
Close #1381
2015-07-15 20:49:40 +01:00
Nico Vogelaar
b3af5590f9
Fixes ClassMetadata wakeupReflection with embeddable and StaticReflectionService
2015-07-15 20:49:16 +01:00
Marco Pivetta
34eb4fdec5
Merge branch 'hotfix/#1380-non-cache-persister-bug'
...
Close #1380
2015-07-15 20:37:30 +01:00
Marco Pivetta
56cedc5d4f
DDC-3683 - #1380 - reverting BC break, annotating correct types, cs fixes
2015-07-15 20:35:21 +01:00
Darien Hager
77d03ec745
Remove runtime assertion
2015-07-15 20:29:44 +01:00
Darien Hager
6f1107c4ee
Clarify state-changes, replace array_key_exists() with isset() for speed
2015-07-15 20:29:43 +01:00
Darien Hager
1659fab44f
Whitespace formatting tweaks
2015-07-15 20:29:43 +01:00
Darien Hager
d0892b21fb
Remove now-superfluous EntityManager check
2015-07-15 20:29:43 +01:00
Darien Hager
6d6a6a7fbd
Refactor LoadClassMetadataEventArgs to ensure it contains an EntityManager
2015-07-15 20:29:43 +01:00
Darien Hager
e8854b68bb
Change the test listener than layers on second-level-caching so that it is more conservative, only turning on caching-associations when it knows the target entity is cache-able.
2015-07-15 20:29:43 +01:00
Darien Hager
cddbbf00b4
Stumbled across a bug where signatures didn't match, but also the current persister-type didn't support getCacheRegion(). Unsure of exact mechanism, but clearly the constructor doesn't take the second argument anyway, may be old code.
2015-07-15 20:29:43 +01:00
Marco Pivetta
4b1851467b
Merge pull request #1458 from phansys/patch-1
...
[Paginator] Fixed boolean casting
2015-07-15 08:11:43 +01:00
Javier Spagnoletti
cedff7715e
[Paginator] Fixed boolean casting in Paginator
...
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
2015-07-14 16:48:42 -03:00
Javier Spagnoletti
97cc49033e
Updated syntax for ``integer` and `boolean`` types
...
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Used short syntax for ```integer``` and ```boolean``` types.
**Before**
```php
/**
* @var integer
*
* @ORM\Column(name="some_integer_field", type="integer")
*/
private $someIntegerField;
/**
* @var boolean
*
* @ORM\Column(name="some_boolean_field", type="boolean")
*/
private $someBooleanField;
```
**After**
```php
/**
* @var int
*
* @ORM\Column(name="some_integer_field", type="integer")
*/
private $someIntegerField;
/**
* @var bool
*
* @ORM\Column(name="some_boolean_field", type="boolean")
*/
private $someBooleanField;
```
2015-07-14 15:30:13 -03:00
xoeoro
44557a5afa
Update ExprTest.php
...
expr()->countDistinct allows to create COUNT(DISTINCT) expression with mulltiple fields but parser requires only one field.
\Doctrine\ORM\Query\Parser::AggregateExpression
some body, please, fix this problem
2015-07-13 10:45:17 +03:00
Dick Marinus
4a39754e76
unsigned is in fieldMapping['options']
2015-07-09 20:54:04 +02:00
Tomáš Votruba
e0872c55a9
composer: dev is now by default
2015-07-08 14:31:43 +02:00
Tomas Votruba
726383cafb
composer: autoload via PSR-4
2015-07-08 01:51:16 +02:00
David Fuhr
de424be9f7
[DX] Link annotation ref to locking explanation
...
The annotation reference contained no cross reference to the great
transaction and concurrency page. But this might be very useful for the
reader.
2015-07-07 18:45:56 +02:00
Guilherme Blanco
33c2ae465d
Merge pull request #1449 from dunglas/patch-1
...
minor: code quality in Paginator
2015-07-07 11:03:03 -04:00
Kévin Dunglas
abf6b8bee5
minor: Code quality in Paginator
2015-07-07 10:09:06 +02:00
Guilherme Blanco
96b065b282
Merge pull request #1447 from krispypen/patch-1
...
Fix second level caching for queries with multiple joins
2015-07-06 09:49:35 -04:00
Kris Pypen
5780f3209c
wrote a Test for second level cache with multiple levels of associations
2015-07-06 14:18:38 +02:00
Kris Pypen
a2a400b8fb
Fix second level caching for queries with multiple joins
...
The $metadata of the main entity is not always the metadata you need here, for example when you do join A with B and then B with C. For the second join it was using the metadata from A.
2015-07-03 14:45:25 +02:00
Cezary Kluczyński
793fe9d2d1
Missing opening tags added in one of the tutorials
2015-07-01 19:49:11 +02:00
Dick Marinus
9715f3dfcc
add field options as array
2015-06-30 19:42:22 +02:00
Matthew Turland
af2f6a6fff
Corrected bad class reference in "Adding own commands"
2015-06-29 22:58:48 -05:00
David Adams
6fa20062f3
allow ManyToManyPersister to handle identification types
2015-06-23 17:55:56 +00:00
Asmir Mustafic
32f0fefec7
Test XML driver with failing SLC mapping
2015-06-20 14:33:36 +02:00
Asmir Mustafic
4da0ee9db8
Test PHP driver with failing SLC mapping
2015-06-20 14:33:36 +02:00
Asmir Mustafic
5f2922b3a7
Test annotation driver with failing SLC mapping
2015-06-20 14:32:15 +02:00
Asmir Mustafic
012367a371
Removed runtime check test for non-cacheable entities
2015-06-20 14:32:14 +02:00
Asmir Mustafic
acbda4bc0e
YAML driver uses getAssociationCacheDefaults for SLC mapping
2015-06-20 14:32:14 +02:00
Asmir Mustafic
7d64be915c
XML driver uses getAssociationCacheDefaults for SLC mapping
2015-06-20 14:32:14 +02:00
Asmir Mustafic
f4f32a5213
Annotation driver uses getAssociationCacheDefaults for SLC mapping
2015-06-20 14:32:14 +02:00
Asmir Mustafic
11be4fae86
Do not check at runtime for non-cacheable associations
2015-06-20 14:32:14 +02:00
Asmir Mustafic
c685255fe3
Check for non-cacheable associations directly on the class metada info
2015-06-20 14:32:14 +02:00
Asmir Mustafic
6a428c6064
Allow to retreive association cache defaults
2015-06-20 14:32:14 +02:00
Bill Schaller
6b3056ff8c
Merge pull request #1430 from michael-lavaveshkul/master
...
"INSTANCE OF" example doesn't match description.
2015-06-18 10:30:14 -04:00
michael-lavaveshkul
073f570c67
Updated "INSTANCE OF" example code.
2015-06-17 22:15:17 -07:00
Marco Pivetta
37a409aa1f
Merge pull request #1429 from hallabro/update-preupdate-documentation
...
Update events.rst to reflect behaviour of preUpdate
2015-06-17 08:25:37 +01:00
Robin Hallabro
63a543d6a0
Update events.rst to reflect behaviour of preUpdate
2015-06-17 07:57:11 +02:00
Thomas Lallement
f41e59258c
Failing Test - Paginator with sorted collection
2015-06-16 16:34:37 -04:00
Benjamin Eberlei
ae5b8178e7
Merge pull request #1406 from XitasoChris/patch-1
...
add default value for GeneratedValue
2015-06-16 22:25:49 +02:00
Benjamin Eberlei
5ae40d571a
Merge pull request #1409 from haeber/patch-1
...
Added PHPDoc return type false of next method in Hydration/IterableResult
2015-06-16 22:21:20 +02:00
Benjamin Eberlei
8d1be42924
[DDC-3741] Add test for AbstractQuery#setHydrationCacheProfile(null)
2015-06-16 21:56:25 +02:00
Benjamin Eberlei
6423a33a23
Merge pull request #1411 from icambridge/patch-1
...
Allow null to be passed to setHydrationCacheProfile
2015-06-16 21:54:08 +02:00
Benjamin Eberlei
545e448024
Merge pull request #1416 from Restless-ET/patch-1
...
[2.5][Bug] Fix ConvertDoctrine1Schema->getMetadata
2015-06-16 21:38:35 +02:00
Benjamin Eberlei
5aded88cf6
Merge pull request #1418 from mageekguy/patch-2
...
Remove (useless?) call to parser::getLexer()
2015-06-16 21:36:14 +02:00
Benjamin Eberlei
1e7e8f216a
Merge pull request #1419 from c960657/cancel-orphan-removal
...
[DDC-3382] Allow orphan removal to be cancelled
2015-06-16 21:23:20 +02:00
Benjamin Eberlei
ac03c9d851
Add section about entities, proxies and reflection to "Limitations and Known Issues" chapter.
2015-06-16 21:11:29 +02:00
Christian Schmidt
96dbecec24
[DDC-3382] Allow orphan removal to be cancelled
2015-06-12 16:44:13 +02:00
Marco Pivetta
14ff7f50cf
Updating contributing notes to latest composer standard
2015-06-11 14:08:34 +01:00
Frédéric Hardy
b6d29c8b72
Remove (useless?) call to parser::getLexer()
...
The `$lexer` variable is not used, the method `parser::getLexer()` is just a dumb getter and do nothing, so in my opinion, the call to `parser::getLexer()` is useless in this context.
Can you confirm?
2015-06-08 16:04:58 +02:00
Restless-ET
b33612f9e7
[2.5][Bug] Fix ConvertDoctrine1Schema->getMetadata
...
This bug was introduced at #1205 while resolving #1200 .
2015-06-05 17:08:50 +01:00
Iain Cambridge
8625ca5187
Allow null to be passed to setHydrationCacheProfile
...
Currently null can be passed and is set as default, however if you do this you get an exception. This allows null to be passed and set.
There is an if statement later on to see if $this->_hydrationCacheProfile is null so it seems logical you can set it to be null.
2015-05-20 15:10:01 +02:00
Thomas Häber
d92785811b
Added PHPDoc return type false of next method
...
Because hydrateRow can return false, too. The PHPDoc return type of the next method has return false in addition to array.
2015-05-15 12:06:56 +02:00
Logan Bailey
272e8aa6f1
[doc] Remove unused variable from sample code
...
Removes lexer since it's not used.
2015-05-14 11:51:01 -07:00
Ilya Antipenko
6a98f0391d
Add return to removeMethodTemplate
2015-05-13 15:52:38 +03:00
Christopher Gross
702b8b3309
add default value for GeneratedValue
2015-05-12 14:16:02 +02:00
Sergio Santoro
8c6607532b
EntityManager#getReference throw ORMException for unrecognized id
...
- Unreachable statements have been removed
- Throw ORMException for unrecognized identifier field (same
behavior as EntityManager#find)
2015-05-10 00:28:28 +02:00
Marco Pivetta
900b55d16a
Merge pull request #1404 from stephan281094/typo
...
Fix PHPDoc typo
2015-05-07 13:36:20 +01:00
Stephan de Vries
f61526d3ff
Fix PHPDoc typo
2015-05-07 14:05:20 +02:00
photodude
4d6dfb2b81
PostgreSQL currently unsupported by HHVM
...
- Supported but you have to [install an officially supported dependency.](https://github.com/PocketRent/hhvm-pgsql/tree/releases )
2015-05-06 19:45:36 -06:00
photodude
652f999e83
pgsql and mysqli are supported by HHVM
...
- reference to [Known compatible extensions for HHVM](http://docs.hhvm.com/manual/en/extensions.alphabetical.php )
2015-05-06 19:45:24 -06:00
Marco Pivetta
330f88e44b
Merge pull request #1401 from stof/patch-2
...
Remove HHVM-nightly builds
2015-05-05 10:03:25 +01:00
Christophe Coevoet
1b9e197ff3
Remove HHVM-nightly builds
...
hhvm-nightly is not available anymore on Travis because HHVM dropped support for Ubuntu Precise, which is still used by Travis.
2015-05-05 10:41:44 +02:00
Wojciech Zylinski
af2295b73a
Switch to relationToTargetKeyColumns when matching non-owning side with Criteria. Fixes DDC-3719.
2015-05-03 18:39:51 +01:00
Adam Prager
961bff6a80
Initializing embeddables doc
2015-04-27 17:23:40 +02:00
Andrew Berry
f91fadd00c
Not all cache drivers are explicitly documented.
2015-04-19 20:51:46 -04:00
Andrew Berry
3d0f44f596
Document the ChainCache class.
2015-04-19 20:47:36 -04:00
Steve Müller
71d134fcc0
Merge pull request #1379 from holtkamp/patch-1
...
Added missing 'new' keyword for logger instantiation
2015-04-18 11:13:31 +02:00
Steve Müller
b8ef6cfd2f
Merge pull request #1384 from TomasVotruba/patch-1
...
cs
2015-04-18 11:07:17 +02:00
Steve Müller
2706812b37
Merge pull request #1385 from TomasVotruba/patch-2
...
duplicated param in phpdoc
2015-04-18 11:03:09 +02:00
Steve Müller
5ac291d0f4
Merge pull request #1386 from TomasVotruba/patch-3
...
PersisterException: missing license added
2015-04-18 10:57:12 +02:00
Tomáš Votruba
b3b0f6bd5b
PersisterException: missing license added
2015-04-17 12:46:52 +02:00
Tomáš Votruba
6fae618669
duplicated param in phpdoc
2015-04-17 10:13:40 +02:00
Tomáš Votruba
a71f2ba76f
cs
2015-04-17 10:12:18 +02:00
Guilherme Blanco
5f18618355
Merge pull request #1382 from holtkamp/patch-second-level-cache-association-hydration
...
Patch second level cache association hydration
2015-04-14 11:37:54 -04:00
Menno Holtkamp
5f891435f1
Use early return
2015-04-14 16:02:36 +02:00
Menno Holtkamp
34b6ce9259
Introduced getCacheEntryKey() to combine region name and cache key
2015-04-14 09:52:25 +02:00
Menno Holtkamp
dbc29d28d2
Simplified way to fetch multiple entries when index does not matter
2015-04-14 09:47:57 +02:00
Menno Holtkamp
012f33524b
Fixed some typo's
2015-04-14 09:43:22 +02:00
Menno Holtkamp
c236a67096
Used index as key to retrieve proper entry
2015-04-13 23:33:09 +02:00
Menno Holtkamp
74964e7d85
Improved testing region->getMultiple()
2015-04-13 23:31:19 +02:00
Menno Holtkamp
eef81b6eb9
Added missing 'new' keyword for logger instantiation
2015-04-09 15:06:41 +02:00
Bill Schaller
3f84be7b7c
Merge pull request #1377 from fprochazka/bugfix/paginator
...
LimitSubqueryOutputWalker: fix aliasing of property in OrderBy from MappedSuperclass
2015-04-08 20:05:51 -04:00
Filip Procházka
e501137d1a
LimitSubqueryOutputWalker: fix aliasing of property in OrderBy from MappedSuperclass
2015-04-09 01:43:05 +02:00
Filip Procházka
192da14842
Failing test case for broken paginator case
2015-04-09 01:42:46 +02:00
Michał Bundyra
699a6e1783
prevent duplicate unique index
2015-04-08 10:49:21 +01:00
Marco Pivetta
2c90930068
Merge pull request #1374 from mbeccati/fix-DDC767Test-php7-pg94
...
Fix DDC767Test failing on php7 + pg94
2015-04-06 04:22:24 +01:00
Marco Pivetta
6a41b73318
Merge pull request #1373 from aivus/patch-1
...
Add note about "symfony/yaml" dependency for yml mappings
2015-04-06 04:09:51 +01:00
Matteo Beccati
e7397ff62e
Fix DDC767Test failing on php7 + pg94
...
The failure happens when running the full suite or even just:
phpunit tests/Doctrine/Tests/ORM/Functional/Ticket
2015-04-05 21:50:25 +02:00
Ilya Antipenko
a14517dc9d
Add note about "symfony/yaml" dependency for yml mappings
2015-04-05 15:26:12 +03:00
Bill Schaller
354ccdc58b
Merge pull request #1361 from Ocramius/hotfix/array-property-initialization
...
Hotfix: Reverting BC Break - PersistentCollection should accept `null` and `array` as constructor parameter
2015-04-04 20:26:19 -04:00
Marco Pivetta
ea824f39a9
Merge branch 'hotfix/#1365-query-dql-function-test-determinism'
2015-04-05 00:09:47 +01:00
Bill Schaller
f93f601715
fix rare query test failures due to nondeterminism without order by clause
2015-04-05 00:09:38 +01:00
Marco Pivetta
19e24eeb23
Merge pull request #1369 from DavidPrevot/clean-up
...
Drop empty file
2015-04-05 00:03:10 +01:00
Marco Pivetta
63d86c2e0f
Merge pull request #1371 from TomasVotruba/patch-2
...
Readme: drop "Downloads" link
2015-04-05 00:02:02 +01:00
Tomáš Votruba
c162b593be
Readme: drop "Downloads" link
...
Probably deprecated option
2015-04-05 00:38:43 +02:00
Marco Pivetta
a661a7371d
Merge pull request #1370 from TomasVotruba/vendor-clean
...
drop doctrine/common git submodule
2015-04-04 22:49:20 +01:00
Tomas Votruba
8f758dc932
drop doctrine/common git submodule
2015-04-04 22:43:50 +02:00
David Prévot
6f033a2c47
Drop empty file
2015-04-04 15:37:59 -04:00
Marco Pivetta
c7c6822c56
Merge pull request #1368 from TomasVotruba/patch-2
...
Readme: coverage badge for 2.4 added
2015-04-04 18:49:35 +01:00
Tomáš Votruba
257bf81a3b
Readme: coverage badge for 2.4 added
2015-04-04 19:47:43 +02:00
Marco Pivetta
fb055b5eab
Merge pull request #1366 from shieldo/patch-3
...
[Documentation] typo fixes
2015-04-04 00:29:33 +01:00
Douglas Greenshields
fb96a65733
[Documentation] typo fixes
2015-04-04 00:22:00 +01:00
Bill Schaller
052b8e802f
Merge pull request #1364 from shieldo/embeddedables
...
[Documentation] correct naming of Embeddable Objects feature
2015-04-03 12:08:37 -04:00
Douglas Greenshields
16a3d0d769
[Documentation] correct naming of Embeddable Objects feature
2015-04-03 17:05:47 +01:00
Bill Schaller
4a358284f6
Merge pull request #1363 from shieldo/patch-2
...
merged #1363
2015-04-03 10:53:48 -04:00
Douglas Greenshields
08b66f09b1
remove disclaimer about ORM 2.5 being in beta
2015-04-03 15:52:22 +01:00
Marco Pivetta
2a81adc1fc
Correcting ObjectHydrator logic: if an array is a default value for a collection-valued property, it should be cast to a Collection
2015-04-03 15:28:53 +01:00
Marco Pivetta
f0d2e8d150
Correcting static introspection issue in cache specific tests (null was being passed to a PersistentCollection)
2015-04-03 15:28:13 +01:00
Marco Pivetta
95b128ce8f
Removing irrelevant tests (as per discussion with @guilhermeblanco and @stof
2015-04-03 15:27:13 +01:00
Marco Pivetta
d49c907934
a PersistentCollection should only allow another collection as a wrapped collection
2015-04-03 15:26:38 +01:00
Tomas Votruba
e5efc23642
Readme: renamed to standard md suffix
2015-04-03 14:55:28 +02:00
Tomas Votruba
23fb24e2be
Readme: nicer badges
2015-04-03 14:55:09 +02:00
Marco Pivetta
ad5de6f67a
Merge pull request #1362 from TomasVotruba/patch-2
...
Readme: badges for 2.5 added; 2.3- dropped
2015-04-03 13:49:55 +01:00
Tomáš Votruba
8a4d1e2cf6
Readme: badges for 2.5 added; 2.3- dropped
...
If I understand [2.5 release info](https://github.com/doctrine/doctrine2/releases/tag/v2.5.0 ) correctly, 2.4 will have last bugfix, then security fixes. I suppose then 2.3 and lower are in EOL, thus not needed to check badge for. Also they don't have any branch.
2015-04-03 14:16:48 +02:00
Marco Pivetta
1993aecd4c
Reverting BC break: PersistentConnection#__construct() now accepts null|array|Collection again
2015-04-02 23:45:46 +01:00
Marco Pivetta
6b5188fee8
FQCN reference (class was not imported correctly)
2015-04-02 23:45:12 +01:00
Marco Pivetta
670972d5c3
PersistentCollection should still accept null and array as constructor argument, as it did before
2015-04-02 23:44:12 +01:00
Marco Pivetta
3bc3aeeb52
Minor docblock correction (discovered during testing)
2015-04-02 23:43:41 +01:00
Marco Pivetta
21b70577d3
Hydration of fetch-joined results fails when an entity has a default value of array for the collection property
2015-04-02 23:43:16 +01:00
Marco Pivetta
6b94dc61c6
Merge branch 'hotfix/#1360-docs-fix-misleading-embeddable-documentation-prefix'
2015-04-02 23:25:02 +01:00
Nicolas Grekas
bad6593460
Allow symfony 3.0 components
...
Tests should tell if any deprecated interfaces of Symfony are used. If not, then the bundle is defacto compatible with 3.0
2015-02-22 20:13:44 +01:00