[PR #10] [CLOSED] fixed mixed content errors in patch preview #10

New Issue

admin · 2026-01-24T11:41:15+01:00

admin commented

2026-01-24 11:41:15 +01:00

📋 Pull Request Information

Original PR: https://github.com/php/web-doc-editor/pull/10
Author: @staabm
Created: 4/10/2017
Status: ❌ Closed

Base: master ← Head: preview-https

📝 Commits (1)

2061099 fixed mixed content errors in patch preview

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 js/ui/cmp/MainPanel.js (+3 -3)

📄 Description

I guess this patch fixes my mixed content errors I see in firefox nightly.

I found the "same mistake" also in main-all-debug.js and in main-all.js but I guess those files are build from the other source files. If I am wrong please give me a ping and I will patch those the same way.

Repro:

open https://edit.php.net in FF nightly (guess the same for the stable FF)
"Patches for review"
open a patch you already sent into the queue by right click "view diff" (context menu)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/php/web-doc-editor/pull/10 **Author:** [@staabm](https://github.com/staabm) **Created:** 4/10/2017 **Status:** ❌ Closed **Base:** `master` ← **Head:** `preview-https` --- ### 📝 Commits (1) - [`2061099`](https://github.com/php/web-doc-editor/commit/206109974fdfbb5538fc28d11e36b58a5211f64d) fixed mixed content errors in patch preview ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `js/ui/cmp/MainPanel.js` (+3 -3) </details> ### 📄 Description I guess this patch fixes my mixed content errors I see in firefox nightly. I found the "same mistake" also in `main-all-debug.js` and in `main-all.js` but I guess those files are build from the other source files. If I am wrong please give me a ping and I will patch those the same way. ![image](https://cloud.githubusercontent.com/assets/120441/24850362/01f41f28-1dd0-11e7-8791-860e30cf02db.png) Repro: - open https://edit.php.net in FF nightly (guess the same for the stable FF) - "Patches for review" - open a patch you already sent into the queue by right click "view diff" (context menu) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-24 11:41:15 +01:00

admin referenced this issue

2026-01-24 11:41:15 +01:00

[PR #10] fixed mixed content errors in patch preview #15

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: php/web-doc-editor#10