php/web-doc-editor
1
0
Fork 0
mirror of https://github.com/php/web-doc-editor.git synced 2026-03-24 09:12:07 +01:00
Code Issues 12 Packages Projects Releases Wiki Activity

[PR #10] fixed mixed content errors in patch preview #15

New Issue
Closed
opened 2026-01-24 11:41:15 +01:00 by admin · 0 comments
admin commented 2026-01-24 11:41:15 +01:00
Owner
Copy Link

Original Pull Request: https://github.com/php/web-doc-editor/pull/10

State: closed
Merged: No

I guess this patch fixes my mixed content errors I see in firefox nightly.

I found the "same mistake" also in main-all-debug.js and in main-all.js but I guess those files are build from the other source files. If I am wrong please give me a ping and I will patch those the same way.

image

Repro:

  • open https://edit.php.net in FF nightly (guess the same for the stable FF)
  • "Patches for review"
  • open a patch you already sent into the queue by right click "view diff" (context menu)
**Original Pull Request:** https://github.com/php/web-doc-editor/pull/10 **State:** closed **Merged:** No --- I guess this patch fixes my mixed content errors I see in firefox nightly. I found the "same mistake" also in `main-all-debug.js` and in `main-all.js` but I guess those files are build from the other source files. If I am wrong please give me a ping and I will patch those the same way. ![image](https://cloud.githubusercontent.com/assets/120441/24850362/01f41f28-1dd0-11e7-8791-860e30cf02db.png) Repro: - open https://edit.php.net in FF nightly (guess the same for the stable FF) - "Patches for review" - open a patch you already sent into the queue by right click "view diff" (context menu)
admin added the pull-request label 2026-01-24 11:41:15 +01:00
admin closed this issue 2026-01-24 11:41:15 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: php/web-doc-editor#15
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?