[PR #4] [MERGED] Removing dist/ & testing against Stimulus 3 #4

New Issue

2026-01-24T13:04:36+01:00

admin commented

2026-01-24 13:04:36 +01:00

📋 Pull Request Information

Original PR: https://github.com/symfony/stimulus-testing/pull/4
Author: @weaverryan
Created: 9/27/2021
Status: ✅ Merged
Merged: 11/24/2021
Merged by: @tgalopin

Base: main ← Head: stimulus3

📝 Commits (1)

3c7697a Removing dist/ & testing against Stimulus 3

📊 Changes

8 files changed (+15 additions, -56 deletions)

View changed files

📝 .babelrc (+1 -2)
📝 .github/workflows/test.yaml (+2 -2)
📝 README.md (+2 -4)
➖ dist/index.js (+0 -30)
📝 package.json (+3 -10)
📝 setup.js (+1 -1)
📝 src/setup.js (+4 -5)
📝 test/controller.test.js (+2 -2)

📄 Description

Hi!

This was mainly motivated to add support for Stimulus 3... but I think the library already supports it just fine, as this library never actually imports Stimulus itself (other than in a test file).

So, this PR includes a number of other "chores" that we should handle:

The dist/ directory is not needed, because this is used purely as a node package. Babel IS still there, because it's used by jest to transform the test controller file.
The src/setup.js file was missing (there was a dist/setup.js file but the original source file was missing - but easily reproduceable).
We're now testing against Stimulus 3.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/symfony/stimulus-testing/pull/4 **Author:** [@weaverryan](https://github.com/weaverryan) **Created:** 9/27/2021 **Status:** ✅ Merged **Merged:** 11/24/2021 **Merged by:** [@tgalopin](https://github.com/tgalopin) **Base:** `main` ← **Head:** `stimulus3` --- ### 📝 Commits (1) - [`3c7697a`](https://github.com/symfony/stimulus-testing/commit/3c7697ace8d259e90c6022d9623efa347605d881) Removing dist/ & testing against Stimulus 3 ### 📊 Changes **8 files changed** (+15 additions, -56 deletions) <details> <summary>View changed files</summary> 📝 `.babelrc` (+1 -2) 📝 `.github/workflows/test.yaml` (+2 -2) 📝 `README.md` (+2 -4) ➖ `dist/index.js` (+0 -30) 📝 `package.json` (+3 -10) 📝 `setup.js` (+1 -1) 📝 `src/setup.js` (+4 -5) 📝 `test/controller.test.js` (+2 -2) </details> ### 📄 Description Hi! This was mainly motivated to add support for Stimulus 3... but I think the library already supports it just fine, as this library never actually *imports* Stimulus itself (other than in a test file). So, this PR includes a number of other "chores" that we should handle: * The `dist/` directory is not needed, because this is used purely as a node package. Babel IS still there, because it's used by jest to transform the test controller file. * The `src/setup.js` file was missing (there was a `dist/setup.js` file but the original source file was missing - but easily reproduceable). * We're now testing against Stimulus 3. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-24 13:04:36 +01:00

admin closed this issue

2026-01-24 13:04:37 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: symfony/stimulus-testing#4