Merge branch '3.4' into 4.2

* 3.4: minor: the meaning of the data breach was not correct Optimize SVGs property normalizer should also pass format and context to isAllowedAttribute
Optimize SVGs
2026-03-25 09:42:20 +01:00 · 2019-04-11 13:27:41 +02:00 · 2019-04-11 11:48:14 +02:00 · 2019-04-07 20:00:57 +02:00 · 2019-04-07 14:43:40 +02:00 · 2019-04-07 11:56:43 +02:00
2 changed files with 9 additions and 5 deletions
--- a/ExceptionHandler.php
+++ b/ExceptionHandler.php
--- a/Tests/ErrorHandlerTest.php
+++ b/Tests/ErrorHandlerTest.php
@@ -481,7 +481,7 @@ class ErrorHandlerTest extends TestCase

    public function testHandleErrorException()
    {
-        $exception = new \Error("Class 'Foo' not found");
+        $exception = new \Error("Class 'IReallyReallyDoNotExistAnywhereInTheRepositoryISwear' not found");

        $handler = new ErrorHandler();
        $handler->setExceptionHandler(function () use (&$args) {
@@ -491,7 +491,7 @@ class ErrorHandlerTest extends TestCase
        $handler->handleException($exception);

        $this->assertInstanceOf('Symfony\Component\Debug\Exception\ClassNotFoundException', $args[0]);
-        $this->assertStringStartsWith("Attempted to load class \"Foo\" from the global namespace.\nDid you forget a \"use\" statement", $args[0]->getMessage());
+        $this->assertStringStartsWith("Attempted to load class \"IReallyReallyDoNotExistAnywhereInTheRepositoryISwear\" from the global namespace.\nDid you forget a \"use\" statement", $args[0]->getMessage());
    }

    /**
Author	SHA1	Message	Date
Nicolas Grekas	2d279b6bb1	Merge branch '3.4' into 4.2 * 3.4: minor: the meaning of the data breach was not correct Optimize SVGs property normalizer should also pass format and context to isAllowedAttribute	2019-04-11 13:27:41 +02:00
Martijn Cuppens	681afbb264	Optimize SVGs	2019-04-11 11:48:14 +02:00
Christian Flothmann	f90c108a59	Merge branch '3.4' into 4.2 * 3.4: fix PHPUnit 4.8 compatibility [Debug] Fixed error handling when an error is already handled when another error is already handled (5) sync validator translations	2019-04-07 20:00:57 +02:00
Grégoire Pineau	63b4ddb7c6	[Debug] Fixed error handling when an error is already handled when another error is already handled (5)	2019-04-07 14:43:40 +02:00
Nicolas Grekas	c4d2a5ad16	Merge branch '3.4' into 4.2 * 3.4: fix translating file validation error message [Validator] Add missing Hungarian translations [3.4] [Validator] Add missing french validation translations. [Validator] Only traverse arrays that are cascaded into Handle case where no translations were found [Validator] Translate unique collection message to Hungarian fix tests Run test in separate process Use a class name that does not actually exist fix horizontal spacing of inlined Bootstrap forms [Translator] Warm up the translations cache in dev turn failed file uploads into form errors	2019-04-07 11:56:43 +02:00
Grégoire Paris	032e6624c3	Use a class name that does not actually exist Using "Foo", a class name that corresponds to no less than 22 fixture classes, results in the first found "Foo" being loaded when one is found by the ClassNotFoundFatalErrorHandler error handler, I am not sure exactly why, but it is not really a big issue because this is a fatal error handler and execution is not supposed to continue after that. Except that is very much the case when running the whole test suite sequentially with ./phpunit . Then we arrive to the DI component test suite, and a failure happens because \\foo was not supposed to be defined: > Failed asserting that exception message 'The definition for "\foo" has > no class attribute, and appears to reference a class or interface in the > global namespace. Leaving out the "class" attribute is only allowed for > namespaced classes. Please specify the class attribute explicitly to get > rid of this error.' contains 'The definition for "\foo" has no class.'.	2019-04-06 21:25:09 +02:00