Merge branch '2.7' into 2.8

* 2.7: Pass on previous exception in FatalThrowableError [Routing] remove dead code [Routing] fix typo
Pass on previous exception in FatalThrowableError
2026-03-24 17:22:13 +01:00 · 2018-02-28 13:47:46 -08:00 · 2018-02-28 13:02:44 -08:00 · 2018-02-03 15:53:47 +01:00 · 2018-02-03 01:09:36 +01:00 · 2018-02-03 00:51:31 +01:00
4 changed files with 19 additions and 7 deletions
--- a/ErrorHandler.php
+++ b/ErrorHandler.php
@@ -151,9 +151,20 @@ class ErrorHandler
        }
        if (!$replace && $prev) {
            restore_error_handler();
+            $handlerIsRegistered = is_array($prev) && $handler === $prev[0];
+        } else {
+            $handlerIsRegistered = true;
        }
-        if (is_array($prev = set_exception_handler(array($handler, 'handleException'))) && $prev[0] === $handler) {
+        if (is_array($prev = set_exception_handler(array($handler, 'handleException'))) && $prev[0] instanceof self) {
            restore_exception_handler();
+            if (!$handlerIsRegistered) {
+                $handler = $prev[0];
+            } elseif ($handler !== $prev[0] && $replace) {
+                set_exception_handler(array($handler, 'handleException'));
+                $p = $prev[0]->setExceptionHandler(null);
+                $handler->setExceptionHandler($p);
+                $prev[0]->setExceptionHandler($p);
+            }
        } else {
            $handler->setExceptionHandler($prev);
        }
--- a/Exception/FatalThrowableError.php
+++ b/Exception/FatalThrowableError.php
@@ -36,7 +36,8 @@ class FatalThrowableError extends FatalErrorException
            $e->getCode(),
            $severity,
            $e->getFile(),
-            $e->getLine()
+            $e->getLine(),
+            $e->getPrevious()
        );

        $this->setTrace($e->getTrace());
--- a/Tests/ErrorHandlerTest.php
+++ b/Tests/ErrorHandlerTest.php
@@ -35,7 +35,7 @@ class ErrorHandlerTest extends TestCase

            $newHandler = new ErrorHandler();

-            $this->assertSame($newHandler, ErrorHandler::register($newHandler, false));
+            $this->assertSame($handler, ErrorHandler::register($newHandler, false));
            $h = set_error_handler('var_dump');
            restore_error_handler();
            $this->assertSame(array($handler, 'handleError'), $h);
--- a/Tests/Exception/FlattenExceptionTest.php
+++ b/Tests/Exception/FlattenExceptionTest.php
@@ -105,7 +105,7 @@ class FlattenExceptionTest extends TestCase
    /**
     * @dataProvider flattenDataProvider
     */
-    public function testFlattenHttpException(\Exception $exception, $statusCode)
+    public function testFlattenHttpException(\Exception $exception)
    {
        $flattened = FlattenException::create($exception);
        $flattened2 = FlattenException::create($exception);
@@ -120,7 +120,7 @@ class FlattenExceptionTest extends TestCase
    /**
     * @dataProvider flattenDataProvider
     */
-    public function testPrevious(\Exception $exception, $statusCode)
+    public function testPrevious(\Exception $exception)
    {
        $flattened = FlattenException::create($exception);
        $flattened2 = FlattenException::create($exception);
@@ -167,7 +167,7 @@ class FlattenExceptionTest extends TestCase
    /**
     * @dataProvider flattenDataProvider
     */
-    public function testToArray(\Exception $exception, $statusCode)
+    public function testToArray(\Exception $exception)
    {
        $flattened = FlattenException::create($exception);
        $flattened->setTrace(array(), 'foo.php', 123);
@@ -187,7 +187,7 @@ class FlattenExceptionTest extends TestCase
    public function flattenDataProvider()
    {
        return array(
-            array(new \Exception('test', 123), 500),
+            array(new \Exception('test', 123)),
        );
    }
Author	SHA1	Message	Date
Fabien Potencier	f693ba8818	Merge branch '2.7' into 2.8 * 2.7: Pass on previous exception in FatalThrowableError [Routing] remove dead code [Routing] fix typo	2018-02-28 13:47:46 -08:00
Philipp Keck	6a76089f75	Pass on previous exception in FatalThrowableError	2018-02-28 13:02:44 -08:00
Nicolas Grekas	338c06c0dc	Merge branch '2.7' into 2.8 * 2.7: [CssSelector] For AND operator, the left operand should have parentheses, not only right operand Removed unused parameter from flattenDataProvider(). Update MongoDB extension on travis to make the builds green again.	2018-02-03 15:53:47 +01:00
Alexander M. Turek	7d96be3eaf	Removed unused parameter from flattenDataProvider().	2018-02-03 01:09:36 +01:00
Robin Chalas	0d52d1c98c	Merge branch '2.7' into 2.8 * 2.7: [Intl] Fixed the broken link [Routing] Fix trailing slash redirection for non-safe verbs [Debug] Fix bad registration of exception handler, leading to mem leak [Form] Fixed empty data on expanded ChoiceType and FileType	2018-02-03 00:51:31 +01:00
Nicolas Grekas	a91a8fdd8c	[Debug] Fix bad registration of exception handler, leading to mem leak	2018-01-30 16:14:37 +01:00