[Debug] workaround opcache bug mutating "$this" !?!

Merge branch '2.8' into 3.4
* 2.8: [Form] Hardened test suite for empty data Bump phpunit XSD version to 5.2 Add required key attribute
2026-03-25 09:42:20 +01:00 · 2018-11-27 13:43:10 +01:00 · 2018-11-11 20:48:54 +01:00 · 2018-11-11 12:18:13 +01:00 · 2018-10-31 10:06:03 +01:00 · 2018-10-30 17:24:01 +01:00
3 changed files with 8 additions and 8 deletions
--- a/Debug.php
+++ b/Debug.php
@@ -45,7 +45,7 @@ class Debug
        if (!\in_array(\PHP_SAPI, array('cli', 'phpdbg'), true)) {
            ini_set('display_errors', 0);
            ExceptionHandler::register();
-        } elseif ($displayErrors && (!ini_get('log_errors') || ini_get('error_log'))) {
+        } elseif ($displayErrors && (!filter_var(ini_get('log_errors'), FILTER_VALIDATE_BOOLEAN) || ini_get('error_log'))) {
            // CLI - display errors only if they're not already logged to STDERR
            ini_set('display_errors', 1);
        }
--- a/DebugClassLoader.php
+++ b/DebugClassLoader.php
@@ -138,14 +138,14 @@ class DebugClassLoader
        try {
            if ($this->isFinder && !isset($this->loaded[$class])) {
                $this->loaded[$class] = true;
-                if ($file = $this->classLoader[0]->findFile($class) ?: false) {
-                    $wasCached = \function_exists('opcache_is_script_cached') && @opcache_is_script_cached($file);
-
+                if (!$file = $this->classLoader[0]->findFile($class) ?: false) {
+                    // no-op
+                } elseif (\function_exists('opcache_is_script_cached') && @opcache_is_script_cached($file)) {
                    require $file;

-                    if ($wasCached) {
-                        return;
-                    }
+                    return;
+                } else {
+                    require $file;
                }
            } else {
                \call_user_func($this->classLoader, $class);
--- a/phpunit.xml.dist
+++ b/phpunit.xml.dist
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>

 <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-         xsi:noNamespaceSchemaLocation="http://schema.phpunit.de/4.1/phpunit.xsd"
+         xsi:noNamespaceSchemaLocation="http://schema.phpunit.de/5.2/phpunit.xsd"
         backupGlobals="false"
         colors="true"
         bootstrap="vendor/autoload.php"
Author	SHA1	Message	Date
Nicolas Grekas	a2233f555d	[Debug] workaround opcache bug mutating "$this" !?!	2018-11-27 13:43:10 +01:00
Nicolas Grekas	2016b3eec2	Merge branch '2.8' into 3.4 * 2.8: [Form] Hardened test suite for empty data Bump phpunit XSD version to 5.2 Add required key attribute	2018-11-11 20:48:54 +01:00
Grégoire Paris	74251c8d50	Bump phpunit XSD version to 5.2 Some attributes being used in the phpunit configuration files, namely failOnRisky and failOnWarning were introduced in phpunit 5.2.0. The Composer configuration shows that tests should run with old versions of phpunit, but phpunit only validates the configuration against the XSD since phpunit 7.2.0. These changes can be tested as follows: wget http://schema.phpunit.de/5.2/phpunit.xsd xargs xmllint --schema phpunit.xsd 1>/dev/null find src -name phpunit.xml.dist\| xargs xmllint --schema phpunit.xsd 1>/dev/null See `7e06a82806` See `46e3745a03/composer.json (L98)`	2018-11-11 12:18:13 +01:00
Nicolas Grekas	fe9793af00	Merge branch '2.8' into 3.4 * 2.8: Fixed typo Fix ini_get() for boolean values	2018-10-31 10:06:03 +01:00
François-Xavier de Guillebon	6a198c52b6	Fix ini_get() for boolean values	2018-10-30 17:24:01 +01:00