[HttpKernel][Debug] Remove noise from stack frames of deprecations

Merge branch '2.8' into 3.3
* 2.8: [DI] minor docblock fixes
2026-03-25 01:32:09 +01:00 · 2017-11-10 17:38:39 +01:00 · 2017-10-24 16:05:06 +02:00 · 2017-10-24 15:48:52 +02:00 · 2017-10-24 13:40:19 +02:00 · 2017-10-18 08:00:09 -07:00
7 changed files with 11 additions and 25 deletions
--- a/DebugClassLoader.php
+++ b/DebugClassLoader.php
@@ -34,11 +34,6 @@ class DebugClassLoader
    private static $php7Reserved = array('int', 'float', 'bool', 'string', 'true', 'false', 'null');
    private static $darwinCache = array('/' => array('/', array()));

-    /**
-     * Constructor.
-     *
-     * @param callable $classLoader A class loader
-     */
    public function __construct(callable $classLoader)
    {
        $this->classLoader = $classLoader;
@@ -209,18 +204,11 @@ class DebugClassLoader
                self::$deprecated[$name] = preg_replace('#\s*\r?\n \* +#', ' ', $notice[1]);
            } else {
                // Don't trigger deprecations for classes in the same vendor
-                if (2 > $len = 1 + (strpos($name, '\\', 1 + strpos($name, '\\')) ?: strpos($name, '_'))) {
+                if (2 > $len = 1 + (strpos($name, '\\') ?: strpos($name, '_'))) {
                    $len = 0;
                    $ns = '';
                } else {
-                    switch ($ns = substr($name, 0, $len)) {
-                        case 'Symfony\Bridge\\':
-                        case 'Symfony\Bundle\\':
-                        case 'Symfony\Component\\':
-                            $ns = 'Symfony\\';
-                            $len = strlen($ns);
-                            break;
-                    }
+                    $ns = substr($name, 0, $len);
                }

                if (!$parent || strncmp($ns, $parent, $len)) {
--- a/ErrorHandler.php
+++ b/ErrorHandler.php
@@ -707,7 +707,7 @@ class ErrorHandler
        }
        if (!($throw || $this->scopedErrors & $type)) {
            for ($i = 0; isset($lightTrace[$i]); ++$i) {
-                unset($lightTrace[$i]['args']);
+                unset($lightTrace[$i]['args'], $lightTrace[$i]['object']);
            }
        }

--- a/ExceptionHandler.php
+++ b/ExceptionHandler.php
@@ -196,8 +196,6 @@ class ExceptionHandler
    /**
     * Gets the HTML content associated with the given exception.
     *
-     * @param FlattenException $exception A FlattenException instance
-     *
     * @return string The content as a string
     */
    public function getContent(FlattenException $exception)
@@ -276,8 +274,6 @@ EOF;
    /**
     * Gets the stylesheet associated with the given exception.
     *
-     * @param FlattenException $exception A FlattenException instance
-     *
     * @return string The stylesheet as a string
     */
    public function getStylesheet(FlattenException $exception)
@@ -310,8 +306,8 @@ EOF;
            .exception-message { flex-grow: 1; padding: 30px 0; }
            .exception-message, .exception-message a { color: #FFF; font-size: 21px; font-weight: 400; margin: 0; }
            .exception-message.long { font-size: 18px; }
-            .exception-message a { text-decoration: none; }
-            .exception-message a:hover { text-decoration: underline; }
+            .exception-message a { border-bottom: 1px solid rgba(255, 255, 255, 0.5); font-size: inherit; text-decoration: none; }
+            .exception-message a:hover { border-bottom-color: #ffffff; }

            .exception-illustration { flex-basis: 111px; flex-shrink: 0; height: 66px; margin-left: 15px; opacity: .7; }

--- a/Tests/DebugClassLoaderTest.php
+++ b/Tests/DebugClassLoaderTest.php
@@ -204,7 +204,7 @@ class DebugClassLoaderTest extends TestCase

        $xError = array(
            'type' => E_USER_DEPRECATED,
-            'message' => 'The "Test\Symfony\Component\Debug\Tests\\'.$class.'" class '.$type.' "Symfony\Component\Debug\Tests\Fixtures\\'.$super.'" that is deprecated but this is a test deprecation notice.',
+            'message' => 'The "Test\Symfony\Component\Debug\Tests\\'.$class.'" class '.$type.' "Symfony\Component\Debug\Tests\Fixtures\\'.$super.'" that is deprecated but this is a test deprecation notice',
        );

        $this->assertSame($xError, $lastError);
--- a/Tests/Fixtures/DeprecatedClass.php
+++ b/Tests/Fixtures/DeprecatedClass.php
@@ -4,7 +4,7 @@ namespace Symfony\Component\Debug\Tests\Fixtures;

 /**
 * @deprecated but this is a test
- *             deprecation notice.
+ *             deprecation notice
 * @foobar
 */
 class DeprecatedClass
--- a/Tests/Fixtures/DeprecatedInterface.php
+++ b/Tests/Fixtures/DeprecatedInterface.php
@@ -4,7 +4,7 @@ namespace Symfony\Component\Debug\Tests\Fixtures;

 /**
 * @deprecated but this is a test
- *             deprecation notice.
+ *             deprecation notice
 * @foobar
 */
 interface DeprecatedInterface
--- a/Tests/Fixtures/Throwing.php
+++ b/Tests/Fixtures/Throwing.php
@@ -1,3 +1,5 @@
 <?php

-throw new \Exception('boo');
+if (!function_exists('__phpunit_run_isolated_test')) {
+    throw new \Exception('boo');
+}
Author	SHA1	Message	Date
Nicolas Grekas	74557880e2	[HttpKernel][Debug] Remove noise from stack frames of deprecations	2017-11-10 17:38:39 +01:00
Nicolas Grekas	2854347f27	Merge branch '2.8' into 3.3 * 2.8: [DI] minor docblock fixes	2017-10-24 16:05:06 +02:00
Nicolas Grekas	a0a29e9867	Merge branch '2.7' into 2.8 * 2.7: [DI] minor docblock fixes	2017-10-24 15:48:52 +02:00
Nicolas Grekas	271c75c24d	[DI] minor docblock fixes	2017-10-24 13:40:19 +02:00
Fabien Potencier	5f49adc996	Merge branch '2.8' into 3.3 * 2.8: Username and password in basic auth are allowed to contain '.' Remove obsolete PHPDoc from UriSigner [Serializer] ObjectNormalizer: throw if PropertyAccess isn't installed [PropertyInfo] Add support for the iterable type pdo session fix Fixed unsetting from loosely equal keys OrderedHashMap [Debug] Fix same vendor detection in class loader Updated the source text and translation reject remember-me token if user check fails	2017-10-18 08:00:09 -07:00
Fabien Potencier	08bf2c53db	Merge branch '2.7' into 2.8 * 2.7: Username and password in basic auth are allowed to contain '.' Remove obsolete PHPDoc from UriSigner [Serializer] ObjectNormalizer: throw if PropertyAccess isn't installed pdo session fix Fixed unsetting from loosely equal keys OrderedHashMap [Debug] Fix same vendor detection in class loader Updated the source text and translation reject remember-me token if user check fails	2017-10-18 07:57:21 -07:00
hubert.lenoir	f0546da70c	[Debug] Fix same vendor detection in class loader	2017-10-13 19:28:12 +02:00
Nicolas Grekas	88e1bd3ad2	Merge branch '2.8' into 3.3 * 2.8: fix merge Fix 7.2 compat layer Fix PHP 7.2 support [HttpFoundation] Add missing session.lazy_write config option [HttpFoundation] Combine Cache-Control headers [Form] fix parsing invalid floating point numbers Escape command usage when displaying it in the text descriptor Use for=ID on radio/checkbox label.	2017-10-10 12:12:32 +02:00
Nicolas Grekas	d295479508	Merge branch '2.7' into 2.8 * 2.7: Fix 7.2 compat layer Fix PHP 7.2 support [HttpFoundation] Add missing session.lazy_write config option [HttpFoundation] Combine Cache-Control headers [Form] fix parsing invalid floating point numbers Escape command usage when displaying it in the text descriptor Use for=ID on radio/checkbox label.	2017-10-10 09:42:03 +02:00
Nicolas Grekas	d2d11379b5	Fix 7.2 compat layer	2017-10-09 20:05:34 +02:00
Nicolas Grekas	eb95d9ce8f	Merge branch '2.8' into 3.3 * 2.8: (22 commits) Tests and fix for issue in array model data in EntityType field with multiple=true [Form] Fixed PercentToLocalizedStringTransformer to accept both comma and dot as decimal separator, if possible removed useless PHPDoc [Form] Fix FormInterface::submit() annotation PdoSessionHandler: fix advisory lock for pgsql when session.sid_bits_per_character > 4 HttpCache does not consider ESI resources in HEAD requests Fix translation for "This field was not expected" [Routing] Enhance Route(Collection) docblocks Added improvement for accuracy in MoneyToLocalizedStringTransformer. Removed unused private property Use correct verb form in the pull request template Use PHP_MAXPATHLEN in Filesystem. Added null as explicit return type (?TokenInterface) [FrameworkBundle] Fix Routing\DelegatingLoader Render all line breaks according to the exception message [Form] Fix phpdoc [DI] remove confusing code [Form] Fixed GroupSequence with "constraints" option [Validator] Clarify UUID validator behavior [Filesystem] Fixed makePathRelative ...	2017-10-02 08:42:24 +02:00
Nicolas Grekas	eaaec993ca	Merge branch '2.7' into 2.8 * 2.7: (22 commits) Tests and fix for issue in array model data in EntityType field with multiple=true [Form] Fixed PercentToLocalizedStringTransformer to accept both comma and dot as decimal separator, if possible removed useless PHPDoc [Form] Fix FormInterface::submit() annotation PdoSessionHandler: fix advisory lock for pgsql when session.sid_bits_per_character > 4 HttpCache does not consider ESI resources in HEAD requests Fix translation for "This field was not expected" [Routing] Enhance Route(Collection) docblocks Added improvement for accuracy in MoneyToLocalizedStringTransformer. Removed unused private property Use correct verb form in the pull request template Use PHP_MAXPATHLEN in Filesystem. Added null as explicit return type (?TokenInterface) [FrameworkBundle] Fix Routing\DelegatingLoader Render all line breaks according to the exception message [Form] Fix phpdoc [DI] remove confusing code [Form] Fixed GroupSequence with "constraints" option [Validator] Clarify UUID validator behavior [Filesystem] Fixed makePathRelative ...	2017-10-01 23:00:16 +02:00
Fabien Potencier	e12a6f1168	minor #24342 removed useless PHPDoc (OskarStark) This PR was squashed before being merged into the 2.7 branch (closes #24342). Discussion ---------- removed useless PHPDoc \| Q \| A \| ------------- \| --- \| Branch? \| 2.7 \| Bug fix? \| no \| New feature? \| no <!-- don't forget updating src/*/CHANGELOG.md files --> \| BC breaks? \| no \| Deprecations? \| no <!-- don't forget updating UPGRADE-.md files --> \| Tests pass? \| yes \| Fixed tickets \| \| License \| MIT \| Doc PR \| n/a Commits ------- 5ee9043d8b removed useless PHPDoc	2017-09-30 07:00:25 -07:00
Oskar Stark	34d945c4eb	removed useless PHPDoc	2017-09-30 07:00:23 -07:00
Fabien Potencier	3bea0cdeb5	Merge branch '2.8' into 3.3 * 2.8: [CS] Apply phpdoc_annotation_without_dot	2017-09-11 13:43:11 -07:00
Fabien Potencier	2827a6e8c2	Merge branch '2.7' into 2.8 * 2.7: [CS] Apply phpdoc_annotation_without_dot	2017-09-11 13:39:16 -07:00
Dariusz	9c5b622f5a	[CS] Apply phpdoc_annotation_without_dot	2017-09-11 13:37:52 -07:00
Javier Eguiluz	8beb24eec7	Improved how links are displayed in exception messages	2017-09-01 15:23:39 +02:00