Merge branch '2.8' into 3.1

* 2.8: (26 commits)
  fixed CS
  fixed CS
  fixed CS fixer config
  fixed typo
  Revert "fixed typo"
  fixed typo
  fixed CS
  Avoid setting request attributes from signature arguments in AnnotationClassLoader
  [DependencyInjection] Add some missing typehints in YamlFileLoader
  [DependencyInjection] minor: Fix a DocBlock
  [HttpKernel] Give higher priority to adding request formats
  [PropertyInfo] Don't try to access a property thru a static method
  [PropertyInfo] Exclude static methods form properties guessing
  [FrameworkBundle] Fix third level headers for MarkdownDescriptor
  [TwigBundle] do not lose already set method calls
  #20411 fix Yaml parsing for very long quoted strings
  CS: apply is_null
  DX: remove invalid inheritdoc
  bumped Symfony version to 2.8.17
  updated VERSION for 2.8.16
  ...

ClassCollectionLoader.php

@@ -60,7 +60,7 @@ class ClassCollectionLoader
             throw new \RuntimeException(sprintf('Class Collection Loader was not able to create directory "%s"', $cacheDir));
         }
         $cacheDir = rtrim(realpath($cacheDir) ?: $cacheDir, '/'.DIRECTORY_SEPARATOR);
-        $cache = $cacheDir.DIRECTORY_SEPARATOR.$name.$extension;
+        $cache = $cacheDir.'/'.$name.$extension;
 
         // auto-reload
         $reload = false;
@@ -98,38 +98,6 @@ class ClassCollectionLoader
             $declared = array_merge(get_declared_classes(), get_declared_interfaces(), get_declared_traits());
         }
 
-        $files = self::inline($classes, $cache, $declared);
-
-        if ($autoReload) {
-            // save the resources
-            self::writeCacheFile($metadata, serialize(array(array_values($files), $classes)));
-        }
-    }
-
-    /**
-     * Generates a file where classes and their parents are inlined.
-     *
-     * @param array  $classes  An array of classes to load
-     * @param string $cache    The file where classes are inlined
-     * @param array  $excluded An array of classes that won't be inlined
-     *
-     * @return array The source map of inlined classes, with classes as keys and files as values
-     *
-     * @throws \RuntimeException When class can't be loaded
-     */
-    public static function inline($classes, $cache, array $excluded)
-    {
-        $declared = array();
-        foreach (self::getOrderedClasses($excluded) as $class) {
-            $declared[$class->getName()] = true;
-        }
-
-        // cache the core classes
-        $cacheDir = dirname($cache);
-        if (!is_dir($cacheDir) && !@mkdir($cacheDir, 0777, true) && !is_dir($cacheDir)) {
-            throw new \RuntimeException(sprintf('Class Collection Loader was not able to create directory "%s"', $cacheDir));
-        }
-
         $spacesRegex = '(?:\s*+(?:(?:\#|//)[^\n]*+\n|/\*(?:(?<!\*/).)++)?+)*+';
         $dontInlineRegex = <<<REGEX
             '(?:
@@ -140,20 +108,19 @@ class ClassCollectionLoader
 REGEX;
         $dontInlineRegex = str_replace('.', $spacesRegex, $dontInlineRegex);
 
-        $cacheDir = explode(DIRECTORY_SEPARATOR, $cacheDir);
+        $cacheDir = explode('/', str_replace(DIRECTORY_SEPARATOR, '/', $cacheDir));
         $files = array();
         $content = '';
         foreach (self::getOrderedClasses($classes) as $class) {
-            if (isset($declared[$class->getName()])) {
+            if (in_array($class->getName(), $declared)) {
                 continue;
             }
-            $declared[$class->getName()] = true;
 
-            $files[$class->getName()] = $file = $class->getFileName();
+            $files[] = $file = $class->getFileName();
             $c = file_get_contents($file);
 
             if (preg_match($dontInlineRegex, $c)) {
-                $file = explode(DIRECTORY_SEPARATOR, $file);
+                $file = explode('/', str_replace(DIRECTORY_SEPARATOR, '/', $file));
 
                 for ($i = 0; isset($file[$i], $cacheDir[$i]); ++$i) {
                     if ($file[$i] !== $cacheDir[$i]) {
@@ -161,11 +128,11 @@ REGEX;
                     }
                 }
                 if (1 >= $i) {
-                    $file = var_export(implode(DIRECTORY_SEPARATOR, $file), true);
+                    $file = var_export(implode('/', $file), true);
                 } else {
                     $file = array_slice($file, $i);
-                    $file = str_repeat('..'.DIRECTORY_SEPARATOR, count($cacheDir) - $i).implode(DIRECTORY_SEPARATOR, $file);
-                    $file = '__DIR__.'.var_export(DIRECTORY_SEPARATOR.$file, true);
+                    $file = str_repeat('../', count($cacheDir) - $i).implode('/', $file);
+                    $file = '__DIR__.'.var_export('/'.$file, true);
                 }
 
                 $c = "\nnamespace {require $file;}";
@@ -185,7 +152,10 @@ REGEX;
         }
         self::writeCacheFile($cache, '<?php '.$content);
 
-        return $files;
+        if ($autoReload) {
+            // save the resources
+            self::writeCacheFile($metadata, serialize(array($files, $classes)));
+        }
     }
 
     /**
@@ -299,7 +269,13 @@ REGEX;
      */
     private static function writeCacheFile($file, $content)
     {
-        $tmpFile = tempnam(dirname($file), basename($file));
+        $dir = dirname($file);
+        if (!is_writable($dir)) {
+            throw new \RuntimeException(sprintf('Cache directory "%s" is not writable.', $dir));
+        }
+
+        $tmpFile = tempnam($dir, basename($file));
+
         if (false !== @file_put_contents($tmpFile, $content) && @rename($tmpFile, $file)) {
             @chmod($file, 0666 & ~umask());
 

LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2004-2016 Fabien Potencier
+Copyright (c) 2004-2017 Fabien Potencier
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

Tests/ClassCollectionLoaderTest.php

@@ -12,8 +12,6 @@
 namespace Symfony\Component\ClassLoader\Tests;
 
 use Symfony\Component\ClassLoader\ClassCollectionLoader;
-use Symfony\Component\ClassLoader\Tests\Fixtures\DeclaredClass;
-use Symfony\Component\ClassLoader\Tests\Fixtures\WarmedClass;
 
 require_once __DIR__.'/Fixtures/ClassesWithParents/GInterface.php';
 require_once __DIR__.'/Fixtures/ClassesWithParents/CInterface.php';
@@ -280,36 +278,4 @@ EOF
 
         unlink($file);
     }
-
-    public function testInline()
-    {
-        $this->assertTrue(class_exists(WarmedClass::class, true));
-
-        @unlink($cache = sys_get_temp_dir().'/inline.php');
-
-        $classes = array(WarmedClass::class);
-        $excluded = array(DeclaredClass::class);
-
-        ClassCollectionLoader::inline($classes, $cache, $excluded);
-
-        $this->assertSame(<<<'EOTXT'
-<?php 
-namespace Symfony\Component\ClassLoader\Tests\Fixtures
-{
-interface WarmedInterface
-{
-}
-}
-namespace Symfony\Component\ClassLoader\Tests\Fixtures
-{
-class WarmedClass extends DeclaredClass implements WarmedInterface
-{
-}
-}
-EOTXT
-            , file_get_contents($cache)
-        );
-
-        unlink($cache);
-    }
 }

Tests/Fixtures/DeclaredClass.php

@@ -1,7 +0,0 @@
-<?php
-
-namespace Symfony\Component\ClassLoader\Tests\Fixtures;
-
-class DeclaredClass implements DeclaredInterface
-{
-}

Tests/Fixtures/DeclaredInterface.php

@@ -1,7 +0,0 @@
-<?php
-
-namespace Symfony\Component\ClassLoader\Tests\Fixtures;
-
-interface DeclaredInterface
-{
-}

Tests/Fixtures/Namespaced/WithStrictTypes.php

@@ -4,7 +4,7 @@
  * foo
  */
 
-declare (strict_types = 1);
+declare(strict_types=1);
 
 namespace Namespaced;
 

Tests/Fixtures/WarmedClass.php

@@ -1,7 +0,0 @@
-<?php
-
-namespace Symfony\Component\ClassLoader\Tests\Fixtures;
-
-class WarmedClass extends DeclaredClass implements WarmedInterface
-{
-}

Tests/Fixtures/WarmedInterface.php

@@ -1,7 +0,0 @@
-<?php
-
-namespace Symfony\Component\ClassLoader\Tests\Fixtures;
-
-interface WarmedInterface
-{
-}

composer.json

@@ -34,7 +34,7 @@
     },
     "extra": {
         "branch-alias": {
-            "dev-master": "3.2-dev"
+            "dev-master": "3.1-dev"
         }
     }
 }