symfony/archived-console
1
0
Fork 0
mirror of https://github.com/symfony/console.git synced 2026-03-24 01:12:13 +01:00
Code Issues Packages Projects Releases Wiki Activity

[Console] Fix setting aliases & hidden via name

Browse Source
This commit is contained in:
HypeMC
2025-06-07 17:59:31 +02:00
parent aa64416f1d
commit 5e7cd96684
3 changed files with 21 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
CHANGELOG.md
View File

@@ -1,6 +1,11 @@
CHANGELOG
=========
7.4
---
* Allow setting aliases and the hidden flag via the command name passed to the constructor
7.3
---

6
Command/Command.php
View File

@@ -97,13 +97,13 @@ class Command implements SignalableCommandInterface
if (self::class !== (new \ReflectionMethod($this, 'getDefaultName'))->class) {
trigger_deprecation('symfony/console', '7.3', 'Overriding "Command::getDefaultName()" in "%s" is deprecated and will be removed in Symfony 8.0, use the #[AsCommand] attribute instead.', static::class);
$defaultName = static::getDefaultName();
$name = static::getDefaultName();
} else {
$defaultName = $attribute?->name;
$name = $attribute?->name;
}
}
if (null === $name && null !== $name = $defaultName) {
if (null !== $name) {
$aliases = explode('|', $name);
if ('' === $name = array_shift($aliases)) {

13
Tests/Command/CommandTest.php
View File

@@ -205,6 +205,19 @@ class CommandTest extends TestCase
$this->assertEquals(['name1'], $command->getAliases(), '->setAliases() sets the aliases');
}
/**
* @testWith ["name|alias1|alias2", "name", ["alias1", "alias2"], false]
* ["|alias1|alias2", "alias1", ["alias2"], true]
*/
public function testSetAliasesAndHiddenViaName(string $name, string $expectedName, array $expectedAliases, bool $expectedHidden)
{
$command = new Command($name);
self::assertSame($expectedName, $command->getName());
self::assertSame($expectedHidden, $command->isHidden());
self::assertSame($expectedAliases, $command->getAliases());
}
public function testGetSynopsis()
{
$command = new \TestCommand();