symfony/archived-amazon-sqs-messenger
1
0
Fork 0
mirror of https://github.com/symfony/amazon-sqs-messenger.git synced 2026-03-23 23:12:09 +01:00
Code Issues Packages Projects Releases Wiki Activity

[Messenger] Add retry delay on amazon sqs

Browse Source
This commit is contained in:
François-Xavier de Guillebon
2025-10-07 12:27:55 +02:00
parent d3178e7853
commit a10486eaea
3 changed files with 23 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGELOG.md
View File

@@ -4,7 +4,8 @@ CHANGELOG
7.4
---
* Allow SQS to handle it's own retry/DLQ
* Allow SQS to handle its own retry/DLQ
* Add `retry_delay` option to configure the delay between retries when using SQS retry/DLQ handling
7.3
---

19
Tests/Transport/ConnectionTest.php
View File

@@ -391,13 +391,28 @@ class ConnectionTest extends TestCase
$expectedParams = [
'QueueUrl' => $queueUrl = 'https://sqs.us-east-2.amazonaws.com/123456789012/MyQueue',
'ReceiptHandle' => $id = 'abc',
'VisibilityTimeout' => $visibilityTimeout = 10,
'VisibilityTimeout' => 0,
];
$client = $this->createMock(SqsClient::class);
$client->expects($this->once())->method('changeMessageVisibility')->with($expectedParams);
$connection = new Connection(['delete_on_rejection' => false, 'visibility_timeout' => $visibilityTimeout], $client, $queueUrl);
$connection = new Connection(['delete_on_rejection' => false, 'visibility_timeout' => 30], $client, $queueUrl);
$connection->reject($id);
}
public function testDoNotDeleteOnRejectionWithRetryDelay()
{
$expectedParams = [
'QueueUrl' => $queueUrl = 'https://sqs.us-east-2.amazonaws.com/123456789012/MyQueue',
'ReceiptHandle' => $id = 'abc',
'VisibilityTimeout' => $retryDelay = 5,
];
$client = $this->createMock(SqsClient::class);
$client->expects($this->once())->method('changeMessageVisibility')->with($expectedParams);
$connection = new Connection(['delete_on_rejection' => false, 'retry_delay' => $retryDelay], $client, $queueUrl);
$connection->reject($id);
}

5
Transport/Connection.php
View File

@@ -40,6 +40,7 @@ class Connection
'poll_timeout' => 0.1,
'visibility_timeout' => null,
'delete_on_rejection' => true,
'retry_delay' => 0,
'auto_setup' => true,
'access_key' => null,
'secret_key' => null,
@@ -103,6 +104,7 @@ class Connection
* * poll_timeout: amount of seconds the transport should wait for new message
* * visibility_timeout: amount of seconds the message won't be visible
* * delete_on_rejection: Whether to delete message on rejection or allow SQS to handle retries. (Default: true).
* * retry_delay: amount of seconds the message won't be visible before retry. (Default: 0).
* * sslmode: Can be "disable" to use http for a custom endpoint
* * auto_setup: Whether the queue should be created automatically during send / get (Default: true)
* * debug: Log all HTTP requests and responses as LoggerInterface::DEBUG (Default: false)
@@ -137,6 +139,7 @@ class Connection
'poll_timeout' => $options['poll_timeout'],
'visibility_timeout' => null !== $options['visibility_timeout'] ? (int) $options['visibility_timeout'] : null,
'delete_on_rejection' => filter_var($options['delete_on_rejection'], \FILTER_VALIDATE_BOOL),
'retry_delay' => (int) $options['retry_delay'],
'auto_setup' => filter_var($options['auto_setup'], \FILTER_VALIDATE_BOOL),
'queue_name' => (string) $options['queue_name'],
'queue_attributes' => $options['queue_attributes'],
@@ -323,7 +326,7 @@ class Connection
$this->client->changeMessageVisibility([
'QueueUrl' => $this->getQueueUrl(),
'ReceiptHandle' => $id,
'VisibilityTimeout' => $this->configuration['visibility_timeout'] ?? 30,
'VisibilityTimeout' => $this->configuration['retry_delay'],
]);
}
}