php/archived-php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2026-03-24 00:02:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

Drop superfluous readline test skip conditions

Browse Source 
The `--EXTENSIONS--` section already ensures that ext/readline is
available, so there's no need to additionally check for unconditionally
available readline functions.

Closes GH-17170.
This commit is contained in:
Christoph M. Becker
2024-12-15 17:05:14 +01:00
parent 75410eb457
commit aff044857f
7 changed files with 2 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
ext/readline/tests/bug69054.phpt
View File

@@ -2,8 +2,6 @@
Bug #69054 (Null dereference in readline_(read|write)_history() without parameters)
--EXTENSIONS--
readline
--SKIPIF--
<?php if (!function_exists('readline_add_history')) die("skip"); ?>
--INI--
open_basedir="{TMP}"
--FILE--

2
ext/readline/tests/libedit_write_history_001.phpt
View File

@@ -3,7 +3,7 @@ readline_write_history(): Basic test
--EXTENSIONS--
readline
--SKIPIF--
<?php if (!function_exists('readline_add_history')) die("skip");
<?php
if (READLINE_LIB != "libedit") die("skip libedit only");
if (getenv('SKIP_REPEAT')) die("skip readline has global state");
?>

1
ext/readline/tests/readline_read_history_error_001.phpt
View File

@@ -5,7 +5,6 @@ Pedro Manoel Evangelista <pedro.evangelista at gmail dot com>
--EXTENSIONS--
readline
--SKIPIF--
<?php if (!function_exists('readline_read_history')) die('skip readline_read_history function does not exist'); ?>
<?php if (!READLINE_LIB != "libedit") die('skip READLINE_LIB != "libedit"'); ?>
--FILE--
<?php

2
ext/readline/tests/readline_read_history_open_basedir_001.phpt
View File

@@ -2,8 +2,6 @@
readline_read_history(): Test that open_basedir is respected
--EXTENSIONS--
readline
--SKIPIF--
<?php if (!function_exists('readline_read_history')) die("skip"); ?>
--INI--
open_basedir=/tmp/some-sandbox
--FILE--

4
ext/readline/tests/readline_without_input.phpt
View File

@@ -5,10 +5,6 @@ Jonathan Stevens <info at jonathanstevens dot be>
User Group: PHP-WVL & PHPGent #PHPTestFest
--EXTENSIONS--
readline
--SKIPIF--
<?php
if (!function_exists('readline')) die("skip readline() not available");
?>
--FILE--
<?php
var_dump(readline());

2
ext/readline/tests/readline_write_history_001.phpt
View File

@@ -3,7 +3,7 @@ readline_write_history(): Basic test
--EXTENSIONS--
readline
--SKIPIF--
<?php if (!function_exists('readline_add_history')) die("skip");
<?php
if (READLINE_LIB == "libedit") die("skip readline only");
if (getenv('SKIP_REPEAT')) die("skip readline has global state");
?>

2
ext/readline/tests/readline_write_history_open_basedir_001.phpt
View File

@@ -2,8 +2,6 @@
readline_write_history(): Test that open_basedir is respected
--EXTENSIONS--
readline
--SKIPIF--
<?php if (!function_exists('readline_write_history')) die("skip"); ?>
--INI--
open_basedir=/tmp/some-sandbox
--FILE--