From aff044857f24042b93e38226e33228c43d01ef91 Mon Sep 17 00:00:00 2001
From: "Christoph M. Becker" <cmbecker69@gmx.de>
Date: Sun, 15 Dec 2024 17:05:14 +0100
Subject: [PATCH] Drop superfluous readline test skip conditions

The `--EXTENSIONS--` section already ensures that ext/readline is
available, so there's no need to additionally check for unconditionally
available readline functions.

Closes GH-17170.
---
 ext/readline/tests/bug69054.phpt                              | 2 --
 ext/readline/tests/libedit_write_history_001.phpt             | 2 +-
 ext/readline/tests/readline_read_history_error_001.phpt       | 1 -
 .../tests/readline_read_history_open_basedir_001.phpt         | 2 --
 ext/readline/tests/readline_without_input.phpt                | 4 ----
 ext/readline/tests/readline_write_history_001.phpt            | 2 +-
 .../tests/readline_write_history_open_basedir_001.phpt        | 2 --
 7 files changed, 2 insertions(+), 13 deletions(-)

diff --git a/ext/readline/tests/bug69054.phpt b/ext/readline/tests/bug69054.phpt
index 99750bfd3d3..985b4736047 100644
--- a/ext/readline/tests/bug69054.phpt
+++ b/ext/readline/tests/bug69054.phpt
@@ -2,8 +2,6 @@
 Bug #69054 (Null dereference in readline_(read|write)_history() without parameters)
 --EXTENSIONS--
 readline
---SKIPIF--
-<?php if (!function_exists('readline_add_history')) die("skip"); ?>
 --INI--
 open_basedir="{TMP}"
 --FILE--
diff --git a/ext/readline/tests/libedit_write_history_001.phpt b/ext/readline/tests/libedit_write_history_001.phpt
index ba3d65ee507..a6240ff7b7d 100644
--- a/ext/readline/tests/libedit_write_history_001.phpt
+++ b/ext/readline/tests/libedit_write_history_001.phpt
@@ -3,7 +3,7 @@ readline_write_history(): Basic test
 --EXTENSIONS--
 readline
 --SKIPIF--
-<?php if (!function_exists('readline_add_history')) die("skip");
+<?php
 if (READLINE_LIB != "libedit") die("skip libedit only");
 if (getenv('SKIP_REPEAT')) die("skip readline has global state");
 ?>
diff --git a/ext/readline/tests/readline_read_history_error_001.phpt b/ext/readline/tests/readline_read_history_error_001.phpt
index 500b509b865..bdd05d27f88 100644
--- a/ext/readline/tests/readline_read_history_error_001.phpt
+++ b/ext/readline/tests/readline_read_history_error_001.phpt
@@ -5,7 +5,6 @@ Pedro Manoel Evangelista <pedro.evangelista at gmail dot com>
 --EXTENSIONS--
 readline
 --SKIPIF--
-<?php if (!function_exists('readline_read_history')) die('skip readline_read_history function does not exist'); ?>
 <?php if (!READLINE_LIB != "libedit") die('skip READLINE_LIB != "libedit"'); ?>
 --FILE--
 <?php
diff --git a/ext/readline/tests/readline_read_history_open_basedir_001.phpt b/ext/readline/tests/readline_read_history_open_basedir_001.phpt
index 88939760e37..583ca389c2f 100644
--- a/ext/readline/tests/readline_read_history_open_basedir_001.phpt
+++ b/ext/readline/tests/readline_read_history_open_basedir_001.phpt
@@ -2,8 +2,6 @@
 readline_read_history(): Test that open_basedir is respected
 --EXTENSIONS--
 readline
---SKIPIF--
-<?php if (!function_exists('readline_read_history')) die("skip"); ?>
 --INI--
 open_basedir=/tmp/some-sandbox
 --FILE--
diff --git a/ext/readline/tests/readline_without_input.phpt b/ext/readline/tests/readline_without_input.phpt
index 0b727256403..4c855b6d756 100644
--- a/ext/readline/tests/readline_without_input.phpt
+++ b/ext/readline/tests/readline_without_input.phpt
@@ -5,10 +5,6 @@ Jonathan Stevens <info at jonathanstevens dot be>
 User Group: PHP-WVL & PHPGent #PHPTestFest
 --EXTENSIONS--
 readline
---SKIPIF--
-<?php
-if (!function_exists('readline')) die("skip readline() not available");
-?>
 --FILE--
 <?php
 var_dump(readline());
diff --git a/ext/readline/tests/readline_write_history_001.phpt b/ext/readline/tests/readline_write_history_001.phpt
index 7373aa52a08..d602c959862 100644
--- a/ext/readline/tests/readline_write_history_001.phpt
+++ b/ext/readline/tests/readline_write_history_001.phpt
@@ -3,7 +3,7 @@ readline_write_history(): Basic test
 --EXTENSIONS--
 readline
 --SKIPIF--
-<?php if (!function_exists('readline_add_history')) die("skip");
+<?php
 if (READLINE_LIB == "libedit") die("skip readline only");
 if (getenv('SKIP_REPEAT')) die("skip readline has global state");
 ?>
diff --git a/ext/readline/tests/readline_write_history_open_basedir_001.phpt b/ext/readline/tests/readline_write_history_open_basedir_001.phpt
index 263522a0b65..0b85f321683 100644
--- a/ext/readline/tests/readline_write_history_open_basedir_001.phpt
+++ b/ext/readline/tests/readline_write_history_open_basedir_001.phpt
@@ -2,8 +2,6 @@
 readline_write_history(): Test that open_basedir is respected
 --EXTENSIONS--
 readline
---SKIPIF--
-<?php if (!function_exists('readline_write_history')) die("skip"); ?>
 --INI--
 open_basedir=/tmp/some-sandbox
 --FILE--