[PR #50] [CLOSED] Fixes #6: Remove NSIS installer/script #84

New Issue

admin · 2026-01-24T11:40:45+01:00

admin commented

2026-01-24 11:40:45 +01:00

📋 Pull Request Information

Original PR: https://github.com/php/pftt2/pull/50
Author: @lavturo
Created: 6/27/2019
Status: ❌ Closed

Base: master ← Head: fix_issue6

📝 Commits (1)

ab10ae9 Fixes #6: Remove NSIS installer/script

📊 Changes

2 files changed (+0 additions, -128 deletions)

View changed files

➖ script/install/windows/PFTT-Windows.nsi (+0 -128)
➖ script/install/windows/nsis-2.46-setup.exe (+0 -0)

📄 Description

@weltling Checked through the script and saw that the biggest differences was:

-It an uninstaller (which is irrelevant)
-It uses the pftt cmd shell. I believe the pftt cmd shell isn't really needed for how pftt currently operates.

This installer should be safe to remove. Did we want to leave the script folder there or just remove it all together?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/php/pftt2/pull/50 **Author:** [@lavturo](https://github.com/lavturo) **Created:** 6/27/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix_issue6` --- ### 📝 Commits (1) - [`ab10ae9`](https://github.com/php/pftt2/commit/ab10ae9d66452e5862832eb8f6265c8cbc4edc59) Fixes #6: Remove NSIS installer/script ### 📊 Changes **2 files changed** (+0 additions, -128 deletions) <details> <summary>View changed files</summary> ➖ `script/install/windows/PFTT-Windows.nsi` (+0 -128) ➖ `script/install/windows/nsis-2.46-setup.exe` (+0 -0) </details> ### 📄 Description @weltling Checked through the script and saw that the biggest differences was: -It an uninstaller (which is irrelevant) -It uses the pftt cmd shell. I believe the pftt cmd shell isn't really needed for how pftt currently operates. This installer should be safe to remove. Did we want to leave the script folder there or just remove it all together? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-24 11:40:45 +01:00

admin closed this issue

2026-01-24 11:40:45 +01:00

admin referenced this issue

2026-01-24 11:40:50 +01:00

[PR #84] Fix #63: Mbstring tests charset issue #112

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: php/pftt2#84