[PR #84] Fix #63: Mbstring tests charset issue #112

New Issue

admin · 2026-01-24T11:40:50+01:00

admin commented

2026-01-24 11:40:50 +01:00

Original Pull Request: https://github.com/php/pftt2/pull/84

State: open
Merged: No

Detecting the charset of single lines does not really work (see my
comment about that[1]), so we're dropping this attempt for now, and
instead assume an arbitrary single byte character set. This lets all
ten reported failing tests pass.

[1] https://github.com/php/pftt2/issues/63#issuecomment-553351697

If we're going this way, there is of course no need to use CharsetDeciderDecoder and related classes any longer, and we could simplify. Before investing more time in this, we should decide whether we want to do this.

@lavturo, @weltling, what do you think?

**Original Pull Request:** https://github.com/php/pftt2/pull/84 **State:** open **Merged:** No --- Detecting the charset of single lines does not really work (see my comment about that[1]), so we're dropping this attempt for now, and instead assume an arbitrary single byte character set. This lets all ten reported failing tests pass. [1] <https://github.com/php/pftt2/issues/63#issuecomment-553351697> --- If we're going this way, there is of course no need to use `CharsetDeciderDecoder` and related classes any longer, and we could simplify. Before investing more time in this, we should decide whether we want to do this. @lavturo, @weltling, what do you think?

admin added the pull-request label 2026-01-24 11:40:50 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: php/pftt2#112